net/mlx4: fix unnecessary comma compilation warnings
PATCH 1/2 net/mlx4: fix unnecessary comma compilation warnings
The patch fixes compilation warnings produced by clang -Wcomma option.
Bugzilla ID: 1810
Fixes ba576975a89b ("net/mlx4: support hardware TSO")
Signed-off-by Gregory Etelson <[email protected]>
--- drivers/net/mlx4/mlx4_rxtx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/mlx4/mlx4_rxtx.c +1 -1
@@ -638,7 +638,7 @@ mlx4_tx_burst_fill_tso_hdr(struct rte_mbuf *buf, thdr.vto = sq->buf;/* New TXBB, stash the first 32bits for later use. */ pv[*pv_counter].dst = (volatile uint32_t *)thdr.to; - pv[(*pv_counter)++].val = *(uint32_t *)from, + pv[(*pv_counter)++].val = *(uint32_t *)from; from +=sizeof (uint32_t ); thdr.to +=sizeof (uint32_t ); remain_size -= txbb_avail_space +sizeof (uint32_t );
Signature · 1 line
2.51.0
PATCH 2/2 net/mlx5: fix unnecessary comma compilation warnings
The patch fixes compilation warnings produced by clang -Wcomma option.
Bugzilla ID: 1810
Fixes 630a587bfb37 ("net/mlx5: support matching on VXLAN reserved field")
Fixes 86d259cec852 ("net/mlx5: separate Tx queue object creations")
Fixes bc1d90a3cf6f ("net/mlx5: fix build with Direct Verbs disabled")
Fixes 444320186393 ("net/mlx5: support meter creation with policy")
Fixes 821a6a5cc495 ("net/mlx5: add metadata split for compatibility")
Signed-off-by Gregory Etelson <[email protected]>
--- drivers/net/mlx5/linux/mlx5_os.c | 4 ++-- drivers/net/mlx5/linux/mlx5_verbs.c | 2 +- drivers/net/mlx5/mlx5_flow.c | 12 ++++++------ drivers/net/mlx5/mlx5_flow_dv.c | 2 +- drivers/net/mlx5/mlx5_nta_split.c | 4 ++-- 5 files changed, 12 insertions(+), 12 deletions(-)
drivers/net/mlx5/linux/mlx5_os.c +2 -2
@@ -431,8 +431,8 @@ __mlx5_discovery_misc5_cap(struct mlx5_priv *priv)DRV_LOG (INFO ,"No SW steering support" );return ; } - dv_attr.type =IBV_FLOW_ATTR_NORMAL , - dv_attr.match_mask = (void *)&matcher_mask, + dv_attr.type =IBV_FLOW_ATTR_NORMAL ; + dv_attr.match_mask = (void *)&matcher_mask; dv_attr.match_criteria_enable = (1 <<MLX5_MATCH_CRITERIA_ENABLE_OUTER_BIT ) | (1 <<MLX5_MATCH_CRITERIA_ENABLE_MISC5_BIT );
drivers/net/mlx5/linux/mlx5_verbs.c +1 -1
@@ -883,7 +883,7 @@ mlx5_txq_ibv_qp_create(struct rte_eth_dev *dev, uint16_t idx)* dev_cap.max_sge limit and will still work properly. */ qp_attr.cap.max_send_sge =1 ; - qp_attr.qp_type =IBV_QPT_RAW_PACKET , + qp_attr.qp_type =IBV_QPT_RAW_PACKET ;/* Do *NOT* enable this, completions events are managed per Tx burst. */ qp_attr.sq_sig_all =0 ; qp_attr.pd = priv->sh->cdev->pd;
drivers/net/mlx5/mlx5_flow.c +6 -6
@@ -11132,12 +11132,12 @@ flow_tunnel_add_default_miss(struct rte_eth_dev *dev, (error,ENOMEM ,RTE_FLOW_ERROR_TYPE_ACTION_CONF ,NULL ,"invalid default miss RSS" ); - ctx->action_rss.func =RTE_ETH_HASH_FUNCTION_DEFAULT , - ctx->action_rss.level =0 , - ctx->action_rss.types = priv->rss_conf.rss_hf, - ctx->action_rss.key_len = priv->rss_conf.rss_key_len, - ctx->action_rss.queue_num = priv->reta_idx_n, - ctx->action_rss.key = priv->rss_conf.rss_key, + ctx->action_rss.func =RTE_ETH_HASH_FUNCTION_DEFAULT ; + ctx->action_rss.level =0 ; + ctx->action_rss.types = priv->rss_conf.rss_hf; + ctx->action_rss.key_len = priv->rss_conf.rss_key_len; + ctx->action_rss.queue_num = priv->reta_idx_n; + ctx->action_rss.key = priv->rss_conf.rss_key; ctx->action_rss.queue = ctx->queue;if (!priv->reta_idx_n || !priv->rxqs_n)return rte_flow_error_set
drivers/net/mlx5/mlx5_flow_dv.c +1 -1
@@ -18903,7 +18903,7 @@ flow_dv_create_mtr_tbls(struct rte_eth_dev *dev, } }/* Create default matcher in drop table. */ - matcher.tbl = mtrmng->drop_tbl[domain], + matcher.tbl = mtrmng->drop_tbl[domain]; tbl_data =container_of (mtrmng->drop_tbl[domain], struct mlx5_flow_tbl_data_entry, tbl);if (!mtrmng->def_matcher[domain]) {
drivers/net/mlx5/mlx5_nta_split.c +2 -2
@@ -345,8 +345,8 @@ flow_nta_mreg_create_cb(void *tool_ctx, void *cb_ctx)/* (match REG 'tag') or all. */ items[1 ].type =RTE_FLOW_ITEM_TYPE_END ;/* (Mark) or void + copy to Rx meta + jump to the MREG_ACT_TABLE_GROUP. */ - actions[1 ].type =RTE_FLOW_ACTION_TYPE_MODIFY_FIELD , - actions[1 ].conf = &rx_meta, + actions[1 ].type =RTE_FLOW_ACTION_TYPE_MODIFY_FIELD ; + actions[1 ].conf = &rx_meta; actions[2 ].type =RTE_FLOW_ACTION_TYPE_JUMP ; actions[2 ].conf = &jump; actions[3 ].type =RTE_FLOW_ACTION_TYPE_END ;
Signature · 1 line
2.51.0
Re: [PATCH 2/2] net/mlx5: fix unnecessary comma compilation warnings
Quoted 11 lines · Gregory Etelson
The patch fixes compilation warnings produced by clang -Wcomma option.
Bugzilla ID: 1810
Fixes 630a587bfb37 ("net/mlx5: support matching on VXLAN reserved field")Fixes 86d259cec852 ("net/mlx5: separate Tx queue object creations")Fixes bc1d90a3cf6f ("net/mlx5: fix build with Direct Verbs disabled")Fixes 444320186393 ("net/mlx5: support meter creation with policy")Fixes 821a6a5cc495 ("net/mlx5: add metadata split for compatibility")Signed-off-by Gregory Etelson <[email protected]>
Quoted 7 lines · Gregory Etelson
The patch fixes compilation warnings produced by clang -Wcomma option.
Bugzilla ID: 1810
Fixes ba576975a89b ("net/mlx4: support hardware TSO")Signed-off-by Gregory Etelson <[email protected]>
Hi
Quoted 7 lines · Gregory Etelson
The patch fixes compilation warnings produced by clang -Wcomma option.
Bugzilla ID: 1810
Fixes ba576975a89b ("net/mlx4: support hardware TSO")Signed-off-by Gregory Etelson <[email protected]>
Series applied to next-net-mlx,
Kindest regards
Raslan Darawsheh