Skip to contentSkip to conversation

MIPS: Alchemy: Remove bogus static/inline specifiers

PATCH Applied Thierry Reding 3 participants 6 messages Oct 29, 2025 – Dec 15, 2025 MIPS

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 MIPS: Alchemy: Remove bogus static/inline specifiers

From: Thierry Reding <[email protected]>

The recent io_remap_pfn_range() rework applied the static and inline specifiers to the implementation of io_remap_pfn_range_pfn() on MIPS Alchemy, mirroring the same change on other platforms. However, this function is defined in a source file and that definition causes a conflict with its declaration. Fix this by dropping the specifiers.

Fixes 8efb51ad1b05 ("mm: abstract io_remap_pfn_range() based on PFN")
---
 arch/mips/alchemy/common/setup.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
arch/mips/alchemy/common/setup.c +1 -2
index c35b4f809d51..992134a8c23a 100644
@@ -94,8 +94,7 @@ phys_addr_t fixup_bigphys_addr(phys_addr_t phys_addr, phys_addr_t size)
 	return phys_addr;
 }
 
-static inline unsigned long io_remap_pfn_range_pfn(unsigned long pfn,
-		unsigned long size)
+unsigned long io_remap_pfn_range_pfn(unsigned long pfn, unsigned long size)
 {
 	phys_addr_t phys_addr = fixup_bigphys_addr(pfn << PAGE_SHIFT, size);
 
Signature · 1 line
2.51.0
maintainer Acked-by on v1 1/1
#1 lore raw
Quoted 9 lines · Thierry Reding

From: Thierry Reding <[email protected]>

The recent io_remap_pfn_range() rework applied the static and inline specifiers to the implementation of io_remap_pfn_range_pfn() on MIPS Alchemy, mirroring the same change on other platforms. However, this function is defined in a source file and that definition causes a conflict with its declaration. Fix this by dropping the specifiers.

Fixes 8efb51ad1b05 ("mm: abstract io_remap_pfn_range() based on PFN")

I guess this patch should be applied to the tree, where this commit is in.

Quoted 1 line
Signature · 2 lines
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea.                                                [ RFC1925, 2.3 ]
Tested-by Reviewed-by on v1 1/1
#2 lore raw
In reply to Thierry Reding
Quoted 10 lines · Thierry Reding

From: Thierry Reding <[email protected]>

The recent io_remap_pfn_range() rework applied the static and inline specifiers to the implementation of io_remap_pfn_range_pfn() on MIPS Alchemy, mirroring the same change on other platforms. However, this function is defined in a source file and that definition causes a conflict with its declaration. Fix this by dropping the specifiers.

Fixes 8efb51ad1b05 ("mm: abstract io_remap_pfn_range() based on PFN")

Thanks!

Thomas, can you pick this up so we have working alchemy builds again? Thanks!

Signature · 1 line
Florian
#3 lore raw
Quoted 12 lines · Florian Fainelli
Quoted 10 lines · Thierry Reding

From: Thierry Reding <[email protected]>

The recent io_remap_pfn_range() rework applied the static and inline specifiers to the implementation of io_remap_pfn_range_pfn() on MIPS Alchemy, mirroring the same change on other platforms. However, this function is defined in a source file and that definition causes a conflict with its declaration. Fix this by dropping the specifiers.

Fixes 8efb51ad1b05 ("mm: abstract io_remap_pfn_range() based on PFN")
Quoted 6 lines

Thanks!

Thomas, can you pick this up so we have working alchemy builds again?

well, I've acked the patch for inclusion in the tree where the broken commit was applied, but I could take it.

I'll correct the Fixes tag to

Fixes c707a68f9468 ("mm: abstract io_remap_pfn_range() based on PFN")

when applying.

Thomas.

Signature · 2 lines
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea.                                                [ RFC1925, 2.3 ]
#4 lore raw
Quoted 16 lines · Thomas Bogendoerfer
Quoted 15 lines · Florian Fainelli
Quoted 10 lines · Thierry Reding

From: Thierry Reding <[email protected]>

The recent io_remap_pfn_range() rework applied the static and inline specifiers to the implementation of io_remap_pfn_range_pfn() on MIPS Alchemy, mirroring the same change on other platforms. However, this function is defined in a source file and that definition causes a conflict with its declaration. Fix this by dropping the specifiers.

Fixes 8efb51ad1b05 ("mm: abstract io_remap_pfn_range() based on PFN")
Quoted 6 lines
Quoted 3 lines

Thanks!

Thomas, can you pick this up so we have working alchemy builds again?

well, I've acked the patch for inclusion in the tree where the broken commit was applied, but I could take it.

but this has to wait until -rc1, since the breaking commit is not in my mips-next branch, yet (and mergign current upstream is not an option there).

Thomas.

Signature · 2 lines
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea.                                                [ RFC1925, 2.3 ]
maintainer Applied
#5 lore raw
In reply to Thierry Reding
Quoted 30 lines · Thierry Reding

From: Thierry Reding <[email protected]>

The recent io_remap_pfn_range() rework applied the static and inline specifiers to the implementation of io_remap_pfn_range_pfn() on MIPS Alchemy, mirroring the same change on other platforms. However, this function is defined in a source file and that definition causes a conflict with its declaration. Fix this by dropping the specifiers.

Fixes 8efb51ad1b05 ("mm: abstract io_remap_pfn_range() based on PFN")
---
 arch/mips/alchemy/common/setup.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
arch/mips/alchemy/common/setup.c +1 -2
index c35b4f809d51..992134a8c23a 100644
@@ -94,8 +94,7 @@ phys_addr_t fixup_bigphys_addr(phys_addr_t phys_addr, phys_addr_t size)
 	return phys_addr;
 }
 
-static inline unsigned long io_remap_pfn_range_pfn(unsigned long pfn,
-		unsigned long size)
+unsigned long io_remap_pfn_range_pfn(unsigned long pfn, unsigned long size)
 {
 	phys_addr_t phys_addr = fixup_bigphys_addr(pfn << PAGE_SHIFT, size);
 
Signature · 1 line
2.51.0

applied to mips-fixes.

Thomas.

Signature · 2 lines
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea.                                                [ RFC1925, 2.3 ]