Skip to contentSkip to conversation

crypto: deflate - Use struct_size to improve deflate_alloc_stream

PATCH In review Thorsten Blum 2 participants 2 messages Oct 30, 2025 – Nov 6, 2025 Crypto API

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 crypto: deflate - Use struct_size to improve deflate_alloc_stream

Use struct_size(), which provides additional compile-time checks for structures with flexible array members (e.g., __must_be_array()), to calculate the allocation size for a new 'deflate_stream'.

---
 crypto/deflate.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
crypto/deflate.c +2 -1
index 21404515dc77..a3e1fff55661 100644
@@ -15,6 +15,7 @@
 #include <linux/kernel.h>
 #include <linux/module.h>
 #include <linux/mutex.h>
+#include <linux/overflow.h>
 #include <linux/percpu.h>
 #include <linux/scatterlist.h>
 #include <linux/slab.h>
@@ -39,7 +40,7 @@ static void *deflate_alloc_stream(void)
 						     DEFLATE_DEF_MEMLEVEL));
 	struct deflate_stream *ctx;
 
-	ctx = kvmalloc(sizeof(*ctx) + size, GFP_KERNEL);
+	ctx = kvmalloc(struct_size(ctx, workspace, size), GFP_KERNEL);
 	if (!ctx)
 		return ERR_PTR(-ENOMEM);
 
Signature · 1 line
2.51.0
maintainer
#1 lore raw
Quoted 8 lines · Thorsten Blum

Use struct_size(), which provides additional compile-time checks for structures with flexible array members (e.g., __must_be_array()), to calculate the allocation size for a new 'deflate_stream'.

---
 crypto/deflate.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Patch appiled. Thanks.

Signature · 3 lines
Email: Herbert Xu <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt