Pagefault refactor
Subsystems (2)
Matthew Brost
maintainerv4 cover Pagefault refactor
We likely need multiple page fault producers feeding into a common consumer backend. Additionally, our current page fault work queue design—being per-GT rather than per-device—makes little sense. Clean up pagefault handling with clear layers.
Matt
Matthew Brost (7):
drm/xe: Stub out new pagefault layer
drm/xe: Implement xe_pagefault_init
drm/xe: Implement xe_pagefault_reset
drm/xe: Implement xe_pagefault_handler
drm/xe: Implement xe_pagefault_queue_work
drm/xe: Add xe_guc_pagefault layer
drm/xe: Remove unused GT page fault code
drivers/gpu/drm/xe/Makefile | 3 +- drivers/gpu/drm/xe/xe_device.c | 5 + drivers/gpu/drm/xe/xe_device_types.h | 11 + drivers/gpu/drm/xe/xe_gt.c | 8 +- drivers/gpu/drm/xe/xe_gt_pagefault.c | 679 ------------------------ drivers/gpu/drm/xe/xe_gt_pagefault.h | 19 - drivers/gpu/drm/xe/xe_gt_types.h | 65 --- drivers/gpu/drm/xe/xe_guc_ct.c | 6 +- drivers/gpu/drm/xe/xe_guc_pagefault.c | 95 ++++ drivers/gpu/drm/xe/xe_guc_pagefault.h | 15 + drivers/gpu/drm/xe/xe_pagefault.c | 440 +++++++++++++++ drivers/gpu/drm/xe/xe_pagefault.h | 19 + drivers/gpu/drm/xe/xe_pagefault_types.h | 136 +++++ drivers/gpu/drm/xe/xe_svm.c | 3 +- drivers/gpu/drm/xe/xe_vm.c | 1 - 15 files changed, 727 insertions(+), 778 deletions(-) delete mode 100644 drivers/gpu/drm/xe/xe_gt_pagefault.c delete mode 100644 drivers/gpu/drm/xe/xe_gt_pagefault.h create mode 100644 drivers/gpu/drm/xe/xe_guc_pagefault.c create mode 100644 drivers/gpu/drm/xe/xe_guc_pagefault.h create mode 100644 drivers/gpu/drm/xe/xe_pagefault.c create mode 100644 drivers/gpu/drm/xe/xe_pagefault.h create mode 100644 drivers/gpu/drm/xe/xe_pagefault_types.h
Signature · 1 line
2.34.1
Matthew Brost
maintainerPATCH v4 1/7 drm/xe: Stub out new pagefault layer
Stub out the new page fault layer and add kernel documentation. This is intended as a replacement for the GT page fault layer, enabling multiple producers to hook into a shared page fault consumer interface.
v2:
- Fix kernel doc typo (checkpatch)
- Remove comment around GT (Stuart)
- Add explaination around reclaim (Francois)
- Add comment around u8 vs enum (Francois)
- Include engine instance (Stuart)
v3:
- Fix XE_PAGEFAULT_TYPE_ATOMIC_ACCESS_VIOLATION kernel doc (Stuart)
--- drivers/gpu/drm/xe/Makefile | 1 + drivers/gpu/drm/xe/xe_pagefault.c | 65 +++++++++++ drivers/gpu/drm/xe/xe_pagefault.h | 19 ++++ drivers/gpu/drm/xe/xe_pagefault_types.h | 136 ++++++++++++++++++++++++ 4 files changed, 221 insertions(+) create mode 100644 drivers/gpu/drm/xe/xe_pagefault.c create mode 100644 drivers/gpu/drm/xe/xe_pagefault.h create mode 100644 drivers/gpu/drm/xe/xe_pagefault_types.h
drivers/gpu/drm/xe/Makefile +1 -0
@@ -94,6 +94,7 @@ xe-y += xe_bb.o \ xe_nvm.o \ xe_oa.o \ xe_observation.o \ + xe_pagefault.o \ xe_pat.o \ xe_pci.o \ xe_pcode.o \
drivers/gpu/drm/xe/xe_pagefault.c new file +65 -0
65 lines not on this page · raw message
drivers/gpu/drm/xe/xe_pagefault.h new file +19 -0
@@ -0,0 +1,19 @@ +/* SPDX-License-Identifier: MIT */ +/* +* Copyright © 2025 Intel Corporation +*/ + +#ifndef _XE_PAGEFAULT_H_ +#define _XE_PAGEFAULT_H_ + +struct xe_device ; +struct xe_gt ; +struct xe_pagefault ; + +int xe_pagefault_init (struct xe_device *xe); + +void xe_pagefault_reset (struct xe_device *xe,struct xe_gt *gt); + +int xe_pagefault_handler (struct xe_device *xe,struct xe_pagefault *pf); + +#endif
drivers/gpu/drm/xe/xe_pagefault_types.h new file +136 -0
136 lines not on this page · raw message
Signature · 1 line
2.34.1
Re: [PATCH v4 1/7] drm/xe: Stub out new pagefault layer
Quoted 13 lines · Matthew Brost
Stub out the new page fault layer and add kernel documentation. This is intended as a replacement for the GT page fault layer, enabling multiple producers to hook into a shared page fault consumer interface.
v2:
- Fix kernel doc typo (checkpatch)
- Remove comment around GT (Stuart)
- Add explaination around reclaim (Francois)
- Add comment around u8 vs enum (Francois)
- Include engine instance (Stuart)
v3:
- FixXE_PAGEFAULT_TYPE_ATOMIC_ACCESS_VIOLATIONkernel doc (Stuart)
Quoted 1 line
Signed-off-by Matthew Brost <[email protected]>
Lucas De Marchi
Matthew Brost
maintainerPATCH v4 2/7 drm/xe: Implement xe_pagefault_init
In reply to Matthew BrostCreate pagefault queues and initialize them.
v2:
- Fix kernel doc + add comment for number PF queue (Francois)
v4:
- Move init after GT init (CI, Francois)
--- drivers/gpu/drm/xe/xe_device.c | 5 ++ drivers/gpu/drm/xe/xe_device_types.h | 11 ++++ drivers/gpu/drm/xe/xe_pagefault.c | 93 +++++++++++++++++++++++++++- 3 files changed, 107 insertions(+), 2 deletions(-)
drivers/gpu/drm/xe/xe_device.c +5 -0
@@ -52,6 +52,7 @@#include "xe_nvm.h" #include "xe_oa.h" #include "xe_observation.h" +#include "xe_pagefault.h" #include "xe_pat.h" #include "xe_pcode.h" #include "xe_pm.h"
@@ -896,6 +897,10 @@ int xe_device_probe(struct xe_device *xe)return err; } + err =xe_pagefault_init (xe); +if (err) +return err; +if (xe->tiles->media_gt && XE_GT_WA(xe->tiles->media_gt, 15015404425_disable))XE_DEVICE_WA_DISABLE (xe,15015404425 );
drivers/gpu/drm/xe/xe_device_types.h +11 -0
@@ -18,6 +18,7 @@#include "xe_lmtt_types.h" #include "xe_memirq_types.h" #include "xe_oa_types.h" +#include "xe_pagefault_types.h" #include "xe_platform_types.h" #include "xe_pmu_types.h" #include "xe_pt_types.h"
@@ -418,6 +419,16 @@ struct xe_device {u32 next_asid;/** @usm.lock: protects UM state */ struct rw_semaphore lock; +/** @usm.pf_wq: page fault work queue, unbound, high priority */ +struct workqueue_struct *pf_wq; +/* +* We pick 4 here because, in the current implementation, it +* yields the best bandwidth utilization of the kernel paging +* engine. +*/ +#define XE_PAGEFAULT_QUEUE_COUNT 4 +/** @usm.pf_queue: Page fault queues */ +struct xe_pagefault_queue pf_queue[XE_PAGEFAULT_QUEUE_COUNT ]; } usm;/** @pinned: pinned BO state */
drivers/gpu/drm/xe/xe_pagefault.c +91 -2
111 lines not on this page · raw message
Signature · 1 line
2.34.1
Re: [PATCH v4 2/7] drm/xe: Implement xe_pagefault_init
Quoted 82 lines · Matthew Brost
Create pagefault queues and initialize them.
v2:
- Fix kernel doc + add comment for number PF queue (Francois)
v4:
- Move init after GT init (CI, Francois)Signed-off-by Matthew Brost <[email protected]>--- drivers/gpu/drm/xe/xe_device.c | 5 ++ drivers/gpu/drm/xe/xe_device_types.h | 11 ++++ drivers/gpu/drm/xe/xe_pagefault.c | 93 +++++++++++++++++++++++++++- 3 files changed, 107 insertions(+), 2 deletions(-)drivers/gpu/drm/xe/xe_device.c +5
-0@@ -52,6 +52,7 @@#include "xe_nvm.h" #include "xe_oa.h" #include "xe_observation.h" +#include "xe_pagefault.h" #include "xe_pat.h" #include "xe_pcode.h" #include "xe_pm.h" @@ -896,6 +897,10 @@ int xe_device_probe(struct xe_device *xe)return err; } + err =xe_pagefault_init (xe); +if (err) +return err; +if (xe->tiles->media_gt && XE_GT_WA(xe->tiles->media_gt, 15015404425_disable))XE_DEVICE_WA_DISABLE (xe,15015404425 );drivers/gpu/drm/xe/xe_device_types.h +11
-0@@ -18,6 +18,7 @@#include "xe_lmtt_types.h" #include "xe_memirq_types.h" #include "xe_oa_types.h" +#include "xe_pagefault_types.h" #include "xe_platform_types.h" #include "xe_pmu_types.h" #include "xe_pt_types.h" @@ -418,6 +419,16 @@ struct xe_device {u32 next_asid;/** @usm.lock: protects UM state */ struct rw_semaphore lock; +/** @usm.pf_wq: page fault work queue, unbound, high priority */ +struct workqueue_struct *pf_wq; +/* +* We pick 4 here because, in the current implementation, it +* yields the best bandwidth utilization of the kernel paging +* engine. +*/ +#define XE_PAGEFAULT_QUEUE_COUNT 4 +/** @usm.pf_queue: Page fault queues */ +struct xe_pagefault_queue pf_queue[XE_PAGEFAULT_QUEUE_COUNT ]; } usm;/** @pinned: pinned BO state */ drivers/gpu/drm/xe/xe_pagefault.c +4
-0@@ -3,6 +3,10 @@* Copyright © 2025 Intel Corporation */ +#include <drm/drm_managed.h> + +#include "xe_device.h" +#include "xe_gt_types.h" #include "xe_pagefault.h" #include "xe_pagefault_types.h"
drivers/gpu/drm/xe/xe_pagefault.c line 30
Quoted 6 lines
drivers/gpu/drm/xe/xe_pagefault.c +3
-0@@ -21,6 +25,71 @@* xe_pagefault.c implements the consumer layer. */ +static int xe_pagefault_entry_size (void ) +{ +return roundup_pow_of_two (sizeof (struct xe_pagefault ));
It seems this is missing:
https://patchwork.freedesktop.org/patch/667318/?series=152565&rev=1#comment_1230914
With that:
Quoted 99 lines
drivers/gpu/drm/xe/xe_pagefault.c +84
-2+} + +static void xe_pagefault_queue_work (struct work_struct *w) +{ +/* TODO: Implement */ +} + +static int xe_pagefault_queue_init (struct xe_device *xe, +struct xe_pagefault_queue *pf_queue) +{ +struct xe_gt *gt; +int total_num_eus =0 ; +u8 id; + +for_each_gt (gt, xe, id) { +xe_dss_mask_t all_dss; +int num_dss, num_eus; + +bitmap_or (all_dss, gt->fuse_topo.g_dss_mask, + gt->fuse_topo.c_dss_mask,XE_MAX_DSS_FUSE_BITS ); + + num_dss =bitmap_weight (all_dss,XE_MAX_DSS_FUSE_BITS ); + num_eus =bitmap_weight (gt->fuse_topo.eu_mask_per_dss, +XE_MAX_EU_FUSE_BITS ) * num_dss; + + total_num_eus += num_eus; + } + +xe_assert (xe, total_num_eus); + +/* +* user can issue separate page faults per EU and per CS +* +* XXX: Multiplier required as compute UMD are getting PF queue errors +* without it. Follow on why this multiplier is required. +*/ +#define PF_MULTIPLIER 8 + pf_queue->size = (total_num_eus +XE_NUM_HW_ENGINES ) * +xe_pagefault_entry_size () *PF_MULTIPLIER ; + pf_queue->size =roundup_pow_of_two (pf_queue->size); +#undef PF_MULTIPLIER + +drm_dbg (&xe->drm,"xe_pagefault_entry_size=%d, total_num_eus=%d, pf_queue->size=%u" , +xe_pagefault_entry_size (), total_num_eus, pf_queue->size); + +spin_lock_init (&pf_queue->lock); +INIT_WORK (&pf_queue->worker, xe_pagefault_queue_work); + + pf_queue->data =drmm_kzalloc (&xe->drm, pf_queue->size,GFP_KERNEL ); +if (!pf_queue->data) +return -ENOMEM ; + +return 0 ; +} + +static void xe_pagefault_fini (void *arg) +{ +struct xe_device *xe = arg; + +destroy_workqueue (xe->usm.pf_wq); +} +/** * xe_pagefault_init() - Page fault init * @xe: xe device instance @@ -31,8 +100,28 @@*/ int xe_pagefault_init (struct xe_device *xe) { -/* TODO - implement */ -return 0 ; +int err, i; + +if (!xe->info.has_usm) +return 0 ; + + xe->usm.pf_wq =alloc_workqueue ("xe_page_fault_work_queue" , +WQ_UNBOUND |WQ_HIGHPRI , +XE_PAGEFAULT_QUEUE_COUNT ); +if (!xe->usm.pf_wq) +return -ENOMEM ; + +for (i =0 ; i <XE_PAGEFAULT_QUEUE_COUNT ; ++i) { + err =xe_pagefault_queue_init (xe, xe->usm.pf_queue + i); +if (err) + goto err_out; + } + +return devm_add_action_or_reset (xe->drm.dev, xe_pagefault_fini, xe); + +err_out: +destroy_workqueue (xe->usm.pf_wq); +return err; }/** Signature · 1 line
2.34.1
Matthew Brost
maintainerRe: [PATCH v4 2/7] drm/xe: Implement xe_pagefault_init
Quoted 86 lines · Francois Dugast
Quoted 85 lines · Matthew Brost
Create pagefault queues and initialize them.
v2:
- Fix kernel doc + add comment for number PF queue (Francois)
v4:
- Move init after GT init (CI, Francois)Signed-off-by Matthew Brost <[email protected]>--- drivers/gpu/drm/xe/xe_device.c | 5 ++ drivers/gpu/drm/xe/xe_device_types.h | 11 ++++ drivers/gpu/drm/xe/xe_pagefault.c | 93 +++++++++++++++++++++++++++- 3 files changed, 107 insertions(+), 2 deletions(-)drivers/gpu/drm/xe/xe_device.c +5
-0@@ -52,6 +52,7 @@#include "xe_nvm.h" #include "xe_oa.h" #include "xe_observation.h" +#include "xe_pagefault.h" #include "xe_pat.h" #include "xe_pcode.h" #include "xe_pm.h" @@ -896,6 +897,10 @@ int xe_device_probe(struct xe_device *xe)return err; } + err =xe_pagefault_init (xe); +if (err) +return err; +if (xe->tiles->media_gt && XE_GT_WA(xe->tiles->media_gt, 15015404425_disable))XE_DEVICE_WA_DISABLE (xe,15015404425 );drivers/gpu/drm/xe/xe_device_types.h +11
-0@@ -18,6 +18,7 @@#include "xe_lmtt_types.h" #include "xe_memirq_types.h" #include "xe_oa_types.h" +#include "xe_pagefault_types.h" #include "xe_platform_types.h" #include "xe_pmu_types.h" #include "xe_pt_types.h" @@ -418,6 +419,16 @@ struct xe_device {u32 next_asid;/** @usm.lock: protects UM state */ struct rw_semaphore lock; +/** @usm.pf_wq: page fault work queue, unbound, high priority */ +struct workqueue_struct *pf_wq; +/* +* We pick 4 here because, in the current implementation, it +* yields the best bandwidth utilization of the kernel paging +* engine. +*/ +#define XE_PAGEFAULT_QUEUE_COUNT 4 +/** @usm.pf_queue: Page fault queues */ +struct xe_pagefault_queue pf_queue[XE_PAGEFAULT_QUEUE_COUNT ]; } usm;/** @pinned: pinned BO state */ drivers/gpu/drm/xe/xe_pagefault.c +4
-0@@ -3,6 +3,10 @@* Copyright © 2025 Intel Corporation */ +#include <drm/drm_managed.h> + +#include "xe_device.h" +#include "xe_gt_types.h" #include "xe_pagefault.h" #include "xe_pagefault_types.h" @@ -21,6 +25,71 @@* xe_pagefault.c implements the consumer layer. */
Quoted 7 lines
drivers/gpu/drm/xe/xe_pagefault.c line 30
Quoted 3 lines
drivers/gpu/drm/xe/xe_pagefault.c +3
-0+static int xe_pagefault_entry_size (void ) +{ +return roundup_pow_of_two (sizeof (struct xe_pagefault ));It seems this is missing:
https://patchwork.freedesktop.org/patch/667318/?series=152565&rev=1#comment_1230914
Ah, yes. Will add:
/*
* Power of two alignment is not a hardware requirement, rather a
* software restriction which makes the math for page fault queue
* management simplier.
*/
Quoted 2 lines
With that:
Reviewed-by Francois Dugast <[email protected]>
Thanks - Matt
Quoted 100 lines
Quoted 100 lines
drivers/gpu/drm/xe/xe_pagefault.c +84
-2+} + +static void xe_pagefault_queue_work (struct work_struct *w) +{ +/* TODO: Implement */ +} + +static int xe_pagefault_queue_init (struct xe_device *xe, +struct xe_pagefault_queue *pf_queue) +{ +struct xe_gt *gt; +int total_num_eus =0 ; +u8 id; + +for_each_gt (gt, xe, id) { +xe_dss_mask_t all_dss; +int num_dss, num_eus; + +bitmap_or (all_dss, gt->fuse_topo.g_dss_mask, + gt->fuse_topo.c_dss_mask,XE_MAX_DSS_FUSE_BITS ); + + num_dss =bitmap_weight (all_dss,XE_MAX_DSS_FUSE_BITS ); + num_eus =bitmap_weight (gt->fuse_topo.eu_mask_per_dss, +XE_MAX_EU_FUSE_BITS ) * num_dss; + + total_num_eus += num_eus; + } + +xe_assert (xe, total_num_eus); + +/* +* user can issue separate page faults per EU and per CS +* +* XXX: Multiplier required as compute UMD are getting PF queue errors +* without it. Follow on why this multiplier is required. +*/ +#define PF_MULTIPLIER 8 + pf_queue->size = (total_num_eus +XE_NUM_HW_ENGINES ) * +xe_pagefault_entry_size () *PF_MULTIPLIER ; + pf_queue->size =roundup_pow_of_two (pf_queue->size); +#undef PF_MULTIPLIER + +drm_dbg (&xe->drm,"xe_pagefault_entry_size=%d, total_num_eus=%d, pf_queue->size=%u" , +xe_pagefault_entry_size (), total_num_eus, pf_queue->size); + +spin_lock_init (&pf_queue->lock); +INIT_WORK (&pf_queue->worker, xe_pagefault_queue_work); + + pf_queue->data =drmm_kzalloc (&xe->drm, pf_queue->size,GFP_KERNEL ); +if (!pf_queue->data) +return -ENOMEM ; + +return 0 ; +} + +static void xe_pagefault_fini (void *arg) +{ +struct xe_device *xe = arg; + +destroy_workqueue (xe->usm.pf_wq); +} +/** * xe_pagefault_init() - Page fault init * @xe: xe device instance @@ -31,8 +100,28 @@*/ int xe_pagefault_init (struct xe_device *xe) { -/* TODO - implement */ -return 0 ; +int err, i; + +if (!xe->info.has_usm) +return 0 ; + + xe->usm.pf_wq =alloc_workqueue ("xe_page_fault_work_queue" , +WQ_UNBOUND |WQ_HIGHPRI , +XE_PAGEFAULT_QUEUE_COUNT ); +if (!xe->usm.pf_wq) +return -ENOMEM ; + +for (i =0 ; i <XE_PAGEFAULT_QUEUE_COUNT ; ++i) { + err =xe_pagefault_queue_init (xe, xe->usm.pf_queue + i); +if (err) + goto err_out; + } + +return devm_add_action_or_reset (xe->drm.dev, xe_pagefault_fini, xe); + +err_out: +destroy_workqueue (xe->usm.pf_wq); +return err; }/** Signature · 1 line
2.34.1
Matthew Brost
maintainerPATCH v4 3/7 drm/xe: Implement xe_pagefault_reset
In reply to Matthew BrostSquash any pending faults on the GT being reset by setting the GT field in struct xe_pagefault to NULL.
v4:
- Only do reset it page faults queues initialized (CI)
--- drivers/gpu/drm/xe/xe_gt.c | 2 ++ drivers/gpu/drm/xe/xe_pagefault.c | 27 ++++++++++++++++++++++++++- 2 files changed, 28 insertions(+), 1 deletion(-)
drivers/gpu/drm/xe/xe_gt.c +2 -0
@@ -49,6 +49,7 @@#include "xe_map.h" #include "xe_migrate.h" #include "xe_mmio.h" +#include "xe_pagefault.h" #include "xe_pat.h" #include "xe_pm.h" #include "xe_mocs.h"
@@ -849,6 +850,7 @@ static int gt_reset(struct xe_gt *gt)xe_uc_gucrc_disable (>->uc);xe_uc_stop_prepare (>->uc); +xe_pagefault_reset (gt_to_xe (gt), gt);xe_gt_pagefault_reset (gt);xe_uc_stop (>->uc);
drivers/gpu/drm/xe/xe_pagefault.c +26 -1
@@ -124,6 +124,28 @@ int xe_pagefault_init(struct xe_device *xe)return err; } +static void xe_pagefault_queue_reset (struct xe_device *xe,struct xe_gt *gt, +struct xe_pagefault_queue *pf_queue) +{ +u32 i; + +/* Driver load failure guard / USM not enabled guard */ +if (!pf_queue->data) +return ; + +/* Squash all pending faults on the GT */ + +spin_lock_irq (&pf_queue->lock); +for (i = pf_queue->tail; i != pf_queue->head; + i = (i +xe_pagefault_entry_size ()) % pf_queue->size) { +struct xe_pagefault *pf = pf_queue->data + i; + +if (pf->gt == gt) + pf->gt =NULL ; + } +spin_unlock_irq (&pf_queue->lock); +} +/** * xe_pagefault_reset() - Page fault reset for a GT * @xe: xe device instance
@@ -134,7 +156,10 @@ int xe_pagefault_init(struct xe_device *xe)*/ void xe_pagefault_reset (struct xe_device *xe,struct xe_gt *gt) { -/* TODO - implement */ +int i; + +for (i =0 ; i <XE_PAGEFAULT_QUEUE_COUNT ; ++i) +xe_pagefault_queue_reset (xe, gt, xe->usm.pf_queue + i); }/**
Signature · 1 line
2.34.1
Re: [PATCH v4 3/7] drm/xe: Implement xe_pagefault_reset
Quoted 7 lines · Matthew Brost
Squash any pending faults on the GT being reset by setting the GT field in struct
xe_pagefaultto NULL.v4:
- Only do reset it page faults queues initialized (CI)Signed-off-by Matthew Brost <[email protected]>
Lucas De Marchi
Matthew Brost
maintainerPATCH v4 4/7 drm/xe: Implement xe_pagefault_handler
In reply to Matthew BrostEnqueue (copy) the input struct xe_pagefault into a queue (i.e., into a memory buffer) and schedule a worker to service it.
--- drivers/gpu/drm/xe/xe_pagefault.c | 32 +++++++++++++++++++++++++++++-- 1 file changed, 30 insertions(+), 2 deletions(-)
drivers/gpu/drm/xe/xe_pagefault.c +30 -2
@@ -3,6 +3,8 @@* Copyright © 2025 Intel Corporation */ +#include <linux/circ_buf.h> +#include <drm/drm_managed.h> #include "xe_device.h"
@@ -162,6 +164,14 @@ void xe_pagefault_reset(struct xe_device *xe, struct xe_gt *gt)xe_pagefault_queue_reset (xe, gt, xe->usm.pf_queue + i); } +static bool xe_pagefault_queue_full (struct xe_pagefault_queue *pf_queue) +{ +lockdep_assert_held (&pf_queue->lock); + +return CIRC_SPACE (pf_queue->head, pf_queue->tail, pf_queue->size) <= +xe_pagefault_entry_size (); +} +/** * xe_pagefault_handler() - Page fault handler * @xe: xe device instance
@@ -174,6 +184,24 @@ void xe_pagefault_reset(struct xe_device *xe, struct xe_gt *gt)*/ int xe_pagefault_handler (struct xe_device *xe,struct xe_pagefault *pf) { -/* TODO - implement */ -return 0 ; +struct xe_pagefault_queue *pf_queue = xe->usm.pf_queue + + (pf->consumer.asid %XE_PAGEFAULT_QUEUE_COUNT ); +unsigned long flags; +bool full; + +spin_lock_irqsave (&pf_queue->lock, flags); + full =xe_pagefault_queue_full (pf_queue); +if (!full) { +memcpy (pf_queue->data + pf_queue->head, pf,sizeof (*pf)); + pf_queue->head = (pf_queue->head +xe_pagefault_entry_size ()) % + pf_queue->size; +queue_work (xe->usm.pf_wq, &pf_queue->worker); + }else { +drm_warn (&xe->drm, +"PageFault Queue (%d) full, shouldn't be possible\n" , + pf->consumer.asid %XE_PAGEFAULT_QUEUE_COUNT ); + } +spin_unlock_irqrestore (&pf_queue->lock, flags); + +return full ? -ENOSPC :0 ; }
Signature · 1 line
2.34.1
Matthew Brost
maintainerPATCH v4 5/7 drm/xe: Implement xe_pagefault_queue_work
In reply to Matthew BrostImplement a worker that services page faults, using the same implementation as in xe_gt_pagefault.c.
v2:
- Rebase on exhaustive eviction changes
- Include engine instance in debug prints (Stuart)
--- drivers/gpu/drm/xe/xe_pagefault.c | 235 +++++++++++++++++++++++++++++- 1 file changed, 234 insertions(+), 1 deletion(-)
drivers/gpu/drm/xe/xe_pagefault.c +234 -1
@@ -5,12 +5,20 @@#include <linux/circ_buf.h> +#include <drm/drm_exec.h> #include <drm/drm_managed.h> +#include "xe_bo.h" #include "xe_device.h" +#include "xe_gt_printk.h" #include "xe_gt_types.h" +#include "xe_gt_stats.h" +#include "xe_hw_engine.h" #include "xe_pagefault.h" #include "xe_pagefault_types.h" +#include "xe_svm.h" +#include "xe_trace_bo.h" +#include "xe_vm.h" /** * DOC: Xe page faults
@@ -32,9 +40,234 @@ static int xe_pagefault_entry_size(void)return roundup_pow_of_two (sizeof (struct xe_pagefault )); } +static int xe_pagefault_begin (struct drm_exec *exec,struct xe_vma *vma, +struct xe_vram_region *vram,bool need_vram_move) +{ +struct xe_bo *bo =xe_vma_bo (vma); +struct xe_vm *vm =xe_vma_vm (vma); +int err; + + err =xe_vm_lock_vma (exec, vma); +if (err) +return err; + +if (!bo) +return 0 ; + +return need_vram_move ?xe_bo_migrate (bo, vram->placement,NULL , exec) : +xe_bo_validate (bo, vm, true, exec); +} + +static int xe_pagefault_handle_vma (struct xe_gt *gt,struct xe_vma *vma, +bool atomic) +{ +struct xe_vm *vm =xe_vma_vm (vma); +struct xe_tile *tile =gt_to_tile (gt); +struct xe_validation_ctx ctx; +struct drm_exec exec; +struct dma_fence *fence; +int err, needs_vram; + +lockdep_assert_held_write (&vm->lock); + + needs_vram =xe_vma_need_vram_for_atomic (vm->xe, vma, atomic); +if (needs_vram <0 || (needs_vram &&xe_vma_is_userptr (vma))) +return needs_vram <0 ? needs_vram : -EACCES ; + +xe_gt_stats_incr (gt,XE_GT_STATS_ID_VMA_PAGEFAULT_COUNT ,1 ); +xe_gt_stats_incr (gt,XE_GT_STATS_ID_VMA_PAGEFAULT_KB , +xe_vma_size (vma) /SZ_1K ); + +trace_xe_vma_pagefault (vma); + +/* Check if VMA is valid, opportunistic check only */ +if (xe_vm_has_valid_gpu_mapping (tile, vma->tile_present, + vma->tile_invalidated) && !atomic) +return 0 ; + +retry_userptr: +if (xe_vma_is_userptr (vma) && +xe_vma_userptr_check_repin (to_userptr_vma (vma))) { +struct xe_userptr_vma *uvma =to_userptr_vma (vma); + + err =xe_vma_userptr_pin_pages (uvma); +if (err) +return err; + } + +/* Lock VM and BOs dma-resv */ +xe_validation_ctx_init (&ctx, &vm->xe->val, &exec, (struct xe_val_flags ) {}); +drm_exec_init (&exec,0 ,0 ); + drm_exec_until_all_locked(&exec) { + err =xe_pagefault_begin (&exec, vma, tile->mem.vram, + needs_vram ==1 ); +drm_exec_retry_on_contention (&exec); +xe_validation_retry_on_oom (&ctx, &err); +if (err) + goto unlock_dma_resv; + +/* Bind VMA only to the GT that has faulted */ +trace_xe_vma_pf_bind (vma); +xe_vm_set_validation_exec (vm, &exec); + fence =xe_vma_rebind (vm, vma,BIT (tile->id)); +xe_vm_set_validation_exec (vm,NULL ); +if (IS_ERR (fence)) { + err =PTR_ERR (fence); +xe_validation_retry_on_oom (&ctx, &err); + goto unlock_dma_resv; + } + } + +dma_fence_wait (fence, false); +dma_fence_put (fence); + +unlock_dma_resv: +xe_validation_ctx_fini (&ctx); +if (err == -EAGAIN ) + goto retry_userptr; + +return err; +} + +static bool +xe_pagefault_access_is_atomic (enum xe_pagefault_access_type access_type) +{ +return access_type ==XE_PAGEFAULT_ACCESS_TYPE_ATOMIC ; +} + +static struct xe_vm *xe_pagefault_asid_to_vm (struct xe_device *xe,u32 asid) +{ +struct xe_vm *vm; + +down_read (&xe->usm.lock); + vm =xa_load (&xe->usm.asid_to_vm, asid); +if (vm &&xe_vm_in_fault_mode (vm)) +xe_vm_get (vm); +else + vm =ERR_PTR (-EINVAL ); +up_read (&xe->usm.lock); + +return vm; +} + +static int xe_pagefault_service (struct xe_pagefault *pf) +{ +struct xe_gt *gt = pf->gt; +struct xe_device *xe =gt_to_xe (gt); +struct xe_vm *vm; +struct xe_vma *vma =NULL ; +int err; +bool atomic; + +/* Producer flagged this fault to be nacked */ +if (pf->consumer.fault_level ==XE_PAGEFAULT_LEVEL_NACK ) +return -EFAULT ; + + vm =xe_pagefault_asid_to_vm (xe, pf->consumer.asid); +if (IS_ERR (vm)) +return PTR_ERR (vm); + +/* +* TODO: Change to read lock? Using write lock for simplicity. +*/ +down_write (&vm->lock); + +if (xe_vm_is_closed (vm)) { + err = -ENOENT ; + goto unlock_vm; + } + + vma =xe_vm_find_vma_by_addr (vm, pf->consumer.page_addr); +if (!vma) { + err = -EINVAL ; + goto unlock_vm; + } + + atomic =xe_pagefault_access_is_atomic (pf->consumer.access_type); + +if (xe_vma_is_cpu_addr_mirror (vma)) + err =xe_svm_handle_pagefault (vm, vma, gt, + pf->consumer.page_addr, atomic); +else + err =xe_pagefault_handle_vma (gt, vma, atomic); + +unlock_vm: +if (!err) + vm->usm.last_fault_vma = vma; +up_write (&vm->lock); +xe_vm_put (vm); + +return err; +} + +static bool xe_pagefault_queue_pop (struct xe_pagefault_queue *pf_queue, +struct xe_pagefault *pf) +{ +bool found_fault = false; + +spin_lock_irq (&pf_queue->lock); +if (pf_queue->tail != pf_queue->head) { +memcpy (pf, pf_queue->data + pf_queue->tail,sizeof (*pf)); + pf_queue->tail = (pf_queue->tail +xe_pagefault_entry_size ()) % + pf_queue->size; + found_fault = true; + } +spin_unlock_irq (&pf_queue->lock); + +return found_fault; +} + +static void xe_pagefault_print (struct xe_pagefault *pf) +{ +xe_gt_dbg (pf->gt,"\n\tASID: %d\n" +"\tFaulted Address: 0x%08x%08x\n" +"\tFaultType: %d\n" +"\tAccessType: %d\n" +"\tFaultLevel: %d\n" +"\tEngineClass: %d %s\n" +"\tEngineInstance: %d\n" , + pf->consumer.asid, +upper_32_bits (pf->consumer.page_addr), +lower_32_bits (pf->consumer.page_addr), + pf->consumer.fault_type, + pf->consumer.access_type, + pf->consumer.fault_level, + pf->consumer.engine_class, +xe_hw_engine_class_to_str (pf->consumer.engine_class), + pf->consumer.engine_instance); +} +static void xe_pagefault_queue_work (struct work_struct *w) { -/* TODO: Implement */ +struct xe_pagefault_queue *pf_queue = +container_of (w,typeof (*pf_queue), worker); +struct xe_pagefault pf; +unsigned long threshold; + +#define USM_QUEUE_MAX_RUNTIME_MS 20 + threshold = jiffies +msecs_to_jiffies (USM_QUEUE_MAX_RUNTIME_MS ); + +while (xe_pagefault_queue_pop (pf_queue, &pf)) { +int err; + +if (!pf.gt)/* Fault squashed during reset */ +continue ; + + err =xe_pagefault_service (&pf); +if (err) { +xe_pagefault_print (&pf); +xe_gt_dbg (pf.gt,"Fault response: Unsuccessful %pe\n" , +ERR_PTR (err)); + } + + pf.producer.ops->ack_fault (&pf, err); + +if (time_after (jiffies, threshold)) { +queue_work (gt_to_xe (pf.gt)->usm.pf_wq, w); +break ; + } + } +#undef USM_QUEUE_MAX_RUNTIME_MS } static int xe_pagefault_queue_init(struct xe_device *xe,
Signature · 1 line
2.34.1
Re: [PATCH v4 5/7] drm/xe: Implement xe_pagefault_queue_work
Quoted 78 lines · Matthew Brost
Implement a worker that services page faults, using the same implementation as in
xe_gt_pagefault.c.v2:
- Rebase on exhaustive eviction changes
- Include engine instance in debug prints (Stuart)Signed-off-by Matthew Brost <[email protected]>Reviewed-by Stuart Summers <[email protected]>---
drivers/gpu/drm/xe/xe_pagefault.c| 235 +++++++++++++++++++++++++++++-1 file changed, 234 insertions(+), 1 deletion(-)drivers/gpu/drm/xe/xe_pagefault.c +44
-0@@ -5,12 +5,20 @@#include <linux/circ_buf.h> +#include <drm/drm_exec.h> #include <drm/drm_managed.h> +#include "xe_bo.h" #include "xe_device.h" +#include "xe_gt_printk.h" #include "xe_gt_types.h" +#include "xe_gt_stats.h" +#include "xe_hw_engine.h" #include "xe_pagefault.h" #include "xe_pagefault_types.h" +#include "xe_svm.h" +#include "xe_trace_bo.h" +#include "xe_vm.h" /** * DOC: Xe page faults @@ -32,9 +40,234 @@ static int xe_pagefault_entry_size(void)return roundup_pow_of_two (sizeof (struct xe_pagefault )); } +static int xe_pagefault_begin (struct drm_exec *exec,struct xe_vma *vma, +struct xe_vram_region *vram,bool need_vram_move) +{ +struct xe_bo *bo =xe_vma_bo (vma); +struct xe_vm *vm =xe_vma_vm (vma); +int err; + + err =xe_vm_lock_vma (exec, vma); +if (err) +return err; + +if (!bo) +return 0 ; + +return need_vram_move ?xe_bo_migrate (bo, vram->placement,NULL , exec) : +xe_bo_validate (bo, vm, true, exec); +} + +static int xe_pagefault_handle_vma (struct xe_gt *gt,struct xe_vma *vma, +bool atomic) +{ +struct xe_vm *vm =xe_vma_vm (vma); +struct xe_tile *tile =gt_to_tile (gt); +struct xe_validation_ctx ctx; +struct drm_exec exec; +struct dma_fence *fence; +int err, needs_vram; + +lockdep_assert_held_write (&vm->lock); + + needs_vram =xe_vma_need_vram_for_atomic (vm->xe, vma, atomic); +if (needs_vram <0 || (needs_vram &&xe_vma_is_userptr (vma))) +return needs_vram <0 ? needs_vram : -EACCES ; + +xe_gt_stats_incr (gt,XE_GT_STATS_ID_VMA_PAGEFAULT_COUNT ,1 ); + xe_gt_stats_incr(gt, XE_GT_STATS_ID_VMA_PAGEFAULT_KB,
drivers/gpu/drm/xe/xe_pagefault.c static int xe_pagefault_entry_size(void) · line 88
Quoted 10 lines
drivers/gpu/drm/xe/xe_pagefault.c +10
-0+ xe_vma_size(vma) / SZ_1K); + +trace_xe_vma_pagefault (vma); + +/* Check if VMA is valid, opportunistic check only */ +if (xe_vm_has_valid_gpu_mapping (tile, vma->tile_present, + vma->tile_invalidated) && !atomic) +return 0 ; + +retry_userptr:
I realize this is a copy-paste-diverge from xe_gt_pagefault but this goto backwards is ugly for no reason.
it could be either
do {
...
} while (err == -EAGAIN)or a separate function
while (err == -EAGAIN) err = try_pagefault_handle_userptr(...)
this can be done on top though.
Lucas De Marchi
Quoted 189 lines
drivers/gpu/drm/xe/xe_pagefault.c +180
-1+if (xe_vma_is_userptr (vma) && +xe_vma_userptr_check_repin (to_userptr_vma (vma))) { +struct xe_userptr_vma *uvma =to_userptr_vma (vma); + + err =xe_vma_userptr_pin_pages (uvma); +if (err) +return err; + } + +/* Lock VM and BOs dma-resv */ +xe_validation_ctx_init (&ctx, &vm->xe->val, &exec, (struct xe_val_flags ) {}); +drm_exec_init (&exec,0 ,0 ); + drm_exec_until_all_locked(&exec) { + err =xe_pagefault_begin (&exec, vma, tile->mem.vram, + needs_vram ==1 ); +drm_exec_retry_on_contention (&exec); +xe_validation_retry_on_oom (&ctx, &err); +if (err) + goto unlock_dma_resv; + +/* Bind VMA only to the GT that has faulted */ +trace_xe_vma_pf_bind (vma); +xe_vm_set_validation_exec (vm, &exec); + fence =xe_vma_rebind (vm, vma,BIT (tile->id)); +xe_vm_set_validation_exec (vm,NULL ); +if (IS_ERR (fence)) { + err =PTR_ERR (fence); +xe_validation_retry_on_oom (&ctx, &err); + goto unlock_dma_resv; + } + } + +dma_fence_wait (fence, false); +dma_fence_put (fence); + +unlock_dma_resv: +xe_validation_ctx_fini (&ctx); +if (err == -EAGAIN ) + goto retry_userptr; + +return err; +} + +static bool +xe_pagefault_access_is_atomic (enum xe_pagefault_access_type access_type) +{ +return access_type ==XE_PAGEFAULT_ACCESS_TYPE_ATOMIC ; +} + +static struct xe_vm *xe_pagefault_asid_to_vm (struct xe_device *xe,u32 asid) +{ +struct xe_vm *vm; + +down_read (&xe->usm.lock); + vm =xa_load (&xe->usm.asid_to_vm, asid); +if (vm &&xe_vm_in_fault_mode (vm)) +xe_vm_get (vm); +else + vm =ERR_PTR (-EINVAL ); +up_read (&xe->usm.lock); + +return vm; +} + +static int xe_pagefault_service (struct xe_pagefault *pf) +{ +struct xe_gt *gt = pf->gt; +struct xe_device *xe =gt_to_xe (gt); +struct xe_vm *vm; +struct xe_vma *vma =NULL ; +int err; +bool atomic; + +/* Producer flagged this fault to be nacked */ +if (pf->consumer.fault_level ==XE_PAGEFAULT_LEVEL_NACK ) +return -EFAULT ; + + vm =xe_pagefault_asid_to_vm (xe, pf->consumer.asid); +if (IS_ERR (vm)) +return PTR_ERR (vm); + +/* +* TODO: Change to read lock? Using write lock for simplicity. +*/ +down_write (&vm->lock); + +if (xe_vm_is_closed (vm)) { + err = -ENOENT ; + goto unlock_vm; + } + + vma =xe_vm_find_vma_by_addr (vm, pf->consumer.page_addr); +if (!vma) { + err = -EINVAL ; + goto unlock_vm; + } + + atomic =xe_pagefault_access_is_atomic (pf->consumer.access_type); + +if (xe_vma_is_cpu_addr_mirror (vma)) + err =xe_svm_handle_pagefault (vm, vma, gt, + pf->consumer.page_addr, atomic); +else + err =xe_pagefault_handle_vma (gt, vma, atomic); + +unlock_vm: +if (!err) + vm->usm.last_fault_vma = vma; +up_write (&vm->lock); +xe_vm_put (vm); + +return err; +} + +static bool xe_pagefault_queue_pop (struct xe_pagefault_queue *pf_queue, +struct xe_pagefault *pf) +{ +bool found_fault = false; + +spin_lock_irq (&pf_queue->lock); +if (pf_queue->tail != pf_queue->head) { +memcpy (pf, pf_queue->data + pf_queue->tail,sizeof (*pf)); + pf_queue->tail = (pf_queue->tail +xe_pagefault_entry_size ()) % + pf_queue->size; + found_fault = true; + } +spin_unlock_irq (&pf_queue->lock); + +return found_fault; +} + +static void xe_pagefault_print (struct xe_pagefault *pf) +{ +xe_gt_dbg (pf->gt,"\n\tASID: %d\n" +"\tFaulted Address: 0x%08x%08x\n" +"\tFaultType: %d\n" +"\tAccessType: %d\n" +"\tFaultLevel: %d\n" +"\tEngineClass: %d %s\n" +"\tEngineInstance: %d\n" , + pf->consumer.asid, +upper_32_bits (pf->consumer.page_addr), +lower_32_bits (pf->consumer.page_addr), + pf->consumer.fault_type, + pf->consumer.access_type, + pf->consumer.fault_level, + pf->consumer.engine_class, +xe_hw_engine_class_to_str (pf->consumer.engine_class), + pf->consumer.engine_instance); +} +static void xe_pagefault_queue_work (struct work_struct *w) { -/* TODO: Implement */ +struct xe_pagefault_queue *pf_queue = +container_of (w,typeof (*pf_queue), worker); +struct xe_pagefault pf; +unsigned long threshold; + +#define USM_QUEUE_MAX_RUNTIME_MS 20 + threshold = jiffies +msecs_to_jiffies (USM_QUEUE_MAX_RUNTIME_MS ); + +while (xe_pagefault_queue_pop (pf_queue, &pf)) { +int err; + +if (!pf.gt)/* Fault squashed during reset */ +continue ; + + err =xe_pagefault_service (&pf); +if (err) { +xe_pagefault_print (&pf); +xe_gt_dbg (pf.gt,"Fault response: Unsuccessful %pe\n" , +ERR_PTR (err)); + } + + pf.producer.ops->ack_fault (&pf, err); + +if (time_after (jiffies, threshold)) { +queue_work (gt_to_xe (pf.gt)->usm.pf_wq, w); +break ; + } + } +#undef USM_QUEUE_MAX_RUNTIME_MS } static int xe_pagefault_queue_init(struct xe_device *xe,Signature · 1 line
2.34.1
Matthew Brost
maintainerRe: [PATCH v4 5/7] drm/xe: Implement xe_pagefault_queue_work
Quoted 99 lines · Lucas De Marchi
Quoted 78 lines · Matthew Brost
Implement a worker that services page faults, using the same implementation as in
xe_gt_pagefault.c.v2:
- Rebase on exhaustive eviction changes
- Include engine instance in debug prints (Stuart)Signed-off-by Matthew Brost <[email protected]>Reviewed-by Stuart Summers <[email protected]>---
drivers/gpu/drm/xe/xe_pagefault.c| 235 +++++++++++++++++++++++++++++-1 file changed, 234 insertions(+), 1 deletion(-)drivers/gpu/drm/xe/xe_pagefault.c +44
-0@@ -5,12 +5,20 @@#include <linux/circ_buf.h> +#include <drm/drm_exec.h> #include <drm/drm_managed.h> +#include "xe_bo.h" #include "xe_device.h" +#include "xe_gt_printk.h" #include "xe_gt_types.h" +#include "xe_gt_stats.h" +#include "xe_hw_engine.h" #include "xe_pagefault.h" #include "xe_pagefault_types.h" +#include "xe_svm.h" +#include "xe_trace_bo.h" +#include "xe_vm.h" /** * DOC: Xe page faults @@ -32,9 +40,234 @@ static int xe_pagefault_entry_size(void)return roundup_pow_of_two (sizeof (struct xe_pagefault )); } +static int xe_pagefault_begin (struct drm_exec *exec,struct xe_vma *vma, +struct xe_vram_region *vram,bool need_vram_move) +{ +struct xe_bo *bo =xe_vma_bo (vma); +struct xe_vm *vm =xe_vma_vm (vma); +int err; + + err =xe_vm_lock_vma (exec, vma); +if (err) +return err; + +if (!bo) +return 0 ; + +return need_vram_move ?xe_bo_migrate (bo, vram->placement,NULL , exec) : +xe_bo_validate (bo, vm, true, exec); +} + +static int xe_pagefault_handle_vma (struct xe_gt *gt,struct xe_vma *vma, +bool atomic) +{ +struct xe_vm *vm =xe_vma_vm (vma); +struct xe_tile *tile =gt_to_tile (gt); +struct xe_validation_ctx ctx; +struct drm_exec exec; +struct dma_fence *fence; +int err, needs_vram; + +lockdep_assert_held_write (&vm->lock); + + needs_vram =xe_vma_need_vram_for_atomic (vm->xe, vma, atomic); +if (needs_vram <0 || (needs_vram &&xe_vma_is_userptr (vma))) +return needs_vram <0 ? needs_vram : -EACCES ; + +xe_gt_stats_incr (gt,XE_GT_STATS_ID_VMA_PAGEFAULT_COUNT ,1 ); + xe_gt_stats_incr(gt, XE_GT_STATS_ID_VMA_PAGEFAULT_KB,drivers/gpu/drm/xe/xe_pagefault.c static int xe_pagefault_entry_size(void) · line 88
Quoted 10 lines
drivers/gpu/drm/xe/xe_pagefault.c +10
-0+ xe_vma_size(vma) / SZ_1K); + +trace_xe_vma_pagefault (vma); + +/* Check if VMA is valid, opportunistic check only */ +if (xe_vm_has_valid_gpu_mapping (tile, vma->tile_present, + vma->tile_invalidated) && !atomic) +return 0 ; + +retry_userptr:I realize this is a copy-paste-diverge from
xe_gt_pagefaultbut this goto backwards is ugly for no reason.it could be either
do { ... } while (err == -EAGAIN)
Quoted 7 lines
or a separate function
while (err == -EAGAIN) err = try_pagefault_handle_userptr(...)this can be done on top though.
Let's get this in, then rework the logic a bit for clarity.
Matt
Quoted 193 lines
Reviewed-by Lucas De Marchi <[email protected]>Lucas De Marchi
Quoted 189 lines
drivers/gpu/drm/xe/xe_pagefault.c +180
-1+if (xe_vma_is_userptr (vma) && +xe_vma_userptr_check_repin (to_userptr_vma (vma))) { +struct xe_userptr_vma *uvma =to_userptr_vma (vma); + + err =xe_vma_userptr_pin_pages (uvma); +if (err) +return err; + } + +/* Lock VM and BOs dma-resv */ +xe_validation_ctx_init (&ctx, &vm->xe->val, &exec, (struct xe_val_flags ) {}); +drm_exec_init (&exec,0 ,0 ); + drm_exec_until_all_locked(&exec) { + err =xe_pagefault_begin (&exec, vma, tile->mem.vram, + needs_vram ==1 ); +drm_exec_retry_on_contention (&exec); +xe_validation_retry_on_oom (&ctx, &err); +if (err) + goto unlock_dma_resv; + +/* Bind VMA only to the GT that has faulted */ +trace_xe_vma_pf_bind (vma); +xe_vm_set_validation_exec (vm, &exec); + fence =xe_vma_rebind (vm, vma,BIT (tile->id)); +xe_vm_set_validation_exec (vm,NULL ); +if (IS_ERR (fence)) { + err =PTR_ERR (fence); +xe_validation_retry_on_oom (&ctx, &err); + goto unlock_dma_resv; + } + } + +dma_fence_wait (fence, false); +dma_fence_put (fence); + +unlock_dma_resv: +xe_validation_ctx_fini (&ctx); +if (err == -EAGAIN ) + goto retry_userptr; + +return err; +} + +static bool +xe_pagefault_access_is_atomic (enum xe_pagefault_access_type access_type) +{ +return access_type ==XE_PAGEFAULT_ACCESS_TYPE_ATOMIC ; +} + +static struct xe_vm *xe_pagefault_asid_to_vm (struct xe_device *xe,u32 asid) +{ +struct xe_vm *vm; + +down_read (&xe->usm.lock); + vm =xa_load (&xe->usm.asid_to_vm, asid); +if (vm &&xe_vm_in_fault_mode (vm)) +xe_vm_get (vm); +else + vm =ERR_PTR (-EINVAL ); +up_read (&xe->usm.lock); + +return vm; +} + +static int xe_pagefault_service (struct xe_pagefault *pf) +{ +struct xe_gt *gt = pf->gt; +struct xe_device *xe =gt_to_xe (gt); +struct xe_vm *vm; +struct xe_vma *vma =NULL ; +int err; +bool atomic; + +/* Producer flagged this fault to be nacked */ +if (pf->consumer.fault_level ==XE_PAGEFAULT_LEVEL_NACK ) +return -EFAULT ; + + vm =xe_pagefault_asid_to_vm (xe, pf->consumer.asid); +if (IS_ERR (vm)) +return PTR_ERR (vm); + +/* +* TODO: Change to read lock? Using write lock for simplicity. +*/ +down_write (&vm->lock); + +if (xe_vm_is_closed (vm)) { + err = -ENOENT ; + goto unlock_vm; + } + + vma =xe_vm_find_vma_by_addr (vm, pf->consumer.page_addr); +if (!vma) { + err = -EINVAL ; + goto unlock_vm; + } + + atomic =xe_pagefault_access_is_atomic (pf->consumer.access_type); + +if (xe_vma_is_cpu_addr_mirror (vma)) + err =xe_svm_handle_pagefault (vm, vma, gt, + pf->consumer.page_addr, atomic); +else + err =xe_pagefault_handle_vma (gt, vma, atomic); + +unlock_vm: +if (!err) + vm->usm.last_fault_vma = vma; +up_write (&vm->lock); +xe_vm_put (vm); + +return err; +} + +static bool xe_pagefault_queue_pop (struct xe_pagefault_queue *pf_queue, +struct xe_pagefault *pf) +{ +bool found_fault = false; + +spin_lock_irq (&pf_queue->lock); +if (pf_queue->tail != pf_queue->head) { +memcpy (pf, pf_queue->data + pf_queue->tail,sizeof (*pf)); + pf_queue->tail = (pf_queue->tail +xe_pagefault_entry_size ()) % + pf_queue->size; + found_fault = true; + } +spin_unlock_irq (&pf_queue->lock); + +return found_fault; +} + +static void xe_pagefault_print (struct xe_pagefault *pf) +{ +xe_gt_dbg (pf->gt,"\n\tASID: %d\n" +"\tFaulted Address: 0x%08x%08x\n" +"\tFaultType: %d\n" +"\tAccessType: %d\n" +"\tFaultLevel: %d\n" +"\tEngineClass: %d %s\n" +"\tEngineInstance: %d\n" , + pf->consumer.asid, +upper_32_bits (pf->consumer.page_addr), +lower_32_bits (pf->consumer.page_addr), + pf->consumer.fault_type, + pf->consumer.access_type, + pf->consumer.fault_level, + pf->consumer.engine_class, +xe_hw_engine_class_to_str (pf->consumer.engine_class), + pf->consumer.engine_instance); +} +static void xe_pagefault_queue_work (struct work_struct *w) { -/* TODO: Implement */ +struct xe_pagefault_queue *pf_queue = +container_of (w,typeof (*pf_queue), worker); +struct xe_pagefault pf; +unsigned long threshold; + +#define USM_QUEUE_MAX_RUNTIME_MS 20 + threshold = jiffies +msecs_to_jiffies (USM_QUEUE_MAX_RUNTIME_MS ); + +while (xe_pagefault_queue_pop (pf_queue, &pf)) { +int err; + +if (!pf.gt)/* Fault squashed during reset */ +continue ; + + err =xe_pagefault_service (&pf); +if (err) { +xe_pagefault_print (&pf); +xe_gt_dbg (pf.gt,"Fault response: Unsuccessful %pe\n" , +ERR_PTR (err)); + } + + pf.producer.ops->ack_fault (&pf, err); + +if (time_after (jiffies, threshold)) { +queue_work (gt_to_xe (pf.gt)->usm.pf_wq, w); +break ; + } + } +#undef USM_QUEUE_MAX_RUNTIME_MS } static int xe_pagefault_queue_init(struct xe_device *xe,Signature · 1 line
2.34.1
Matthew Brost
maintainerPATCH v4 6/7 drm/xe: Add xe_guc_pagefault layer
In reply to Matthew BrostAdd xe_guc_pagefault layer (producer) which parses G2H fault messages messages into struct xe_pagefault, forwards them to the page fault layer (consumer) for servicing, and provides a vfunc to acknowledge faults to the GuC upon completion. Replace the old (and incorrect) GT page fault layer with this new layer throughout the driver.
v2:
- Include engine instance (Stuart)
--- drivers/gpu/drm/xe/Makefile | 2 +- drivers/gpu/drm/xe/xe_gt.c | 6 -- drivers/gpu/drm/xe/xe_guc_ct.c | 6 +- drivers/gpu/drm/xe/xe_guc_pagefault.c | 95 +++++++++++++++++++++++++++ drivers/gpu/drm/xe/xe_guc_pagefault.h | 15 +++++ drivers/gpu/drm/xe/xe_svm.c | 3 +- drivers/gpu/drm/xe/xe_vm.c | 1 - 7 files changed, 113 insertions(+), 15 deletions(-) create mode 100644 drivers/gpu/drm/xe/xe_guc_pagefault.c create mode 100644 drivers/gpu/drm/xe/xe_guc_pagefault.h
drivers/gpu/drm/xe/Makefile +1 -1
@@ -58,7 +58,6 @@ xe-y += xe_bb.o \ xe_gt_freq.o \ xe_gt_idle.o \ xe_gt_mcr.o \ - xe_gt_pagefault.o \ xe_gt_sysfs.o \ xe_gt_throttle.o \ xe_gt_topology.o \
@@ -73,6 +72,7 @@ xe-y += xe_bb.o \ xe_guc_id_mgr.o \ xe_guc_klv_helpers.o \ xe_guc_log.o \ + xe_guc_pagefault.o \ xe_guc_pc.o \ xe_guc_submit.o \ xe_guc_tlb_inval.o \
drivers/gpu/drm/xe/xe_gt.c +0 -6
@@ -32,7 +32,6 @@#include "xe_gt_freq.h" #include "xe_gt_idle.h" #include "xe_gt_mcr.h" -#include "xe_gt_pagefault.h" #include "xe_gt_printk.h" #include "xe_gt_sriov_pf.h" #include "xe_gt_sriov_vf.h"
@@ -638,10 +637,6 @@ int xe_gt_init(struct xe_gt *gt)if (err)return err; - err =xe_gt_pagefault_init (gt); -if (err) -return err; - err =xe_gt_idle_init (>->gtidle);if (err)return err;
@@ -851,7 +846,6 @@ static int gt_reset(struct xe_gt *gt)xe_uc_gucrc_disable (>->uc);xe_uc_stop_prepare (>->uc);xe_pagefault_reset (gt_to_xe (gt), gt); -xe_gt_pagefault_reset (gt);xe_uc_stop (>->uc);
drivers/gpu/drm/xe/xe_guc_ct.c +1 -5
@@ -21,12 +21,12 @@#include "xe_devcoredump.h" #include "xe_device.h" #include "xe_gt.h" -#include "xe_gt_pagefault.h" #include "xe_gt_printk.h" #include "xe_gt_sriov_pf_control.h" #include "xe_gt_sriov_pf_monitor.h" #include "xe_guc.h" #include "xe_guc_log.h" +#include "xe_guc_pagefault.h" #include "xe_guc_relay.h" #include "xe_guc_submit.h" #include "xe_guc_tlb_inval.h"
@@ -1545,10 +1545,6 @@ static int process_g2h_msg(struct xe_guc_ct *ct, u32 *msg, u32 len)case XE_GUC_ACTION_TLB_INVALIDATION_DONE : ret =xe_guc_tlb_inval_done_handler (guc, payload, adj_len);break ; -case XE_GUC_ACTION_ACCESS_COUNTER_NOTIFY : - ret =xe_guc_access_counter_notify_handler (guc, payload, - adj_len); -break ;case XE_GUC_ACTION_GUC2PF_RELAY_FROM_VF : ret =xe_guc_relay_process_guc2pf (&guc->relay, hxg, hxg_len);break ;
drivers/gpu/drm/xe/xe_guc_pagefault.c new file +95 -0
95 lines not on this page · raw message
drivers/gpu/drm/xe/xe_guc_pagefault.h new file +15 -0
@@ -0,0 +1,15 @@ +/* SPDX-License-Identifier: MIT */ +/* +* Copyright © 2025 Intel Corporation +*/ + +#ifndef _XE_GUC_PAGEFAULT_H_ +#define _XE_GUC_PAGEFAULT_H_ + +#include <linux/types.h> + +struct xe_guc ; + +int xe_guc_pagefault_handler (struct xe_guc *guc,u32 *msg,u32 len); + +#endif
drivers/gpu/drm/xe/xe_svm.c +1 -2
@@ -104,8 +104,7 @@ xe_svm_garbage_collector_add_range(struct xe_vm *vm, struct xe_svm_range *range, &vm->svm.garbage_collector.range_list);spin_unlock (&vm->svm.garbage_collector.lock); -queue_work (xe_device_get_root_tile (xe)->primary_gt->usm.pf_wq, - &vm->svm.garbage_collector.work); +queue_work (xe->usm.pf_wq, &vm->svm.garbage_collector.work); }static void xe_svm_tlb_inval_count_stats_incr (struct xe_gt *gt)
drivers/gpu/drm/xe/xe_vm.c +0 -1
@@ -27,7 +27,6 @@#include "xe_device.h" #include "xe_drm_client.h" #include "xe_exec_queue.h" -#include "xe_gt_pagefault.h" #include "xe_migrate.h" #include "xe_pat.h" #include "xe_pm.h"
Signature · 1 line
2.34.1
Re: [PATCH v4 6/7] drm/xe: Add xe_guc_pagefault layer
Quoted 92 lines · Matthew Brost
Add
xe_guc_pagefaultlayer (producer) which parses G2H fault messages messages into structxe_pagefault, forwards them to the page fault layer (consumer) for servicing, and provides a vfunc to acknowledge faults to the GuC upon completion. Replace the old (and incorrect) GT page fault layer with this new layer throughout the driver.v2:
- Include engine instance (Stuart)Signed-off-by Matthew Brost <[email protected]>---
drivers/gpu/drm/xe/Makefile | 2 +- drivers/gpu/drm/xe/xe_gt.c | 6 -- drivers/gpu/drm/xe/xe_guc_ct.c | 6 +- drivers/gpu/drm/xe/xe_guc_pagefault.c | 95 +++++++++++++++++++++++++++ drivers/gpu/drm/xe/xe_guc_pagefault.h | 15 +++++ drivers/gpu/drm/xe/xe_svm.c | 3 +- drivers/gpu/drm/xe/xe_vm.c | 1 - 7 files changed, 113 insertions(+), 15 deletions(-)create mode 100644
drivers/gpu/drm/xe/xe_guc_pagefault.ccreate mode 100644drivers/gpu/drm/xe/xe_guc_pagefault.hdrivers/gpu/drm/xe/Makefile +1
-1@@ -58,7 +58,6 @@ xe-y += xe_bb.o \ xe_gt_freq.o \ xe_gt_idle.o \ xe_gt_mcr.o \ - xe_gt_pagefault.o \ xe_gt_sysfs.o \ xe_gt_throttle.o \ xe_gt_topology.o \@@ -73,6 +72,7 @@ xe-y += xe_bb.o \ xe_guc_id_mgr.o \ xe_guc_klv_helpers.o \ xe_guc_log.o \ + xe_guc_pagefault.o \ xe_guc_pc.o \ xe_guc_submit.o \ xe_guc_tlb_inval.o \drivers/gpu/drm/xe/xe_gt.c +0
-6@@ -32,7 +32,6 @@#include "xe_gt_freq.h" #include "xe_gt_idle.h" #include "xe_gt_mcr.h" -#include "xe_gt_pagefault.h" #include "xe_gt_printk.h" #include "xe_gt_sriov_pf.h" #include "xe_gt_sriov_vf.h" @@ -638,10 +637,6 @@ int xe_gt_init(struct xe_gt *gt)if (err)return err; - err =xe_gt_pagefault_init (gt); -if (err) -return err; - err =xe_gt_idle_init (>->gtidle);if (err)return err;@@ -851,7 +846,6 @@ static int gt_reset(struct xe_gt *gt)xe_uc_gucrc_disable (>->uc);xe_uc_stop_prepare (>->uc);xe_pagefault_reset (gt_to_xe (gt), gt); -xe_gt_pagefault_reset (gt);xe_uc_stop (>->uc);drivers/gpu/drm/xe/xe_guc_ct.c +1
-1@@ -21,12 +21,12 @@#include "xe_devcoredump.h" #include "xe_device.h" #include "xe_gt.h" -#include "xe_gt_pagefault.h" #include "xe_gt_printk.h" #include "xe_gt_sriov_pf_control.h" #include "xe_gt_sriov_pf_monitor.h" #include "xe_guc.h" #include "xe_guc_log.h" +#include "xe_guc_pagefault.h" #include "xe_guc_relay.h" #include "xe_guc_submit.h" #include "xe_guc_tlb_inval.h"
drivers/gpu/drm/xe/xe_guc_ct.c static int process_g2h_msg(struct xe_guc_ct *ct, u32 *msg, u32 len) · line 1551
Quoted 7 lines
drivers/gpu/drm/xe/xe_guc_ct.c +0
-4@@ -1545,10 +1545,6 @@ static int process_g2h_msg(struct xe_guc_ct *ct, u32 *msg, u32 len)case XE_GUC_ACTION_TLB_INVALIDATION_DONE : ret =xe_guc_tlb_inval_done_handler (guc, payload, adj_len);break ; -case XE_GUC_ACTION_ACCESS_COUNTER_NOTIFY : - ret =xe_guc_access_counter_notify_handler (guc, payload, - adj_len); -break ;
this doesn't seem to belong here. Should that be in the last patch? Or a dedicated patch for acc removal?
I started to look into this because we need to add support for the prefetch bit for xe3p, and I think it makes sense to add it on top of your series rather than conflicting with it.
Lucas De Marchi
Matthew Brost
maintainerRe: [PATCH v4 6/7] drm/xe: Add xe_guc_pagefault layer
Quoted 94 lines · Lucas De Marchi
Quoted 93 lines · Matthew Brost
Add
xe_guc_pagefaultlayer (producer) which parses G2H fault messages messages into structxe_pagefault, forwards them to the page fault layer (consumer) for servicing, and provides a vfunc to acknowledge faults to the GuC upon completion. Replace the old (and incorrect) GT page fault layer with this new layer throughout the driver.v2:
- Include engine instance (Stuart)Signed-off-by Matthew Brost <[email protected]>---
drivers/gpu/drm/xe/Makefile | 2 +- drivers/gpu/drm/xe/xe_gt.c | 6 -- drivers/gpu/drm/xe/xe_guc_ct.c | 6 +- drivers/gpu/drm/xe/xe_guc_pagefault.c | 95 +++++++++++++++++++++++++++ drivers/gpu/drm/xe/xe_guc_pagefault.h | 15 +++++ drivers/gpu/drm/xe/xe_svm.c | 3 +- drivers/gpu/drm/xe/xe_vm.c | 1 - 7 files changed, 113 insertions(+), 15 deletions(-)create mode 100644
drivers/gpu/drm/xe/xe_guc_pagefault.ccreate mode 100644drivers/gpu/drm/xe/xe_guc_pagefault.hdrivers/gpu/drm/xe/Makefile +1
-1@@ -58,7 +58,6 @@ xe-y += xe_bb.o \ xe_gt_freq.o \ xe_gt_idle.o \ xe_gt_mcr.o \ - xe_gt_pagefault.o \ xe_gt_sysfs.o \ xe_gt_throttle.o \ xe_gt_topology.o \@@ -73,6 +72,7 @@ xe-y += xe_bb.o \ xe_guc_id_mgr.o \ xe_guc_klv_helpers.o \ xe_guc_log.o \ + xe_guc_pagefault.o \ xe_guc_pc.o \ xe_guc_submit.o \ xe_guc_tlb_inval.o \drivers/gpu/drm/xe/xe_gt.c +0
-6@@ -32,7 +32,6 @@#include "xe_gt_freq.h" #include "xe_gt_idle.h" #include "xe_gt_mcr.h" -#include "xe_gt_pagefault.h" #include "xe_gt_printk.h" #include "xe_gt_sriov_pf.h" #include "xe_gt_sriov_vf.h" @@ -638,10 +637,6 @@ int xe_gt_init(struct xe_gt *gt)if (err)return err; - err =xe_gt_pagefault_init (gt); -if (err) -return err; - err =xe_gt_idle_init (>->gtidle);if (err)return err;@@ -851,7 +846,6 @@ static int gt_reset(struct xe_gt *gt)xe_uc_gucrc_disable (>->uc);xe_uc_stop_prepare (>->uc);xe_pagefault_reset (gt_to_xe (gt), gt); -xe_gt_pagefault_reset (gt);xe_uc_stop (>->uc);drivers/gpu/drm/xe/xe_guc_ct.c +1
-1@@ -21,12 +21,12 @@#include "xe_devcoredump.h" #include "xe_device.h" #include "xe_gt.h" -#include "xe_gt_pagefault.h" #include "xe_gt_printk.h" #include "xe_gt_sriov_pf_control.h" #include "xe_gt_sriov_pf_monitor.h" #include "xe_guc.h" #include "xe_guc_log.h" +#include "xe_guc_pagefault.h" #include "xe_guc_relay.h" #include "xe_guc_submit.h" #include "xe_guc_tlb_inval.h" @@ -1545,10 +1545,6 @@ static int process_g2h_msg(struct xe_guc_ct *ct, u32 *msg, u32 len)case XE_GUC_ACTION_TLB_INVALIDATION_DONE :
Quoted 8 lines
drivers/gpu/drm/xe/xe_guc_ct.c static int process_g2h_msg(struct xe_guc_ct *ct, u32 *msg, u32 len) · line 1551
Quoted 6 lines
drivers/gpu/drm/xe/xe_guc_ct.c +0
-4ret =xe_guc_tlb_inval_done_handler (guc, payload, adj_len);break ; -case XE_GUC_ACTION_ACCESS_COUNTER_NOTIFY : - ret =xe_guc_access_counter_notify_handler (guc, payload, - adj_len); -break ;this doesn't seem to belong here. Should that be in the last patch?
I think it is in this patch as xe_gt_pagefault.h was removed as include and xe_guc_pagefault.h was added. So I think this is probably correct.
Quoted 6 lines
Or a dedicated patch for acc removal?
I started to look into this because we need to add support for the prefetch bit for xe3p, and I think it makes sense to add it on top of your series rather than conflicting with it.
Yes, adding it on top would be preferred from my point of view.
Matt
Quoted 1 line
Lucas De Marchi
Re: [PATCH v4 6/7] drm/xe: Add xe_guc_pagefault layer
Quoted 104 lines · Matthew Brost
Quoted 94 lines · Lucas De Marchi
Quoted 93 lines · Matthew Brost
Add
xe_guc_pagefaultlayer (producer) which parses G2H fault messages messages into structxe_pagefault, forwards them to the page fault layer (consumer) for servicing, and provides a vfunc to acknowledge faults to the GuC upon completion. Replace the old (and incorrect) GT page fault layer with this new layer throughout the driver.v2:
- Include engine instance (Stuart)Signed-off-by Matthew Brost <[email protected]>---
drivers/gpu/drm/xe/Makefile | 2 +- drivers/gpu/drm/xe/xe_gt.c | 6 -- drivers/gpu/drm/xe/xe_guc_ct.c | 6 +- drivers/gpu/drm/xe/xe_guc_pagefault.c | 95 +++++++++++++++++++++++++++ drivers/gpu/drm/xe/xe_guc_pagefault.h | 15 +++++ drivers/gpu/drm/xe/xe_svm.c | 3 +- drivers/gpu/drm/xe/xe_vm.c | 1 - 7 files changed, 113 insertions(+), 15 deletions(-)create mode 100644
drivers/gpu/drm/xe/xe_guc_pagefault.ccreate mode 100644drivers/gpu/drm/xe/xe_guc_pagefault.hdrivers/gpu/drm/xe/Makefile +1
-1@@ -58,7 +58,6 @@ xe-y += xe_bb.o \ xe_gt_freq.o \ xe_gt_idle.o \ xe_gt_mcr.o \ - xe_gt_pagefault.o \ xe_gt_sysfs.o \ xe_gt_throttle.o \ xe_gt_topology.o \@@ -73,6 +72,7 @@ xe-y += xe_bb.o \ xe_guc_id_mgr.o \ xe_guc_klv_helpers.o \ xe_guc_log.o \ + xe_guc_pagefault.o \ xe_guc_pc.o \ xe_guc_submit.o \ xe_guc_tlb_inval.o \drivers/gpu/drm/xe/xe_gt.c +0
-6@@ -32,7 +32,6 @@#include "xe_gt_freq.h" #include "xe_gt_idle.h" #include "xe_gt_mcr.h" -#include "xe_gt_pagefault.h" #include "xe_gt_printk.h" #include "xe_gt_sriov_pf.h" #include "xe_gt_sriov_vf.h" @@ -638,10 +637,6 @@ int xe_gt_init(struct xe_gt *gt)if (err)return err; - err =xe_gt_pagefault_init (gt); -if (err) -return err; - err =xe_gt_idle_init (>->gtidle);if (err)return err;@@ -851,7 +846,6 @@ static int gt_reset(struct xe_gt *gt)xe_uc_gucrc_disable (>->uc);xe_uc_stop_prepare (>->uc);xe_pagefault_reset (gt_to_xe (gt), gt); -xe_gt_pagefault_reset (gt);xe_uc_stop (>->uc);drivers/gpu/drm/xe/xe_guc_ct.c +1
-1@@ -21,12 +21,12 @@#include "xe_devcoredump.h" #include "xe_device.h" #include "xe_gt.h" -#include "xe_gt_pagefault.h" #include "xe_gt_printk.h" #include "xe_gt_sriov_pf_control.h" #include "xe_gt_sriov_pf_monitor.h" #include "xe_guc.h" #include "xe_guc_log.h" +#include "xe_guc_pagefault.h" #include "xe_guc_relay.h" #include "xe_guc_submit.h" #include "xe_guc_tlb_inval.h" @@ -1545,10 +1545,6 @@ static int process_g2h_msg(struct xe_guc_ct *ct, u32 *msg, u32 len)case XE_GUC_ACTION_TLB_INVALIDATION_DONE :Quoted 8 lines
drivers/gpu/drm/xe/xe_guc_ct.c static int process_g2h_msg(struct xe_guc_ct *ct, u32 *msg, u32 len) · line 1551
Quoted 6 lines
drivers/gpu/drm/xe/xe_guc_ct.c +0
-4ret =xe_guc_tlb_inval_done_handler (guc, payload, adj_len);break ; -case XE_GUC_ACTION_ACCESS_COUNTER_NOTIFY : - ret =xe_guc_access_counter_notify_handler (guc, payload, - adj_len); -break ;this doesn't seem to belong here. Should that be in the last patch?
Quoted 2 lines
I think it is in this patch as
xe_gt_pagefault.hwas removed as include andxe_guc_pagefault.hwas added. So I think this is probably correct.
humn... ok, now I see why, but it still looks weird. The justification in the next patch for removal was "it's now dead code", but there's no mention why we made it dead code in the first place.
Quoted 9 lines
Quoted 7 lines
Or a dedicated patch for acc removal?
I started to look into this because we need to add support for the prefetch bit for xe3p, and I think it makes sense to add it on top of your series rather than conflicting with it.
Yes, adding it on top would be preferred from my point of view.
will do, thanks.
Lucas De Marchi
Quoted 4 lines
Matt
Quoted 1 line
Lucas De Marchi
Matthew Brost
maintainerRe: [PATCH v4 6/7] drm/xe: Add xe_guc_pagefault layer
Quoted 105 lines · Lucas De Marchi
Quoted 104 lines · Matthew Brost
Quoted 102 lines · Lucas De Marchi
Quoted 92 lines · Matthew Brost
Add
xe_guc_pagefaultlayer (producer) which parses G2H fault messages messages into structxe_pagefault, forwards them to the page fault layer (consumer) for servicing, and provides a vfunc to acknowledge faults to the GuC upon completion. Replace the old (and incorrect) GT page fault layer with this new layer throughout the driver.v2:
- Include engine instance (Stuart)Signed-off-by Matthew Brost <[email protected]>---
drivers/gpu/drm/xe/Makefile | 2 +- drivers/gpu/drm/xe/xe_gt.c | 6 -- drivers/gpu/drm/xe/xe_guc_ct.c | 6 +- drivers/gpu/drm/xe/xe_guc_pagefault.c | 95 +++++++++++++++++++++++++++ drivers/gpu/drm/xe/xe_guc_pagefault.h | 15 +++++ drivers/gpu/drm/xe/xe_svm.c | 3 +- drivers/gpu/drm/xe/xe_vm.c | 1 - 7 files changed, 113 insertions(+), 15 deletions(-)create mode 100644
drivers/gpu/drm/xe/xe_guc_pagefault.ccreate mode 100644drivers/gpu/drm/xe/xe_guc_pagefault.hdrivers/gpu/drm/xe/Makefile +1
-1@@ -58,7 +58,6 @@ xe-y += xe_bb.o \ xe_gt_freq.o \ xe_gt_idle.o \ xe_gt_mcr.o \ - xe_gt_pagefault.o \ xe_gt_sysfs.o \ xe_gt_throttle.o \ xe_gt_topology.o \@@ -73,6 +72,7 @@ xe-y += xe_bb.o \ xe_guc_id_mgr.o \ xe_guc_klv_helpers.o \ xe_guc_log.o \ + xe_guc_pagefault.o \ xe_guc_pc.o \ xe_guc_submit.o \ xe_guc_tlb_inval.o \drivers/gpu/drm/xe/xe_gt.c +0
-6@@ -32,7 +32,6 @@#include "xe_gt_freq.h" #include "xe_gt_idle.h" #include "xe_gt_mcr.h" -#include "xe_gt_pagefault.h" #include "xe_gt_printk.h" #include "xe_gt_sriov_pf.h" #include "xe_gt_sriov_vf.h" @@ -638,10 +637,6 @@ int xe_gt_init(struct xe_gt *gt)if (err)return err; - err =xe_gt_pagefault_init (gt); -if (err) -return err; - err =xe_gt_idle_init (>->gtidle);if (err)return err;@@ -851,7 +846,6 @@ static int gt_reset(struct xe_gt *gt)xe_uc_gucrc_disable (>->uc);xe_uc_stop_prepare (>->uc);xe_pagefault_reset (gt_to_xe (gt), gt); -xe_gt_pagefault_reset (gt);xe_uc_stop (>->uc);drivers/gpu/drm/xe/xe_guc_ct.c +1
-1@@ -21,12 +21,12 @@#include "xe_devcoredump.h" #include "xe_device.h" #include "xe_gt.h" -#include "xe_gt_pagefault.h" #include "xe_gt_printk.h" #include "xe_gt_sriov_pf_control.h" #include "xe_gt_sriov_pf_monitor.h" #include "xe_guc.h" #include "xe_guc_log.h" +#include "xe_guc_pagefault.h" #include "xe_guc_relay.h" #include "xe_guc_submit.h" #include "xe_guc_tlb_inval.h" drivers/gpu/drm/xe/xe_guc_ct.c static int process_g2h_msg(struct xe_guc_ct *ct, u32 *msg, u32 len) · line 1551
Quoted 7 lines
drivers/gpu/drm/xe/xe_guc_ct.c +0
-4@@ -1545,10 +1545,6 @@ static int process_g2h_msg(struct xe_guc_ct *ct, u32 *msg, u32 len)case XE_GUC_ACTION_TLB_INVALIDATION_DONE : ret =xe_guc_tlb_inval_done_handler (guc, payload, adj_len);break ; -case XE_GUC_ACTION_ACCESS_COUNTER_NOTIFY : - ret =xe_guc_access_counter_notify_handler (guc, payload, - adj_len); -break ;this doesn't seem to belong here. Should that be in the last patch?
Quoted 7 lines
Quoted 2 lines
I think it is in this patch as
xe_gt_pagefault.hwas removed as include andxe_guc_pagefault.hwas added. So I think this is probably correct.humn... ok, now I see why, but it still looks weird. The justification in the next patch for removal was "it's now dead code", but there's no mention why we made it dead code in the first place.
Let me adjust the comment in the follow patch.
Matt
Quoted 18 lines
Quoted 9 lines
Quoted 7 lines
Or a dedicated patch for acc removal?
I started to look into this because we need to add support for the prefetch bit for xe3p, and I think it makes sense to add it on top of your series rather than conflicting with it.
Yes, adding it on top would be preferred from my point of view.
will do, thanks.
Lucas De Marchi
Quoted 4 lines
Matt
Quoted 1 line
Lucas De Marchi
Lucas De Marchi
Reviewed-byRe: [PATCH v4 6/7] drm/xe: Add xe_guc_pagefault layer
Quoted 109 lines · Matthew Brost
Quoted 108 lines · Lucas De Marchi
Quoted 106 lines · Matthew Brost
Quoted 94 lines · Lucas De Marchi
Quoted 93 lines · Matthew Brost
Add
xe_guc_pagefaultlayer (producer) which parses G2H fault messages messages into structxe_pagefault, forwards them to the page fault layer (consumer) for servicing, and provides a vfunc to acknowledge faults to the GuC upon completion. Replace the old (and incorrect) GT page fault layer with this new layer throughout the driver.v2:
- Include engine instance (Stuart)Signed-off-by Matthew Brost <[email protected]>---
drivers/gpu/drm/xe/Makefile | 2 +- drivers/gpu/drm/xe/xe_gt.c | 6 -- drivers/gpu/drm/xe/xe_guc_ct.c | 6 +- drivers/gpu/drm/xe/xe_guc_pagefault.c | 95 +++++++++++++++++++++++++++ drivers/gpu/drm/xe/xe_guc_pagefault.h | 15 +++++ drivers/gpu/drm/xe/xe_svm.c | 3 +- drivers/gpu/drm/xe/xe_vm.c | 1 - 7 files changed, 113 insertions(+), 15 deletions(-)create mode 100644
drivers/gpu/drm/xe/xe_guc_pagefault.ccreate mode 100644drivers/gpu/drm/xe/xe_guc_pagefault.hdrivers/gpu/drm/xe/Makefile +1
-1@@ -58,7 +58,6 @@ xe-y += xe_bb.o \ xe_gt_freq.o \ xe_gt_idle.o \ xe_gt_mcr.o \ - xe_gt_pagefault.o \ xe_gt_sysfs.o \ xe_gt_throttle.o \ xe_gt_topology.o \@@ -73,6 +72,7 @@ xe-y += xe_bb.o \ xe_guc_id_mgr.o \ xe_guc_klv_helpers.o \ xe_guc_log.o \ + xe_guc_pagefault.o \ xe_guc_pc.o \ xe_guc_submit.o \ xe_guc_tlb_inval.o \drivers/gpu/drm/xe/xe_gt.c +0
-6@@ -32,7 +32,6 @@#include "xe_gt_freq.h" #include "xe_gt_idle.h" #include "xe_gt_mcr.h" -#include "xe_gt_pagefault.h" #include "xe_gt_printk.h" #include "xe_gt_sriov_pf.h" #include "xe_gt_sriov_vf.h" @@ -638,10 +637,6 @@ int xe_gt_init(struct xe_gt *gt)if (err)return err; - err =xe_gt_pagefault_init (gt); -if (err) -return err; - err =xe_gt_idle_init (>->gtidle);if (err)return err;@@ -851,7 +846,6 @@ static int gt_reset(struct xe_gt *gt)xe_uc_gucrc_disable (>->uc);xe_uc_stop_prepare (>->uc);xe_pagefault_reset (gt_to_xe (gt), gt); -xe_gt_pagefault_reset (gt);xe_uc_stop (>->uc);drivers/gpu/drm/xe/xe_guc_ct.c +1
-1@@ -21,12 +21,12 @@#include "xe_devcoredump.h" #include "xe_device.h" #include "xe_gt.h" -#include "xe_gt_pagefault.h" #include "xe_gt_printk.h" #include "xe_gt_sriov_pf_control.h" #include "xe_gt_sriov_pf_monitor.h" #include "xe_guc.h" #include "xe_guc_log.h" +#include "xe_guc_pagefault.h" #include "xe_guc_relay.h" #include "xe_guc_submit.h" #include "xe_guc_tlb_inval.h" @@ -1545,10 +1545,6 @@ static int process_g2h_msg(struct xe_guc_ct *ct, u32 *msg, u32 len)case XE_GUC_ACTION_TLB_INVALIDATION_DONE :Quoted 8 lines
drivers/gpu/drm/xe/xe_guc_ct.c static int process_g2h_msg(struct xe_guc_ct *ct, u32 *msg, u32 len) · line 1551
Quoted 6 lines
drivers/gpu/drm/xe/xe_guc_ct.c +0
-4ret =xe_guc_tlb_inval_done_handler (guc, payload, adj_len);break ; -case XE_GUC_ACTION_ACCESS_COUNTER_NOTIFY : - ret =xe_guc_access_counter_notify_handler (guc, payload, - adj_len); -break ;this doesn't seem to belong here. Should that be in the last patch?
I think it is in this patch as
xe_gt_pagefault.hwas removed as include andxe_guc_pagefault.hwas added. So I think this is probably correct.
Quoted 6 lines
Quoted 4 lines
humn... ok, now I see why, but it still looks weird. The justification in the next patch for removal was "it's now dead code", but there's no mention why we made it dead code in the first place.
Let me adjust the comment in the follow patch.
if that's done in the next patch, then I don't have any other feedback for this one and it looks good.
Lucas De Marchi
Matthew Brost
maintainerPATCH v4 7/7 drm/xe: Remove unused GT page fault code
In reply to Matthew BrostWith the Xe page fault layer and GuC page layer in place, this is now dead code and can be removed. ACC code is also removed, but this was dead code.
--- drivers/gpu/drm/xe/xe_gt_pagefault.c | 679 --------------------------- drivers/gpu/drm/xe/xe_gt_pagefault.h | 19 - drivers/gpu/drm/xe/xe_gt_types.h | 65 --- 3 files changed, 763 deletions(-) delete mode 100644 drivers/gpu/drm/xe/xe_gt_pagefault.c delete mode 100644 drivers/gpu/drm/xe/xe_gt_pagefault.h
drivers/gpu/drm/xe/xe_gt_pagefault.c deleted +0 -679
@@ -1,679 +0,0 @@ -// SPDX-License-Identifier: MIT -/* -* Copyright © 2022 Intel Corporation -*/ - -#include "xe_gt_pagefault.h" - -#include <linux/bitfield.h> -#include <linux/circ_buf.h> - -#include <drm/drm_exec.h> -#include <drm/drm_managed.h> - -#include "abi/guc_actions_abi.h" -#include "xe_bo.h" -#include "xe_gt.h" -#include "xe_gt_printk.h" -#include "xe_gt_stats.h" -#include "xe_guc.h" -#include "xe_guc_ct.h" -#include "xe_migrate.h" -#include "xe_svm.h" -#include "xe_trace_bo.h" -#include "xe_vm.h" -#include "xe_vram_types.h" - -struct pagefault { -u64 page_addr; -u32 asid; -u16 pdata; -u8 vfid; -u8 access_type; -u8 fault_type; -u8 fault_level; -u8 engine_class; -u8 engine_instance; -u8 fault_unsuccessful; -bool trva_fault; -}; - -enum access_type { -ACCESS_TYPE_READ =0 , -ACCESS_TYPE_WRITE =1 , -ACCESS_TYPE_ATOMIC =2 , -ACCESS_TYPE_RESERVED =3 , -}; - -enum fault_type { -NOT_PRESENT =0 , -WRITE_ACCESS_VIOLATION =1 , -ATOMIC_ACCESS_VIOLATION =2 , -}; - -struct acc { -u64 va_range_base; -u32 asid; -u32 sub_granularity; -u8 granularity; -u8 vfid; -u8 access_type; -u8 engine_class; -u8 engine_instance; -}; - -static bool access_is_atomic (enum access_type access_type) -{ -return access_type ==ACCESS_TYPE_ATOMIC ; -} - -static bool vma_is_valid (struct xe_tile *tile,struct xe_vma *vma) -{ -return xe_vm_has_valid_gpu_mapping (tile, vma->tile_present, - vma->tile_invalidated); -} - -static int xe_pf_begin (struct drm_exec *exec,struct xe_vma *vma, -bool need_vram_move,struct xe_vram_region *vram) -{ -struct xe_bo *bo =xe_vma_bo (vma); -struct xe_vm *vm =xe_vma_vm (vma); -int err; - - err =xe_vm_lock_vma (exec, vma); -if (err) -return err; - -if (!bo) -return 0 ; - -return need_vram_move ?xe_bo_migrate (bo, vram->placement,NULL , exec) : -xe_bo_validate (bo, vm, true, exec); -} - -static int handle_vma_pagefault (struct xe_gt *gt,struct xe_vma *vma, -bool atomic) -{ -struct xe_vm *vm =xe_vma_vm (vma); -struct xe_tile *tile =gt_to_tile (gt); -struct xe_validation_ctx ctx; -struct drm_exec exec; -struct dma_fence *fence; -int err, needs_vram; - -lockdep_assert_held_write (&vm->lock); - - needs_vram =xe_vma_need_vram_for_atomic (vm->xe, vma, atomic); -if (needs_vram <0 || (needs_vram &&xe_vma_is_userptr (vma))) -return needs_vram <0 ? needs_vram : -EACCES ; - -xe_gt_stats_incr (gt,XE_GT_STATS_ID_VMA_PAGEFAULT_COUNT ,1 ); -xe_gt_stats_incr (gt,XE_GT_STATS_ID_VMA_PAGEFAULT_KB ,xe_vma_size (vma) /1024 ); - -trace_xe_vma_pagefault (vma); - -/* Check if VMA is valid, opportunistic check only */ -if (vma_is_valid (tile, vma) && !atomic) -return 0 ; - -retry_userptr: -if (xe_vma_is_userptr (vma) && -xe_vma_userptr_check_repin (to_userptr_vma (vma))) { -struct xe_userptr_vma *uvma =to_userptr_vma (vma); - - err =xe_vma_userptr_pin_pages (uvma); -if (err) -return err; - } - -/* Lock VM and BOs dma-resv */ -xe_validation_ctx_init (&ctx, &vm->xe->val, &exec, (struct xe_val_flags ) {}); - drm_exec_until_all_locked(&exec) { - err =xe_pf_begin (&exec, vma, needs_vram ==1 , tile->mem.vram); -drm_exec_retry_on_contention (&exec); -xe_validation_retry_on_oom (&ctx, &err); -if (err) - goto unlock_dma_resv; - -/* Bind VMA only to the GT that has faulted */ -trace_xe_vma_pf_bind (vma); -xe_vm_set_validation_exec (vm, &exec); - fence =xe_vma_rebind (vm, vma,BIT (tile->id)); -xe_vm_set_validation_exec (vm,NULL ); -if (IS_ERR (fence)) { - err =PTR_ERR (fence); -xe_validation_retry_on_oom (&ctx, &err); - goto unlock_dma_resv; - } - } - -dma_fence_wait (fence, false); -dma_fence_put (fence); - -unlock_dma_resv: -xe_validation_ctx_fini (&ctx); -if (err == -EAGAIN ) - goto retry_userptr; - -return err; -} - -static struct xe_vm *asid_to_vm (struct xe_device *xe,u32 asid) -{ -struct xe_vm *vm; - -down_read (&xe->usm.lock); - vm =xa_load (&xe->usm.asid_to_vm, asid); -if (vm &&xe_vm_in_fault_mode (vm)) -xe_vm_get (vm); -else - vm =ERR_PTR (-EINVAL ); -up_read (&xe->usm.lock); - -return vm; -} - -static int handle_pagefault (struct xe_gt *gt,struct pagefault *pf) -{ -struct xe_device *xe =gt_to_xe (gt); -struct xe_vm *vm; -struct xe_vma *vma =NULL ; -int err; -bool atomic; - -/* SW isn't expected to handle TRTT faults */ -if (pf->trva_fault) -return -EFAULT ; - - vm =asid_to_vm (xe, pf->asid); -if (IS_ERR (vm)) -return PTR_ERR (vm); - -/* -* TODO: Change to read lock? Using write lock for simplicity. -*/ -down_write (&vm->lock); - -if (xe_vm_is_closed (vm)) { - err = -ENOENT ; - goto unlock_vm; - } - - vma =xe_vm_find_vma_by_addr (vm, pf->page_addr); -if (!vma) { - err = -EINVAL ; - goto unlock_vm; - } - - atomic =access_is_atomic (pf->access_type); - -if (xe_vma_is_cpu_addr_mirror (vma)) - err =xe_svm_handle_pagefault (vm, vma, gt, - pf->page_addr, atomic); -else - err =handle_vma_pagefault (gt, vma, atomic); - -unlock_vm: -if (!err) - vm->usm.last_fault_vma = vma; -up_write (&vm->lock); -xe_vm_put (vm); - -return err; -} - -static int send_pagefault_reply (struct xe_guc *guc, -struct xe_guc_pagefault_reply *reply) -{ -u32 action[] = { -XE_GUC_ACTION_PAGE_FAULT_RES_DESC , - reply->dw0, - reply->dw1, - }; - -return xe_guc_ct_send (&guc->ct, action,ARRAY_SIZE (action),0 ,0 ); -} - -static void print_pagefault (struct xe_gt *gt,struct pagefault *pf) -{ -xe_gt_dbg (gt,"\n\tASID: %d\n" -"\tVFID: %d\n" -"\tPDATA: 0x%04x\n" -"\tFaulted Address: 0x%08x%08x\n" -"\tFaultType: %d\n" -"\tAccessType: %d\n" -"\tFaultLevel: %d\n" -"\tEngineClass: %d %s\n" -"\tEngineInstance: %d\n" , - pf->asid, pf->vfid, pf->pdata,upper_32_bits (pf->page_addr), -lower_32_bits (pf->page_addr), - pf->fault_type, pf->access_type, pf->fault_level, - pf->engine_class,xe_hw_engine_class_to_str (pf->engine_class), - pf->engine_instance); -} - -#define PF_MSG_LEN_DW 4 - -static bool get_pagefault (struct pf_queue *pf_queue,struct pagefault *pf) -{ -const struct xe_guc_pagefault_desc *desc; -bool ret = false; - -spin_lock_irq (&pf_queue->lock); -if (pf_queue->tail != pf_queue->head) { - desc = (const struct xe_guc_pagefault_desc *) - (pf_queue->data + pf_queue->tail); - - pf->fault_level =FIELD_GET (PFD_FAULT_LEVEL , desc->dw0); - pf->trva_fault =FIELD_GET (XE2_PFD_TRVA_FAULT , desc->dw0); - pf->engine_class =FIELD_GET (PFD_ENG_CLASS , desc->dw0); - pf->engine_instance =FIELD_GET (PFD_ENG_INSTANCE , desc->dw0); - pf->pdata =FIELD_GET (PFD_PDATA_HI , desc->dw1) << -PFD_PDATA_HI_SHIFT ; - pf->pdata |=FIELD_GET (PFD_PDATA_LO , desc->dw0); - pf->asid =FIELD_GET (PFD_ASID , desc->dw1); - pf->vfid =FIELD_GET (PFD_VFID , desc->dw2); - pf->access_type =FIELD_GET (PFD_ACCESS_TYPE , desc->dw2); - pf->fault_type =FIELD_GET (PFD_FAULT_TYPE , desc->dw2); - pf->page_addr = (u64)(FIELD_GET (PFD_VIRTUAL_ADDR_HI , desc->dw3)) << -PFD_VIRTUAL_ADDR_HI_SHIFT ; - pf->page_addr |=FIELD_GET (PFD_VIRTUAL_ADDR_LO , desc->dw2) << -PFD_VIRTUAL_ADDR_LO_SHIFT ; - - pf_queue->tail = (pf_queue->tail +PF_MSG_LEN_DW ) % - pf_queue->num_dw; - ret = true; - } -spin_unlock_irq (&pf_queue->lock); - -return ret; -} - -static bool pf_queue_full (struct pf_queue *pf_queue) -{ -lockdep_assert_held (&pf_queue->lock); - -return CIRC_SPACE (pf_queue->head, pf_queue->tail, - pf_queue->num_dw) <= -PF_MSG_LEN_DW ; -} - -int xe_guc_pagefault_handler (struct xe_guc *guc,u32 *msg,u32 len) -{ -struct xe_gt *gt =guc_to_gt (guc); -struct pf_queue *pf_queue; -unsigned long flags; -u32 asid; -bool full; - -if (unlikely (len !=PF_MSG_LEN_DW )) -return -EPROTO ; - - asid =FIELD_GET (PFD_ASID , msg[1 ]); - pf_queue = gt->usm.pf_queue + (asid %NUM_PF_QUEUE ); - -/* -* The below logic doesn't work unless PF_QUEUE_NUM_DW % PF_MSG_LEN_DW == 0 -*/ -xe_gt_assert (gt, !(pf_queue->num_dw %PF_MSG_LEN_DW )); - -spin_lock_irqsave (&pf_queue->lock, flags); - full =pf_queue_full (pf_queue); -if (!full) { -memcpy (pf_queue->data + pf_queue->head, msg, len *sizeof (u32)); - pf_queue->head = (pf_queue->head + len) % - pf_queue->num_dw; -queue_work (gt->usm.pf_wq, &pf_queue->worker); - }else { -xe_gt_warn (gt,"PageFault Queue full, shouldn't be possible\n" ); - } -spin_unlock_irqrestore (&pf_queue->lock, flags); - -return full ? -ENOSPC :0 ; -} - -#define USM_QUEUE_MAX_RUNTIME_MS 20 - -static void pf_queue_work_func (struct work_struct *w) -{ - struct pf_queue *pf_queue = container_of(w, struct pf_queue, worker); -struct xe_gt *gt = pf_queue->gt; -struct xe_guc_pagefault_reply reply = {}; -struct pagefault pf = {}; -unsigned long threshold; -int ret; - - threshold = jiffies +msecs_to_jiffies (USM_QUEUE_MAX_RUNTIME_MS ); - -while (get_pagefault (pf_queue, &pf)) { - ret =handle_pagefault (gt, &pf); -if (unlikely (ret)) { -print_pagefault (gt, &pf); - pf.fault_unsuccessful =1 ; -xe_gt_dbg (gt,"Fault response: Unsuccessful %pe\n" ,ERR_PTR (ret)); - } - - reply.dw0 =FIELD_PREP (PFR_VALID ,1 ) | -FIELD_PREP (PFR_SUCCESS , pf.fault_unsuccessful) | -FIELD_PREP (PFR_REPLY ,PFR_ACCESS ) | -FIELD_PREP (PFR_DESC_TYPE ,FAULT_RESPONSE_DESC ) | -FIELD_PREP (PFR_ASID , pf.asid); - - reply.dw1 =FIELD_PREP (PFR_VFID , pf.vfid) | -FIELD_PREP (PFR_ENG_INSTANCE , pf.engine_instance) | -FIELD_PREP (PFR_ENG_CLASS , pf.engine_class) | -FIELD_PREP (PFR_PDATA , pf.pdata); - -send_pagefault_reply (>->uc.guc, &reply); - -if (time_after (jiffies, threshold) && - pf_queue->tail != pf_queue->head) { -queue_work (gt->usm.pf_wq, w); -break ; - } - } -} - -static void acc_queue_work_func (struct work_struct *w); - -static void pagefault_fini (void *arg) -{ -struct xe_gt *gt = arg; -struct xe_device *xe =gt_to_xe (gt); - -if (!xe->info.has_usm) -return ; - -destroy_workqueue (gt->usm.acc_wq); -destroy_workqueue (gt->usm.pf_wq); -} - -static int xe_alloc_pf_queue (struct xe_gt *gt,struct pf_queue *pf_queue) -{ -struct xe_device *xe =gt_to_xe (gt); -xe_dss_mask_t all_dss; -int num_dss, num_eus; - -bitmap_or (all_dss, gt->fuse_topo.g_dss_mask, gt->fuse_topo.c_dss_mask, -XE_MAX_DSS_FUSE_BITS ); - - num_dss =bitmap_weight (all_dss,XE_MAX_DSS_FUSE_BITS ); - num_eus =bitmap_weight (gt->fuse_topo.eu_mask_per_dss, -XE_MAX_EU_FUSE_BITS ) * num_dss; - -/* -* user can issue separate page faults per EU and per CS -* -* XXX: Multiplier required as compute UMD are getting PF queue errors -* without it. Follow on why this multiplier is required. -*/ -#define PF_MULTIPLIER 8 - pf_queue->num_dw = - (num_eus +XE_NUM_HW_ENGINES ) *PF_MSG_LEN_DW *PF_MULTIPLIER ; - pf_queue->num_dw =roundup_pow_of_two (pf_queue->num_dw); -#undef PF_MULTIPLIER - - pf_queue->gt = gt; - pf_queue->data =devm_kcalloc (xe->drm.dev, pf_queue->num_dw, -sizeof (u32),GFP_KERNEL ); -if (!pf_queue->data) -return -ENOMEM ; - -spin_lock_init (&pf_queue->lock); -INIT_WORK (&pf_queue->worker, pf_queue_work_func); - -return 0 ; -} - -int xe_gt_pagefault_init (struct xe_gt *gt) -{ -struct xe_device *xe =gt_to_xe (gt); -int i, ret =0 ; - -if (!xe->info.has_usm) -return 0 ; - -for (i =0 ; i <NUM_PF_QUEUE ; ++i) { - ret =xe_alloc_pf_queue (gt, >->usm.pf_queue[i]); -if (ret) -return ret; - } -for (i =0 ; i <NUM_ACC_QUEUE ; ++i) { - gt->usm.acc_queue[i].gt = gt; -spin_lock_init (>->usm.acc_queue[i].lock); -INIT_WORK (>->usm.acc_queue[i].worker, acc_queue_work_func); - } - - gt->usm.pf_wq =alloc_workqueue ("xe_gt_page_fault_work_queue" , -WQ_UNBOUND |WQ_HIGHPRI ,NUM_PF_QUEUE ); -if (!gt->usm.pf_wq) -return -ENOMEM ; - - gt->usm.acc_wq =alloc_workqueue ("xe_gt_access_counter_work_queue" , -WQ_UNBOUND |WQ_HIGHPRI , -NUM_ACC_QUEUE ); -if (!gt->usm.acc_wq) { -destroy_workqueue (gt->usm.pf_wq); -return -ENOMEM ; - } - -return devm_add_action_or_reset (xe->drm.dev, pagefault_fini, gt); -} - -void xe_gt_pagefault_reset (struct xe_gt *gt) -{ -struct xe_device *xe =gt_to_xe (gt); -int i; - -if (!xe->info.has_usm) -return ; - -for (i =0 ; i <NUM_PF_QUEUE ; ++i) { -spin_lock_irq (>->usm.pf_queue[i].lock); - gt->usm.pf_queue[i].head =0 ; - gt->usm.pf_queue[i].tail =0 ; -spin_unlock_irq (>->usm.pf_queue[i].lock); - } - -for (i =0 ; i <NUM_ACC_QUEUE ; ++i) { -spin_lock (>->usm.acc_queue[i].lock); - gt->usm.acc_queue[i].head =0 ; - gt->usm.acc_queue[i].tail =0 ; -spin_unlock (>->usm.acc_queue[i].lock); - } -} - -static int granularity_in_byte (int val) -{ -switch (val) { -case 0 : -return SZ_128K ; -case 1 : -return SZ_2M ; -case 2 : -return SZ_16M ; -case 3 : -return SZ_64M ; -default : -return 0 ; - } -} - -static int sub_granularity_in_byte (int val) -{ -return (granularity_in_byte (val) /32 ); -} - -static void print_acc (struct xe_gt *gt,struct acc *acc) -{ -xe_gt_warn (gt,"Access counter request:\n" -"\tType: %s\n" -"\tASID: %d\n" -"\tVFID: %d\n" -"\tEngine: %d:%d\n" -"\tGranularity: 0x%x KB Region/ %d KB sub-granularity\n" -"\tSub_Granularity Vector: 0x%08x\n" -"\tVA Range base: 0x%016llx\n" , - acc->access_type ?"AC_NTFY_VAL" :"AC_TRIG_VAL" , - acc->asid, acc->vfid, acc->engine_class, acc->engine_instance, -granularity_in_byte (acc->granularity) /SZ_1K , -sub_granularity_in_byte (acc->granularity) /SZ_1K , - acc->sub_granularity, acc->va_range_base); -} - -static struct xe_vma *get_acc_vma (struct xe_vm *vm,struct acc *acc) -{ -u64 page_va = acc->va_range_base + (ffs (acc->sub_granularity) -1 ) * -sub_granularity_in_byte (acc->granularity); - -return xe_vm_find_overlapping_vma (vm, page_va,SZ_4K ); -} - -static int handle_acc (struct xe_gt *gt,struct acc *acc) -{ -struct xe_device *xe =gt_to_xe (gt); -struct xe_tile *tile =gt_to_tile (gt); -struct xe_validation_ctx ctx; -struct drm_exec exec; -struct xe_vm *vm; -struct xe_vma *vma; -int ret =0 ; - -/* We only support ACC_TRIGGER at the moment */ -if (acc->access_type !=ACC_TRIGGER ) -return -EINVAL ; - - vm =asid_to_vm (xe, acc->asid); -if (IS_ERR (vm)) -return PTR_ERR (vm); - -down_read (&vm->lock); - -/* Lookup VMA */ - vma =get_acc_vma (vm, acc); -if (!vma) { - ret = -EINVAL ; - goto unlock_vm; - } - -trace_xe_vma_acc (vma); - -/* Userptr or null can't be migrated, nothing to do */ -if (xe_vma_has_no_bo (vma)) - goto unlock_vm; - -/* Lock VM and BOs dma-resv */ -xe_validation_ctx_init (&ctx, &vm->xe->val, &exec, (struct xe_val_flags ) {}); - drm_exec_until_all_locked(&exec) { - ret =xe_pf_begin (&exec, vma,IS_DGFX (vm->xe), tile->mem.vram); -drm_exec_retry_on_contention (&exec); -xe_validation_retry_on_oom (&ctx, &ret); - } - -xe_validation_ctx_fini (&ctx); -unlock_vm: -up_read (&vm->lock); -xe_vm_put (vm); - -return ret; -} - -#define make_u64 (hi__, low__) ((u64)(hi__) << 32 | (u64)(low__)) - -#define ACC_MSG_LEN_DW 4 - -static bool get_acc (struct acc_queue *acc_queue,struct acc *acc) -{ -const struct xe_guc_acc_desc *desc; -bool ret = false; - -spin_lock (&acc_queue->lock); -if (acc_queue->tail != acc_queue->head) { - desc = (const struct xe_guc_acc_desc *) - (acc_queue->data + acc_queue->tail); - - acc->granularity =FIELD_GET (ACC_GRANULARITY , desc->dw2); - acc->sub_granularity =FIELD_GET (ACC_SUBG_HI , desc->dw1) <<31 | -FIELD_GET (ACC_SUBG_LO , desc->dw0); - acc->engine_class =FIELD_GET (ACC_ENG_CLASS , desc->dw1); - acc->engine_instance =FIELD_GET (ACC_ENG_INSTANCE , desc->dw1); - acc->asid =FIELD_GET (ACC_ASID , desc->dw1); - acc->vfid =FIELD_GET (ACC_VFID , desc->dw2); - acc->access_type =FIELD_GET (ACC_TYPE , desc->dw0); - acc->va_range_base =make_u64 (desc->dw3 &ACC_VIRTUAL_ADDR_RANGE_HI , - desc->dw2 &ACC_VIRTUAL_ADDR_RANGE_LO ); - - acc_queue->tail = (acc_queue->tail +ACC_MSG_LEN_DW ) % -ACC_QUEUE_NUM_DW ; - ret = true; - } -spin_unlock (&acc_queue->lock); - -return ret; -} - -static void acc_queue_work_func (struct work_struct *w) -{ - struct acc_queue *acc_queue = container_of(w, struct acc_queue, worker); -struct xe_gt *gt = acc_queue->gt; -struct acc acc = {}; -unsigned long threshold; -int ret; - - threshold = jiffies +msecs_to_jiffies (USM_QUEUE_MAX_RUNTIME_MS ); - -while (get_acc (acc_queue, &acc)) { - ret =handle_acc (gt, &acc); -if (unlikely (ret)) { -print_acc (gt, &acc); -xe_gt_warn (gt,"ACC: Unsuccessful %pe\n" ,ERR_PTR (ret)); - } - -if (time_after (jiffies, threshold) && - acc_queue->tail != acc_queue->head) { -queue_work (gt->usm.acc_wq, w); -break ; - } - } -} - -static bool acc_queue_full (struct acc_queue *acc_queue) -{ -lockdep_assert_held (&acc_queue->lock); - -return CIRC_SPACE (acc_queue->head, acc_queue->tail,ACC_QUEUE_NUM_DW ) <= -ACC_MSG_LEN_DW ; -} - -int xe_guc_access_counter_notify_handler (struct xe_guc *guc,u32 *msg,u32 len) -{ -struct xe_gt *gt =guc_to_gt (guc); -struct acc_queue *acc_queue; -u32 asid; -bool full; - -/* -* The below logic doesn't work unless ACC_QUEUE_NUM_DW % ACC_MSG_LEN_DW == 0 -*/ -BUILD_BUG_ON (ACC_QUEUE_NUM_DW %ACC_MSG_LEN_DW ); - -if (unlikely (len !=ACC_MSG_LEN_DW )) -return -EPROTO ; - - asid =FIELD_GET (ACC_ASID , msg[1 ]); - acc_queue = >->usm.acc_queue[asid %NUM_ACC_QUEUE ]; - -spin_lock (&acc_queue->lock); - full =acc_queue_full (acc_queue); -if (!full) { -memcpy (acc_queue->data + acc_queue->head, msg, - len *sizeof (u32)); - acc_queue->head = (acc_queue->head + len) %ACC_QUEUE_NUM_DW ; -queue_work (gt->usm.acc_wq, &acc_queue->worker); - }else { -xe_gt_warn (gt,"ACC Queue full, dropping ACC\n" ); - } -spin_unlock (&acc_queue->lock); - -return full ? -ENOSPC :0 ; -}
drivers/gpu/drm/xe/xe_gt_pagefault.h deleted +0 -19
@@ -1,19 +0,0 @@ -/* SPDX-License-Identifier: MIT */ -/* -* Copyright © 2022 Intel Corporation -*/ - -#ifndef _XE_GT_PAGEFAULT_H_ -#define _XE_GT_PAGEFAULT_H_ - -#include <linux/types.h> - -struct xe_gt ; -struct xe_guc ; - -int xe_gt_pagefault_init (struct xe_gt *gt); -void xe_gt_pagefault_reset (struct xe_gt *gt); -int xe_guc_pagefault_handler (struct xe_guc *guc,u32 *msg,u32 len); -int xe_guc_access_counter_notify_handler (struct xe_guc *guc,u32 *msg,u32 len); - -#endif /* _XE_GT_PAGEFAULT_ */
drivers/gpu/drm/xe/xe_gt_types.h +0 -65
71 lines not on this page · raw message
Signature · 1 line
2.34.1
Re: [PATCH v4 7/7] drm/xe: Remove unused GT page fault code
Quoted 5 lines · Matthew Brost
With the Xe page fault layer and GuC page layer in place, this is now dead code and can be removed. ACC code is also removed, but this was dead code.
Signed-off-by Matthew Brost <[email protected]>
with the additional explanation about acc to be added here,
thanks
Lucas De Marchi
Patchwork
CI✗ CI.checkpatch: warning for Pagefault refactor (rev3)
In reply to Matthew Brost== Series Details ==
== Series Details ==
Series: Pagefault refactor (rev3)
URL : https://patchwork.freedesktop.org/series/156508/
State : warning
== Summary ==
+ KERNEL=/kernel
+ git clone https://gitlab.freedesktop.org/drm/maintainer-tools mt Cloning into 'mt'...
warning: redirecting to https://gitlab.freedesktop.org/drm/maintainer-tools.git/
+ git -C mt rev-list -n1 origin/master f867e605613af1770f90c4b0afd4a8f06424d1f0
+ cd /kernel
+ git config --global --add safe.directory /kernel
+ git log -n1
commit 2162de6216f26c7494498a52f61ed186dd306359
Author: Matthew Brost <[email protected]> Date: Fri Oct 31 09:54:16 2025 -0700
drm/xe: Remove unused GT page fault code
With the Xe page fault layer and GuC page layer in place, this is now dead code and can be removed. ACC code is also removed, but this was dead code.
+ /mt/dim checkpatch ace589a8065460626a9c37fb770cd5a31e6643b9 drm-intel 7a0cf7403398 drm/xe: Stub out new pagefault layer
-:34: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating? #34:
new file mode 100644
total: 0 errors, 1 warnings, 0 checks, 227 lines checked6420e7966fb8 drm/xe: Implement xe_pagefault_initd4cd7b8855af drm/xe: Implement xe_pagefault_resetc62debf9effe drm/xe: Implement xe_pagefault_handler09c0eba0d93b drm/xe: Implement xe_pagefault_queue_worke32f154b3063 drm/xe: Add xe_guc_pagefault layer
-:98: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating? #98:
new file mode 100644
total: 0 errors, 1 warnings, 0 checks, 187 lines checked2162de6216f2 drm/xe: Remove unused GT page fault code
-:13: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating? #13:
deleted file mode 100644
total: 0 errors, 1 warnings, 0 checks, 71 lines checked
Patchwork
CI✓ CI.KUnit: success for Pagefault refactor (rev3)
In reply to Matthew Brost== Series Details ==
== Series Details ==
Series: Pagefault refactor (rev3)
URL : https://patchwork.freedesktop.org/series/156508/
State : success
== Summary ==
+ trap cleanup EXIT
+ /kernel/tools/testing/kunit/kunit.py run --kunitconfig /kernel/drivers/gpu/drm/xe/.kunitconfig [18:00:21] Configuring KUnit Kernel ...
Generating .config ...
Populating config with:
$ make ARCH=um O=.kunit olddefconfig [18:00:26] Building KUnit Kernel ... Populating config with: $ make ARCH=um O=.kunit olddefconfig Building with: $ make all compile_commands.json scripts_gdb ARCH=um O=.kunit --jobs=48 [18:00:56] Starting KUnit Kernel (1/1)... [18:00:56] ============================================================ Running tests with: $ .kunit/linux kunit.enable=1 mem=1G console=tty kunit_shutdown=halt [18:00:57] ================== guc_buf (11 subtests) =================== [18:00:57] [PASSED] test_smallest [18:00:57] [PASSED] test_largest [18:00:57] [PASSED] test_granular [18:00:57] [PASSED] test_unique [18:00:57] [PASSED] test_overlap [18:00:57] [PASSED] test_reusable [18:00:57] [PASSED] test_too_big [18:00:57] [PASSED] test_flush [18:00:57] [PASSED] test_lookup [18:00:57] [PASSED] test_data [18:00:57] [PASSED] test_class [18:00:57] ===================== [PASSED] guc_buf ===================== [18:00:57] =================== guc_dbm (7 subtests) =================== [18:00:57] [PASSED] test_empty [18:00:57] [PASSED] test_default [18:00:57] ======================== test_size ======================== [18:00:57] [PASSED] 4 [18:00:57] [PASSED] 8 [18:00:57] [PASSED] 32 [18:00:57] [PASSED] 256 [18:00:57] ==================== [PASSED] test_size ==================== [18:00:57] ======================= test_reuse ======================== [18:00:57] [PASSED] 4 [18:00:57] [PASSED] 8 [18:00:57] [PASSED] 32 [18:00:57] [PASSED] 256 [18:00:57] =================== [PASSED] test_reuse ==================== [18:00:57] =================== test_range_overlap ==================== [18:00:57] [PASSED] 4 [18:00:57] [PASSED] 8 [18:00:57] [PASSED] 32 [18:00:57] [PASSED] 256 [18:00:57] =============== [PASSED] test_range_overlap ================ [18:00:57] =================== test_range_compact ==================== [18:00:57] [PASSED] 4 [18:00:57] [PASSED] 8 [18:00:57] [PASSED] 32 [18:00:57] [PASSED] 256 [18:00:57] =============== [PASSED] test_range_compact ================ [18:00:57] ==================== test_range_spare ===================== [18:00:57] [PASSED] 4 [18:00:57] [PASSED] 8 [18:00:57] [PASSED] 32 [18:00:57] [PASSED] 256 [18:00:57] ================ [PASSED] test_range_spare ================= [18:00:57] ===================== [PASSED] guc_dbm ===================== [18:00:57] =================== guc_idm (6 subtests) =================== [18:00:57] [PASSED] bad_init [18:00:57] [PASSED] no_init [18:00:57] [PASSED] init_fini [18:00:57] [PASSED] check_used [18:00:57] [PASSED] check_quota [18:00:57] [PASSED] check_all [18:00:57] ===================== [PASSED] guc_idm ===================== [18:00:57] ================== no_relay (3 subtests) =================== [18:00:57] [PASSED] xe_drops_guc2pf_if_not_ready [18:00:57] [PASSED] xe_drops_guc2vf_if_not_ready [18:00:57] [PASSED] xe_rejects_send_if_not_ready [18:00:57] ==================== [PASSED] no_relay ===================== [18:00:57] ================== pf_relay (14 subtests) ================== [18:00:57] [PASSED] pf_rejects_guc2pf_too_short [18:00:57] [PASSED] pf_rejects_guc2pf_too_long [18:00:57] [PASSED] pf_rejects_guc2pf_no_payload [18:00:57] [PASSED] pf_fails_no_payload [18:00:57] [PASSED] pf_fails_bad_origin [18:00:57] [PASSED] pf_fails_bad_type [18:00:57] [PASSED] pf_txn_reports_error [18:00:57] [PASSED] pf_txn_sends_pf2guc [18:00:57] [PASSED] pf_sends_pf2guc [18:00:57] [SKIPPED] pf_loopback_nop [18:00:57] [SKIPPED] pf_loopback_echo [18:00:57] [SKIPPED] pf_loopback_fail [18:00:57] [SKIPPED] pf_loopback_busy [18:00:57] [SKIPPED] pf_loopback_retry [18:00:57] ==================== [PASSED] pf_relay ===================== [18:00:57] ================== vf_relay (3 subtests) =================== [18:00:57] [PASSED] vf_rejects_guc2vf_too_short [18:00:57] [PASSED] vf_rejects_guc2vf_too_long [18:00:57] [PASSED] vf_rejects_guc2vf_no_payload [18:00:57] ==================== [PASSED] vf_relay ===================== [18:00:57] ===================== lmtt (1 subtest) ===================== [18:00:57] ======================== test_ops ========================= [18:00:57] [PASSED] 2-level [18:00:57] [PASSED] multi-level [18:00:57] ==================== [PASSED] test_ops ===================== [18:00:57] ====================== [PASSED] lmtt ======================= [18:00:57] ================= pf_service (11 subtests) ================= [18:00:57] [PASSED] pf_negotiate_any [18:00:57] [PASSED] pf_negotiate_base_match [18:00:57] [PASSED] pf_negotiate_base_newer [18:00:57] [PASSED] pf_negotiate_base_next [18:00:57] [SKIPPED] pf_negotiate_base_older [18:00:57] [PASSED] pf_negotiate_base_prev [18:00:57] [PASSED] pf_negotiate_latest_match [18:00:57] [PASSED] pf_negotiate_latest_newer [18:00:57] [PASSED] pf_negotiate_latest_next [18:00:57] [SKIPPED] pf_negotiate_latest_older [18:00:57] [SKIPPED] pf_negotiate_latest_prev [18:00:57] =================== [PASSED] pf_service ==================== [18:00:57] ================= xe_guc_g2g (2 subtests) ================== [18:00:57] ============== xe_live_guc_g2g_kunit_default ============== [18:00:57] ========= [SKIPPED] xe_live_guc_g2g_kunit_default ========== [18:00:57] ============== xe_live_guc_g2g_kunit_allmem =============== [18:00:57] ========== [SKIPPED] xe_live_guc_g2g_kunit_allmem ========== [18:00:57] =================== [SKIPPED] xe_guc_g2g =================== [18:00:57] =================== xe_mocs (2 subtests) =================== [18:00:57] ================ xe_live_mocs_kernel_kunit ================ [18:00:57] =========== [SKIPPED] xe_live_mocs_kernel_kunit ============ [18:00:57] ================ xe_live_mocs_reset_kunit ================= [18:00:57] ============ [SKIPPED] xe_live_mocs_reset_kunit ============ [18:00:57] ==================== [SKIPPED] xe_mocs ===================== [18:00:57] ================= xe_migrate (2 subtests) ================== [18:00:57] ================= xe_migrate_sanity_kunit ================= [18:00:57] ============ [SKIPPED] xe_migrate_sanity_kunit ============= [18:00:57] ================== xe_validate_ccs_kunit ================== [18:00:57] ============= [SKIPPED] xe_validate_ccs_kunit ============== [18:00:57] =================== [SKIPPED] xe_migrate =================== [18:00:57] ================== xe_dma_buf (1 subtest) ================== [18:00:57] ==================== xe_dma_buf_kunit ===================== [18:00:57] ================ [SKIPPED] xe_dma_buf_kunit ================ [18:00:57] =================== [SKIPPED] xe_dma_buf =================== [18:00:57] ================= xe_bo_shrink (1 subtest) ================= [18:00:57] =================== xe_bo_shrink_kunit ==================== [18:00:57] =============== [SKIPPED] xe_bo_shrink_kunit =============== [18:00:57] ================== [SKIPPED] xe_bo_shrink ================== [18:00:57] ==================== xe_bo (2 subtests) ==================== [18:00:57] ================== xe_ccs_migrate_kunit =================== [18:00:57] ============== [SKIPPED] xe_ccs_migrate_kunit ============== [18:00:57] ==================== xe_bo_evict_kunit ==================== [18:00:57] =============== [SKIPPED] xe_bo_evict_kunit ================ [18:00:57] ===================== [SKIPPED] xe_bo ====================== [18:00:57] ==================== args (11 subtests) ==================== [18:00:57] [PASSED] count_args_test [18:00:57] [PASSED] call_args_example [18:00:57] [PASSED] call_args_test [18:00:57] [PASSED] drop_first_arg_example [18:00:57] [PASSED] drop_first_arg_test [18:00:57] [PASSED] first_arg_example [18:00:57] [PASSED] first_arg_test [18:00:57] [PASSED] last_arg_example [18:00:57] [PASSED] last_arg_test [18:00:57] [PASSED] pick_arg_example [18:00:57] [PASSED] sep_comma_example [18:00:57] ====================== [PASSED] args ======================= [18:00:57] =================== xe_pci (3 subtests) ==================== [18:00:57] ==================== check_graphics_ip ==================== [18:00:57] [PASSED] 12.00 Xe_LP [18:00:57] [PASSED] 12.10 Xe_LP+ [18:00:57] [PASSED] 12.55 Xe_HPG [18:00:57] [PASSED] 12.60 Xe_HPC [18:00:57] [PASSED] 12.70 Xe_LPG [18:00:57] [PASSED] 12.71 Xe_LPG [18:00:57] [PASSED] 12.74 Xe_LPG+ [18:00:57] [PASSED] 20.01 Xe2_HPG [18:00:57] [PASSED] 20.02 Xe2_HPG [18:00:57] [PASSED] 20.04 Xe2_LPG [18:00:57] [PASSED] 30.00 Xe3_LPG [18:00:57] [PASSED] 30.01 Xe3_LPG [18:00:57] [PASSED] 30.03 Xe3_LPG [18:00:57] [PASSED] 30.04 Xe3_LPG [18:00:57] [PASSED] 30.05 Xe3_LPG [18:00:57] [PASSED] 35.11 Xe3p_XPC [18:00:57] ================ [PASSED] check_graphics_ip ================ [18:00:57] ===================== check_media_ip ====================== [18:00:57] [PASSED] 12.00 Xe_M [18:00:57] [PASSED] 12.55 Xe_HPM [18:00:57] [PASSED] 13.00 Xe_LPM+ [18:00:57] [PASSED] 13.01 Xe2_HPM [18:00:57] [PASSED] 20.00 Xe2_LPM [18:00:57] [PASSED] 30.00 Xe3_LPM [18:00:57] [PASSED] 30.02 Xe3_LPM [18:00:57] [PASSED] 35.00 Xe3p_LPM [18:00:57] [PASSED] 35.03 Xe3p_HPM [18:00:57] ================= [PASSED] check_media_ip ================== [18:00:57] =================== check_platform_desc =================== [18:00:57] [PASSED] 0x9A60 (TIGERLAKE) [18:00:57] [PASSED] 0x9A68 (TIGERLAKE) [18:00:57] [PASSED] 0x9A70 (TIGERLAKE) [18:00:57] [PASSED] 0x9A40 (TIGERLAKE) [18:00:57] [PASSED] 0x9A49 (TIGERLAKE) [18:00:57] [PASSED] 0x9A59 (TIGERLAKE) [18:00:57] [PASSED] 0x9A78 (TIGERLAKE) [18:00:57] [PASSED] 0x9AC0 (TIGERLAKE) [18:00:57] [PASSED] 0x9AC9 (TIGERLAKE) [18:00:57] [PASSED] 0x9AD9 (TIGERLAKE) [18:00:57] [PASSED] 0x9AF8 (TIGERLAKE) [18:00:57] [PASSED] 0x4C80 (ROCKETLAKE) [18:00:57] [PASSED] 0x4C8A (ROCKETLAKE) [18:00:57] [PASSED] 0x4C8B (ROCKETLAKE) [18:00:57] [PASSED] 0x4C8C (ROCKETLAKE) [18:00:57] [PASSED] 0x4C90 (ROCKETLAKE) [18:00:57] [PASSED] 0x4C9A (ROCKETLAKE) [18:00:57] [PASSED] 0x4680 (ALDERLAKE_S) [18:00:57] [PASSED] 0x4682 (ALDERLAKE_S) [18:00:57] [PASSED] 0x4688 (ALDERLAKE_S) [18:00:57] [PASSED] 0x468A (ALDERLAKE_S) [18:00:57] [PASSED] 0x468B (ALDERLAKE_S) [18:00:57] [PASSED] 0x4690 (ALDERLAKE_S) [18:00:57] [PASSED] 0x4692 (ALDERLAKE_S) [18:00:57] [PASSED] 0x4693 (ALDERLAKE_S) [18:00:57] [PASSED] 0x46A0 (ALDERLAKE_P) [18:00:57] [PASSED] 0x46A1 (ALDERLAKE_P) [18:00:57] [PASSED] 0x46A2 (ALDERLAKE_P) [18:00:57] [PASSED] 0x46A3 (ALDERLAKE_P) [18:00:57] [PASSED] 0x46A6 (ALDERLAKE_P) [18:00:57] [PASSED] 0x46A8 (ALDERLAKE_P) [18:00:57] [PASSED] 0x46AA (ALDERLAKE_P) [18:00:57] [PASSED] 0x462A (ALDERLAKE_P) [18:00:57] [PASSED] 0x4626 (ALDERLAKE_P) [18:00:57] [PASSED] 0x4628 (ALDERLAKE_P) [18:00:57] [PASSED] 0x46B0 (ALDERLAKE_P) [18:00:57] [PASSED] 0x46B1 (ALDERLAKE_P) [18:00:57] [PASSED] 0x46B2 (ALDERLAKE_P) [18:00:57] [PASSED] 0x46B3 (ALDERLAKE_P) [18:00:57] [PASSED] 0x46C0 (ALDERLAKE_P) [18:00:57] [PASSED] 0x46C1 (ALDERLAKE_P) [18:00:57] [PASSED] 0x46C2 (ALDERLAKE_P) [18:00:57] [PASSED] 0x46C3 (ALDERLAKE_P) [18:00:57] [PASSED] 0x46D0 (ALDERLAKE_N) [18:00:57] [PASSED] 0x46D1 (ALDERLAKE_N) [18:00:57] [PASSED] 0x46D2 (ALDERLAKE_N) [18:00:57] [PASSED] 0x46D3 (ALDERLAKE_N) [18:00:57] [PASSED] 0x46D4 (ALDERLAKE_N) [18:00:57] [PASSED] 0xA721 (ALDERLAKE_P) [18:00:57] [PASSED] 0xA7A1 (ALDERLAKE_P) [18:00:57] [PASSED] 0xA7A9 (ALDERLAKE_P) [18:00:57] [PASSED] 0xA7AC (ALDERLAKE_P) [18:00:57] [PASSED] 0xA7AD (ALDERLAKE_P) [18:00:57] [PASSED] 0xA720 (ALDERLAKE_P) [18:00:57] [PASSED] 0xA7A0 (ALDERLAKE_P) [18:00:57] [PASSED] 0xA7A8 (ALDERLAKE_P) [18:00:57] [PASSED] 0xA7AA (ALDERLAKE_P) [18:00:57] [PASSED] 0xA7AB (ALDERLAKE_P) [18:00:57] [PASSED] 0xA780 (ALDERLAKE_S) [18:00:57] [PASSED] 0xA781 (ALDERLAKE_S) [18:00:57] [PASSED] 0xA782 (ALDERLAKE_S) [18:00:57] [PASSED] 0xA783 (ALDERLAKE_S) [18:00:57] [PASSED] 0xA788 (ALDERLAKE_S) [18:00:57] [PASSED] 0xA789 (ALDERLAKE_S) [18:00:57] [PASSED] 0xA78A (ALDERLAKE_S) [18:00:57] [PASSED] 0xA78B (ALDERLAKE_S) [18:00:57] [PASSED] 0x4905 (DG1) [18:00:57] [PASSED] 0x4906 (DG1) [18:00:57] [PASSED] 0x4907 (DG1) [18:00:57] [PASSED] 0x4908 (DG1) [18:00:57] [PASSED] 0x4909 (DG1) [18:00:57] [PASSED] 0x56C0 (DG2) [18:00:57] [PASSED] 0x56C2 (DG2) [18:00:57] [PASSED] 0x56C1 (DG2) [18:00:57] [PASSED] 0x7D51 (METEORLAKE) [18:00:57] [PASSED] 0x7DD1 (METEORLAKE) [18:00:57] [PASSED] 0x7D41 (METEORLAKE) [18:00:57] [PASSED] 0x7D67 (METEORLAKE) [18:00:57] [PASSED] 0xB640 (METEORLAKE) [18:00:57] [PASSED] 0x56A0 (DG2) [18:00:57] [PASSED] 0x56A1 (DG2) [18:00:57] [PASSED] 0x56A2 (DG2) [18:00:57] [PASSED] 0x56BE (DG2) [18:00:57] [PASSED] 0x56BF (DG2) [18:00:57] [PASSED] 0x5690 (DG2) [18:00:57] [PASSED] 0x5691 (DG2) [18:00:57] [PASSED] 0x5692 (DG2) [18:00:57] [PASSED] 0x56A5 (DG2) [18:00:57] [PASSED] 0x56A6 (DG2) [18:00:57] [PASSED] 0x56B0 (DG2) [18:00:57] [PASSED] 0x56B1 (DG2) [18:00:57] [PASSED] 0x56BA (DG2) [18:00:57] [PASSED] 0x56BB (DG2) [18:00:57] [PASSED] 0x56BC (DG2) [18:00:57] [PASSED] 0x56BD (DG2) [18:00:57] [PASSED] 0x5693 (DG2) [18:00:57] [PASSED] 0x5694 (DG2) [18:00:57] [PASSED] 0x5695 (DG2) [18:00:57] [PASSED] 0x56A3 (DG2) [18:00:57] [PASSED] 0x56A4 (DG2) [18:00:57] [PASSED] 0x56B2 (DG2) [18:00:57] [PASSED] 0x56B3 (DG2) [18:00:57] [PASSED] 0x5696 (DG2) [18:00:57] [PASSED] 0x5697 (DG2) [18:00:57] [PASSED] 0xB69 (PVC) [18:00:57] [PASSED] 0xB6E (PVC) [18:00:57] [PASSED] 0xBD4 (PVC) [18:00:57] [PASSED] 0xBD5 (PVC) [18:00:57] [PASSED] 0xBD6 (PVC) [18:00:57] [PASSED] 0xBD7 (PVC) [18:00:57] [PASSED] 0xBD8 (PVC) [18:00:57] [PASSED] 0xBD9 (PVC) [18:00:57] [PASSED] 0xBDA (PVC) [18:00:57] [PASSED] 0xBDB (PVC) [18:00:57] [PASSED] 0xBE0 (PVC) [18:00:57] [PASSED] 0xBE1 (PVC) [18:00:57] [PASSED] 0xBE5 (PVC) [18:00:57] [PASSED] 0x7D40 (METEORLAKE) [18:00:57] [PASSED] 0x7D45 (METEORLAKE) [18:00:57] [PASSED] 0x7D55 (METEORLAKE) [18:00:57] [PASSED] 0x7D60 (METEORLAKE) [18:00:57] [PASSED] 0x7DD5 (METEORLAKE) [18:00:57] [PASSED] 0x6420 (LUNARLAKE) [18:00:57] [PASSED] 0x64A0 (LUNARLAKE) [18:00:57] [PASSED] 0x64B0 (LUNARLAKE) [18:00:57] [PASSED] 0xE202 (BATTLEMAGE) [18:00:57] [PASSED] 0xE209 (BATTLEMAGE) [18:00:57] [PASSED] 0xE20B (BATTLEMAGE) [18:00:57] [PASSED] 0xE20C (BATTLEMAGE) [18:00:57] [PASSED] 0xE20D (BATTLEMAGE) [18:00:57] [PASSED] 0xE210 (BATTLEMAGE) [18:00:57] [PASSED] 0xE211 (BATTLEMAGE) [18:00:57] [PASSED] 0xE212 (BATTLEMAGE) [18:00:57] [PASSED] 0xE216 (BATTLEMAGE) [18:00:57] [PASSED] 0xE220 (BATTLEMAGE) [18:00:57] [PASSED] 0xE221 (BATTLEMAGE) [18:00:57] [PASSED] 0xE222 (BATTLEMAGE) [18:00:57] [PASSED] 0xE223 (BATTLEMAGE) [18:00:57] [PASSED] 0xB080 (PANTHERLAKE) [18:00:57] [PASSED] 0xB081 (PANTHERLAKE) [18:00:57] [PASSED] 0xB082 (PANTHERLAKE) [18:00:57] [PASSED] 0xB083 (PANTHERLAKE) [18:00:57] [PASSED] 0xB084 (PANTHERLAKE) [18:00:57] [PASSED] 0xB085 (PANTHERLAKE) [18:00:57] [PASSED] 0xB086 (PANTHERLAKE) [18:00:57] [PASSED] 0xB087 (PANTHERLAKE) [18:00:57] [PASSED] 0xB08F (PANTHERLAKE) [18:00:57] [PASSED] 0xB090 (PANTHERLAKE) [18:00:57] [PASSED] 0xB0A0 (PANTHERLAKE) [18:00:57] [PASSED] 0xB0B0 (PANTHERLAKE) [18:00:57] [PASSED] 0xD740 (NOVALAKE_S) [18:00:57] [PASSED] 0xD741 (NOVALAKE_S) [18:00:57] [PASSED] 0xD742 (NOVALAKE_S) [18:00:57] [PASSED] 0xD743 (NOVALAKE_S) [18:00:57] [PASSED] 0xD744 (NOVALAKE_S) [18:00:57] [PASSED] 0xD745 (NOVALAKE_S) [18:00:57] [PASSED] 0x674C (CRESCENTISLAND) [18:00:57] [PASSED] 0xFD80 (PANTHERLAKE) [18:00:57] [PASSED] 0xFD81 (PANTHERLAKE) [18:00:57] =============== [PASSED] check_platform_desc =============== [18:00:57] ===================== [PASSED] xe_pci ====================== [18:00:57] =================== xe_rtp (2 subtests) ==================== [18:00:57] =============== xe_rtp_process_to_sr_tests ================ [18:00:57] [PASSED] coalesce-same-reg [18:00:57] [PASSED] no-match-no-add [18:00:57] [PASSED] match-or [18:00:57] [PASSED] match-or-xfail [18:00:57] [PASSED] no-match-no-add-multiple-rules [18:00:57] [PASSED] two-regs-two-entries [18:00:57] [PASSED] clr-one-set-other [18:00:57] [PASSED] set-field [18:00:57] [PASSED] conflict-duplicate [18:00:57] [PASSED] conflict-not-disjoint [18:00:57] [PASSED] conflict-reg-type [18:00:57] =========== [PASSED] xe_rtp_process_to_sr_tests ============ [18:00:57] ================== xe_rtp_process_tests =================== [18:00:57] [PASSED] active1 [18:00:57] [PASSED] active2 [18:00:57] [PASSED] active-inactive [18:00:57] [PASSED] inactive-active [18:00:57] [PASSED] inactive-1st_or_active-inactive [18:00:57] [PASSED] inactive-2nd_or_active-inactive [18:00:57] [PASSED] inactive-last_or_active-inactive stty: 'standard input': Inappropriate ioctl for device [18:00:57] [PASSED] inactive-no_or_active-inactive [18:00:57] ============== [PASSED] xe_rtp_process_tests =============== [18:00:57] ===================== [PASSED] xe_rtp ====================== [18:00:57] ==================== xe_wa (1 subtest) ===================== [18:00:57] ======================== xe_wa_gt ========================= [18:00:57] [PASSED] TIGERLAKE B0 [18:00:57] [PASSED] DG1 A0 [18:00:57] [PASSED] DG1 B0 [18:00:57] [PASSED] ALDERLAKE_S A0 [18:00:57] [PASSED] ALDERLAKE_S B0 [18:00:57] [PASSED] ALDERLAKE_S C0 [18:00:57] [PASSED] ALDERLAKE_S D0 [18:00:57] [PASSED] ALDERLAKE_P A0 [18:00:57] [PASSED] ALDERLAKE_P B0 [18:00:57] [PASSED] ALDERLAKE_P C0 [18:00:57] [PASSED] ALDERLAKE_S RPLS D0 [18:00:57] [PASSED] ALDERLAKE_P RPLU E0 [18:00:57] [PASSED] DG2 G10 C0 [18:00:57] [PASSED] DG2 G11 B1 [18:00:57] [PASSED] DG2 G12 A1 [18:00:57] [PASSED] METEORLAKE 12.70(Xe_LPG) A0 13.00(Xe_LPM+) A0 [18:00:57] [PASSED] METEORLAKE 12.71(Xe_LPG) A0 13.00(Xe_LPM+) A0 [18:00:57] [PASSED] METEORLAKE 12.74(Xe_LPG+) A0 13.00(Xe_LPM+) A0 [18:00:57] [PASSED] LUNARLAKE 20.04(Xe2_LPG) A0 20.00(Xe2_LPM) A0 [18:00:57] [PASSED] LUNARLAKE 20.04(Xe2_LPG) B0 20.00(Xe2_LPM) A0 [18:00:57] [PASSED] BATTLEMAGE 20.01(Xe2_HPG) A0 13.01(Xe2_HPM) A1 [18:00:57] [PASSED] PANTHERLAKE 30.00(Xe3_LPG) A0 30.00(Xe3_LPM) A0 [18:00:57] ==================== [PASSED] xe_wa_gt ===================== [18:00:57] ====================== [PASSED] xe_wa ====================== [18:00:57] ============================================================ [18:00:57] Testing complete. Ran 318 tests: passed: 300, skipped: 18 [18:00:57] Elapsed time: 35.328s total, 4.177s configuring, 30.785s building, 0.339s running
+ /kernel/tools/testing/kunit/kunit.py run --kunitconfig /kernel/drivers/gpu/drm/tests/.kunitconfig [18:00:57] Configuring KUnit Kernel ...
Regenerating .config ...
Populating config with:
$ make ARCH=um O=.kunit olddefconfig [18:00:58] Building KUnit Kernel ... Populating config with: $ make ARCH=um O=.kunit olddefconfig Building with: $ make all compile_commands.json scripts_gdb ARCH=um O=.kunit --jobs=48 [18:01:23] Starting KUnit Kernel (1/1)... [18:01:23] ============================================================ Running tests with: $ .kunit/linux kunit.enable=1 mem=1G console=tty kunit_shutdown=halt [18:01:23] ============ drm_test_pick_cmdline (2 subtests) ============ [18:01:23] [PASSED] drm_test_pick_cmdline_res_1920_1080_60 [18:01:23] =============== drm_test_pick_cmdline_named =============== [18:01:23] [PASSED] NTSC [18:01:23] [PASSED] NTSC-J [18:01:23] [PASSED] PAL [18:01:23] [PASSED] PAL-M [18:01:23] =========== [PASSED] drm_test_pick_cmdline_named =========== [18:01:23] ============== [PASSED] drm_test_pick_cmdline ============== [18:01:23] == drm_test_atomic_get_connector_for_encoder (1 subtest) === [18:01:23] [PASSED] drm_test_drm_atomic_get_connector_for_encoder [18:01:23] ==== [PASSED] drm_test_atomic_get_connector_for_encoder ==== [18:01:23] =========== drm_validate_clone_mode (2 subtests) =========== [18:01:23] ============== drm_test_check_in_clone_mode =============== [18:01:23] [PASSED] in_clone_mode [18:01:23] [PASSED] not_in_clone_mode [18:01:23] ========== [PASSED] drm_test_check_in_clone_mode =========== [18:01:23] =============== drm_test_check_valid_clones =============== [18:01:23] [PASSED] not_in_clone_mode [18:01:23] [PASSED] valid_clone [18:01:23] [PASSED] invalid_clone [18:01:23] =========== [PASSED] drm_test_check_valid_clones =========== [18:01:23] ============= [PASSED] drm_validate_clone_mode ============= [18:01:23] ============= drm_validate_modeset (1 subtest) ============= [18:01:23] [PASSED] drm_test_check_connector_changed_modeset [18:01:23] ============== [PASSED] drm_validate_modeset =============== [18:01:23] ====== drm_test_bridge_get_current_state (2 subtests) ====== [18:01:23] [PASSED] drm_test_drm_bridge_get_current_state_atomic [18:01:23] [PASSED] drm_test_drm_bridge_get_current_state_legacy [18:01:23] ======== [PASSED] drm_test_bridge_get_current_state ======== [18:01:23] ====== drm_test_bridge_helper_reset_crtc (3 subtests) ====== [18:01:23] [PASSED] drm_test_drm_bridge_helper_reset_crtc_atomic [18:01:23] [PASSED] drm_test_drm_bridge_helper_reset_crtc_atomic_disabled [18:01:23] [PASSED] drm_test_drm_bridge_helper_reset_crtc_legacy [18:01:23] ======== [PASSED] drm_test_bridge_helper_reset_crtc ======== [18:01:23] ============== drm_bridge_alloc (2 subtests) =============== [18:01:23] [PASSED] drm_test_drm_bridge_alloc_basic [18:01:23] [PASSED] drm_test_drm_bridge_alloc_get_put [18:01:23] ================ [PASSED] drm_bridge_alloc ================= [18:01:23] ================== drm_buddy (8 subtests) ================== [18:01:23] [PASSED] drm_test_buddy_alloc_limit [18:01:23] [PASSED] drm_test_buddy_alloc_optimistic [18:01:23] [PASSED] drm_test_buddy_alloc_pessimistic [18:01:23] [PASSED] drm_test_buddy_alloc_pathological [18:01:23] [PASSED] drm_test_buddy_alloc_contiguous [18:01:23] [PASSED] drm_test_buddy_alloc_clear [18:01:24] [PASSED] drm_test_buddy_alloc_range_bias [18:01:24] [PASSED] drm_test_buddy_fragmentation_performance [18:01:24] ==================== [PASSED] drm_buddy ==================== [18:01:24] ============= drm_cmdline_parser (40 subtests) ============= [18:01:24] [PASSED] drm_test_cmdline_force_d_only [18:01:24] [PASSED] drm_test_cmdline_force_D_only_dvi [18:01:24] [PASSED] drm_test_cmdline_force_D_only_hdmi [18:01:24] [PASSED] drm_test_cmdline_force_D_only_not_digital [18:01:24] [PASSED] drm_test_cmdline_force_e_only [18:01:24] [PASSED] drm_test_cmdline_res [18:01:24] [PASSED] drm_test_cmdline_res_vesa [18:01:24] [PASSED] drm_test_cmdline_res_vesa_rblank [18:01:24] [PASSED] drm_test_cmdline_res_rblank [18:01:24] [PASSED] drm_test_cmdline_res_bpp [18:01:24] [PASSED] drm_test_cmdline_res_refresh [18:01:24] [PASSED] drm_test_cmdline_res_bpp_refresh [18:01:24] [PASSED] drm_test_cmdline_res_bpp_refresh_interlaced [18:01:24] [PASSED] drm_test_cmdline_res_bpp_refresh_margins [18:01:24] [PASSED] drm_test_cmdline_res_bpp_refresh_force_off [18:01:24] [PASSED] drm_test_cmdline_res_bpp_refresh_force_on [18:01:24] [PASSED] drm_test_cmdline_res_bpp_refresh_force_on_analog [18:01:24] [PASSED] drm_test_cmdline_res_bpp_refresh_force_on_digital [18:01:24] [PASSED] drm_test_cmdline_res_bpp_refresh_interlaced_margins_force_on [18:01:24] [PASSED] drm_test_cmdline_res_margins_force_on [18:01:24] [PASSED] drm_test_cmdline_res_vesa_margins [18:01:24] [PASSED] drm_test_cmdline_name [18:01:24] [PASSED] drm_test_cmdline_name_bpp [18:01:24] [PASSED] drm_test_cmdline_name_option [18:01:24] [PASSED] drm_test_cmdline_name_bpp_option [18:01:24] [PASSED] drm_test_cmdline_rotate_0 [18:01:24] [PASSED] drm_test_cmdline_rotate_90 [18:01:24] [PASSED] drm_test_cmdline_rotate_180 [18:01:24] [PASSED] drm_test_cmdline_rotate_270 [18:01:24] [PASSED] drm_test_cmdline_hmirror [18:01:24] [PASSED] drm_test_cmdline_vmirror [18:01:24] [PASSED] drm_test_cmdline_margin_options [18:01:24] [PASSED] drm_test_cmdline_multiple_options [18:01:24] [PASSED] drm_test_cmdline_bpp_extra_and_option [18:01:24] [PASSED] drm_test_cmdline_extra_and_option [18:01:24] [PASSED] drm_test_cmdline_freestanding_options [18:01:24] [PASSED] drm_test_cmdline_freestanding_force_e_and_options [18:01:24] [PASSED] drm_test_cmdline_panel_orientation [18:01:24] ================ drm_test_cmdline_invalid ================= [18:01:24] [PASSED] margin_only [18:01:24] [PASSED] interlace_only [18:01:24] [PASSED] res_missing_x [18:01:24] [PASSED] res_missing_y [18:01:24] [PASSED] res_bad_y [18:01:24] [PASSED] res_missing_y_bpp [18:01:24] [PASSED] res_bad_bpp [18:01:24] [PASSED] res_bad_refresh [18:01:24] [PASSED] res_bpp_refresh_force_on_off [18:01:24] [PASSED] res_invalid_mode [18:01:24] [PASSED] res_bpp_wrong_place_mode [18:01:24] [PASSED] name_bpp_refresh [18:01:24] [PASSED] name_refresh [18:01:24] [PASSED] name_refresh_wrong_mode [18:01:24] [PASSED] name_refresh_invalid_mode [18:01:24] [PASSED] rotate_multiple [18:01:24] [PASSED] rotate_invalid_val [18:01:24] [PASSED] rotate_truncated [18:01:24] [PASSED] invalid_option [18:01:24] [PASSED] invalid_tv_option [18:01:24] [PASSED] truncated_tv_option [18:01:24] ============ [PASSED] drm_test_cmdline_invalid ============= [18:01:24] =============== drm_test_cmdline_tv_options =============== [18:01:24] [PASSED] NTSC [18:01:24] [PASSED] NTSC_443 [18:01:24] [PASSED] NTSC_J [18:01:24] [PASSED] PAL [18:01:24] [PASSED] PAL_M [18:01:24] [PASSED] PAL_N [18:01:24] [PASSED] SECAM [18:01:24] [PASSED] MONO_525 [18:01:24] [PASSED] MONO_625 [18:01:24] =========== [PASSED] drm_test_cmdline_tv_options =========== [18:01:24] =============== [PASSED] drm_cmdline_parser ================ [18:01:24] ========== drmm_connector_hdmi_init (20 subtests) ========== [18:01:24] [PASSED] drm_test_connector_hdmi_init_valid [18:01:24] [PASSED] drm_test_connector_hdmi_init_bpc_8 [18:01:24] [PASSED] drm_test_connector_hdmi_init_bpc_10 [18:01:24] [PASSED] drm_test_connector_hdmi_init_bpc_12 [18:01:24] [PASSED] drm_test_connector_hdmi_init_bpc_invalid [18:01:24] [PASSED] drm_test_connector_hdmi_init_bpc_null [18:01:24] [PASSED] drm_test_connector_hdmi_init_formats_empty [18:01:24] [PASSED] drm_test_connector_hdmi_init_formats_no_rgb [18:01:24] === drm_test_connector_hdmi_init_formats_yuv420_allowed === [18:01:24] [PASSED] supported_formats=0x9 yuv420_allowed=1 [18:01:24] [PASSED] supported_formats=0x9 yuv420_allowed=0 [18:01:24] [PASSED] supported_formats=0x3 yuv420_allowed=1 [18:01:24] [PASSED] supported_formats=0x3 yuv420_allowed=0 [18:01:24] === [PASSED] drm_test_connector_hdmi_init_formats_yuv420_allowed === [18:01:24] [PASSED] drm_test_connector_hdmi_init_null_ddc [18:01:24] [PASSED] drm_test_connector_hdmi_init_null_product [18:01:24] [PASSED] drm_test_connector_hdmi_init_null_vendor [18:01:24] [PASSED] drm_test_connector_hdmi_init_product_length_exact [18:01:24] [PASSED] drm_test_connector_hdmi_init_product_length_too_long [18:01:24] [PASSED] drm_test_connector_hdmi_init_product_valid [18:01:24] [PASSED] drm_test_connector_hdmi_init_vendor_length_exact [18:01:24] [PASSED] drm_test_connector_hdmi_init_vendor_length_too_long [18:01:24] [PASSED] drm_test_connector_hdmi_init_vendor_valid [18:01:24] ========= drm_test_connector_hdmi_init_type_valid ========= [18:01:24] [PASSED] HDMI-A [18:01:24] [PASSED] HDMI-B [18:01:24] ===== [PASSED] drm_test_connector_hdmi_init_type_valid ===== [18:01:24] ======== drm_test_connector_hdmi_init_type_invalid ======== [18:01:24] [PASSED] Unknown [18:01:24] [PASSED] VGA [18:01:24] [PASSED] DVI-I [18:01:24] [PASSED] DVI-D [18:01:24] [PASSED] DVI-A [18:01:24] [PASSED] Composite [18:01:24] [PASSED] SVIDEO [18:01:24] [PASSED] LVDS [18:01:24] [PASSED] Component [18:01:24] [PASSED] DIN [18:01:24] [PASSED] DP [18:01:24] [PASSED] TV [18:01:24] [PASSED] eDP [18:01:24] [PASSED] Virtual [18:01:24] [PASSED] DSI [18:01:24] [PASSED] DPI [18:01:24] [PASSED] Writeback [18:01:24] [PASSED] SPI [18:01:24] [PASSED] USB [18:01:24] ==== [PASSED] drm_test_connector_hdmi_init_type_invalid ==== [18:01:24] ============ [PASSED] drmm_connector_hdmi_init ============= [18:01:24] ============= drmm_connector_init (3 subtests) ============= [18:01:24] [PASSED] drm_test_drmm_connector_init [18:01:24] [PASSED] drm_test_drmm_connector_init_null_ddc [18:01:24] ========= drm_test_drmm_connector_init_type_valid ========= [18:01:24] [PASSED] Unknown [18:01:24] [PASSED] VGA [18:01:24] [PASSED] DVI-I [18:01:24] [PASSED] DVI-D [18:01:24] [PASSED] DVI-A [18:01:24] [PASSED] Composite [18:01:24] [PASSED] SVIDEO [18:01:24] [PASSED] LVDS [18:01:24] [PASSED] Component [18:01:24] [PASSED] DIN [18:01:24] [PASSED] DP [18:01:24] [PASSED] HDMI-A [18:01:24] [PASSED] HDMI-B [18:01:24] [PASSED] TV [18:01:24] [PASSED] eDP [18:01:24] [PASSED] Virtual [18:01:24] [PASSED] DSI [18:01:24] [PASSED] DPI [18:01:24] [PASSED] Writeback [18:01:24] [PASSED] SPI [18:01:24] [PASSED] USB [18:01:24] ===== [PASSED] drm_test_drmm_connector_init_type_valid ===== [18:01:24] =============== [PASSED] drmm_connector_init =============== [18:01:24] ========= drm_connector_dynamic_init (6 subtests) ========== [18:01:24] [PASSED] drm_test_drm_connector_dynamic_init [18:01:24] [PASSED] drm_test_drm_connector_dynamic_init_null_ddc [18:01:24] [PASSED] drm_test_drm_connector_dynamic_init_not_added [18:01:24] [PASSED] drm_test_drm_connector_dynamic_init_properties [18:01:24] ===== drm_test_drm_connector_dynamic_init_type_valid ====== [18:01:24] [PASSED] Unknown [18:01:24] [PASSED] VGA [18:01:24] [PASSED] DVI-I [18:01:24] [PASSED] DVI-D [18:01:24] [PASSED] DVI-A [18:01:24] [PASSED] Composite [18:01:24] [PASSED] SVIDEO [18:01:24] [PASSED] LVDS [18:01:24] [PASSED] Component [18:01:24] [PASSED] DIN [18:01:24] [PASSED] DP [18:01:24] [PASSED] HDMI-A [18:01:24] [PASSED] HDMI-B [18:01:24] [PASSED] TV [18:01:24] [PASSED] eDP [18:01:24] [PASSED] Virtual [18:01:24] [PASSED] DSI [18:01:24] [PASSED] DPI [18:01:24] [PASSED] Writeback [18:01:24] [PASSED] SPI [18:01:24] [PASSED] USB [18:01:24] = [PASSED] drm_test_drm_connector_dynamic_init_type_valid == [18:01:24] ======== drm_test_drm_connector_dynamic_init_name ========= [18:01:24] [PASSED] Unknown [18:01:24] [PASSED] VGA [18:01:24] [PASSED] DVI-I [18:01:24] [PASSED] DVI-D [18:01:24] [PASSED] DVI-A [18:01:24] [PASSED] Composite [18:01:24] [PASSED] SVIDEO [18:01:24] [PASSED] LVDS [18:01:24] [PASSED] Component [18:01:24] [PASSED] DIN [18:01:24] [PASSED] DP [18:01:24] [PASSED] HDMI-A [18:01:24] [PASSED] HDMI-B [18:01:24] [PASSED] TV [18:01:24] [PASSED] eDP [18:01:24] [PASSED] Virtual [18:01:24] [PASSED] DSI [18:01:24] [PASSED] DPI [18:01:24] [PASSED] Writeback [18:01:24] [PASSED] SPI [18:01:24] [PASSED] USB [18:01:24] ==== [PASSED] drm_test_drm_connector_dynamic_init_name ===== [18:01:24] =========== [PASSED] drm_connector_dynamic_init ============ [18:01:24] ==== drm_connector_dynamic_register_early (4 subtests) ===== [18:01:24] [PASSED] drm_test_drm_connector_dynamic_register_early_on_list [18:01:24] [PASSED] drm_test_drm_connector_dynamic_register_early_defer [18:01:24] [PASSED] drm_test_drm_connector_dynamic_register_early_no_init [18:01:24] [PASSED] drm_test_drm_connector_dynamic_register_early_no_mode_object [18:01:24] ====== [PASSED] drm_connector_dynamic_register_early ======= [18:01:24] ======= drm_connector_dynamic_register (7 subtests) ======== [18:01:24] [PASSED] drm_test_drm_connector_dynamic_register_on_list [18:01:24] [PASSED] drm_test_drm_connector_dynamic_register_no_defer [18:01:24] [PASSED] drm_test_drm_connector_dynamic_register_no_init [18:01:24] [PASSED] drm_test_drm_connector_dynamic_register_mode_object [18:01:24] [PASSED] drm_test_drm_connector_dynamic_register_sysfs [18:01:24] [PASSED] drm_test_drm_connector_dynamic_register_sysfs_name [18:01:24] [PASSED] drm_test_drm_connector_dynamic_register_debugfs [18:01:24] ========= [PASSED] drm_connector_dynamic_register ========== [18:01:24] = drm_connector_attach_broadcast_rgb_property (2 subtests) = [18:01:24] [PASSED] drm_test_drm_connector_attach_broadcast_rgb_property [18:01:24] [PASSED] drm_test_drm_connector_attach_broadcast_rgb_property_hdmi_connector [18:01:24] === [PASSED] drm_connector_attach_broadcast_rgb_property === [18:01:24] ========== drm_get_tv_mode_from_name (2 subtests) ========== [18:01:24] ========== drm_test_get_tv_mode_from_name_valid =========== [18:01:24] [PASSED] NTSC [18:01:24] [PASSED] NTSC-443 [18:01:24] [PASSED] NTSC-J [18:01:24] [PASSED] PAL [18:01:24] [PASSED] PAL-M [18:01:24] [PASSED] PAL-N [18:01:24] [PASSED] SECAM [18:01:24] [PASSED] Mono [18:01:24] ====== [PASSED] drm_test_get_tv_mode_from_name_valid ======= [18:01:24] [PASSED] drm_test_get_tv_mode_from_name_truncated [18:01:24] ============ [PASSED] drm_get_tv_mode_from_name ============ [18:01:24] = drm_test_connector_hdmi_compute_mode_clock (12 subtests) = [18:01:24] [PASSED] drm_test_drm_hdmi_compute_mode_clock_rgb [18:01:24] [PASSED] drm_test_drm_hdmi_compute_mode_clock_rgb_10bpc [18:01:24] [PASSED] drm_test_drm_hdmi_compute_mode_clock_rgb_10bpc_vic_1 [18:01:24] [PASSED] drm_test_drm_hdmi_compute_mode_clock_rgb_12bpc [18:01:24] [PASSED] drm_test_drm_hdmi_compute_mode_clock_rgb_12bpc_vic_1 [18:01:24] [PASSED] drm_test_drm_hdmi_compute_mode_clock_rgb_double [18:01:24] = drm_test_connector_hdmi_compute_mode_clock_yuv420_valid = [18:01:24] [PASSED] VIC 96 [18:01:24] [PASSED] VIC 97 [18:01:24] [PASSED] VIC 101 [18:01:24] [PASSED] VIC 102 [18:01:24] [PASSED] VIC 106 [18:01:24] [PASSED] VIC 107 [18:01:24] === [PASSED] drm_test_connector_hdmi_compute_mode_clock_yuv420_valid === [18:01:24] [PASSED] drm_test_connector_hdmi_compute_mode_clock_yuv420_10_bpc [18:01:24] [PASSED] drm_test_connector_hdmi_compute_mode_clock_yuv420_12_bpc [18:01:24] [PASSED] drm_test_connector_hdmi_compute_mode_clock_yuv422_8_bpc [18:01:24] [PASSED] drm_test_connector_hdmi_compute_mode_clock_yuv422_10_bpc [18:01:24] [PASSED] drm_test_connector_hdmi_compute_mode_clock_yuv422_12_bpc [18:01:24] === [PASSED] drm_test_connector_hdmi_compute_mode_clock ==== [18:01:24] == drm_hdmi_connector_get_broadcast_rgb_name (2 subtests) == [18:01:24] === drm_test_drm_hdmi_connector_get_broadcast_rgb_name ==== [18:01:24] [PASSED] Automatic [18:01:24] [PASSED] Full [18:01:24] [PASSED] Limited 16:235 [18:01:24] === [PASSED] drm_test_drm_hdmi_connector_get_broadcast_rgb_name === [18:01:24] [PASSED] drm_test_drm_hdmi_connector_get_broadcast_rgb_name_invalid [18:01:24] ==== [PASSED] drm_hdmi_connector_get_broadcast_rgb_name ==== [18:01:24] == drm_hdmi_connector_get_output_format_name (2 subtests) == [18:01:24] === drm_test_drm_hdmi_connector_get_output_format_name ==== [18:01:24] [PASSED] RGB [18:01:24] [PASSED] YUV 4:2:0 [18:01:24] [PASSED] YUV 4:2:2 [18:01:24] [PASSED] YUV 4:4:4 [18:01:24] === [PASSED] drm_test_drm_hdmi_connector_get_output_format_name === [18:01:24] [PASSED] drm_test_drm_hdmi_connector_get_output_format_name_invalid [18:01:24] ==== [PASSED] drm_hdmi_connector_get_output_format_name ==== [18:01:24] ============= drm_damage_helper (21 subtests) ============== [18:01:24] [PASSED] drm_test_damage_iter_no_damage [18:01:24] [PASSED] drm_test_damage_iter_no_damage_fractional_src [18:01:24] [PASSED] drm_test_damage_iter_no_damage_src_moved [18:01:24] [PASSED] drm_test_damage_iter_no_damage_fractional_src_moved [18:01:24] [PASSED] drm_test_damage_iter_no_damage_not_visible [18:01:24] [PASSED] drm_test_damage_iter_no_damage_no_crtc [18:01:24] [PASSED] drm_test_damage_iter_no_damage_no_fb [18:01:24] [PASSED] drm_test_damage_iter_simple_damage [18:01:24] [PASSED] drm_test_damage_iter_single_damage [18:01:24] [PASSED] drm_test_damage_iter_single_damage_intersect_src [18:01:24] [PASSED] drm_test_damage_iter_single_damage_outside_src [18:01:24] [PASSED] drm_test_damage_iter_single_damage_fractional_src [18:01:24] [PASSED] drm_test_damage_iter_single_damage_intersect_fractional_src [18:01:24] [PASSED] drm_test_damage_iter_single_damage_outside_fractional_src [18:01:24] [PASSED] drm_test_damage_iter_single_damage_src_moved [18:01:24] [PASSED] drm_test_damage_iter_single_damage_fractional_src_moved [18:01:24] [PASSED] drm_test_damage_iter_damage [18:01:24] [PASSED] drm_test_damage_iter_damage_one_intersect [18:01:24] [PASSED] drm_test_damage_iter_damage_one_outside [18:01:24] [PASSED] drm_test_damage_iter_damage_src_moved [18:01:24] [PASSED] drm_test_damage_iter_damage_not_visible [18:01:24] ================ [PASSED] drm_damage_helper ================ [18:01:24] ============== drm_dp_mst_helper (3 subtests) ============== [18:01:24] ============== drm_test_dp_mst_calc_pbn_mode ============== [18:01:24] [PASSED] Clock 154000 BPP 30 DSC disabled [18:01:24] [PASSED] Clock 234000 BPP 30 DSC disabled [18:01:24] [PASSED] Clock 297000 BPP 24 DSC disabled [18:01:24] [PASSED] Clock 332880 BPP 24 DSC enabled [18:01:24] [PASSED] Clock 324540 BPP 24 DSC enabled [18:01:24] ========== [PASSED] drm_test_dp_mst_calc_pbn_mode ========== [18:01:24] ============== drm_test_dp_mst_calc_pbn_div =============== [18:01:24] [PASSED] Link rate 2000000 lane count 4 [18:01:24] [PASSED] Link rate 2000000 lane count 2 [18:01:24] [PASSED] Link rate 2000000 lane count 1 [18:01:24] [PASSED] Link rate 1350000 lane count 4 [18:01:24] [PASSED] Link rate 1350000 lane count 2 [18:01:24] [PASSED] Link rate 1350000 lane count 1 [18:01:24] [PASSED] Link rate 1000000 lane count 4 [18:01:24] [PASSED] Link rate 1000000 lane count 2 [18:01:24] [PASSED] Link rate 1000000 lane count 1 [18:01:24] [PASSED] Link rate 810000 lane count 4 [18:01:24] [PASSED] Link rate 810000 lane count 2 [18:01:24] [PASSED] Link rate 810000 lane count 1 [18:01:24] [PASSED] Link rate 540000 lane count 4 [18:01:24] [PASSED] Link rate 540000 lane count 2 [18:01:24] [PASSED] Link rate 540000 lane count 1 [18:01:24] [PASSED] Link rate 270000 lane count 4 [18:01:24] [PASSED] Link rate 270000 lane count 2 [18:01:24] [PASSED] Link rate 270000 lane count 1 [18:01:24] [PASSED] Link rate 162000 lane count 4 [18:01:24] [PASSED] Link rate 162000 lane count 2 [18:01:24] [PASSED] Link rate 162000 lane count 1 [18:01:24] ========== [PASSED] drm_test_dp_mst_calc_pbn_div =========== [18:01:24] ========= drm_test_dp_mst_sideband_msg_req_decode ========= [18:01:24] [PASSED] DP_ENUM_PATH_RESOURCES with port number [18:01:24] [PASSED] DP_POWER_UP_PHY with port number [18:01:24] [PASSED] DP_POWER_DOWN_PHY with port number [18:01:24] [PASSED] DP_ALLOCATE_PAYLOAD with SDP stream sinks [18:01:24] [PASSED] DP_ALLOCATE_PAYLOAD with port number [18:01:24] [PASSED] DP_ALLOCATE_PAYLOAD with VCPI [18:01:24] [PASSED] DP_ALLOCATE_PAYLOAD with PBN [18:01:24] [PASSED] DP_QUERY_PAYLOAD with port number [18:01:24] [PASSED] DP_QUERY_PAYLOAD with VCPI [18:01:24] [PASSED] DP_REMOTE_DPCD_READ with port number [18:01:24] [PASSED] DP_REMOTE_DPCD_READ with DPCD address [18:01:24] [PASSED] DP_REMOTE_DPCD_READ with max number of bytes [18:01:24] [PASSED] DP_REMOTE_DPCD_WRITE with port number [18:01:24] [PASSED] DP_REMOTE_DPCD_WRITE with DPCD address [18:01:24] [PASSED] DP_REMOTE_DPCD_WRITE with data array [18:01:24] [PASSED] DP_REMOTE_I2C_READ with port number [18:01:24] [PASSED] DP_REMOTE_I2C_READ with I2C device ID [18:01:24] [PASSED] DP_REMOTE_I2C_READ with transactions array [18:01:24] [PASSED] DP_REMOTE_I2C_WRITE with port number [18:01:24] [PASSED] DP_REMOTE_I2C_WRITE with I2C device ID [18:01:24] [PASSED] DP_REMOTE_I2C_WRITE with data array [18:01:24] [PASSED] DP_QUERY_STREAM_ENC_STATUS with stream ID [18:01:24] [PASSED] DP_QUERY_STREAM_ENC_STATUS with client ID [18:01:24] [PASSED] DP_QUERY_STREAM_ENC_STATUS with stream event [18:01:24] [PASSED] DP_QUERY_STREAM_ENC_STATUS with valid stream event [18:01:24] [PASSED] DP_QUERY_STREAM_ENC_STATUS with stream behavior [18:01:24] [PASSED] DP_QUERY_STREAM_ENC_STATUS with a valid stream behavior [18:01:24] ===== [PASSED] drm_test_dp_mst_sideband_msg_req_decode ===== [18:01:24] ================ [PASSED] drm_dp_mst_helper ================ [18:01:24] ================== drm_exec (7 subtests) =================== [18:01:24] [PASSED] sanitycheck [18:01:24] [PASSED] test_lock [18:01:24] [PASSED] test_lock_unlock [18:01:24] [PASSED] test_duplicates [18:01:24] [PASSED] test_prepare [18:01:24] [PASSED] test_prepare_array [18:01:24] [PASSED] test_multiple_loops [18:01:24] ==================== [PASSED] drm_exec ===================== [18:01:24] =========== drm_format_helper_test (17 subtests) =========== [18:01:24] ============== drm_test_fb_xrgb8888_to_gray8 ============== [18:01:24] [PASSED] single_pixel_source_buffer [18:01:24] [PASSED] single_pixel_clip_rectangle [18:01:24] [PASSED] well_known_colors [18:01:24] [PASSED] destination_pitch [18:01:24] ========== [PASSED] drm_test_fb_xrgb8888_to_gray8 ========== [18:01:24] ============= drm_test_fb_xrgb8888_to_rgb332 ============== [18:01:24] [PASSED] single_pixel_source_buffer [18:01:24] [PASSED] single_pixel_clip_rectangle [18:01:24] [PASSED] well_known_colors [18:01:24] [PASSED] destination_pitch [18:01:24] ========= [PASSED] drm_test_fb_xrgb8888_to_rgb332 ========== [18:01:24] ============= drm_test_fb_xrgb8888_to_rgb565 ============== [18:01:24] [PASSED] single_pixel_source_buffer [18:01:24] [PASSED] single_pixel_clip_rectangle [18:01:24] [PASSED] well_known_colors [18:01:24] [PASSED] destination_pitch [18:01:24] ========= [PASSED] drm_test_fb_xrgb8888_to_rgb565 ========== [18:01:24] ============ drm_test_fb_xrgb8888_to_xrgb1555 ============= [18:01:24] [PASSED] single_pixel_source_buffer [18:01:24] [PASSED] single_pixel_clip_rectangle [18:01:24] [PASSED] well_known_colors [18:01:24] [PASSED] destination_pitch [18:01:24] ======== [PASSED] drm_test_fb_xrgb8888_to_xrgb1555 ========= [18:01:24] ============ drm_test_fb_xrgb8888_to_argb1555 ============= [18:01:24] [PASSED] single_pixel_source_buffer [18:01:24] [PASSED] single_pixel_clip_rectangle [18:01:24] [PASSED] well_known_colors [18:01:24] [PASSED] destination_pitch [18:01:24] ======== [PASSED] drm_test_fb_xrgb8888_to_argb1555 ========= [18:01:24] ============ drm_test_fb_xrgb8888_to_rgba5551 ============= [18:01:24] [PASSED] single_pixel_source_buffer [18:01:24] [PASSED] single_pixel_clip_rectangle [18:01:24] [PASSED] well_known_colors [18:01:24] [PASSED] destination_pitch [18:01:24] ======== [PASSED] drm_test_fb_xrgb8888_to_rgba5551 ========= [18:01:24] ============= drm_test_fb_xrgb8888_to_rgb888 ============== [18:01:24] [PASSED] single_pixel_source_buffer [18:01:24] [PASSED] single_pixel_clip_rectangle [18:01:24] [PASSED] well_known_colors [18:01:24] [PASSED] destination_pitch [18:01:24] ========= [PASSED] drm_test_fb_xrgb8888_to_rgb888 ========== [18:01:24] ============= drm_test_fb_xrgb8888_to_bgr888 ============== [18:01:24] [PASSED] single_pixel_source_buffer [18:01:24] [PASSED] single_pixel_clip_rectangle [18:01:24] [PASSED] well_known_colors [18:01:24] [PASSED] destination_pitch [18:01:24] ========= [PASSED] drm_test_fb_xrgb8888_to_bgr888 ========== [18:01:24] ============ drm_test_fb_xrgb8888_to_argb8888 ============= [18:01:24] [PASSED] single_pixel_source_buffer [18:01:24] [PASSED] single_pixel_clip_rectangle [18:01:24] [PASSED] well_known_colors [18:01:24] [PASSED] destination_pitch [18:01:24] ======== [PASSED] drm_test_fb_xrgb8888_to_argb8888 ========= [18:01:24] =========== drm_test_fb_xrgb8888_to_xrgb2101010 =========== [18:01:24] [PASSED] single_pixel_source_buffer [18:01:24] [PASSED] single_pixel_clip_rectangle [18:01:24] [PASSED] well_known_colors [18:01:24] [PASSED] destination_pitch [18:01:24] ======= [PASSED] drm_test_fb_xrgb8888_to_xrgb2101010 ======= [18:01:24] =========== drm_test_fb_xrgb8888_to_argb2101010 =========== [18:01:24] [PASSED] single_pixel_source_buffer [18:01:24] [PASSED] single_pixel_clip_rectangle [18:01:24] [PASSED] well_known_colors [18:01:24] [PASSED] destination_pitch [18:01:24] ======= [PASSED] drm_test_fb_xrgb8888_to_argb2101010 ======= [18:01:24] ============== drm_test_fb_xrgb8888_to_mono =============== [18:01:24] [PASSED] single_pixel_source_buffer [18:01:24] [PASSED] single_pixel_clip_rectangle [18:01:24] [PASSED] well_known_colors [18:01:24] [PASSED] destination_pitch [18:01:24] ========== [PASSED] drm_test_fb_xrgb8888_to_mono =========== [18:01:24] ==================== drm_test_fb_swab ===================== [18:01:24] [PASSED] single_pixel_source_buffer [18:01:24] [PASSED] single_pixel_clip_rectangle [18:01:24] [PASSED] well_known_colors [18:01:24] [PASSED] destination_pitch [18:01:24] ================ [PASSED] drm_test_fb_swab ================= [18:01:24] ============ drm_test_fb_xrgb8888_to_xbgr8888 ============= [18:01:24] [PASSED] single_pixel_source_buffer [18:01:24] [PASSED] single_pixel_clip_rectangle [18:01:24] [PASSED] well_known_colors [18:01:24] [PASSED] destination_pitch [18:01:24] ======== [PASSED] drm_test_fb_xrgb8888_to_xbgr8888 ========= [18:01:24] ============ drm_test_fb_xrgb8888_to_abgr8888 ============= [18:01:24] [PASSED] single_pixel_source_buffer [18:01:24] [PASSED] single_pixel_clip_rectangle [18:01:24] [PASSED] well_known_colors [18:01:24] [PASSED] destination_pitch [18:01:24] ======== [PASSED] drm_test_fb_xrgb8888_to_abgr8888 ========= [18:01:24] ================= drm_test_fb_clip_offset ================= [18:01:24] [PASSED] pass through [18:01:24] [PASSED] horizontal offset [18:01:24] [PASSED] vertical offset [18:01:24] [PASSED] horizontal and vertical offset [18:01:24] [PASSED] horizontal offset (custom pitch) [18:01:24] [PASSED] vertical offset (custom pitch) [18:01:24] [PASSED] horizontal and vertical offset (custom pitch) [18:01:24] ============= [PASSED] drm_test_fb_clip_offset ============= [18:01:24] =================== drm_test_fb_memcpy ==================== [18:01:24] [PASSED] single_pixel_source_buffer: XR24 little-endian (0x34325258) [18:01:24] [PASSED] single_pixel_source_buffer: XRA8 little-endian (0x38415258) [18:01:24] [PASSED] single_pixel_source_buffer: YU24 little-endian (0x34325559) [18:01:24] [PASSED] single_pixel_clip_rectangle: XB24 little-endian (0x34324258) [18:01:24] [PASSED] single_pixel_clip_rectangle: XRA8 little-endian (0x38415258) [18:01:24] [PASSED] single_pixel_clip_rectangle: YU24 little-endian (0x34325559) [18:01:24] [PASSED] well_known_colors: XB24 little-endian (0x34324258) [18:01:24] [PASSED] well_known_colors: XRA8 little-endian (0x38415258) [18:01:24] [PASSED] well_known_colors: YU24 little-endian (0x34325559) [18:01:24] [PASSED] destination_pitch: XB24 little-endian (0x34324258) [18:01:24] [PASSED] destination_pitch: XRA8 little-endian (0x38415258) [18:01:24] [PASSED] destination_pitch: YU24 little-endian (0x34325559) [18:01:24] =============== [PASSED] drm_test_fb_memcpy ================ [18:01:24] ============= [PASSED] drm_format_helper_test ============== [18:01:24] ================= drm_format (18 subtests) ================= [18:01:24] [PASSED] drm_test_format_block_width_invalid [18:01:24] [PASSED] drm_test_format_block_width_one_plane [18:01:24] [PASSED] drm_test_format_block_width_two_plane [18:01:24] [PASSED] drm_test_format_block_width_three_plane [18:01:24] [PASSED] drm_test_format_block_width_tiled [18:01:24] [PASSED] drm_test_format_block_height_invalid [18:01:24] [PASSED] drm_test_format_block_height_one_plane [18:01:24] [PASSED] drm_test_format_block_height_two_plane [18:01:24] [PASSED] drm_test_format_block_height_three_plane [18:01:24] [PASSED] drm_test_format_block_height_tiled [18:01:24] [PASSED] drm_test_format_min_pitch_invalid [18:01:24] [PASSED] drm_test_format_min_pitch_one_plane_8bpp [18:01:24] [PASSED] drm_test_format_min_pitch_one_plane_16bpp [18:01:24] [PASSED] drm_test_format_min_pitch_one_plane_24bpp [18:01:24] [PASSED] drm_test_format_min_pitch_one_plane_32bpp [18:01:24] [PASSED] drm_test_format_min_pitch_two_plane [18:01:24] [PASSED] drm_test_format_min_pitch_three_plane_8bpp [18:01:24] [PASSED] drm_test_format_min_pitch_tiled [18:01:24] =================== [PASSED] drm_format ==================== [18:01:24] ============== drm_framebuffer (10 subtests) =============== [18:01:24] ========== drm_test_framebuffer_check_src_coords ========== [18:01:24] [PASSED] Success: source fits into fb [18:01:24] [PASSED] Fail: overflowing fb with x-axis coordinate [18:01:24] [PASSED] Fail: overflowing fb with y-axis coordinate [18:01:24] [PASSED] Fail: overflowing fb with source width [18:01:24] [PASSED] Fail: overflowing fb with source height [18:01:24] ====== [PASSED] drm_test_framebuffer_check_src_coords ====== [18:01:24] [PASSED] drm_test_framebuffer_cleanup [18:01:24] =============== drm_test_framebuffer_create =============== [18:01:24] [PASSED] ABGR8888 normal sizes [18:01:24] [PASSED] ABGR8888 max sizes [18:01:24] [PASSED] ABGR8888 pitch greater than min required [18:01:24] [PASSED] ABGR8888 pitch less than min required [18:01:24] [PASSED] ABGR8888 Invalid width [18:01:24] [PASSED] ABGR8888 Invalid buffer handle [18:01:24] [PASSED] No pixel format [18:01:24] [PASSED] ABGR8888 Width 0 [18:01:24] [PASSED] ABGR8888 Height 0 [18:01:24] [PASSED] ABGR8888 Out of bound height * pitch combination [18:01:24] [PASSED] ABGR8888 Large buffer offset [18:01:24] [PASSED] ABGR8888 Buffer offset for inexistent plane [18:01:24] [PASSED] ABGR8888 Invalid flag [18:01:24] [PASSED] ABGR8888 Set DRM_MODE_FB_MODIFIERS without modifiers [18:01:24] [PASSED] ABGR8888 Valid buffer modifier [18:01:24] [PASSED] ABGR8888 Invalid buffer modifier(DRM_FORMAT_MOD_SAMSUNG_64_32_TILE) [18:01:24] [PASSED] ABGR8888 Extra pitches without DRM_MODE_FB_MODIFIERS [18:01:24] [PASSED] ABGR8888 Extra pitches with DRM_MODE_FB_MODIFIERS [18:01:24] [PASSED] NV12 Normal sizes [18:01:24] [PASSED] NV12 Max sizes [18:01:24] [PASSED] NV12 Invalid pitch [18:01:24] [PASSED] NV12 Invalid modifier/missing DRM_MODE_FB_MODIFIERS flag [18:01:24] [PASSED] NV12 different modifier per-plane [18:01:24] [PASSED] NV12 with DRM_FORMAT_MOD_SAMSUNG_64_32_TILE [18:01:24] [PASSED] NV12 Valid modifiers without DRM_MODE_FB_MODIFIERS [18:01:24] [PASSED] NV12 Modifier for inexistent plane [18:01:24] [PASSED] NV12 Handle for inexistent plane [18:01:24] [PASSED] NV12 Handle for inexistent plane without DRM_MODE_FB_MODIFIERS [18:01:24] [PASSED] YVU420 DRM_MODE_FB_MODIFIERS set without modifier [18:01:24] [PASSED] YVU420 Normal sizes [18:01:24] [PASSED] YVU420 Max sizes [18:01:24] [PASSED] YVU420 Invalid pitch [18:01:24] [PASSED] YVU420 Different pitches [18:01:24] [PASSED] YVU420 Different buffer offsets/pitches [18:01:24] [PASSED] YVU420 Modifier set just for plane 0, without DRM_MODE_FB_MODIFIERS [18:01:24] [PASSED] YVU420 Modifier set just for planes 0, 1, without DRM_MODE_FB_MODIFIERS [18:01:24] [PASSED] YVU420 Modifier set just for plane 0, 1, with DRM_MODE_FB_MODIFIERS [18:01:24] [PASSED] YVU420 Valid modifier [18:01:24] [PASSED] YVU420 Different modifiers per plane [18:01:24] [PASSED] YVU420 Modifier for inexistent plane [18:01:24] [PASSED] YUV420_10BIT Invalid modifier(DRM_FORMAT_MOD_LINEAR) [18:01:24] [PASSED] X0L2 Normal sizes [18:01:24] [PASSED] X0L2 Max sizes [18:01:24] [PASSED] X0L2 Invalid pitch [18:01:24] [PASSED] X0L2 Pitch greater than minimum required [18:01:24] [PASSED] X0L2 Handle for inexistent plane [18:01:24] [PASSED] X0L2 Offset for inexistent plane, without DRM_MODE_FB_MODIFIERS set [18:01:24] [PASSED] X0L2 Modifier without DRM_MODE_FB_MODIFIERS set [18:01:24] [PASSED] X0L2 Valid modifier [18:01:24] [PASSED] X0L2 Modifier for inexistent plane [18:01:24] =========== [PASSED] drm_test_framebuffer_create =========== [18:01:24] [PASSED] drm_test_framebuffer_free [18:01:24] [PASSED] drm_test_framebuffer_init [18:01:24] [PASSED] drm_test_framebuffer_init_bad_format [18:01:24] [PASSED] drm_test_framebuffer_init_dev_mismatch [18:01:24] [PASSED] drm_test_framebuffer_lookup [18:01:24] [PASSED] drm_test_framebuffer_lookup_inexistent [18:01:24] [PASSED] drm_test_framebuffer_modifiers_not_supported [18:01:24] ================= [PASSED] drm_framebuffer ================= [18:01:24] ================ drm_gem_shmem (8 subtests) ================ [18:01:24] [PASSED] drm_gem_shmem_test_obj_create [18:01:24] [PASSED] drm_gem_shmem_test_obj_create_private [18:01:24] [PASSED] drm_gem_shmem_test_pin_pages [18:01:24] [PASSED] drm_gem_shmem_test_vmap [18:01:24] [PASSED] drm_gem_shmem_test_get_pages_sgt [18:01:24] [PASSED] drm_gem_shmem_test_get_sg_table [18:01:24] [PASSED] drm_gem_shmem_test_madvise [18:01:24] [PASSED] drm_gem_shmem_test_purge [18:01:24] ================== [PASSED] drm_gem_shmem ================== [18:01:24] === drm_atomic_helper_connector_hdmi_check (27 subtests) === [18:01:24] [PASSED] drm_test_check_broadcast_rgb_auto_cea_mode [18:01:24] [PASSED] drm_test_check_broadcast_rgb_auto_cea_mode_vic_1 [18:01:24] [PASSED] drm_test_check_broadcast_rgb_full_cea_mode [18:01:24] [PASSED] drm_test_check_broadcast_rgb_full_cea_mode_vic_1 [18:01:24] [PASSED] drm_test_check_broadcast_rgb_limited_cea_mode [18:01:24] [PASSED] drm_test_check_broadcast_rgb_limited_cea_mode_vic_1 [18:01:24] ====== drm_test_check_broadcast_rgb_cea_mode_yuv420 ======= [18:01:24] [PASSED] Automatic [18:01:24] [PASSED] Full [18:01:24] [PASSED] Limited 16:235 [18:01:24] == [PASSED] drm_test_check_broadcast_rgb_cea_mode_yuv420 === [18:01:24] [PASSED] drm_test_check_broadcast_rgb_crtc_mode_changed [18:01:24] [PASSED] drm_test_check_broadcast_rgb_crtc_mode_not_changed [18:01:24] [PASSED] drm_test_check_disable_connector [18:01:24] [PASSED] drm_test_check_hdmi_funcs_reject_rate [18:01:24] [PASSED] drm_test_check_max_tmds_rate_bpc_fallback_rgb [18:01:24] [PASSED] drm_test_check_max_tmds_rate_bpc_fallback_yuv420 [18:01:24] [PASSED] drm_test_check_max_tmds_rate_bpc_fallback_ignore_yuv422 [18:01:24] [PASSED] drm_test_check_max_tmds_rate_bpc_fallback_ignore_yuv420 [18:01:24] [PASSED] drm_test_check_driver_unsupported_fallback_yuv420 [18:01:24] [PASSED] drm_test_check_output_bpc_crtc_mode_changed [18:01:24] [PASSED] drm_test_check_output_bpc_crtc_mode_not_changed [18:01:24] [PASSED] drm_test_check_output_bpc_dvi [18:01:24] [PASSED] drm_test_check_output_bpc_format_vic_1 [18:01:24] [PASSED] drm_test_check_output_bpc_format_display_8bpc_only [18:01:24] [PASSED] drm_test_check_output_bpc_format_display_rgb_only [18:01:24] [PASSED] drm_test_check_output_bpc_format_driver_8bpc_only [18:01:24] [PASSED] drm_test_check_output_bpc_format_driver_rgb_only [18:01:24] [PASSED] drm_test_check_tmds_char_rate_rgb_8bpc [18:01:24] [PASSED] drm_test_check_tmds_char_rate_rgb_10bpc [18:01:24] [PASSED] drm_test_check_tmds_char_rate_rgb_12bpc [18:01:24] ===== [PASSED] drm_atomic_helper_connector_hdmi_check ====== [18:01:24] === drm_atomic_helper_connector_hdmi_reset (6 subtests) ==== [18:01:24] [PASSED] drm_test_check_broadcast_rgb_value [18:01:24] [PASSED] drm_test_check_bpc_8_value [18:01:24] [PASSED] drm_test_check_bpc_10_value [18:01:24] [PASSED] drm_test_check_bpc_12_value [18:01:24] [PASSED] drm_test_check_format_value [18:01:24] [PASSED] drm_test_check_tmds_char_value [18:01:24] ===== [PASSED] drm_atomic_helper_connector_hdmi_reset ====== [18:01:24] = drm_atomic_helper_connector_hdmi_mode_valid (4 subtests) = [18:01:24] [PASSED] drm_test_check_mode_valid [18:01:24] [PASSED] drm_test_check_mode_valid_reject [18:01:24] [PASSED] drm_test_check_mode_valid_reject_rate [18:01:24] [PASSED] drm_test_check_mode_valid_reject_max_clock [18:01:24] === [PASSED] drm_atomic_helper_connector_hdmi_mode_valid === [18:01:24] ================= drm_managed (2 subtests) ================= [18:01:24] [PASSED] drm_test_managed_release_action [18:01:24] [PASSED] drm_test_managed_run_action [18:01:24] =================== [PASSED] drm_managed =================== [18:01:24] =================== drm_mm (6 subtests) ==================== [18:01:24] [PASSED] drm_test_mm_init [18:01:24] [PASSED] drm_test_mm_debug [18:01:24] [PASSED] drm_test_mm_align32 [18:01:24] [PASSED] drm_test_mm_align64 [18:01:24] [PASSED] drm_test_mm_lowest [18:01:24] [PASSED] drm_test_mm_highest [18:01:24] ===================== [PASSED] drm_mm ====================== [18:01:24] ============= drm_modes_analog_tv (5 subtests) ============= [18:01:24] [PASSED] drm_test_modes_analog_tv_mono_576i [18:01:24] [PASSED] drm_test_modes_analog_tv_ntsc_480i [18:01:24] [PASSED] drm_test_modes_analog_tv_ntsc_480i_inlined [18:01:24] [PASSED] drm_test_modes_analog_tv_pal_576i [18:01:24] [PASSED] drm_test_modes_analog_tv_pal_576i_inlined [18:01:24] =============== [PASSED] drm_modes_analog_tv =============== [18:01:24] ============== drm_plane_helper (2 subtests) =============== [18:01:24] =============== drm_test_check_plane_state ================ [18:01:24] [PASSED] clipping_simple [18:01:24] [PASSED] clipping_rotate_reflect [18:01:24] [PASSED] positioning_simple [18:01:24] [PASSED] upscaling [18:01:24] [PASSED] downscaling [18:01:24] [PASSED] rounding1 [18:01:24] [PASSED] rounding2 [18:01:24] [PASSED] rounding3 [18:01:24] [PASSED] rounding4 [18:01:24] =========== [PASSED] drm_test_check_plane_state ============ [18:01:24] =========== drm_test_check_invalid_plane_state ============ [18:01:24] [PASSED] positioning_invalid [18:01:24] [PASSED] upscaling_invalid [18:01:24] [PASSED] downscaling_invalid [18:01:24] ======= [PASSED] drm_test_check_invalid_plane_state ======== [18:01:24] ================ [PASSED] drm_plane_helper ================= [18:01:24] ====== drm_connector_helper_tv_get_modes (1 subtest) ======= [18:01:24] ====== drm_test_connector_helper_tv_get_modes_check ======= [18:01:24] [PASSED] None [18:01:24] [PASSED] PAL [18:01:24] [PASSED] NTSC [18:01:24] [PASSED] Both, NTSC Default [18:01:24] [PASSED] Both, PAL Default [18:01:24] [PASSED] Both, NTSC Default, with PAL on command-line [18:01:24] [PASSED] Both, PAL Default, with NTSC on command-line [18:01:24] == [PASSED] drm_test_connector_helper_tv_get_modes_check === [18:01:24] ======== [PASSED] drm_connector_helper_tv_get_modes ======== [18:01:24] ================== drm_rect (9 subtests) =================== [18:01:24] [PASSED] drm_test_rect_clip_scaled_div_by_zero [18:01:24] [PASSED] drm_test_rect_clip_scaled_not_clipped [18:01:24] [PASSED] drm_test_rect_clip_scaled_clipped [18:01:24] [PASSED] drm_test_rect_clip_scaled_signed_vs_unsigned [18:01:24] ================= drm_test_rect_intersect ================= [18:01:24] [PASSED] top-left x bottom-right: 2x2+1+1 x 2x2+0+0 [18:01:24] [PASSED] top-right x bottom-left: 2x2+0+0 x 2x2+1-1 [18:01:24] [PASSED] bottom-left x top-right: 2x2+1-1 x 2x2+0+0 [18:01:24] [PASSED] bottom-right x top-left: 2x2+0+0 x 2x2+1+1 [18:01:24] [PASSED] right x left: 2x1+0+0 x 3x1+1+0 [18:01:24] [PASSED] left x right: 3x1+1+0 x 2x1+0+0 [18:01:24] [PASSED] up x bottom: 1x2+0+0 x 1x3+0-1 [18:01:24] [PASSED] bottom x up: 1x3+0-1 x 1x2+0+0 [18:01:24] [PASSED] touching corner: 1x1+0+0 x 2x2+1+1 [18:01:24] [PASSED] touching side: 1x1+0+0 x 1x1+1+0 [18:01:24] [PASSED] equal rects: 2x2+0+0 x 2x2+0+0 [18:01:24] [PASSED] inside another: 2x2+0+0 x 1x1+1+1 [18:01:24] [PASSED] far away: 1x1+0+0 x 1x1+3+6 [18:01:24] [PASSED] points intersecting: 0x0+5+10 x 0x0+5+10 [18:01:24] [PASSED] points not intersecting: 0x0+0+0 x 0x0+5+10 [18:01:24] ============= [PASSED] drm_test_rect_intersect ============= [18:01:24] ================ drm_test_rect_calc_hscale ================ [18:01:24] [PASSED] normal use [18:01:24] [PASSED] out of max range [18:01:24] [PASSED] out of min range [18:01:24] [PASSED] zero dst [18:01:24] [PASSED] negative src [18:01:24] [PASSED] negative dst [18:01:24] ============ [PASSED] drm_test_rect_calc_hscale ============ [18:01:24] ================ drm_test_rect_calc_vscale ================ [18:01:24] [PASSED] normal use stty: 'standard input': Inappropriate ioctl for device [18:01:24] [PASSED] out of max range [18:01:24] [PASSED] out of min range [18:01:24] [PASSED] zero dst [18:01:24] [PASSED] negative src [18:01:24] [PASSED] negative dst [18:01:24] ============ [PASSED] drm_test_rect_calc_vscale ============ [18:01:24] ================== drm_test_rect_rotate =================== [18:01:24] [PASSED] reflect-x [18:01:24] [PASSED] reflect-y [18:01:24] [PASSED] rotate-0 [18:01:24] [PASSED] rotate-90 [18:01:24] [PASSED] rotate-180 [18:01:24] [PASSED] rotate-270 [18:01:24] ============== [PASSED] drm_test_rect_rotate =============== [18:01:24] ================ drm_test_rect_rotate_inv ================= [18:01:24] [PASSED] reflect-x [18:01:24] [PASSED] reflect-y [18:01:24] [PASSED] rotate-0 [18:01:24] [PASSED] rotate-90 [18:01:24] [PASSED] rotate-180 [18:01:24] [PASSED] rotate-270 [18:01:24] ============ [PASSED] drm_test_rect_rotate_inv ============= [18:01:24] ==================== [PASSED] drm_rect ===================== [18:01:24] ============ drm_sysfb_modeset_test (1 subtest) ============ [18:01:24] ============ drm_test_sysfb_build_fourcc_list ============= [18:01:24] [PASSED] no native formats [18:01:24] [PASSED] XRGB8888 as native format [18:01:24] [PASSED] remove duplicates [18:01:24] [PASSED] convert alpha formats [18:01:24] [PASSED] random formats [18:01:24] ======== [PASSED] drm_test_sysfb_build_fourcc_list ========= [18:01:24] ============= [PASSED] drm_sysfb_modeset_test ============== [18:01:24] ============================================================ [18:01:24] Testing complete. Ran 622 tests: passed: 622 [18:01:24] Elapsed time: 26.912s total, 1.662s configuring, 24.828s building, 0.384s running
+ /kernel/tools/testing/kunit/kunit.py run --kunitconfig /kernel/drivers/gpu/drm/ttm/tests/.kunitconfig [18:01:24] Configuring KUnit Kernel ...
Regenerating .config ...
Populating config with:
$ make ARCH=um O=.kunit olddefconfig [18:01:25] Building KUnit Kernel ... Populating config with: $ make ARCH=um O=.kunit olddefconfig Building with: $ make all compile_commands.json scripts_gdb ARCH=um O=.kunit --jobs=48 [18:01:35] Starting KUnit Kernel (1/1)... [18:01:35] ============================================================ Running tests with: $ .kunit/linux kunit.enable=1 mem=1G console=tty kunit_shutdown=halt [18:01:35] ================= ttm_device (5 subtests) ================== [18:01:35] [PASSED] ttm_device_init_basic [18:01:35] [PASSED] ttm_device_init_multiple [18:01:35] [PASSED] ttm_device_fini_basic [18:01:35] [PASSED] ttm_device_init_no_vma_man [18:01:35] ================== ttm_device_init_pools ================== [18:01:35] [PASSED] No DMA allocations, no DMA32 required [18:01:35] [PASSED] DMA allocations, DMA32 required [18:01:35] [PASSED] No DMA allocations, DMA32 required [18:01:35] [PASSED] DMA allocations, no DMA32 required [18:01:35] ============== [PASSED] ttm_device_init_pools ============== [18:01:35] =================== [PASSED] ttm_device ==================== [18:01:35] ================== ttm_pool (8 subtests) =================== [18:01:35] ================== ttm_pool_alloc_basic =================== [18:01:35] [PASSED] One page [18:01:35] [PASSED] More than one page [18:01:35] [PASSED] Above the allocation limit [18:01:35] [PASSED] One page, with coherent DMA mappings enabled [18:01:35] [PASSED] Above the allocation limit, with coherent DMA mappings enabled [18:01:35] ============== [PASSED] ttm_pool_alloc_basic =============== [18:01:35] ============== ttm_pool_alloc_basic_dma_addr ============== [18:01:35] [PASSED] One page [18:01:35] [PASSED] More than one page [18:01:35] [PASSED] Above the allocation limit [18:01:35] [PASSED] One page, with coherent DMA mappings enabled [18:01:35] [PASSED] Above the allocation limit, with coherent DMA mappings enabled [18:01:35] ========== [PASSED] ttm_pool_alloc_basic_dma_addr ========== [18:01:35] [PASSED] ttm_pool_alloc_order_caching_match [18:01:35] [PASSED] ttm_pool_alloc_caching_mismatch [18:01:35] [PASSED] ttm_pool_alloc_order_mismatch [18:01:35] [PASSED] ttm_pool_free_dma_alloc [18:01:35] [PASSED] ttm_pool_free_no_dma_alloc [18:01:35] [PASSED] ttm_pool_fini_basic [18:01:35] ==================== [PASSED] ttm_pool ===================== [18:01:35] ================ ttm_resource (8 subtests) ================= [18:01:35] ================= ttm_resource_init_basic ================= [18:01:35] [PASSED] Init resource in TTM_PL_SYSTEM [18:01:35] [PASSED] Init resource in TTM_PL_VRAM [18:01:35] [PASSED] Init resource in a private placement [18:01:35] [PASSED] Init resource in TTM_PL_SYSTEM, set placement flags [18:01:35] ============= [PASSED] ttm_resource_init_basic ============= [18:01:35] [PASSED] ttm_resource_init_pinned [18:01:35] [PASSED] ttm_resource_fini_basic [18:01:35] [PASSED] ttm_resource_manager_init_basic [18:01:35] [PASSED] ttm_resource_manager_usage_basic [18:01:35] [PASSED] ttm_resource_manager_set_used_basic [18:01:35] [PASSED] ttm_sys_man_alloc_basic [18:01:35] [PASSED] ttm_sys_man_free_basic [18:01:35] ================== [PASSED] ttm_resource =================== [18:01:35] =================== ttm_tt (15 subtests) =================== [18:01:35] ==================== ttm_tt_init_basic ==================== [18:01:35] [PASSED] Page-aligned size [18:01:35] [PASSED] Extra pages requested [18:01:35] ================ [PASSED] ttm_tt_init_basic ================ [18:01:35] [PASSED] ttm_tt_init_misaligned [18:01:35] [PASSED] ttm_tt_fini_basic [18:01:35] [PASSED] ttm_tt_fini_sg [18:01:35] [PASSED] ttm_tt_fini_shmem [18:01:35] [PASSED] ttm_tt_create_basic [18:01:35] [PASSED] ttm_tt_create_invalid_bo_type [18:01:35] [PASSED] ttm_tt_create_ttm_exists [18:01:35] [PASSED] ttm_tt_create_failed [18:01:35] [PASSED] ttm_tt_destroy_basic [18:01:35] [PASSED] ttm_tt_populate_null_ttm [18:01:35] [PASSED] ttm_tt_populate_populated_ttm [18:01:35] [PASSED] ttm_tt_unpopulate_basic [18:01:35] [PASSED] ttm_tt_unpopulate_empty_ttm [18:01:35] [PASSED] ttm_tt_swapin_basic [18:01:35] ===================== [PASSED] ttm_tt ====================== [18:01:35] =================== ttm_bo (14 subtests) =================== [18:01:35] =========== ttm_bo_reserve_optimistic_no_ticket =========== [18:01:35] [PASSED] Cannot be interrupted and sleeps [18:01:35] [PASSED] Cannot be interrupted, locks straight away [18:01:35] [PASSED] Can be interrupted, sleeps [18:01:35] ======= [PASSED] ttm_bo_reserve_optimistic_no_ticket ======= [18:01:35] [PASSED] ttm_bo_reserve_locked_no_sleep [18:01:35] [PASSED] ttm_bo_reserve_no_wait_ticket [18:01:35] [PASSED] ttm_bo_reserve_double_resv [18:01:35] [PASSED] ttm_bo_reserve_interrupted [18:01:35] [PASSED] ttm_bo_reserve_deadlock [18:01:35] [PASSED] ttm_bo_unreserve_basic [18:01:35] [PASSED] ttm_bo_unreserve_pinned [18:01:35] [PASSED] ttm_bo_unreserve_bulk [18:01:35] [PASSED] ttm_bo_fini_basic [18:01:35] [PASSED] ttm_bo_fini_shared_resv [18:01:35] [PASSED] ttm_bo_pin_basic [18:01:35] [PASSED] ttm_bo_pin_unpin_resource [18:01:35] [PASSED] ttm_bo_multiple_pin_one_unpin [18:01:35] ===================== [PASSED] ttm_bo ====================== [18:01:35] ============== ttm_bo_validate (21 subtests) =============== [18:01:35] ============== ttm_bo_init_reserved_sys_man =============== [18:01:35] [PASSED] Buffer object for userspace [18:01:35] [PASSED] Kernel buffer object [18:01:35] [PASSED] Shared buffer object [18:01:35] ========== [PASSED] ttm_bo_init_reserved_sys_man =========== [18:01:35] ============== ttm_bo_init_reserved_mock_man ============== [18:01:35] [PASSED] Buffer object for userspace [18:01:35] [PASSED] Kernel buffer object [18:01:35] [PASSED] Shared buffer object [18:01:35] ========== [PASSED] ttm_bo_init_reserved_mock_man ========== [18:01:35] [PASSED] ttm_bo_init_reserved_resv [18:01:35] ================== ttm_bo_validate_basic ================== [18:01:35] [PASSED] Buffer object for userspace [18:01:35] [PASSED] Kernel buffer object [18:01:35] [PASSED] Shared buffer object [18:01:35] ============== [PASSED] ttm_bo_validate_basic ============== [18:01:35] [PASSED] ttm_bo_validate_invalid_placement [18:01:35] ============= ttm_bo_validate_same_placement ============== [18:01:35] [PASSED] System manager [18:01:35] [PASSED] VRAM manager [18:01:35] ========= [PASSED] ttm_bo_validate_same_placement ========== [18:01:35] [PASSED] ttm_bo_validate_failed_alloc [18:01:35] [PASSED] ttm_bo_validate_pinned [18:01:35] [PASSED] ttm_bo_validate_busy_placement [18:01:35] ================ ttm_bo_validate_multihop ================= [18:01:35] [PASSED] Buffer object for userspace [18:01:35] [PASSED] Kernel buffer object [18:01:35] [PASSED] Shared buffer object [18:01:35] ============ [PASSED] ttm_bo_validate_multihop ============= [18:01:35] ========== ttm_bo_validate_no_placement_signaled ========== [18:01:35] [PASSED] Buffer object in system domain, no page vector [18:01:35] [PASSED] Buffer object in system domain with an existing page vector [18:01:35] ====== [PASSED] ttm_bo_validate_no_placement_signaled ====== [18:01:35] ======== ttm_bo_validate_no_placement_not_signaled ======== [18:01:35] [PASSED] Buffer object for userspace [18:01:35] [PASSED] Kernel buffer object [18:01:35] [PASSED] Shared buffer object [18:01:35] ==== [PASSED] ttm_bo_validate_no_placement_not_signaled ==== [18:01:35] [PASSED] ttm_bo_validate_move_fence_signaled [18:01:35] ========= ttm_bo_validate_move_fence_not_signaled ========= [18:01:35] [PASSED] Waits for GPU [18:01:35] [PASSED] Tries to lock straight away [18:01:35] ===== [PASSED] ttm_bo_validate_move_fence_not_signaled ===== [18:01:35] [PASSED] ttm_bo_validate_happy_evict [18:01:35] [PASSED] ttm_bo_validate_all_pinned_evict [18:01:35] [PASSED] ttm_bo_validate_allowed_only_evict [18:01:35] [PASSED] ttm_bo_validate_deleted_evict [18:01:35] [PASSED] ttm_bo_validate_busy_domain_evict [18:01:35] [PASSED] ttm_bo_validate_evict_gutting [18:01:35] [PASSED] ttm_bo_validate_recrusive_evict stty: 'standard input': Inappropriate ioctl for device [18:01:35] ================= [PASSED] ttm_bo_validate ================= [18:01:35] ============================================================ [18:01:35] Testing complete. Ran 101 tests: passed: 101 [18:01:35] Elapsed time: 11.407s total, 1.644s configuring, 9.494s building, 0.221s running
+ cleanup
++ stat -c %u:%g /kernel
+ chown -R 1003:1003 /kernel
Patchwork
CI✓ Xe.CI.BAT: success for Pagefault refactor (rev3)
In reply to Matthew Brost== Series Details ==
== Series Details ==
Series: Pagefault refactor (rev3)
URL : https://patchwork.freedesktop.org/series/156508/
State : success
== Summary ==
CI Bug Log - changes from xe-4023-514fac1c82d99307294e5c8a00f91fe5ab0150ab_BAT -> xe-pw-156508v3_BAT
====================================================
Summary
-------
**SUCCESS**
No regressions found.
Participating hosts (12 -> 12)
------------------------------
No changes in participating hosts
Known issues
------------
Here are the changes found in xe-pw-156508v3_BAT that come from known issues:
### IGT changes ###
#### Possible fixes ####
* igt@kms_flip@basic-plain-flip@a-edp1:
- bat-adlp-7: [DMESG-WARN][1] ([Intel XE#4543]) -> [PASS][2] +1 other test pass
[1]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-4023-514fac1c82d99307294e5c8a00f91fe5ab0150ab/bat-adlp-7/igt@kms_flip@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-156508v3/bat-adlp-7/igt@kms_flip@[email protected]
[Intel XE#4543]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/4543
Build changes
-------------
* Linux: xe-4023-514fac1c82d99307294e5c8a00f91fe5ab0150ab -> xe-pw-156508v3
IGT_8604: 8604
xe-4023-514fac1c82d99307294e5c8a00f91fe5ab0150ab: 514fac1c82d99307294e5c8a00f91fe5ab0150ab
xe-pw-156508v3: 156508v3
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-156508v3/index.html
Patchwork
CI✗ Xe.CI.Full: failure for Pagefault refactor (rev3)
In reply to Matthew Brost== Series Details ==
== Series Details ==
Series: Pagefault refactor (rev3)
URL : https://patchwork.freedesktop.org/series/156508/
State : failure
== Summary ==
CI Bug Log - changes from xe-4023-514fac1c82d99307294e5c8a00f91fe5ab0150ab_FULL -> xe-pw-156508v3_FULL
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with xe-pw-156508v3_FULL absolutely need to be verified manually.
If you think the reported changes have nothing to do with the changes
introduced in xe-pw-156508v3_FULL, please notify your bug team ([email protected]) to allow them to document this new failure mode, which will reduce false positives in CI.
Participating hosts (4 -> 4)
------------------------------
No changes in participating hosts
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in xe-pw-156508v3_FULL:
### IGT changes ###
#### Possible regressions ####
* igt@xe_exec_basic@multigpu-many-execqueues-many-vm-rebind:
- shard-dg2-set2: [PASS][1] -> [INCOMPLETE][2]
[1]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-4023-514fac1c82d99307294e5c8a00f91fe5ab0150ab/shard-dg2-434/igt@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-156508v3/shard-dg2-463/igt@[email protected]
Known issues
------------
Here are the changes found in xe-pw-156508v3_FULL that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@kms_atomic_transition@plane-toggle-modeset-transition:
- shard-adlp: [PASS][3] -> [FAIL][4] ([Intel XE#3908]) +1 other test fail
[3]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-4023-514fac1c82d99307294e5c8a00f91fe5ab0150ab/shard-adlp-9/igt@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-156508v3/shard-adlp-3/igt@[email protected]
* igt@kms_big_fb@y-tiled-64bpp-rotate-180:
- shard-dg2-set2: NOTRUN -> [SKIP][5] ([Intel XE#1124]) +1 other test skip
[5]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-156508v3/shard-dg2-463/igt@[email protected]
* igt@kms_bw@connected-linear-tiling-2-displays-3840x2160p:
- shard-bmg: [PASS][6] -> [SKIP][7] ([Intel XE#2314] / [Intel XE#2894])
[6]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-4023-514fac1c82d99307294e5c8a00f91fe5ab0150ab/shard-bmg-4/igt@[email protected]
[7]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-156508v3/shard-bmg-6/igt@[email protected]
* igt@kms_ccs@crc-primary-basic-4-tiled-lnl-ccs@pipe-b-dp-2:
- shard-bmg: NOTRUN -> [SKIP][8] ([Intel XE#2652] / [Intel XE#787]) +3 other tests skip
[8]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-156508v3/shard-bmg-1/igt@kms_ccs@[email protected]
* igt@kms_ccs@missing-ccs-buffer-y-tiled-gen12-mc-ccs:
- shard-dg2-set2: NOTRUN -> [SKIP][9] ([Intel XE#455] / [Intel XE#787]) +1 other test skip
[9]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-156508v3/shard-dg2-463/igt@[email protected]
* igt@kms_ccs@missing-ccs-buffer-y-tiled-gen12-mc-ccs@pipe-a-hdmi-a-6:
- shard-dg2-set2: NOTRUN -> [SKIP][10] ([Intel XE#787]) +6 other tests skip
[10]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-156508v3/shard-dg2-463/igt@kms_ccs@[email protected]
* igt@kms_ccs@random-ccs-data-4-tiled-dg2-rc-ccs-cc@pipe-b-dp-4:
- shard-dg2-set2: NOTRUN -> [INCOMPLETE][11] ([Intel XE#6168])
[11]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-156508v3/shard-dg2-466/igt@kms_ccs@[email protected]
* igt@kms_ccs@random-ccs-data-4-tiled-dg2-rc-ccs-cc@pipe-b-hdmi-a-6:
- shard-dg2-set2: NOTRUN -> [DMESG-WARN][12] ([Intel XE#1727] / [Intel XE#3113])
[12]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-156508v3/shard-dg2-466/igt@kms_ccs@[email protected]
* igt@kms_cursor_legacy@cursor-vs-flip-atomic-transitions-varying-size:
- shard-bmg: [PASS][13] -> [DMESG-WARN][14] ([Intel XE#5354])
[13]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-4023-514fac1c82d99307294e5c8a00f91fe5ab0150ab/shard-bmg-8/igt@kms_cursor_legacy@cursor-vs-flip-atomic-transitions-varying-size.html
[14]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-156508v3/shard-bmg-7/igt@kms_cursor_legacy@cursor-vs-flip-atomic-transitions-varying-size.html
* igt@kms_cursor_legacy@cursorb-vs-flipa-legacy:
- shard-bmg: [PASS][15] -> [SKIP][16] ([Intel XE#2291]) +1 other test skip
[15]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-4023-514fac1c82d99307294e5c8a00f91fe5ab0150ab/shard-bmg-5/igt@[email protected]
[16]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-156508v3/shard-bmg-6/igt@[email protected]
* igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions:
- shard-bmg: [PASS][17] -> [FAIL][18] ([Intel XE#1475])
[17]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-4023-514fac1c82d99307294e5c8a00f91fe5ab0150ab/shard-bmg-4/igt@[email protected]
[18]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-156508v3/shard-bmg-4/igt@[email protected]
* igt@kms_cursor_legacy@short-busy-flip-before-cursor-atomic-transitions:
- shard-dg2-set2: NOTRUN -> [SKIP][19] ([Intel XE#323])
[19]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-156508v3/shard-dg2-463/igt@kms_cursor_legacy@short-busy-flip-before-cursor-atomic-transitions.html
* igt@kms_dp_aux_dev:
- shard-bmg: [PASS][20] -> [SKIP][21] ([Intel XE#3009])
[20]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-4023-514fac1c82d99307294e5c8a00f91fe5ab0150ab/shard-bmg-1/igt@kms_dp_aux_dev.html
[21]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-156508v3/shard-bmg-6/igt@kms_dp_aux_dev.html
* igt@kms_flip@2x-modeset-vs-vblank-race:
- shard-bmg: [PASS][22] -> [SKIP][23] ([Intel XE#2316]) +5 other tests skip
[22]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-4023-514fac1c82d99307294e5c8a00f91fe5ab0150ab/shard-bmg-5/igt@[email protected]
[23]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-156508v3/shard-bmg-6/igt@[email protected]
* igt@kms_flip@flip-vs-blocking-wf-vblank:
- shard-adlp: [PASS][24] -> [DMESG-WARN][25] ([Intel XE#4543]) +3 other tests dmesg-warn
[24]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-4023-514fac1c82d99307294e5c8a00f91fe5ab0150ab/shard-adlp-8/igt@[email protected]
[25]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-156508v3/shard-adlp-3/igt@[email protected]
* igt@kms_frontbuffer_tracking@drrs-1p-offscreen-pri-indfb-draw-mmap-wc:
- shard-dg2-set2: NOTRUN -> [SKIP][26] ([Intel XE#6312])
[26]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-156508v3/shard-dg2-463/igt@kms_frontbuffer_tracking@drrs-1p-offscreen-pri-indfb-draw-mmap-wc.html
* igt@kms_frontbuffer_tracking@drrs-slowdraw:
- shard-bmg: NOTRUN -> [SKIP][27] ([Intel XE#2311])
[27]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-156508v3/shard-bmg-2/igt@[email protected]
* igt@kms_frontbuffer_tracking@fbcdrrs-2p-scndscrn-shrfb-plflip-blt:
- shard-dg2-set2: NOTRUN -> [SKIP][28] ([Intel XE#651]) +2 other tests skip
[28]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-156508v3/shard-dg2-463/igt@kms_frontbuffer_tracking@fbcdrrs-2p-scndscrn-shrfb-plflip-blt.html
* igt@kms_frontbuffer_tracking@psr-2p-scndscrn-pri-shrfb-draw-render:
- shard-dg2-set2: NOTRUN -> [SKIP][29] ([Intel XE#653]) +2 other tests skip
[29]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-156508v3/shard-dg2-463/igt@kms_frontbuffer_tracking@psr-2p-scndscrn-pri-shrfb-draw-render.html
* igt@kms_hdr@invalid-metadata-sizes:
- shard-bmg: [PASS][30] -> [SKIP][31] ([Intel XE#1503])
[30]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-4023-514fac1c82d99307294e5c8a00f91fe5ab0150ab/shard-bmg-4/igt@[email protected]
[31]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-156508v3/shard-bmg-6/igt@[email protected]
* igt@kms_joiner@invalid-modeset-big-joiner:
- shard-dg2-set2: NOTRUN -> [SKIP][32] ([Intel XE#346])
[32]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-156508v3/shard-dg2-463/igt@[email protected]
* igt@kms_plane@plane-panning-bottom-right-suspend:
- shard-adlp: [PASS][33] -> [DMESG-WARN][34] ([Intel XE#2953] / [Intel XE#4173]) +2 other tests dmesg-warn
[33]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-4023-514fac1c82d99307294e5c8a00f91fe5ab0150ab/shard-adlp-4/igt@[email protected]
[34]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-156508v3/shard-adlp-8/igt@[email protected]
* igt@kms_pm_backlight@fade-with-suspend:
- shard-dg2-set2: NOTRUN -> [SKIP][35] ([Intel XE#870])
[35]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-156508v3/shard-dg2-463/igt@[email protected]
* igt@kms_psr2_sf@psr2-overlay-plane-move-continuous-sf:
- shard-dg2-set2: NOTRUN -> [SKIP][36] ([Intel XE#1406] / [Intel XE#1489])
[36]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-156508v3/shard-dg2-463/igt@[email protected]
* igt@kms_psr@psr2-suspend:
- shard-dg2-set2: NOTRUN -> [SKIP][37] ([Intel XE#1406] / [Intel XE#2850] / [Intel XE#929])
[37]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-156508v3/shard-dg2-463/igt@[email protected]
* igt@kms_vrr@flip-dpms:
- shard-dg2-set2: NOTRUN -> [SKIP][38] ([Intel XE#455])
[38]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-156508v3/shard-dg2-463/igt@[email protected]
* igt@xe_eudebug_online@resume-one:
- shard-dg2-set2: NOTRUN -> [SKIP][39] ([Intel XE#4837]) +1 other test skip
[39]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-156508v3/shard-dg2-463/igt@[email protected]
* igt@xe_evict@evict-mixed-many-threads-small:
- shard-bmg: [PASS][40] -> [INCOMPLETE][41] ([Intel XE#6321]) +1 other test incomplete
[40]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-4023-514fac1c82d99307294e5c8a00f91fe5ab0150ab/shard-bmg-5/igt@[email protected]
[41]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-156508v3/shard-bmg-1/igt@[email protected]
* igt@xe_exec_fault_mode@once-rebind-imm:
- shard-dg2-set2: NOTRUN -> [SKIP][42] ([Intel XE#288]) +2 other tests skip
[42]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-156508v3/shard-dg2-463/igt@[email protected]
* igt@xe_exec_reset@cm-close-fd:
- shard-adlp: [PASS][43] -> [DMESG-WARN][44] ([Intel XE#3868])
[43]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-4023-514fac1c82d99307294e5c8a00f91fe5ab0150ab/shard-adlp-9/igt@[email protected]
[44]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-156508v3/shard-adlp-3/igt@[email protected]
* igt@xe_exec_system_allocator@madvise-preffered-loc-atomic-cpu:
- shard-dg2-set2: NOTRUN -> [SKIP][45] ([Intel XE#4915]) +39 other tests skip
[45]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-156508v3/shard-dg2-463/igt@[email protected]
* igt@xe_fault_injection@probe-fail-guc-xe_guc_mmio_send_recv:
- shard-dg2-set2: [PASS][46] -> [DMESG-WARN][47] ([Intel XE#5893])
[46]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-4023-514fac1c82d99307294e5c8a00f91fe5ab0150ab/shard-dg2-434/igt@xe_fault_injection@probe-fail-guc-xe_guc_mmio_send_recv.html
[47]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-156508v3/shard-dg2-463/igt@xe_fault_injection@probe-fail-guc-xe_guc_mmio_send_recv.html
* igt@xe_oa@oa-unit-concurrent-oa-buffer-read:
- shard-dg2-set2: NOTRUN -> [SKIP][48] ([Intel XE#3573])
[48]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-156508v3/shard-dg2-463/igt@[email protected]
* igt@xe_pm@s2idle-vm-bind-userptr:
- shard-adlp: [PASS][49] -> [DMESG-WARN][50] ([Intel XE#2953] / [Intel XE#4173] / [Intel XE#4504])
[49]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-4023-514fac1c82d99307294e5c8a00f91fe5ab0150ab/shard-adlp-9/igt@[email protected]
[50]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-156508v3/shard-adlp-3/igt@[email protected]
* igt@xe_sriov_scheduling@nonpreempt-engine-resets@numvfs-random:
- shard-adlp: [PASS][51] -> [DMESG-FAIL][52] ([Intel XE#3868] / [Intel XE#5213] / [Intel XE#5545]) +1 other test dmesg-fail
[51]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-4023-514fac1c82d99307294e5c8a00f91fe5ab0150ab/shard-adlp-8/igt@xe_sriov_scheduling@[email protected]
[52]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-156508v3/shard-adlp-2/igt@xe_sriov_scheduling@[email protected]
#### Possible fixes ####
* igt@kms_big_fb@y-tiled-max-hw-stride-64bpp-rotate-0-async-flip:
- shard-adlp: [DMESG-FAIL][53] ([Intel XE#4543]) -> [PASS][54]
[53]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-4023-514fac1c82d99307294e5c8a00f91fe5ab0150ab/shard-adlp-8/igt@[email protected]
[54]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-156508v3/shard-adlp-3/igt@[email protected]
* igt@kms_ccs@random-ccs-data-4-tiled-dg2-mc-ccs:
- shard-dg2-set2: [INCOMPLETE][55] ([Intel XE#1727] / [Intel XE#2705] / [Intel XE#3113] / [Intel XE#4212] / [Intel XE#4345]) -> [PASS][56]
[55]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-4023-514fac1c82d99307294e5c8a00f91fe5ab0150ab/shard-dg2-466/igt@[email protected]
[56]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-156508v3/shard-dg2-463/igt@[email protected]
* igt@kms_ccs@random-ccs-data-4-tiled-dg2-mc-ccs@pipe-a-hdmi-a-6:
- shard-dg2-set2: [INCOMPLETE][57] ([Intel XE#2705] / [Intel XE#3113] / [Intel XE#4212]) -> [PASS][58]
[57]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-4023-514fac1c82d99307294e5c8a00f91fe5ab0150ab/shard-dg2-466/igt@kms_ccs@[email protected]
[58]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-156508v3/shard-dg2-463/igt@kms_ccs@[email protected]
* igt@kms_ccs@random-ccs-data-4-tiled-dg2-rc-ccs-cc@pipe-a-dp-4:
- shard-dg2-set2: [INCOMPLETE][59] ([Intel XE#1727] / [Intel XE#2705] / [Intel XE#3113] / [Intel XE#4212] / [Intel XE#4522]) -> [PASS][60]
[59]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-4023-514fac1c82d99307294e5c8a00f91fe5ab0150ab/shard-dg2-435/igt@kms_ccs@[email protected]
[60]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-156508v3/shard-dg2-466/igt@kms_ccs@[email protected]
* igt@kms_cursor_legacy@2x-long-cursor-vs-flip-legacy:
- shard-bmg: [SKIP][61] ([Intel XE#2291]) -> [PASS][62] +1 other test pass
[61]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-4023-514fac1c82d99307294e5c8a00f91fe5ab0150ab/shard-bmg-6/igt@[email protected]
[62]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-156508v3/shard-bmg-1/igt@[email protected]
* igt@kms_cursor_legacy@cursorb-vs-flipa-atomic-transitions-varying-size:
- shard-bmg: [DMESG-WARN][63] ([Intel XE#5354]) -> [PASS][64]
[63]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-4023-514fac1c82d99307294e5c8a00f91fe5ab0150ab/shard-bmg-1/igt@kms_cursor_legacy@cursorb-vs-flipa-atomic-transitions-varying-size.html
[64]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-156508v3/shard-bmg-7/igt@kms_cursor_legacy@cursorb-vs-flipa-atomic-transitions-varying-size.html
* igt@kms_cursor_legacy@flip-vs-cursor-atomic:
- shard-bmg: [FAIL][65] ([Intel XE#1475]) -> [PASS][66]
[65]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-4023-514fac1c82d99307294e5c8a00f91fe5ab0150ab/shard-bmg-5/igt@[email protected]
[66]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-156508v3/shard-bmg-6/igt@[email protected]
* igt@kms_flip@2x-busy-flip:
- shard-bmg: [SKIP][67] ([Intel XE#2316]) -> [PASS][68] +1 other test pass
[67]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-4023-514fac1c82d99307294e5c8a00f91fe5ab0150ab/shard-bmg-6/igt@[email protected]
[68]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-156508v3/shard-bmg-2/igt@[email protected]
* igt@kms_flip@flip-vs-expired-vblank@b-edp1:
- shard-lnl: [FAIL][69] ([Intel XE#301]) -> [PASS][70] +1 other test pass
[69]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-4023-514fac1c82d99307294e5c8a00f91fe5ab0150ab/shard-lnl-1/igt@kms_flip@[email protected]
[70]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-156508v3/shard-lnl-8/igt@kms_flip@[email protected]
* igt@kms_plane_multiple@2x-tiling-4:
- shard-bmg: [SKIP][71] ([Intel XE#4596]) -> [PASS][72]
[71]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-4023-514fac1c82d99307294e5c8a00f91fe5ab0150ab/shard-bmg-6/igt@[email protected]
[72]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-156508v3/shard-bmg-2/igt@[email protected]
* igt@kms_vblank@ts-continuation-suspend:
- shard-adlp: [DMESG-WARN][73] ([Intel XE#2953] / [Intel XE#4173]) -> [PASS][74] +7 other tests pass
[73]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-4023-514fac1c82d99307294e5c8a00f91fe5ab0150ab/shard-adlp-8/igt@[email protected]
[74]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-156508v3/shard-adlp-3/igt@[email protected]
* igt@xe_exec_basic@many-basic-defer-mmap:
- shard-dg2-set2: [FAIL][75] -> [PASS][76]
[75]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-4023-514fac1c82d99307294e5c8a00f91fe5ab0150ab/shard-dg2-435/igt@[email protected]
[76]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-156508v3/shard-dg2-466/igt@[email protected]
* igt@xe_gt_freq@freq_fixed_idle:
- shard-dg2-set2: [FAIL][77] ([Intel XE#6407]) -> [PASS][78]
[77]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-4023-514fac1c82d99307294e5c8a00f91fe5ab0150ab/shard-dg2-432/igt@xe_gt_freq@freq_fixed_idle.html
[78]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-156508v3/shard-dg2-463/igt@xe_gt_freq@freq_fixed_idle.html
#### Warnings ####
* igt@kms_ccs@random-ccs-data-4-tiled-dg2-rc-ccs-cc:
- shard-dg2-set2: [INCOMPLETE][79] ([Intel XE#1727] / [Intel XE#2705] / [Intel XE#3113] / [Intel XE#4212] / [Intel XE#4345] / [Intel XE#4522]) -> [INCOMPLETE][80] ([Intel XE#1727] / [Intel XE#3113] / [Intel XE#4345] / [Intel XE#6168])
[79]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-4023-514fac1c82d99307294e5c8a00f91fe5ab0150ab/shard-dg2-435/igt@[email protected]
[80]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-156508v3/shard-dg2-466/igt@[email protected]
* igt@kms_frontbuffer_tracking@drrs-2p-primscrn-shrfb-msflip-blt:
- shard-bmg: [SKIP][81] ([Intel XE#2312]) -> [SKIP][82] ([Intel XE#2311]) +6 other tests skip
[81]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-4023-514fac1c82d99307294e5c8a00f91fe5ab0150ab/shard-bmg-6/igt@[email protected]
[82]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-156508v3/shard-bmg-2/igt@[email protected]
* igt@kms_frontbuffer_tracking@drrs-2p-primscrn-spr-indfb-draw-render:
- shard-bmg: [SKIP][83] ([Intel XE#2311]) -> [SKIP][84] ([Intel XE#2312]) +11 other tests skip
[83]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-4023-514fac1c82d99307294e5c8a00f91fe5ab0150ab/shard-bmg-4/igt@kms_frontbuffer_tracking@drrs-2p-primscrn-spr-indfb-draw-render.html
[84]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-156508v3/shard-bmg-6/igt@kms_frontbuffer_tracking@drrs-2p-primscrn-spr-indfb-draw-render.html
* igt@kms_frontbuffer_tracking@fbc-2p-primscrn-shrfb-msflip-blt:
- shard-bmg: [SKIP][85] ([Intel XE#2312]) -> [SKIP][86] ([Intel XE#5390]) +1 other test skip
[85]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-4023-514fac1c82d99307294e5c8a00f91fe5ab0150ab/shard-bmg-6/igt@[email protected]
[86]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-156508v3/shard-bmg-1/igt@[email protected]
* igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-spr-indfb-draw-render:
- shard-bmg: [SKIP][87] ([Intel XE#5390]) -> [SKIP][88] ([Intel XE#2312]) +8 other tests skip
[87]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-4023-514fac1c82d99307294e5c8a00f91fe5ab0150ab/shard-bmg-4/igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-spr-indfb-draw-render.html
[88]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-156508v3/shard-bmg-6/igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-spr-indfb-draw-render.html
* igt@kms_frontbuffer_tracking@fbcpsr-2p-primscrn-spr-indfb-onoff:
- shard-bmg: [SKIP][89] ([Intel XE#2312]) -> [SKIP][90] ([Intel XE#2313]) +7 other tests skip
[89]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-4023-514fac1c82d99307294e5c8a00f91fe5ab0150ab/shard-bmg-6/igt@[email protected]
[90]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-156508v3/shard-bmg-1/igt@[email protected]
* igt@kms_frontbuffer_tracking@psr-2p-primscrn-cur-indfb-onoff:
- shard-bmg: [SKIP][91] ([Intel XE#2313]) -> [SKIP][92] ([Intel XE#2312]) +11 other tests skip
[91]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-4023-514fac1c82d99307294e5c8a00f91fe5ab0150ab/shard-bmg-1/igt@[email protected]
[92]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-156508v3/shard-bmg-6/igt@[email protected]
[Intel XE#1124]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1124
[Intel XE#1406]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1406
[Intel XE#1475]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1475
[Intel XE#1489]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1489
[Intel XE#1503]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1503
[Intel XE#1727]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1727
[Intel XE#2291]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2291
[Intel XE#2311]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2311
[Intel XE#2312]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2312
[Intel XE#2313]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2313
[Intel XE#2314]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2314
[Intel XE#2316]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2316
[Intel XE#2652]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2652
[Intel XE#2705]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2705
[Intel XE#2850]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2850
[Intel XE#288]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/288
[Intel XE#2894]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2894
[Intel XE#2953]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2953
[Intel XE#3009]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/3009
[Intel XE#301]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/301
[Intel XE#3113]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/3113
[Intel XE#323]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/323
[Intel XE#346]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/346
[Intel XE#3573]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/3573
[Intel XE#3868]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/3868
[Intel XE#3908]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/3908
[Intel XE#4173]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/4173
[Intel XE#4212]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/4212
[Intel XE#4345]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/4345
[Intel XE#4504]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/4504
[Intel XE#4522]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/4522
[Intel XE#4543]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/4543
[Intel XE#455]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/455
[Intel XE#4596]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/4596
[Intel XE#4837]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/4837
[Intel XE#4915]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/4915
[Intel XE#5213]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/5213
[Intel XE#5354]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/5354
[Intel XE#5390]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/5390
[Intel XE#5545]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/5545
[Intel XE#5893]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/5893
[Intel XE#6168]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/6168
[Intel XE#6312]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/6312
[Intel XE#6321]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/6321
[Intel XE#6407]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/6407
[Intel XE#651]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/651
[Intel XE#653]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/653
[Intel XE#787]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/787
[Intel XE#870]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/870
[Intel XE#929]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/929
Build changes
-------------
* Linux: xe-4023-514fac1c82d99307294e5c8a00f91fe5ab0150ab -> xe-pw-156508v3
IGT_8604: 8604
xe-4023-514fac1c82d99307294e5c8a00f91fe5ab0150ab: 514fac1c82d99307294e5c8a00f91fe5ab0150ab
xe-pw-156508v3: 156508v3
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-156508v3/index.html
Quoted 6 lines · Matthew Brost
We likely need multiple page fault producers feeding into a common consumer backend. Additionally, our current page fault work queue design—being per-GT rather than per-device—makes little sense. Clean up pagefault handling with clear layers.
Matt
I ran some HPC performance test with the series, feel free to add: