Enable/Disable DC balance along with VRR DSB
Subsystems (3)
cover Enable/Disable DC balance along with VRR DSB
Control DC Balance Adjustment bit to accomodate changes along with VRR DSB implementation.
Mitul Golani (16):
drm/i915/display: Add source param for dc balance drm/i915/vrr: Add VRR DC balance registers drm/i915/vrr: Add DC Balance params to crtc_state drm/i915/vrr: Add state dump for DC Balance params drm/i915/vrr: Add compute config for DC Balance params drm/i915/display: Add DC Balance flip counter in crtc drm/i915/vrr: Increment DC balance flip count on every flip drm/i915/vrr: Add function to reset DC Balance flip count drm/i915/vrr: Add function reset DC balance accumulated params drm/i915/vrr: Write DC balance params to hw registers drm/i915/vrr: Configure DC balance flipline adjustment drm/i915/display: Wait for VRR PUSH status update drm/i915/display: Add function to configure event for dc balance drm/i915/vrr: Enable Adaptive sync counter bit drm/i915/vrr: Enable DC Balance
drm/i915/vrr: Add function to check if DC Balance Possible
Ville Syrjälä (6):
drm/i915/dmc: Add pipe dmc registers and bits for DC Balance drm/i915/vrr: Add functions to read out vmin/vmax stuff drm/i915/vblank: Extract vrr_vblank_start() drm/i915/vrr: Implement vblank evasion with DC balancing drm/i915/dsb: Add pipedmc dc balance enable/disable drm/i915/vrr: Pause DC Balancing for DSB commits
drivers/gpu/drm/i915/display/intel_color.c | 1 + .../drm/i915/display/intel_crtc_state_dump.c | 8 + drivers/gpu/drm/i915/display/intel_display.c | 52 ++++ .../drm/i915/display/intel_display_device.h | 1 + .../drm/i915/display/intel_display_types.h | 11 + drivers/gpu/drm/i915/display/intel_dmc.c | 32 +++ drivers/gpu/drm/i915/display/intel_dmc.h | 6 + drivers/gpu/drm/i915/display/intel_dmc_regs.h | 61 ++++- drivers/gpu/drm/i915/display/intel_dsb.c | 31 ++- drivers/gpu/drm/i915/display/intel_vblank.c | 33 ++- drivers/gpu/drm/i915/display/intel_vrr.c | 232 ++++++++++++++++++ drivers/gpu/drm/i915/display/intel_vrr.h | 12 + drivers/gpu/drm/i915/display/intel_vrr_regs.h | 69 ++++++ 13 files changed, 543 insertions(+), 6 deletions(-)
Signature · 1 line
2.48.1
PATCH RESEND 1/22 drm/i915/display: Add source param for dc balance
Add source param for dc balance enablement further.
--v2:
- Arrange in alphabetic order. (Ankit)
- Update name. (Ankit)
--- drivers/gpu/drm/i915/display/intel_display_device.h | 1 + 1 file changed, 1 insertion(+)
drivers/gpu/drm/i915/display/intel_display_device.h +1 -0
@@ -199,6 +199,7 @@ struct intel_display_platforms {#define HAS_ULTRAJOINER (__display) (((__display)->platform.dgfx && \ DISPLAY_VER(__display) == 14) && HAS_DSC(__display))#define HAS_VRR (__display) (DISPLAY_VER(__display) >= 11) +#define HAS_VRR_DC_BALANCE (__display) (DISPLAY_VER(__display) >= 30)#define INTEL_NUM_PIPES (__display) (hweight8(DISPLAY_RUNTIME_INFO(__display)->pipe_mask))#define OVERLAY_NEEDS_PHYSICAL (__display) (DISPLAY_INFO(__display)->overlay_needs_physical)#define SUPPORTS_TV (__display) (DISPLAY_INFO(__display)->supports_tv)
Signature · 1 line
2.48.1
PATCH RESEND 2/22 drm/i915/dmc: Add pipe dmc registers and bits for DC Balance
In reply to Mitul GolaniFrom: Ville Syrjälä <[email protected]>
Add pipe dmc registers and access bits for DC Balance params configuration and enablement.
--v2:
- Separate register definitions for transcoder and pipe dmc. (Ankit)
- Use MMIO pipe macros instead of transcoder ones. (Ankit)
- Remove dev_priv use. (Jani, Nikula)
--v3:
- Add all register address, from capital alphabet to small. (Ankit)
- Add EVT CTL registers.
- Add co-author tag.
- Add event flag for Triggering DC Balance.
--v4:
- Add DCB Flip count and balance reset registers.
--- drivers/gpu/drm/i915/display/intel_dmc_regs.h | 61 ++++++++++++++++++- 1 file changed, 60 insertions(+), 1 deletion(-)
drivers/gpu/drm/i915/display/intel_dmc_regs.h +60 -1
@@ -583,5 +583,64 @@ enum pipedmc_event_id {/* undocumented magic DMC variables */ #define PTL_PIPEDMC_EXEC_TIME_LINES (start_mmioaddr) _MMIO((start_mmioaddr) + 0x6b8)#define PTL_PIPEDMC_END_OF_EXEC_GB (start_mmioaddr) _MMIO((start_mmioaddr) + 0x6c0) - +#define _PIPEDMC_DCB_CTL_A 0x5f1a0 +#define _PIPEDMC_DCB_CTL_B 0x5f5a0 +#define PIPEDMC_DCB_CTL (pipe) _MMIO_PIPE((pipe), _PIPEDMC_DCB_CTL_A,\ + _PIPEDMC_DCB_CTL_B) +#define PIPEDMC_ADAPTIVE_DCB_ENABLE REG_BIT(31) + +#define _PIPEDMC_DCB_VBLANK_A 0x5f1bc +#define _PIPEDMC_DCB_VBLANK_B 0x5f5bc +#define PIPEDMC_DCB_VBLANK (pipe) _MMIO_PIPE((pipe), _PIPEDMC_DCB_VBLANK_A,\ + _PIPEDMC_DCB_VBLANK_B) + +#define _PIPEDMC_DCB_SLOPE_A 0x5f1b8 +#define _PIPEDMC_DCB_SLOPE_B 0x5f5b8 +#define PIPEDMC_DCB_SLOPE (pipe) _MMIO_PIPE((pipe), _PIPEDMC_DCB_SLOPE_A,\ + _PIPEDMC_DCB_SLOPE_B) + +#define _PIPEDMC_DCB_GUARDBAND_A 0x5f1b4 +#define _PIPEDMC_DCB_GUARDBAND_B 0x5f5b4 +#define PIPEDMC_DCB_GUARDBAND (pipe) _MMIO_PIPE((pipe), _PIPEDMC_DCB_GUARDBAND_A,\ + _PIPEDMC_DCB_GUARDBAND_B) + +#define _PIPEDMC_DCB_MAX_INCREASE_A 0x5f1ac +#define _PIPEDMC_DCB_MAX_INCREASE_B 0x5f5ac +#define PIPEDMC_DCB_MAX_INCREASE (pipe) _MMIO_PIPE((pipe), _PIPEDMC_DCB_MAX_INCREASE_A,\ + _PIPEDMC_DCB_MAX_INCREASE_B) + +#define _PIPEDMC_DCB_MAX_DECREASE_A 0x5f1b0 +#define _PIPEDMC_DCB_MAX_DECREASE_B 0x5f5b0 +#define PIPEDMC_DCB_MAX_DECREASE (pipe) _MMIO_PIPE((pipe), _PIPEDMC_DCB_MAX_DECREASE_A,\ + _PIPEDMC_DCB_MAX_DECREASE_B) + +#define _PIPEDMC_DCB_VMIN_A 0x5f1a4 +#define _PIPEDMC_DCB_VMIN_B 0x5f5a4 +#define PIPEDMC_DCB_VMIN (pipe) _MMIO_PIPE((pipe), _PIPEDMC_DCB_VMIN_A,\ + _PIPEDMC_DCB_VMIN_B) + +#define _PIPEDMC_DCB_VMAX_A 0x5f1a8 +#define _PIPEDMC_DCB_VMAX_B 0x5f5a8 +#define PIPEDMC_DCB_VMAX (pipe) _MMIO_PIPE((pipe), _PIPEDMC_DCB_VMAX_A,\ + _PIPEDMC_DCB_VMAX_B) + +#define _PIPEDMC_DCB_DEBUG_A 0x5f1c0 +#define _PIPEDMC_DCB_DEBUG_B 0x5f5c0 +#define PIPEDMC_DCB_DEBUG (pipe) _MMIO_PIPE(pipe, _PIPEDMC_DCB_DEBUG_A,\ + _PIPEDMC_DCB_DEBUG_B) + +#define _PIPEDMC_EVT_CTL_3_A 0x5f040 +#define _PIPEDMC_EVT_CTL_3_B 0x5f440 +#define PIPEDMC_EVT_CTL_3 (pipe) _MMIO_PIPE(pipe, _PIPEDMC_EVT_CTL_3_A,\ + _PIPEDMC_EVT_CTL_3_B) + +#define _PIPEDMC_DCB_FLIP_COUNT_A 0x906A4 +#define _PIPEDMC_DCB_FLIP_COUNT_B 0x986A4 +#define PIPEDMC_DCB_FLIP_COUNT (pipe) _MMIO_PIPE(pipe, _PIPEDMC_EVT_CTL_3_A,\ + _PIPEDMC_DCB_FLIP_COUNT_B) + +#define _PIPEDMC_DCB_BALANCE_RESET_A 0x906A8 +#define _PIPEDMC_DCB_BALANCE_RESET_B 0x986A8 +#define PIPEDMC_DCB_BALANCE_RESET (pipe) _MMIO_PIPE(pipe, _PIPEDMC_DCB_BALANCE_RESET_A,\ + _PIPEDMC_DCB_BALANCE_RESET_B)#endif /* __INTEL_DMC_REGS_H__ */
Signature · 1 line
2.48.1
Re: [RESEND, 02/22] drm/i915/dmc: Add pipe dmc registers and bits for DC Balance
Quoted 33 lines · Mitul Golani
From: Ville Syrjälä <[email protected]>
Add pipe dmc registers and access bits for DC Balance params configuration and enablement.
--v2:
- Separate register definitions for transcoder and pipe dmc. (Ankit)
- Use MMIO pipe macros instead of transcoder ones. (Ankit)
- Removedev_privuse. (Jani, Nikula)--v3:
- Add all register address, from capital alphabet to small. (Ankit)
- Add EVT CTL registers.
- Add co-author tag.
- Add event flag for Triggering DC Balance.--v4:
- Add DCB Flip count and balance reset registers.Co-authored-by Mitul Golani <[email protected]>Signed-off-by Ville Syrjälä <[email protected]>Signed-off-by Mitul Golani <[email protected]>Reviewed-by Ankit Nautiyal <[email protected]>--- drivers/gpu/drm/i915/display/intel_dmc_regs.h | 61 ++++++++++++++++++- 1 file changed, 60 insertions(+), 1 deletion(-)drivers/gpu/drm/i915/display/intel_dmc_regs.h +0
-0
drivers/gpu/drm/i915/display/intel_dmc_regs.h enum pipedmc_event_id { · line 590
Quoted 9 lines
drivers/gpu/drm/i915/display/intel_dmc_regs.h +5
-1@@ -583,5 +583,64 @@ enum pipedmc_event_id {/* undocumented magic DMC variables */ #define PTL_PIPEDMC_EXEC_TIME_LINES (start_mmioaddr) _MMIO((start_mmioaddr) + 0x6b8)#define PTL_PIPEDMC_END_OF_EXEC_GB (start_mmioaddr) _MMIO((start_mmioaddr) + 0x6c0) - +#define _PIPEDMC_DCB_CTL_A 0x5f1a0 +#define _PIPEDMC_DCB_CTL_B 0x5f5a0 +#define PIPEDMC_DCB_CTL (pipe) _MMIO_PIPE((pipe), _PIPEDMC_DCB_CTL_A,\ + _PIPEDMC_DCB_CTL_B) +#define PIPEDMC_ADAPTIVE_DCB_ENABLE REG_BIT(31)
Missed to point this out earlier, quoting fromi915_reg.h :
Indent the register content macros using two extra spaces between ``#define`` and the macro name.
Quoted 40 lines
drivers/gpu/drm/i915/display/intel_dmc_regs.h +40
-0+ +#define _PIPEDMC_DCB_VBLANK_A 0x5f1bc +#define _PIPEDMC_DCB_VBLANK_B 0x5f5bc +#define PIPEDMC_DCB_VBLANK (pipe) _MMIO_PIPE((pipe), _PIPEDMC_DCB_VBLANK_A,\ + _PIPEDMC_DCB_VBLANK_B) + +#define _PIPEDMC_DCB_SLOPE_A 0x5f1b8 +#define _PIPEDMC_DCB_SLOPE_B 0x5f5b8 +#define PIPEDMC_DCB_SLOPE (pipe) _MMIO_PIPE((pipe), _PIPEDMC_DCB_SLOPE_A,\ + _PIPEDMC_DCB_SLOPE_B) + +#define _PIPEDMC_DCB_GUARDBAND_A 0x5f1b4 +#define _PIPEDMC_DCB_GUARDBAND_B 0x5f5b4 +#define PIPEDMC_DCB_GUARDBAND (pipe) _MMIO_PIPE((pipe), _PIPEDMC_DCB_GUARDBAND_A,\ + _PIPEDMC_DCB_GUARDBAND_B) + +#define _PIPEDMC_DCB_MAX_INCREASE_A 0x5f1ac +#define _PIPEDMC_DCB_MAX_INCREASE_B 0x5f5ac +#define PIPEDMC_DCB_MAX_INCREASE (pipe) _MMIO_PIPE((pipe), _PIPEDMC_DCB_MAX_INCREASE_A,\ + _PIPEDMC_DCB_MAX_INCREASE_B) + +#define _PIPEDMC_DCB_MAX_DECREASE_A 0x5f1b0 +#define _PIPEDMC_DCB_MAX_DECREASE_B 0x5f5b0 +#define PIPEDMC_DCB_MAX_DECREASE (pipe) _MMIO_PIPE((pipe), _PIPEDMC_DCB_MAX_DECREASE_A,\ + _PIPEDMC_DCB_MAX_DECREASE_B) + +#define _PIPEDMC_DCB_VMIN_A 0x5f1a4 +#define _PIPEDMC_DCB_VMIN_B 0x5f5a4 +#define PIPEDMC_DCB_VMIN (pipe) _MMIO_PIPE((pipe), _PIPEDMC_DCB_VMIN_A,\ + _PIPEDMC_DCB_VMIN_B) + +#define _PIPEDMC_DCB_VMAX_A 0x5f1a8 +#define _PIPEDMC_DCB_VMAX_B 0x5f5a8 +#define PIPEDMC_DCB_VMAX (pipe) _MMIO_PIPE((pipe), _PIPEDMC_DCB_VMAX_A,\ + _PIPEDMC_DCB_VMAX_B) + +#define _PIPEDMC_DCB_DEBUG_A 0x5f1c0 +#define _PIPEDMC_DCB_DEBUG_B 0x5f5c0 +#define PIPEDMC_DCB_DEBUG (pipe) _MMIO_PIPE(pipe, _PIPEDMC_DCB_DEBUG_A,\ + _PIPEDMC_DCB_DEBUG_B)
drivers/gpu/drm/i915/display/intel_dmc_regs.h enum pipedmc_event_id { · line 640
Quoted 10 lines
drivers/gpu/drm/i915/display/intel_dmc_regs.h +10
-0+ +#define _PIPEDMC_EVT_CTL_3_A 0x5f040 +#define _PIPEDMC_EVT_CTL_3_B 0x5f440 +#define PIPEDMC_EVT_CTL_3 (pipe) _MMIO_PIPE(pipe, _PIPEDMC_EVT_CTL_3_A,\ + _PIPEDMC_EVT_CTL_3_B) + +#define _PIPEDMC_DCB_FLIP_COUNT_A 0x906A4 +#define _PIPEDMC_DCB_FLIP_COUNT_B 0x986A4 +#define PIPEDMC_DCB_FLIP_COUNT (pipe) _MMIO_PIPE(pipe, _PIPEDMC_EVT_CTL_3_A,\ + _PIPEDMC_DCB_FLIP_COUNT_B)
This doesn’t seem to be right.
Regards,
Ankit
Quoted 6 lines
drivers/gpu/drm/i915/display/intel_dmc_regs.h +5
-0+ +#define _PIPEDMC_DCB_BALANCE_RESET_A 0x906A8 +#define _PIPEDMC_DCB_BALANCE_RESET_B 0x986A8 +#define PIPEDMC_DCB_BALANCE_RESET (pipe) _MMIO_PIPE(pipe, _PIPEDMC_DCB_BALANCE_RESET_A,\ + _PIPEDMC_DCB_BALANCE_RESET_B)#endif /* __INTEL_DMC_REGS_H__ */
PATCH RESEND 3/22 drm/i915/vrr: Add VRR DC balance registers
In reply to Mitul GolaniAdd VRR register offsets and bits to access DC Balance configuration.
--v2:
- Separate register definitions. (Ankit)
- Remove usage of dev_priv. (Jani, Nikula)
--v3:
- Convert register address offset, from capital to small. (Ankit)
- Move mask bits near to register offsets. (Ankit)
--v4:
- Use _MMIO_TRANS wherever possible. (Jani)
--v5:
- Added LIVE Value registers for VMAX and FLIPLINE as provided by DMC fw
- For pipe B it is temporary and expected to change later once finalised.
--v6:
- Add live value registers for DCB VMAX/FLIPLINE.
--v7:
- Correct commit message file. (Jani Nikula)
- Add bits in highest to lowest order. (Jani Nikula)
--- drivers/gpu/drm/i915/display/intel_vrr_regs.h | 69 +++++++++++++++++++ 1 file changed, 69 insertions(+)
drivers/gpu/drm/i915/display/intel_vrr_regs.h +69 -0
@@ -8,6 +8,74 @@#include "intel_display_reg_defs.h" +/* VRR registers */ +#define _TRANS_VRR_DCB_ADJ_FLIPLINE_CFG_A 0x604d4 +#define _TRANS_VRR_DCB_ADJ_FLIPLINE_CFG_B 0x614d4 +#define TRANS_VRR_DCB_ADJ_FLIPLINE_CFG (trans) _MMIO_TRANS(trans, \ + _TRANS_VRR_DCB_ADJ_FLIPLINE_CFG_A, \ + _TRANS_VRR_DCB_ADJ_FLIPLINE_CFG_B) + +#define _TRANS_VRR_DCB_ADJ_FLIPLINE_CFG_LIVE_A 0x90700 +#define _TRANS_VRR_DCB_ADJ_FLIPLINE_CFG_LIVE_B 0x98700 +#define TRANS_VRR_DCB_ADJ_FLIPLINE_CFG_LIVE (trans) \ + _MMIO_TRANS(trans, \ + _TRANS_VRR_DCB_ADJ_FLIPLINE_CFG_LIVE_A, \ + _TRANS_VRR_DCB_ADJ_FLIPLINE_CFG_LIVE_B) +#define VRR_DCB_ADJ_FLIPLINE_CNT_MASK REG_GENMASK(31, 24) +#define VRR_DCB_ADJ_FLIPLINE_MASK REG_GENMASK(19, 0) +#define VRR_DCB_ADJ_FLIPLINE (flipline) REG_FIELD_PREP(VRR_DCB_ADJ_FLIPLINE_MASK, \ + (flipline)) + +#define _TRANS_VRR_DCB_ADJ_VMAX_CFG_A 0x604d8 +#define _TRANS_VRR_DCB_ADJ_VMAX_CFG_B 0x614d8 +#define TRANS_VRR_DCB_ADJ_VMAX_CFG (trans) _MMIO_TRANS(trans, \ + _TRANS_VRR_DCB_ADJ_VMAX_CFG_A, \ + _TRANS_VRR_DCB_ADJ_VMAX_CFG_B) + +#define _TRANS_VRR_DCB_ADJ_VMAX_CFG_LIVE_A 0x906F8 +#define _TRANS_VRR_DCB_ADJ_VMAX_CFG_LIVE_B 0x986F8 +#define TRANS_VRR_DCB_ADJ_VMAX_CFG_LIVE (trans) _MMIO_TRANS(trans, \ + _TRANS_VRR_DCB_ADJ_VMAX_CFG_LIVE_A, \ + _TRANS_VRR_DCB_ADJ_VMAX_CFG_LIVE_B) +#define VRR_DCB_ADJ_VMAX_CNT_MASK REG_GENMASK(31, 24) +#define VRR_DCB_ADJ_VMAX_MASK REG_GENMASK(19, 0) +#define VRR_DCB_ADJ_VMAX (vmax) REG_FIELD_PREP(VRR_DCB_ADJ_VMAX_MASK, (vmax)) + +#define _TRANS_VRR_DCB_FLIPLINE_A 0x60418 +#define _TRANS_VRR_DCB_FLIPLINE_B 0x61418 +#define TRANS_VRR_DCB_FLIPLINE (trans) _MMIO_TRANS(trans, \ + _TRANS_VRR_DCB_FLIPLINE_A, \ + _TRANS_VRR_DCB_FLIPLINE_B) + +#define _TRANS_VRR_DCB_FLIPLINE_LIVE_A 0x906FC +#define _TRANS_VRR_DCB_FLIPLINE_LIVE_B 0x986FC +#define TRANS_VRR_DCB_FLIPLINE_LIVE (trans) _MMIO_TRANS(trans, \ + _TRANS_VRR_DCB_FLIPLINE_LIVE_A, \ + _TRANS_VRR_DCB_FLIPLINE_LIVE_B) +#define VRR_DCB_FLIPLINE_MASK REG_GENMASK(19, 0) +#define VRR_DCB_FLIPLINE (flipline) REG_FIELD_PREP(VRR_DCB_FLIPLINE_MASK, \ + (flipline)) + +#define _TRANS_VRR_DCB_VMAX_A 0x60414 +#define _TRANS_VRR_DCB_VMAX_B 0x61414 +#define TRANS_VRR_DCB_VMAX (trans) _MMIO_TRANS(trans, \ + _TRANS_VRR_DCB_VMAX_A, \ + _TRANS_VRR_DCB_VMAX_B) +#define _TRANS_VRR_DCB_VMAX_LIVE_A 0x906F4 +#define _TRANS_VRR_DCB_VMAX_LIVE_B 0x986F4 +#define TRANS_VRR_DCB_VMAX_LIVE (trans) _MMIO_TRANS(trans, \ + _TRANS_VRR_DCB_VMAX_LIVE_A, \ + _TRANS_VRR_DCB_VMAX_LIVE_B) +#define VRR_DCB_VMAX_MASK REG_GENMASK(19, 0) +#define VRR_DCB_VMAX (vmax) REG_FIELD_PREP(VRR_DCB_VMAX_MASK, (vmax)) + +#define _TRANS_ADAPTIVE_SYNC_DCB_CTL_A 0x604c0 +#define _TRANS_ADAPTIVE_SYNC_DCB_CTL_B 0x614c0 +#define TRANS_ADAPTIVE_SYNC_DCB_CTL (trans) _MMIO_TRANS(trans, \ + _TRANS_ADAPTIVE_SYNC_DCB_CTL_A, \ + _TRANS_ADAPTIVE_SYNC_DCB_CTL_B) +#define ADAPTIVE_SYNC_COUNTER_EN REG_BIT(31) +#define _TRANS_VRR_CTL_A 0x60420#define _TRANS_VRR_CTL_B 0x61420#define _TRANS_VRR_CTL_C 0x62420
@@ -19,6 +87,7 @@#define VRR_CTL_CMRR_ENABLE REG_BIT(27)#define VRR_CTL_PIPELINE_FULL_MASK REG_GENMASK(10, 3)#define VRR_CTL_PIPELINE_FULL (x) REG_FIELD_PREP(VRR_CTL_PIPELINE_FULL_MASK, (x)) +#define VRR_CTL_DCB_ADJ_ENABLE REG_BIT(28)#define VRR_CTL_PIPELINE_FULL_OVERRIDE REG_BIT(0)#define XELPD_VRR_CTL_VRR_GUARDBAND_MASK REG_GENMASK(15, 0)#define XELPD_VRR_CTL_VRR_GUARDBAND (x) REG_FIELD_PREP(XELPD_VRR_CTL_VRR_GUARDBAND_MASK, (x))
Signature · 1 line
2.48.1
Jani Nikula
maintainerRe: [RESEND, 03/22] drm/i915/vrr: Add VRR DC balance registers
Quoted 1 line · Mitul Golani
Add VRR register offsets and bits to access DC Balance configuration.
v7 and the indentation is still all over the place. Read the big comment near the top of i915_reg.h.
Quoted 116 lines
--v2:
- Separate register definitions. (Ankit)
- Remove usage ofdev_priv. (Jani, Nikula)--v3:
- Convert register address offset, from capital to small. (Ankit)
- Move mask bits near to register offsets. (Ankit)--v4:
- Use_MMIO_TRANSwherever possible. (Jani)--v5:
- Added LIVE Value registers for VMAX and FLIPLINE as provided by DMC fw
- For pipe B it is temporary and expected to change later once finalised.--v6:
- Add live value registers for DCB VMAX/FLIPLINE.--v7:
- Correct commit message file. (Jani Nikula)
- Add bits in highest to lowest order. (Jani Nikula)Signed-off-by Mitul Golani <[email protected]>Reviewed-by Ankit Nautiyal <[email protected]>--- drivers/gpu/drm/i915/display/intel_vrr_regs.h | 69 +++++++++++++++++++ 1 file changed, 69 insertions(+)drivers/gpu/drm/i915/display/intel_vrr_regs.h +69
-0@@ -8,6 +8,74 @@#include "intel_display_reg_defs.h" +/* VRR registers */ +#define _TRANS_VRR_DCB_ADJ_FLIPLINE_CFG_A 0x604d4 +#define _TRANS_VRR_DCB_ADJ_FLIPLINE_CFG_B 0x614d4 +#define TRANS_VRR_DCB_ADJ_FLIPLINE_CFG (trans) _MMIO_TRANS(trans, \ + _TRANS_VRR_DCB_ADJ_FLIPLINE_CFG_A, \ + _TRANS_VRR_DCB_ADJ_FLIPLINE_CFG_B) + +#define _TRANS_VRR_DCB_ADJ_FLIPLINE_CFG_LIVE_A 0x90700 +#define _TRANS_VRR_DCB_ADJ_FLIPLINE_CFG_LIVE_B 0x98700 +#define TRANS_VRR_DCB_ADJ_FLIPLINE_CFG_LIVE (trans) \ + _MMIO_TRANS(trans, \ + _TRANS_VRR_DCB_ADJ_FLIPLINE_CFG_LIVE_A, \ + _TRANS_VRR_DCB_ADJ_FLIPLINE_CFG_LIVE_B) +#define VRR_DCB_ADJ_FLIPLINE_CNT_MASK REG_GENMASK(31, 24) +#define VRR_DCB_ADJ_FLIPLINE_MASK REG_GENMASK(19, 0) +#define VRR_DCB_ADJ_FLIPLINE (flipline) REG_FIELD_PREP(VRR_DCB_ADJ_FLIPLINE_MASK, \ + (flipline)) + +#define _TRANS_VRR_DCB_ADJ_VMAX_CFG_A 0x604d8 +#define _TRANS_VRR_DCB_ADJ_VMAX_CFG_B 0x614d8 +#define TRANS_VRR_DCB_ADJ_VMAX_CFG (trans) _MMIO_TRANS(trans, \ + _TRANS_VRR_DCB_ADJ_VMAX_CFG_A, \ + _TRANS_VRR_DCB_ADJ_VMAX_CFG_B) + +#define _TRANS_VRR_DCB_ADJ_VMAX_CFG_LIVE_A 0x906F8 +#define _TRANS_VRR_DCB_ADJ_VMAX_CFG_LIVE_B 0x986F8 +#define TRANS_VRR_DCB_ADJ_VMAX_CFG_LIVE (trans) _MMIO_TRANS(trans, \ + _TRANS_VRR_DCB_ADJ_VMAX_CFG_LIVE_A, \ + _TRANS_VRR_DCB_ADJ_VMAX_CFG_LIVE_B) +#define VRR_DCB_ADJ_VMAX_CNT_MASK REG_GENMASK(31, 24) +#define VRR_DCB_ADJ_VMAX_MASK REG_GENMASK(19, 0) +#define VRR_DCB_ADJ_VMAX (vmax) REG_FIELD_PREP(VRR_DCB_ADJ_VMAX_MASK, (vmax)) + +#define _TRANS_VRR_DCB_FLIPLINE_A 0x60418 +#define _TRANS_VRR_DCB_FLIPLINE_B 0x61418 +#define TRANS_VRR_DCB_FLIPLINE (trans) _MMIO_TRANS(trans, \ + _TRANS_VRR_DCB_FLIPLINE_A, \ + _TRANS_VRR_DCB_FLIPLINE_B) + +#define _TRANS_VRR_DCB_FLIPLINE_LIVE_A 0x906FC +#define _TRANS_VRR_DCB_FLIPLINE_LIVE_B 0x986FC +#define TRANS_VRR_DCB_FLIPLINE_LIVE (trans) _MMIO_TRANS(trans, \ + _TRANS_VRR_DCB_FLIPLINE_LIVE_A, \ + _TRANS_VRR_DCB_FLIPLINE_LIVE_B) +#define VRR_DCB_FLIPLINE_MASK REG_GENMASK(19, 0) +#define VRR_DCB_FLIPLINE (flipline) REG_FIELD_PREP(VRR_DCB_FLIPLINE_MASK, \ + (flipline)) + +#define _TRANS_VRR_DCB_VMAX_A 0x60414 +#define _TRANS_VRR_DCB_VMAX_B 0x61414 +#define TRANS_VRR_DCB_VMAX (trans) _MMIO_TRANS(trans, \ + _TRANS_VRR_DCB_VMAX_A, \ + _TRANS_VRR_DCB_VMAX_B) +#define _TRANS_VRR_DCB_VMAX_LIVE_A 0x906F4 +#define _TRANS_VRR_DCB_VMAX_LIVE_B 0x986F4 +#define TRANS_VRR_DCB_VMAX_LIVE (trans) _MMIO_TRANS(trans, \ + _TRANS_VRR_DCB_VMAX_LIVE_A, \ + _TRANS_VRR_DCB_VMAX_LIVE_B) +#define VRR_DCB_VMAX_MASK REG_GENMASK(19, 0) +#define VRR_DCB_VMAX (vmax) REG_FIELD_PREP(VRR_DCB_VMAX_MASK, (vmax)) + +#define _TRANS_ADAPTIVE_SYNC_DCB_CTL_A 0x604c0 +#define _TRANS_ADAPTIVE_SYNC_DCB_CTL_B 0x614c0 +#define TRANS_ADAPTIVE_SYNC_DCB_CTL (trans) _MMIO_TRANS(trans, \ + _TRANS_ADAPTIVE_SYNC_DCB_CTL_A, \ + _TRANS_ADAPTIVE_SYNC_DCB_CTL_B) +#define ADAPTIVE_SYNC_COUNTER_EN REG_BIT(31) +#define _TRANS_VRR_CTL_A 0x60420#define _TRANS_VRR_CTL_B 0x61420#define _TRANS_VRR_CTL_C 0x62420@@ -19,6 +87,7 @@#define VRR_CTL_CMRR_ENABLE REG_BIT(27)#define VRR_CTL_PIPELINE_FULL_MASK REG_GENMASK(10, 3)#define VRR_CTL_PIPELINE_FULL (x) REG_FIELD_PREP(VRR_CTL_PIPELINE_FULL_MASK, (x)) +#define VRR_CTL_DCB_ADJ_ENABLE REG_BIT(28)#define VRR_CTL_PIPELINE_FULL_OVERRIDE REG_BIT(0)#define XELPD_VRR_CTL_VRR_GUARDBAND_MASK REG_GENMASK(15, 0)#define XELPD_VRR_CTL_VRR_GUARDBAND (x) REG_FIELD_PREP(XELPD_VRR_CTL_VRR_GUARDBAND_MASK, (x))
Signature · 1 line
Jani Nikula, Intel
Re: [RESEND, 03/22] drm/i915/vrr: Add VRR DC balance registers
In reply to Mitul GolaniQuoted 41 lines · Mitul Golani
Add VRR register offsets and bits to access DC Balance configuration.
--v2:
- Separate register definitions. (Ankit)
- Remove usage ofdev_priv. (Jani, Nikula)--v3:
- Convert register address offset, from capital to small. (Ankit)
- Move mask bits near to register offsets. (Ankit)--v4:
- Use_MMIO_TRANSwherever possible. (Jani)--v5:
- Added LIVE Value registers for VMAX and FLIPLINE as provided by DMC fw
- For pipe B it is temporary and expected to change later once finalised.--v6:
- Add live value registers for DCB VMAX/FLIPLINE.--v7:
- Correct commit message file. (Jani Nikula)
- Add bits in highest to lowest order. (Jani Nikula)Signed-off-by Mitul Golani <[email protected]>Reviewed-by Ankit Nautiyal <[email protected]>--- drivers/gpu/drm/i915/display/intel_vrr_regs.h | 69 +++++++++++++++++++ 1 file changed, 69 insertions(+)drivers/gpu/drm/i915/display/intel_vrr_regs.h +3
-0@@ -8,6 +8,74 @@#include "intel_display_reg_defs.h" +/* VRR registers */ +#define _TRANS_VRR_DCB_ADJ_FLIPLINE_CFG_A 0x604d4 +#define _TRANS_VRR_DCB_ADJ_FLIPLINE_CFG_B 0x614d4
drivers/gpu/drm/i915/display/intel_vrr_regs.h line 23
Quoted 10 lines
drivers/gpu/drm/i915/display/intel_vrr_regs.h +10
-0+#define TRANS_VRR_DCB_ADJ_FLIPLINE_CFG (trans) _MMIO_TRANS(trans, \ + _TRANS_VRR_DCB_ADJ_FLIPLINE_CFG_A, \ + _TRANS_VRR_DCB_ADJ_FLIPLINE_CFG_B) + +#define _TRANS_VRR_DCB_ADJ_FLIPLINE_CFG_LIVE_A 0x90700 +#define _TRANS_VRR_DCB_ADJ_FLIPLINE_CFG_LIVE_B 0x98700 +#define TRANS_VRR_DCB_ADJ_FLIPLINE_CFG_LIVE (trans) \ + _MMIO_TRANS(trans, \ + _TRANS_VRR_DCB_ADJ_FLIPLINE_CFG_LIVE_A, \ + _TRANS_VRR_DCB_ADJ_FLIPLINE_CFG_LIVE_B)
This is a bit awkward to read, can we have this in same line. I understand this will be more than 100 chars but IMO that should be alright.
Regards,
Ankit
Quoted 66 lines
drivers/gpu/drm/i915/display/intel_vrr_regs.h +56
-0+#define VRR_DCB_ADJ_FLIPLINE_CNT_MASK REG_GENMASK(31, 24) +#define VRR_DCB_ADJ_FLIPLINE_MASK REG_GENMASK(19, 0) +#define VRR_DCB_ADJ_FLIPLINE (flipline) REG_FIELD_PREP(VRR_DCB_ADJ_FLIPLINE_MASK, \ + (flipline)) + +#define _TRANS_VRR_DCB_ADJ_VMAX_CFG_A 0x604d8 +#define _TRANS_VRR_DCB_ADJ_VMAX_CFG_B 0x614d8 +#define TRANS_VRR_DCB_ADJ_VMAX_CFG (trans) _MMIO_TRANS(trans, \ + _TRANS_VRR_DCB_ADJ_VMAX_CFG_A, \ + _TRANS_VRR_DCB_ADJ_VMAX_CFG_B) + +#define _TRANS_VRR_DCB_ADJ_VMAX_CFG_LIVE_A 0x906F8 +#define _TRANS_VRR_DCB_ADJ_VMAX_CFG_LIVE_B 0x986F8 +#define TRANS_VRR_DCB_ADJ_VMAX_CFG_LIVE (trans) _MMIO_TRANS(trans, \ + _TRANS_VRR_DCB_ADJ_VMAX_CFG_LIVE_A, \ + _TRANS_VRR_DCB_ADJ_VMAX_CFG_LIVE_B) +#define VRR_DCB_ADJ_VMAX_CNT_MASK REG_GENMASK(31, 24) +#define VRR_DCB_ADJ_VMAX_MASK REG_GENMASK(19, 0) +#define VRR_DCB_ADJ_VMAX (vmax) REG_FIELD_PREP(VRR_DCB_ADJ_VMAX_MASK, (vmax)) + +#define _TRANS_VRR_DCB_FLIPLINE_A 0x60418 +#define _TRANS_VRR_DCB_FLIPLINE_B 0x61418 +#define TRANS_VRR_DCB_FLIPLINE (trans) _MMIO_TRANS(trans, \ + _TRANS_VRR_DCB_FLIPLINE_A, \ + _TRANS_VRR_DCB_FLIPLINE_B) + +#define _TRANS_VRR_DCB_FLIPLINE_LIVE_A 0x906FC +#define _TRANS_VRR_DCB_FLIPLINE_LIVE_B 0x986FC +#define TRANS_VRR_DCB_FLIPLINE_LIVE (trans) _MMIO_TRANS(trans, \ + _TRANS_VRR_DCB_FLIPLINE_LIVE_A, \ + _TRANS_VRR_DCB_FLIPLINE_LIVE_B) +#define VRR_DCB_FLIPLINE_MASK REG_GENMASK(19, 0) +#define VRR_DCB_FLIPLINE (flipline) REG_FIELD_PREP(VRR_DCB_FLIPLINE_MASK, \ + (flipline)) + +#define _TRANS_VRR_DCB_VMAX_A 0x60414 +#define _TRANS_VRR_DCB_VMAX_B 0x61414 +#define TRANS_VRR_DCB_VMAX (trans) _MMIO_TRANS(trans, \ + _TRANS_VRR_DCB_VMAX_A, \ + _TRANS_VRR_DCB_VMAX_B) +#define _TRANS_VRR_DCB_VMAX_LIVE_A 0x906F4 +#define _TRANS_VRR_DCB_VMAX_LIVE_B 0x986F4 +#define TRANS_VRR_DCB_VMAX_LIVE (trans) _MMIO_TRANS(trans, \ + _TRANS_VRR_DCB_VMAX_LIVE_A, \ + _TRANS_VRR_DCB_VMAX_LIVE_B) +#define VRR_DCB_VMAX_MASK REG_GENMASK(19, 0) +#define VRR_DCB_VMAX (vmax) REG_FIELD_PREP(VRR_DCB_VMAX_MASK, (vmax)) + +#define _TRANS_ADAPTIVE_SYNC_DCB_CTL_A 0x604c0 +#define _TRANS_ADAPTIVE_SYNC_DCB_CTL_B 0x614c0 +#define TRANS_ADAPTIVE_SYNC_DCB_CTL (trans) _MMIO_TRANS(trans, \ + _TRANS_ADAPTIVE_SYNC_DCB_CTL_A, \ + _TRANS_ADAPTIVE_SYNC_DCB_CTL_B) +#define ADAPTIVE_SYNC_COUNTER_EN REG_BIT(31) +#define _TRANS_VRR_CTL_A 0x60420#define _TRANS_VRR_CTL_B 0x61420#define _TRANS_VRR_CTL_C 0x62420@@ -19,6 +87,7 @@#define VRR_CTL_CMRR_ENABLE REG_BIT(27)#define VRR_CTL_PIPELINE_FULL_MASK REG_GENMASK(10, 3)#define VRR_CTL_PIPELINE_FULL (x) REG_FIELD_PREP(VRR_CTL_PIPELINE_FULL_MASK, (x)) +#define VRR_CTL_DCB_ADJ_ENABLE REG_BIT(28)#define VRR_CTL_PIPELINE_FULL_OVERRIDE REG_BIT(0)#define XELPD_VRR_CTL_VRR_GUARDBAND_MASK REG_GENMASK(15, 0)#define XELPD_VRR_CTL_VRR_GUARDBAND (x) REG_FIELD_PREP(XELPD_VRR_CTL_VRR_GUARDBAND_MASK, (x))
PATCH RESEND 4/22 drm/i915/vrr: Add functions to read out vmin/vmax stuff
In reply to Mitul GolaniFrom: Ville Syrjälä <[email protected]>
Calculate delayed vblank start position with the help of added vmin/vmax stuff for next frame and final computation.
--v2:
- Correct Author details.
--v3:
- Separate register details from this patch.
--v4:
- Add mask macros.
--v5:
- As live prefix params indicate timings for current frame, read just _live prefix values instead of next frame timings as done previously.
- Squash Refactor vrr params patch.
--- drivers/gpu/drm/i915/display/intel_vrr.c | 56 ++++++++++++++++++++++++ drivers/gpu/drm/i915/display/intel_vrr.h | 5 +++ 2 files changed, 61 insertions(+)
drivers/gpu/drm/i915/display/intel_vrr.c +56 -0
@@ -261,6 +261,12 @@ static int intel_vrr_hw_value(const struct intel_crtc_state *crtc_state,return value - crtc_state->set_context_latency; } +static int intel_vrr_vblank_start (const struct intel_crtc_state *crtc_state, +int vmin_vmax) +{ +return intel_vrr_hw_value (crtc_state, vmin_vmax) - crtc_state->vrr.guardband; +} +/* * For fixed refresh rate mode Vmin, Vmax and Flipline all are set to * Vtotal value.
@@ -898,3 +904,53 @@ int intel_vrr_vmin_safe_window_end(const struct intel_crtc_state *crtc_state)return intel_vrr_vmin_vblank_start (crtc_state) - crtc_state->set_context_latency; } + +int intel_vrr_dcb_vmin_vblank_start_next (const struct intel_crtc_state *crtc_state) +{ +struct intel_display *display =to_intel_display (crtc_state); +enum transcoder cpu_transcoder = crtc_state->cpu_transcoder; +u32 tmp =0 ; + + tmp =intel_de_read (display,TRANS_VRR_DCB_ADJ_FLIPLINE_CFG_LIVE (cpu_transcoder)); + +if (REG_FIELD_GET (VRR_DCB_ADJ_FLIPLINE_CNT_MASK , tmp) ==0 ) +return -1 ; + +return intel_vrr_vblank_start (crtc_state,VRR_DCB_ADJ_FLIPLINE (tmp) +1 ); +} + +int intel_vrr_dcb_vmax_vblank_start_next (const struct intel_crtc_state *crtc_state) +{ +struct intel_display *display =to_intel_display (crtc_state); +enum transcoder cpu_transcoder = crtc_state->cpu_transcoder; +u32 tmp =0 ; + + tmp =intel_de_read (display,TRANS_VRR_DCB_ADJ_VMAX_CFG_LIVE (cpu_transcoder)); + +if (REG_FIELD_GET (VRR_DCB_ADJ_VMAX_CNT_MASK , tmp) ==0 ) +return -1 ; + +return intel_vrr_vblank_start (crtc_state,VRR_DCB_ADJ_VMAX (tmp) +1 ); +} + +int intel_vrr_dcb_vmin_vblank_start_final (const struct intel_crtc_state *crtc_state) +{ +struct intel_display *display =to_intel_display (crtc_state); +enum transcoder cpu_transcoder = crtc_state->cpu_transcoder; +u32 tmp =0 ; + + tmp =intel_de_read (display,TRANS_VRR_DCB_FLIPLINE_LIVE (cpu_transcoder)); + +return intel_vrr_vblank_start (crtc_state,VRR_DCB_FLIPLINE (tmp) +1 ); +} + +int intel_vrr_dcb_vmax_vblank_start_final (const struct intel_crtc_state *crtc_state) +{ +struct intel_display *display =to_intel_display (crtc_state); +enum transcoder cpu_transcoder = crtc_state->cpu_transcoder; +u32 tmp =0 ; + + tmp =intel_de_read (display,TRANS_VRR_DCB_VMAX_LIVE (cpu_transcoder)); + +return intel_vrr_vblank_start (crtc_state,VRR_DCB_VMAX (tmp) +1 ); +}
drivers/gpu/drm/i915/display/intel_vrr.h +5 -0
@@ -43,4 +43,9 @@ bool intel_vrr_always_use_vrr_tg(struct intel_display *display);int intel_vrr_safe_window_start (const struct intel_crtc_state *crtc_state);int intel_vrr_vmin_safe_window_end (const struct intel_crtc_state *crtc_state); +int intel_vrr_dcb_vmin_vblank_start_next (const struct intel_crtc_state *crtc_state); +int intel_vrr_dcb_vmax_vblank_start_next (const struct intel_crtc_state *crtc_state); +int intel_vrr_dcb_vmin_vblank_start_final (const struct intel_crtc_state *crtc_state); +int intel_vrr_dcb_vmax_vblank_start_final (const struct intel_crtc_state *crtc_state); +#endif /* __INTEL_VRR_H__ */
Signature · 1 line
2.48.1
PATCH RESEND 5/22 drm/i915/vrr: Add DC Balance params to crtc_state
In reply to Mitul GolaniAdd DC Balance params to crtc_state, also add state checker params for related properties.
--v3:
- Seggregate crtc_state params with this patch. (Ankit)
--v4:
- Update commit message and header. (Ankit)
- Add +1 to VMIN and VMAX only when it is non-zero. (Ankit)
--v5:
- Add headers in sorted order. (Jani Nikula)
--- drivers/gpu/drm/i915/display/intel_display.c | 7 ++++++ .../drm/i915/display/intel_display_types.h | 7 ++++++ drivers/gpu/drm/i915/display/intel_vrr.c | 22 +++++++++++++++++++ 3 files changed, 36 insertions(+)
drivers/gpu/drm/i915/display/intel_display.c +7 -0
@@ -5470,6 +5470,13 @@ intel_pipe_config_compare(const struct intel_crtc_state *current_config,PIPE_CONF_CHECK_LLI (cmrr.cmrr_m);PIPE_CONF_CHECK_LLI (cmrr.cmrr_n);PIPE_CONF_CHECK_BOOL (cmrr.enable); +PIPE_CONF_CHECK_I (vrr.dc_balance.vmin); +PIPE_CONF_CHECK_I (vrr.dc_balance.vmax); +PIPE_CONF_CHECK_I (vrr.dc_balance.guardband); +PIPE_CONF_CHECK_I (vrr.dc_balance.slope); +PIPE_CONF_CHECK_I (vrr.dc_balance.max_increase); +PIPE_CONF_CHECK_I (vrr.dc_balance.max_decrease); +PIPE_CONF_CHECK_I (vrr.dc_balance.vblank_target); }if (!fastset ||intel_vrr_always_use_vrr_tg (display)) {
drivers/gpu/drm/i915/display/intel_display_types.h +7 -0
@@ -1358,6 +1358,13 @@ struct intel_crtc_state {u8 pipeline_full;u16 flipline, vmin, vmax, guardband;u32 vsync_end, vsync_start; +struct { +bool enable; +u16 vmin, vmax; +u16 guardband, slope; +u16 max_increase, max_decrease; +u16 vblank_target; + } dc_balance; } vrr;/* Content Match Refresh Rate state */
drivers/gpu/drm/i915/display/intel_vrr.c +22 -0
@@ -9,6 +9,7 @@#include "intel_de.h" #include "intel_display_regs.h" #include "intel_display_types.h" +#include "intel_dmc_regs.h" #include "intel_dp.h" #include "intel_psr.h" #include "intel_vrr.h"
@@ -789,6 +790,8 @@ void intel_vrr_get_config(struct intel_crtc_state *crtc_state) {struct intel_display *display =to_intel_display (crtc_state);enum transcoder cpu_transcoder = crtc_state->cpu_transcoder; +struct intel_crtc *crtc =to_intel_crtc (crtc_state->uapi.crtc); +enum pipe pipe = crtc->pipe;u32 trans_vrr_ctl, trans_vrr_vsync;bool vrr_enable;
@@ -866,6 +869,25 @@ void intel_vrr_get_config(struct intel_crtc_state *crtc_state)else crtc_state->vrr.enable = vrr_enable; +if (HAS_VRR_DC_BALANCE (display)) { + crtc_state->vrr.dc_balance.vmin = +intel_de_read (display,PIPEDMC_DCB_VMIN (pipe)) ? +intel_de_read (display,PIPEDMC_DCB_VMIN (pipe)) +1 :0 ; + crtc_state->vrr.dc_balance.vmax = +intel_de_read (display,PIPEDMC_DCB_VMAX (pipe)) ? +intel_de_read (display,PIPEDMC_DCB_VMAX (pipe)) +1 :0 ; + crtc_state->vrr.dc_balance.guardband = +intel_de_read (display,PIPEDMC_DCB_GUARDBAND (pipe)); + crtc_state->vrr.dc_balance.max_increase = +intel_de_read (display,PIPEDMC_DCB_MAX_INCREASE (pipe)); + crtc_state->vrr.dc_balance.max_decrease = +intel_de_read (display,PIPEDMC_DCB_MAX_DECREASE (pipe)); + crtc_state->vrr.dc_balance.slope = +intel_de_read (display,PIPEDMC_DCB_SLOPE (pipe)); + crtc_state->vrr.dc_balance.vblank_target = +intel_de_read (display,PIPEDMC_DCB_VBLANK (pipe)); + } +/* * #TODO: For Both VRR and CMRR the flag I915_MODE_FLAG_VRR is set for mode_flags. * Since CMRR is currently disabled, set this flag for VRR for now.
Signature · 1 line
2.48.1
Re: [RESEND, 05/22] drm/i915/vrr: Add DC Balance params to crtc_state
Quoted 79 lines · Mitul Golani
Add DC Balance params to
crtc_state, also add state checker params for related properties.--v3:
- Seggregatecrtc_stateparams with this patch. (Ankit)--v4:
- Update commit message and header. (Ankit)
- Add +1 to VMIN and VMAX only when it is non-zero. (Ankit)--v5:
- Add headers in sorted order. (Jani Nikula)Signed-off-by Mitul Golani <[email protected]>Reviewed-by Ankit Nautiyal <[email protected]>--- drivers/gpu/drm/i915/display/intel_display.c | 7 ++++++ .../drm/i915/display/intel_display_types.h | 7 ++++++ drivers/gpu/drm/i915/display/intel_vrr.c | 22 +++++++++++++++++++ 3 files changed, 36 insertions(+)drivers/gpu/drm/i915/display/intel_display.c +7
-0@@ -5470,6 +5470,13 @@ intel_pipe_config_compare(const struct intel_crtc_state *current_config,PIPE_CONF_CHECK_LLI (cmrr.cmrr_m);PIPE_CONF_CHECK_LLI (cmrr.cmrr_n);PIPE_CONF_CHECK_BOOL (cmrr.enable); +PIPE_CONF_CHECK_I (vrr.dc_balance.vmin); +PIPE_CONF_CHECK_I (vrr.dc_balance.vmax); +PIPE_CONF_CHECK_I (vrr.dc_balance.guardband); +PIPE_CONF_CHECK_I (vrr.dc_balance.slope); +PIPE_CONF_CHECK_I (vrr.dc_balance.max_increase); +PIPE_CONF_CHECK_I (vrr.dc_balance.max_decrease); +PIPE_CONF_CHECK_I (vrr.dc_balance.vblank_target); }if (!fastset ||intel_vrr_always_use_vrr_tg (display)) {drivers/gpu/drm/i915/display/intel_display_types.h +7
-0@@ -1358,6 +1358,13 @@ struct intel_crtc_state {u8 pipeline_full;u16 flipline, vmin, vmax, guardband;u32 vsync_end, vsync_start; +struct { +bool enable; +u16 vmin, vmax; +u16 guardband, slope; +u16 max_increase, max_decrease; +u16 vblank_target; + } dc_balance; } vrr;/* Content Match Refresh Rate state */ drivers/gpu/drm/i915/display/intel_vrr.c +3
-0@@ -9,6 +9,7 @@#include "intel_de.h" #include "intel_display_regs.h" #include "intel_display_types.h" +#include "intel_dmc_regs.h" #include "intel_dp.h" #include "intel_psr.h" #include "intel_vrr.h" @@ -789,6 +790,8 @@ void intel_vrr_get_config(struct intel_crtc_state *crtc_state) {struct intel_display *display =to_intel_display (crtc_state);enum transcoder cpu_transcoder = crtc_state->cpu_transcoder; +struct intel_crtc *crtc =to_intel_crtc (crtc_state->uapi.crtc); +enum pipe pipe = crtc->pipe;u32 trans_vrr_ctl, trans_vrr_vsync;bool vrr_enable;
drivers/gpu/drm/i915/display/intel_vrr.c void intel_vrr_get_config(struct intel_crtc_state *crtc_state) · line 875
Quoted 7 lines
drivers/gpu/drm/i915/display/intel_vrr.c +4
-0@@ -866,6 +869,25 @@ void intel_vrr_get_config(struct intel_crtc_state *crtc_state)else crtc_state->vrr.enable = vrr_enable; +if (HAS_VRR_DC_BALANCE (display)) { + crtc_state->vrr.dc_balance.vmin = +intel_de_read (display,PIPEDMC_DCB_VMIN (pipe)) ? +intel_de_read (display,PIPEDMC_DCB_VMIN (pipe)) +1 :0 ;
Instead of reading it twice, can we just use a temp variable:
reg = intel_de_read(display, PIPEDMC_DCB_VMIN(pipe)) ; crtc_state->vrr.dc_balance.vmin = reg ? reg + 1 :0;
reg = intel_de_read(display, PIPEDMC_DCB_VMAX(pipe)) ; crtc_state->vrr.dc_balance.vmax = reg ? reg + 1 :0;
Regards,
Ankit
Quoted 18 lines
drivers/gpu/drm/i915/display/intel_vrr.c +15
-0+ crtc_state->vrr.dc_balance.vmax = +intel_de_read (display,PIPEDMC_DCB_VMAX (pipe)) ? +intel_de_read (display,PIPEDMC_DCB_VMAX (pipe)) +1 :0 ; + crtc_state->vrr.dc_balance.guardband = +intel_de_read (display,PIPEDMC_DCB_GUARDBAND (pipe)); + crtc_state->vrr.dc_balance.max_increase = +intel_de_read (display,PIPEDMC_DCB_MAX_INCREASE (pipe)); + crtc_state->vrr.dc_balance.max_decrease = +intel_de_read (display,PIPEDMC_DCB_MAX_DECREASE (pipe)); + crtc_state->vrr.dc_balance.slope = +intel_de_read (display,PIPEDMC_DCB_SLOPE (pipe)); + crtc_state->vrr.dc_balance.vblank_target = +intel_de_read (display,PIPEDMC_DCB_VBLANK (pipe)); + } +/* * #TODO: For Both VRR and CMRR the flag I915_MODE_FLAG_VRR is set for mode_flags. * Since CMRR is currently disabled, set this flag for VRR for now.
PATCH RESEND 6/22 drm/i915/vrr: Add state dump for DC Balance params
In reply to Mitul GolaniAdd state dump for dc balance params to track DC Balance crtc state config.
--- drivers/gpu/drm/i915/display/intel_crtc_state_dump.c | 8 ++++++++ 1 file changed, 8 insertions(+)
drivers/gpu/drm/i915/display/intel_crtc_state_dump.c +8 -0
@@ -303,6 +303,14 @@ void intel_crtc_state_dump(const struct intel_crtc_state *pipe_config,drm_printf (&p,"vrr: vmin vblank: %d, vmax vblank: %d, vmin vtotal: %d, vmax vtotal: %d\n" ,intel_vrr_vmin_vblank_start (pipe_config),intel_vrr_vmax_vblank_start (pipe_config),intel_vrr_vmin_vtotal (pipe_config),intel_vrr_vmax_vtotal (pipe_config)); +drm_printf (&p,"vrr: dc balance: %s, vmin: %d vmax: %d guardband: %d, slope: %d max increase: %d max decrease: %d Vblank target: %d\n" , +str_yes_no (pipe_config->vrr.dc_balance.enable), + pipe_config->vrr.dc_balance.vmin, pipe_config->vrr.dc_balance.vmax, + pipe_config->vrr.dc_balance.guardband, + pipe_config->vrr.dc_balance.slope, + pipe_config->vrr.dc_balance.max_increase, + pipe_config->vrr.dc_balance.max_decrease, + pipe_config->vrr.dc_balance.vblank_target);drm_printf (&p,"requested mode: " DRM_MODE_FMT "\n" ,DRM_MODE_ARG (&pipe_config->hw.mode));
Signature · 1 line
2.48.1
Re: [RESEND, 06/22] drm/i915/vrr: Add state dump for DC Balance params
Quoted 14 lines · Mitul Golani
Add state dump for dc balance params to track DC Balance crtc state config.
Signed-off-by Mitul Golani <[email protected]>Reviewed-by Ankit Nautiyal <[email protected]>--- drivers/gpu/drm/i915/display/intel_crtc_state_dump.c | 8 ++++++++ 1 file changed, 8 insertions(+)drivers/gpu/drm/i915/display/intel_crtc_state_dump.c +0
-0
drivers/gpu/drm/i915/display/intel_crtc_state_dump.c void intel_crtc_state_dump(const struct intel_crtc_state *pipe_config, · line 306
Quoted 4 lines
drivers/gpu/drm/i915/display/intel_crtc_state_dump.c +1
-0@@ -303,6 +303,14 @@ void intel_crtc_state_dump(const struct intel_crtc_state *pipe_config,drm_printf (&p,"vrr: vmin vblank: %d, vmax vblank: %d, vmin vtotal: %d, vmax vtotal: %d\n" ,intel_vrr_vmin_vblank_start (pipe_config),intel_vrr_vmax_vblank_start (pipe_config),intel_vrr_vmin_vtotal (pipe_config),intel_vrr_vmax_vtotal (pipe_config)); + drm_printf(&p, "vrr: dc balance: %s, vmin: %d vmax: %d guardband: %d, slope: %d max increase: %d max decrease: %d Vblank target: %d\n",
nitpick: s/Vblank target/vblank target
Regards,
Ankit
Quoted 10 lines
drivers/gpu/drm/i915/display/intel_crtc_state_dump.c +7
-0+str_yes_no (pipe_config->vrr.dc_balance.enable), + pipe_config->vrr.dc_balance.vmin, pipe_config->vrr.dc_balance.vmax, + pipe_config->vrr.dc_balance.guardband, + pipe_config->vrr.dc_balance.slope, + pipe_config->vrr.dc_balance.max_increase, + pipe_config->vrr.dc_balance.max_decrease, + pipe_config->vrr.dc_balance.vblank_target);drm_printf (&p,"requested mode: " DRM_MODE_FMT "\n" ,DRM_MODE_ARG (&pipe_config->hw.mode));
PATCH RESEND 7/22 drm/i915/vrr: Add compute config for DC Balance params
In reply to Mitul GolaniCompute DC Balance parameters and tunable params based on experiments.
--v2:
- Document tunable params. (Ankit)
--v3:
- Add line spaces to compute config. (Ankit)
- Remove redundancy checks.
--- drivers/gpu/drm/i915/display/intel_vrr.c | 26 ++++++++++++++++++++++++ 1 file changed, 26 insertions(+)
drivers/gpu/drm/i915/display/intel_vrr.c +26 -0
@@ -20,6 +20,14 @@#define FIXED_POINT_PRECISION 100#define CMRR_PRECISION_TOLERANCE 10 +/* +* Tunable parameters for DC Balance correction. +* These are captured based on experimentations. +*/ +#define DCB_CORRECTION_SENSITIVITY 30 +#define DCB_CORRECTION_AGGRESSIVENESS 1000 +#define DCB_BLANK_TARGET 50 +bool intel_vrr_is_capable (struct intel_connector *connector) {struct intel_display *display =to_intel_display (connector);
@@ -399,6 +407,24 @@ intel_vrr_compute_config(struct intel_crtc_state *crtc_state, (crtc_state->hw.adjusted_mode.crtc_vtotal - crtc_state->hw.adjusted_mode.crtc_vsync_end); } + +if (crtc_state->vrr.dc_balance.enable) { + crtc_state->vrr.dc_balance.vmax = crtc_state->vrr.vmax; + crtc_state->vrr.dc_balance.vmin = crtc_state->vrr.vmin; + crtc_state->vrr.dc_balance.max_increase = + crtc_state->vrr.vmax - crtc_state->vrr.vmin; + crtc_state->vrr.dc_balance.max_decrease = + crtc_state->vrr.vmax - crtc_state->vrr.vmin; + crtc_state->vrr.dc_balance.guardband = +DIV_ROUND_UP (crtc_state->vrr.dc_balance.vmax * +DCB_CORRECTION_SENSITIVITY ,100 ); + crtc_state->vrr.dc_balance.slope = +DIV_ROUND_UP (DCB_CORRECTION_AGGRESSIVENESS *10 , + crtc_state->vrr.dc_balance.guardband); + crtc_state->vrr.dc_balance.vblank_target = +DIV_ROUND_UP ((crtc_state->vrr.vmax - crtc_state->vrr.vmin) * +DCB_BLANK_TARGET ,100 ); + } } static int
Signature · 1 line
2.48.1
Re: [RESEND, 07/22] drm/i915/vrr: Add compute config for DC Balance params
Quoted 42 lines · Mitul Golani
Compute DC Balance parameters and tunable params based on experiments.
--v2:
- Document tunable params. (Ankit)--v3:
- Add line spaces to compute config. (Ankit)
- Remove redundancy checks.Signed-off-by Mitul Golani <[email protected]>Reviewed-by Ankit Nautiyal <[email protected]>--- drivers/gpu/drm/i915/display/intel_vrr.c | 26 ++++++++++++++++++++++++ 1 file changed, 26 insertions(+)drivers/gpu/drm/i915/display/intel_vrr.c +11
-0@@ -20,6 +20,14 @@#define FIXED_POINT_PRECISION 100#define CMRR_PRECISION_TOLERANCE 10 +/* +* Tunable parameters for DC Balance correction. +* These are captured based on experimentations. +*/ +#define DCB_CORRECTION_SENSITIVITY 30 +#define DCB_CORRECTION_AGGRESSIVENESS 1000 +#define DCB_BLANK_TARGET 50 +bool intel_vrr_is_capable (struct intel_connector *connector) {struct intel_display *display =to_intel_display (connector);@@ -399,6 +407,24 @@ intel_vrr_compute_config(struct intel_crtc_state *crtc_state, (crtc_state->hw.adjusted_mode.crtc_vtotal - crtc_state->hw.adjusted_mode.crtc_vsync_end); } + +if (crtc_state->vrr.dc_balance.enable) { + crtc_state->vrr.dc_balance.vmax = crtc_state->vrr.vmax;
drivers/gpu/drm/i915/display/intel_vrr.c intel_vrr_compute_config(struct intel_crtc_state *crtc_state, · line 422
Quoted 10 lines
drivers/gpu/drm/i915/display/intel_vrr.c +10
-0+ crtc_state->vrr.dc_balance.vmin = crtc_state->vrr.vmin; + crtc_state->vrr.dc_balance.max_increase = + crtc_state->vrr.vmax - crtc_state->vrr.vmin; + crtc_state->vrr.dc_balance.max_decrease = + crtc_state->vrr.vmax - crtc_state->vrr.vmin; + crtc_state->vrr.dc_balance.guardband = +DIV_ROUND_UP (crtc_state->vrr.dc_balance.vmax * +DCB_CORRECTION_SENSITIVITY ,100 ); + crtc_state->vrr.dc_balance.slope = + DIV_ROUND_UP(DCB_CORRECTION_AGGRESSIVENESS * 10,
Should we have DCB_CORRECTION_AGGRESSIVENESS directly as 10000 instead?
Regards,
Ankit
Quoted 8 lines
drivers/gpu/drm/i915/display/intel_vrr.c +5
-0+ crtc_state->vrr.dc_balance.guardband); + crtc_state->vrr.dc_balance.vblank_target = +DIV_ROUND_UP ((crtc_state->vrr.vmax - crtc_state->vrr.vmin) * +DCB_BLANK_TARGET ,100 ); + } } static int
PATCH RESEND 8/22 drm/i915/display: Add DC Balance flip counter in crtc
In reply to Mitul GolaniTrack dc balance flip count with params per crtc.
--- drivers/gpu/drm/i915/display/intel_display_types.h | 4 ++++ 1 file changed, 4 insertions(+)
drivers/gpu/drm/i915/display/intel_display_types.h +4 -0
@@ -1502,6 +1502,10 @@ struct intel_crtc {struct intel_link_m_n m_n, m2_n2; } drrs; +struct { +u64 flip_count; + } dc_balance; +int scanline_offset;struct {
Signature · 1 line
2.48.1
Re: [RESEND, 08/22] drm/i915/display: Add DC Balance flip counter in crtc
On 11/3/2025 10:59 AM, Mitul Golani wrote:
Track dc balance flip count with params per crtc. Signed-off-by: Mitul Golani <[email protected]> --- drivers/gpu/drm/i915/display/intel_display_types.h | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/gpu/drm/i915/display/intel_display_types.h b/drivers/gpu/drm/i915/display/intel_display_types.h index 33fb70716110..09eda2c409d8 100644 --- a/drivers/gpu/drm/i915/display/intel_display_types.h +++ b/drivers/gpu/drm/i915/display/intel_display_types.h @@ -1502,6 +1502,10 @@ struct intel_crtc { struct intel_link_m_n m_n, m2_n2; } drrs; + struct { + u64 flip_count; + } dc_balance; +
Why u64? The register PIPEDMC_DCB_FLIP_COUNT is 32 bit.
This will create an issue when we want to roll over to 0 after UINT32_MAX.
Also wondering if we should just use dc_balance_flip_count, instead of a struct.
Regards,
Ankit
int scanline_offset; struct {
PATCH RESEND 9/22 drm/i915/vrr: Increment DC balance flip count on every flip
In reply to Mitul GolaniIncrement DC Balance Flip count before every send push to indicate DMC firmware about new flip occurrence. This is tracked separately from legacy FLIP_COUNT register.
--- drivers/gpu/drm/i915/display/intel_color.c | 1 + drivers/gpu/drm/i915/display/intel_display.c | 1 + drivers/gpu/drm/i915/display/intel_vrr.c | 15 +++++++++++++++ drivers/gpu/drm/i915/display/intel_vrr.h | 3 +++ 4 files changed, 20 insertions(+)
drivers/gpu/drm/i915/display/intel_color.c +1 -0
@@ -2012,6 +2012,7 @@ void intel_color_prepare_commit(struct intel_atomic_state *state, display->funcs.color->load_luts (crtc_state);if (crtc_state->use_dsb &&intel_color_uses_chained_dsb (crtc_state)) { +intel_vrr_dcb_increment_flip_count (crtc_state, crtc);intel_vrr_send_push (crtc_state->dsb_color, crtc_state);intel_dsb_wait_for_delayed_vblank (state, crtc_state->dsb_color);intel_vrr_check_push_sent (crtc_state->dsb_color, crtc_state);
drivers/gpu/drm/i915/display/intel_display.c +1 -0
@@ -7366,6 +7366,7 @@ static void intel_atomic_dsb_finish(struct intel_atomic_state *state,if (new_crtc_state->use_dsb && !intel_color_uses_chained_dsb (new_crtc_state)) {intel_dsb_wait_vblanks (new_crtc_state->dsb_commit,1 ); +intel_vrr_dcb_increment_flip_count (new_crtc_state, crtc);intel_vrr_send_push (new_crtc_state->dsb_commit, new_crtc_state);intel_dsb_wait_for_delayed_vblank (state, new_crtc_state->dsb_commit); intel_vrr_check_push_sent(new_crtc_state->dsb_commit,
drivers/gpu/drm/i915/display/intel_vrr.c +15 -0
@@ -14,6 +14,7 @@#include "intel_psr.h" #include "intel_vrr.h" #include "intel_vrr_regs.h" +#include "intel_dmc_regs.h" #include "skl_prefill.h" #include "skl_watermark.h"
@@ -612,6 +613,20 @@ void intel_vrr_set_transcoder_timings(const struct intel_crtc_state *crtc_state) EMP_AS_SDP_DB_TL(crtc_state->vrr.vsync_start)); } +void +intel_vrr_dcb_increment_flip_count (struct intel_crtc_state *crtc_state, +struct intel_crtc *crtc) +{ +struct intel_display *display =to_intel_display (crtc_state); +enum pipe pipe = crtc->pipe; + +if (!crtc_state->vrr.dc_balance.enable) +return ; + +intel_de_write (display,PIPEDMC_DCB_FLIP_COUNT (pipe), + ++crtc->dc_balance.flip_count); +} +void intel_vrr_send_push (struct intel_dsb *dsb,const struct intel_crtc_state *crtc_state) {
drivers/gpu/drm/i915/display/intel_vrr.h +3 -0
@@ -14,6 +14,7 @@ struct intel_connector;struct intel_crtc_state ;struct intel_dsb ;struct intel_display ; +struct intel_crtc ;bool intel_vrr_is_capable (struct intel_connector *connector);bool intel_vrr_is_in_range (struct intel_connector *connector,int vrefresh);
@@ -39,6 +40,8 @@ bool intel_vrr_is_fixed_rr(const struct intel_crtc_state *crtc_state);void intel_vrr_transcoder_enable (const struct intel_crtc_state *crtc_state);void intel_vrr_transcoder_disable (const struct intel_crtc_state *crtc_state);void intel_vrr_set_fixed_rr_timings (const struct intel_crtc_state *crtc_state); +void intel_vrr_dcb_increment_flip_count (struct intel_crtc_state *crtc_state, +struct intel_crtc *crtc);bool intel_vrr_always_use_vrr_tg (struct intel_display *display);int intel_vrr_safe_window_start (const struct intel_crtc_state *crtc_state);int intel_vrr_vmin_safe_window_end (const struct intel_crtc_state *crtc_state);
Signature · 1 line
2.48.1
Jani Nikula
maintainerRe: [RESEND, 09/22] drm/i915/vrr: Increment DC balance flip count on every flip
Quoted 41 lines · Mitul Golani
Increment DC Balance Flip count before every send push to indicate DMC firmware about new flip occurrence. This is tracked separately from legacy
FLIP_COUNTregister.Signed-off-by Mitul Golani <[email protected]>--- drivers/gpu/drm/i915/display/intel_color.c | 1 + drivers/gpu/drm/i915/display/intel_display.c | 1 + drivers/gpu/drm/i915/display/intel_vrr.c | 15 +++++++++++++++ drivers/gpu/drm/i915/display/intel_vrr.h | 3 +++ 4 files changed, 20 insertions(+)drivers/gpu/drm/i915/display/intel_color.c +1
-0@@ -2012,6 +2012,7 @@ void intel_color_prepare_commit(struct intel_atomic_state *state, display->funcs.color->load_luts (crtc_state);if (crtc_state->use_dsb &&intel_color_uses_chained_dsb (crtc_state)) { +intel_vrr_dcb_increment_flip_count (crtc_state, crtc);intel_vrr_send_push (crtc_state->dsb_color, crtc_state);intel_dsb_wait_for_delayed_vblank (state, crtc_state->dsb_color);intel_vrr_check_push_sent (crtc_state->dsb_color, crtc_state);drivers/gpu/drm/i915/display/intel_display.c +1
-0@@ -7366,6 +7366,7 @@ static void intel_atomic_dsb_finish(struct intel_atomic_state *state,if (new_crtc_state->use_dsb && !intel_color_uses_chained_dsb (new_crtc_state)) {intel_dsb_wait_vblanks (new_crtc_state->dsb_commit,1 ); +intel_vrr_dcb_increment_flip_count (new_crtc_state, crtc);intel_vrr_send_push (new_crtc_state->dsb_commit, new_crtc_state);intel_dsb_wait_for_delayed_vblank (state, new_crtc_state->dsb_commit); intel_vrr_check_push_sent(new_crtc_state->dsb_commit,drivers/gpu/drm/i915/display/intel_vrr.c +0
-0
drivers/gpu/drm/i915/display/intel_vrr.c line 17
Quoted 4 lines
drivers/gpu/drm/i915/display/intel_vrr.c +1
-0@@ -14,6 +14,7 @@#include "intel_psr.h" #include "intel_vrr.h" #include "intel_vrr_regs.h" +#include "intel_dmc_regs.h"
Please keep includes sorted.
Quoted 29 lines
drivers/gpu/drm/i915/display/intel_vrr.c +14
-0#include "skl_prefill.h" #include "skl_watermark.h" @@ -612,6 +613,20 @@ void intel_vrr_set_transcoder_timings(const struct intel_crtc_state *crtc_state) EMP_AS_SDP_DB_TL(crtc_state->vrr.vsync_start)); } +void +intel_vrr_dcb_increment_flip_count (struct intel_crtc_state *crtc_state, +struct intel_crtc *crtc) +{ +struct intel_display *display =to_intel_display (crtc_state); +enum pipe pipe = crtc->pipe; + +if (!crtc_state->vrr.dc_balance.enable) +return ; + +intel_de_write (display,PIPEDMC_DCB_FLIP_COUNT (pipe), + ++crtc->dc_balance.flip_count); +} +void intel_vrr_send_push (struct intel_dsb *dsb,const struct intel_crtc_state *crtc_state) {drivers/gpu/drm/i915/display/intel_vrr.h +0
-0
drivers/gpu/drm/i915/display/intel_vrr.h struct intel_connector; · line 17
Quoted 4 lines
drivers/gpu/drm/i915/display/intel_vrr.h +1
-0@@ -14,6 +14,7 @@ struct intel_connector;struct intel_crtc_state ;struct intel_dsb ;struct intel_display ; +struct intel_crtc ;
Please keep forward declarations sorted.
Quoted 12 lines
drivers/gpu/drm/i915/display/intel_vrr.h +2
-0bool intel_vrr_is_capable (struct intel_connector *connector);bool intel_vrr_is_in_range (struct intel_connector *connector,int vrefresh);@@ -39,6 +40,8 @@ bool intel_vrr_is_fixed_rr(const struct intel_crtc_state *crtc_state);void intel_vrr_transcoder_enable (const struct intel_crtc_state *crtc_state);void intel_vrr_transcoder_disable (const struct intel_crtc_state *crtc_state);void intel_vrr_set_fixed_rr_timings (const struct intel_crtc_state *crtc_state); +void intel_vrr_dcb_increment_flip_count (struct intel_crtc_state *crtc_state, +struct intel_crtc *crtc);bool intel_vrr_always_use_vrr_tg (struct intel_display *display);int intel_vrr_safe_window_start (const struct intel_crtc_state *crtc_state);int intel_vrr_vmin_safe_window_end (const struct intel_crtc_state *crtc_state);
Signature · 1 line
Jani Nikula, Intel
Re: [RESEND, 09/22] drm/i915/vrr: Increment DC balance flip count on every flip
In reply to Mitul GolaniQuoted 29 lines · Mitul Golani
Increment DC Balance Flip count before every send push to indicate DMC firmware about new flip occurrence. This is tracked separately from legacy
FLIP_COUNTregister.Signed-off-by Mitul Golani <[email protected]>--- drivers/gpu/drm/i915/display/intel_color.c | 1 + drivers/gpu/drm/i915/display/intel_display.c | 1 + drivers/gpu/drm/i915/display/intel_vrr.c | 15 +++++++++++++++ drivers/gpu/drm/i915/display/intel_vrr.h | 3 +++ 4 files changed, 20 insertions(+)drivers/gpu/drm/i915/display/intel_color.c +1
-0@@ -2012,6 +2012,7 @@ void intel_color_prepare_commit(struct intel_atomic_state *state, display->funcs.color->load_luts (crtc_state);if (crtc_state->use_dsb &&intel_color_uses_chained_dsb (crtc_state)) { +intel_vrr_dcb_increment_flip_count (crtc_state, crtc);intel_vrr_send_push (crtc_state->dsb_color, crtc_state);intel_dsb_wait_for_delayed_vblank (state, crtc_state->dsb_color);intel_vrr_check_push_sent (crtc_state->dsb_color, crtc_state);drivers/gpu/drm/i915/display/intel_display.c +0
-0
drivers/gpu/drm/i915/display/intel_display.c static void intel_atomic_dsb_finish(struct intel_atomic_state *state, · line 7369
Quoted 4 lines
drivers/gpu/drm/i915/display/intel_display.c +1
-0@@ -7366,6 +7366,7 @@ static void intel_atomic_dsb_finish(struct intel_atomic_state *state,if (new_crtc_state->use_dsb && !intel_color_uses_chained_dsb (new_crtc_state)) {intel_dsb_wait_vblanks (new_crtc_state->dsb_commit,1 ); +intel_vrr_dcb_increment_flip_count (new_crtc_state, crtc);
Shouldn't these have DSB context? We are asking DSB to write these registers.
We need to increment flip_count after intel_vrr_send_push() not before as per the spec.
Also we need to do this for MMIO path along with the DSB path.
So IMO, add this flip count increment at last in intel_update_crtc() instead, then we do not need to use DSB.
Regards,
Ankit
Quoted 60 lines
drivers/gpu/drm/i915/display/intel_display.c +0
-0intel_vrr_send_push (new_crtc_state->dsb_commit, new_crtc_state);intel_dsb_wait_for_delayed_vblank (state, new_crtc_state->dsb_commit); intel_vrr_check_push_sent(new_crtc_state->dsb_commit,drivers/gpu/drm/i915/display/intel_vrr.c +15
-0@@ -14,6 +14,7 @@#include "intel_psr.h" #include "intel_vrr.h" #include "intel_vrr_regs.h" +#include "intel_dmc_regs.h" #include "skl_prefill.h" #include "skl_watermark.h" @@ -612,6 +613,20 @@ void intel_vrr_set_transcoder_timings(const struct intel_crtc_state *crtc_state) EMP_AS_SDP_DB_TL(crtc_state->vrr.vsync_start)); } +void +intel_vrr_dcb_increment_flip_count (struct intel_crtc_state *crtc_state, +struct intel_crtc *crtc) +{ +struct intel_display *display =to_intel_display (crtc_state); +enum pipe pipe = crtc->pipe; + +if (!crtc_state->vrr.dc_balance.enable) +return ; + +intel_de_write (display,PIPEDMC_DCB_FLIP_COUNT (pipe), + ++crtc->dc_balance.flip_count); +} +void intel_vrr_send_push(struct
intel_dsb*dsb,
const structintel_crtc_state*crtc_state)
{drivers/gpu/drm/i915/display/intel_vrr.h +3
-0@@ -14,6 +14,7 @@ struct intel_connector;struct intel_crtc_state ;struct intel_dsb ;struct intel_display ; +struct intel_crtc ;bool intel_vrr_is_capable (struct intel_connector *connector);bool intel_vrr_is_in_range (struct intel_connector *connector,int vrefresh);@@ -39,6 +40,8 @@ bool intel_vrr_is_fixed_rr(const struct intel_crtc_state *crtc_state);void intel_vrr_transcoder_enable (const struct intel_crtc_state *crtc_state);void intel_vrr_transcoder_disable (const struct intel_crtc_state *crtc_state);void intel_vrr_set_fixed_rr_timings (const struct intel_crtc_state *crtc_state); +void intel_vrr_dcb_increment_flip_count (struct intel_crtc_state *crtc_state, +struct intel_crtc *crtc);bool intel_vrr_always_use_vrr_tg (struct intel_display *display);int intel_vrr_safe_window_start (const struct intel_crtc_state *crtc_state);int intel_vrr_vmin_safe_window_end (const struct intel_crtc_state *crtc_state);
Re: [RESEND, 09/22] drm/i915/vrr: Increment DC balance flip count on every flip
In reply to Mitul GolaniQuoted 41 lines · Mitul Golani
Increment DC Balance Flip count before every send push to indicate DMC firmware about new flip occurrence. This is tracked separately from legacy
FLIP_COUNTregister.Signed-off-by Mitul Golani <[email protected]>--- drivers/gpu/drm/i915/display/intel_color.c | 1 + drivers/gpu/drm/i915/display/intel_display.c | 1 + drivers/gpu/drm/i915/display/intel_vrr.c | 15 +++++++++++++++ drivers/gpu/drm/i915/display/intel_vrr.h | 3 +++ 4 files changed, 20 insertions(+)drivers/gpu/drm/i915/display/intel_color.c +1
-0@@ -2012,6 +2012,7 @@ void intel_color_prepare_commit(struct intel_atomic_state *state, display->funcs.color->load_luts (crtc_state);if (crtc_state->use_dsb &&intel_color_uses_chained_dsb (crtc_state)) { +intel_vrr_dcb_increment_flip_count (crtc_state, crtc);intel_vrr_send_push (crtc_state->dsb_color, crtc_state);intel_dsb_wait_for_delayed_vblank (state, crtc_state->dsb_color);intel_vrr_check_push_sent (crtc_state->dsb_color, crtc_state);drivers/gpu/drm/i915/display/intel_display.c +1
-0@@ -7366,6 +7366,7 @@ static void intel_atomic_dsb_finish(struct intel_atomic_state *state,if (new_crtc_state->use_dsb && !intel_color_uses_chained_dsb (new_crtc_state)) {intel_dsb_wait_vblanks (new_crtc_state->dsb_commit,1 ); +intel_vrr_dcb_increment_flip_count (new_crtc_state, crtc);intel_vrr_send_push (new_crtc_state->dsb_commit, new_crtc_state);intel_dsb_wait_for_delayed_vblank (state, new_crtc_state->dsb_commit); intel_vrr_check_push_sent(new_crtc_state->dsb_commit,drivers/gpu/drm/i915/display/intel_vrr.c +0
-0
drivers/gpu/drm/i915/display/intel_vrr.c line 17
Quoted 4 lines
drivers/gpu/drm/i915/display/intel_vrr.c +1
-0@@ -14,6 +14,7 @@#include "intel_psr.h" #include "intel_vrr.h" #include "intel_vrr_regs.h" +#include "intel_dmc_regs.h"
This is already added in patch#5, so drop this.
Regards,
Ankit
Quoted 45 lines
drivers/gpu/drm/i915/display/intel_vrr.c +14
-0#include "skl_prefill.h" #include "skl_watermark.h" @@ -612,6 +613,20 @@ void intel_vrr_set_transcoder_timings(const struct intel_crtc_state *crtc_state) EMP_AS_SDP_DB_TL(crtc_state->vrr.vsync_start)); } +void +intel_vrr_dcb_increment_flip_count (struct intel_crtc_state *crtc_state, +struct intel_crtc *crtc) +{ +struct intel_display *display =to_intel_display (crtc_state); +enum pipe pipe = crtc->pipe; + +if (!crtc_state->vrr.dc_balance.enable) +return ; + +intel_de_write (display,PIPEDMC_DCB_FLIP_COUNT (pipe), + ++crtc->dc_balance.flip_count); +} +void intel_vrr_send_push (struct intel_dsb *dsb,const struct intel_crtc_state *crtc_state) {drivers/gpu/drm/i915/display/intel_vrr.h +3
-0@@ -14,6 +14,7 @@ struct intel_connector;struct intel_crtc_state ;struct intel_dsb ;struct intel_display ; +struct intel_crtc ;bool intel_vrr_is_capable (struct intel_connector *connector);bool intel_vrr_is_in_range (struct intel_connector *connector,int vrefresh);@@ -39,6 +40,8 @@ bool intel_vrr_is_fixed_rr(const struct intel_crtc_state *crtc_state);void intel_vrr_transcoder_enable (const struct intel_crtc_state *crtc_state);void intel_vrr_transcoder_disable (const struct intel_crtc_state *crtc_state);void intel_vrr_set_fixed_rr_timings (const struct intel_crtc_state *crtc_state); +void intel_vrr_dcb_increment_flip_count (struct intel_crtc_state *crtc_state, +struct intel_crtc *crtc);bool intel_vrr_always_use_vrr_tg (struct intel_display *display);int intel_vrr_safe_window_start (const struct intel_crtc_state *crtc_state);int intel_vrr_vmin_safe_window_end (const struct intel_crtc_state *crtc_state);
PATCH RESEND 10/22 drm/i915/vrr: Add function to reset DC Balance flip count
In reply to Mitul GolaniReset DC balance flip count value while disabling VRR adaptive mode, this is to start with fresh counts when VRR adaptive refresh mode is triggered again.
--- drivers/gpu/drm/i915/display/intel_display.c | 1 + drivers/gpu/drm/i915/display/intel_vrr.c | 12 ++++++++++++ drivers/gpu/drm/i915/display/intel_vrr.h | 2 ++ 3 files changed, 15 insertions(+)
drivers/gpu/drm/i915/display/intel_display.c +1 -0
@@ -1148,6 +1148,7 @@ static void intel_pre_plane_update(struct intel_atomic_state *state,if (intel_crtc_vrr_disabling (state, crtc)) {intel_vrr_disable (old_crtc_state); +intel_vrr_dcb_reset_flip_count (old_crtc_state, crtc);intel_crtc_update_active_timings (old_crtc_state, false); }
drivers/gpu/drm/i915/display/intel_vrr.c +12 -0
@@ -627,6 +627,18 @@ intel_vrr_dcb_increment_flip_count(struct intel_crtc_state *crtc_state, ++crtc->dc_balance.flip_count); } +void intel_vrr_dcb_reset_flip_count (const struct intel_crtc_state *crtc_state, +struct intel_crtc *crtc) +{ +struct intel_display *display =to_intel_display (crtc_state); +enum pipe pipe = crtc->pipe; + +if (!crtc_state->vrr.dc_balance.enable) +return ; + +intel_de_write (display,PIPEDMC_DCB_FLIP_COUNT (pipe),0 ); +} +void intel_vrr_send_push (struct intel_dsb *dsb,const struct intel_crtc_state *crtc_state) {
drivers/gpu/drm/i915/display/intel_vrr.h +2 -0
@@ -42,6 +42,8 @@ void intel_vrr_transcoder_disable(const struct intel_crtc_state *crtc_state);void intel_vrr_set_fixed_rr_timings (const struct intel_crtc_state *crtc_state);void intel_vrr_dcb_increment_flip_count (struct intel_crtc_state *crtc_state,struct intel_crtc *crtc); +void intel_vrr_dcb_reset_flip_count (const struct intel_crtc_state *crtc_state, +struct intel_crtc *crtc);bool intel_vrr_always_use_vrr_tg (struct intel_display *display);int intel_vrr_safe_window_start (const struct intel_crtc_state *crtc_state);int intel_vrr_vmin_safe_window_end (const struct intel_crtc_state *crtc_state);
Signature · 1 line
2.48.1
Re: [RESEND, 10/22] drm/i915/vrr: Add function to reset DC Balance flip count
Quoted 16 lines · Mitul Golani
Reset DC balance flip count value while disabling VRR adaptive mode, this is to start with fresh counts when VRR adaptive refresh mode is triggered again.
Signed-off-by Mitul Golani <[email protected]>--- drivers/gpu/drm/i915/display/intel_display.c | 1 + drivers/gpu/drm/i915/display/intel_vrr.c | 12 ++++++++++++ drivers/gpu/drm/i915/display/intel_vrr.h | 2 ++ 3 files changed, 15 insertions(+)drivers/gpu/drm/i915/display/intel_display.c +0
-0
drivers/gpu/drm/i915/display/intel_display.c static void intel_pre_plane_update(struct intel_atomic_state *state, · line 1151
Quoted 4 lines
drivers/gpu/drm/i915/display/intel_display.c +1
-0@@ -1148,6 +1148,7 @@ static void intel_pre_plane_update(struct intel_atomic_state *state,if (intel_crtc_vrr_disabling (state, crtc)) {intel_vrr_disable (old_crtc_state); +intel_vrr_dcb_reset_flip_count (old_crtc_state, crtc);
IMHO we should merge patches#8,9,10 to have a single patch that introduces a new member flip_count to struct intel_crtc, and to increment and reset the counter.
Regards,
Ankit
Quoted 39 lines
drivers/gpu/drm/i915/display/intel_display.c +0
-0intel_crtc_update_active_timings (old_crtc_state, false); }drivers/gpu/drm/i915/display/intel_vrr.c +12
-0@@ -627,6 +627,18 @@ intel_vrr_dcb_increment_flip_count(struct intel_crtc_state *crtc_state, ++crtc->dc_balance.flip_count); } +void intel_vrr_dcb_reset_flip_count (const struct intel_crtc_state *crtc_state, +struct intel_crtc *crtc) +{ +struct intel_display *display =to_intel_display (crtc_state); +enum pipe pipe = crtc->pipe; + +if (!crtc_state->vrr.dc_balance.enable) +return ; + +intel_de_write (display,PIPEDMC_DCB_FLIP_COUNT (pipe),0 ); +} +void intel_vrr_send_push (struct intel_dsb *dsb,const struct intel_crtc_state *crtc_state) {drivers/gpu/drm/i915/display/intel_vrr.h +2
-0@@ -42,6 +42,8 @@ void intel_vrr_transcoder_disable(const struct intel_crtc_state *crtc_state);void intel_vrr_set_fixed_rr_timings (const struct intel_crtc_state *crtc_state);void intel_vrr_dcb_increment_flip_count (struct intel_crtc_state *crtc_state,struct intel_crtc *crtc); +void intel_vrr_dcb_reset_flip_count (const struct intel_crtc_state *crtc_state, +struct intel_crtc *crtc);bool intel_vrr_always_use_vrr_tg (struct intel_display *display);int intel_vrr_safe_window_start (const struct intel_crtc_state *crtc_state);int intel_vrr_vmin_safe_window_end (const struct intel_crtc_state *crtc_state);
PATCH RESEND 11/22 drm/i915/vrr: Add function reset DC balance accumulated params
In reply to Mitul GolaniAdd function which resets all accumulated DC Balance parameters whenever adaptive mode of VRR goes off. This helps to give a fresh start when VRR is re-enabled.
--- drivers/gpu/drm/i915/display/intel_display.c | 1 + drivers/gpu/drm/i915/display/intel_vrr.c | 13 +++++++++++++ drivers/gpu/drm/i915/display/intel_vrr.h | 2 ++ 3 files changed, 16 insertions(+)
drivers/gpu/drm/i915/display/intel_display.c +1 -0
@@ -1149,6 +1149,7 @@ static void intel_pre_plane_update(struct intel_atomic_state *state,if (intel_crtc_vrr_disabling (state, crtc)) {intel_vrr_disable (old_crtc_state);intel_vrr_dcb_reset_flip_count (old_crtc_state, crtc); +intel_vrr_dcb_balance_reset (old_crtc_state, crtc);intel_crtc_update_active_timings (old_crtc_state, false); }
drivers/gpu/drm/i915/display/intel_vrr.c +13 -0
@@ -639,6 +639,19 @@ void intel_vrr_dcb_reset_flip_count(const struct intel_crtc_state *crtc_state,intel_de_write (display,PIPEDMC_DCB_FLIP_COUNT (pipe),0 ); } +void +intel_vrr_dcb_balance_reset (const struct intel_crtc_state *crtc_state, +struct intel_crtc *crtc) +{ +struct intel_display *display =to_intel_display (crtc_state); +enum pipe pipe = crtc->pipe; + +if (!crtc_state->vrr.dc_balance.enable) +return ; + +intel_de_write (display,PIPEDMC_DCB_BALANCE_RESET (pipe),0 ); +} +void intel_vrr_send_push (struct intel_dsb *dsb,const struct intel_crtc_state *crtc_state) {
drivers/gpu/drm/i915/display/intel_vrr.h +2 -0
@@ -44,6 +44,8 @@ void intel_vrr_dcb_increment_flip_count(struct intel_crtc_state *crtc_state, struct intel_crtc *crtc);void intel_vrr_dcb_reset_flip_count (const struct intel_crtc_state *crtc_state,struct intel_crtc *crtc); +void intel_vrr_dcb_balance_reset (const struct intel_crtc_state *crtc_state, +struct intel_crtc *crtc);bool intel_vrr_always_use_vrr_tg (struct intel_display *display);int intel_vrr_safe_window_start (const struct intel_crtc_state *crtc_state);int intel_vrr_vmin_safe_window_end (const struct intel_crtc_state *crtc_state);
Signature · 1 line
2.48.1
Re: [RESEND, 11/22] drm/i915/vrr: Add function reset DC balance accumulated params
Quoted 16 lines · Mitul Golani
Add function which resets all accumulated DC Balance parameters whenever adaptive mode of VRR goes off. This helps to give a fresh start when VRR is re-enabled.
Signed-off-by Mitul Golani <[email protected]>--- drivers/gpu/drm/i915/display/intel_display.c | 1 + drivers/gpu/drm/i915/display/intel_vrr.c | 13 +++++++++++++ drivers/gpu/drm/i915/display/intel_vrr.h | 2 ++ 3 files changed, 16 insertions(+)drivers/gpu/drm/i915/display/intel_display.c +0
-0
drivers/gpu/drm/i915/display/intel_display.c static void intel_pre_plane_update(struct intel_atomic_state *state, · line 1152
Quoted 4 lines
drivers/gpu/drm/i915/display/intel_display.c +1
-0@@ -1149,6 +1149,7 @@ static void intel_pre_plane_update(struct intel_atomic_state *state,if (intel_crtc_vrr_disabling (state, crtc)) {intel_vrr_disable (old_crtc_state);intel_vrr_dcb_reset_flip_count (old_crtc_state, crtc); +intel_vrr_dcb_balance_reset (old_crtc_state, crtc);
Lets have both the reset functions in the intel_vrr_dcb_balance_reset(). Move this patch before the dcb_flip_count introduction patch.
Call the function to reset the flip_count from intel_vrr_dcb_balance_reset()
Regards,
Ankit
Quoted 40 lines
drivers/gpu/drm/i915/display/intel_display.c +0
-0intel_crtc_update_active_timings (old_crtc_state, false); }drivers/gpu/drm/i915/display/intel_vrr.c +13
-0@@ -639,6 +639,19 @@ void intel_vrr_dcb_reset_flip_count(const struct intel_crtc_state *crtc_state,intel_de_write (display,PIPEDMC_DCB_FLIP_COUNT (pipe),0 ); } +void +intel_vrr_dcb_balance_reset (const struct intel_crtc_state *crtc_state, +struct intel_crtc *crtc) +{ +struct intel_display *display =to_intel_display (crtc_state); +enum pipe pipe = crtc->pipe; + +if (!crtc_state->vrr.dc_balance.enable) +return ; + +intel_de_write (display,PIPEDMC_DCB_BALANCE_RESET (pipe),0 ); +} +void intel_vrr_send_push (struct intel_dsb *dsb,const struct intel_crtc_state *crtc_state) {drivers/gpu/drm/i915/display/intel_vrr.h +2
-0@@ -44,6 +44,8 @@ void intel_vrr_dcb_increment_flip_count(struct intel_crtc_state *crtc_state, struct intel_crtc *crtc);void intel_vrr_dcb_reset_flip_count (const struct intel_crtc_state *crtc_state,struct intel_crtc *crtc); +void intel_vrr_dcb_balance_reset (const struct intel_crtc_state *crtc_state, +struct intel_crtc *crtc);bool intel_vrr_always_use_vrr_tg (struct intel_display *display);int intel_vrr_safe_window_start (const struct intel_crtc_state *crtc_state);int intel_vrr_vmin_safe_window_end (const struct intel_crtc_state *crtc_state);
PATCH RESEND 12/22 drm/i915/vrr: Write DC balance params to hw registers
In reply to Mitul GolaniWrite DC Balance parameters to hw registers.
--v2:
- Update commit header.
- Separate crtc_state params from this patch. (Ankit)
--v3:
- Write registers at compute config.
- Update condition for write.
--v4:
- Address issue with state checker.
--v5:
- Initialise some more dc balance register while enabling VRR.
--v6:
- FLIPLINE_CFG need to be configure at last, as it is double buffer arming point.
--v7:
- Initialise and reset live value of vmax and vmin as well.
--- drivers/gpu/drm/i915/display/intel_vrr.c | 53 ++++++++++++++++++++++++ 1 file changed, 53 insertions(+)
drivers/gpu/drm/i915/display/intel_vrr.c +53 -0
@@ -764,10 +764,43 @@ static void intel_vrr_tg_enable(const struct intel_crtc_state *crtc_state, {struct intel_display *display =to_intel_display (crtc_state);enum transcoder cpu_transcoder = crtc_state->cpu_transcoder; +struct intel_crtc *crtc =to_intel_crtc (crtc_state->uapi.crtc); +enum pipe pipe = crtc->pipe;u32 vrr_ctl;intel_de_write (display,TRANS_PUSH (display, cpu_transcoder),TRANS_PUSH_EN ); +if (crtc_state->vrr.dc_balance.enable) { +intel_de_write (display,TRANS_VRR_DCB_ADJ_VMAX_CFG (cpu_transcoder), +VRR_DCB_ADJ_VMAX (crtc_state->vrr.vmax -1 )); +intel_de_write (display,TRANS_VRR_DCB_ADJ_VMAX_CFG_LIVE (cpu_transcoder), +VRR_DCB_ADJ_VMAX (crtc_state->vrr.vmax -1 )); +intel_de_write (display,TRANS_VRR_DCB_VMAX (cpu_transcoder), +VRR_DCB_VMAX (crtc_state->vrr.vmax -1 )); +intel_de_write (display,TRANS_VRR_DCB_VMAX_LIVE (cpu_transcoder), +VRR_DCB_VMAX (crtc_state->vrr.vmax -1 )); +intel_de_write (display,TRANS_VRR_DCB_FLIPLINE (cpu_transcoder), +VRR_DCB_FLIPLINE (crtc_state->vrr.flipline -1 )); +intel_de_write (display,TRANS_VRR_DCB_FLIPLINE_LIVE (cpu_transcoder), +VRR_DCB_FLIPLINE (crtc_state->vrr.flipline -1 )); +intel_de_write (display,TRANS_VRR_DCB_ADJ_FLIPLINE_CFG_LIVE (cpu_transcoder), +VRR_DCB_ADJ_FLIPLINE (crtc_state->vrr.flipline -1 )); +intel_de_write (display,PIPEDMC_DCB_VMIN (pipe), + crtc_state->vrr.dc_balance.vmin -1 ); +intel_de_write (display,PIPEDMC_DCB_VMAX (pipe), + crtc_state->vrr.dc_balance.vmax -1 ); +intel_de_write (display,PIPEDMC_DCB_MAX_INCREASE (pipe), + crtc_state->vrr.dc_balance.max_increase); +intel_de_write (display,PIPEDMC_DCB_MAX_DECREASE (pipe), + crtc_state->vrr.dc_balance.max_decrease); +intel_de_write (display,PIPEDMC_DCB_GUARDBAND (pipe), + crtc_state->vrr.dc_balance.guardband); +intel_de_write (display,PIPEDMC_DCB_SLOPE (pipe), + crtc_state->vrr.dc_balance.slope); +intel_de_write (display,PIPEDMC_DCB_VBLANK (pipe), + crtc_state->vrr.dc_balance.vblank_target); + } + vrr_ctl =VRR_CTL_VRR_ENABLE |trans_vrr_ctl (crtc_state);/*
@@ -785,6 +818,8 @@ static void intel_vrr_tg_disable(const struct intel_crtc_state *old_crtc_state) {struct intel_display *display =to_intel_display (old_crtc_state);enum transcoder cpu_transcoder = old_crtc_state->cpu_transcoder; +struct intel_crtc *crtc =to_intel_crtc (old_crtc_state->uapi.crtc); +enum pipe pipe = crtc->pipe;intel_de_write (display,TRANS_VRR_CTL (display, cpu_transcoder),trans_vrr_ctl (old_crtc_state));
@@ -795,6 +830,24 @@ static void intel_vrr_tg_disable(const struct intel_crtc_state *old_crtc_state)drm_err (display->drm,"Timed out waiting for VRR live status to clear\n" );intel_de_write (display,TRANS_PUSH (display, cpu_transcoder),0 ); + +if (old_crtc_state->vrr.dc_balance.enable) { +intel_de_write (display,PIPEDMC_DCB_VMIN (pipe),0 ); +intel_de_write (display,PIPEDMC_DCB_VMAX (pipe),0 ); +intel_de_write (display,PIPEDMC_DCB_MAX_INCREASE (pipe),0 ); +intel_de_write (display,PIPEDMC_DCB_MAX_DECREASE (pipe),0 ); +intel_de_write (display,PIPEDMC_DCB_GUARDBAND (pipe),0 ); +intel_de_write (display,PIPEDMC_DCB_SLOPE (pipe),0 ); +intel_de_write (display,PIPEDMC_DCB_VBLANK (pipe),0 ); +intel_de_write (display,TRANS_VRR_DCB_ADJ_VMAX_CFG_LIVE (cpu_transcoder),0 ); +intel_de_write (display,TRANS_VRR_DCB_ADJ_FLIPLINE_CFG_LIVE (cpu_transcoder),0 ); +intel_de_write (display,TRANS_VRR_DCB_VMAX_LIVE (cpu_transcoder),0 ); +intel_de_write (display,TRANS_VRR_DCB_FLIPLINE_LIVE (cpu_transcoder),0 ); +intel_de_write (display,TRANS_VRR_DCB_ADJ_VMAX_CFG (cpu_transcoder),0 ); +intel_de_write (display,TRANS_VRR_DCB_ADJ_FLIPLINE_CFG (cpu_transcoder),0 ); +intel_de_write (display,TRANS_VRR_DCB_VMAX (cpu_transcoder),0 ); +intel_de_write (display,TRANS_VRR_DCB_FLIPLINE (cpu_transcoder),0 ); + } }void intel_vrr_enable (const struct intel_crtc_state *crtc_state)
Signature · 1 line
2.48.1
Re: [RESEND, 12/22] drm/i915/vrr: Write DC balance params to hw registers
Quoted 62 lines · Mitul Golani
Write DC Balance parameters to hw registers.
--v2:
- Update commit header.
- Separatecrtc_stateparams from this patch. (Ankit)--v3:
- Write registers at compute config.
- Update condition for write.--v4:
- Address issue with state checker.--v5:
- Initialise some more dc balance register while enabling VRR.--v6:
-FLIPLINE_CFGneed to be configure at last, as it is double buffer arming point.--v7:
- Initialise and reset live value of vmax and vmin as well.Signed-off-by Mitul Golani <[email protected]>Reviewed-by Ankit Nautiyal <[email protected]>--- drivers/gpu/drm/i915/display/intel_vrr.c | 53 ++++++++++++++++++++++++ 1 file changed, 53 insertions(+)drivers/gpu/drm/i915/display/intel_vrr.c +21
-0@@ -764,10 +764,43 @@ static void intel_vrr_tg_enable(const struct intel_crtc_state *crtc_state, {struct intel_display *display =to_intel_display (crtc_state);enum transcoder cpu_transcoder = crtc_state->cpu_transcoder; +struct intel_crtc *crtc =to_intel_crtc (crtc_state->uapi.crtc); +enum pipe pipe = crtc->pipe;u32 vrr_ctl;intel_de_write (display,TRANS_PUSH (display, cpu_transcoder),TRANS_PUSH_EN ); +if (crtc_state->vrr.dc_balance.enable) { +intel_de_write (display,TRANS_VRR_DCB_ADJ_VMAX_CFG (cpu_transcoder), +VRR_DCB_ADJ_VMAX (crtc_state->vrr.vmax -1 )); +intel_de_write (display,TRANS_VRR_DCB_ADJ_VMAX_CFG_LIVE (cpu_transcoder), +VRR_DCB_ADJ_VMAX (crtc_state->vrr.vmax -1 )); +intel_de_write (display,TRANS_VRR_DCB_VMAX (cpu_transcoder), +VRR_DCB_VMAX (crtc_state->vrr.vmax -1 )); +intel_de_write (display,TRANS_VRR_DCB_VMAX_LIVE (cpu_transcoder), +VRR_DCB_VMAX (crtc_state->vrr.vmax -1 )); +intel_de_write (display,TRANS_VRR_DCB_FLIPLINE (cpu_transcoder), +VRR_DCB_FLIPLINE (crtc_state->vrr.flipline -1 )); +intel_de_write (display,TRANS_VRR_DCB_FLIPLINE_LIVE (cpu_transcoder), +VRR_DCB_FLIPLINE (crtc_state->vrr.flipline -1 )); +intel_de_write (display,TRANS_VRR_DCB_ADJ_FLIPLINE_CFG_LIVE (cpu_transcoder), +VRR_DCB_ADJ_FLIPLINE (crtc_state->vrr.flipline -1 )); +intel_de_write (display,PIPEDMC_DCB_VMIN (pipe), + crtc_state->vrr.dc_balance.vmin -1 ); +intel_de_write (display,PIPEDMC_DCB_VMAX (pipe), + crtc_state->vrr.dc_balance.vmax -1 );
drivers/gpu/drm/i915/display/intel_vrr.c static void intel_vrr_tg_enable(const struct intel_crtc_state *crtc_state, · line 801
Quoted 10 lines
drivers/gpu/drm/i915/display/intel_vrr.c +10
-0+intel_de_write (display,PIPEDMC_DCB_MAX_INCREASE (pipe), + crtc_state->vrr.dc_balance.max_increase); +intel_de_write (display,PIPEDMC_DCB_MAX_DECREASE (pipe), + crtc_state->vrr.dc_balance.max_decrease); +intel_de_write (display,PIPEDMC_DCB_GUARDBAND (pipe), + crtc_state->vrr.dc_balance.guardband); +intel_de_write (display,PIPEDMC_DCB_SLOPE (pipe), + crtc_state->vrr.dc_balance.slope); +intel_de_write (display,PIPEDMC_DCB_VBLANK (pipe), + crtc_state->vrr.dc_balance.vblank_target);
Can we make a separate function for this something like:
intel_vrr_enable_dc_balancing()
{
if (!crtc_state->vrr.dc_balance.enable)
Return;
…..
…..
}
Similar thing for disable.
Regards,
Ankit
Quoted 39 lines
drivers/gpu/drm/i915/display/intel_vrr.c +22
-0+ } + vrr_ctl =VRR_CTL_VRR_ENABLE |trans_vrr_ctl (crtc_state);/* @@ -785,6 +818,8 @@ static void intel_vrr_tg_disable(const struct intel_crtc_state *old_crtc_state) {struct intel_display *display =to_intel_display (old_crtc_state);enum transcoder cpu_transcoder = old_crtc_state->cpu_transcoder; +struct intel_crtc *crtc =to_intel_crtc (old_crtc_state->uapi.crtc); +enum pipe pipe = crtc->pipe;intel_de_write (display,TRANS_VRR_CTL (display, cpu_transcoder),trans_vrr_ctl (old_crtc_state));@@ -795,6 +830,24 @@ static void intel_vrr_tg_disable(const struct intel_crtc_state *old_crtc_state)drm_err (display->drm,"Timed out waiting for VRR live status to clear\n" );intel_de_write (display,TRANS_PUSH (display, cpu_transcoder),0 ); + +if (old_crtc_state->vrr.dc_balance.enable) { +intel_de_write (display,PIPEDMC_DCB_VMIN (pipe),0 ); +intel_de_write (display,PIPEDMC_DCB_VMAX (pipe),0 ); +intel_de_write (display,PIPEDMC_DCB_MAX_INCREASE (pipe),0 ); +intel_de_write (display,PIPEDMC_DCB_MAX_DECREASE (pipe),0 ); +intel_de_write (display,PIPEDMC_DCB_GUARDBAND (pipe),0 ); +intel_de_write (display,PIPEDMC_DCB_SLOPE (pipe),0 ); +intel_de_write (display,PIPEDMC_DCB_VBLANK (pipe),0 ); +intel_de_write (display,TRANS_VRR_DCB_ADJ_VMAX_CFG_LIVE (cpu_transcoder),0 ); +intel_de_write (display,TRANS_VRR_DCB_ADJ_FLIPLINE_CFG_LIVE (cpu_transcoder),0 ); +intel_de_write (display,TRANS_VRR_DCB_VMAX_LIVE (cpu_transcoder),0 ); +intel_de_write (display,TRANS_VRR_DCB_FLIPLINE_LIVE (cpu_transcoder),0 ); +intel_de_write (display,TRANS_VRR_DCB_ADJ_VMAX_CFG (cpu_transcoder),0 ); +intel_de_write (display,TRANS_VRR_DCB_ADJ_FLIPLINE_CFG (cpu_transcoder),0 ); +intel_de_write (display,TRANS_VRR_DCB_VMAX (cpu_transcoder),0 ); +intel_de_write (display,TRANS_VRR_DCB_FLIPLINE (cpu_transcoder),0 ); + } }void intel_vrr_enable (const struct intel_crtc_state *crtc_state)
PATCH RESEND 13/22 drm/i915/vrr: Configure DC balance flipline adjustment
In reply to Mitul GolaniConfigure DC Balance Flipline adjustment once after other DC balance adjustment registers are written.
Bspec: 68935
--- drivers/gpu/drm/i915/display/intel_vrr.c | 2 ++ 1 file changed, 2 insertions(+)
drivers/gpu/drm/i915/display/intel_vrr.c +2 -0
@@ -785,6 +785,8 @@ static void intel_vrr_tg_enable(const struct intel_crtc_state *crtc_state, VRR_DCB_FLIPLINE(crtc_state->vrr.flipline - 1));intel_de_write (display,TRANS_VRR_DCB_ADJ_FLIPLINE_CFG_LIVE (cpu_transcoder),VRR_DCB_ADJ_FLIPLINE (crtc_state->vrr.flipline -1 )); +intel_de_write (display,TRANS_VRR_DCB_ADJ_FLIPLINE_CFG (cpu_transcoder), +VRR_DCB_ADJ_FLIPLINE (crtc_state->vrr.flipline -1 ));intel_de_write (display,PIPEDMC_DCB_VMIN (pipe), crtc_state->vrr.dc_balance.vmin -1 ); intel_de_write(display, PIPEDMC_DCB_VMAX(pipe),
Signature · 1 line
2.48.1
Re: [RESEND, 13/22] drm/i915/vrr: Configure DC balance flipline adjustment
Quoted 15 lines · Mitul Golani
Configure DC Balance Flipline adjustment once after other DC balance adjustment registers are written.
Bspec: 68935
Signed-off-by Mitul Golani <[email protected]>--- drivers/gpu/drm/i915/display/intel_vrr.c | 2 ++ 1 file changed, 2 insertions(+)drivers/gpu/drm/i915/display/intel_vrr.c +0
-0
drivers/gpu/drm/i915/display/intel_vrr.c static void intel_vrr_tg_enable(const struct intel_crtc_state *crtc_state, · line 789
Quoted 5 lines
drivers/gpu/drm/i915/display/intel_vrr.c +2
-0@@ -785,6 +785,8 @@ static void intel_vrr_tg_enable(const struct intel_crtc_state *crtc_state, VRR_DCB_FLIPLINE(crtc_state->vrr.flipline - 1));intel_de_write (display,TRANS_VRR_DCB_ADJ_FLIPLINE_CFG_LIVE (cpu_transcoder),VRR_DCB_ADJ_FLIPLINE (crtc_state->vrr.flipline -1 )); +intel_de_write (display,TRANS_VRR_DCB_ADJ_FLIPLINE_CFG (cpu_transcoder), +VRR_DCB_ADJ_FLIPLINE (crtc_state->vrr.flipline -1 ));
This can be part of the earlier patch.
Regards,
Ankit
Quoted 3 lines
drivers/gpu/drm/i915/display/intel_vrr.c +0
-0intel_de_write (display,PIPEDMC_DCB_VMIN (pipe), crtc_state->vrr.dc_balance.vmin -1 ); intel_de_write(display, PIPEDMC_DCB_VMAX(pipe),
PATCH RESEND 14/22 drm/i915/vblank: Extract vrr_vblank_start()
In reply to Mitul GolaniFrom: Ville Syrjälä <[email protected]>
Initialise delayed vblank position for evasion logic.
--- drivers/gpu/drm/i915/display/intel_vblank.c | 13 +++++++++---- 1 file changed, 9 insertions(+), 4 deletions(-)
drivers/gpu/drm/i915/display/intel_vblank.c +9 -4
@@ -652,6 +652,14 @@ intel_pre_commit_crtc_state(struct intel_atomic_state *state,return pre_commit_crtc_state (old_crtc_state, new_crtc_state); } +static int vrr_vblank_start (const struct intel_crtc_state *crtc_state) +{ +if (intel_vrr_is_push_sent (crtc_state)) +return intel_vrr_vmin_vblank_start (crtc_state); +else +return intel_vrr_vmax_vblank_start (crtc_state); +} +void intel_vblank_evade_init (const struct intel_crtc_state *old_crtc_state,const struct intel_crtc_state *new_crtc_state,struct intel_vblank_evade_ctx *evade)
@@ -678,10 +686,7 @@ void intel_vblank_evade_init(const struct intel_crtc_state *old_crtc_state,drm_WARN_ON (crtc->base.dev,intel_crtc_needs_modeset (new_crtc_state) || new_crtc_state->update_m_n || new_crtc_state->update_lrr); -if (intel_vrr_is_push_sent (crtc_state)) - evade->vblank_start =intel_vrr_vmin_vblank_start (crtc_state); -else - evade->vblank_start =intel_vrr_vmax_vblank_start (crtc_state); + evade->vblank_start =vrr_vblank_start (crtc_state); vblank_delay = crtc_state->set_context_latency; }else {
Signature · 1 line
2.48.1
PATCH RESEND 15/22 drm/i915/vrr: Implement vblank evasion with DC balancing
In reply to Mitul GolaniFrom: Ville Syrjälä <[email protected]>
Add vblank evasion logic when vrr is already enabled along with dc balance is computed.
--- drivers/gpu/drm/i915/display/intel_dsb.c | 31 ++++++++++++++++++++- drivers/gpu/drm/i915/display/intel_vblank.c | 26 +++++++++++++++-- 2 files changed, 53 insertions(+), 4 deletions(-)
drivers/gpu/drm/i915/display/intel_dsb.c +30 -1
@@ -704,7 +704,36 @@ void intel_dsb_vblank_evade(struct intel_atomic_state *state,if (crtc_state->has_psr)intel_dsb_emit_wait_dsl (dsb,DSB_OPCODE_WAIT_DSL_OUT ,0 ,0 ); -if (pre_commit_is_vrr_active (state, crtc)) { +if (pre_commit_is_vrr_active (state, crtc) && crtc_state->vrr.dc_balance.enable) { +int vblank_delay = crtc_state->set_context_latency; +int vmin_vblank_start, vmax_vblank_start; + + vmin_vblank_start =intel_vrr_dcb_vmin_vblank_start_next (crtc_state); + +if (vmin_vblank_start >=0 ) { + end = vmin_vblank_start; + start = end - vblank_delay - latency; +intel_dsb_wait_scanline_out (state, dsb, start, end); + } + + vmax_vblank_start =intel_vrr_dcb_vmax_vblank_start_next (crtc_state); + +if (vmax_vblank_start >=0 ) { + end = vmax_vblank_start; + start = end - vblank_delay - latency; +intel_dsb_wait_scanline_out (state, dsb, start, end); + } + + vmin_vblank_start =intel_vrr_dcb_vmin_vblank_start_final (crtc_state); + end = vmin_vblank_start; + start = end - vblank_delay - latency; +intel_dsb_wait_scanline_out (state, dsb, start, end); + + vmax_vblank_start =intel_vrr_dcb_vmax_vblank_start_final (crtc_state); + end = vmax_vblank_start; + start = end - vblank_delay - latency; +intel_dsb_wait_scanline_out (state, dsb, start, end); + }else if (pre_commit_is_vrr_active (state, crtc)) {int vblank_delay = crtc_state->set_context_latency; end =intel_vrr_vmin_vblank_start (crtc_state);
drivers/gpu/drm/i915/display/intel_vblank.c +23 -3
@@ -654,10 +654,30 @@ intel_pre_commit_crtc_state(struct intel_atomic_state *state,static int vrr_vblank_start (const struct intel_crtc_state *crtc_state) { -if (intel_vrr_is_push_sent (crtc_state)) -return intel_vrr_vmin_vblank_start (crtc_state); +bool is_push_sent =intel_vrr_is_push_sent (crtc_state); +int vblank_start; + +if (!crtc_state->vrr.dc_balance.enable) { +if (is_push_sent) +return intel_vrr_vmin_vblank_start (crtc_state); +else +return intel_vrr_vmax_vblank_start (crtc_state); + } + +if (is_push_sent) + vblank_start =intel_vrr_dcb_vmin_vblank_start_next (crtc_state);else -return intel_vrr_vmax_vblank_start (crtc_state); + vblank_start =intel_vrr_dcb_vmax_vblank_start_next (crtc_state); + +if (vblank_start >=0 ) +return vblank_start; + +if (is_push_sent) + vblank_start =intel_vrr_dcb_vmin_vblank_start_final (crtc_state); +else + vblank_start =intel_vrr_dcb_vmax_vblank_start_final (crtc_state); + +return vblank_start; } void intel_vblank_evade_init(const struct intel_crtc_state *old_crtc_state,
Signature · 1 line
2.48.1
PATCH RESEND 16/22 drm/i915/display: Wait for VRR PUSH status update
In reply to Mitul GolaniAfter VRR Push is sent, need to wait till flipline decision boundary to get Push bit to get cleared.
--- drivers/gpu/drm/i915/display/intel_display.c | 23 ++++++++++++++++++++ 1 file changed, 23 insertions(+)
drivers/gpu/drm/i915/display/intel_display.c +23 -0
@@ -7287,6 +7287,22 @@ static void intel_atomic_dsb_prepare(struct intel_atomic_state *state,intel_color_prepare_commit (state, crtc); } +static int +dcb_vmin_vblank_start (struct intel_crtc_state *crtc_state) +{ +return (intel_vrr_dcb_vmin_vblank_start_next (crtc_state) <0 ) ? +intel_vrr_dcb_vmin_vblank_start_final (crtc_state) : +intel_vrr_dcb_vmin_vblank_start_next (crtc_state); +} + +static int +dcb_vmax_vblank_start (struct intel_crtc_state *crtc_state) +{ +return (intel_vrr_dcb_vmax_vblank_start_next (crtc_state) <0 ) ? +intel_vrr_dcb_vmax_vblank_start_final (crtc_state) : +intel_vrr_dcb_vmax_vblank_start_next (crtc_state); +} +static void intel_atomic_dsb_finish (struct intel_atomic_state *state,struct intel_crtc *crtc) {
@@ -7371,6 +7387,13 @@ static void intel_atomic_dsb_finish(struct intel_atomic_state *state,intel_vrr_dcb_increment_flip_count (new_crtc_state, crtc);intel_vrr_send_push (new_crtc_state->dsb_commit, new_crtc_state);intel_dsb_wait_for_delayed_vblank (state, new_crtc_state->dsb_commit); + +if (new_crtc_state->vrr.dc_balance.enable) { +intel_dsb_wait_scanline_in (state, new_crtc_state->dsb_commit, +dcb_vmin_vblank_start (new_crtc_state), +dcb_vmax_vblank_start (new_crtc_state)); + } +intel_vrr_check_push_sent (new_crtc_state->dsb_commit, new_crtc_state);intel_dsb_interrupt (new_crtc_state->dsb_commit);
Signature · 1 line
2.48.1
Re: [RESEND, 16/22] drm/i915/display: Wait for VRR PUSH status update
Quoted 36 lines · Mitul Golani
After VRR Push is sent, need to wait till flipline decision boundary to get Push bit to get cleared.
Signed-off-by Mitul Golani <[email protected]>--- drivers/gpu/drm/i915/display/intel_display.c | 23 ++++++++++++++++++++ 1 file changed, 23 insertions(+)drivers/gpu/drm/i915/display/intel_display.c +16
-0@@ -7287,6 +7287,22 @@ static void intel_atomic_dsb_prepare(struct intel_atomic_state *state,intel_color_prepare_commit (state, crtc); } +static int +dcb_vmin_vblank_start (struct intel_crtc_state *crtc_state) +{ +return (intel_vrr_dcb_vmin_vblank_start_next (crtc_state) <0 ) ? +intel_vrr_dcb_vmin_vblank_start_final (crtc_state) : +intel_vrr_dcb_vmin_vblank_start_next (crtc_state); +} + +static int +dcb_vmax_vblank_start (struct intel_crtc_state *crtc_state) +{ +return (intel_vrr_dcb_vmax_vblank_start_next (crtc_state) <0 ) ? +intel_vrr_dcb_vmax_vblank_start_final (crtc_state) : +intel_vrr_dcb_vmax_vblank_start_next (crtc_state); +} +static void intel_atomic_dsb_finish (struct intel_atomic_state *state,struct intel_crtc *crtc) {
drivers/gpu/drm/i915/display/intel_display.c static void intel_atomic_dsb_finish(struct intel_atomic_state *state, · line 7395
Quoted 9 lines
drivers/gpu/drm/i915/display/intel_display.c +6
-0@@ -7371,6 +7387,13 @@ static void intel_atomic_dsb_finish(struct intel_atomic_state *state,intel_vrr_dcb_increment_flip_count (new_crtc_state, crtc);intel_vrr_send_push (new_crtc_state->dsb_commit, new_crtc_state);intel_dsb_wait_for_delayed_vblank (state, new_crtc_state->dsb_commit); + +if (new_crtc_state->vrr.dc_balance.enable) { +intel_dsb_wait_scanline_in (state, new_crtc_state->dsb_commit, +dcb_vmin_vblank_start (new_crtc_state), +dcb_vmax_vblank_start (new_crtc_state)); + }
Hmm... lets not add this as a separate thing. The idea is to wait for vmin safe window, so that after that we are exactly SCL lines away from the delayed vblank.
As I understand, DMC FW will adjust the VRR timings so we need to use the Live values from the registers.
I think we need to use the TRANS_VRR_DCB_FLIPLINE_LIVE value for computing thevrr vmin safe window end in intel_dsb_wait_for_delayed_vblank() when DC balancing is enabled.
Regards,
Ankit
Quoted 4 lines
drivers/gpu/drm/i915/display/intel_display.c +1
-0+intel_vrr_check_push_sent (new_crtc_state->dsb_commit, new_crtc_state);intel_dsb_interrupt (new_crtc_state->dsb_commit);
PATCH RESEND 17/22 drm/i915/dsb: Add pipedmc dc balance enable/disable
In reply to Mitul GolaniFrom: Ville Syrjälä <[email protected]>
Add function to control DC balance enable/disable bit via DSB.
--- drivers/gpu/drm/i915/display/intel_dmc.c | 17 +++++++++++++++++ drivers/gpu/drm/i915/display/intel_dmc.h | 4 ++++ 2 files changed, 21 insertions(+)
drivers/gpu/drm/i915/display/intel_dmc.c +17 -0
@@ -1748,3 +1748,20 @@ u32 intel_pipedmc_start_mmioaddr(struct intel_crtc *crtc)return dmc ? dmc->dmc_info[dmc_id].start_mmioaddr :0 ; } + +void intel_pipedmc_dcb_enable (struct intel_dsb *dsb,struct intel_crtc *crtc) +{ +struct intel_display *display =to_intel_display (crtc); +enum pipe pipe = crtc->pipe; + +intel_de_write_dsb (display, dsb,PIPEDMC_DCB_CTL (pipe), +PIPEDMC_ADAPTIVE_DCB_ENABLE ); +} + +void intel_pipedmc_dcb_disable (struct intel_dsb *dsb,struct intel_crtc *crtc) +{ +struct intel_display *display =to_intel_display (crtc); +enum pipe pipe = crtc->pipe; + +intel_de_write_dsb (display, dsb,PIPEDMC_DCB_CTL (pipe),0 ); +}
drivers/gpu/drm/i915/display/intel_dmc.h +4 -0
@@ -10,11 +10,13 @@enum pipe ;enum pipedmc_event_id ; +struct intel_crtc ;struct drm_printer ;struct intel_crtc ;struct intel_crtc_state ;struct intel_display ;struct intel_dmc_snapshot ; +struct intel_dsb ;void intel_dmc_init (struct intel_display *display);void intel_dmc_load_program (struct intel_display *display);
@@ -39,6 +41,8 @@ void intel_dmc_update_dc6_allowed_count(struct intel_display *display, bool starvoid assert_main_dmc_loaded (struct intel_display *display);void intel_pipedmc_irq_handler (struct intel_display *display,enum pipe pipe); +void intel_pipedmc_dcb_enable (struct intel_dsb *dsb,struct intel_crtc *crtc); +void intel_pipedmc_dcb_disable (struct intel_dsb *dsb,struct intel_crtc *crtc);u32 intel_pipedmc_start_mmioaddr (struct intel_crtc *crtc); void intel_pipedmc_enable_event(struct intel_crtc *crtc,
Signature · 1 line
2.48.1
Jani Nikula
maintainerRe: [RESEND, 17/22] drm/i915/dsb: Add pipedmc dc balance enable/disable
Quoted 42 lines · Mitul Golani
From: Ville Syrjälä <[email protected]>
Add function to control DC balance enable/disable bit via DSB.
Signed-off-by Ville Syrjälä <[email protected]>Signed-off-by Mitul Golani <[email protected]>Reviewed-by Ankit Nautiyal <[email protected]>--- drivers/gpu/drm/i915/display/intel_dmc.c | 17 +++++++++++++++++ drivers/gpu/drm/i915/display/intel_dmc.h | 4 ++++ 2 files changed, 21 insertions(+)drivers/gpu/drm/i915/display/intel_dmc.c +17
-0@@ -1748,3 +1748,20 @@ u32 intel_pipedmc_start_mmioaddr(struct intel_crtc *crtc)return dmc ? dmc->dmc_info[dmc_id].start_mmioaddr :0 ; } + +void intel_pipedmc_dcb_enable (struct intel_dsb *dsb,struct intel_crtc *crtc) +{ +struct intel_display *display =to_intel_display (crtc); +enum pipe pipe = crtc->pipe; + +intel_de_write_dsb (display, dsb,PIPEDMC_DCB_CTL (pipe), +PIPEDMC_ADAPTIVE_DCB_ENABLE ); +} + +void intel_pipedmc_dcb_disable (struct intel_dsb *dsb,struct intel_crtc *crtc) +{ +struct intel_display *display =to_intel_display (crtc); +enum pipe pipe = crtc->pipe; + +intel_de_write_dsb (display, dsb,PIPEDMC_DCB_CTL (pipe),0 ); +}drivers/gpu/drm/i915/display/intel_dmc.h +0
-0
drivers/gpu/drm/i915/display/intel_dmc.h line 19
Quoted 10 lines
drivers/gpu/drm/i915/display/intel_dmc.h +2
-0@@ -10,11 +10,13 @@enum pipe ;enum pipedmc_event_id ; +struct intel_crtc ;struct drm_printer ;struct intel_crtc ;struct intel_crtc_state ;struct intel_display ;struct intel_dmc_snapshot ; +struct intel_dsb ;
Please keep forward declarations sorted.
Quoted 12 lines
drivers/gpu/drm/i915/display/intel_dmc.h +2
-0void intel_dmc_init (struct intel_display *display);void intel_dmc_load_program (struct intel_display *display);@@ -39,6 +41,8 @@ void intel_dmc_update_dc6_allowed_count(struct intel_display *display, bool starvoid assert_main_dmc_loaded (struct intel_display *display);void intel_pipedmc_irq_handler (struct intel_display *display,enum pipe pipe); +void intel_pipedmc_dcb_enable (struct intel_dsb *dsb,struct intel_crtc *crtc); +void intel_pipedmc_dcb_disable (struct intel_dsb *dsb,struct intel_crtc *crtc);u32 intel_pipedmc_start_mmioaddr (struct intel_crtc *crtc); void intel_pipedmc_enable_event(struct intel_crtc *crtc,
Signature · 1 line
Jani Nikula, Intel
PATCH RESEND 18/22 drm/i915/vrr: Pause DC Balancing for DSB commits
In reply to Mitul GolaniFrom: Ville Syrjälä <[email protected]>
Pause the DMC DC Balancing for the remainder of the commit so that vmin/vmax won't change after we've baked them into the DSB vblank evasion commands.
--v2:
- Remove typo. (Ankit)
- Separate vrr enable structuring. (Ankit)
--v3:
- Add gaurd before accessing DC balance bits.
- Remove redundancy checks.
--- drivers/gpu/drm/i915/display/intel_display.c | 19 +++++++++++++++++++ drivers/gpu/drm/i915/display/intel_vrr.c | 5 +++++ 2 files changed, 24 insertions(+)
drivers/gpu/drm/i915/display/intel_display.c +19 -0
@@ -7335,6 +7335,21 @@ static void intel_atomic_dsb_finish(struct intel_atomic_state *state,if (new_crtc_state->use_flipq)intel_flipq_wait_dmc_halt (new_crtc_state->dsb_commit, crtc); +if (new_crtc_state->vrr.dc_balance.enable) { +/* +* Pause the DMC DC balancing for the remainder of +* the commit so that vmin/vmax won't change after +* we've baked them into the DSB vblank evasion +* commands. +* +* FIXME maybe need a small delay here to make sure +* DMC has finished updating the values? Or we need +* a better DMC<->driver protocol that gives is real +* guarantees about that... +*/ +intel_pipedmc_dcb_disable (NULL , crtc); + } +if (intel_crtc_needs_color_update (new_crtc_state))intel_color_commit_noarm (new_crtc_state->dsb_commit, new_crtc_state);
@@ -7396,6 +7411,10 @@ static void intel_atomic_dsb_finish(struct intel_atomic_state *state,intel_vrr_check_push_sent (new_crtc_state->dsb_commit, new_crtc_state); + +if (new_crtc_state->vrr.dc_balance.enable) +intel_pipedmc_dcb_enable (new_crtc_state->dsb_commit, crtc); +intel_dsb_interrupt (new_crtc_state->dsb_commit); }
drivers/gpu/drm/i915/display/intel_vrr.c +5 -0
@@ -9,6 +9,7 @@#include "intel_de.h" #include "intel_display_regs.h" #include "intel_display_types.h" +#include "intel_dmc.h" #include "intel_dmc_regs.h" #include "intel_dp.h" #include "intel_psr.h"
@@ -813,6 +814,9 @@ static void intel_vrr_tg_enable(const struct intel_crtc_state *crtc_state,if (cmrr_enable) vrr_ctl |=VRR_CTL_CMRR_ENABLE ; +if (crtc_state->vrr.dc_balance.enable) +intel_pipedmc_dcb_enable (NULL , crtc); +intel_de_write (display,TRANS_VRR_CTL (display, cpu_transcoder), vrr_ctl); }
@@ -834,6 +838,7 @@ static void intel_vrr_tg_disable(const struct intel_crtc_state *old_crtc_state)intel_de_write (display,TRANS_PUSH (display, cpu_transcoder),0 );if (old_crtc_state->vrr.dc_balance.enable) { +intel_pipedmc_dcb_disable (NULL , crtc);intel_de_write (display,PIPEDMC_DCB_VMIN (pipe),0 );intel_de_write (display,PIPEDMC_DCB_VMAX (pipe),0 );intel_de_write (display,PIPEDMC_DCB_MAX_INCREASE (pipe),0 );
Signature · 1 line
2.48.1
PATCH RESEND 19/22 drm/i915/display: Add function to configure event for dc balance
In reply to Mitul GolaniConfigure pipe dmc event for dc balance enable/disable.
--v2:
- Initialize with redundant flags. (Ankit)
--v3:
- Add function as per new enable/disable configuration framework.
--- drivers/gpu/drm/i915/display/intel_dmc.c | 15 +++++++++++++++ drivers/gpu/drm/i915/display/intel_dmc.h | 2 ++ drivers/gpu/drm/i915/display/intel_vrr.c | 5 ++++- 3 files changed, 21 insertions(+), 1 deletion(-)
drivers/gpu/drm/i915/display/intel_dmc.c +15 -0
@@ -852,6 +852,21 @@ static void dmc_configure_event(struct intel_display *display, dmc_id, num_handlers, event_id); } +/* +* intel_dmc_configure_dc_balance_event() - Configure event +* for dc balance enable/disable +* @display: display instance +* @pipe: pipe which register use to block +* @enable: enable/disable +*/ +void intel_dmc_configure_dc_balance_event (struct intel_display *display, +enum pipe pipe,bool enable) +{ +enum intel_dmc_id dmc_id =PIPE_TO_DMC_ID (pipe); + +dmc_configure_event (display, dmc_id,PIPEDMC_EVENT_ADAPTIVE_DCB_TRIGGER , enable); +} +/** * intel_dmc_block_pkgc() - block PKG C-state * @display: display instance
drivers/gpu/drm/i915/display/intel_dmc.h +2 -0
@@ -26,6 +26,8 @@ void intel_dmc_enable_pipe(const struct intel_crtc_state *crtc_state);void intel_dmc_disable_pipe (const struct intel_crtc_state *crtc_state);void intel_dmc_block_pkgc (struct intel_display *display,enum pipe pipe,bool block); +void intel_dmc_configure_dc_balance_event (struct intel_display *display, +enum pipe pipe,bool enable);void intel_dmc_start_pkgc_exit_at_start_of_undelayed_vblank (struct intel_display *display,enum pipe pipe,bool enable);void intel_dmc_fini (struct intel_display *display);
drivers/gpu/drm/i915/display/intel_vrr.c +4 -1
@@ -814,8 +814,10 @@ static void intel_vrr_tg_enable(const struct intel_crtc_state *crtc_state,if (cmrr_enable) vrr_ctl |=VRR_CTL_CMRR_ENABLE ; -if (crtc_state->vrr.dc_balance.enable) +if (crtc_state->vrr.dc_balance.enable) { +intel_dmc_configure_dc_balance_event (display, pipe, true);intel_pipedmc_dcb_enable (NULL , crtc); + }intel_de_write (display,TRANS_VRR_CTL (display, cpu_transcoder), vrr_ctl); }
@@ -839,6 +841,7 @@ static void intel_vrr_tg_disable(const struct intel_crtc_state *old_crtc_state)if (old_crtc_state->vrr.dc_balance.enable) {intel_pipedmc_dcb_disable (NULL , crtc); +intel_dmc_configure_dc_balance_event (display, pipe, false);intel_de_write (display,PIPEDMC_DCB_VMIN (pipe),0 );intel_de_write (display,PIPEDMC_DCB_VMAX (pipe),0 );intel_de_write (display,PIPEDMC_DCB_MAX_INCREASE (pipe),0 );
Signature · 1 line
2.48.1
Re: [RESEND, 19/22] drm/i915/display: Add function to configure event for dc balance
Quoted 7 lines · Mitul Golani
Configure pipe dmc event for dc balance enable/disable.
--v2:
- Initialize with redundant flags. (Ankit)--v3:
- Add function as per new enable/disable configuration framework.
This is a new patch, the version history is no more applicable.
Regards,
Ankit
Quoted 70 lines
Signed-off-by Mitul Golani <[email protected]>--- drivers/gpu/drm/i915/display/intel_dmc.c | 15 +++++++++++++++ drivers/gpu/drm/i915/display/intel_dmc.h | 2 ++ drivers/gpu/drm/i915/display/intel_vrr.c | 5 ++++- 3 files changed, 21 insertions(+), 1 deletion(-)drivers/gpu/drm/i915/display/intel_dmc.c +15
-0@@ -852,6 +852,21 @@ static void dmc_configure_event(struct intel_display *display, dmc_id, num_handlers, event_id); } +/* +* intel_dmc_configure_dc_balance_event() - Configure event +* for dc balance enable/disable +* @display: display instance +* @pipe: pipe which register use to block +* @enable: enable/disable +*/ +void intel_dmc_configure_dc_balance_event (struct intel_display *display, +enum pipe pipe,bool enable) +{ +enum intel_dmc_id dmc_id =PIPE_TO_DMC_ID (pipe); + +dmc_configure_event (display, dmc_id,PIPEDMC_EVENT_ADAPTIVE_DCB_TRIGGER , enable); +} +/** * intel_dmc_block_pkgc() - block PKG C-state * @display: display instance drivers/gpu/drm/i915/display/intel_dmc.h +2
-0@@ -26,6 +26,8 @@ void intel_dmc_enable_pipe(const struct intel_crtc_state *crtc_state);void intel_dmc_disable_pipe (const struct intel_crtc_state *crtc_state);void intel_dmc_block_pkgc (struct intel_display *display,enum pipe pipe,bool block); +void intel_dmc_configure_dc_balance_event (struct intel_display *display, +enum pipe pipe,bool enable);void intel_dmc_start_pkgc_exit_at_start_of_undelayed_vblank (struct intel_display *display,enum pipe pipe,bool enable);void intel_dmc_fini (struct intel_display *display);drivers/gpu/drm/i915/display/intel_vrr.c +4
-1@@ -814,8 +814,10 @@ static void intel_vrr_tg_enable(const struct intel_crtc_state *crtc_state,if (cmrr_enable) vrr_ctl |=VRR_CTL_CMRR_ENABLE ; -if (crtc_state->vrr.dc_balance.enable) +if (crtc_state->vrr.dc_balance.enable) { +intel_dmc_configure_dc_balance_event (display, pipe, true);intel_pipedmc_dcb_enable (NULL , crtc); + }intel_de_write (display,TRANS_VRR_CTL (display, cpu_transcoder), vrr_ctl); }@@ -839,6 +841,7 @@ static void intel_vrr_tg_disable(const struct intel_crtc_state *old_crtc_state)if (old_crtc_state->vrr.dc_balance.enable) {intel_pipedmc_dcb_disable (NULL , crtc); +intel_dmc_configure_dc_balance_event (display, pipe, false);intel_de_write (display,PIPEDMC_DCB_VMIN (pipe),0 );intel_de_write (display,PIPEDMC_DCB_VMAX (pipe),0 );intel_de_write (display,PIPEDMC_DCB_MAX_INCREASE (pipe),0 );
PATCH RESEND 20/22 drm/i915/vrr: Enable Adaptive sync counter bit
In reply to Mitul GolaniAdd enable/disable frame counters for DC Balance odd and even frame count calculation.
--v2:
Update commit message
--v3:
- Driver should not control adjustment enable bit, as that is already being controlled by firmware. Release bit from driver computation.
- Commit message update.
--v4:
- Configure PIPEDMC_EVT_CTL enable/disable call.
--v5:
- Add Adaptive sync counter enable.
--- drivers/gpu/drm/i915/display/intel_vrr.c | 3 +++ 1 file changed, 3 insertions(+)
drivers/gpu/drm/i915/display/intel_vrr.c +3 -0
@@ -816,6 +816,8 @@ static void intel_vrr_tg_enable(const struct intel_crtc_state *crtc_state,if (crtc_state->vrr.dc_balance.enable) {intel_dmc_configure_dc_balance_event (display, pipe, true); +intel_de_write (display,TRANS_ADAPTIVE_SYNC_DCB_CTL (cpu_transcoder), +ADAPTIVE_SYNC_COUNTER_EN );intel_pipedmc_dcb_enable (NULL , crtc); }
@@ -842,6 +844,7 @@ static void intel_vrr_tg_disable(const struct intel_crtc_state *old_crtc_state)if (old_crtc_state->vrr.dc_balance.enable) {intel_pipedmc_dcb_disable (NULL , crtc);intel_dmc_configure_dc_balance_event (display, pipe, false); +intel_de_write (display,TRANS_ADAPTIVE_SYNC_DCB_CTL (cpu_transcoder),0 );intel_de_write (display,PIPEDMC_DCB_VMIN (pipe),0 );intel_de_write (display,PIPEDMC_DCB_VMAX (pipe),0 );intel_de_write (display,PIPEDMC_DCB_MAX_INCREASE (pipe),0 );
Signature · 1 line
2.48.1
Re: [RESEND, 20/22] drm/i915/vrr: Enable Adaptive sync counter bit
Quoted 37 lines · Mitul Golani
Add enable/disable frame counters for DC Balance odd and even frame count calculation.
--v2:
Update commit message--v3:
- Driver should not control adjustment enable bit, as that is already being controlled by firmware. Release bit from driver computation.
- Commit message update.--v4:
- ConfigurePIPEDMC_EVT_CTLenable/disable call.--v5:
- Add Adaptive sync counter enable.Signed-off-by Mitul Golani <[email protected]>--- drivers/gpu/drm/i915/display/intel_vrr.c | 3 +++ 1 file changed, 3 insertions(+)drivers/gpu/drm/i915/display/intel_vrr.c +2
-0@@ -816,6 +816,8 @@ static void intel_vrr_tg_enable(const struct intel_crtc_state *crtc_state,if (crtc_state->vrr.dc_balance.enable) {intel_dmc_configure_dc_balance_event (display, pipe, true); +intel_de_write (display,TRANS_ADAPTIVE_SYNC_DCB_CTL (cpu_transcoder), +ADAPTIVE_SYNC_COUNTER_EN );intel_pipedmc_dcb_enable (NULL , crtc); }
drivers/gpu/drm/i915/display/intel_vrr.c static void intel_vrr_tg_disable(const struct intel_crtc_state *old_crtc_state) · line 847
Quoted 4 lines
drivers/gpu/drm/i915/display/intel_vrr.c +1
-0@@ -842,6 +844,7 @@ static void intel_vrr_tg_disable(const struct intel_crtc_state *old_crtc_state)if (old_crtc_state->vrr.dc_balance.enable) {intel_pipedmc_dcb_disable (NULL , crtc);intel_dmc_configure_dc_balance_event (display, pipe, false); +intel_de_write (display,TRANS_ADAPTIVE_SYNC_DCB_CTL (cpu_transcoder),0 );
This change can be part of Patch#12.
Regards,
Ankit
Quoted 3 lines
drivers/gpu/drm/i915/display/intel_vrr.c +0
-0intel_de_write (display,PIPEDMC_DCB_VMIN (pipe),0 );intel_de_write (display,PIPEDMC_DCB_VMAX (pipe),0 );intel_de_write (display,PIPEDMC_DCB_MAX_INCREASE (pipe),0 );
PATCH RESEND 21/22 drm/i915/vrr: Enable DC Balance
In reply to Mitul GolaniEnable DC Balance from vrr compute config and related hw flag.
--- drivers/gpu/drm/i915/display/intel_vrr.c | 6 ++++++ 1 file changed, 6 insertions(+)
drivers/gpu/drm/i915/display/intel_vrr.c +6 -0
@@ -240,12 +240,17 @@ staticvoid intel_vrr_compute_vrr_timings (struct intel_crtc_state *crtc_state,int vmin,int vmax) { +struct intel_display *display =to_intel_display (crtc_state); + crtc_state->vrr.vmax = vmax; crtc_state->vrr.vmin = vmin; crtc_state->vrr.flipline = crtc_state->vrr.vmin; crtc_state->vrr.enable = true; crtc_state->mode_flags |=I915_MODE_FLAG_VRR ; + +if (HAS_VRR_DC_BALANCE (display)) + crtc_state->vrr.dc_balance.enable = true; } static
@@ -815,6 +820,7 @@ static void intel_vrr_tg_enable(const struct intel_crtc_state *crtc_state, vrr_ctl |=VRR_CTL_CMRR_ENABLE ;if (crtc_state->vrr.dc_balance.enable) { + vrr_ctl |=VRR_CTL_DCB_ADJ_ENABLE ;intel_dmc_configure_dc_balance_event (display, pipe, true);intel_de_write (display,TRANS_ADAPTIVE_SYNC_DCB_CTL (cpu_transcoder),ADAPTIVE_SYNC_COUNTER_EN );
Signature · 1 line
2.48.1
PATCH RESEND 22/22 drm/i915/vrr: Add function to check if DC Balance Possible
In reply to Mitul GolaniAdd function to check if DC Balance possibile on requested PIPE and also validate along with DISPLAY_VER check.
--- drivers/gpu/drm/i915/display/intel_vrr.c | 18 +++++++++++++++++- 1 file changed, 17 insertions(+), 1 deletion(-)
drivers/gpu/drm/i915/display/intel_vrr.c +17 -1
@@ -236,6 +236,22 @@ void intel_vrr_compute_cmrr_timings(struct intel_crtc_state *crtc_state) crtc_state->mode_flags |=I915_MODE_FLAG_VRR ; } +static +int intel_vrr_dc_balance_possible (const struct intel_crtc_state *crtc_state) +{ +struct intel_display *display =to_intel_display (crtc_state); +struct intel_crtc *crtc =to_intel_crtc (crtc_state->uapi.crtc); +enum pipe pipe = crtc->pipe; + +/* +* FIXME: Currently Firmware supports DC Balancing on PIPE A +* and PIPE B. Account those limitation while computing DC +* Balance parameters. +*/ +return (HAS_VRR_DC_BALANCE (display) && + ((pipe ==PIPE_A ) || (pipe ==PIPE_B ))); +} +static void intel_vrr_compute_vrr_timings (struct intel_crtc_state *crtc_state,int vmin,int vmax)
@@ -249,7 +265,7 @@ void intel_vrr_compute_vrr_timings(struct intel_crtc_state *crtc_state, crtc_state->vrr.enable = true; crtc_state->mode_flags |=I915_MODE_FLAG_VRR ; -if (HAS_VRR_DC_BALANCE (display)) +if (intel_vrr_dc_balance_possible (crtc_state)) crtc_state->vrr.dc_balance.enable = true; }
Signature · 1 line
2.48.1
Re: [RESEND, 22/22] drm/i915/vrr: Add function to check if DC Balance Possible
Quoted 22 lines · Mitul Golani
Add function to check if DC Balance possibile on requested PIPE and also validate along with
DISPLAY_VERcheck.Signed-off-by Mitul Golani <[email protected]>Reviewed-by Ankit Nautiyal <[email protected]>--- drivers/gpu/drm/i915/display/intel_vrr.c | 18 +++++++++++++++++- 1 file changed, 17 insertions(+), 1 deletion(-)drivers/gpu/drm/i915/display/intel_vrr.c +4
-0@@ -236,6 +236,22 @@ void intel_vrr_compute_cmrr_timings(struct intel_crtc_state *crtc_state) crtc_state->mode_flags |=I915_MODE_FLAG_VRR ; } +static +int intel_vrr_dc_balance_possible (const struct intel_crtc_state *crtc_state) +{ +struct intel_display *display =to_intel_display (crtc_state);
drivers/gpu/drm/i915/display/intel_vrr.c void intel_vrr_compute_cmrr_timings(struct intel_crtc_state *crtc_state) · line 252
Quoted 10 lines
drivers/gpu/drm/i915/display/intel_vrr.c +10
-0+struct intel_crtc *crtc =to_intel_crtc (crtc_state->uapi.crtc); +enum pipe pipe = crtc->pipe; + +/* +* FIXME: Currently Firmware supports DC Balancing on PIPE A +* and PIPE B. Account those limitation while computing DC +* Balance parameters. +*/ +return (HAS_VRR_DC_BALANCE (display) && + ((pipe ==PIPE_A ) || (pipe ==PIPE_B )));
Earlier there were plans to have this supported on other pipes, but now I think this condition is fixed that only PIPE A/B have this feature. So this change can be clubbed with the previous patch.
Regards,
Ankit
Quoted 14 lines
drivers/gpu/drm/i915/display/intel_vrr.c +3
-1+} +static void intel_vrr_compute_vrr_timings (struct intel_crtc_state *crtc_state,int vmin,int vmax)@@ -249,7 +265,7 @@ void intel_vrr_compute_vrr_timings(struct intel_crtc_state *crtc_state, crtc_state->vrr.enable = true; crtc_state->mode_flags |=I915_MODE_FLAG_VRR ; -if (HAS_VRR_DC_BALANCE (display)) +if (intel_vrr_dc_balance_possible (crtc_state)) crtc_state->vrr.dc_balance.enable = true; }
✗ CI.checkpatch: warning for Enable/Disable DC balance along with VRR DSB
In reply to Mitul Golani== Series Details ==
== Series Details ==
Series: Enable/Disable DC balance along with VRR DSB
URL : https://patchwork.freedesktop.org/series/156900/
State : warning
== Summary ==
+ KERNEL=/kernel
+ git clone https://gitlab.freedesktop.org/drm/maintainer-tools mt Cloning into 'mt'...
warning: redirecting to https://gitlab.freedesktop.org/drm/maintainer-tools.git/
+ git -C mt rev-list -n1 origin/master f867e605613af1770f90c4b0afd4a8f06424d1f0
+ cd /kernel
+ git config --global --add safe.directory /kernel
+ git log -n1
commit 832c66709ffb9fa9039ce222d77e3cec8c27ee6c
Author: Mitul Golani <[email protected]> Date: Mon Nov 3 11:00:02 2025 +0530
drm/i915/vrr: Add function to check if DC Balance Possible
Add function to check if DC Balance possibile on requested PIPE and also validate along with DISPLAY_VER check.
+ /mt/dim checkpatch b9356481c8ac3cba317f6c7af88db25452b0e515 drm-intel 19f6bb51cdca drm/i915/display: Add source param for dc balance f9ee61d1bb6a drm/i915/dmc: Add pipe dmc registers and bits for DC Balance -:27: WARNING:BAD_SIGN_OFF: Non-standard signature: Co-authored-by:
#27:
total: 0 errors, 1 warnings, 0 checks, 65 lines checked b09e282c1485 drm/i915/vrr: Add VRR DC balance registers 2fd70f9f18a7 drm/i915/vrr: Add functions to read out vmin/vmax stuff 1d19a937892a drm/i915/vrr: Add DC Balance params to crtc_state 1dc667c575ea drm/i915/vrr: Add state dump for DC Balance params 686d2ba125c0 drm/i915/vrr: Add compute config for DC Balance params 5c5d1155451e drm/i915/display: Add DC Balance flip counter in crtc c91d39651fa7 drm/i915/vrr: Increment DC balance flip count on every flip 9d09aa08afa9 drm/i915/vrr: Add function to reset DC Balance flip count f6846e48b7fa drm/i915/vrr: Add function reset DC balance accumulated params 66df3d187732 drm/i915/vrr: Write DC balance params to hw registers 032b8d82e68e drm/i915/vrr: Configure DC balance flipline adjustment 4cf4cb13ffc0 drm/i915/vblank: Extract vrr_vblank_start() a6f61de563e3 drm/i915/vrr: Implement vblank evasion with DC balancing b562a263dfc0 drm/i915/display: Wait for VRR PUSH status update dcf16bf120d4 drm/i915/dsb: Add pipedmc dc balance enable/disable c9cb8a7101b4 drm/i915/vrr: Pause DC Balancing for DSB commits afea25da00e9 drm/i915/display: Add function to configure event for dc balance 9c2d6d83216e drm/i915/vrr: Enable Adaptive sync counter bit bda864fff1ae drm/i915/vrr: Enable DC Balance832c66709ffb drm/i915/vrr: Add function to check if DC Balance Possible
Patchwork
CI✓ CI.KUnit: success for Enable/Disable DC balance along with VRR DSB
In reply to Mitul Golani== Series Details ==
== Series Details ==
Series: Enable/Disable DC balance along with VRR DSB
URL : https://patchwork.freedesktop.org/series/156900/
State : success
== Summary ==
+ trap cleanup EXIT
+ /kernel/tools/testing/kunit/kunit.py run --kunitconfig /kernel/drivers/gpu/drm/xe/.kunitconfig [05:38:20] Configuring KUnit Kernel ...
Generating .config ...
Populating config with:
$ make ARCH=um O=.kunit olddefconfig [05:38:24] Building KUnit Kernel ... Populating config with: $ make ARCH=um O=.kunit olddefconfig Building with: $ make all compile_commands.json scripts_gdb ARCH=um O=.kunit --jobs=48 [05:38:54] Starting KUnit Kernel (1/1)... [05:38:54] ============================================================ Running tests with: $ .kunit/linux kunit.enable=1 mem=1G console=tty kunit_shutdown=halt [05:38:55] ================== guc_buf (11 subtests) =================== [05:38:55] [PASSED] test_smallest [05:38:55] [PASSED] test_largest [05:38:55] [PASSED] test_granular [05:38:55] [PASSED] test_unique [05:38:55] [PASSED] test_overlap [05:38:55] [PASSED] test_reusable [05:38:55] [PASSED] test_too_big [05:38:55] [PASSED] test_flush [05:38:55] [PASSED] test_lookup [05:38:55] [PASSED] test_data [05:38:55] [PASSED] test_class [05:38:55] ===================== [PASSED] guc_buf ===================== [05:38:55] =================== guc_dbm (7 subtests) =================== [05:38:55] [PASSED] test_empty [05:38:55] [PASSED] test_default [05:38:55] ======================== test_size ======================== [05:38:55] [PASSED] 4 [05:38:55] [PASSED] 8 [05:38:55] [PASSED] 32 [05:38:55] [PASSED] 256 [05:38:55] ==================== [PASSED] test_size ==================== [05:38:55] ======================= test_reuse ======================== [05:38:55] [PASSED] 4 [05:38:55] [PASSED] 8 [05:38:55] [PASSED] 32 [05:38:55] [PASSED] 256 [05:38:55] =================== [PASSED] test_reuse ==================== [05:38:55] =================== test_range_overlap ==================== [05:38:55] [PASSED] 4 [05:38:55] [PASSED] 8 [05:38:55] [PASSED] 32 [05:38:55] [PASSED] 256 [05:38:55] =============== [PASSED] test_range_overlap ================ [05:38:55] =================== test_range_compact ==================== [05:38:55] [PASSED] 4 [05:38:55] [PASSED] 8 [05:38:55] [PASSED] 32 [05:38:55] [PASSED] 256 [05:38:55] =============== [PASSED] test_range_compact ================ [05:38:55] ==================== test_range_spare ===================== [05:38:55] [PASSED] 4 [05:38:55] [PASSED] 8 [05:38:55] [PASSED] 32 [05:38:55] [PASSED] 256 [05:38:55] ================ [PASSED] test_range_spare ================= [05:38:55] ===================== [PASSED] guc_dbm ===================== [05:38:55] =================== guc_idm (6 subtests) =================== [05:38:55] [PASSED] bad_init [05:38:55] [PASSED] no_init [05:38:55] [PASSED] init_fini [05:38:55] [PASSED] check_used [05:38:55] [PASSED] check_quota [05:38:55] [PASSED] check_all [05:38:55] ===================== [PASSED] guc_idm ===================== [05:38:55] ================== no_relay (3 subtests) =================== [05:38:55] [PASSED] xe_drops_guc2pf_if_not_ready [05:38:55] [PASSED] xe_drops_guc2vf_if_not_ready [05:38:55] [PASSED] xe_rejects_send_if_not_ready [05:38:55] ==================== [PASSED] no_relay ===================== [05:38:55] ================== pf_relay (14 subtests) ================== [05:38:55] [PASSED] pf_rejects_guc2pf_too_short [05:38:55] [PASSED] pf_rejects_guc2pf_too_long [05:38:55] [PASSED] pf_rejects_guc2pf_no_payload [05:38:55] [PASSED] pf_fails_no_payload [05:38:55] [PASSED] pf_fails_bad_origin [05:38:55] [PASSED] pf_fails_bad_type [05:38:55] [PASSED] pf_txn_reports_error [05:38:55] [PASSED] pf_txn_sends_pf2guc [05:38:55] [PASSED] pf_sends_pf2guc [05:38:55] [SKIPPED] pf_loopback_nop [05:38:55] [SKIPPED] pf_loopback_echo [05:38:55] [SKIPPED] pf_loopback_fail [05:38:55] [SKIPPED] pf_loopback_busy [05:38:55] [SKIPPED] pf_loopback_retry [05:38:55] ==================== [PASSED] pf_relay ===================== [05:38:55] ================== vf_relay (3 subtests) =================== [05:38:55] [PASSED] vf_rejects_guc2vf_too_short [05:38:55] [PASSED] vf_rejects_guc2vf_too_long [05:38:55] [PASSED] vf_rejects_guc2vf_no_payload [05:38:55] ==================== [PASSED] vf_relay ===================== [05:38:55] ===================== lmtt (1 subtest) ===================== [05:38:55] ======================== test_ops ========================= [05:38:55] [PASSED] 2-level [05:38:55] [PASSED] multi-level [05:38:55] ==================== [PASSED] test_ops ===================== [05:38:55] ====================== [PASSED] lmtt ======================= [05:38:55] ================= pf_service (11 subtests) ================= [05:38:55] [PASSED] pf_negotiate_any [05:38:55] [PASSED] pf_negotiate_base_match [05:38:55] [PASSED] pf_negotiate_base_newer [05:38:55] [PASSED] pf_negotiate_base_next [05:38:55] [SKIPPED] pf_negotiate_base_older [05:38:55] [PASSED] pf_negotiate_base_prev [05:38:55] [PASSED] pf_negotiate_latest_match [05:38:55] [PASSED] pf_negotiate_latest_newer [05:38:55] [PASSED] pf_negotiate_latest_next [05:38:55] [SKIPPED] pf_negotiate_latest_older [05:38:55] [SKIPPED] pf_negotiate_latest_prev [05:38:55] =================== [PASSED] pf_service ==================== [05:38:55] ================= xe_guc_g2g (2 subtests) ================== [05:38:55] ============== xe_live_guc_g2g_kunit_default ============== [05:38:55] ========= [SKIPPED] xe_live_guc_g2g_kunit_default ========== [05:38:55] ============== xe_live_guc_g2g_kunit_allmem =============== [05:38:55] ========== [SKIPPED] xe_live_guc_g2g_kunit_allmem ========== [05:38:55] =================== [SKIPPED] xe_guc_g2g =================== [05:38:55] =================== xe_mocs (2 subtests) =================== [05:38:55] ================ xe_live_mocs_kernel_kunit ================ [05:38:55] =========== [SKIPPED] xe_live_mocs_kernel_kunit ============ [05:38:55] ================ xe_live_mocs_reset_kunit ================= [05:38:55] ============ [SKIPPED] xe_live_mocs_reset_kunit ============ [05:38:55] ==================== [SKIPPED] xe_mocs ===================== [05:38:55] ================= xe_migrate (2 subtests) ================== [05:38:55] ================= xe_migrate_sanity_kunit ================= [05:38:55] ============ [SKIPPED] xe_migrate_sanity_kunit ============= [05:38:55] ================== xe_validate_ccs_kunit ================== [05:38:55] ============= [SKIPPED] xe_validate_ccs_kunit ============== [05:38:55] =================== [SKIPPED] xe_migrate =================== [05:38:55] ================== xe_dma_buf (1 subtest) ================== [05:38:55] ==================== xe_dma_buf_kunit ===================== [05:38:55] ================ [SKIPPED] xe_dma_buf_kunit ================ [05:38:55] =================== [SKIPPED] xe_dma_buf =================== [05:38:55] ================= xe_bo_shrink (1 subtest) ================= [05:38:55] =================== xe_bo_shrink_kunit ==================== [05:38:55] =============== [SKIPPED] xe_bo_shrink_kunit =============== [05:38:55] ================== [SKIPPED] xe_bo_shrink ================== [05:38:55] ==================== xe_bo (2 subtests) ==================== [05:38:55] ================== xe_ccs_migrate_kunit =================== [05:38:55] ============== [SKIPPED] xe_ccs_migrate_kunit ============== [05:38:55] ==================== xe_bo_evict_kunit ==================== [05:38:55] =============== [SKIPPED] xe_bo_evict_kunit ================ [05:38:55] ===================== [SKIPPED] xe_bo ====================== [05:38:55] ==================== args (11 subtests) ==================== [05:38:55] [PASSED] count_args_test [05:38:55] [PASSED] call_args_example [05:38:55] [PASSED] call_args_test [05:38:55] [PASSED] drop_first_arg_example [05:38:55] [PASSED] drop_first_arg_test [05:38:55] [PASSED] first_arg_example [05:38:55] [PASSED] first_arg_test [05:38:55] [PASSED] last_arg_example [05:38:55] [PASSED] last_arg_test [05:38:55] [PASSED] pick_arg_example [05:38:55] [PASSED] sep_comma_example [05:38:55] ====================== [PASSED] args ======================= [05:38:55] =================== xe_pci (3 subtests) ==================== [05:38:55] ==================== check_graphics_ip ==================== [05:38:55] [PASSED] 12.00 Xe_LP [05:38:55] [PASSED] 12.10 Xe_LP+ [05:38:55] [PASSED] 12.55 Xe_HPG [05:38:55] [PASSED] 12.60 Xe_HPC [05:38:55] [PASSED] 12.70 Xe_LPG [05:38:55] [PASSED] 12.71 Xe_LPG [05:38:55] [PASSED] 12.74 Xe_LPG+ [05:38:55] [PASSED] 20.01 Xe2_HPG [05:38:55] [PASSED] 20.02 Xe2_HPG [05:38:55] [PASSED] 20.04 Xe2_LPG [05:38:55] [PASSED] 30.00 Xe3_LPG [05:38:55] [PASSED] 30.01 Xe3_LPG [05:38:55] [PASSED] 30.03 Xe3_LPG [05:38:55] [PASSED] 30.04 Xe3_LPG [05:38:55] [PASSED] 30.05 Xe3_LPG [05:38:55] [PASSED] 35.11 Xe3p_XPC [05:38:55] ================ [PASSED] check_graphics_ip ================ [05:38:55] ===================== check_media_ip ====================== [05:38:55] [PASSED] 12.00 Xe_M [05:38:55] [PASSED] 12.55 Xe_HPM [05:38:55] [PASSED] 13.00 Xe_LPM+ [05:38:55] [PASSED] 13.01 Xe2_HPM [05:38:55] [PASSED] 20.00 Xe2_LPM [05:38:55] [PASSED] 30.00 Xe3_LPM [05:38:55] [PASSED] 30.02 Xe3_LPM [05:38:55] [PASSED] 35.00 Xe3p_LPM [05:38:55] [PASSED] 35.03 Xe3p_HPM [05:38:55] ================= [PASSED] check_media_ip ================== [05:38:55] =================== check_platform_desc =================== [05:38:55] [PASSED] 0x9A60 (TIGERLAKE) [05:38:55] [PASSED] 0x9A68 (TIGERLAKE) [05:38:55] [PASSED] 0x9A70 (TIGERLAKE) [05:38:55] [PASSED] 0x9A40 (TIGERLAKE) [05:38:55] [PASSED] 0x9A49 (TIGERLAKE) [05:38:55] [PASSED] 0x9A59 (TIGERLAKE) [05:38:55] [PASSED] 0x9A78 (TIGERLAKE) [05:38:55] [PASSED] 0x9AC0 (TIGERLAKE) [05:38:55] [PASSED] 0x9AC9 (TIGERLAKE) [05:38:55] [PASSED] 0x9AD9 (TIGERLAKE) [05:38:55] [PASSED] 0x9AF8 (TIGERLAKE) [05:38:55] [PASSED] 0x4C80 (ROCKETLAKE) [05:38:55] [PASSED] 0x4C8A (ROCKETLAKE) [05:38:55] [PASSED] 0x4C8B (ROCKETLAKE) [05:38:55] [PASSED] 0x4C8C (ROCKETLAKE) [05:38:55] [PASSED] 0x4C90 (ROCKETLAKE) [05:38:55] [PASSED] 0x4C9A (ROCKETLAKE) [05:38:55] [PASSED] 0x4680 (ALDERLAKE_S) [05:38:55] [PASSED] 0x4682 (ALDERLAKE_S) [05:38:55] [PASSED] 0x4688 (ALDERLAKE_S) [05:38:55] [PASSED] 0x468A (ALDERLAKE_S) [05:38:55] [PASSED] 0x468B (ALDERLAKE_S) [05:38:55] [PASSED] 0x4690 (ALDERLAKE_S) [05:38:55] [PASSED] 0x4692 (ALDERLAKE_S) [05:38:55] [PASSED] 0x4693 (ALDERLAKE_S) [05:38:55] [PASSED] 0x46A0 (ALDERLAKE_P) [05:38:55] [PASSED] 0x46A1 (ALDERLAKE_P) [05:38:55] [PASSED] 0x46A2 (ALDERLAKE_P) [05:38:55] [PASSED] 0x46A3 (ALDERLAKE_P) [05:38:55] [PASSED] 0x46A6 (ALDERLAKE_P) [05:38:55] [PASSED] 0x46A8 (ALDERLAKE_P) [05:38:55] [PASSED] 0x46AA (ALDERLAKE_P) [05:38:55] [PASSED] 0x462A (ALDERLAKE_P) [05:38:55] [PASSED] 0x4626 (ALDERLAKE_P) [05:38:55] [PASSED] 0x4628 (ALDERLAKE_P) [05:38:55] [PASSED] 0x46B0 (ALDERLAKE_P) [05:38:55] [PASSED] 0x46B1 (ALDERLAKE_P) [05:38:55] [PASSED] 0x46B2 (ALDERLAKE_P) [05:38:55] [PASSED] 0x46B3 (ALDERLAKE_P) [05:38:55] [PASSED] 0x46C0 (ALDERLAKE_P) [05:38:55] [PASSED] 0x46C1 (ALDERLAKE_P) [05:38:55] [PASSED] 0x46C2 (ALDERLAKE_P) [05:38:55] [PASSED] 0x46C3 (ALDERLAKE_P) [05:38:55] [PASSED] 0x46D0 (ALDERLAKE_N) [05:38:55] [PASSED] 0x46D1 (ALDERLAKE_N) [05:38:55] [PASSED] 0x46D2 (ALDERLAKE_N) [05:38:55] [PASSED] 0x46D3 (ALDERLAKE_N) [05:38:55] [PASSED] 0x46D4 (ALDERLAKE_N) [05:38:55] [PASSED] 0xA721 (ALDERLAKE_P) [05:38:55] [PASSED] 0xA7A1 (ALDERLAKE_P) [05:38:55] [PASSED] 0xA7A9 (ALDERLAKE_P) [05:38:55] [PASSED] 0xA7AC (ALDERLAKE_P) [05:38:55] [PASSED] 0xA7AD (ALDERLAKE_P) [05:38:55] [PASSED] 0xA720 (ALDERLAKE_P) [05:38:55] [PASSED] 0xA7A0 (ALDERLAKE_P) [05:38:55] [PASSED] 0xA7A8 (ALDERLAKE_P) [05:38:55] [PASSED] 0xA7AA (ALDERLAKE_P) [05:38:55] [PASSED] 0xA7AB (ALDERLAKE_P) [05:38:55] [PASSED] 0xA780 (ALDERLAKE_S) [05:38:55] [PASSED] 0xA781 (ALDERLAKE_S) [05:38:55] [PASSED] 0xA782 (ALDERLAKE_S) [05:38:55] [PASSED] 0xA783 (ALDERLAKE_S) [05:38:55] [PASSED] 0xA788 (ALDERLAKE_S) [05:38:55] [PASSED] 0xA789 (ALDERLAKE_S) [05:38:55] [PASSED] 0xA78A (ALDERLAKE_S) [05:38:55] [PASSED] 0xA78B (ALDERLAKE_S) [05:38:55] [PASSED] 0x4905 (DG1) [05:38:55] [PASSED] 0x4906 (DG1) [05:38:55] [PASSED] 0x4907 (DG1) [05:38:55] [PASSED] 0x4908 (DG1) [05:38:55] [PASSED] 0x4909 (DG1) [05:38:55] [PASSED] 0x56C0 (DG2) [05:38:55] [PASSED] 0x56C2 (DG2) [05:38:55] [PASSED] 0x56C1 (DG2) [05:38:55] [PASSED] 0x7D51 (METEORLAKE) [05:38:55] [PASSED] 0x7DD1 (METEORLAKE) [05:38:55] [PASSED] 0x7D41 (METEORLAKE) [05:38:55] [PASSED] 0x7D67 (METEORLAKE) [05:38:55] [PASSED] 0xB640 (METEORLAKE) [05:38:55] [PASSED] 0x56A0 (DG2) [05:38:55] [PASSED] 0x56A1 (DG2) [05:38:55] [PASSED] 0x56A2 (DG2) [05:38:55] [PASSED] 0x56BE (DG2) [05:38:55] [PASSED] 0x56BF (DG2) [05:38:55] [PASSED] 0x5690 (DG2) [05:38:55] [PASSED] 0x5691 (DG2) [05:38:55] [PASSED] 0x5692 (DG2) [05:38:55] [PASSED] 0x56A5 (DG2) [05:38:55] [PASSED] 0x56A6 (DG2) [05:38:55] [PASSED] 0x56B0 (DG2) [05:38:55] [PASSED] 0x56B1 (DG2) [05:38:55] [PASSED] 0x56BA (DG2) [05:38:55] [PASSED] 0x56BB (DG2) [05:38:55] [PASSED] 0x56BC (DG2) [05:38:55] [PASSED] 0x56BD (DG2) [05:38:55] [PASSED] 0x5693 (DG2) [05:38:55] [PASSED] 0x5694 (DG2) [05:38:55] [PASSED] 0x5695 (DG2) [05:38:55] [PASSED] 0x56A3 (DG2) [05:38:55] [PASSED] 0x56A4 (DG2) [05:38:55] [PASSED] 0x56B2 (DG2) [05:38:55] [PASSED] 0x56B3 (DG2) [05:38:55] [PASSED] 0x5696 (DG2) [05:38:55] [PASSED] 0x5697 (DG2) [05:38:55] [PASSED] 0xB69 (PVC) [05:38:55] [PASSED] 0xB6E (PVC) [05:38:55] [PASSED] 0xBD4 (PVC) [05:38:55] [PASSED] 0xBD5 (PVC) [05:38:55] [PASSED] 0xBD6 (PVC) [05:38:55] [PASSED] 0xBD7 (PVC) [05:38:55] [PASSED] 0xBD8 (PVC) [05:38:55] [PASSED] 0xBD9 (PVC) [05:38:55] [PASSED] 0xBDA (PVC) [05:38:55] [PASSED] 0xBDB (PVC) [05:38:55] [PASSED] 0xBE0 (PVC) [05:38:55] [PASSED] 0xBE1 (PVC) [05:38:55] [PASSED] 0xBE5 (PVC) [05:38:55] [PASSED] 0x7D40 (METEORLAKE) [05:38:55] [PASSED] 0x7D45 (METEORLAKE) [05:38:55] [PASSED] 0x7D55 (METEORLAKE) [05:38:55] [PASSED] 0x7D60 (METEORLAKE) [05:38:55] [PASSED] 0x7DD5 (METEORLAKE) [05:38:55] [PASSED] 0x6420 (LUNARLAKE) [05:38:55] [PASSED] 0x64A0 (LUNARLAKE) [05:38:55] [PASSED] 0x64B0 (LUNARLAKE) [05:38:55] [PASSED] 0xE202 (BATTLEMAGE) [05:38:55] [PASSED] 0xE209 (BATTLEMAGE) [05:38:55] [PASSED] 0xE20B (BATTLEMAGE) [05:38:55] [PASSED] 0xE20C (BATTLEMAGE) [05:38:55] [PASSED] 0xE20D (BATTLEMAGE) [05:38:55] [PASSED] 0xE210 (BATTLEMAGE) [05:38:55] [PASSED] 0xE211 (BATTLEMAGE) [05:38:55] [PASSED] 0xE212 (BATTLEMAGE) [05:38:55] [PASSED] 0xE216 (BATTLEMAGE) [05:38:55] [PASSED] 0xE220 (BATTLEMAGE) [05:38:55] [PASSED] 0xE221 (BATTLEMAGE) [05:38:55] [PASSED] 0xE222 (BATTLEMAGE) [05:38:55] [PASSED] 0xE223 (BATTLEMAGE) [05:38:55] [PASSED] 0xB080 (PANTHERLAKE) [05:38:55] [PASSED] 0xB081 (PANTHERLAKE) [05:38:55] [PASSED] 0xB082 (PANTHERLAKE) [05:38:55] [PASSED] 0xB083 (PANTHERLAKE) [05:38:55] [PASSED] 0xB084 (PANTHERLAKE) [05:38:55] [PASSED] 0xB085 (PANTHERLAKE) [05:38:55] [PASSED] 0xB086 (PANTHERLAKE) [05:38:55] [PASSED] 0xB087 (PANTHERLAKE) [05:38:55] [PASSED] 0xB08F (PANTHERLAKE) [05:38:55] [PASSED] 0xB090 (PANTHERLAKE) [05:38:55] [PASSED] 0xB0A0 (PANTHERLAKE) [05:38:55] [PASSED] 0xB0B0 (PANTHERLAKE) [05:38:55] [PASSED] 0xD740 (NOVALAKE_S) [05:38:55] [PASSED] 0xD741 (NOVALAKE_S) [05:38:55] [PASSED] 0xD742 (NOVALAKE_S) [05:38:55] [PASSED] 0xD743 (NOVALAKE_S) [05:38:55] [PASSED] 0xD744 (NOVALAKE_S) [05:38:55] [PASSED] 0xD745 (NOVALAKE_S) [05:38:55] [PASSED] 0x674C (CRESCENTISLAND) [05:38:55] [PASSED] 0xFD80 (PANTHERLAKE) [05:38:55] [PASSED] 0xFD81 (PANTHERLAKE) [05:38:55] =============== [PASSED] check_platform_desc =============== [05:38:55] ===================== [PASSED] xe_pci ====================== [05:38:55] =================== xe_rtp (2 subtests) ==================== [05:38:55] =============== xe_rtp_process_to_sr_tests ================ [05:38:55] [PASSED] coalesce-same-reg [05:38:55] [PASSED] no-match-no-add [05:38:55] [PASSED] match-or [05:38:55] [PASSED] match-or-xfail [05:38:55] [PASSED] no-match-no-add-multiple-rules [05:38:55] [PASSED] two-regs-two-entries [05:38:55] [PASSED] clr-one-set-other [05:38:55] [PASSED] set-field [05:38:55] [PASSED] conflict-duplicate [05:38:55] [PASSED] conflict-not-disjoint [05:38:55] [PASSED] conflict-reg-type [05:38:55] =========== [PASSED] xe_rtp_process_to_sr_tests ============ [05:38:55] ================== xe_rtp_process_tests =================== [05:38:55] [PASSED] active1 [05:38:55] [PASSED] active2 [05:38:55] [PASSED] active-inactive [05:38:55] [PASSED] inactive-active [05:38:55] [PASSED] inactive-1st_or_active-inactive [05:38:55] [PASSED] inactive-2nd_or_active-inactive [05:38:55] [PASSED] inactive-last_or_active-inactive stty: 'standard input': Inappropriate ioctl for device [05:38:55] [PASSED] inactive-no_or_active-inactive [05:38:55] ============== [PASSED] xe_rtp_process_tests =============== [05:38:55] ===================== [PASSED] xe_rtp ====================== [05:38:55] ==================== xe_wa (1 subtest) ===================== [05:38:55] ======================== xe_wa_gt ========================= [05:38:55] [PASSED] TIGERLAKE B0 [05:38:55] [PASSED] DG1 A0 [05:38:55] [PASSED] DG1 B0 [05:38:55] [PASSED] ALDERLAKE_S A0 [05:38:55] [PASSED] ALDERLAKE_S B0 [05:38:55] [PASSED] ALDERLAKE_S C0 [05:38:55] [PASSED] ALDERLAKE_S D0 [05:38:55] [PASSED] ALDERLAKE_P A0 [05:38:55] [PASSED] ALDERLAKE_P B0 [05:38:55] [PASSED] ALDERLAKE_P C0 [05:38:55] [PASSED] ALDERLAKE_S RPLS D0 [05:38:55] [PASSED] ALDERLAKE_P RPLU E0 [05:38:55] [PASSED] DG2 G10 C0 [05:38:55] [PASSED] DG2 G11 B1 [05:38:55] [PASSED] DG2 G12 A1 [05:38:55] [PASSED] METEORLAKE 12.70(Xe_LPG) A0 13.00(Xe_LPM+) A0 [05:38:55] [PASSED] METEORLAKE 12.71(Xe_LPG) A0 13.00(Xe_LPM+) A0 [05:38:55] [PASSED] METEORLAKE 12.74(Xe_LPG+) A0 13.00(Xe_LPM+) A0 [05:38:55] [PASSED] LUNARLAKE 20.04(Xe2_LPG) A0 20.00(Xe2_LPM) A0 [05:38:55] [PASSED] LUNARLAKE 20.04(Xe2_LPG) B0 20.00(Xe2_LPM) A0 [05:38:55] [PASSED] BATTLEMAGE 20.01(Xe2_HPG) A0 13.01(Xe2_HPM) A1 [05:38:55] [PASSED] PANTHERLAKE 30.00(Xe3_LPG) A0 30.00(Xe3_LPM) A0 [05:38:55] ==================== [PASSED] xe_wa_gt ===================== [05:38:55] ====================== [PASSED] xe_wa ====================== [05:38:55] ============================================================ [05:38:55] Testing complete. Ran 318 tests: passed: 300, skipped: 18 [05:38:55] Elapsed time: 34.998s total, 4.282s configuring, 30.350s building, 0.345s running
+ /kernel/tools/testing/kunit/kunit.py run --kunitconfig /kernel/drivers/gpu/drm/tests/.kunitconfig [05:38:55] Configuring KUnit Kernel ...
Regenerating .config ...
Populating config with:
$ make ARCH=um O=.kunit olddefconfig [05:38:57] Building KUnit Kernel ... Populating config with: $ make ARCH=um O=.kunit olddefconfig Building with: $ make all compile_commands.json scripts_gdb ARCH=um O=.kunit --jobs=48 [05:39:21] Starting KUnit Kernel (1/1)... [05:39:21] ============================================================ Running tests with: $ .kunit/linux kunit.enable=1 mem=1G console=tty kunit_shutdown=halt [05:39:22] ============ drm_test_pick_cmdline (2 subtests) ============ [05:39:22] [PASSED] drm_test_pick_cmdline_res_1920_1080_60 [05:39:22] =============== drm_test_pick_cmdline_named =============== [05:39:22] [PASSED] NTSC [05:39:22] [PASSED] NTSC-J [05:39:22] [PASSED] PAL [05:39:22] [PASSED] PAL-M [05:39:22] =========== [PASSED] drm_test_pick_cmdline_named =========== [05:39:22] ============== [PASSED] drm_test_pick_cmdline ============== [05:39:22] == drm_test_atomic_get_connector_for_encoder (1 subtest) === [05:39:22] [PASSED] drm_test_drm_atomic_get_connector_for_encoder [05:39:22] ==== [PASSED] drm_test_atomic_get_connector_for_encoder ==== [05:39:22] =========== drm_validate_clone_mode (2 subtests) =========== [05:39:22] ============== drm_test_check_in_clone_mode =============== [05:39:22] [PASSED] in_clone_mode [05:39:22] [PASSED] not_in_clone_mode [05:39:22] ========== [PASSED] drm_test_check_in_clone_mode =========== [05:39:22] =============== drm_test_check_valid_clones =============== [05:39:22] [PASSED] not_in_clone_mode [05:39:22] [PASSED] valid_clone [05:39:22] [PASSED] invalid_clone [05:39:22] =========== [PASSED] drm_test_check_valid_clones =========== [05:39:22] ============= [PASSED] drm_validate_clone_mode ============= [05:39:22] ============= drm_validate_modeset (1 subtest) ============= [05:39:22] [PASSED] drm_test_check_connector_changed_modeset [05:39:22] ============== [PASSED] drm_validate_modeset =============== [05:39:22] ====== drm_test_bridge_get_current_state (2 subtests) ====== [05:39:22] [PASSED] drm_test_drm_bridge_get_current_state_atomic [05:39:22] [PASSED] drm_test_drm_bridge_get_current_state_legacy [05:39:22] ======== [PASSED] drm_test_bridge_get_current_state ======== [05:39:22] ====== drm_test_bridge_helper_reset_crtc (3 subtests) ====== [05:39:22] [PASSED] drm_test_drm_bridge_helper_reset_crtc_atomic [05:39:22] [PASSED] drm_test_drm_bridge_helper_reset_crtc_atomic_disabled [05:39:22] [PASSED] drm_test_drm_bridge_helper_reset_crtc_legacy [05:39:22] ======== [PASSED] drm_test_bridge_helper_reset_crtc ======== [05:39:22] ============== drm_bridge_alloc (2 subtests) =============== [05:39:22] [PASSED] drm_test_drm_bridge_alloc_basic [05:39:22] [PASSED] drm_test_drm_bridge_alloc_get_put [05:39:22] ================ [PASSED] drm_bridge_alloc ================= [05:39:22] ================== drm_buddy (8 subtests) ================== [05:39:22] [PASSED] drm_test_buddy_alloc_limit [05:39:22] [PASSED] drm_test_buddy_alloc_optimistic [05:39:22] [PASSED] drm_test_buddy_alloc_pessimistic [05:39:22] [PASSED] drm_test_buddy_alloc_pathological [05:39:22] [PASSED] drm_test_buddy_alloc_contiguous [05:39:22] [PASSED] drm_test_buddy_alloc_clear [05:39:22] [PASSED] drm_test_buddy_alloc_range_bias [05:39:22] [PASSED] drm_test_buddy_fragmentation_performance [05:39:22] ==================== [PASSED] drm_buddy ==================== [05:39:22] ============= drm_cmdline_parser (40 subtests) ============= [05:39:22] [PASSED] drm_test_cmdline_force_d_only [05:39:22] [PASSED] drm_test_cmdline_force_D_only_dvi [05:39:22] [PASSED] drm_test_cmdline_force_D_only_hdmi [05:39:22] [PASSED] drm_test_cmdline_force_D_only_not_digital [05:39:22] [PASSED] drm_test_cmdline_force_e_only [05:39:22] [PASSED] drm_test_cmdline_res [05:39:22] [PASSED] drm_test_cmdline_res_vesa [05:39:22] [PASSED] drm_test_cmdline_res_vesa_rblank [05:39:22] [PASSED] drm_test_cmdline_res_rblank [05:39:22] [PASSED] drm_test_cmdline_res_bpp [05:39:22] [PASSED] drm_test_cmdline_res_refresh [05:39:22] [PASSED] drm_test_cmdline_res_bpp_refresh [05:39:22] [PASSED] drm_test_cmdline_res_bpp_refresh_interlaced [05:39:22] [PASSED] drm_test_cmdline_res_bpp_refresh_margins [05:39:22] [PASSED] drm_test_cmdline_res_bpp_refresh_force_off [05:39:22] [PASSED] drm_test_cmdline_res_bpp_refresh_force_on [05:39:22] [PASSED] drm_test_cmdline_res_bpp_refresh_force_on_analog [05:39:22] [PASSED] drm_test_cmdline_res_bpp_refresh_force_on_digital [05:39:22] [PASSED] drm_test_cmdline_res_bpp_refresh_interlaced_margins_force_on [05:39:22] [PASSED] drm_test_cmdline_res_margins_force_on [05:39:22] [PASSED] drm_test_cmdline_res_vesa_margins [05:39:22] [PASSED] drm_test_cmdline_name [05:39:22] [PASSED] drm_test_cmdline_name_bpp [05:39:22] [PASSED] drm_test_cmdline_name_option [05:39:22] [PASSED] drm_test_cmdline_name_bpp_option [05:39:22] [PASSED] drm_test_cmdline_rotate_0 [05:39:22] [PASSED] drm_test_cmdline_rotate_90 [05:39:22] [PASSED] drm_test_cmdline_rotate_180 [05:39:22] [PASSED] drm_test_cmdline_rotate_270 [05:39:22] [PASSED] drm_test_cmdline_hmirror [05:39:22] [PASSED] drm_test_cmdline_vmirror [05:39:22] [PASSED] drm_test_cmdline_margin_options [05:39:22] [PASSED] drm_test_cmdline_multiple_options [05:39:22] [PASSED] drm_test_cmdline_bpp_extra_and_option [05:39:22] [PASSED] drm_test_cmdline_extra_and_option [05:39:22] [PASSED] drm_test_cmdline_freestanding_options [05:39:22] [PASSED] drm_test_cmdline_freestanding_force_e_and_options [05:39:22] [PASSED] drm_test_cmdline_panel_orientation [05:39:22] ================ drm_test_cmdline_invalid ================= [05:39:22] [PASSED] margin_only [05:39:22] [PASSED] interlace_only [05:39:22] [PASSED] res_missing_x [05:39:22] [PASSED] res_missing_y [05:39:22] [PASSED] res_bad_y [05:39:22] [PASSED] res_missing_y_bpp [05:39:22] [PASSED] res_bad_bpp [05:39:22] [PASSED] res_bad_refresh [05:39:22] [PASSED] res_bpp_refresh_force_on_off [05:39:22] [PASSED] res_invalid_mode [05:39:22] [PASSED] res_bpp_wrong_place_mode [05:39:22] [PASSED] name_bpp_refresh [05:39:22] [PASSED] name_refresh [05:39:22] [PASSED] name_refresh_wrong_mode [05:39:22] [PASSED] name_refresh_invalid_mode [05:39:22] [PASSED] rotate_multiple [05:39:22] [PASSED] rotate_invalid_val [05:39:22] [PASSED] rotate_truncated [05:39:22] [PASSED] invalid_option [05:39:22] [PASSED] invalid_tv_option [05:39:22] [PASSED] truncated_tv_option [05:39:22] ============ [PASSED] drm_test_cmdline_invalid ============= [05:39:22] =============== drm_test_cmdline_tv_options =============== [05:39:22] [PASSED] NTSC [05:39:22] [PASSED] NTSC_443 [05:39:22] [PASSED] NTSC_J [05:39:22] [PASSED] PAL [05:39:22] [PASSED] PAL_M [05:39:22] [PASSED] PAL_N [05:39:22] [PASSED] SECAM [05:39:22] [PASSED] MONO_525 [05:39:22] [PASSED] MONO_625 [05:39:22] =========== [PASSED] drm_test_cmdline_tv_options =========== [05:39:22] =============== [PASSED] drm_cmdline_parser ================ [05:39:22] ========== drmm_connector_hdmi_init (20 subtests) ========== [05:39:22] [PASSED] drm_test_connector_hdmi_init_valid [05:39:22] [PASSED] drm_test_connector_hdmi_init_bpc_8 [05:39:22] [PASSED] drm_test_connector_hdmi_init_bpc_10 [05:39:22] [PASSED] drm_test_connector_hdmi_init_bpc_12 [05:39:22] [PASSED] drm_test_connector_hdmi_init_bpc_invalid [05:39:22] [PASSED] drm_test_connector_hdmi_init_bpc_null [05:39:22] [PASSED] drm_test_connector_hdmi_init_formats_empty [05:39:22] [PASSED] drm_test_connector_hdmi_init_formats_no_rgb [05:39:22] === drm_test_connector_hdmi_init_formats_yuv420_allowed === [05:39:22] [PASSED] supported_formats=0x9 yuv420_allowed=1 [05:39:22] [PASSED] supported_formats=0x9 yuv420_allowed=0 [05:39:22] [PASSED] supported_formats=0x3 yuv420_allowed=1 [05:39:22] [PASSED] supported_formats=0x3 yuv420_allowed=0 [05:39:22] === [PASSED] drm_test_connector_hdmi_init_formats_yuv420_allowed === [05:39:22] [PASSED] drm_test_connector_hdmi_init_null_ddc [05:39:22] [PASSED] drm_test_connector_hdmi_init_null_product [05:39:22] [PASSED] drm_test_connector_hdmi_init_null_vendor [05:39:22] [PASSED] drm_test_connector_hdmi_init_product_length_exact [05:39:22] [PASSED] drm_test_connector_hdmi_init_product_length_too_long [05:39:22] [PASSED] drm_test_connector_hdmi_init_product_valid [05:39:22] [PASSED] drm_test_connector_hdmi_init_vendor_length_exact [05:39:22] [PASSED] drm_test_connector_hdmi_init_vendor_length_too_long [05:39:22] [PASSED] drm_test_connector_hdmi_init_vendor_valid [05:39:22] ========= drm_test_connector_hdmi_init_type_valid ========= [05:39:22] [PASSED] HDMI-A [05:39:22] [PASSED] HDMI-B [05:39:22] ===== [PASSED] drm_test_connector_hdmi_init_type_valid ===== [05:39:22] ======== drm_test_connector_hdmi_init_type_invalid ======== [05:39:22] [PASSED] Unknown [05:39:22] [PASSED] VGA [05:39:22] [PASSED] DVI-I [05:39:22] [PASSED] DVI-D [05:39:22] [PASSED] DVI-A [05:39:22] [PASSED] Composite [05:39:22] [PASSED] SVIDEO [05:39:22] [PASSED] LVDS [05:39:22] [PASSED] Component [05:39:22] [PASSED] DIN [05:39:22] [PASSED] DP [05:39:22] [PASSED] TV [05:39:22] [PASSED] eDP [05:39:22] [PASSED] Virtual [05:39:22] [PASSED] DSI [05:39:22] [PASSED] DPI [05:39:22] [PASSED] Writeback [05:39:22] [PASSED] SPI [05:39:22] [PASSED] USB [05:39:22] ==== [PASSED] drm_test_connector_hdmi_init_type_invalid ==== [05:39:22] ============ [PASSED] drmm_connector_hdmi_init ============= [05:39:22] ============= drmm_connector_init (3 subtests) ============= [05:39:22] [PASSED] drm_test_drmm_connector_init [05:39:22] [PASSED] drm_test_drmm_connector_init_null_ddc [05:39:22] ========= drm_test_drmm_connector_init_type_valid ========= [05:39:22] [PASSED] Unknown [05:39:22] [PASSED] VGA [05:39:22] [PASSED] DVI-I [05:39:22] [PASSED] DVI-D [05:39:22] [PASSED] DVI-A [05:39:22] [PASSED] Composite [05:39:22] [PASSED] SVIDEO [05:39:22] [PASSED] LVDS [05:39:22] [PASSED] Component [05:39:22] [PASSED] DIN [05:39:22] [PASSED] DP [05:39:22] [PASSED] HDMI-A [05:39:22] [PASSED] HDMI-B [05:39:22] [PASSED] TV [05:39:22] [PASSED] eDP [05:39:22] [PASSED] Virtual [05:39:22] [PASSED] DSI [05:39:22] [PASSED] DPI [05:39:22] [PASSED] Writeback [05:39:22] [PASSED] SPI [05:39:22] [PASSED] USB [05:39:22] ===== [PASSED] drm_test_drmm_connector_init_type_valid ===== [05:39:22] =============== [PASSED] drmm_connector_init =============== [05:39:22] ========= drm_connector_dynamic_init (6 subtests) ========== [05:39:22] [PASSED] drm_test_drm_connector_dynamic_init [05:39:22] [PASSED] drm_test_drm_connector_dynamic_init_null_ddc [05:39:22] [PASSED] drm_test_drm_connector_dynamic_init_not_added [05:39:22] [PASSED] drm_test_drm_connector_dynamic_init_properties [05:39:22] ===== drm_test_drm_connector_dynamic_init_type_valid ====== [05:39:22] [PASSED] Unknown [05:39:22] [PASSED] VGA [05:39:22] [PASSED] DVI-I [05:39:22] [PASSED] DVI-D [05:39:22] [PASSED] DVI-A [05:39:22] [PASSED] Composite [05:39:22] [PASSED] SVIDEO [05:39:22] [PASSED] LVDS [05:39:22] [PASSED] Component [05:39:22] [PASSED] DIN [05:39:22] [PASSED] DP [05:39:22] [PASSED] HDMI-A [05:39:22] [PASSED] HDMI-B [05:39:22] [PASSED] TV [05:39:22] [PASSED] eDP [05:39:22] [PASSED] Virtual [05:39:22] [PASSED] DSI [05:39:22] [PASSED] DPI [05:39:22] [PASSED] Writeback [05:39:22] [PASSED] SPI [05:39:22] [PASSED] USB [05:39:22] = [PASSED] drm_test_drm_connector_dynamic_init_type_valid == [05:39:22] ======== drm_test_drm_connector_dynamic_init_name ========= [05:39:22] [PASSED] Unknown [05:39:22] [PASSED] VGA [05:39:22] [PASSED] DVI-I [05:39:22] [PASSED] DVI-D [05:39:22] [PASSED] DVI-A [05:39:22] [PASSED] Composite [05:39:22] [PASSED] SVIDEO [05:39:22] [PASSED] LVDS [05:39:22] [PASSED] Component [05:39:22] [PASSED] DIN [05:39:22] [PASSED] DP [05:39:22] [PASSED] HDMI-A [05:39:22] [PASSED] HDMI-B [05:39:22] [PASSED] TV [05:39:22] [PASSED] eDP [05:39:22] [PASSED] Virtual [05:39:22] [PASSED] DSI [05:39:22] [PASSED] DPI [05:39:22] [PASSED] Writeback [05:39:22] [PASSED] SPI [05:39:22] [PASSED] USB [05:39:22] ==== [PASSED] drm_test_drm_connector_dynamic_init_name ===== [05:39:22] =========== [PASSED] drm_connector_dynamic_init ============ [05:39:22] ==== drm_connector_dynamic_register_early (4 subtests) ===== [05:39:22] [PASSED] drm_test_drm_connector_dynamic_register_early_on_list [05:39:22] [PASSED] drm_test_drm_connector_dynamic_register_early_defer [05:39:22] [PASSED] drm_test_drm_connector_dynamic_register_early_no_init [05:39:22] [PASSED] drm_test_drm_connector_dynamic_register_early_no_mode_object [05:39:22] ====== [PASSED] drm_connector_dynamic_register_early ======= [05:39:22] ======= drm_connector_dynamic_register (7 subtests) ======== [05:39:22] [PASSED] drm_test_drm_connector_dynamic_register_on_list [05:39:22] [PASSED] drm_test_drm_connector_dynamic_register_no_defer [05:39:22] [PASSED] drm_test_drm_connector_dynamic_register_no_init [05:39:22] [PASSED] drm_test_drm_connector_dynamic_register_mode_object [05:39:22] [PASSED] drm_test_drm_connector_dynamic_register_sysfs [05:39:22] [PASSED] drm_test_drm_connector_dynamic_register_sysfs_name [05:39:22] [PASSED] drm_test_drm_connector_dynamic_register_debugfs [05:39:22] ========= [PASSED] drm_connector_dynamic_register ========== [05:39:22] = drm_connector_attach_broadcast_rgb_property (2 subtests) = [05:39:22] [PASSED] drm_test_drm_connector_attach_broadcast_rgb_property [05:39:22] [PASSED] drm_test_drm_connector_attach_broadcast_rgb_property_hdmi_connector [05:39:22] === [PASSED] drm_connector_attach_broadcast_rgb_property === [05:39:22] ========== drm_get_tv_mode_from_name (2 subtests) ========== [05:39:22] ========== drm_test_get_tv_mode_from_name_valid =========== [05:39:22] [PASSED] NTSC [05:39:22] [PASSED] NTSC-443 [05:39:22] [PASSED] NTSC-J [05:39:22] [PASSED] PAL [05:39:22] [PASSED] PAL-M [05:39:22] [PASSED] PAL-N [05:39:22] [PASSED] SECAM [05:39:22] [PASSED] Mono [05:39:22] ====== [PASSED] drm_test_get_tv_mode_from_name_valid ======= [05:39:22] [PASSED] drm_test_get_tv_mode_from_name_truncated [05:39:22] ============ [PASSED] drm_get_tv_mode_from_name ============ [05:39:22] = drm_test_connector_hdmi_compute_mode_clock (12 subtests) = [05:39:22] [PASSED] drm_test_drm_hdmi_compute_mode_clock_rgb [05:39:22] [PASSED] drm_test_drm_hdmi_compute_mode_clock_rgb_10bpc [05:39:22] [PASSED] drm_test_drm_hdmi_compute_mode_clock_rgb_10bpc_vic_1 [05:39:22] [PASSED] drm_test_drm_hdmi_compute_mode_clock_rgb_12bpc [05:39:22] [PASSED] drm_test_drm_hdmi_compute_mode_clock_rgb_12bpc_vic_1 [05:39:22] [PASSED] drm_test_drm_hdmi_compute_mode_clock_rgb_double [05:39:22] = drm_test_connector_hdmi_compute_mode_clock_yuv420_valid = [05:39:22] [PASSED] VIC 96 [05:39:22] [PASSED] VIC 97 [05:39:22] [PASSED] VIC 101 [05:39:22] [PASSED] VIC 102 [05:39:22] [PASSED] VIC 106 [05:39:22] [PASSED] VIC 107 [05:39:22] === [PASSED] drm_test_connector_hdmi_compute_mode_clock_yuv420_valid === [05:39:22] [PASSED] drm_test_connector_hdmi_compute_mode_clock_yuv420_10_bpc [05:39:22] [PASSED] drm_test_connector_hdmi_compute_mode_clock_yuv420_12_bpc [05:39:22] [PASSED] drm_test_connector_hdmi_compute_mode_clock_yuv422_8_bpc [05:39:22] [PASSED] drm_test_connector_hdmi_compute_mode_clock_yuv422_10_bpc [05:39:22] [PASSED] drm_test_connector_hdmi_compute_mode_clock_yuv422_12_bpc [05:39:22] === [PASSED] drm_test_connector_hdmi_compute_mode_clock ==== [05:39:22] == drm_hdmi_connector_get_broadcast_rgb_name (2 subtests) == [05:39:22] === drm_test_drm_hdmi_connector_get_broadcast_rgb_name ==== [05:39:22] [PASSED] Automatic [05:39:22] [PASSED] Full [05:39:22] [PASSED] Limited 16:235 [05:39:22] === [PASSED] drm_test_drm_hdmi_connector_get_broadcast_rgb_name === [05:39:22] [PASSED] drm_test_drm_hdmi_connector_get_broadcast_rgb_name_invalid [05:39:22] ==== [PASSED] drm_hdmi_connector_get_broadcast_rgb_name ==== [05:39:22] == drm_hdmi_connector_get_output_format_name (2 subtests) == [05:39:22] === drm_test_drm_hdmi_connector_get_output_format_name ==== [05:39:22] [PASSED] RGB [05:39:22] [PASSED] YUV 4:2:0 [05:39:22] [PASSED] YUV 4:2:2 [05:39:22] [PASSED] YUV 4:4:4 [05:39:22] === [PASSED] drm_test_drm_hdmi_connector_get_output_format_name === [05:39:22] [PASSED] drm_test_drm_hdmi_connector_get_output_format_name_invalid [05:39:22] ==== [PASSED] drm_hdmi_connector_get_output_format_name ==== [05:39:22] ============= drm_damage_helper (21 subtests) ============== [05:39:22] [PASSED] drm_test_damage_iter_no_damage [05:39:22] [PASSED] drm_test_damage_iter_no_damage_fractional_src [05:39:22] [PASSED] drm_test_damage_iter_no_damage_src_moved [05:39:22] [PASSED] drm_test_damage_iter_no_damage_fractional_src_moved [05:39:22] [PASSED] drm_test_damage_iter_no_damage_not_visible [05:39:22] [PASSED] drm_test_damage_iter_no_damage_no_crtc [05:39:22] [PASSED] drm_test_damage_iter_no_damage_no_fb [05:39:22] [PASSED] drm_test_damage_iter_simple_damage [05:39:22] [PASSED] drm_test_damage_iter_single_damage [05:39:22] [PASSED] drm_test_damage_iter_single_damage_intersect_src [05:39:22] [PASSED] drm_test_damage_iter_single_damage_outside_src [05:39:22] [PASSED] drm_test_damage_iter_single_damage_fractional_src [05:39:22] [PASSED] drm_test_damage_iter_single_damage_intersect_fractional_src [05:39:22] [PASSED] drm_test_damage_iter_single_damage_outside_fractional_src [05:39:22] [PASSED] drm_test_damage_iter_single_damage_src_moved [05:39:22] [PASSED] drm_test_damage_iter_single_damage_fractional_src_moved [05:39:22] [PASSED] drm_test_damage_iter_damage [05:39:22] [PASSED] drm_test_damage_iter_damage_one_intersect [05:39:22] [PASSED] drm_test_damage_iter_damage_one_outside [05:39:22] [PASSED] drm_test_damage_iter_damage_src_moved [05:39:22] [PASSED] drm_test_damage_iter_damage_not_visible [05:39:22] ================ [PASSED] drm_damage_helper ================ [05:39:22] ============== drm_dp_mst_helper (3 subtests) ============== [05:39:22] ============== drm_test_dp_mst_calc_pbn_mode ============== [05:39:22] [PASSED] Clock 154000 BPP 30 DSC disabled [05:39:22] [PASSED] Clock 234000 BPP 30 DSC disabled [05:39:22] [PASSED] Clock 297000 BPP 24 DSC disabled [05:39:22] [PASSED] Clock 332880 BPP 24 DSC enabled [05:39:22] [PASSED] Clock 324540 BPP 24 DSC enabled [05:39:22] ========== [PASSED] drm_test_dp_mst_calc_pbn_mode ========== [05:39:22] ============== drm_test_dp_mst_calc_pbn_div =============== [05:39:22] [PASSED] Link rate 2000000 lane count 4 [05:39:22] [PASSED] Link rate 2000000 lane count 2 [05:39:22] [PASSED] Link rate 2000000 lane count 1 [05:39:22] [PASSED] Link rate 1350000 lane count 4 [05:39:22] [PASSED] Link rate 1350000 lane count 2 [05:39:22] [PASSED] Link rate 1350000 lane count 1 [05:39:22] [PASSED] Link rate 1000000 lane count 4 [05:39:22] [PASSED] Link rate 1000000 lane count 2 [05:39:22] [PASSED] Link rate 1000000 lane count 1 [05:39:22] [PASSED] Link rate 810000 lane count 4 [05:39:22] [PASSED] Link rate 810000 lane count 2 [05:39:22] [PASSED] Link rate 810000 lane count 1 [05:39:22] [PASSED] Link rate 540000 lane count 4 [05:39:22] [PASSED] Link rate 540000 lane count 2 [05:39:22] [PASSED] Link rate 540000 lane count 1 [05:39:22] [PASSED] Link rate 270000 lane count 4 [05:39:22] [PASSED] Link rate 270000 lane count 2 [05:39:22] [PASSED] Link rate 270000 lane count 1 [05:39:22] [PASSED] Link rate 162000 lane count 4 [05:39:22] [PASSED] Link rate 162000 lane count 2 [05:39:22] [PASSED] Link rate 162000 lane count 1 [05:39:22] ========== [PASSED] drm_test_dp_mst_calc_pbn_div =========== [05:39:22] ========= drm_test_dp_mst_sideband_msg_req_decode ========= [05:39:22] [PASSED] DP_ENUM_PATH_RESOURCES with port number [05:39:22] [PASSED] DP_POWER_UP_PHY with port number [05:39:22] [PASSED] DP_POWER_DOWN_PHY with port number [05:39:22] [PASSED] DP_ALLOCATE_PAYLOAD with SDP stream sinks [05:39:22] [PASSED] DP_ALLOCATE_PAYLOAD with port number [05:39:22] [PASSED] DP_ALLOCATE_PAYLOAD with VCPI [05:39:22] [PASSED] DP_ALLOCATE_PAYLOAD with PBN [05:39:22] [PASSED] DP_QUERY_PAYLOAD with port number [05:39:22] [PASSED] DP_QUERY_PAYLOAD with VCPI [05:39:22] [PASSED] DP_REMOTE_DPCD_READ with port number [05:39:22] [PASSED] DP_REMOTE_DPCD_READ with DPCD address [05:39:22] [PASSED] DP_REMOTE_DPCD_READ with max number of bytes [05:39:22] [PASSED] DP_REMOTE_DPCD_WRITE with port number [05:39:22] [PASSED] DP_REMOTE_DPCD_WRITE with DPCD address [05:39:22] [PASSED] DP_REMOTE_DPCD_WRITE with data array [05:39:22] [PASSED] DP_REMOTE_I2C_READ with port number [05:39:22] [PASSED] DP_REMOTE_I2C_READ with I2C device ID [05:39:22] [PASSED] DP_REMOTE_I2C_READ with transactions array [05:39:22] [PASSED] DP_REMOTE_I2C_WRITE with port number [05:39:22] [PASSED] DP_REMOTE_I2C_WRITE with I2C device ID [05:39:22] [PASSED] DP_REMOTE_I2C_WRITE with data array [05:39:22] [PASSED] DP_QUERY_STREAM_ENC_STATUS with stream ID [05:39:22] [PASSED] DP_QUERY_STREAM_ENC_STATUS with client ID [05:39:22] [PASSED] DP_QUERY_STREAM_ENC_STATUS with stream event [05:39:22] [PASSED] DP_QUERY_STREAM_ENC_STATUS with valid stream event [05:39:22] [PASSED] DP_QUERY_STREAM_ENC_STATUS with stream behavior [05:39:22] [PASSED] DP_QUERY_STREAM_ENC_STATUS with a valid stream behavior [05:39:22] ===== [PASSED] drm_test_dp_mst_sideband_msg_req_decode ===== [05:39:22] ================ [PASSED] drm_dp_mst_helper ================ [05:39:22] ================== drm_exec (7 subtests) =================== [05:39:22] [PASSED] sanitycheck [05:39:22] [PASSED] test_lock [05:39:22] [PASSED] test_lock_unlock [05:39:22] [PASSED] test_duplicates [05:39:22] [PASSED] test_prepare [05:39:22] [PASSED] test_prepare_array [05:39:22] [PASSED] test_multiple_loops [05:39:22] ==================== [PASSED] drm_exec ===================== [05:39:22] =========== drm_format_helper_test (17 subtests) =========== [05:39:22] ============== drm_test_fb_xrgb8888_to_gray8 ============== [05:39:22] [PASSED] single_pixel_source_buffer [05:39:22] [PASSED] single_pixel_clip_rectangle [05:39:22] [PASSED] well_known_colors [05:39:22] [PASSED] destination_pitch [05:39:22] ========== [PASSED] drm_test_fb_xrgb8888_to_gray8 ========== [05:39:22] ============= drm_test_fb_xrgb8888_to_rgb332 ============== [05:39:22] [PASSED] single_pixel_source_buffer [05:39:22] [PASSED] single_pixel_clip_rectangle [05:39:22] [PASSED] well_known_colors [05:39:22] [PASSED] destination_pitch [05:39:22] ========= [PASSED] drm_test_fb_xrgb8888_to_rgb332 ========== [05:39:22] ============= drm_test_fb_xrgb8888_to_rgb565 ============== [05:39:22] [PASSED] single_pixel_source_buffer [05:39:22] [PASSED] single_pixel_clip_rectangle [05:39:22] [PASSED] well_known_colors [05:39:22] [PASSED] destination_pitch [05:39:22] ========= [PASSED] drm_test_fb_xrgb8888_to_rgb565 ========== [05:39:22] ============ drm_test_fb_xrgb8888_to_xrgb1555 ============= [05:39:22] [PASSED] single_pixel_source_buffer [05:39:22] [PASSED] single_pixel_clip_rectangle [05:39:22] [PASSED] well_known_colors [05:39:22] [PASSED] destination_pitch [05:39:22] ======== [PASSED] drm_test_fb_xrgb8888_to_xrgb1555 ========= [05:39:22] ============ drm_test_fb_xrgb8888_to_argb1555 ============= [05:39:22] [PASSED] single_pixel_source_buffer [05:39:22] [PASSED] single_pixel_clip_rectangle [05:39:22] [PASSED] well_known_colors [05:39:22] [PASSED] destination_pitch [05:39:22] ======== [PASSED] drm_test_fb_xrgb8888_to_argb1555 ========= [05:39:22] ============ drm_test_fb_xrgb8888_to_rgba5551 ============= [05:39:22] [PASSED] single_pixel_source_buffer [05:39:22] [PASSED] single_pixel_clip_rectangle [05:39:22] [PASSED] well_known_colors [05:39:22] [PASSED] destination_pitch [05:39:22] ======== [PASSED] drm_test_fb_xrgb8888_to_rgba5551 ========= [05:39:22] ============= drm_test_fb_xrgb8888_to_rgb888 ============== [05:39:22] [PASSED] single_pixel_source_buffer [05:39:22] [PASSED] single_pixel_clip_rectangle [05:39:22] [PASSED] well_known_colors [05:39:22] [PASSED] destination_pitch [05:39:22] ========= [PASSED] drm_test_fb_xrgb8888_to_rgb888 ========== [05:39:22] ============= drm_test_fb_xrgb8888_to_bgr888 ============== [05:39:22] [PASSED] single_pixel_source_buffer [05:39:22] [PASSED] single_pixel_clip_rectangle [05:39:22] [PASSED] well_known_colors [05:39:22] [PASSED] destination_pitch [05:39:22] ========= [PASSED] drm_test_fb_xrgb8888_to_bgr888 ========== [05:39:22] ============ drm_test_fb_xrgb8888_to_argb8888 ============= [05:39:22] [PASSED] single_pixel_source_buffer [05:39:22] [PASSED] single_pixel_clip_rectangle [05:39:22] [PASSED] well_known_colors [05:39:22] [PASSED] destination_pitch [05:39:22] ======== [PASSED] drm_test_fb_xrgb8888_to_argb8888 ========= [05:39:22] =========== drm_test_fb_xrgb8888_to_xrgb2101010 =========== [05:39:22] [PASSED] single_pixel_source_buffer [05:39:22] [PASSED] single_pixel_clip_rectangle [05:39:22] [PASSED] well_known_colors [05:39:22] [PASSED] destination_pitch [05:39:22] ======= [PASSED] drm_test_fb_xrgb8888_to_xrgb2101010 ======= [05:39:22] =========== drm_test_fb_xrgb8888_to_argb2101010 =========== [05:39:22] [PASSED] single_pixel_source_buffer [05:39:22] [PASSED] single_pixel_clip_rectangle [05:39:22] [PASSED] well_known_colors [05:39:22] [PASSED] destination_pitch [05:39:22] ======= [PASSED] drm_test_fb_xrgb8888_to_argb2101010 ======= [05:39:22] ============== drm_test_fb_xrgb8888_to_mono =============== [05:39:22] [PASSED] single_pixel_source_buffer [05:39:22] [PASSED] single_pixel_clip_rectangle [05:39:22] [PASSED] well_known_colors [05:39:22] [PASSED] destination_pitch [05:39:22] ========== [PASSED] drm_test_fb_xrgb8888_to_mono =========== [05:39:22] ==================== drm_test_fb_swab ===================== [05:39:22] [PASSED] single_pixel_source_buffer [05:39:22] [PASSED] single_pixel_clip_rectangle [05:39:22] [PASSED] well_known_colors [05:39:22] [PASSED] destination_pitch [05:39:22] ================ [PASSED] drm_test_fb_swab ================= [05:39:22] ============ drm_test_fb_xrgb8888_to_xbgr8888 ============= [05:39:22] [PASSED] single_pixel_source_buffer [05:39:22] [PASSED] single_pixel_clip_rectangle [05:39:22] [PASSED] well_known_colors [05:39:22] [PASSED] destination_pitch [05:39:22] ======== [PASSED] drm_test_fb_xrgb8888_to_xbgr8888 ========= [05:39:22] ============ drm_test_fb_xrgb8888_to_abgr8888 ============= [05:39:22] [PASSED] single_pixel_source_buffer [05:39:22] [PASSED] single_pixel_clip_rectangle [05:39:22] [PASSED] well_known_colors [05:39:22] [PASSED] destination_pitch [05:39:22] ======== [PASSED] drm_test_fb_xrgb8888_to_abgr8888 ========= [05:39:22] ================= drm_test_fb_clip_offset ================= [05:39:22] [PASSED] pass through [05:39:22] [PASSED] horizontal offset [05:39:22] [PASSED] vertical offset [05:39:22] [PASSED] horizontal and vertical offset [05:39:22] [PASSED] horizontal offset (custom pitch) [05:39:22] [PASSED] vertical offset (custom pitch) [05:39:22] [PASSED] horizontal and vertical offset (custom pitch) [05:39:22] ============= [PASSED] drm_test_fb_clip_offset ============= [05:39:22] =================== drm_test_fb_memcpy ==================== [05:39:22] [PASSED] single_pixel_source_buffer: XR24 little-endian (0x34325258) [05:39:22] [PASSED] single_pixel_source_buffer: XRA8 little-endian (0x38415258) [05:39:22] [PASSED] single_pixel_source_buffer: YU24 little-endian (0x34325559) [05:39:22] [PASSED] single_pixel_clip_rectangle: XB24 little-endian (0x34324258) [05:39:22] [PASSED] single_pixel_clip_rectangle: XRA8 little-endian (0x38415258) [05:39:22] [PASSED] single_pixel_clip_rectangle: YU24 little-endian (0x34325559) [05:39:22] [PASSED] well_known_colors: XB24 little-endian (0x34324258) [05:39:22] [PASSED] well_known_colors: XRA8 little-endian (0x38415258) [05:39:22] [PASSED] well_known_colors: YU24 little-endian (0x34325559) [05:39:22] [PASSED] destination_pitch: XB24 little-endian (0x34324258) [05:39:22] [PASSED] destination_pitch: XRA8 little-endian (0x38415258) [05:39:22] [PASSED] destination_pitch: YU24 little-endian (0x34325559) [05:39:22] =============== [PASSED] drm_test_fb_memcpy ================ [05:39:22] ============= [PASSED] drm_format_helper_test ============== [05:39:22] ================= drm_format (18 subtests) ================= [05:39:22] [PASSED] drm_test_format_block_width_invalid [05:39:22] [PASSED] drm_test_format_block_width_one_plane [05:39:22] [PASSED] drm_test_format_block_width_two_plane [05:39:22] [PASSED] drm_test_format_block_width_three_plane [05:39:22] [PASSED] drm_test_format_block_width_tiled [05:39:22] [PASSED] drm_test_format_block_height_invalid [05:39:22] [PASSED] drm_test_format_block_height_one_plane [05:39:22] [PASSED] drm_test_format_block_height_two_plane [05:39:22] [PASSED] drm_test_format_block_height_three_plane [05:39:22] [PASSED] drm_test_format_block_height_tiled [05:39:22] [PASSED] drm_test_format_min_pitch_invalid [05:39:22] [PASSED] drm_test_format_min_pitch_one_plane_8bpp [05:39:22] [PASSED] drm_test_format_min_pitch_one_plane_16bpp [05:39:22] [PASSED] drm_test_format_min_pitch_one_plane_24bpp [05:39:22] [PASSED] drm_test_format_min_pitch_one_plane_32bpp [05:39:22] [PASSED] drm_test_format_min_pitch_two_plane [05:39:22] [PASSED] drm_test_format_min_pitch_three_plane_8bpp [05:39:22] [PASSED] drm_test_format_min_pitch_tiled [05:39:22] =================== [PASSED] drm_format ==================== [05:39:22] ============== drm_framebuffer (10 subtests) =============== [05:39:22] ========== drm_test_framebuffer_check_src_coords ========== [05:39:22] [PASSED] Success: source fits into fb [05:39:22] [PASSED] Fail: overflowing fb with x-axis coordinate [05:39:22] [PASSED] Fail: overflowing fb with y-axis coordinate [05:39:22] [PASSED] Fail: overflowing fb with source width [05:39:22] [PASSED] Fail: overflowing fb with source height [05:39:22] ====== [PASSED] drm_test_framebuffer_check_src_coords ====== [05:39:22] [PASSED] drm_test_framebuffer_cleanup [05:39:22] =============== drm_test_framebuffer_create =============== [05:39:22] [PASSED] ABGR8888 normal sizes [05:39:22] [PASSED] ABGR8888 max sizes [05:39:22] [PASSED] ABGR8888 pitch greater than min required [05:39:22] [PASSED] ABGR8888 pitch less than min required [05:39:22] [PASSED] ABGR8888 Invalid width [05:39:22] [PASSED] ABGR8888 Invalid buffer handle [05:39:22] [PASSED] No pixel format [05:39:22] [PASSED] ABGR8888 Width 0 [05:39:22] [PASSED] ABGR8888 Height 0 [05:39:22] [PASSED] ABGR8888 Out of bound height * pitch combination [05:39:22] [PASSED] ABGR8888 Large buffer offset [05:39:22] [PASSED] ABGR8888 Buffer offset for inexistent plane [05:39:22] [PASSED] ABGR8888 Invalid flag [05:39:22] [PASSED] ABGR8888 Set DRM_MODE_FB_MODIFIERS without modifiers [05:39:22] [PASSED] ABGR8888 Valid buffer modifier [05:39:22] [PASSED] ABGR8888 Invalid buffer modifier(DRM_FORMAT_MOD_SAMSUNG_64_32_TILE) [05:39:22] [PASSED] ABGR8888 Extra pitches without DRM_MODE_FB_MODIFIERS [05:39:22] [PASSED] ABGR8888 Extra pitches with DRM_MODE_FB_MODIFIERS [05:39:22] [PASSED] NV12 Normal sizes [05:39:22] [PASSED] NV12 Max sizes [05:39:22] [PASSED] NV12 Invalid pitch [05:39:22] [PASSED] NV12 Invalid modifier/missing DRM_MODE_FB_MODIFIERS flag [05:39:22] [PASSED] NV12 different modifier per-plane [05:39:22] [PASSED] NV12 with DRM_FORMAT_MOD_SAMSUNG_64_32_TILE [05:39:22] [PASSED] NV12 Valid modifiers without DRM_MODE_FB_MODIFIERS [05:39:22] [PASSED] NV12 Modifier for inexistent plane [05:39:22] [PASSED] NV12 Handle for inexistent plane [05:39:22] [PASSED] NV12 Handle for inexistent plane without DRM_MODE_FB_MODIFIERS [05:39:22] [PASSED] YVU420 DRM_MODE_FB_MODIFIERS set without modifier [05:39:22] [PASSED] YVU420 Normal sizes [05:39:22] [PASSED] YVU420 Max sizes [05:39:22] [PASSED] YVU420 Invalid pitch [05:39:22] [PASSED] YVU420 Different pitches [05:39:22] [PASSED] YVU420 Different buffer offsets/pitches [05:39:22] [PASSED] YVU420 Modifier set just for plane 0, without DRM_MODE_FB_MODIFIERS [05:39:22] [PASSED] YVU420 Modifier set just for planes 0, 1, without DRM_MODE_FB_MODIFIERS [05:39:22] [PASSED] YVU420 Modifier set just for plane 0, 1, with DRM_MODE_FB_MODIFIERS [05:39:22] [PASSED] YVU420 Valid modifier [05:39:22] [PASSED] YVU420 Different modifiers per plane [05:39:22] [PASSED] YVU420 Modifier for inexistent plane [05:39:22] [PASSED] YUV420_10BIT Invalid modifier(DRM_FORMAT_MOD_LINEAR) [05:39:22] [PASSED] X0L2 Normal sizes [05:39:22] [PASSED] X0L2 Max sizes [05:39:22] [PASSED] X0L2 Invalid pitch [05:39:22] [PASSED] X0L2 Pitch greater than minimum required [05:39:22] [PASSED] X0L2 Handle for inexistent plane [05:39:22] [PASSED] X0L2 Offset for inexistent plane, without DRM_MODE_FB_MODIFIERS set [05:39:22] [PASSED] X0L2 Modifier without DRM_MODE_FB_MODIFIERS set [05:39:22] [PASSED] X0L2 Valid modifier [05:39:22] [PASSED] X0L2 Modifier for inexistent plane [05:39:22] =========== [PASSED] drm_test_framebuffer_create =========== [05:39:22] [PASSED] drm_test_framebuffer_free [05:39:22] [PASSED] drm_test_framebuffer_init [05:39:22] [PASSED] drm_test_framebuffer_init_bad_format [05:39:22] [PASSED] drm_test_framebuffer_init_dev_mismatch [05:39:22] [PASSED] drm_test_framebuffer_lookup [05:39:22] [PASSED] drm_test_framebuffer_lookup_inexistent [05:39:22] [PASSED] drm_test_framebuffer_modifiers_not_supported [05:39:22] ================= [PASSED] drm_framebuffer ================= [05:39:22] ================ drm_gem_shmem (8 subtests) ================ [05:39:22] [PASSED] drm_gem_shmem_test_obj_create [05:39:22] [PASSED] drm_gem_shmem_test_obj_create_private [05:39:22] [PASSED] drm_gem_shmem_test_pin_pages [05:39:22] [PASSED] drm_gem_shmem_test_vmap [05:39:22] [PASSED] drm_gem_shmem_test_get_pages_sgt [05:39:22] [PASSED] drm_gem_shmem_test_get_sg_table [05:39:22] [PASSED] drm_gem_shmem_test_madvise [05:39:22] [PASSED] drm_gem_shmem_test_purge [05:39:22] ================== [PASSED] drm_gem_shmem ================== [05:39:22] === drm_atomic_helper_connector_hdmi_check (27 subtests) === [05:39:22] [PASSED] drm_test_check_broadcast_rgb_auto_cea_mode [05:39:22] [PASSED] drm_test_check_broadcast_rgb_auto_cea_mode_vic_1 [05:39:22] [PASSED] drm_test_check_broadcast_rgb_full_cea_mode [05:39:22] [PASSED] drm_test_check_broadcast_rgb_full_cea_mode_vic_1 [05:39:22] [PASSED] drm_test_check_broadcast_rgb_limited_cea_mode [05:39:22] [PASSED] drm_test_check_broadcast_rgb_limited_cea_mode_vic_1 [05:39:22] ====== drm_test_check_broadcast_rgb_cea_mode_yuv420 ======= [05:39:22] [PASSED] Automatic [05:39:22] [PASSED] Full [05:39:22] [PASSED] Limited 16:235 [05:39:22] == [PASSED] drm_test_check_broadcast_rgb_cea_mode_yuv420 === [05:39:22] [PASSED] drm_test_check_broadcast_rgb_crtc_mode_changed [05:39:22] [PASSED] drm_test_check_broadcast_rgb_crtc_mode_not_changed [05:39:22] [PASSED] drm_test_check_disable_connector [05:39:22] [PASSED] drm_test_check_hdmi_funcs_reject_rate [05:39:22] [PASSED] drm_test_check_max_tmds_rate_bpc_fallback_rgb [05:39:22] [PASSED] drm_test_check_max_tmds_rate_bpc_fallback_yuv420 [05:39:22] [PASSED] drm_test_check_max_tmds_rate_bpc_fallback_ignore_yuv422 [05:39:22] [PASSED] drm_test_check_max_tmds_rate_bpc_fallback_ignore_yuv420 [05:39:22] [PASSED] drm_test_check_driver_unsupported_fallback_yuv420 [05:39:22] [PASSED] drm_test_check_output_bpc_crtc_mode_changed [05:39:22] [PASSED] drm_test_check_output_bpc_crtc_mode_not_changed [05:39:22] [PASSED] drm_test_check_output_bpc_dvi [05:39:22] [PASSED] drm_test_check_output_bpc_format_vic_1 [05:39:22] [PASSED] drm_test_check_output_bpc_format_display_8bpc_only [05:39:22] [PASSED] drm_test_check_output_bpc_format_display_rgb_only [05:39:22] [PASSED] drm_test_check_output_bpc_format_driver_8bpc_only [05:39:22] [PASSED] drm_test_check_output_bpc_format_driver_rgb_only [05:39:22] [PASSED] drm_test_check_tmds_char_rate_rgb_8bpc [05:39:22] [PASSED] drm_test_check_tmds_char_rate_rgb_10bpc [05:39:22] [PASSED] drm_test_check_tmds_char_rate_rgb_12bpc [05:39:22] ===== [PASSED] drm_atomic_helper_connector_hdmi_check ====== [05:39:22] === drm_atomic_helper_connector_hdmi_reset (6 subtests) ==== [05:39:22] [PASSED] drm_test_check_broadcast_rgb_value [05:39:22] [PASSED] drm_test_check_bpc_8_value [05:39:22] [PASSED] drm_test_check_bpc_10_value [05:39:22] [PASSED] drm_test_check_bpc_12_value [05:39:22] [PASSED] drm_test_check_format_value [05:39:22] [PASSED] drm_test_check_tmds_char_value [05:39:22] ===== [PASSED] drm_atomic_helper_connector_hdmi_reset ====== [05:39:22] = drm_atomic_helper_connector_hdmi_mode_valid (4 subtests) = [05:39:22] [PASSED] drm_test_check_mode_valid [05:39:22] [PASSED] drm_test_check_mode_valid_reject [05:39:22] [PASSED] drm_test_check_mode_valid_reject_rate [05:39:22] [PASSED] drm_test_check_mode_valid_reject_max_clock [05:39:22] === [PASSED] drm_atomic_helper_connector_hdmi_mode_valid === [05:39:22] ================= drm_managed (2 subtests) ================= [05:39:22] [PASSED] drm_test_managed_release_action [05:39:22] [PASSED] drm_test_managed_run_action [05:39:22] =================== [PASSED] drm_managed =================== [05:39:22] =================== drm_mm (6 subtests) ==================== [05:39:22] [PASSED] drm_test_mm_init [05:39:22] [PASSED] drm_test_mm_debug [05:39:22] [PASSED] drm_test_mm_align32 [05:39:22] [PASSED] drm_test_mm_align64 [05:39:22] [PASSED] drm_test_mm_lowest [05:39:22] [PASSED] drm_test_mm_highest [05:39:22] ===================== [PASSED] drm_mm ====================== [05:39:22] ============= drm_modes_analog_tv (5 subtests) ============= [05:39:22] [PASSED] drm_test_modes_analog_tv_mono_576i [05:39:22] [PASSED] drm_test_modes_analog_tv_ntsc_480i [05:39:22] [PASSED] drm_test_modes_analog_tv_ntsc_480i_inlined [05:39:22] [PASSED] drm_test_modes_analog_tv_pal_576i [05:39:22] [PASSED] drm_test_modes_analog_tv_pal_576i_inlined [05:39:22] =============== [PASSED] drm_modes_analog_tv =============== [05:39:22] ============== drm_plane_helper (2 subtests) =============== [05:39:22] =============== drm_test_check_plane_state ================ [05:39:22] [PASSED] clipping_simple [05:39:22] [PASSED] clipping_rotate_reflect [05:39:22] [PASSED] positioning_simple [05:39:22] [PASSED] upscaling [05:39:22] [PASSED] downscaling [05:39:22] [PASSED] rounding1 [05:39:22] [PASSED] rounding2 [05:39:22] [PASSED] rounding3 [05:39:22] [PASSED] rounding4 [05:39:22] =========== [PASSED] drm_test_check_plane_state ============ [05:39:22] =========== drm_test_check_invalid_plane_state ============ [05:39:22] [PASSED] positioning_invalid [05:39:22] [PASSED] upscaling_invalid [05:39:22] [PASSED] downscaling_invalid [05:39:22] ======= [PASSED] drm_test_check_invalid_plane_state ======== [05:39:22] ================ [PASSED] drm_plane_helper ================= [05:39:22] ====== drm_connector_helper_tv_get_modes (1 subtest) ======= [05:39:22] ====== drm_test_connector_helper_tv_get_modes_check ======= [05:39:22] [PASSED] None [05:39:22] [PASSED] PAL [05:39:22] [PASSED] NTSC [05:39:22] [PASSED] Both, NTSC Default [05:39:22] [PASSED] Both, PAL Default [05:39:22] [PASSED] Both, NTSC Default, with PAL on command-line [05:39:22] [PASSED] Both, PAL Default, with NTSC on command-line [05:39:22] == [PASSED] drm_test_connector_helper_tv_get_modes_check === [05:39:22] ======== [PASSED] drm_connector_helper_tv_get_modes ======== [05:39:22] ================== drm_rect (9 subtests) =================== [05:39:22] [PASSED] drm_test_rect_clip_scaled_div_by_zero [05:39:22] [PASSED] drm_test_rect_clip_scaled_not_clipped [05:39:22] [PASSED] drm_test_rect_clip_scaled_clipped [05:39:22] [PASSED] drm_test_rect_clip_scaled_signed_vs_unsigned [05:39:22] ================= drm_test_rect_intersect ================= [05:39:22] [PASSED] top-left x bottom-right: 2x2+1+1 x 2x2+0+0 [05:39:22] [PASSED] top-right x bottom-left: 2x2+0+0 x 2x2+1-1 [05:39:22] [PASSED] bottom-left x top-right: 2x2+1-1 x 2x2+0+0 [05:39:22] [PASSED] bottom-right x top-left: 2x2+0+0 x 2x2+1+1 [05:39:22] [PASSED] right x left: 2x1+0+0 x 3x1+1+0 [05:39:22] [PASSED] left x right: 3x1+1+0 x 2x1+0+0 [05:39:22] [PASSED] up x bottom: 1x2+0+0 x 1x3+0-1 [05:39:22] [PASSED] bottom x up: 1x3+0-1 x 1x2+0+0 [05:39:22] [PASSED] touching corner: 1x1+0+0 x 2x2+1+1 [05:39:22] [PASSED] touching side: 1x1+0+0 x 1x1+1+0 [05:39:22] [PASSED] equal rects: 2x2+0+0 x 2x2+0+0 [05:39:22] [PASSED] inside another: 2x2+0+0 x 1x1+1+1 [05:39:22] [PASSED] far away: 1x1+0+0 x 1x1+3+6 [05:39:22] [PASSED] points intersecting: 0x0+5+10 x 0x0+5+10 [05:39:22] [PASSED] points not intersecting: 0x0+0+0 x 0x0+5+10 [05:39:22] ============= [PASSED] drm_test_rect_intersect ============= [05:39:22] ================ drm_test_rect_calc_hscale ================ [05:39:22] [PASSED] normal use [05:39:22] [PASSED] out of max range [05:39:22] [PASSED] out of min range [05:39:22] [PASSED] zero dst [05:39:22] [PASSED] negative src [05:39:22] [PASSED] negative dst [05:39:22] ============ [PASSED] drm_test_rect_calc_hscale ============ [05:39:22] ================ drm_test_rect_calc_vscale ================ [05:39:22] [PASSED] normal use stty: 'standard input': Inappropriate ioctl for device [05:39:22] [PASSED] out of max range [05:39:22] [PASSED] out of min range [05:39:22] [PASSED] zero dst [05:39:22] [PASSED] negative src [05:39:22] [PASSED] negative dst [05:39:22] ============ [PASSED] drm_test_rect_calc_vscale ============ [05:39:22] ================== drm_test_rect_rotate =================== [05:39:22] [PASSED] reflect-x [05:39:22] [PASSED] reflect-y [05:39:22] [PASSED] rotate-0 [05:39:22] [PASSED] rotate-90 [05:39:22] [PASSED] rotate-180 [05:39:22] [PASSED] rotate-270 [05:39:22] ============== [PASSED] drm_test_rect_rotate =============== [05:39:22] ================ drm_test_rect_rotate_inv ================= [05:39:22] [PASSED] reflect-x [05:39:22] [PASSED] reflect-y [05:39:22] [PASSED] rotate-0 [05:39:22] [PASSED] rotate-90 [05:39:22] [PASSED] rotate-180 [05:39:22] [PASSED] rotate-270 [05:39:22] ============ [PASSED] drm_test_rect_rotate_inv ============= [05:39:22] ==================== [PASSED] drm_rect ===================== [05:39:22] ============ drm_sysfb_modeset_test (1 subtest) ============ [05:39:22] ============ drm_test_sysfb_build_fourcc_list ============= [05:39:22] [PASSED] no native formats [05:39:22] [PASSED] XRGB8888 as native format [05:39:22] [PASSED] remove duplicates [05:39:22] [PASSED] convert alpha formats [05:39:22] [PASSED] random formats [05:39:22] ======== [PASSED] drm_test_sysfb_build_fourcc_list ========= [05:39:22] ============= [PASSED] drm_sysfb_modeset_test ============== [05:39:22] ============================================================ [05:39:22] Testing complete. Ran 622 tests: passed: 622 [05:39:22] Elapsed time: 27.068s total, 1.734s configuring, 24.867s building, 0.446s running
+ /kernel/tools/testing/kunit/kunit.py run --kunitconfig /kernel/drivers/gpu/drm/ttm/tests/.kunitconfig [05:39:22] Configuring KUnit Kernel ...
Regenerating .config ...
Populating config with:
$ make ARCH=um O=.kunit olddefconfig [05:39:24] Building KUnit Kernel ... Populating config with: $ make ARCH=um O=.kunit olddefconfig Building with: $ make all compile_commands.json scripts_gdb ARCH=um O=.kunit --jobs=48 [05:39:33] Starting KUnit Kernel (1/1)... [05:39:33] ============================================================ Running tests with: $ .kunit/linux kunit.enable=1 mem=1G console=tty kunit_shutdown=halt [05:39:33] ================= ttm_device (5 subtests) ================== [05:39:33] [PASSED] ttm_device_init_basic [05:39:33] [PASSED] ttm_device_init_multiple [05:39:33] [PASSED] ttm_device_fini_basic [05:39:33] [PASSED] ttm_device_init_no_vma_man [05:39:33] ================== ttm_device_init_pools ================== [05:39:33] [PASSED] No DMA allocations, no DMA32 required [05:39:33] [PASSED] DMA allocations, DMA32 required [05:39:33] [PASSED] No DMA allocations, DMA32 required [05:39:33] [PASSED] DMA allocations, no DMA32 required [05:39:33] ============== [PASSED] ttm_device_init_pools ============== [05:39:33] =================== [PASSED] ttm_device ==================== [05:39:33] ================== ttm_pool (8 subtests) =================== [05:39:33] ================== ttm_pool_alloc_basic =================== [05:39:33] [PASSED] One page [05:39:33] [PASSED] More than one page [05:39:33] [PASSED] Above the allocation limit [05:39:33] [PASSED] One page, with coherent DMA mappings enabled [05:39:33] [PASSED] Above the allocation limit, with coherent DMA mappings enabled [05:39:33] ============== [PASSED] ttm_pool_alloc_basic =============== [05:39:33] ============== ttm_pool_alloc_basic_dma_addr ============== [05:39:33] [PASSED] One page [05:39:33] [PASSED] More than one page [05:39:33] [PASSED] Above the allocation limit [05:39:33] [PASSED] One page, with coherent DMA mappings enabled [05:39:33] [PASSED] Above the allocation limit, with coherent DMA mappings enabled [05:39:33] ========== [PASSED] ttm_pool_alloc_basic_dma_addr ========== [05:39:33] [PASSED] ttm_pool_alloc_order_caching_match [05:39:33] [PASSED] ttm_pool_alloc_caching_mismatch [05:39:33] [PASSED] ttm_pool_alloc_order_mismatch [05:39:33] [PASSED] ttm_pool_free_dma_alloc [05:39:33] [PASSED] ttm_pool_free_no_dma_alloc [05:39:33] [PASSED] ttm_pool_fini_basic [05:39:33] ==================== [PASSED] ttm_pool ===================== [05:39:33] ================ ttm_resource (8 subtests) ================= [05:39:33] ================= ttm_resource_init_basic ================= [05:39:33] [PASSED] Init resource in TTM_PL_SYSTEM [05:39:33] [PASSED] Init resource in TTM_PL_VRAM [05:39:33] [PASSED] Init resource in a private placement [05:39:33] [PASSED] Init resource in TTM_PL_SYSTEM, set placement flags [05:39:33] ============= [PASSED] ttm_resource_init_basic ============= [05:39:33] [PASSED] ttm_resource_init_pinned [05:39:33] [PASSED] ttm_resource_fini_basic [05:39:33] [PASSED] ttm_resource_manager_init_basic [05:39:33] [PASSED] ttm_resource_manager_usage_basic [05:39:33] [PASSED] ttm_resource_manager_set_used_basic [05:39:33] [PASSED] ttm_sys_man_alloc_basic [05:39:33] [PASSED] ttm_sys_man_free_basic [05:39:33] ================== [PASSED] ttm_resource =================== [05:39:33] =================== ttm_tt (15 subtests) =================== [05:39:33] ==================== ttm_tt_init_basic ==================== [05:39:33] [PASSED] Page-aligned size [05:39:33] [PASSED] Extra pages requested [05:39:33] ================ [PASSED] ttm_tt_init_basic ================ [05:39:33] [PASSED] ttm_tt_init_misaligned [05:39:33] [PASSED] ttm_tt_fini_basic [05:39:33] [PASSED] ttm_tt_fini_sg [05:39:33] [PASSED] ttm_tt_fini_shmem [05:39:33] [PASSED] ttm_tt_create_basic [05:39:33] [PASSED] ttm_tt_create_invalid_bo_type [05:39:33] [PASSED] ttm_tt_create_ttm_exists [05:39:33] [PASSED] ttm_tt_create_failed [05:39:33] [PASSED] ttm_tt_destroy_basic [05:39:33] [PASSED] ttm_tt_populate_null_ttm [05:39:33] [PASSED] ttm_tt_populate_populated_ttm [05:39:33] [PASSED] ttm_tt_unpopulate_basic [05:39:33] [PASSED] ttm_tt_unpopulate_empty_ttm [05:39:33] [PASSED] ttm_tt_swapin_basic [05:39:33] ===================== [PASSED] ttm_tt ====================== [05:39:33] =================== ttm_bo (14 subtests) =================== [05:39:33] =========== ttm_bo_reserve_optimistic_no_ticket =========== [05:39:33] [PASSED] Cannot be interrupted and sleeps [05:39:33] [PASSED] Cannot be interrupted, locks straight away [05:39:33] [PASSED] Can be interrupted, sleeps [05:39:33] ======= [PASSED] ttm_bo_reserve_optimistic_no_ticket ======= [05:39:33] [PASSED] ttm_bo_reserve_locked_no_sleep [05:39:33] [PASSED] ttm_bo_reserve_no_wait_ticket [05:39:33] [PASSED] ttm_bo_reserve_double_resv [05:39:33] [PASSED] ttm_bo_reserve_interrupted [05:39:33] [PASSED] ttm_bo_reserve_deadlock [05:39:33] [PASSED] ttm_bo_unreserve_basic [05:39:33] [PASSED] ttm_bo_unreserve_pinned [05:39:33] [PASSED] ttm_bo_unreserve_bulk [05:39:33] [PASSED] ttm_bo_fini_basic [05:39:33] [PASSED] ttm_bo_fini_shared_resv [05:39:33] [PASSED] ttm_bo_pin_basic [05:39:33] [PASSED] ttm_bo_pin_unpin_resource [05:39:33] [PASSED] ttm_bo_multiple_pin_one_unpin [05:39:33] ===================== [PASSED] ttm_bo ====================== [05:39:33] ============== ttm_bo_validate (21 subtests) =============== [05:39:33] ============== ttm_bo_init_reserved_sys_man =============== [05:39:33] [PASSED] Buffer object for userspace [05:39:33] [PASSED] Kernel buffer object [05:39:33] [PASSED] Shared buffer object [05:39:33] ========== [PASSED] ttm_bo_init_reserved_sys_man =========== [05:39:33] ============== ttm_bo_init_reserved_mock_man ============== [05:39:33] [PASSED] Buffer object for userspace [05:39:33] [PASSED] Kernel buffer object [05:39:33] [PASSED] Shared buffer object [05:39:33] ========== [PASSED] ttm_bo_init_reserved_mock_man ========== [05:39:33] [PASSED] ttm_bo_init_reserved_resv [05:39:33] ================== ttm_bo_validate_basic ================== [05:39:33] [PASSED] Buffer object for userspace [05:39:33] [PASSED] Kernel buffer object [05:39:33] [PASSED] Shared buffer object [05:39:33] ============== [PASSED] ttm_bo_validate_basic ============== [05:39:33] [PASSED] ttm_bo_validate_invalid_placement [05:39:33] ============= ttm_bo_validate_same_placement ============== [05:39:33] [PASSED] System manager [05:39:33] [PASSED] VRAM manager [05:39:33] ========= [PASSED] ttm_bo_validate_same_placement ========== [05:39:33] [PASSED] ttm_bo_validate_failed_alloc [05:39:33] [PASSED] ttm_bo_validate_pinned [05:39:33] [PASSED] ttm_bo_validate_busy_placement [05:39:33] ================ ttm_bo_validate_multihop ================= [05:39:33] [PASSED] Buffer object for userspace [05:39:33] [PASSED] Kernel buffer object [05:39:33] [PASSED] Shared buffer object [05:39:33] ============ [PASSED] ttm_bo_validate_multihop ============= [05:39:33] ========== ttm_bo_validate_no_placement_signaled ========== [05:39:33] [PASSED] Buffer object in system domain, no page vector [05:39:33] [PASSED] Buffer object in system domain with an existing page vector [05:39:33] ====== [PASSED] ttm_bo_validate_no_placement_signaled ====== [05:39:33] ======== ttm_bo_validate_no_placement_not_signaled ======== [05:39:33] [PASSED] Buffer object for userspace [05:39:33] [PASSED] Kernel buffer object [05:39:33] [PASSED] Shared buffer object [05:39:33] ==== [PASSED] ttm_bo_validate_no_placement_not_signaled ==== [05:39:33] [PASSED] ttm_bo_validate_move_fence_signaled [05:39:33] ========= ttm_bo_validate_move_fence_not_signaled ========= [05:39:33] [PASSED] Waits for GPU [05:39:33] [PASSED] Tries to lock straight away [05:39:33] ===== [PASSED] ttm_bo_validate_move_fence_not_signaled ===== [05:39:33] [PASSED] ttm_bo_validate_happy_evict [05:39:33] [PASSED] ttm_bo_validate_all_pinned_evict [05:39:33] [PASSED] ttm_bo_validate_allowed_only_evict [05:39:33] [PASSED] ttm_bo_validate_deleted_evict [05:39:33] [PASSED] ttm_bo_validate_busy_domain_evict [05:39:33] [PASSED] ttm_bo_validate_evict_gutting [05:39:33] [PASSED] ttm_bo_validate_recrusive_evict stty: 'standard input': Inappropriate ioctl for device [05:39:33] ================= [PASSED] ttm_bo_validate ================= [05:39:33] ============================================================ [05:39:33] Testing complete. Ran 101 tests: passed: 101 [05:39:33] Elapsed time: 11.246s total, 1.673s configuring, 9.357s building, 0.178s running
+ cleanup
++ stat -c %u:%g /kernel
+ chown -R 1003:1003 /kernel
Patchwork
CI✗ Fi.CI.BUILD: failure for Enable/Disable DC balance along with VRR DSB
In reply to Mitul Golani== Series Details ==
== Series Details ==
Series: Enable/Disable DC balance along with VRR DSB
URL : https://patchwork.freedesktop.org/series/156899/
State : failure
== Summary ==
Error: make failed
CALL scripts/checksyscalls.sh
DESCEND objtool
INSTALL libsubcmd_headers
CC [M] drivers/gpu/drm/i915/display/intel_vrr.odrivers/gpu/drm/i915/display/intel_vrr.c: In function ‘intel_vrr_compute_vrr_timings’:drivers/gpu/drm/i915/display/intel_vrr.c:259:31: error: unused variable ‘display’ [-Werror=unused-variable]
259 | struct intel_display *display = to_intel_display(crtc_state);
| ^~~~~~~
cc1: all warnings being treated as errors
make[6]: *** [scripts/Makefile.build:287: drivers/gpu/drm/i915/display/intel_vrr.o] Error 1 make[5]: *** [scripts/Makefile.build:556: drivers/gpu/drm/i915] Error 2
make[4]: *** [scripts/Makefile.build:556: drivers/gpu/drm] Error 2
make[3]: *** [scripts/Makefile.build:556: drivers/gpu] Error 2
make[2]: *** [scripts/Makefile.build:556: drivers] Error 2
make[1]: *** [/home/kbuild2/kernel/Makefile:2010: .] Error 2
make: *** [Makefile:248: __sub-make] Error 2
Build failed, no error log produced