f2fs/023: test sanity check condition w/ error injection
PATCH v2 1/1 f2fs/023: test sanity check condition w/ error injection
After commit 5c1768b67250 ("f2fs: fix to do sanity check correctly on i_inline_xattr_size"), f2fs should handle corrupted i_inline_xattr_size correctly, let's add this regression testcase to check that.
---
v2:
- use _filter_scratch to filter scratch mountpoint
- check output message of inject.f2fs rather than return value
- add _require_attrs
- add f2fs/023 to attr group
- fail testcase if mkfs failed
tests/f2fs/023 | 49 ++++++++++++++++++++++++++++++++++++++++++++++ tests/f2fs/023.out | 2 ++ 2 files changed, 51 insertions(+) create mode 100755 tests/f2fs/023 create mode 100644 tests/f2fs/023.out
tests/f2fs/023 new file +49 -0
@@ -0,0 +1,49 @@ +#! /bin/bash +# SPDX-License-Identifier: GPL-2.0 +# Copyright (c) 2025 Chao Yu <[email protected]> +# +# FS QA Test No. f2fs/023 +# +# This testcase tries to inject fault into inode.i_inline_xattr_size, +# and check whether sanity check of f2fs can handle fault correctly. +# + +. ./common/preamble +. ./common/attr +. ./common/filter +_begin_fstest auto quick rw attr + +_fixed_by_kernel_commit 5c1768b67250 \ + "f2fs: fix to do sanity check correctly on i_inline_xattr_size" + +_require_attrs +_require_scratch_nocheck +_require_inject_f2fs_command node i_inline +_require_inject_f2fs_command node i_inline_xattr_size + +testfile=$SCRATCH_MNT/testfile + +# remove all mkfs options to avoid layout change of on-disk inode +export MKFS_OPTIONS="" + +_scratch_mkfs "-O extra_attr,flexible_inline_xattr" >> $seqres.full || _fail "mkfs failed" +_scratch_mount "-o inline_xattr_size=512" >>$seqres.full 2>&1 +touch $testfile +_scratch_unmount + +# inject .i_inline field: clear F2FS_EXTRA_ATTR bit +output=`$F2FS_INJECT_PROG --node --mb i_inline --nid 4 --val 0x1 $SCRATCH_DEV` +echo "$output" >> $seqres.full +echo "$output" | grep "unknown or unsupported member" && _fail "i_inline is unsupported" + +# inject .i_inline_xattr_size field from 512 to 2048 +output=`$F2FS_INJECT_PROG --node --mb i_inline_xattr_size --nid 4 --val 2048 $SCRATCH_DEV` +echo "$output" >> $seqres.full +echo "$output" | grep "unknown or unsupported member" && _fail "i_inline_xattr_size is unsupported" + +_scratch_mount + +$GETFATTR_PROG -n user.test "$testfile" 2>&1 | _filter_scratch + +status=0 +exit
tests/f2fs/023.out new file +2 -0
@@ -0,0 +1,2 @@ +QA output created by 023 +getfattr: SCRATCH_MNT/testfile: Structure needs cleaning
Signature · 1 line
2.49.0
Quoted 57 lines · Chao Yu
After commit
5c1768b67250("f2fs: fix to do sanity check correctly oni_inline_xattr_size"), f2fs should handle corruptedi_inline_xattr_sizecorrectly, let's add this regression testcase to check that.Cc Jaegeuk Kim <[email protected]>Signed-off-by Chao Yu <[email protected]>---
v2:
- use_filter_scratchto filter scratch mountpoint
- check output message of inject.f2fs rather than return value
- add_require_attrs
- add f2fs/023 to attr group
- fail testcase if mkfs failedtests/f2fs/023 | 49 ++++++++++++++++++++++++++++++++++++++++++++++ tests/f2fs/023.out | 2 ++ 2 files changed, 51 insertions(+) create mode 100755 tests/f2fs/023 create mode 100644 tests/f2fs/023.outtests/f2fs/023 new file +32
-0@@ -0,0 +1,49 @@ +#! /bin/bash +# SPDX-License-Identifier: GPL-2.0 +# Copyright (c) 2025 Chao Yu <[email protected]> +# +# FS QA Test No. f2fs/023 +# +# This testcase tries to inject fault into inode.i_inline_xattr_size, +# and check whether sanity check of f2fs can handle fault correctly. +# + +. ./common/preamble +. ./common/attr +. ./common/filter +_begin_fstest auto quick rw attr + +_fixed_by_kernel_commit 5c1768b67250 \ + "f2fs: fix to do sanity check correctly on i_inline_xattr_size" + +_require_attrs +_require_scratch_nocheck +_require_inject_f2fs_command node i_inline +_require_inject_f2fs_command node i_inline_xattr_size + +testfile=$SCRATCH_MNT/testfile + +# remove all mkfs options to avoid layout change of on-disk inode +export MKFS_OPTIONS="" + +_scratch_mkfs "-O extra_attr,flexible_inline_xattr" >> $seqres.full || _fail "mkfs failed" +_scratch_mount "-o inline_xattr_size=512" >>$seqres.full 2>&1 +touch $testfile +_scratch_unmount
tests/f2fs/023 line 42
Quoted 10 lines
tests/f2fs/023 new file +10
-0+ +# inject .i_inline field: clear F2FS_EXTRA_ATTR bit +output=`$F2FS_INJECT_PROG --node --mb i_inline --nid 4 --val 0x1 $SCRATCH_DEV` +echo "$output" >> $seqres.full +echo "$output" | grep "unknown or unsupported member" && _fail "i_inline is unsupported" + +# inject .i_inline_xattr_size field from 512 to 2048 +output=`$F2FS_INJECT_PROG --node --mb i_inline_xattr_size --nid 4 --val 2048 $SCRATCH_DEV` +echo "$output" >> $seqres.full +echo "$output" | grep "unknown or unsupported member" && _fail "i_inline_xattr_size is unsupported"
I think we might need a common helper to do f2fs injection and return error if injection fails, if F2FS_INJECT_PROG always can't return error properly. Anyway, that's another story. For this patch:
Quoted 18 lines
tests/f2fs/023 new file +7
-0+ +_scratch_mount + +$GETFATTR_PROG -n user.test "$testfile" 2>&1 | _filter_scratch + +status=0 +exittests/f2fs/023.out new file +2
-0@@ -0,0 +1,2 @@ +QA output created by 023 +getfattr: SCRATCH_MNT/testfile: Structure needs cleaningSignature · 1 line
2.49.0
Quoted 63 lines · Zorro Lang
Quoted 62 lines · Chao Yu
After commit
5c1768b67250("f2fs: fix to do sanity check correctly oni_inline_xattr_size"), f2fs should handle corruptedi_inline_xattr_sizecorrectly, let's add this regression testcase to check that.Cc Jaegeuk Kim <[email protected]>Signed-off-by Chao Yu <[email protected]>---
v2:
- use_filter_scratchto filter scratch mountpoint
- check output message of inject.f2fs rather than return value
- add_require_attrs
- add f2fs/023 to attr group
- fail testcase if mkfs failedtests/f2fs/023 | 49 ++++++++++++++++++++++++++++++++++++++++++++++ tests/f2fs/023.out | 2 ++ 2 files changed, 51 insertions(+)create mode 100755 tests/f2fs/023
create mode 100644 tests/f2fs/023.outtests/f2fs/023 new file +37
-0@@ -0,0 +1,49 @@ +#! /bin/bash +# SPDX-License-Identifier: GPL-2.0 +# Copyright (c) 2025 Chao Yu <[email protected]> +# +# FS QA Test No. f2fs/023 +# +# This testcase tries to inject fault into inode.i_inline_xattr_size, +# and check whether sanity check of f2fs can handle fault correctly. +# + +. ./common/preamble +. ./common/attr +. ./common/filter +_begin_fstest auto quick rw attr + +_fixed_by_kernel_commit 5c1768b67250 \ + "f2fs: fix to do sanity check correctly on i_inline_xattr_size" + +_require_attrs +_require_scratch_nocheck +_require_inject_f2fs_command node i_inline +_require_inject_f2fs_command node i_inline_xattr_size + +testfile=$SCRATCH_MNT/testfile + +# remove all mkfs options to avoid layout change of on-disk inode +export MKFS_OPTIONS="" + +_scratch_mkfs "-O extra_attr,flexible_inline_xattr" >> $seqres.full || _fail "mkfs failed" +_scratch_mount "-o inline_xattr_size=512" >>$seqres.full 2>&1 +touch $testfile +_scratch_unmount + +# inject .i_inline field: clear F2FS_EXTRA_ATTR bit +output=`$F2FS_INJECT_PROG --node --mb i_inline --nid 4 --val 0x1 $SCRATCH_DEV` +echo "$output" >> $seqres.full +echo "$output" | grep "unknown or unsupported member" && _fail "i_inline is unsupported"
Quoted 8 lines
tests/f2fs/023 line 42
Quoted 5 lines
tests/f2fs/023 new file +5
-0+ +# inject .i_inline_xattr_size field from 512 to 2048 +output=`$F2FS_INJECT_PROG --node --mb i_inline_xattr_size --nid 4 --val 2048 $SCRATCH_DEV` +echo "$output" >> $seqres.full +echo "$output" | grep "unknown or unsupported member" && _fail "i_inline_xattr_size is unsupported"I think we might need a common helper to do f2fs injection and return error if injection fails, if
F2FS_INJECT_PROGalways can't return error
Yes, let me find free slot to clean up, thanks for the suggestion and review. :)
Thanks.
Quoted 23 lines
properly. Anyway, that's another story. For this patch:
Reviewed-by Zorro Lang <[email protected]>Quoted 18 lines
tests/f2fs/023 new file +7
-0+ +_scratch_mount + +$GETFATTR_PROG -n user.test "$testfile" 2>&1 | _filter_scratch + +status=0 +exittests/f2fs/023.out new file +2
-0@@ -0,0 +1,2 @@ +QA output created by 023 +getfattr: SCRATCH_MNT/testfile: Structure needs cleaningSignature · 1 line
2.49.0