rust: auxiliary: fix false positive warning for missing a safety comment
Subsystems (2)
Danilo Krummrich
maintainerPATCH 1/1 rust: auxiliary: fix false positive warning for missing a safety comment
Some older (yet supported) versions of clippy throw a false positive warning for missing a safety comment when the safety comment is on a multiline statement.
warning: unsafe block missing a safety comment
--> rust/kernel/auxiliary.rs:351:22
|
351 | Self(unsafe { NonNull::new_unchecked(adev) }),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
| = help: consider adding a safety comment on the preceding line
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#undocumented_unsafe_blocks
= note: requested on the command line with -W clippy::undocumented-unsafe-blocks
warning: 1 warning emitted
Fix this by placing the safety comment right on top of the same line introducing the unsafe block.
--- rust/kernel/auxiliary.rs | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)
rust/kernel/auxiliary.rs +2 -3
@@ -341,13 +341,12 @@ pub fn new<'a>(return Err (Error ::from_errno (ret)); } -// SAFETY: `adev` is guaranteed to be non-null, since the `KBox` was allocated -// successfully. -// // INVARIANT: The device will remain registered until `auxiliary_device_delete()` is // called, which happens in `Self::drop()`. Ok (Devres ::new ( parent, +// SAFETY: `adev` is guaranteed to be non-null, since the `KBox` was allocated +// successfully. Self (unsafe {NonNull ::new_unchecked (adev) }), )) })
Signature · 1 line
2.51.0
Quoted 49 lines · Danilo Krummrich
Some older (yet supported) versions of clippy throw a false positive warning for missing a safety comment when the safety comment is on a multiline statement.
warning: unsafe block missing a safety comment
-->rust/kernel/auxiliary.rs:351:22| 351 | Self(unsafe { NonNull::new_unchecked(adev) }), | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ |= help: consider adding a safety comment on the preceding line
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#undocumented_unsafe_blocks
= note: requested on the command line with-W clippy::undocumented-unsafe-blockswarning: 1 warning emitted
Fix this by placing the safety comment right on top of the same line introducing the unsafe block.
Fixes e4e679c8608e ("rust: auxiliary: unregister on parent device unbind")Signed-off-by Danilo Krummrich <[email protected]>--- rust/kernel/auxiliary.rs | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)rust/kernel/auxiliary.rs +2
-3@@ -341,13 +341,12 @@ pub fn new<'a>(return Err (Error ::from_errno (ret)); } -// SAFETY: `adev` is guaranteed to be non-null, since the `KBox` was allocated -// successfully. -// // INVARIANT: The device will remain registered until `auxiliary_device_delete()` is // called, which happens in `Self::drop()`. Ok (Devres ::new ( parent, +// SAFETY: `adev` is guaranteed to be non-null, since the `KBox` was allocated +// successfully. Self (unsafe {NonNull ::new_unchecked (adev) }), )) })Signature · 1 line
2.51.0
Quoted 14 lines · Danilo Krummrich
Some older (yet supported) versions of clippy throw a false positive warning for missing a safety comment when the safety comment is on a multiline statement.
warning: unsafe block missing a safety comment
-->rust/kernel/auxiliary.rs:351:22| 351 | Self(unsafe { NonNull::new_unchecked(adev) }), | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ |= help: consider adding a safety comment on the preceding line
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#undocumented_unsafe_blocks
= note: requested on the command line with-W clippy::undocumented-unsafe-blocks
Quoted 7 lines
warning: 1 warning emitted
Fix this by placing the safety comment right on top of the same line introducing the unsafe block.
Fixes e4e679c8608e ("rust: auxiliary: unregister on parent device unbind")Signed-off-by Danilo Krummrich <[email protected]>
Danilo Krummrich
maintainerQuoted 14 lines · Danilo Krummrich
Some older (yet supported) versions of clippy throw a false positive warning for missing a safety comment when the safety comment is on a multiline statement.
warning: unsafe block missing a safety comment
-->rust/kernel/auxiliary.rs:351:22| 351 | Self(unsafe { NonNull::new_unchecked(adev) }), | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ |= help: consider adding a safety comment on the preceding line
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#undocumented_unsafe_blocks
= note: requested on the command line with-W clippy::undocumented-unsafe-blocks
Quoted 7 lines
warning: 1 warning emitted
Fix this by placing the safety comment right on top of the same line introducing the unsafe block.
Fixes e4e679c8608e ("rust: auxiliary: unregister on parent device unbind")Signed-off-by Danilo Krummrich <[email protected]>
Applied to driver-core-testing, thanks!