ASoC/SOF/PCI/Intel: Support for Nova Lake S
Subsystems (5)
Peter Ujfalusi
maintainerv2 cover ASoC/SOF/PCI/Intel: Support for Nova Lake S
Hi,
Changes since v1:
- Add information for the users of the PCI ID
- Add Acked-by tag for the pci_ids.h from Bjorn
- Add Acked-by tags from Mark for the ASoC patches
This series adds initial support for NVL-S from the Nova Lake family. NVL-S includes ACE4 audio subsystem, it has 2 DSP cores.
Regards,
Peter
---
Bard Liao (1):
ASoC: Intel: soc-acpi-intel-nvl-match: add rt722 l3 support
Peter Ujfalusi (6):
PCI: Add Intel Nova Lake S audio Device ID
ALSA: hda/hdmi: intelhdmi: add HDMI codec ID for Intel NVL
ASoC: Intel: soc-acpi: add NVL match tables
ASoC: SOF: Intel: add initial support for NVL-S
ALSA: hda: core: intel-dsp-config: Add support for NVL-S
ALSA: hda: controllers: intel: add support for Nova Lake S
include/linux/pci_ids.h | 1 + include/sound/soc-acpi-intel-match.h | 2 + sound/hda/codecs/hdmi/intelhdmi.c | 1 + sound/hda/controllers/intel.c | 2 + sound/hda/core/intel-dsp-config.c | 8 ++ sound/soc/intel/common/Makefile | 1 + .../intel/common/soc-acpi-intel-nvl-match.c | 90 +++++++++++++++++++ sound/soc/sof/intel/Kconfig | 17 ++++ sound/soc/sof/intel/Makefile | 2 + sound/soc/sof/intel/hda-dsp.c | 1 + sound/soc/sof/intel/hda.h | 1 + sound/soc/sof/intel/nvl.c | 55 ++++++++++++ sound/soc/sof/intel/nvl.h | 14 +++ sound/soc/sof/intel/pci-nvl.c | 82 +++++++++++++++++ sound/soc/sof/intel/shim.h | 1 + 15 files changed, 278 insertions(+) create mode 100644 sound/soc/intel/common/soc-acpi-intel-nvl-match.c create mode 100644 sound/soc/sof/intel/nvl.c create mode 100644 sound/soc/sof/intel/nvl.h create mode 100644 sound/soc/sof/intel/pci-nvl.c
Signature · 1 line
2.51.2
Peter Ujfalusi
maintainerPATCH v2 1/7 PCI: Add Intel Nova Lake S audio Device ID
Add Nova Lake S (NVL-S) audio Device ID
The ID will be used by HDA legacy, SOF audio stack and the driver to determine which audio stack should be used (intel-dsp-config).
--- include/linux/pci_ids.h | 1 + 1 file changed, 1 insertion(+)
include/linux/pci_ids.h +1 -0
@@ -3075,6 +3075,7 @@#define PCI_DEVICE_ID_INTEL_5100_22 0x65f6#define PCI_DEVICE_ID_INTEL_IOAT_SCNB 0x65ff#define PCI_DEVICE_ID_INTEL_HDA_FCL 0x67a8 +#define PCI_DEVICE_ID_INTEL_HDA_NVL_S 0x6e50#define PCI_DEVICE_ID_INTEL_82371SB_0 0x7000#define PCI_DEVICE_ID_INTEL_82371SB_1 0x7010#define PCI_DEVICE_ID_INTEL_82371SB_2 0x7020
Signature · 1 line
2.51.2
Peter Ujfalusi
maintainerPATCH v2 2/7 ALSA: hda/hdmi: intelhdmi: add HDMI codec ID for Intel NVL
In reply to Peter UjfalusiAdd HDMI codec ID for Intel Nova Lake platform.
--- sound/hda/codecs/hdmi/intelhdmi.c | 1 + 1 file changed, 1 insertion(+)
sound/hda/codecs/hdmi/intelhdmi.c +1 -0
@@ -793,6 +793,7 @@ static const struct hda_device_id snd_hda_id_intelhdmi[] = {HDA_CODEC_ID_MODEL (0x80862820 ,"Lunar Lake HDMI" ,MODEL_ADLP ),HDA_CODEC_ID_MODEL (0x80862822 ,"Panther Lake HDMI" ,MODEL_ADLP ),HDA_CODEC_ID_MODEL (0x80862823 ,"Wildcat Lake HDMI" ,MODEL_ADLP ), +HDA_CODEC_ID_MODEL (0x80862824 ,"Nova Lake HDMI" ,MODEL_ADLP ),HDA_CODEC_ID_MODEL (0x80862882 ,"Valleyview2 HDMI" ,MODEL_BYT ), HDA_CODEC_ID_MODEL(0x80862883, "Braswell HDMI", MODEL_BYT), {} /* terminator */
Signature · 1 line
2.51.2
Peter Ujfalusi
maintainerPATCH v2 3/7 ASoC: Intel: soc-acpi: add NVL match tables
In reply to Peter UjfalusiFor now the tables are basic for mockup devices
--- include/sound/soc-acpi-intel-match.h | 2 + sound/soc/intel/common/Makefile | 1 + .../intel/common/soc-acpi-intel-nvl-match.c | 41 +++++++++++++++++++ 3 files changed, 44 insertions(+) create mode 100644 sound/soc/intel/common/soc-acpi-intel-nvl-match.c
include/sound/soc-acpi-intel-match.h +2 -0
@@ -34,6 +34,7 @@ extern struct snd_soc_acpi_mach snd_soc_acpi_intel_mtl_machines[];extern struct snd_soc_acpi_mach snd_soc_acpi_intel_lnl_machines[];extern struct snd_soc_acpi_mach snd_soc_acpi_intel_arl_machines[];extern struct snd_soc_acpi_mach snd_soc_acpi_intel_ptl_machines[]; +extern struct snd_soc_acpi_mach snd_soc_acpi_intel_nvl_machines[];extern struct snd_soc_acpi_mach snd_soc_acpi_intel_cnl_sdw_machines[];extern struct snd_soc_acpi_mach snd_soc_acpi_intel_cfl_sdw_machines[];
@@ -46,6 +47,7 @@ extern struct snd_soc_acpi_mach snd_soc_acpi_intel_mtl_sdw_machines[];extern struct snd_soc_acpi_mach snd_soc_acpi_intel_lnl_sdw_machines[];extern struct snd_soc_acpi_mach snd_soc_acpi_intel_arl_sdw_machines[];extern struct snd_soc_acpi_mach snd_soc_acpi_intel_ptl_sdw_machines[]; +extern struct snd_soc_acpi_mach snd_soc_acpi_intel_nvl_sdw_machines[];/* * generic table used for HDA codec-based platforms, possibly with
sound/soc/intel/common/Makefile +1 -0
@@ -11,6 +11,7 @@ snd-soc-acpi-intel-match-y := soc-acpi-intel-byt-match.o soc-acpi-intel-cht-matc soc-acpi-intel-arl-match.o \ soc-acpi-intel-lnl-match.o \ soc-acpi-intel-ptl-match.o \ + soc-acpi-intel-nvl-match.o \ soc-acpi-intel-hda-match.o \ soc-acpi-intel-sdw-mockup-match.o sof-function-topology-lib.o
sound/soc/intel/common/soc-acpi-intel-nvl-match.c new file +41 -0
41 lines not on this page · raw message
Signature · 1 line
2.51.2
Peter Ujfalusi
maintainerPATCH v2 4/7 ASoC: Intel: soc-acpi-intel-nvl-match: add rt722 l3 support
In reply to Peter UjfalusiFrom: Bard Liao <[email protected]>
Add rt722 on SDW link 3 support
--- .../intel/common/soc-acpi-intel-nvl-match.c | 49 +++++++++++++++++++ 1 file changed, 49 insertions(+)
sound/soc/intel/common/soc-acpi-intel-nvl-match.c +49 -0
@@ -15,6 +15,49 @@ struct snd_soc_acpi_mach snd_soc_acpi_intel_nvl_machines[] = { };EXPORT_SYMBOL_GPL (snd_soc_acpi_intel_nvl_machines); +/* +* Multi-function codecs with three endpoints created for +* headset, amp and dmic functions. +*/ +static const struct snd_soc_acpi_endpoint rt_mf_endpoints[] = { + { + .num =0 , + .aggregated =0 , + .group_position =0 , + .group_id =0 , + }, + { + .num =1 , + .aggregated =0 , + .group_position =0 , + .group_id =0 , + }, + { + .num =2 , + .aggregated =0 , + .group_position =0 , + .group_id =0 , + }, +}; + +static const struct snd_soc_acpi_adr_device rt722_3_single_adr[] = { + { + .adr =0x000330025d072201ull , + .num_endpoints =ARRAY_SIZE (rt_mf_endpoints), + .endpoints = rt_mf_endpoints, + .name_prefix ="rt722" + } +}; + +static const struct snd_soc_acpi_link_adr nvl_rt722_l3[] = { + { + .mask =BIT (3 ), + .num_adr =ARRAY_SIZE (rt722_3_single_adr), + .adr_d = rt722_3_single_adr, + }, + {} +}; +/* this table is used when there is no I2S codec present */ struct snd_soc_acpi_mach snd_soc_acpi_intel_nvl_sdw_machines[] = {/* mockup tests need to be first */
@@ -36,6 +79,12 @@ struct snd_soc_acpi_mach snd_soc_acpi_intel_nvl_sdw_machines[] = { .drv_name = "sof_sdw", .sof_tplg_filename = "sof-nvl-rt715-rt711-rt1308-mono.tplg", }, + { + .link_mask = BIT(3), + .links = nvl_rt722_l3, + .drv_name = "sof_sdw", + .sof_tplg_filename = "sof-nvl-rt722.tplg", + }, {}, };EXPORT_SYMBOL_GPL (snd_soc_acpi_intel_nvl_sdw_machines);
Signature · 1 line
2.51.2
Peter Ujfalusi
maintainerPATCH v2 5/7 ASoC: SOF: Intel: add initial support for NVL-S
In reply to Peter UjfalusiAdd support for Nova Lake S (NVL-S).
--- sound/soc/sof/intel/Kconfig | 17 ++++++++ sound/soc/sof/intel/Makefile | 2 + sound/soc/sof/intel/hda-dsp.c | 1 + sound/soc/sof/intel/hda.h | 1 + sound/soc/sof/intel/nvl.c | 55 +++++++++++++++++++++++ sound/soc/sof/intel/nvl.h | 14 ++++++ sound/soc/sof/intel/pci-nvl.c | 82 +++++++++++++++++++++++++++++++++++ sound/soc/sof/intel/shim.h | 1 + 8 files changed, 173 insertions(+) create mode 100644 sound/soc/sof/intel/nvl.c create mode 100644 sound/soc/sof/intel/nvl.h create mode 100644 sound/soc/sof/intel/pci-nvl.c
sound/soc/sof/intel/Kconfig +17 -0
@@ -300,6 +300,23 @@ config SND_SOC_SOF_PANTHERLAKE Say Y if you have such a device. If unsure select "N". +config SND_SOC_SOF_INTEL_NVL + tristate + select SND_SOC_SOF_HDA_COMMON + select SND_SOC_SOF_INTEL_SOUNDWIRE_LINK_BASELINE + select SND_SOC_SOF_IPC4 + select SND_SOC_SOF_INTEL_PTL + +config SND_SOC_SOF_NOVALAKE + tristate "SOF support for Novalake" + default SND_SOC_SOF_PCI + select SND_SOC_SOF_INTEL_NVL + help + This adds support for Sound Open Firmware for Intel(R) platforms + using the Novalake processors. + Say Y if you have such a device. + If unsure select "N". + config SND_SOC_SOF_HDA_COMMON tristate
sound/soc/sof/intel/Makefile +2 -0
@@ -39,6 +39,7 @@ snd-sof-pci-intel-tgl-y := pci-tgl.o tgl.o snd-sof-pci-intel-mtl-y := pci-mtl.o mtl.o snd-sof-pci-intel-lnl-y := pci-lnl.o lnl.o snd-sof-pci-intel-ptl-y := pci-ptl.o ptl.o +snd-sof-pci-intel-nvl-y := pci-nvl.o nvl.o obj-$(CONFIG_SND_SOC_SOF_MERRIFIELD) += snd-sof-pci-intel-tng.o obj-$(CONFIG_SND_SOC_SOF_INTEL_SKL) += snd-sof-pci-intel-skl.o
@@ -49,3 +50,4 @@ obj-$(CONFIG_SND_SOC_SOF_INTEL_TGL) += snd-sof-pci-intel-tgl.o obj-$(CONFIG_SND_SOC_SOF_INTEL_MTL) += snd-sof-pci-intel-mtl.o obj-$(CONFIG_SND_SOC_SOF_INTEL_LNL) += snd-sof-pci-intel-lnl.o obj-$(CONFIG_SND_SOC_SOF_INTEL_PTL) += snd-sof-pci-intel-ptl.o +obj-$(CONFIG_SND_SOC_SOF_INTEL_NVL) += snd-sof-pci-intel-nvl.o
sound/soc/sof/intel/hda-dsp.c +1 -0
@@ -70,6 +70,7 @@ static void hda_get_interfaces(struct snd_sof_dev *sdev, u32 *interface_mask)break ;case SOF_INTEL_ACE_2_0 :case SOF_INTEL_ACE_3_0 : +case SOF_INTEL_ACE_4_0 : interface_mask[SOF_DAI_DSP_ACCESS ] =BIT (SOF_DAI_INTEL_SSP ) |BIT (SOF_DAI_INTEL_DMIC ) |BIT (SOF_DAI_INTEL_HDA ) |BIT (SOF_DAI_INTEL_ALH );
sound/soc/sof/intel/hda.h +1 -0
@@ -936,6 +936,7 @@ extern const struct sof_intel_dsp_desc arl_s_chip_info;extern const struct sof_intel_dsp_desc lnl_chip_info;extern const struct sof_intel_dsp_desc ptl_chip_info;extern const struct sof_intel_dsp_desc wcl_chip_info; +extern const struct sof_intel_dsp_desc nvl_s_chip_info;/* Probes support */ #if IS_ENABLED (CONFIG_SND_SOC_SOF_HDA_PROBES )
sound/soc/sof/intel/nvl.c new file +55 -0
55 lines not on this page · raw message
sound/soc/sof/intel/nvl.h new file +14 -0
@@ -0,0 +1,14 @@ +/* SPDX-License-Identifier: (GPL-2.0-only OR BSD-3-Clause) */ +/* +* This file is provided under a dual BSD/GPLv2 license. When using or +* redistributing this file, you may do so under either license. +* +* Copyright(c) 2025 Intel Corporation +*/ + +#ifndef __SOF_INTEL_NVL_H +#define __SOF_INTEL_NVL_H + +int sof_nvl_set_ops (struct snd_sof_dev *sdev,struct snd_sof_dsp_ops *dsp_ops); + +#endif /* __SOF_INTEL_NVL_H */
sound/soc/sof/intel/pci-nvl.c new file +82 -0
82 lines not on this page · raw message
sound/soc/sof/intel/shim.h +1 -0
@@ -23,6 +23,7 @@ enum sof_intel_hw_ip_version {SOF_INTEL_ACE_1_0 ,/* MeteorLake */ SOF_INTEL_ACE_2_0 ,/* LunarLake */ SOF_INTEL_ACE_3_0 ,/* PantherLake */ + SOF_INTEL_ACE_4_0, /* NovaLake */ };/*
Signature · 1 line
2.51.2
Peter Ujfalusi
maintainerPATCH v2 6/7 ALSA: hda: core: intel-dsp-config: Add support for NVL-S
In reply to Peter UjfalusiSame recipes as PTL for NVL-S from the Nova Lake family.
--- sound/hda/core/intel-dsp-config.c | 8 ++++++++ 1 file changed, 8 insertions(+)
sound/hda/core/intel-dsp-config.c +8 -0
@@ -578,6 +578,14 @@ static const struct config_entry config_table[] = {#endif +/* Nova Lake */ +#if IS_ENABLED (CONFIG_SND_SOC_SOF_NOVALAKE ) + { + .flags = FLAG_SOF | FLAG_SOF_ONLY_IF_DMIC_OR_SOUNDWIRE, + .device = PCI_DEVICE_ID_INTEL_HDA_NVL_S, + }, +#endif + };static const struct config_entry *snd_intel_dsp_find_config
Signature · 1 line
2.51.2
Peter Ujfalusi
maintainerPATCH v2 7/7 ALSA: hda: controllers: intel: add support for Nova Lake S
In reply to Peter UjfalusiAdd NVL-S to the PCI-ID list.
--- sound/hda/controllers/intel.c | 2 ++ 1 file changed, 2 insertions(+)
sound/hda/controllers/intel.c +2 -0
@@ -2550,6 +2550,8 @@ static const struct pci_device_id azx_ids[] = { { PCI_DEVICE_DATA(INTEL, HDA_PTL_H, AZX_DRIVER_SKL | AZX_DCAPS_INTEL_LNL) },/* Wildcat Lake */ { PCI_DEVICE_DATA(INTEL, HDA_WCL, AZX_DRIVER_SKL | AZX_DCAPS_INTEL_LNL) }, +/* Nova Lake */ + { PCI_DEVICE_DATA(INTEL, HDA_NVL_S, AZX_DRIVER_SKL | AZX_DCAPS_INTEL_LNL) },/* Apollolake (Broxton-P) */ { PCI_DEVICE_DATA(INTEL, HDA_APL, AZX_DRIVER_SKL | AZX_DCAPS_INTEL_BROXTON) },/* Gemini-Lake */
Signature · 1 line
2.51.2
Péter Ujfalusi
maintainerHi Takashi,
Quoted 9 lines · Peter Ujfalusi
Hi,
Changes since v1:
- Add information for the users of the PCI ID
- Add Acked-by tag for thepci_ids.hfrom Bjorn
- Add Acked-by tags from Mark for the ASoC patchesThis series adds initial support for NVL-S from the Nova Lake family. NVL-S includes ACE4 audio subsystem, it has 2 DSP cores.
Would you consider to pick up this series for 6.19?
Quoted 36 lines
Regards,
Peter
---
Bard Liao (1):
ASoC: Intel: soc-acpi-intel-nvl-match: add rt722 l3 supportPeter Ujfalusi (6):
PCI: Add Intel Nova Lake S audio Device ID
ALSA: hda/hdmi: intelhdmi: add HDMI codec ID for Intel NVL
ASoC: Intel: soc-acpi: add NVL match tables
ASoC: SOF: Intel: add initial support for NVL-S
ALSA: hda: core: intel-dsp-config: Add support for NVL-S
ALSA: hda: controllers: intel: add support for Nova Lake Sinclude/linux/pci_ids.h | 1 + include/sound/soc-acpi-intel-match.h | 2 + sound/hda/codecs/hdmi/intelhdmi.c | 1 + sound/hda/controllers/intel.c | 2 + sound/hda/core/intel-dsp-config.c | 8 ++ sound/soc/intel/common/Makefile | 1 + .../intel/common/soc-acpi-intel-nvl-match.c | 90 +++++++++++++++++++ sound/soc/sof/intel/Kconfig | 17 ++++ sound/soc/sof/intel/Makefile | 2 + sound/soc/sof/intel/hda-dsp.c | 1 + sound/soc/sof/intel/hda.h | 1 + sound/soc/sof/intel/nvl.c | 55 ++++++++++++ sound/soc/sof/intel/nvl.h | 14 +++ sound/soc/sof/intel/pci-nvl.c | 82 +++++++++++++++++ sound/soc/sof/intel/shim.h | 1 + 15 files changed, 278 insertions(+) create mode 100644 sound/soc/intel/common/soc-acpi-intel-nvl-match.c create mode 100644 sound/soc/sof/intel/nvl.c create mode 100644 sound/soc/sof/intel/nvl.h create mode 100644 sound/soc/sof/intel/pci-nvl.c
Signature · 1 line
Péter
Quoted 11 lines · Péter Ujfalusi
Hi Takashi,
Quoted 7 lines · Peter Ujfalusi
Hi,
Changes since v1:
- Add information for the users of the PCI ID
- Add Acked-by tag for thepci_ids.hfrom Bjorn
- Add Acked-by tags from Mark for the ASoC patches
Quoted 4 lines
Quoted 2 lines
This series adds initial support for NVL-S from the Nova Lake family. NVL-S includes ACE4 audio subsystem, it has 2 DSP cores.
Would you consider to pick up this series for 6.19?
I wasn't in Cc and it was ASoC subject prefix, so I overlooked this series. Now pull to for-next branch.
thanks,
Takashi
Péter Ujfalusi
maintainerQuoted 13 lines · Takashi Iwai
Quoted 11 lines · Péter Ujfalusi
Hi Takashi,
Quoted 7 lines · Peter Ujfalusi
Hi,
Changes since v1:
- Add information for the users of the PCI ID
- Add Acked-by tag for thepci_ids.hfrom Bjorn
- Add Acked-by tags from Mark for the ASoC patches
Quoted 7 lines
Quoted 4 lines
Quoted 2 lines
This series adds initial support for NVL-S from the Nova Lake family. NVL-S includes ACE4 audio subsystem, it has 2 DSP cores.
Would you consider to pick up this series for 6.19?
I wasn't in Cc and it was ASoC subject prefix, so I overlooked this series. Now pull to for-next branch.
Oh, I'm sorry, it really appears to be the case, thank you and sorry for the mistake.
Signature · 1 line
Péter