Skip to contentSkip to conversation

Add config check for systems that do not support CONFIG_XFS_FS.

PATCH In review Stephen Bertram via ltp 2 participants 4 messages Nov 5, 2025 – Jan 8

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Add config check for systems that do not support CONFIG_XFS_FS.

---
 testcases/kernel/syscalls/file_attr/file_attr02.c | 4 ++++
 testcases/kernel/syscalls/file_attr/file_attr03.c | 4 ++++
 2 files changed, 8 insertions(+)
testcases/kernel/syscalls/file_attr/file_attr02.c +4 -0
index f6625985a..a1c459d30 100644
@@ -102,6 +102,10 @@ static struct tst_test test = {
 		},
 		{}
 	},
+	.needs_kconfigs = (const char *[]) {
+		"CONFIG_XFS_FS",
+		NULL
+	},
 	.bufs = (struct tst_buffers []) {
 		{&attr, .size = sizeof(struct file_attr)},
 		{}
testcases/kernel/syscalls/file_attr/file_attr03.c +4 -0
index 9ad779041..19a8e298d 100644
@@ -69,6 +69,10 @@ static struct tst_test test = {
 		{.type = "xfs"},
 		{}
 	},
+	.needs_kconfigs = (const char *[]) {
+		"CONFIG_XFS_FS",
+		NULL
+	},
 	.bufs = (struct tst_buffers []) {
 		{&attr, .size = sizeof(struct file_attr)},
 		{}
Signature · 5 lines
2.49.0


-- 
Mailing list info: https://lists.linux.it/listinfo/ltp
#1 lore raw

Hi!
There was a bug in the test library filesystem availability check, should have been fixed by:

commit 5e1e0e2d81e564df09542b7caa2a66928c05dd3a

Author: Cyril Hrubis <[email protected]>
Date:   Mon Oct 27 16:09:24 2025 +0100

lib/tst_test: Fix FS kernel supported check

Signature · 5 lines
Cyril Hrubis
[email protected]

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp
#2 lore raw

Hi!

Quoted 9 lines · Cyril Hrubis

Hi!
There was a bug in the test library filesystem availability check, should have been fixed by:

commit 5e1e0e2d81e564df09542b7caa2a66928c05dd3a

Author: Cyril Hrubis <[email protected]>
Date:   Mon Oct 27 16:09:24 2025 +0100

lib/tst_test: Fix FS kernel supported check

Should we reject the patch?

Signature · 7 lines
Andrea Cervesato
SUSE QE Automation Engineer Linux
[email protected]


-- 
Mailing list info: https://lists.linux.it/listinfo/ltp
#3 lore raw

Yes, please!
stephen
He/His/Him

Quoted 21 lines · Andrea Cervesato

Hi!

Quoted 9 lines · Cyril Hrubis

Hi!
There was a bug in the test library filesystem availability check, should have been fixed by:

commit 5e1e0e2d81e564df09542b7caa2a66928c05dd3a

Author: Cyril Hrubis <[email protected]>
Date:   Mon Oct 27 16:09:24 2025 +0100

lib/tst_test: Fix FS kernel supported check

Should we reject the patch?

--
Andrea Cervesato
SUSE QE Automation Engineer Linux
[email protected]

Signature · 1 line
Mailing list info: https://lists.linux.it/listinfo/ltp