Skip to contentSkip to conversation

mv_xor: some devm cleanups

PATCH Superseded Rosen Penev 2 participants 4 messages Nov 5, 2025 – Dec 23, 2025 dmaengine

v4 of 5 Superseded Latest is v5 →

lore
Share & tools
lore

Rosen Penev

author
#0 lore raw

v4 cover mv_xor: some devm cleanups

Some devm cleanups that are now possible.

It's interesting that this driver lacks a _remove function to free its resources...

v2: resent with dmaengine prefix
v3: add error handling for devm_clk_get_optional_enabled to potentially handle EPROBE_DEFER.
v4: remove request_irq based on feedback.

Rosen Penev (2):
dmaengine: mv_xor: use devm_platform_ioremap_resource
dmaengine: mv_xor: use devm_clk_get_optional_enabled

 drivers/dma/mv_xor.c | 34 +++++++++-------------------------
 1 file changed, 9 insertions(+), 25 deletions(-)

--
2.51.2

author
#1 lore raw

PATCH v4 1/2 dmaengine: mv_xor: use devm_platform_ioremap_resource

Simplifies probe slightly by removing explicit struct resource pointers and platform_get_resource calls.

Signed-off-by Rosen Penev <[email protected]>
---
 drivers/dma/mv_xor.c | 23 ++++++-----------------
 1 file changed, 6 insertions(+), 17 deletions(-)
drivers/dma/mv_xor.c +6 -17
index 5e8386296046..3597ad8d1220 100644
@@ -1309,7 +1309,6 @@ static int mv_xor_probe(struct platform_device *pdev)
 	const struct mbus_dram_target_info *dram;
 	struct mv_xor_device *xordev;
 	struct mv_xor_platform_data *pdata = dev_get_platdata(&pdev->dev);
-	struct resource *res;
 	unsigned int max_engines, max_channels;
 	int i, ret;
 

@@ -1319,23 +1318,13 @@ static int mv_xor_probe(struct platform_device *pdev)
 	if (!xordev)
 		return -ENOMEM;
 
-	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
-	if (!res)
-		return -ENODEV;
+	xordev->xor_base = devm_platform_ioremap_resource(pdev, 0);
+	if (IS_ERR(xordev->xor_base))
+		return PTR_ERR(xordev->xor_base);
 
-	xordev->xor_base = devm_ioremap(&pdev->dev, res->start,
-					resource_size(res));
-	if (!xordev->xor_base)
-		return -EBUSY;
-
-	res = platform_get_resource(pdev, IORESOURCE_MEM, 1);
-	if (!res)
-		return -ENODEV;
-
-	xordev->xor_high_base = devm_ioremap(&pdev->dev, res->start,
-					     resource_size(res));
-	if (!xordev->xor_high_base)
-		return -EBUSY;
+	xordev->xor_high_base = devm_platform_ioremap_resource(pdev, 1);
+	if (IS_ERR(xordev->xor_high_base))
+		return PTR_ERR(xordev->xor_high_base);
 
 	platform_set_drvdata(pdev, xordev);
Signature · 1 line
2.51.2
author
#2 lore raw

PATCH v4 2/2 dmaengine: mv_xor: use devm_clk_get_optional_enabled

In reply to Rosen Penev

Driver was written before this was available. Simplifies code slightly.

Actually also a bugfix. clk_disable_unprepare is missing in _remove, which is also missing.

Signed-off-by Rosen Penev <[email protected]>
---
 drivers/dma/mv_xor.c | 11 +++--------
 1 file changed, 3 insertions(+), 8 deletions(-)
drivers/dma/mv_xor.c +3 -8
index 3597ad8d1220..d15a1990534b 100644
@@ -1351,9 +1351,9 @@ static int mv_xor_probe(struct platform_device *pdev)
 	/* Not all platforms can gate the clock, so it is not
 	 * an error if the clock does not exists.
 	 */
-	xordev->clk = clk_get(&pdev->dev, NULL);
-	if (!IS_ERR(xordev->clk))
-		clk_prepare_enable(xordev->clk);
+	xordev->clk = devm_clk_get_optional_enabled(&pdev->dev, NULL);
+	if (IS_ERR(xordev->clk))
+		return PTR_ERR(xordev->clk);
 
 	/*
 	 * We don't want to have more than one channel per CPU in

@@ -1441,11 +1441,6 @@ static int mv_xor_probe(struct platform_device *pdev)
 				irq_dispose_mapping(xordev->channels[i]->irq);
 		}
 
-	if (!IS_ERR(xordev->clk)) {
-		clk_disable_unprepare(xordev->clk);
-		clk_put(xordev->clk);
-	}
-
 	return ret;
 }
Signature · 1 line
2.51.2
maintainer
#3 lore raw
In reply to Rosen Penev
Quoted 6 lines · Rosen Penev

Some devm cleanups that are now possible.

It's interesting that this driver lacks a _remove function to free its resources...

v2: resent with dmaengine prefix

Not required to add this in within []..
[PATCHv4 0/2] dmaengine: mv_xor.. would be fin

I cant apply this as it fails for me, please rebase

Quoted 13 lines

v3: add error handling for devm_clk_get_optional_enabled to potentially handle EPROBE_DEFER.
v4: remove request_irq based on feedback.

Rosen Penev (2):
dmaengine: mv_xor: use devm_platform_ioremap_resource
dmaengine: mv_xor: use devm_clk_get_optional_enabled

 drivers/dma/mv_xor.c | 34 +++++++++-------------------------
 1 file changed, 9 insertions(+), 25 deletions(-)

--
2.51.2

Signature · 1 line
~Vinod