arm64: dts: rockchip: Fix USB power enable pin for BTT CB2 and Pi2
Subsystems (2)
PATCH 1/1 arm64: dts: rockchip: Fix USB power enable pin for BTT CB2 and Pi2
Fix typo into regulator GPIO definition. With current
definition - USB powered off. Valid definition can be found on "pinctrl" section:
vcc5v0_usb2t_en: vcc5v0-usb2t-en {
rockchip,pins = <3 RK_PD5 RK_FUNC_GPIO &pcfg_pull_none>;
};
vcc5v0_usb2b_en: vcc5v0-usb2b-en {
rockchip,pins = <4 RK_PC4 RK_FUNC_GPIO &pcfg_pull_none>;
};
Fixes bfbc663d2733a ("arm64: dts: rockchip: Add BigTreeTech CB2 and Pi2")
Signed-off-by Andrey Leonchikov <[email protected]>
--- arch/arm64/boot/dts/rockchip/rk3566-bigtreetech-cb2.dtsi | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
arch/arm64/boot/dts/rockchip/rk3566-bigtreetech-cb2.dtsi +2 -2
@@ -187,7 +187,7 @@ vcc5v0_usb: regulator-vcc5v0-usb { vcc5v0_usb2b: regulator-vcc5v0-usb2b { compatible = "regulator-fixed"; enable-active-high; - gpio = <&gpio0 RK_PC4 GPIO_ACTIVE_HIGH>; + gpio = <&gpio4 RK_PC4 GPIO_ACTIVE_HIGH>; pinctrl-names = "default"; pinctrl-0 = <&vcc5v0_usb2b_en>; regulator-name = "vcc5v0_usb2b";
@@ -199,7 +199,7 @@ vcc5v0_usb2b: regulator-vcc5v0-usb2b { vcc5v0_usb2t: regulator-vcc5v0-usb2t { compatible = "regulator-fixed"; enable-active-high; - gpios = <&gpio0 RK_PD5 GPIO_ACTIVE_HIGH>; + gpios = <&gpio3 RK_PD5 GPIO_ACTIVE_HIGH>; pinctrl-names = "default"; pinctrl-0 = <&vcc5v0_usb2t_en>; regulator-name = "vcc5v0_usb2t";
Signature · 1 line
2.51.0
Review
Quoted 8 lines · Andrey Leonchikov
Fix typo into regulator GPIO definition. With current definition - USB powered off. Valid definition can be found on "pinctrl" section:
(quoted diff) +0
-0vcc5v0_usb2t_en: vcc5v0-usb2t-en { rockchip,pins = <3 RK_PD5 RK_FUNC_GPIO &pcfg_pull_none>; };
Applied, thanks!
[1/1] arm64: dts: rockchip: Fix USB power enable pin for BTT CB2 and Pi2
commit: a59e927ff46a967f84ddf94e89cbb045810e8974
Best regards,
Signature · 1 line
Heiko Stuebner <[email protected]>