socat: Update LICENSE field
PATCH 1/1 socat: Update LICENSE field
The below reference clearly states that GPL-2.0-with-OpenSSL-exception is to be used with GPL 2.0 or GPL3.0 and not as a standalone license. Therefore, update the correct license.
--- meta/recipes-connectivity/socat/socat_1.8.0.3.bb | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)
meta/recipes-connectivity/socat/socat_1.8.0.3.bb +3 -2
@@ -5,9 +5,10 @@ HOMEPAGE = "http://www.dest-unreach.org/socat/" SECTION = "console/network" -LICENSE = "GPL-2.0-with-OpenSSL-exception" +LICENSE = "GPL-2.0-only & GPL-2.0-with-OpenSSL-exception" LIC_FILES_CHKSUM = "file://COPYING;md5=b234ee4d69f5fce4486a80fdaf4a4263 \ - file://README;beginline=248;endline=278;md5=338c05eadd013872abb1d6e198e10a3f" + file://README;beginline=248;endline=278;md5=338c05eadd013872abb1d6e198e10a3f \ + file://COPYING.OpenSSL;md5=5c9bccc77f67a8328ef4ebaf468116f4" SRC_URI = "http://www.dest-unreach.org/socat/download/socat-${PV}.tar.bz2 \ file://0001-fix-compile-procan.c-failed.patch \
Signature · 1 line
2.34.1
Quoted 19 lines · Naman Jain via lists.openembedded.org
The below reference clearly states that GPL-2.0-with-OpenSSL-exception is to be used with GPL 2.0 or GPL3.0 and not as a standalone license. Therefore, update the correct license.
Signed-off-by Virendra Thakur <[email protected]>Signed-off-by Naman Jain <[email protected]>--- meta/recipes-connectivity/socat/socat_1.8.0.3.bb | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)meta/recipes-connectivity/socat/socat_1.8.0.3.bb +0
-0
meta/recipes-connectivity/socat/socat_1.8.0.3.bb HOMEPAGE = "http://www.dest-unreach.org/socat/" · line 8
Quoted 5 lines
meta/recipes-connectivity/socat/socat_1.8.0.3.bb +1
-1@@ -5,9 +5,10 @@ HOMEPAGE = "http://www.dest-unreach.org/socat/" SECTION = "console/network" -LICENSE = "GPL-2.0-with-OpenSSL-exception" +LICENSE = "GPL-2.0-only & GPL-2.0-with-OpenSSL-exception"
I don't think & here is really correct. If we were doing this in accordance with SPDX guidelines, it would be something like "GPL-2.0-only WITH OpenSSL-exception" or similar, but we don't (currently) support the WITH operator, or dsitinct license exceptions in general. However, our "GPL-2.0-with-OpenSSL-exception" is not just the exception (as scancode claims), but it is the complete license text; it also isn't a SPDX license identifier. I'm not sure why scancode is identifying as just the exception instead of the full license with the exception, I'm pretty sure that's the problem here, and adding in the GPL-2.0-only is not correct.
Quoted 19 lines
meta/recipes-connectivity/socat/socat_1.8.0.3.bb +2
-2LIC_FILES_CHKSUM = "file://COPYING;md5=b234ee4d69f5fce4486a80fdaf4a4263 \ - file://README;beginline=248;endline=278;md5=338c05eadd013872abb1d6e198e10a3f" + file://README;beginline=248;endline=278;md5=338c05eadd013872abb1d6e198e10a3f \ + file://COPYING.OpenSSL;md5=5c9bccc77f67a8328ef4ebaf468116f4" SRC_URI = "http://www.dest-unreach.org/socat/download/socat-${PV}.tar.bz2 \ file://0001-fix-compile-procan.c-failed.patch \ --2.34.1
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#226007): https://lists.openembedded.org/g/openembedded-core/message/226007
Mute This Topic: https://lists.openembedded.org/mt/116166040/3616693
Group Owner: [email protected]
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-
Hello,
I understand your point that GPL-2.0-with-OpenSSL-exception is generally treated as a complete combined license, and that Yocto doesn’t yet support the SPDX WITH operator. However, I’d like to highlight a similar precedent in cryptsetup, where the license field is defined as:
LICENSE = "LGPL-2.1-or-later & GPL-2.0-or-later & GPL-2.0-with-OpenSSL-exception"
That was discussed @KhemRaj before being merged I have attached the conversation for the reference, and was accepted to reflect that the codebase includes both plain GPL components and parts linking against OpenSSL (covered by the exception variant).
In our case, we are in a similar situation where both plain GPL-2.0 code and OpenSSL-linked code coexist. Therefore, expressing it as:
LICENSE = "GPL-2.0-only & GPL-2.0-with-OpenSSL-exception"
more accurately represents the license structure present in the source, even if GPL-2.0-with-OpenSSL-exception is itself a combined identifier.
Looping in Khem Raj here (added in CC) for his thoughts as well.
Quoted 68 lines · Joshua Watt,
Quoted 7 lines · Naman Jain via lists.openembedded.org
The below reference clearly states that GPL-2.0-with-OpenSSL-exception is to be used with GPL 2.0 or GPL3.0 and not as a standalone license. Therefore, update the correct license.
Reference:
Review
Quoted 8 lines
Signed-off-by Virendra Thakur <[email protected]>Signed-off-by Naman Jain <[email protected]>--- meta/recipes-connectivity/socat/socat_1.8.0.3.bb | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)(quoted diff) +0
-0b/meta/recipes-connectivity/socat/socat_1.8.0.3.bb
meta/recipes-connectivity/socat/socat_1.8.0.3.bb HOMEPAGE = "http://www.dest-unreach.org/socat/" · line 8
Quoted 9 lines
index
ee6ca1fe44..964af9d124100644meta/recipes-connectivity/socat/socat_1.8.0.3.bb +1
-1@@ -5,9 +5,10 @@ HOMEPAGE = "http://www.dest-unreach.org/socat/" SECTION = "console/network" -LICENSE = "GPL-2.0-with-OpenSSL-exception" +LICENSE = "GPL-2.0-only & GPL-2.0-with-OpenSSL-exception"I don't think & here is really correct. If we were doing this in accordance with SPDX guidelines, it would be something like "GPL-2.0-only WITH OpenSSL-exception" or similar, but we don't (currently) support the WITH operator, or dsitinct license exceptions in general. However, our "GPL-2.0-with-OpenSSL-exception" is not just the exception (as scancode claims), but it is the complete license text; it also isn't a SPDX license identifier. I'm not sure why scancode is identifying as just the exception instead of the full license with the exception, I'm pretty sure that's the problem here, and adding in the GPL-2.0-only is not correct.
meta/recipes-connectivity/socat/socat_1.8.0.3.bb HOMEPAGE = "http://www.dest-unreach.org/socat/" · line 9
Quoted 1 line
meta/recipes-connectivity/socat/socat_1.8.0.3.bb +0
-0LIC_FILES_CHKSUM = "file://COPYING;md5=b234ee4d69f5fce4486a80fdaf4a4263\
meta/recipes-connectivity/socat/socat_1.8.0.3.bb HOMEPAGE = "http://www.dest-unreach.org/socat/" · line 10
Quoted 1 line
meta/recipes-connectivity/socat/socat_1.8.0.3.bb +0
-1-file://README;beginline=248;endline=278;md5=338c05eadd013872abb1d6e198e10a3f"
meta/recipes-connectivity/socat/socat_1.8.0.3.bb HOMEPAGE = "http://www.dest-unreach.org/socat/" · line 10
Quoted 1 line
meta/recipes-connectivity/socat/socat_1.8.0.3.bb +1
-0+file://README;beginline=248;endline=278;md5=338c05eadd013872abb1d6e198e10a3f \
meta/recipes-connectivity/socat/socat_1.8.0.3.bb HOMEPAGE = "http://www.dest-unreach.org/socat/" · line 11
Quoted 1 line
meta/recipes-connectivity/socat/socat_1.8.0.3.bb +1
-0+file://COPYING.OpenSSL;md5=5c9bccc77f67a8328ef4ebaf468116f4"
meta/recipes-connectivity/socat/socat_1.8.0.3.bb HOMEPAGE = "http://www.dest-unreach.org/socat/" · line 12
Quoted 2 lines
meta/recipes-connectivity/socat/socat_1.8.0.3.bb +0
-0SRC_URI = "http://www.dest-unreach.org/socat/download/socat-${PV}.tar.bz2 \
Quoted 8 lines
meta/recipes-connectivity/socat/socat_1.8.0.3.bb +0
-1file://0001-fix-compile-procan.c-failed.patch \ --2.34.1
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group. View/Reply Online (#226007):https://lists.openembedded.org/g/openembedded-core/message/226007
Quoted 3 lines
Mute This Topic: https://lists.openembedded.org/mt/116166040/3616693
Group Owner: [email protected]
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [Quoted 2 lines
-=-=-=-=-=-=-=-=-=-=-=-
Quoted 15 lines · Naman Jain
Hello,
I understand your point thatGPL-2.0-with-OpenSSL-exceptionis generally treated as a complete combined license, and that Yocto doesn’t yet support the SPDXWITHoperator. However, I’d like to highlight a similar precedent incryptsetup, where the license field is defined as:LICENSE = "LGPL-2.1-or-later & GPL-2.0-or-later & GPL-2.0-with-OpenSSL-exception"
That was discussed @KhemRaj before being merged I have attached the conversation for the reference, and was accepted to reflect that the codebase includes both plain GPL components and parts linking against OpenSSL (covered by the exception variant).
In our case, we are in a similar situation where both plain GPL-2.0 code and OpenSSL-linked code coexist. Therefore, expressing it as:
Quoted 7 lines
LICENSE = "GPL-2.0-only & GPL-2.0-with-OpenSSL-exception"
more accurately represents the license structure present in the source, even if
GPL-2.0-with-OpenSSL-exceptionis itself a combined identifier.Looping in Khem Raj here (added in CC) for his thoughts as well.
I gave a similar response to Joshua's, I think we want to be fill in the SPDX gap until then I don't think we need to change the current semantics.
Quoted 72 lines · Joshua Watt,
Quoted 69 lines
Quoted 7 lines · Naman Jain via lists.openembedded.org
The below reference clearly states that GPL-2.0-with-OpenSSL-exception is to be used with GPL 2.0 or GPL3.0 and not as a standalone license. Therefore, update the correct license.
Reference:
Review
Quoted 8 lines
Signed-off-by Virendra Thakur <[email protected]>Signed-off-by Naman Jain <[email protected]>--- meta/recipes-connectivity/socat/socat_1.8.0.3.bb | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)(quoted diff) +0
-0b/meta/recipes-connectivity/socat/socat_1.8.0.3.bb
meta/recipes-connectivity/socat/socat_1.8.0.3.bb HOMEPAGE = "http://www.dest-unreach.org/socat/" · line 8
Quoted 9 lines
index
ee6ca1fe44..964af9d124100644meta/recipes-connectivity/socat/socat_1.8.0.3.bb +1
-1@@ -5,9 +5,10 @@ HOMEPAGE = "http://www.dest-unreach.org/socat/" SECTION = "console/network" -LICENSE = "GPL-2.0-with-OpenSSL-exception" +LICENSE = "GPL-2.0-only & GPL-2.0-with-OpenSSL-exception"I don't think & here is really correct. If we were doing this in accordance with SPDX guidelines, it would be something like "GPL-2.0-only WITH OpenSSL-exception" or similar, but we don't (currently) support the WITH operator, or dsitinct license exceptions in general. However, our "GPL-2.0-with-OpenSSL-exception" is not just the exception (as scancode claims), but it is the complete license text; it also isn't a SPDX license identifier. I'm not sure why scancode is identifying as just the exception instead of the full license with the exception, I'm pretty sure that's the problem here, and adding in the GPL-2.0-only is not correct.
meta/recipes-connectivity/socat/socat_1.8.0.3.bb HOMEPAGE = "http://www.dest-unreach.org/socat/" · line 9
Quoted 1 line
meta/recipes-connectivity/socat/socat_1.8.0.3.bb +0
-0LIC_FILES_CHKSUM ="file://COPYING;md5=b234ee4d69f5fce4486a80fdaf4a4263 \
meta/recipes-connectivity/socat/socat_1.8.0.3.bb HOMEPAGE = "http://www.dest-unreach.org/socat/" · line 10
Quoted 1 line
meta/recipes-connectivity/socat/socat_1.8.0.3.bb +0
-1-file://README;beginline=248;endline=278;md5=338c05eadd013872abb1d6e198e10a3f"
meta/recipes-connectivity/socat/socat_1.8.0.3.bb HOMEPAGE = "http://www.dest-unreach.org/socat/" · line 10
Quoted 1 line
meta/recipes-connectivity/socat/socat_1.8.0.3.bb +1
-0+file://README;beginline=248;endline=278;md5=338c05eadd013872abb1d6e198e10a3f \
meta/recipes-connectivity/socat/socat_1.8.0.3.bb HOMEPAGE = "http://www.dest-unreach.org/socat/" · line 11
Quoted 1 line
meta/recipes-connectivity/socat/socat_1.8.0.3.bb +1
-0+file://COPYING.OpenSSL;md5=5c9bccc77f67a8328ef4ebaf468116f4"
meta/recipes-connectivity/socat/socat_1.8.0.3.bb HOMEPAGE = "http://www.dest-unreach.org/socat/" · line 12
Quoted 2 lines
meta/recipes-connectivity/socat/socat_1.8.0.3.bb +0
-0SRC_URI = "http://www.dest-unreach.org/socat/download/socat-${PV}.tar.bz2 \
Quoted 8 lines
meta/recipes-connectivity/socat/socat_1.8.0.3.bb +0
-1file://0001-fix-compile-procan.c-failed.patch \ --2.34.1
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group. View/Reply Online (#226007):https://lists.openembedded.org/g/openembedded-core/message/226007
Quoted 3 lines
Mute This Topic: https://lists.openembedded.org/mt/116166040/3616693
Group Owner: [email protected]
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [Quoted 2 lines
-=-=-=-=-=-=-=-=-=-=-=-
Quoted 41 lines · Naman Jain,
The below reference clearly states that GPL-2.0-with-OpenSSL-exception is to be used with GPL 2.0 or GPL3.0 and not as a standalone license. Therefore, update the correct license.
Reference:
Signed-off-by Virendra Thakur <[email protected]>Signed-off-by Naman Jain <[email protected]>--- meta/recipes-connectivity/socat/socat_1.8.0.3.bb | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)meta/recipes-connectivity/socat/socat_1.8.0.3.bb +1
-2@@ -5,9 +5,10 @@ HOMEPAGE = "http://www.dest-unreach.org/socat/" SECTION = "console/network" -LICENSE = "GPL-2.0-with-OpenSSL-exception" +LICENSE = "GPL-2.0-only & GPL-2.0-with-OpenSSL-exception" LIC_FILES_CHKSUM = "file://COPYING;md5=b234ee4d69f5fce4486a80fdaf4a4263 \ -file://README;beginline=248;endline=278;md5=338c05eadd013872abb1d6e198e10a3f" + file://README;beginline=248;endline=278;md5=338c05eadd013872abb1d6e198e10a3f \
+
file://COPYING.OpenSSL;md5=5c9bccc77f67a8328ef4ebaf468116f4"
SRC_URI= "http://www.dest-unreach.org/socat/download/socat-${PV}.tar.bz2\ file://0001-fix-compile-procan.c-failed.patch \--
2.34.1