Skip to contentSkip to conversation

jfs: Initialize synclist in metapage allocation

PATCH In review [email protected] 2 participants 2 messages Nov 7, 2025 – Nov 8, 2025 JFS filesystem

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 jfs: Initialize synclist in metapage allocation

From: Shaurya Rane <[email protected]>

The synclist field in struct metapage was not being initialized during allocation in alloc_metapage(), leading to list corruption when the metapage is later added to a transaction's sync list.

When diUpdatePMap() calls list_add(&mp->synclist, &tblk->synclist), if the synclist field contains stale data from a previous allocation (such as LIST_POISON values from a freed list node), the list debugging code detects the corruption and triggers a stack segment fault.

This issue is intermittent because it only manifests when recycled memory happens to contain poison values in the synclist field. The bug was discovered by syzbot, which creates specific filesystem patterns that reliably trigger this uninitialized memory usage.

Initialize the synclist field with INIT_LIST_HEAD() in alloc_metapage() to ensure it's in a valid state before being used in list operations. This is consistent with how the wait queue is initialized in the same function.

---
Tested:
- Tested locally with syzbot reproducer, no errors observed

 fs/jfs/jfs_metapage.c | 1 +
 1 file changed, 1 insertion(+)
fs/jfs/jfs_metapage.c +1 -0
index 871cf4fb3636..77c512a0a42b 100644
@@ -269,6 +269,7 @@ static inline struct metapage *alloc_metapage(gfp_t gfp_mask)
 		mp->data = NULL;
 		mp->clsn = 0;
 		mp->log = NULL;
+		INIT_LIST_HEAD(&mp->synclist);
 		init_waitqueue_head(&mp->wait);
 	}
 	return mp;
Signature · 1 line
2.34.1