arm64: dts: rockchip: Make eeprom read-only for Radxa ROCK 3C
Subsystems (2)
PATCH 1/2 arm64: dts: rockchip: Make eeprom read-only for Radxa ROCK 3C
Make EEPROM read-only as it may contain factory-programmed board-specific data.
--- arch/arm64/boot/dts/rockchip/rk3566-rock-3c.dts | 1 + 1 file changed, 1 insertion(+)
arch/arm64/boot/dts/rockchip/rk3566-rock-3c.dts +1 -0
@@ -466,6 +466,7 @@ eeprom: eeprom@50 { compatible = "belling,bl24c16a", "atmel,24c16"; reg = <0x50>; pagesize = <16>; + read-only; }; };
Signature · 7 lines
2.43.0 _______________________________________________ Linux-rockchip mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-rockchip
PATCH 2/2 arm64: dts: rockchip: Make eeprom read-only for Radxa ROCK 5A
Make EEPROM read-only as it may contain factory-programmed board-specific data.
--- arch/arm64/boot/dts/rockchip/rk3588s-rock-5a.dts | 1 + 1 file changed, 1 insertion(+)
arch/arm64/boot/dts/rockchip/rk3588s-rock-5a.dts +1 -0
@@ -254,6 +254,7 @@ eeprom: eeprom@50 { compatible = "belling,bl24c16a", "atmel,24c16"; reg = <0x50>; pagesize = <16>; + read-only; }; };
Signature · 7 lines
2.43.0 _______________________________________________ Linux-rockchip mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-rockchip
Re: [PATCH 2/2] arm64: dts: rockchip: Make eeprom read-only for Radxa ROCK 5A
Hello Naoki,
Quoted 14 lines · FUKAUMI Naoki
Make EEPROM read-only as it may contain factory-programmed board-specific data.
Fixes 89c880808cff8 ("arm64: dts: rockchip: add I2C EEPROM to rock-5a")Signed-off-by FUKAUMI Naoki <[email protected]>--- arch/arm64/boot/dts/rockchip/rk3588s-rock-5a.dts | 1 + 1 file changed, 1 insertion(+)arch/arm64/boot/dts/rockchip/rk3588s-rock-5a.dts +0
-0
arch/arm64/boot/dts/rockchip/rk3588s-rock-5a.dts eeprom: eeprom@50 { · line 259
Quoted 6 lines
arch/arm64/boot/dts/rockchip/rk3588s-rock-5a.dts +1
-0@@ -254,6 +254,7 @@ eeprom: eeprom@50 { compatible = "belling,bl24c16a", "atmel,24c16"; reg = <0x50>; pagesize = <16>; + read-only; }; };
I've checked the board schematic and making this BL24C16 chip read-only makes sense to me. However, I think that the patch description should be expanded to contain a better description of what might be found in the chip, such as a factory-programmed MAC address. Also, providing a link to the board schematic, as a reference, would be a good idea.
With these remarks addressed in a v2, please feel free to include
Additionally, it would make sense to squash this patch and your other patch that addresses the ROCK 5C together. They're very similar and having them together in a single commit might actually help the people browsing the repository understand it better.
Re: [PATCH 2/2] arm64: dts: rockchip: Make eeprom read-only for Radxa ROCK 5A
Hi Dragan,
Thank you very much for your review!
Quoted 22 lines · Dragan Simic
Hello Naoki,
Quoted 19 lines · FUKAUMI Naoki
Make EEPROM read-only as it may contain factory-programmed board-specific data.
Fixes 89c880808cff8 ("arm64: dts: rockchip: add I2C EEPROM to rock-5a")Signed-off-by FUKAUMI Naoki <[email protected]>--- arch/arm64/boot/dts/rockchip/rk3588s-rock-5a.dts | 1 + 1 file changed, 1 insertion(+)arch/arm64/boot/dts/rockchip/rk3588s-rock-5a.dts +1
-0@@ -254,6 +254,7 @@ eeprom: eeprom@50 { compatible = "belling,bl24c16a", "atmel,24c16"; reg = <0x50>; pagesize = <16>; + read-only; };
Quoted 8 lines
arch/arm64/boot/dts/rockchip/rk3588s-rock-5a.dts eeprom: eeprom@50 { · line 259
Quoted 1 line
arch/arm64/boot/dts/rockchip/rk3588s-rock-5a.dts +0
-0};I've checked the board schematic and making this BL24C16 chip read-only makes sense to me. However, I think that the patch description should be expanded to contain a better description of what might be found in the chip, such as a factory-programmed MAC address. Also, providing a link to the board schematic, as a reference, would be a good idea.
----
arm64: dts: rockchip: Make eeprom read-only for Radxa ROCK 3C/5A/5C
Make the EEPROM[1][2][3] read-only. Board-specific data written to the EEPROM at the factory includes, but is not limited to, the SKU (~ product name), BOM version (~ board version), and MAC address.
[1] https://dl.radxa.com/rock3/docs/hw/3c/v1400/radxa_rock_3c_v1400_schematic.pdf p.13
[2] https://dl.radxa.com/rock5/5a/docs/hw/radxa_rock5a_V1.1_sch.pdf p.19
[3] https://dl.radxa.com/rock5/5c/docs/hw/v1100/radxa_rock_5c_schematic_v1100.pdf p.18
----
Quoted 8 lines
With these remarks addressed in a v2, please feel free to include
Reviewed-by Dragan Simic <[email protected]>Additionally, it would make sense to squash this patch and your other patch that addresses the ROCK 5C together. They're very similar and having them together in a single commit might actually help the people browsing the repository understand it better.
I'll drop eeprom patch from ROCK 5C v7 patch series, and squash eeprom patches for ROCK 3C/5A/5C.
Best regards,
--
FUKAUMI Naoki
Radxa Computer (Shenzhen) Co., Ltd.
Re: [PATCH 2/2] arm64: dts: rockchip: Make eeprom read-only for Radxa ROCK 5A
Quoted 30 lines · FUKAUMI Naoki
Quoted 20 lines · Dragan Simic
Quoted 19 lines · FUKAUMI Naoki
Make EEPROM read-only as it may contain factory-programmed board-specific data.
Fixes 89c880808cff8 ("arm64: dts: rockchip: add I2C EEPROM to rock-5a")Signed-off-by FUKAUMI Naoki <[email protected]>--- arch/arm64/boot/dts/rockchip/rk3588s-rock-5a.dts | 1 + 1 file changed, 1 insertion(+)arch/arm64/boot/dts/rockchip/rk3588s-rock-5a.dts +1
-0@@ -254,6 +254,7 @@ eeprom: eeprom@50 { compatible = "belling,bl24c16a", "atmel,24c16"; reg = <0x50>; pagesize = <16>; + read-only; };Quoted 8 lines
arch/arm64/boot/dts/rockchip/rk3588s-rock-5a.dts eeprom: eeprom@50 { · line 259
Quoted 1 line
arch/arm64/boot/dts/rockchip/rk3588s-rock-5a.dts +0
-0};I've checked the board schematic and making this BL24C16 chip read-only makes sense to me. However, I think that the patch description should be expanded to contain a better description of what might be found in the chip, such as a factory-programmed MAC address. Also, providing a link to the board schematic, as a reference, would be a good idea.
Quoted 6 lines
----
arm64: dts: rockchip: Make eeprom read-only for Radxa ROCK 3C/5A/5CMake the EEPROM[1][2][3] read-only. Board-specific data written to the EEPROM at the factory includes, but is not limited to, the SKU (~ product name), BOM version (~ board version), and MAC address.
Thanks for the improvements! I'd just suggest that the opening sentence above is rewritten like this:
Make the BL24C16 EEPROM chips found on Radxa ROCK 3C, 5A and 5C SBCs [1][2][3] read-only, because they contain factory- programmed data that isn't supposed to be modified by the end users.
This would also be perfect timing for Radxa to officially release the layout of the board-specific data that goes into these EPROM chips, so the data can actually be used.
Quoted 13 lines
[1]
https://dl.radxa.com/rock3/docs/hw/3c/v1400/radxa_rock_3c_v1400_schematic.pdf
p.13
[2] https://dl.radxa.com/rock5/5a/docs/hw/radxa_rock5a_V1.1_sch.pdf p.19
[3]
https://dl.radxa.com/rock5/5c/docs/hw/v1100/radxa_rock_5c_schematic_v1100.pdf
p.18
----Quoted 4 lines
With these remarks addressed in a v2, please feel free to include
Reviewed-by Dragan Simic <[email protected]>
Quoted 7 lines
Quoted 4 lines
Additionally, it would make sense to squash this patch and your other patch that addresses the ROCK 5C together. They're very similar and having them together in a single commit might actually help the people browsing the repository understand it better.
I'll drop eeprom patch from ROCK 5C v7 patch series, and squash eeprom patches for ROCK 3C/5A/5C.
Thanks!
Re: [PATCH 2/2] arm64: dts: rockchip: Make eeprom read-only for Radxa ROCK 5A
Hi Dragan,
Quoted 41 lines · Dragan Simic
Quoted 30 lines · FUKAUMI Naoki
Quoted 20 lines · Dragan Simic
Quoted 19 lines · FUKAUMI Naoki
Make EEPROM read-only as it may contain factory-programmed board-specific data.
Fixes 89c880808cff8 ("arm64: dts: rockchip: add I2C EEPROM to rock-5a")Signed-off-by FUKAUMI Naoki <[email protected]>--- arch/arm64/boot/dts/rockchip/rk3588s-rock-5a.dts | 1 + 1 file changed, 1 insertion(+)arch/arm64/boot/dts/rockchip/rk3588s-rock-5a.dts +1
-0@@ -254,6 +254,7 @@ eeprom: eeprom@50 { compatible = "belling,bl24c16a", "atmel,24c16"; reg = <0x50>; pagesize = <16>; + read-only; };Quoted 8 lines
arch/arm64/boot/dts/rockchip/rk3588s-rock-5a.dts eeprom: eeprom@50 { · line 259
Quoted 1 line
arch/arm64/boot/dts/rockchip/rk3588s-rock-5a.dts +0
-0};I've checked the board schematic and making this BL24C16 chip read-only makes sense to me. However, I think that the patch description should be expanded to contain a better description of what might be found in the chip, such as a factory-programmed MAC address. Also, providing a link to the board schematic, as a reference, would be a good idea.
Quoted 6 lines
----
arm64: dts: rockchip: Make eeprom read-only for Radxa ROCK 3C/5A/5CMake the EEPROM[1][2][3] read-only. Board-specific data written to the EEPROM at the factory includes, but is not limited to, the SKU (~ product name), BOM version (~ board version), and MAC address.
Thanks for the improvements! I'd just suggest that the opening sentence above is rewritten like this:
Quoted 8 lines
Make the BL24C16 EEPROM chips found on Radxa ROCK 3C, 5A and 5C SBCs [1][2][3] read-only, because they contain factory- programmed data that isn't supposed to be modified by the end users.
This would also be perfect timing for Radxa to officially release the layout of the board-specific data that goes into these EPROM chips, so the data can actually be used.
https://github.com/radxa/u-boot/blob/next-dev-v2024.10/drivers/misc/radxa-i2c-eeprom.c
The actual data in the EEPROMs of my boards has some content inconsistencies with the code descriptions, but the format is consistent. The SKU, BOM, and MAC mentioned previously should be available.
Best regards,
--
FUKAUMI Naoki
Radxa Computer (Shenzhen) Co., Ltd.
Quoted 24 lines
Quoted 13 lines
[1]
https://dl.radxa.com/rock3/docs/hw/3c/v1400/radxa_rock_3c_v1400_schematic.pdf
p.13
[2] https://dl.radxa.com/rock5/5a/docs/hw/radxa_rock5a_V1.1_sch.pdf p.19
[3]
https://dl.radxa.com/rock5/5c/docs/hw/v1100/radxa_rock_5c_schematic_v1100.pdf
p.18
----Quoted 4 lines
With these remarks addressed in a v2, please feel free to include
Reviewed-by Dragan Simic <[email protected]>Quoted 7 lines
Quoted 4 lines
Additionally, it would make sense to squash this patch and your other patch that addresses the ROCK 5C together. They're very similar and having them together in a single commit might actually help the people browsing the repository understand it better.
I'll drop eeprom patch from ROCK 5C v7 patch series, and squash eeprom patches for ROCK 3C/5A/5C.
Thanks!
Re: [PATCH 2/2] arm64: dts: rockchip: Make eeprom read-only for Radxa ROCK 5A
Hello Naoki,
Quoted 20 lines · FUKAUMI Naoki
Quoted 10 lines · Dragan Simic
Quoted 5 lines · FUKAUMI Naoki
arm64: dts: rockchip: Make eeprom read-only for Radxa ROCK 3C/5A/5C
Make the EEPROM[1][2][3] read-only. Board-specific data written to the EEPROM at the factory includes, but is not limited to, the SKU (~ product name), BOM version (~ board version), and MAC address.
Thanks for the improvements! I'd just suggest that the opening sentence above is rewritten like this:
Quoted 8 lines
Make the BL24C16 EEPROM chips found on Radxa ROCK 3C, 5A and 5C SBCs [1][2][3] read-only, because they contain factory- programmed data that isn't supposed to be modified by the end users.
This would also be perfect timing for Radxa to officially release the layout of the board-specific data that goes into these EPROM chips, so the data can actually be used.
Quoted 5 lines
https://github.com/radxa/u-boot/blob/next-dev-v2024.10/drivers/misc/radxa-i2c-eeprom.c
The actual data in the EEPROMs of my boards has some content inconsistencies with the code descriptions, but the format is consistent. The SKU, BOM, and MAC mentioned previously should be available.
I see, thanks. I'm wondering could U-Boot's drivers/misc/nvmem.c be used instead. It seems like the driver linked above includes quite a lot of code that's already present elsewhere in U-Boot.
Re: [PATCH 2/2] arm64: dts: rockchip: Make eeprom read-only for Radxa ROCK 5A
In reply to Dragan SimicHi Dragan,
On 11/10/25 16:38, Dragan Simic wrote:
(snip)>>> Additionally, it would make sense to squash this patch and your
Quoted 8 lines
Quoted 6 lines
Quoted 3 lines
other patch that addresses the ROCK 5C together. They're very similar and having them together in a single commit might actually help the people browsing the repository understand it better.
I'll drop eeprom patch from ROCK 5C v7 patch series, and squash eeprom patches for ROCK 3C/5A/5C.
Thanks!
I'm preparing a patch series for Radxa ROCK 5A and I just remembered that the eeprom node in 5a.dts is totally incorrect. The eeprom is on i2c0, not on i2c2.
I'm planning to include this eeprom fix as a part of the patch series for 5A.
Best regards,
--
FUKAUMI Naoki
Radxa Computer (Shenzhen) Co., Ltd.
Re: [PATCH 2/2] arm64: dts: rockchip: Make eeprom read-only for Radxa ROCK 5A
Quoted 9 lines · FUKAUMI Naoki
On 11/10/25 16:38, Dragan Simic wrote:
(snip)>>> Additionally, it would make sense to squash this patch and yourQuoted 7 lines
Quoted 6 lines
Quoted 3 lines
other patch that addresses the ROCK 5C together. They're very similar and having them together in a single commit might actually help the people browsing the repository understand it better.
I'll drop eeprom patch from ROCK 5C v7 patch series, and squash eeprom patches for ROCK 3C/5A/5C.
Quoted 8 lines
Quoted 1 line
Thanks!
I'm preparing a patch series for Radxa ROCK 5A and I just remembered that the eeprom node in
5a.dtsis totally incorrect. The eeprom is on i2c0, not on i2c2.I'm planning to include this eeprom fix as a part of the patch series for 5A.
You're right, and I managed to miss that during my review. :/
It would be good if you'd prepare and send a separate, two-patch series with just the I2C bus fix for the ROCK 5A and the squashed patch that makes the EEPROMs read-only on three boards. Reviewing and accepting large changes split into smaller portions is always easier.
Re: [PATCH 2/2] arm64: dts: rockchip: Make eeprom read-only for Radxa ROCK 5A
Hi Dragan,
Quoted 19 lines · Dragan Simic
Quoted 9 lines · FUKAUMI Naoki
On 11/10/25 16:38, Dragan Simic wrote:
(snip)>>> Additionally, it would make sense to squash this patch and yourQuoted 7 lines
Quoted 6 lines
Quoted 3 lines
other patch that addresses the ROCK 5C together. They're very similar and having them together in a single commit might actually help the people browsing the repository understand it better.
I'll drop eeprom patch from ROCK 5C v7 patch series, and squash eeprom patches for ROCK 3C/5A/5C.
Quoted 8 lines
Quoted 1 line
Thanks!
I'm preparing a patch series for Radxa ROCK 5A and I just remembered that the eeprom node in
5a.dtsis totally incorrect. The eeprom is on i2c0, not on i2c2.I'm planning to include this eeprom fix as a part of the patch series for 5A.
Quoted 7 lines
You're right, and I managed to miss that during my review. :/
It would be good if you'd prepare and send a separate, two-patch series with just the I2C bus fix for the ROCK 5A and the squashed patch that makes the EEPROMs read-only on three boards. Reviewing and accepting large changes split into smaller portions is always easier.
I see. I'll do it first.
Thank you very much for your advice!
Best regards,
--
FUKAUMI Naoki
Radxa Computer (Shenzhen) Co., Ltd.
Hello Naoki,
Quoted 14 lines · FUKAUMI Naoki
Make EEPROM read-only as it may contain factory-programmed board-specific data.
Fixes ee219017ddb50 ("arm64: dts: rockchip: Add Radxa ROCK 3C")Signed-off-by FUKAUMI Naoki <[email protected]>--- arch/arm64/boot/dts/rockchip/rk3566-rock-3c.dts | 1 + 1 file changed, 1 insertion(+)arch/arm64/boot/dts/rockchip/rk3566-rock-3c.dts +0
-0
arch/arm64/boot/dts/rockchip/rk3566-rock-3c.dts eeprom: eeprom@50 { · line 471
Quoted 6 lines
arch/arm64/boot/dts/rockchip/rk3566-rock-3c.dts +1
-0@@ -466,6 +466,7 @@ eeprom: eeprom@50 { compatible = "belling,bl24c16a", "atmel,24c16"; reg = <0x50>; pagesize = <16>; + read-only; }; };
I've checked the board schematic and making this BL24C16 chip read-only makes sense to me. However, I think that the patch description should be expanded to contain a better description of what might be found in the chip, such as a factory-programmed MAC address. Also, providing a link to the board schematic, as a reference, would be a good idea.
With these remarks addressed in a v2, please feel free to include