weston: Clean up PipeWire backend configuration and dependencies
PATCH 1/1 weston: Clean up PipeWire backend configuration and dependencies
- Remove redundant -Dpipewire=false from EXTRA_OEMESON.
The -Dpipewire flag is already controlled by PACKAGECONFIG[pipewire]. If 'pipewire' is not in PACKAGECONFIG, Meson will receive -Dbackend-pipewire=false automatically. Setting -Dpipewire=false unconditionally in EXTRA_OEMESON is redundant and may cause confusion.
- Add pipewire as a runtime dependency in PACKAGECONFIG[pipewire]. This ensures the PipeWire backend is properly enabled and the runtime dependency is present when selected.
--- meta/recipes-graphics/wayland/weston_14.0.2.bb | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
meta/recipes-graphics/wayland/weston_14.0.2.bb +2 -2
@@ -31,7 +31,7 @@ LDFLAGS += "${@bb.utils.contains('DISTRO_FEATURES', 'lto', '-Wl,-z,undefs', '', WESTON_MAJOR_VERSION = "${@'.'.join(d.getVar('PV').split('.')[0:1])}" -EXTRA_OEMESON += "-Dpipewire=false -Dtests=false" +EXTRA_OEMESON += "-Dtests=false" PACKAGECONFIG ??= "${@bb.utils.contains('DISTRO_FEATURES', 'wayland', 'kms wayland egl clients', '', d)} \ ${@bb.utils.contains('DISTRO_FEATURES', 'x11 wayland', 'xwayland', '', d)} \
@@ -90,7 +90,7 @@ PACKAGECONFIG[shell-kiosk] = "-Dshell-kiosk=true,-Dshell-kiosk=false" # JPEG image loading support PACKAGECONFIG[image-jpeg] = "-Dimage-jpeg=true,-Dimage-jpeg=false, jpeg" # screencasting via PipeWire -PACKAGECONFIG[pipewire] = "-Dbackend-pipewire=true,-Dbackend-pipewire=false,pipewire" +PACKAGECONFIG[pipewire] = "-Dbackend-pipewire=true,-Dbackend-pipewire=false,pipewire,pipewire" # VNC remote screensharing PACKAGECONFIG[vnc] = "-Dbackend-vnc=true,-Dbackend-vnc=false,neatvnc libpam"
Quoted 6 lines · Veeresh Kadasani via lists.openembedded.org
- Remove redundant -Dpipewire=false from
EXTRA_OEMESON.
The -Dpipewire flag is already controlled by PACKAGECONFIG[pipewire]. If 'pipewire' is not in PACKAGECONFIG, Meson will receive -Dbackend-pipewire=false automatically. Setting -Dpipewire=false unconditionally inEXTRA_OEMESONis redundant and may cause confusion.
Quoted 6 lines
- Add pipewire as a runtime dependency in PACKAGECONFIG[pipewire]. This ensures the PipeWire backend is properly enabled and the runtime dependency is present when selected.
Signed-off-by Veeresh Kadasani <[email protected]>---
Hi Veeresh,
Thanks for your patch.
It look like this is causing some build errors:
ERROR: lib32-weston-14.0.2-r0 do_configure: Execution of '/srv/pokybuild/yocto-worker/qemux86-world/build/build/tmp/work/x86-pokymllib32-linux/lib32-weston/14.0.2/temp/run.do_configure.577747' failed with exit code 1
...
| NOTE: Executing meson -Dtests=false -Dsimple-clients=all -Ddemo-clients=true -Drenderer-gl=true -Dbackend-headless=false -Dimage-jpeg=true -Dbackend-drm=true -Dcolor-management-lcms=false -Dbackend-pipewire=false -Dbackend-rdp=false -Dremoting=false -Dscreenshare=true -Dshell-desktop=true -Dshell-fullscreen=true -Dshell-ivi=true -Dshell-kiosk=true -Dsystemd=false -Dbackend-drm-screencast-vaapi=false -Dbackend-vnc=false -Dbackend-wayland=true -Dimage-webp=false -Dbackend-x11=true -Dxwayland=true...
...
| Run-time dependency libpipewire-0.3 found: NO (tried pkgconfig and cmake) | | ../sources/weston-14.0.2/pipewire/meson.build:12:2: ERROR: Problem encountered: Pipewire plugin requires libpipewire which was not found. If you rather not build this, set '-Dpipewire=false'.
https://autobuilder.yoctoproject.org/valkyrie/#/builders/59/builds/2719
https://autobuilder.yoctoproject.org/valkyrie/#/builders/25/builds/2706
https://autobuilder.yoctoproject.org/valkyrie/#/builders/17/builds/2551
Can you have a look at this issue?
Thanks,
Mathieu
Signature · 3 lines
Mathieu Dubois-Briand, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
PATCH v2 1/1 weston: Add PipeWire as runtime dependency
In reply to Veeresh Kadasani- Add pipewire as a runtime dependency in PACKAGECONFIG[pipewire]. This ensures the PipeWire backend is properly enabled and the runtime dependency is present when selected.
--- meta/recipes-graphics/wayland/weston_14.0.2.bb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
meta/recipes-graphics/wayland/weston_14.0.2.bb +1 -1
@@ -90,7 +90,7 @@ PACKAGECONFIG[shell-kiosk] = "-Dshell-kiosk=true,-Dshell-kiosk=false" # JPEG image loading support PACKAGECONFIG[image-jpeg] = "-Dimage-jpeg=true,-Dimage-jpeg=false, jpeg" # screencasting via PipeWire -PACKAGECONFIG[pipewire] = "-Dbackend-pipewire=true,-Dbackend-pipewire=false,pipewire" +PACKAGECONFIG[pipewire] = "-Dbackend-pipewire=true,-Dbackend-pipewire=false,pipewire,pipewire" # VNC remote screensharing PACKAGECONFIG[vnc] = "-Dbackend-vnc=true,-Dbackend-vnc=false,neatvnc libpam"