dt-bindings: arm: qcom: Add waveshare MIPI-DSI panels support
Subsystems (7)
PATCH 1/2 dt-bindings: arm: qcom: Add waveshare MIPI-DSI panels support
Device tree bindings for Waveshare MIPI-DSI panels of various sizes (5.0, 5.5, 7.0, 8.0, and 10.1). These panels require proper power sequencing via an external regulator and a backlight node for brightness control.
--- .../display/panel/waveshare,dsi-panel.yaml | 84 +++++++++++++++++++ ...waveshare,touchscreen-panel-regulator.yaml | 72 ++++++++++++++++ 2 files changed, 156 insertions(+) create mode 100644 Documentation/devicetree/bindings/display/panel/waveshare,dsi-panel.yaml create mode 100644 Documentation/devicetree/bindings/regulator/waveshare,touchscreen-panel-regulator.yaml
Documentation/devicetree/bindings/display/panel/waveshare,dsi-panel.yaml new file +84 -0
@@ -0,0 +1,84 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/display/panel/waveshare,dsi-panel.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Waveshare 10.1" DSI Touch Display Panel + +maintainers: + - Sudarshan Shetty <[email protected]> + +allOf: + - $ref: panel-common.yaml# + +properties: + compatible: + enum: + - waveshare,12.3-dsi-touch-a,4lane + - waveshare,10.1-dsi-touch-a + - waveshare,10.1-dsi-touch-a-4lane + - waveshare,10.1-dsi-touch-b + - waveshare,10.1-dsi-touch-b,4lane + - waveshare,9.0-dsi-touch-b + - waveshare,9.0-dsi-touch-b,4lane + - waveshare,8.8-dsi-touch-a + - waveshare,8.0-dsi-touch-a + - waveshare,8.0-dsi-touch-a-4lane + - waveshare,7.0-dsi-touch-a + - waveshare,7.0-dsi-touch-b + - waveshare,5.5-dsi-touch-a + - waveshare,5.0-dsi-touch-a + - waveshare,4.0-dsi-touch-c + - waveshare,3.4-dsi-touch-c + + reg: + description: DSI virtual channel + maxItems: 1 + + vdd-supply: + description: Power supply regulator for the panel + + reset-gpios: + maxItems: 1 + description: GPIO to control panel reset + + enable-gpios: + maxItems: 1 + description: GPIO to control panel power enable + +required: + - compatible + - reg + - vdd-supply + - reset-gpios + - enable-gpios + +unevaluatedProperties: false + +examples: + - | + #include <dt-bindings/gpio/gpio.h> + + dsi@ae94000 { + #address-cells = <1>; + #size-cells = <0>; + + panel@1 { + compatible = "waveshare,10.1-dsi-touch-a"; + reg = <1>; + vdd-supply = <&vreg_l11a>; + reset-gpios = <&display_mcu 1 GPIO_ACTIVE_HIGH>; + enable-gpios = <&display_mcu 2 GPIO_ACTIVE_HIGH>; + + port { + panel_in: endpoint { + remote-endpoint = <&mdss_dsi0_out>; + }; + }; + }; + }; + + mdss_dsi0_out: endpoint { + remote-endpoint = <&panel_in>; + };
Documentation/devicetree/bindings/regulator/waveshare,touchscreen-panel-regulator.yaml new file +72 -0
72 lines not on this page · raw message
Signature · 1 line
2.34.1
PATCH 2/2 arm64: dts: qcom: Add support to validate direct DSI
Adds device tree support for the Waveshare 10.1-inch MIPI-DSI panel on the QCS615 talos evk platform.
--- arch/arm64/boot/dts/qcom/Makefile | 1 + arch/arm64/boot/dts/qcom/talos-evk-dsi.dts | 43 ++++++++++++++++++++++ 2 files changed, 44 insertions(+) create mode 100644 arch/arm64/boot/dts/qcom/talos-evk-dsi.dts
arch/arm64/boot/dts/qcom/Makefile +1 -0
@@ -306,6 +306,7 @@ dtb-$(CONFIG_ARCH_QCOM) += sm8650-qrd.dtb dtb-$(CONFIG_ARCH_QCOM) += sm8750-mtp.dtb dtb-$(CONFIG_ARCH_QCOM) += sm8750-qrd.dtb dtb-$(CONFIG_ARCH_QCOM) += talos-evk.dtb +dtb-$(CONFIG_ARCH_QCOM) += talos-evk-dsi.dtb x1e001de-devkit-el2-dtbs := x1e001de-devkit.dtb x1-el2.dtbo dtb-$(CONFIG_ARCH_QCOM) += x1e001de-devkit.dtb x1e001de-devkit-el2.dtb x1e78100-lenovo-thinkpad-t14s-el2-dtbs := x1e78100-lenovo-thinkpad-t14s.dtb x1-el2.dtbo
arch/arm64/boot/dts/qcom/talos-evk-dsi.dts new file +43 -0
43 lines not on this page · raw message
Signature · 1 line
2.34.1
Re: [PATCH v1 2/2] arm64: dts: qcom: Add support to validate direct DSI
Quoted 2 lines · Sudarshan Shetty
Adds device tree support for the Waveshare 10.1-inch MIPI-DSI panel on the QCS615 talos evk platform.
Why is this a board? Panel is a hat or sort of addon, so overlay, not a board.
Quoted 31 lines
Signed-off-by Sudarshan Shetty <[email protected]>--- arch/arm64/boot/dts/qcom/Makefile | 1 + arch/arm64/boot/dts/qcom/talos-evk-dsi.dts | 43 ++++++++++++++++++++++ 2 files changed, 44 insertions(+) create mode 100644 arch/arm64/boot/dts/qcom/talos-evk-dsi.dtsarch/arm64/boot/dts/qcom/Makefile +1
-0@@ -306,6 +306,7 @@ dtb-$(CONFIG_ARCH_QCOM) += sm8650-qrd.dtb dtb-$(CONFIG_ARCH_QCOM) += sm8750-mtp.dtb dtb-$(CONFIG_ARCH_QCOM) += sm8750-qrd.dtb dtb-$(CONFIG_ARCH_QCOM) += talos-evk.dtb +dtb-$(CONFIG_ARCH_QCOM) += talos-evk-dsi.dtb x1e001de-devkit-el2-dtbs := x1e001de-devkit.dtb x1-el2.dtbo dtb-$(CONFIG_ARCH_QCOM) += x1e001de-devkit.dtb x1e001de-devkit-el2.dtb x1e78100-lenovo-thinkpad-t14s-el2-dtbs := x1e78100-lenovo-thinkpad-t14s.dtb x1-el2.dtboarch/arm64/boot/dts/qcom/talos-evk-dsi.dts new file +5
-0@@ -0,0 +1,43 @@ +// SPDX-License-Identifier: BSD-3-Clause +/* + * Copyright (c) Qualcomm Technologies, Inc. and/or its subsidiaries. + */ +/dts-v1/;
arch/arm64/boot/dts/qcom/talos-evk-dsi.dts line 15
Quoted 10 lines
arch/arm64/boot/dts/qcom/talos-evk-dsi.dts new file +10
-0+ +#include "talos-evk-cb.dtsi" + +&i2c1 { + clock-frequency = <400000>; + + status = "okay"; + + display_mcu: display-mcu@45 { + compatible = "waveshare,touchscreen-panel-regulator";
It does not look like you tested the DTS against bindings. Please run make dtbs_check W=1 (see Documentation/devicetree/bindings/writing-schema.rst or
https://www.linaro.org/blog/tips-and-tricks-for-validating-devicetree-sources-with-the-devicetree-schema/
for instructions).
Maybe you need to update your dtschema and yamllint. Don't rely on distro packages for dtschema and be sure you are using the latest released dtschema.
Best regards,
Krzysztof
Re: [PATCH v1 2/2] arm64: dts: qcom: Add support to validate direct DSI
Quoted 6 lines · Krzysztof Kozlowski
Quoted 2 lines · Sudarshan Shetty
Adds device tree support for the Waveshare 10.1-inch MIPI-DSI panel on the QCS615 talos evk platform.
Why is this a board? Panel is a hat or sort of addon, so overlay, not a board.
Don't waste your time. The developer completely ignored review on the internal mailing list. I don't see a reason to believe that your review won't get ignored.
Quoted 56 lines
Quoted 32 lines
Signed-off-by Sudarshan Shetty <[email protected]>--- arch/arm64/boot/dts/qcom/Makefile | 1 + arch/arm64/boot/dts/qcom/talos-evk-dsi.dts | 43 ++++++++++++++++++++++ 2 files changed, 44 insertions(+) create mode 100644 arch/arm64/boot/dts/qcom/talos-evk-dsi.dtsarch/arm64/boot/dts/qcom/Makefile +1
-0@@ -306,6 +306,7 @@ dtb-$(CONFIG_ARCH_QCOM) += sm8650-qrd.dtb dtb-$(CONFIG_ARCH_QCOM) += sm8750-mtp.dtb dtb-$(CONFIG_ARCH_QCOM) += sm8750-qrd.dtb dtb-$(CONFIG_ARCH_QCOM) += talos-evk.dtb +dtb-$(CONFIG_ARCH_QCOM) += talos-evk-dsi.dtb x1e001de-devkit-el2-dtbs := x1e001de-devkit.dtb x1-el2.dtbo dtb-$(CONFIG_ARCH_QCOM) += x1e001de-devkit.dtb x1e001de-devkit-el2.dtb x1e78100-lenovo-thinkpad-t14s-el2-dtbs := x1e78100-lenovo-thinkpad-t14s.dtb x1-el2.dtboarch/arm64/boot/dts/qcom/talos-evk-dsi.dts new file +5
-0@@ -0,0 +1,43 @@ +// SPDX-License-Identifier: BSD-3-Clause +/* + * Copyright (c) Qualcomm Technologies, Inc. and/or its subsidiaries. + */ +/dts-v1/;arch/arm64/boot/dts/qcom/talos-evk-dsi.dts line 15
Quoted 10 lines
arch/arm64/boot/dts/qcom/talos-evk-dsi.dts new file +10
-0+ +#include "talos-evk-cb.dtsi" + +&i2c1 { + clock-frequency = <400000>; + + status = "okay"; + + display_mcu: display-mcu@45 { + compatible = "waveshare,touchscreen-panel-regulator";It does not look like you tested the DTS against bindings. Please run
make dtbs_check W=1(seeDocumentation/devicetree/bindings/writing-schema.rstor
https://www.linaro.org/blog/tips-and-tricks-for-validating-devicetree-sources-with-the-devicetree-schema/
for instructions).
Maybe you need to update your dtschema and yamllint. Don't rely on distro packages for dtschema and be sure you are using the latest released dtschema.Best regards,
Krzysztof
Signature · 2 lines
With best wishes Dmitry
Bjorn Andersson
maintainerRe: [PATCH v1 2/2] arm64: dts: qcom: Add support to validate direct DSI
In reply to Sudarshan ShettyOn Tue, Nov 11, 2025 at 04:12:45PM +0530, Sudarshan Shetty wrote:
The subject indicates that you're adding support for validating DSI to all Qualcomm boards. Rewrite this to be more specific.
arch/arm64/boot/dts/qcom/talos-evk-dsi.dts
Quoted 27 lines
Adds device tree support for the Waveshare 10.1-inch MIPI-DSI panel on the QCS615 talos evk platform.
Signed-off-by Sudarshan Shetty <[email protected]>--- arch/arm64/boot/dts/qcom/Makefile | 1 + arch/arm64/boot/dts/qcom/talos-evk-dsi.dts | 43 ++++++++++++++++++++++ 2 files changed, 44 insertions(+) create mode 100644 arch/arm64/boot/dts/qcom/talos-evk-dsi.dtsarch/arm64/boot/dts/qcom/Makefile +1
-0@@ -306,6 +306,7 @@ dtb-$(CONFIG_ARCH_QCOM) += sm8650-qrd.dtb dtb-$(CONFIG_ARCH_QCOM) += sm8750-mtp.dtb dtb-$(CONFIG_ARCH_QCOM) += sm8750-qrd.dtb dtb-$(CONFIG_ARCH_QCOM) += talos-evk.dtb +dtb-$(CONFIG_ARCH_QCOM) += talos-evk-dsi.dtb x1e001de-devkit-el2-dtbs := x1e001de-devkit.dtb x1-el2.dtbo dtb-$(CONFIG_ARCH_QCOM) += x1e001de-devkit.dtb x1e001de-devkit-el2.dtb x1e78100-lenovo-thinkpad-t14s-el2-dtbs := x1e78100-lenovo-thinkpad-t14s.dtb x1-el2.dtboarch/arm64/boot/dts/qcom/talos-evk-dsi.dts new file +0
-0
This isn't the one and only "EVK with DSI support" board. Please follow other examples and describe the connected panel as a overlay - and be specific.
This should likely be talos-evk-waveshare-10.3.dtso - so that one can support other DSI panels...
arch/arm64/boot/dts/qcom/talos-evk-dsi.dts line 7
Quoted 8 lines
arch/arm64/boot/dts/qcom/talos-evk-dsi.dts new file +7
-0@@ -0,0 +1,43 @@ +// SPDX-License-Identifier: BSD-3-Clause +/* + * Copyright (c) Qualcomm Technologies, Inc. and/or its subsidiaries. + */ +/dts-v1/; + +#include "talos-evk-cb.dtsi"
This file doesn't exist, please make sure you structure your patches such that we don't have multiple discussions about the same topic in parallel.
Quoted 13 lines
arch/arm64/boot/dts/qcom/talos-evk-dsi.dts new file +13
-0+ +&i2c1 { + clock-frequency = <400000>; + + status = "okay"; + + display_mcu: display-mcu@45 { + compatible = "waveshare,touchscreen-panel-regulator"; + reg = <0x45>; + gpio-controller; + #gpio-cells = <2>; + enable-gpio = <&display_mcu 2 GPIO_ACTIVE_HIGH>; + };
arch/arm64/boot/dts/qcom/talos-evk-dsi.dts line 30
Quoted 10 lines
arch/arm64/boot/dts/qcom/talos-evk-dsi.dts new file +10
-0+}; + +&mdss_dsi0 { + vdda-supply = <&vreg_l11a>; + status = "okay"; + + dsi_panel: dsi-panel@1 { + reg = <1>; + compatible = "waveshare,10.1-dsi-touch-a"; + reset-gpio = <&display_mcu 1 GPIO_ACTIVE_HIGH>;
Can you confirm that this actually works?
Based on the Waveshare "example" driver I had to enable pins 0, 1, and 4 to make my 12.3 DSI panel to work on my board, and then pin 9 to make the Goodix touchpad work.
Speaking of which, I want the touchscreen support added in the same patch.
Regards,
Bjorn
Quoted 16 lines
arch/arm64/boot/dts/qcom/talos-evk-dsi.dts new file +13
-0+ backlight = <&display_mcu>; + + port { + panel_in: endpoint { + remote-endpoint = <&mdss_dsi0_out>; + }; + }; + }; +}; + +&mdss_dsi0_out { + remote-endpoint = <&panel_in>; +};Signature · 1 line
2.34.1
Quoted 2 lines · Sudarshan Shetty
Device tree bindings for Waveshare MIPI-DSI panels of various sizes (5.0, 5.5, 7.0, 8.0, and 10.1).
Please wrap commit message according to Linux coding style / submission process (neither too early nor over the limit):
https://elixir.bootlin.com/linux/v6.4-rc1/source/Documentation/process/submitting-patches.rst#L597
Quoted 7 lines
These panels require proper power sequencing via an external regulator and a backlight node for brightness control.
Signed-off-by Sudarshan Shetty <[email protected]>--- .../display/panel/waveshare,dsi-panel.yaml | 84 +++++++++++++++++++ ...waveshare,touchscreen-panel-regulator.yaml | 72 ++++++++++++++++
Do not mix up patches from different subsystems into one patchset.
Quoted 4 lines
2 files changed, 156 insertions(+) create mode 100644 Documentation/devicetree/bindings/display/panel/waveshare,dsi-panel.yaml create mode 100644 Documentation/devicetree/bindings/regulator/waveshare,touchscreen-panel-regulator.yaml
Please use subject prefixes matching the subsystem. You can get them for example with git log --oneline -- DIRECTORY_OR_FILE on the directory your patch is touching. For bindings, the preferred subjects are explained here:
https://www.kernel.org/doc/html/latest/devicetree/bindings/submitting-patches.html#i-for-patch-submitters
Quoted 29 lines
Documentation/devicetree/bindings/display/panel/waveshare,dsi-panel.yaml new file +23
-0@@ -0,0 +1,84 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/display/panel/waveshare,dsi-panel.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Waveshare 10.1" DSI Touch Display Panel + +maintainers: + - Sudarshan Shetty <[email protected]> + +allOf: + - $ref: panel-common.yaml# + +properties: + compatible: + enum: + - waveshare,12.3-dsi-touch-a,4lane + - waveshare,10.1-dsi-touch-a + - waveshare,10.1-dsi-touch-a-4lane + - waveshare,10.1-dsi-touch-b + - waveshare,10.1-dsi-touch-b,4lane + - waveshare,9.0-dsi-touch-b
Documentation/devicetree/bindings/display/panel/waveshare,dsi-panel.yaml line 33
Quoted 10 lines
Documentation/devicetree/bindings/display/panel/waveshare,dsi-panel.yaml new file +10
-0+ - waveshare,9.0-dsi-touch-b,4lane + - waveshare,8.8-dsi-touch-a + - waveshare,8.0-dsi-touch-a + - waveshare,8.0-dsi-touch-a-4lane + - waveshare,7.0-dsi-touch-a + - waveshare,7.0-dsi-touch-b + - waveshare,5.5-dsi-touch-a + - waveshare,5.0-dsi-touch-a + - waveshare,4.0-dsi-touch-c + - waveshare,3.4-dsi-touch-c
None of these come with any reasonable model names? How so?
Quoted 41 lines
Documentation/devicetree/bindings/display/panel/waveshare,dsi-panel.yaml new file +41
-0+ + reg: + description: DSI virtual channel + maxItems: 1 + + vdd-supply: + description: Power supply regulator for the panel + + reset-gpios: + maxItems: 1 + description: GPIO to control panel reset + + enable-gpios: + maxItems: 1 + description: GPIO to control panel power enable + +required: + - compatible + - reg + - vdd-supply + - reset-gpios + - enable-gpios + +unevaluatedProperties: false + +examples: + - | + #include <dt-bindings/gpio/gpio.h> + + dsi@ae94000 { + #address-cells = <1>; + #size-cells = <0>; + + panel@1 { + compatible = "waveshare,10.1-dsi-touch-a"; + reg = <1>; + vdd-supply = <&vreg_l11a>; + reset-gpios = <&display_mcu 1 GPIO_ACTIVE_HIGH>; + enable-gpios = <&display_mcu 2 GPIO_ACTIVE_HIGH>; + + port {
Documentation/devicetree/bindings/display/panel/waveshare,dsi-panel.yaml line 84
Quoted 10 lines
Documentation/devicetree/bindings/display/panel/waveshare,dsi-panel.yaml new file +10
-0+ panel_in: endpoint { + remote-endpoint = <&mdss_dsi0_out>; + }; + }; + }; + }; + + mdss_dsi0_out: endpoint { + remote-endpoint = <&panel_in>; + };
Drop node, not relevant here.
Quoted 8 lines
Documentation/devicetree/bindings/regulator/waveshare,touchscreen-panel-regulator.yaml new file +2
-0@@ -0,0 +1,72 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2
Documentation/devicetree/bindings/regulator/waveshare,touchscreen-panel-regulator.yaml line 12
Quoted 10 lines
Documentation/devicetree/bindings/regulator/waveshare,touchscreen-panel-regulator.yaml new file +10
-0+--- +$id: http://devicetree.org/schemas/regulator/waveshare,touchscreen-panel-regulator.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Waveshare Touchscreen Panel Regulator + +maintainers: + - Sudarshan Shetty <[email protected]> + +description: |
Do not need '|' unless you need to preserve formatting.
Documentation/devicetree/bindings/regulator/waveshare,touchscreen-panel-regulator.yaml line 13
Quoted 1 line
Documentation/devicetree/bindings/regulator/waveshare,touchscreen-panel-regulator.yaml new file +1
-0+ Regulator driver for Waveshare touchscreen display units.
Driver as Linux driver?
Documentation/devicetree/bindings/regulator/waveshare,touchscreen-panel-regulator.yaml line 19
Quoted 6 lines
Documentation/devicetree/bindings/regulator/waveshare,touchscreen-panel-regulator.yaml new file +6
-0+ This regulator enables and disables panel power and provides + backlight control over I2C. + +properties: + compatible: + const: waveshare,touchscreen-panel-regulator
That's way too generic. Description doesn't tell me much more what is this hardware.
How is so that a device with specific programming model over I2C has no name, no model, absolutely nothing which would identify that programming model?
Documentation/devicetree/bindings/regulator/waveshare,touchscreen-panel-regulator.yaml line 23
Quoted 4 lines
Documentation/devicetree/bindings/regulator/waveshare,touchscreen-panel-regulator.yaml new file +4
-0+ + reg: + maxItems: 1 + description: I2C address of the regulator device
Drop description, redundant.
Quoted 11 lines
Documentation/devicetree/bindings/regulator/waveshare,touchscreen-panel-regulator.yaml new file +11
-0+ + vin-supply: + description: Input supply regulator for the panel + + enable-gpios: + maxItems: 1 + description: GPIO to enable/disable regulator + +required: + - compatible + - reg
Documentation/devicetree/bindings/regulator/waveshare,touchscreen-panel-regulator.yaml line 44
Quoted 10 lines
Documentation/devicetree/bindings/regulator/waveshare,touchscreen-panel-regulator.yaml new file +10
-0+ - vin-supply + +additionalProperties: false + +examples: + - | + /dts-v1/; + /plugin/; + + / {
Drop all this. Look at existing bindings first, how this is written. There is no single file like that. Please do not come up with your own style.
Best regards,
Krzysztof
Rob Herring (Arm)
maintainerQuoted 5 lines · Sudarshan Shetty
Device tree bindings for Waveshare MIPI-DSI panels of various sizes (5.0, 5.5, 7.0, 8.0, and 10.1). These panels require proper power sequencing via an external regulator and a backlight node for brightness control.
Quoted 8 lines
Signed-off-by Sudarshan Shetty <[email protected]>--- .../display/panel/waveshare,dsi-panel.yaml | 84 +++++++++++++++++++ ...waveshare,touchscreen-panel-regulator.yaml | 72 ++++++++++++++++ 2 files changed, 156 insertions(+) create mode 100644 Documentation/devicetree/bindings/display/panel/waveshare,dsi-panel.yaml create mode 100644 Documentation/devicetree/bindings/regulator/waveshare,touchscreen-panel-regulator.yaml
My bot found errors running 'make dt_binding_check' on your patch:
yamllint warnings/errors:
dtschema/dtc warnings/errors:
Documentation/devicetree/bindings/regulator/waveshare,touchscreen-panel-regulator.example.dts:23.16-34.7: Warning (unit_address_vs_reg): /i2c@980000: node has a unit name, but no reg or ranges property /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/regulator/waveshare,touchscreen-panel-regulator.example.dtb: /: '#gpio-cells' is a dependency of 'gpio-controller'
from schema $id: http://devicetree.org/schemas/gpio/gpio.yaml
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/regulator/waveshare,touchscreen-panel-regulator.example.dtb: /: gpio-controller: 'oneOf' conditional failed, one must be fixed:
True was expected
{'compatible': ['test,gpio'], '#gpio-cells': 2, 'phandle': 2} is not of type 'boolean'
{'compatible': ['test,gpio'], '#gpio-cells': 2, 'phandle': 2} is not of type 'null'
from schema $id: http://devicetree.org/schemas/gpio/gpio.yaml/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/regulator/waveshare,touchscreen-panel-regulator.example.dtb: /: i2c@980000: 'anyOf' conditional failed, one must be fixed:
'reg' is a required property
'ranges' is a required property
from schema $id: http://devicetree.org/schemas/root-node.yaml
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/regulator/waveshare,touchscreen-panel-regulator.example.dtb: /: 'compatible' is a required property
from schema $id: http://devicetree.org/schemas/root-node.yaml
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/regulator/waveshare,touchscreen-panel-regulator.example.dtb: /: 'model' is a required property
from schema $id: http://devicetree.org/schemas/root-node.yaml
Documentation/devicetree/bindings/display/panel/waveshare,dsi-panel.example.dts:20.21-37.11: Warning (unit_address_vs_reg): /example-0/dsi@ae94000: node has a unit name, but no reg or ranges property
doc reference errors (make refcheckdocs):
See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/[email protected]
The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch.
If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date:
pip3 install dtschema --upgrade
Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.
Bjorn Andersson
maintainerQuoted 57 lines · Sudarshan Shetty
Device tree bindings for Waveshare MIPI-DSI panels of various sizes (5.0, 5.5, 7.0, 8.0, and 10.1). These panels require proper power sequencing via an external regulator and a backlight node for brightness control.
Signed-off-by Sudarshan Shetty <[email protected]>--- .../display/panel/waveshare,dsi-panel.yaml | 84 +++++++++++++++++++ ...waveshare,touchscreen-panel-regulator.yaml | 72 ++++++++++++++++ 2 files changed, 156 insertions(+) create mode 100644 Documentation/devicetree/bindings/display/panel/waveshare,dsi-panel.yaml create mode 100644 Documentation/devicetree/bindings/regulator/waveshare,touchscreen-panel-regulator.yamlDocumentation/devicetree/bindings/display/panel/waveshare,dsi-panel.yaml new file +38
-0@@ -0,0 +1,84 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/display/panel/waveshare,dsi-panel.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Waveshare 10.1" DSI Touch Display Panel + +maintainers: + - Sudarshan Shetty <[email protected]> + +allOf: + - $ref: panel-common.yaml# + +properties: + compatible: + enum: + - waveshare,12.3-dsi-touch-a,4lane + - waveshare,10.1-dsi-touch-a + - waveshare,10.1-dsi-touch-a-4lane + - waveshare,10.1-dsi-touch-b + - waveshare,10.1-dsi-touch-b,4lane + - waveshare,9.0-dsi-touch-b + - waveshare,9.0-dsi-touch-b,4lane + - waveshare,8.8-dsi-touch-a + - waveshare,8.0-dsi-touch-a + - waveshare,8.0-dsi-touch-a-4lane + - waveshare,7.0-dsi-touch-a + - waveshare,7.0-dsi-touch-b + - waveshare,5.5-dsi-touch-a + - waveshare,5.0-dsi-touch-a + - waveshare,4.0-dsi-touch-c + - waveshare,3.4-dsi-touch-c + + reg: + description: DSI virtual channel + maxItems: 1 +
Documentation/devicetree/bindings/display/panel/waveshare,dsi-panel.yaml line 48
Quoted 10 lines
Documentation/devicetree/bindings/display/panel/waveshare,dsi-panel.yaml new file +10
-0+ vdd-supply: + description: Power supply regulator for the panel + + reset-gpios: + maxItems: 1 + description: GPIO to control panel reset + + enable-gpios: + maxItems: 1 + description: GPIO to control panel power enable
If this is the correct description of this pin, then this should be a regulator provided by the regulator node and it should likely have the 3.3V (and 5V?) listed as -supply.
Quoted 58 lines
Documentation/devicetree/bindings/display/panel/waveshare,dsi-panel.yaml new file +36
-0+ +required: + - compatible + - reg + - vdd-supply + - reset-gpios + - enable-gpios + +unevaluatedProperties: false + +examples: + - | + #include <dt-bindings/gpio/gpio.h> + + dsi@ae94000 { + #address-cells = <1>; + #size-cells = <0>; + + panel@1 { + compatible = "waveshare,10.1-dsi-touch-a"; + reg = <1>; + vdd-supply = <&vreg_l11a>; + reset-gpios = <&display_mcu 1 GPIO_ACTIVE_HIGH>; + enable-gpios = <&display_mcu 2 GPIO_ACTIVE_HIGH>; + + port { + panel_in: endpoint { + remote-endpoint = <&mdss_dsi0_out>; + }; + }; + }; + }; + + mdss_dsi0_out: endpoint { + remote-endpoint = <&panel_in>; + };Documentation/devicetree/bindings/regulator/waveshare,touchscreen-panel-regulator.yaml new file +16
-0@@ -0,0 +1,72 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/regulator/waveshare,touchscreen-panel-regulator.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Waveshare Touchscreen Panel Regulator + +maintainers: + - Sudarshan Shetty <[email protected]> + +description: | + Regulator driver for Waveshare touchscreen display units. + This regulator enables and disables panel power and provides + backlight control over I2C. +
Documentation/devicetree/bindings/regulator/waveshare,touchscreen-panel-regulator.yaml line 26
Quoted 10 lines
Documentation/devicetree/bindings/regulator/waveshare,touchscreen-panel-regulator.yaml new file +10
-0+properties: + compatible: + const: waveshare,touchscreen-panel-regulator + + reg: + maxItems: 1 + description: I2C address of the regulator device + + vin-supply: + description: Input supply regulator for the panel
The Waveshare takes 3.3V and 5V inputs, which then is distributed to the panel and the touch through some regulators controlled by the MCU that this binding represents.
So I'm pretty sure we need one more supply, and we need better descriptions of what they are.
Documentation/devicetree/bindings/regulator/waveshare,touchscreen-panel-regulator.yaml line 30
Quoted 4 lines
Documentation/devicetree/bindings/regulator/waveshare,touchscreen-panel-regulator.yaml new file +4
-0+ + enable-gpios: + maxItems: 1 + description: GPIO to enable/disable regulator
This too is a pin controlled by the MCU, i.e. provided by the entity you describe by this node.
Documentation/devicetree/bindings/regulator/waveshare,touchscreen-panel-regulator.yaml line 31
Quoted 1 line
Documentation/devicetree/bindings/regulator/waveshare,touchscreen-panel-regulator.yaml new file +1
-0+
The driver that you also posted, which should have been sent together with the binding, registers a GPIO controller, so you need "gpio-controller" and "#gpio-cells" here as well.
Quoted 26 lines
Documentation/devicetree/bindings/regulator/waveshare,touchscreen-panel-regulator.yaml new file +26
-0+required: + - compatible + - reg + - vin-supply + +additionalProperties: false + +examples: + - | + /dts-v1/; + /plugin/; + + / { + #address-cells = <1>; + #size-cells = <1>; + + gpio: gpio-controller { + compatible = "test,gpio"; + #gpio-cells = <2>; + }; + + vdd_3v3: regulator { + compatible = "regulator-fixed"; + regulator-name = "vdd_3v3"; + regulator-min-microvolt = <3300000>; + regulator-max-microvolt = <3300000>;
Documentation/devicetree/bindings/regulator/waveshare,touchscreen-panel-regulator.yaml line 67
Quoted 10 lines
Documentation/devicetree/bindings/regulator/waveshare,touchscreen-panel-regulator.yaml new file +10
-0+ }; + + i2c@980000 { + #address-cells = <1>; + #size-cells = <0>; + compatible = "test,i2c"; + + panel-regulator@3c { + compatible = "waveshare,touchscreen-panel-regulator"; + reg = <0x3c>;
Are you sure/ All the material I've found says it's 0x45
Documentation/devicetree/bindings/regulator/waveshare,touchscreen-panel-regulator.yaml line 71
Quoted 4 lines
Documentation/devicetree/bindings/regulator/waveshare,touchscreen-panel-regulator.yaml new file +4
-0+ vin-supply = <&vdd_3v3>; + enable-gpios = <&gpio 2 0>; /* active high */ + }; + };
This example does not show how the waveshare,touchscreen-panel-regulator should be added to a DeviceTree!
Based on how you wrote the driver, enable-gpios should point back into panel-regulator itself. vin-supply
Regards,
Bjorn
Quoted 4 lines
Documentation/devicetree/bindings/regulator/waveshare,touchscreen-panel-regulator.yaml new file +1
-0+ };Signature · 1 line
2.34.1