Skip to contentSkip to conversation

net/mlx5: release representor interrupt handler

PATCH In review Bing Zhao 5 participants 6 messages Nov 12, 2025 – Nov 20, 2025 Network drivers

lore
Share & tools
lore

Bing Zhao

author
#0 lore raw

PATCH 1/4 net/mlx5: release representor interrupt handler

From: Roi Dayan <[email protected]>

Looks like commit the cited commit removed the representor interrupt handler cleanup by mistake. Fix it.

Fixes 5cf0707fc7e9 ("net/mlx5: remove Rx queue data list from device")
Cc [email protected]
Signed-off-by Roi Dayan <[email protected]>
---
 drivers/net/mlx5/mlx5.c | 5 +++++
 1 file changed, 5 insertions(+)
drivers/net/mlx5/mlx5.c +5 -0
index 666216c21a..591420c77f 100644
@@ -2389,6 +2389,11 @@ mlx5_dev_close(struct rte_eth_dev *dev)
 	/* Free the eCPRI flex parser resource. */
 	mlx5_flex_parser_ecpri_release(dev);
 	mlx5_flex_item_port_cleanup(dev);
+	if (priv->representor) {
+		/* Each representor has a dedicated interrupts handler */
+		rte_intr_instance_free(dev->intr_handle);
+		dev->intr_handle = NULL;
+	}
 	mlx5_indirect_list_handles_release(dev);
 #ifdef HAVE_MLX5_HWS_SUPPORT
 	mlx5_nta_sample_context_free(dev);
Signature · 1 line
2.34.1
Acked-by on v1 1/4
#1 lore raw

Hi,

Quoted 14 lines

-----Original Message-----
From: Bing Zhao <[email protected]>
Sent: Wednesday, November 12, 2025 3:40 PM
To: Slava Ovsiienko <[email protected]>; [email protected]; Raslan Darawsheh <[email protected]>
Cc: Ori Kam <[email protected]>; Dariusz Sosnowski <[email protected]>; Suanming Mou <[email protected]>; Matan Azrad <[email protected]>; NBU-Contact-Thomas Monjalon (EXTERNAL) <[email protected]>; Bing Zhao <[email protected]>; Roi Dayan <[email protected]>; Xueming Li <[email protected]>
Subject: [PATCH 1/4] net/mlx5: release representor interrupt handler

From: Roi Dayan <[email protected]>

Quoted 7 lines

Looks like commit the cited commit removed the representor interrupt handler cleanup by mistake. Fix it.

Fixes 5cf0707fc7e9 ("net/mlx5: remove Rx queue data list from device")
Cc [email protected]
Signed-off-by Roi Dayan <[email protected]>
Acked-by Suanming Mou <[email protected]>

Thanks

#3 lore raw
In reply to Bing Zhao
Quoted 8 lines · Bing Zhao

From: Roi Dayan <[email protected]>

Looks like commit the cited commit removed the representor interrupt handler cleanup by mistake. Fix it.

Fixes 5cf0707fc7e9 ("net/mlx5: remove Rx queue data list from device")
Cc [email protected]

Hi,

Some of this series (see below) is fixing issues in older releases, but does not include stable tag to indicate the fixes should be backported.

Just checking if this is deliberate, or an oversight and they should be backported ?

thanks,
Kevin.

25.11 dbaed15366 - F net/mlx5: release representor interrupt handler (Fixes issue in 21.11)

25.11 aef94343d3 - F common/mlx5: release unused mempool entries (Fixes issue in 21.11 (partially fixed in 8947eebc999e @ 21.11))

25.11 8d1fe10768 - F net/mlx5/hws: fix buddy memory allocation (Fixes issue in 22.11)

Quoted 21 lines
Signed-off-by Roi Dayan <[email protected]>
---
 drivers/net/mlx5/mlx5.c | 5 +++++
 1 file changed, 5 insertions(+)
drivers/net/mlx5/mlx5.c +5 -0
index 666216c21a..591420c77f 100644
@@ -2389,6 +2389,11 @@ mlx5_dev_close(struct rte_eth_dev *dev)
 	/* Free the eCPRI flex parser resource. */
 	mlx5_flex_parser_ecpri_release(dev);
 	mlx5_flex_item_port_cleanup(dev);
+	if (priv->representor) {
+		/* Each representor has a dedicated interrupts handler */
+		rte_intr_instance_free(dev->intr_handle);
+		dev->intr_handle = NULL;
+	}
 	mlx5_indirect_list_handles_release(dev);
 #ifdef HAVE_MLX5_HWS_SUPPORT
 	mlx5_nta_sample_context_free(dev);
#4 lore raw

20/11/2025 18:08, Kevin Traynor:

Quoted 21 lines · Bing Zhao
Quoted 8 lines

From: Roi Dayan <[email protected]>

Looks like commit the cited commit removed the representor interrupt handler cleanup by mistake. Fix it.

Fixes 5cf0707fc7e9 ("net/mlx5: remove Rx queue data list from device")
Cc [email protected]

Hi,

Some of this series (see below) is fixing issues in older releases, but does not include stable tag to indicate the fixes should be backported.

Just checking if this is deliberate, or an oversight and they should be backported ?

thanks,
Kevin.

Quoted 8 lines

25.11 dbaed15366 - F net/mlx5: release representor interrupt handler (Fixes issue in 21.11)

25.11 aef94343d3 - F common/mlx5: release unused mempool entries (Fixes issue in 21.11 (partially fixed in 8947eebc999e @ 21.11))

25.11 8d1fe10768 - F net/mlx5/hws: fix buddy memory allocation (Fixes issue in 22.11)

I think it is an oversight.
Usually I fix it myself, but this time I missed some.

Raslan, please run devtools/check-git-log.sh for each patch, it is raising such issue.

#5 lore raw
Quoted 25 lines · Thomas Monjalon

20/11/2025 18:08, Kevin Traynor:

Quoted 24 lines · Bing Zhao
Quoted 8 lines

From: Roi Dayan <[email protected]>

Looks like commit the cited commit removed the representor interrupt handler cleanup by mistake. Fix it.

Fixes 5cf0707fc7e9 ("net/mlx5: remove Rx queue data list from device")
Cc [email protected]

Hi,

Some of this series (see below) is fixing issues in older releases, but does not include stable tag to indicate the fixes should be backported.

Just checking if this is deliberate, or an oversight and they should be backported ?

thanks,
Kevin.

25.11 dbaed15366 - F net/mlx5: release representor interrupt handler (Fixes issue in 21.11)

Quoted 9 lines
Quoted 5 lines

25.11 aef94343d3 - F common/mlx5: release unused mempool entries (Fixes issue in 21.11 (partially fixed in 8947eebc999e @ 21.11))

25.11 8d1fe10768 - F net/mlx5/hws: fix buddy memory allocation (Fixes issue in 22.11)

I think it is an oversight.
Usually I fix it myself, but this time I missed some.

No problem, they all apply cleanly (24.11). Just checking builds now.

Quoted 4 lines

Raslan, please run devtools/check-git-log.sh for each patch, it is raising such issue.