Consolidate and clarify LED device tree descriptions on Radxa boards
Subsystems (2)
v3 cover Consolidate and clarify LED device tree descriptions on Radxa boards
Currently, on Radxa boards, the power LED is turned on immediately after power-up, independent of software control. The heartbeat LED and other available LEDs are subsequently turned on by the initial software, such as U-Boot, to indicate software is running.
However, the device tree description for this behavior is inconsistent and fragmented, with definitions split between the main Linux DTS files and separate U-Boot files (u-boot/arch/arm/dts/*-u-boot.dtsi).
This patch series addresses this inconsistency and fragmentation by consolidating the description within the upstream device tree, thereby improving overall clarity.
Patch 1 addresses the inconsistency for the power LED by using default-state = "on" instead of linux,default-trigger = "default-on".
Patch 2 addresses the description fragmentation for the heartbeat LED by consolidating its default-state = "on" definition from the U-Boot files into the main Linux DTS.
Patch 3 addresses inconsistency by removing redundant default-state = "off" definitions, as this is already the default configuration.
This patch series does not address some LEDs that are (implicitly) default-state = "off" at kernel but should be "on" at bootloader. These will be addressed separately.
FUKAUMI Naoki (3):
arm64: dts: rockchip: Use default-state for power LED for Radxa boards
arm64: dts: rockchip: Turn on heartbeat LED at boot for Radxa boards
arm64: dts: rockchip: Remove default-state = "off" from LEDs for Radxa
boards
---
Changes in v3:
- Split into three patches
- Reword commit message
Changes in v2:
- Add more URLs for reference
- Reword commit message
--- arch/arm64/boot/dts/rockchip/rk3308-rock-pi-s.dts | 1 - arch/arm64/boot/dts/rockchip/rk3328-rock-pi-e.dts | 1 + arch/arm64/boot/dts/rockchip/rk3399-rock-4c-plus.dts | 3 ++- arch/arm64/boot/dts/rockchip/rk3399-rock-pi-4.dtsi | 1 + arch/arm64/boot/dts/rockchip/rk3528-radxa-e20c.dts | 2 -- arch/arm64/boot/dts/rockchip/rk3528-rock-2a.dts | 1 - arch/arm64/boot/dts/rockchip/rk3566-radxa-cm3-io.dts | 1 + arch/arm64/boot/dts/rockchip/rk3566-rock-3c.dts | 1 + arch/arm64/boot/dts/rockchip/rk3568-radxa-cm3i.dtsi | 1 + arch/arm64/boot/dts/rockchip/rk3568-rock-3a.dts | 1 + arch/arm64/boot/dts/rockchip/rk3576-rock-4d.dts | 3 ++- arch/arm64/boot/dts/rockchip/rk3582-radxa-e52c.dts | 2 -- arch/arm64/boot/dts/rockchip/rk3588-rock-5-itx.dts | 2 +- arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dtsi | 1 + arch/arm64/boot/dts/rockchip/rk3588-rock-5t.dts | 1 + arch/arm64/boot/dts/rockchip/rk3588s-rock-5a.dts | 3 ++- 16 files changed, 15 insertions(+), 10 deletions(-)
Signature · 7 lines
2.43.0 _______________________________________________ Linux-rockchip mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-rockchip
PATCH v3 1/3 arm64: dts: rockchip: Use default-state for power LED for Radxa boards
Currently, on Radxa boards, the power LED is turned on immediately after power-up, independent of software control. The heartbeat LED and other available LEDs are subsequently turned on by the initial software, such as U-Boot, to indicate software is running.
However, the device tree description for this behavior is inconsistent and fragmented, with definitions split between the main Linux DTS files and separate U-Boot files (u-boot/arch/arm/dts/*-u-boot.dtsi).
This patch addresses the inconsistency for the power LED by using default-state = "on" instead of linux,default-trigger = "default-on".
--- arch/arm64/boot/dts/rockchip/rk3308-rock-pi-s.dts | 1 - arch/arm64/boot/dts/rockchip/rk3399-rock-4c-plus.dts | 2 +- arch/arm64/boot/dts/rockchip/rk3528-rock-2a.dts | 1 - arch/arm64/boot/dts/rockchip/rk3576-rock-4d.dts | 2 +- arch/arm64/boot/dts/rockchip/rk3588-rock-5-itx.dts | 2 +- arch/arm64/boot/dts/rockchip/rk3588s-rock-5a.dts | 2 +- 6 files changed, 4 insertions(+), 6 deletions(-)
arch/arm64/boot/dts/rockchip/rk3308-rock-pi-s.dts +0 -1
@@ -35,7 +35,6 @@ green-led { function = LED_FUNCTION_POWER; gpios = <&gpio0 RK_PA6 GPIO_ACTIVE_HIGH>; label = "rockpis:green:power"; - linux,default-trigger = "default-on"; }; blue-led {
arch/arm64/boot/dts/rockchip/rk3399-rock-4c-plus.dts +1 -1
@@ -39,8 +39,8 @@ leds { led-0 { function = LED_FUNCTION_POWER; color = <LED_COLOR_ID_GREEN>; + default-state = "on"; gpios = <&gpio3 RK_PD4 GPIO_ACTIVE_LOW>; - linux,default-trigger = "default-on"; }; /* USER_LED2 */
arch/arm64/boot/dts/rockchip/rk3528-rock-2a.dts +0 -1
@@ -45,7 +45,6 @@ led-1 { default-state = "on"; function = LED_FUNCTION_STATUS; gpios = <&gpio3 RK_PC1 GPIO_ACTIVE_LOW>; - linux,default-trigger = "default-on"; }; };
arch/arm64/boot/dts/rockchip/rk3576-rock-4d.dts +1 -1
@@ -52,9 +52,9 @@ leds: leds { power-led { color = <LED_COLOR_ID_GREEN>; + default-state = "on"; function = LED_FUNCTION_STATUS; gpios = <&gpio0 RK_PB4 GPIO_ACTIVE_HIGH>; - linux,default-trigger = "default-on"; }; user-led {
arch/arm64/boot/dts/rockchip/rk3588-rock-5-itx.dts +1 -1
@@ -88,8 +88,8 @@ gpio-leds { pinctrl-0 = <&led_pins>; power-led1 { + default-state = "on"; gpios = <&gpio0 RK_PB7 GPIO_ACTIVE_HIGH>; - linux,default-trigger = "default-on"; }; hdd-led2 {
arch/arm64/boot/dts/rockchip/rk3588s-rock-5a.dts +1 -1
@@ -61,9 +61,9 @@ io-led { power-led { color = <LED_COLOR_ID_GREEN>; + default-state = "on"; function = LED_FUNCTION_POWER; gpios = <&gpio3 RK_PC4 GPIO_ACTIVE_HIGH>; - linux,default-trigger = "default-on"; }; };
Signature · 7 lines
2.43.0 _______________________________________________ Linux-rockchip mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-rockchip
Re: [PATCH v3 1/3] arm64: dts: rockchip: Use default-state for power LED for Radxa boards
Hello Naoki,
Quoted 13 lines · FUKAUMI Naoki
Currently, on Radxa boards, the power LED is turned on immediately after power-up, independent of software control. The heartbeat LED and other available LEDs are subsequently turned on by the initial software, such as U-Boot, to indicate software is running.
However, the device tree description for this behavior is inconsistent and fragmented, with definitions split between the main Linux DTS files and separate U-Boot files (
u-boot/arch/arm/dts/*-u-boot.dtsi).This patch addresses the inconsistency for the power LED by using default-state = "on" instead of linux,default-trigger = "default-on".
Signed-off-by FUKAUMI Naoki <[email protected]>
Quoted 8 lines
--- arch/arm64/boot/dts/rockchip/rk3308-rock-pi-s.dts | 1 - arch/arm64/boot/dts/rockchip/rk3399-rock-4c-plus.dts | 2 +- arch/arm64/boot/dts/rockchip/rk3528-rock-2a.dts | 1 - arch/arm64/boot/dts/rockchip/rk3576-rock-4d.dts | 2 +- arch/arm64/boot/dts/rockchip/rk3588-rock-5-itx.dts | 2 +- arch/arm64/boot/dts/rockchip/rk3588s-rock-5a.dts | 2 +- 6 files changed, 4 insertions(+), 6 deletions(-)
[snip]
Thanks for this patch. The introduces changes look consistent to me, so please feel free to include
PATCH v3 2/3 arm64: dts: rockchip: Turn on heartbeat LED at boot for Radxa boards
In reply to FUKAUMI NaokiCurrently, on Radxa boards, the power LED is turned on immediately after power-up, independent of software control. The heartbeat LED and other available LEDs are subsequently turned on by the initial software, such as U-Boot, to indicate software is running.
However, the device tree description for this behavior is inconsistent and fragmented, with definitions split between the main Linux DTS files and separate U-Boot files (u-boot/arch/arm/dts/*-u-boot.dtsi).
This patch addresses the description fragmentation for the heartbeat LED by consolidating its default-state = "on" definition from the U-Boot files into the main Linux DTS.
- Radxa CM3 IO board
https://source.denx.de/u-boot/u-boot/-/blob/v2025.10/arch/arm/dts/rk3566-radxa-cm3-io-u-boot.dtsi#L10-12
- Radxa CM3I
https://source.denx.de/u-boot/u-boot/-/blob/v2025.10/arch/arm/dts/rk3568-radxa-e25-u-boot.dtsi#L7-24
- Radxa ROCK 3A
https://source.denx.de/u-boot/u-boot/-/blob/v2025.10/arch/arm/dts/rk3568-rock-3a-u-boot.dtsi#L11-13
- Radxa ROCK 3C
https://source.denx.de/u-boot/u-boot/-/blob/v2025.10/arch/arm/dts/rk3566-rock-3c-u-boot.dtsi#L14-16
- Radxa ROCK 4C+
https://source.denx.de/u-boot/u-boot/-/blob/v2025.10/arch/arm/dts/rk3399-rock-4c-plus-u-boot.dtsi#L11-17
- Radxa ROCK 4D
(New)
- Radxa ROCK 4SE
Radxa ROCK Pi 4A/A+/B/B+/C
https://source.denx.de/u-boot/u-boot/-/blob/v2025.10/arch/arm/dts/rk3399-rock-pi-4-u-boot.dtsi#L11-13
- Radxa ROCK 5A
https://source.denx.de/u-boot/u-boot/-/blob/v2025.10/arch/arm/dts/rk3588s-rock-5a-u-boot.dtsi#L10-12
- Radxa ROCK 5B
https://source.denx.de/u-boot/u-boot/-/blob/v2025.10/arch/arm/dts/rk3588-rock-5b-u-boot.dtsi#L11-13
- Radxa ROCK 5B+/5T
(New)
- Radxa ROCK Pi E
https://source.denx.de/u-boot/u-boot/-/blob/v2025.10/arch/arm/dts/rk3328-rock-pi-e-base-u-boot.dtsi#L10-12
--- arch/arm64/boot/dts/rockchip/rk3328-rock-pi-e.dts | 1 + arch/arm64/boot/dts/rockchip/rk3399-rock-4c-plus.dts | 1 + arch/arm64/boot/dts/rockchip/rk3399-rock-pi-4.dtsi | 1 + arch/arm64/boot/dts/rockchip/rk3566-radxa-cm3-io.dts | 1 + arch/arm64/boot/dts/rockchip/rk3566-rock-3c.dts | 1 + arch/arm64/boot/dts/rockchip/rk3568-radxa-cm3i.dtsi | 1 + arch/arm64/boot/dts/rockchip/rk3568-rock-3a.dts | 1 + arch/arm64/boot/dts/rockchip/rk3576-rock-4d.dts | 1 + arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dtsi | 1 + arch/arm64/boot/dts/rockchip/rk3588-rock-5t.dts | 1 + arch/arm64/boot/dts/rockchip/rk3588s-rock-5a.dts | 1 + 11 files changed, 11 insertions(+)
arch/arm64/boot/dts/rockchip/rk3328-rock-pi-e.dts +1 -0
@@ -59,6 +59,7 @@ leds { led-0 { color = <LED_COLOR_ID_BLUE>; + default-state = "on"; gpios = <&gpio3 RK_PA5 GPIO_ACTIVE_LOW>; linux,default-trigger = "heartbeat"; };
arch/arm64/boot/dts/rockchip/rk3399-rock-4c-plus.dts +1 -0
@@ -47,6 +47,7 @@ led-0 { led-1 { function = LED_FUNCTION_STATUS; color = <LED_COLOR_ID_BLUE>; + default-state = "on"; gpios = <&gpio3 RK_PD5 GPIO_ACTIVE_HIGH>; linux,default-trigger = "heartbeat"; };
arch/arm64/boot/dts/rockchip/rk3399-rock-pi-4.dtsi +1 -0
@@ -35,6 +35,7 @@ leds { led-0 { function = LED_FUNCTION_STATUS; color = <LED_COLOR_ID_BLUE>; + default-state = "on"; gpios = <&gpio3 RK_PD5 GPIO_ACTIVE_HIGH>; linux,default-trigger = "heartbeat"; };
arch/arm64/boot/dts/rockchip/rk3566-radxa-cm3-io.dts +1 -0
@@ -46,6 +46,7 @@ leds { led-1 { gpios = <&gpio4 RK_PA4 GPIO_ACTIVE_LOW>; color = <LED_COLOR_ID_GREEN>; + default-state = "on"; function = LED_FUNCTION_ACTIVITY; linux,default-trigger = "heartbeat"; pinctrl-names = "default";
arch/arm64/boot/dts/rockchip/rk3566-rock-3c.dts +1 -0
@@ -47,6 +47,7 @@ led-0 { gpios = <&gpio0 RK_PA0 GPIO_ACTIVE_HIGH>; function = LED_FUNCTION_HEARTBEAT; color = <LED_COLOR_ID_BLUE>; + default-state = "on"; linux,default-trigger = "heartbeat"; pinctrl-names = "default"; pinctrl-0 = <&user_led2>;
arch/arm64/boot/dts/rockchip/rk3568-radxa-cm3i.dtsi +1 -0
@@ -23,6 +23,7 @@ led_user: led-0 { gpios = <&gpio0 RK_PA6 GPIO_ACTIVE_HIGH>; function = LED_FUNCTION_HEARTBEAT; color = <LED_COLOR_ID_GREEN>; + default-state = "on"; linux,default-trigger = "heartbeat"; pinctrl-names = "default"; pinctrl-0 = <&led_user_en>;
arch/arm64/boot/dts/rockchip/rk3568-rock-3a.dts +1 -0
@@ -47,6 +47,7 @@ led_user: led-0 { gpios = <&gpio0 RK_PB7 GPIO_ACTIVE_HIGH>; function = LED_FUNCTION_HEARTBEAT; color = <LED_COLOR_ID_BLUE>; + default-state = "on"; linux,default-trigger = "heartbeat"; pinctrl-names = "default"; pinctrl-0 = <&led_user_en>;
arch/arm64/boot/dts/rockchip/rk3576-rock-4d.dts +1 -0
@@ -59,6 +59,7 @@ power-led { user-led { color = <LED_COLOR_ID_BLUE>; + default-state = "on"; function = LED_FUNCTION_HEARTBEAT; gpios = <&gpio0 RK_PC4 GPIO_ACTIVE_LOW>; linux,default-trigger = "heartbeat";
arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dtsi +1 -0
@@ -30,6 +30,7 @@ leds { led_rgb_b { function = LED_FUNCTION_STATUS; color = <LED_COLOR_ID_BLUE>; + default-state = "on"; gpios = <&gpio0 RK_PB7 GPIO_ACTIVE_HIGH>; linux,default-trigger = "heartbeat"; };
arch/arm64/boot/dts/rockchip/rk3588-rock-5t.dts +1 -0
@@ -33,6 +33,7 @@ leds { led_rgb_b { function = LED_FUNCTION_STATUS; color = <LED_COLOR_ID_BLUE>; + default-state = "on"; gpios = <&gpio0 RK_PA0 GPIO_ACTIVE_HIGH>; linux,default-trigger = "heartbeat"; };
arch/arm64/boot/dts/rockchip/rk3588s-rock-5a.dts +1 -0
@@ -54,6 +54,7 @@ leds { io-led { color = <LED_COLOR_ID_BLUE>; + default-state = "on"; function = LED_FUNCTION_STATUS; gpios = <&gpio3 RK_PD5 GPIO_ACTIVE_HIGH>; linux,default-trigger = "heartbeat";
Signature · 7 lines
2.43.0 _______________________________________________ Linux-rockchip mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-rockchip
Re: [PATCH v3 2/3] arm64: dts: rockchip: Turn on heartbeat LED at boot for Radxa boards
Hello Naoki,
(+ Quentin)
Quoted 48 lines · FUKAUMI Naoki
Currently, on Radxa boards, the power LED is turned on immediately after power-up, independent of software control. The heartbeat LED and other available LEDs are subsequently turned on by the initial software, such as U-Boot, to indicate software is running.
However, the device tree description for this behavior is inconsistent and fragmented, with definitions split between the main Linux DTS files and separate U-Boot files (
u-boot/arch/arm/dts/*-u-boot.dtsi).This patch addresses the description fragmentation for the heartbeat LED by consolidating its default-state = "on" definition from the U-Boot files into the main Linux DTS.
- Radxa CM3 IO board
https://source.denx.de/u-boot/u-boot/-/blob/v2025.10/arch/arm/dts/rk3566-radxa-cm3-io-u-boot.dtsi#L10-12- Radxa CM3I
https://source.denx.de/u-boot/u-boot/-/blob/v2025.10/arch/arm/dts/rk3568-radxa-e25-u-boot.dtsi#L7-24- Radxa ROCK 3A
https://source.denx.de/u-boot/u-boot/-/blob/v2025.10/arch/arm/dts/rk3568-rock-3a-u-boot.dtsi#L11-13- Radxa ROCK 3C
https://source.denx.de/u-boot/u-boot/-/blob/v2025.10/arch/arm/dts/rk3566-rock-3c-u-boot.dtsi#L14-16- Radxa ROCK 4C+
https://source.denx.de/u-boot/u-boot/-/blob/v2025.10/arch/arm/dts/rk3399-rock-4c-plus-u-boot.dtsi#L11-17- Radxa ROCK 4D
(New)- Radxa ROCK 4SE
Radxa ROCK Pi 4A/A+/B/B+/C
https://source.denx.de/u-boot/u-boot/-/blob/v2025.10/arch/arm/dts/rk3399-rock-pi-4-u-boot.dtsi#L11-13- Radxa ROCK 5A
https://source.denx.de/u-boot/u-boot/-/blob/v2025.10/arch/arm/dts/rk3588s-rock-5a-u-boot.dtsi#L10-12- Radxa ROCK 5B
https://source.denx.de/u-boot/u-boot/-/blob/v2025.10/arch/arm/dts/rk3588-rock-5b-u-boot.dtsi#L11-13- Radxa ROCK 5B+/5T
(New)- Radxa ROCK Pi E
https://source.denx.de/u-boot/u-boot/-/blob/v2025.10/arch/arm/dts/rk3328-rock-pi-e-base-u-boot.dtsi#L10-12Signed-off-by FUKAUMI Naoki <[email protected]>
Quoted 13 lines
--- arch/arm64/boot/dts/rockchip/rk3328-rock-pi-e.dts | 1 + arch/arm64/boot/dts/rockchip/rk3399-rock-4c-plus.dts | 1 + arch/arm64/boot/dts/rockchip/rk3399-rock-pi-4.dtsi | 1 + arch/arm64/boot/dts/rockchip/rk3566-radxa-cm3-io.dts | 1 + arch/arm64/boot/dts/rockchip/rk3566-rock-3c.dts | 1 + arch/arm64/boot/dts/rockchip/rk3568-radxa-cm3i.dtsi | 1 + arch/arm64/boot/dts/rockchip/rk3568-rock-3a.dts | 1 + arch/arm64/boot/dts/rockchip/rk3576-rock-4d.dts | 1 + arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dtsi | 1 + arch/arm64/boot/dts/rockchip/rk3588-rock-5t.dts | 1 + arch/arm64/boot/dts/rockchip/rk3588s-rock-5a.dts | 1 + 11 files changed, 11 insertions(+)
[snip]
I'm sorry, but I disagree with the employed approach. As already discussed at length in the v2 of this series, the right and more useful approach would be to use the LED_BOOT feature in U-Boot and to move the associated DT definitions from the U-Boot-specific DTs to the Linux kernel's DTs.
IIUC, there are still some issues with the way U-Boot handles the LEDs on some Radxa boards that way, [2] but the right approach would be to get the DT changes implemented now, and resolve the issues at the U-Boot side afterwards. It will take a while anyway until the kernel's DT changes reach U-Boot, so there should be plenty of time to resolve the observed U-Boot issues.
[1] https://lore.kernel.org/linux-rockchip/[email protected]/T/#u
[2] https://libera.catirclogs.org/linux-rockchip/2025-11-13#1763038074-1763038779;
PATCH v3 3/3 arm64: dts: rockchip: Remove default-state = "off" from LEDs for Radxa boards
In reply to FUKAUMI NaokiCurrently, on Radxa boards, the power LED is turned on immediately after power-up, independent of software control. The heartbeat LED and other available LEDs are subsequently turned on by the initial software, such as U-Boot, to indicate software is running.
However, the device tree description for this behavior is inconsistent and fragmented, with definitions split between the main Linux DTS files and separate U-Boot files (u-boot/arch/arm/dts/*-u-boot.dtsi).
This patch addresses inconsistency by removing redundant default-state = "off" definitions, as this is already the default configuration.
--- arch/arm64/boot/dts/rockchip/rk3528-radxa-e20c.dts | 2 -- arch/arm64/boot/dts/rockchip/rk3582-radxa-e52c.dts | 2 -- 2 files changed, 4 deletions(-)
arch/arm64/boot/dts/rockchip/rk3528-radxa-e20c.dts +0 -2
@@ -62,7 +62,6 @@ leds { led-lan { color = <LED_COLOR_ID_GREEN>; - default-state = "off"; function = LED_FUNCTION_LAN; gpios = <&gpio4 RK_PB5 GPIO_ACTIVE_HIGH>; linux,default-trigger = "netdev";
@@ -78,7 +77,6 @@ led-sys { led-wan { color = <LED_COLOR_ID_GREEN>; - default-state = "off"; function = LED_FUNCTION_WAN; gpios = <&gpio4 RK_PC0 GPIO_ACTIVE_HIGH>; linux,default-trigger = "netdev";
arch/arm64/boot/dts/rockchip/rk3582-radxa-e52c.dts +0 -2
@@ -71,7 +71,6 @@ leds-1 { led-1 { color = <LED_COLOR_ID_GREEN>; - default-state = "off"; function = LED_FUNCTION_LAN; linux,default-trigger = "netdev"; pwms = <&pwm14 0 1000000 PWM_POLARITY_INVERTED>;
@@ -80,7 +79,6 @@ led-1 { led-2 { color = <LED_COLOR_ID_GREEN>; - default-state = "off"; function = LED_FUNCTION_WAN; linux,default-trigger = "netdev"; pwms = <&pwm11 0 1000000 PWM_POLARITY_INVERTED>;
Signature · 7 lines
2.43.0 _______________________________________________ Linux-rockchip mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-rockchip
Re: [PATCH v3 3/3] arm64: dts: rockchip: Remove default-state = "off" from LEDs for Radxa boards
Hello Naoki,
Quoted 8 lines · FUKAUMI Naoki
Currently, on Radxa boards, the power LED is turned on immediately after power-up, independent of software control. The heartbeat LED and other available LEDs are subsequently turned on by the initial software, such as U-Boot, to indicate software is running.
However, the device tree description for this behavior is inconsistent and fragmented, with definitions split between the main Linux DTS files and separate U-Boot files (
u-boot/arch/arm/dts/*-u-boot.dtsi).
I'm sorry, but the two paragraphs above seem to be redundant and should be deleted, because they actually don't help with describing what this patch attempts to achieve.
Quoted 2 lines
This patch addresses inconsistency by removing redundant default-state = "off" definitions, as this is already the default configuration.
Mentioning inconsistency here also seems redundant.
Quoted 39 lines
Signed-off-by FUKAUMI Naoki <[email protected]>--- arch/arm64/boot/dts/rockchip/rk3528-radxa-e20c.dts | 2 -- arch/arm64/boot/dts/rockchip/rk3582-radxa-e52c.dts | 2 -- 2 files changed, 4 deletions(-)arch/arm64/boot/dts/rockchip/rk3528-radxa-e20c.dts +0
-2@@ -62,7 +62,6 @@ leds { led-lan { color = <LED_COLOR_ID_GREEN>; - default-state = "off"; function = LED_FUNCTION_LAN; gpios = <&gpio4 RK_PB5 GPIO_ACTIVE_HIGH>; linux,default-trigger = "netdev";@@ -78,7 +77,6 @@ led-sys { led-wan { color = <LED_COLOR_ID_GREEN>; - default-state = "off"; function = LED_FUNCTION_WAN; gpios = <&gpio4 RK_PC0 GPIO_ACTIVE_HIGH>; linux,default-trigger = "netdev";arch/arm64/boot/dts/rockchip/rk3582-radxa-e52c.dts +0
-1@@ -71,7 +71,6 @@ leds-1 { led-1 { color = <LED_COLOR_ID_GREEN>; - default-state = "off"; function = LED_FUNCTION_LAN; linux,default-trigger = "netdev"; pwms = <&pwm14 0 1000000 PWM_POLARITY_INVERTED>;
arch/arm64/boot/dts/rockchip/rk3582-radxa-e52c.dts led-1 { · line 84
Quoted 7 lines
arch/arm64/boot/dts/rockchip/rk3582-radxa-e52c.dts +0
-1@@ -80,7 +79,6 @@ led-1 { led-2 { color = <LED_COLOR_ID_GREEN>; - default-state = "off"; function = LED_FUNCTION_WAN; linux,default-trigger = "netdev"; pwms = <&pwm11 0 1000000 PWM_POLARITY_INVERTED>;
Removing the properties that introduce the default values is fine, so with the remarks above addressed, please feel free to include
Re: [PATCH v3 3/3] arm64: dts: rockchip: Remove default-state = "off" from LEDs for Radxa boards
Quoted 4 lines · Dragan Simic
Removing the properties that introduce the default values is fine, so with the remarks above addressed, please feel free to include
Reviewed-by Dragan Simic <[email protected]>
Though, applying this patch might mess up the current behavior of U-Boot, which doesn't auto-probe and configure the LEDs that have no "default-state" defined, so perhaps addressing this patch should be left for after the patch 2/3 is resolved.
Re: (subset) [PATCH v3 0/3] Consolidate and clarify LED device tree descriptions on Radxa boards
In reply to FUKAUMI NaokiQuoted 10 lines · FUKAUMI Naoki
Currently, on Radxa boards, the power LED is turned on immediately after power-up, independent of software control. The heartbeat LED and other available LEDs are subsequently turned on by the initial software, such as U-Boot, to indicate software is running.
However, the device tree description for this behavior is inconsistent and fragmented, with definitions split between the main Linux DTS files and separate U-Boot files (
u-boot/arch/arm/dts/*-u-boot.dtsi).[...]
Applied, thanks!
[1/3] arm64: dts: rockchip: Use default-state for power LED for Radxa boards
commit: 6ed597fdbcfa5ffc1a01c8740320c5a20093b863
Best regards,
Signature · 1 line
Heiko Stuebner <[email protected]>