Skip to contentSkip to conversation

generic/773: fix expected output "QA output created by 1226"

PATCH In review Theodore Ts'o 3 participants 3 messages Nov 14, 2025

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 generic/773: fix expected output "QA output created by 1226"

The test generic/773 was apparently submitted as generic/1226, but when it was renamed to pack the test namespace, apparently the test output wasn't adjusted to reflect the new test name, leading to the test failing on sytems that have devices that support atomic writes.

Fixes 1499d4ff2365 ("generic: Add atomic write test using fio crc ...")
Cc Ojaswin Mujoo <[email protected]>
Cc Zorro Lang <[email protected]>
---
 tests/generic/773     | 2 +-
 tests/generic/773.out | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
tests/generic/773 +1 -1
index 7ad745546..0a30ac7f4 100755
@@ -2,7 +2,7 @@
 # SPDX-License-Identifier: GPL-2.0
 # Copyright (c) 2025 IBM Corporation. All Rights Reserved.
 #
-# FS QA Test 1226
+# FS QA Test 773
 #
 # Validate FS atomic write using fio crc check verifier.
 #
tests/generic/773.out +1 -1
index 6dce0ea52..8626114df 100644
@@ -1,2 +1,2 @@
-QA output created by 1226
+QA output created by 773
 Silence is golden
Signature · 1 line
2.51.0
Reviewed-by on v1 1/1
#1 lore raw
Quoted 9 lines · Theodore Ts'o

The test generic/773 was apparently submitted as generic/1226, but when it was renamed to pack the test namespace, apparently the test output wasn't adjusted to reflect the new test name, leading to the test failing on sytems that have devices that support atomic writes.

Fixes 1499d4ff2365 ("generic: Add atomic write test using fio crc ...")
Cc Ojaswin Mujoo <[email protected]>
Cc Zorro Lang <[email protected]>

Looks good, feel free to add:

Regards,
ojaswin

Quoted 29 lines
---
 tests/generic/773     | 2 +-
 tests/generic/773.out | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
tests/generic/773 +1 -1
index 7ad745546..0a30ac7f4 100755
@@ -2,7 +2,7 @@
 # SPDX-License-Identifier: GPL-2.0
 # Copyright (c) 2025 IBM Corporation. All Rights Reserved.
 #
-# FS QA Test 1226
+# FS QA Test 773
 #
 # Validate FS atomic write using fio crc check verifier.
 #
tests/generic/773.out +1 -1
index 6dce0ea52..8626114df 100644
@@ -1,2 +1,2 @@
-QA output created by 1226
+QA output created by 773
 Silence is golden
Signature · 1 line
2.51.0
Reviewed-by on v1 1/1
#2 lore raw
In reply to Theodore Ts'o
Quoted 10 lines · Theodore Ts'o

The test generic/773 was apparently submitted as generic/1226, but when it was renamed to pack the test namespace, apparently the test output wasn't adjusted to reflect the new test name, leading to the test failing on sytems that have devices that support atomic writes.

Fixes 1499d4ff2365 ("generic: Add atomic write test using fio crc ...")
Cc Ojaswin Mujoo <[email protected]>
Cc Zorro Lang <[email protected]>

---

Thanks Ted, I'm not sure why tools/mvtest missed this :)

Quoted 29 lines
 tests/generic/773     | 2 +-
 tests/generic/773.out | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
tests/generic/773 +1 -1
index 7ad745546..0a30ac7f4 100755
@@ -2,7 +2,7 @@
 # SPDX-License-Identifier: GPL-2.0
 # Copyright (c) 2025 IBM Corporation. All Rights Reserved.
 #
-# FS QA Test 1226
+# FS QA Test 773
 #
 # Validate FS atomic write using fio crc check verifier.
 #
tests/generic/773.out +1 -1
index 6dce0ea52..8626114df 100644
@@ -1,2 +1,2 @@
-QA output created by 1226
+QA output created by 773
 Silence is golden
Signature · 1 line
2.51.0