Skip to contentSkip to conversation

arm64: dts: rockchip: fix PCIe 3.3V regulator voltage on 9Tripod X3568 v4

PATCH Applied Coia Prant 2 participants 2 messages Nov 14, 2025 – Nov 20, 2025

Subsystems (2)
lore
Share & tools
lore

Coia Prant

author
#0 lore raw

PATCH 1/1 arm64: dts: rockchip: fix PCIe 3.3V regulator voltage on 9Tripod X3568 v4

The regulator type is "regulator-fixed" since its voltage always be 3.3v, min and max should be 3300000 make the regulator has a voltage

The regulator is supplied by dc_12v, so add the vin-supply.

---
 .../boot/dts/rockchip/rk3568-9tripod-x3568-v4.dts  | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)
arch/arm64/boot/dts/rockchip/rk3568-9tripod-x3568-v4.dts +7 -7
index ad4d62060..32fda9f5e 100644
@@ -170,16 +170,16 @@ vcc3v3_sys: regulator-vcc3v3-sys {
 	};
 
 	vcc3v3_pcie: regulator-vcc3v3-pcie {
-		compatible = "regulator-gpio";
-		regulator-name = "vcc3v3_pcie";
-		regulator-min-microvolt = <100000>;
-		regulator-max-microvolt = <3300000>;
+		compatible = "regulator-fixed";
+		enable-active-high;
+		gpio = <&gpio3 RK_PC3 GPIO_ACTIVE_HIGH>;
 		pinctrl-names = "default";
 		pinctrl-0 = <&vcc3v3_pcie_en_pin>;
-		gpios = <&gpio3 RK_PC3 GPIO_ACTIVE_HIGH>;
-		gpios-states = <1>;
-		states = <100000 0>, <3300000 1>;
+		regulator-name = "vcc3v3_pcie";
+		regulator-min-microvolt = <3300000>;
+		regulator-max-microvolt = <3300000>;
 		startup-delay-us = <5000>;
+		vin-supply = <&dc_12v>;
 	};
 
 	vcc5v0_sys: regulator-vcc5v0-sys {
Signature · 1 line
2.47.3
maintainer Applied
#1 lore raw
Quoted 6 lines · Coia Prant

The regulator type is "regulator-fixed" since its voltage always be 3.3v, min and max should be 3300000 make the regulator has a voltage

The regulator is supplied by dc_12v, so add the vin-supply.

Applied, thanks!

[1/1] arm64: dts: rockchip: fix PCIe 3.3V regulator voltage on 9Tripod X3568 v4

      commit: c8ecda015eb4070ced887eba34cdb60737a9893b

Changes "gpio" to the correct "gpios" property.
"gpio" only works because the kernel handles this common mistake :-) .

Best regards,

Signature · 1 line
Heiko Stuebner <[email protected]>