media: irtoy: fix race between device disconnection and urb callback
Subsystems (2)
PATCH 1/1 media: irtoy: fix race between device disconnection and urb callback
The irtoy_disconnect() function calls rc_unregister_device() before usb_kill_urb(), creating a race condition similar to the one fixed in commit 'f656cfbc7a29'. If rc_unregister_device() executes while the URB callback irtoy_in_callback() is still running, irtoy_response() may call ir_raw_event_store_with_timeout() with a freed irtoy->rc->raw pointer, leading to a NULL pointer dereference.
Call usb_kill_urb() before rc_unregister_device() to ensure all URB callbacks complete before freeing device resources.
Fixes 261463dbc34f ("media: rc: add support for Infrared Toy and IR Droid devices")
Signed-off-by Haotian Zhang <[email protected]>
--- drivers/media/rc/ir_toy.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/media/rc/ir_toy.c +2 -2
@@ -530,11 +530,11 @@ static void irtoy_disconnect(struct usb_interface *intf) {struct irtoy *ir =usb_get_intfdata (intf); +usb_kill_urb (ir->urb_out); +usb_kill_urb (ir->urb_in);rc_unregister_device (ir->rc);usb_set_intfdata (intf,NULL ); -usb_kill_urb (ir->urb_out);usb_free_urb (ir->urb_out); -usb_kill_urb (ir->urb_in);usb_free_urb (ir->urb_in);kfree (ir->in);kfree (ir->out);
Signature · 1 line
2.50.1.windows.1