can: add dummy_can driver
Subsystems (2)
Oliver Hartkopp
maintainerPATCH 1/2 can: add dummy_can driver
From: Vincent Mailhol <[email protected]>
During the development of CAN XL, we found the need of creating a dummy CAN XL driver in order to test the new netlink interface. While this code was initially intended to be some throwaway, it received some positive feedback.
Add the dummy_can driver. This driver acts similarly to the vcan interface in the sense that it will echo back any packet it receives. The difference is that it exposes a set on bittiming parameters as a real device would and thus must be configured as if it was a real physical interface.
The driver comes with a debug mode. If debug message are enabled (for example by enabling CONFIG_CAN_DEBUG_DEVICES), it will print in the kernel log all the bittiming values, similar to what a:
ip --details link show can0
would do.
This driver is mostly intended for debugging and testing, but some developers also may want to look at it as a simple reference implementation.
--- drivers/net/can/Kconfig | 17 +++ drivers/net/can/Makefile | 1 + drivers/net/can/dummy_can.c | 284 ++++++++++++++++++++++++++++++++++++ 3 files changed, 302 insertions(+) create mode 100644 drivers/net/can/dummy_can.c
drivers/net/can/Kconfig +17 -0
@@ -122,10 +122,27 @@ config CAN_CAN327 Please refer to the documentation for information on how to use it: Documentation/networking/device_drivers/can/can327.rst If this driver is built as a module, it will be called can327. +config CAN_DUMMY + tristate "Dummy CAN" + help + A dummy CAN module supporting Classical CAN, CAN FD and CAN XL. It + exposes bittiming values which can be configured through the netlink + interface. + + The module will simply echo any frame sent to it. If debug messages + are activated, it prints all the CAN bittiming information in the + kernel log. Aside from that it does nothing. + + This is convenient for testing the CAN netlink interface. Most of the + users will never need this. If unsure, say NO. + + To compile this driver as a module, choose M here: the module will be + called dummy-can. + config CAN_FLEXCAN tristate "Support for Freescale FLEXCAN based chips" depends on OF || COLDFIRE || COMPILE_TEST depends on HAS_IOMEM select CAN_RX_OFFLOAD
drivers/net/can/Makefile +1 -0
@@ -19,10 +19,11 @@ obj-$(CONFIG_CAN_AT91) += at91_can.o obj-$(CONFIG_CAN_BXCAN) += bxcan.o obj-$(CONFIG_CAN_CAN327) += can327.o obj-$(CONFIG_CAN_CC770) += cc770/ obj-$(CONFIG_CAN_C_CAN) += c_can/ obj-$(CONFIG_CAN_CTUCANFD) += ctucanfd/ +obj-$(CONFIG_CAN_DUMMY) += dummy_can.o obj-$(CONFIG_CAN_FLEXCAN) += flexcan/ obj-$(CONFIG_CAN_GRCAN) += grcan.o obj-$(CONFIG_CAN_IFI_CANFD) += ifi_canfd/ obj-$(CONFIG_CAN_JANZ_ICAN3) += janz-ican3.o obj-$(CONFIG_CAN_KVASER_PCIEFD) += kvaser_pciefd/
drivers/net/can/dummy_can.c new file +284 -0
284 lines not on this page · raw message
Signature · 1 line
2.47.3
Oliver Hartkopp
maintainerPATCH 2/2 can: raw: instantly reject unsupported CAN frames
For real CAN interfaces the CAN_CTRLMODE_FD and CAN_CTRLMODE_XL control modes indicate whether an interface can handle those CAN FD/XL frames.
In the case a CAN XL interface is configured in CANXL-only mode with disabled error-signalling neither CAN CC nor CAN FD frames can be sent.
The checks are performed on CAN_RAW sockets to give an instant feedback to the user when writing unsupported CAN frames to the interface.
--- net/can/raw.c | 54 +++++++++++++++++++++++++++++++++++++++++++-------- 1 file changed, 46 insertions(+), 8 deletions(-)
net/can/raw.c +46 -8
@@ -890,24 +890,62 @@ static void raw_put_canxl_vcid(struct raw_sock *ro, struct sk_buff *skb) cxl->prio &=CANXL_PRIO_MASK ; cxl->prio |= ro->tx_vcid_shifted; } } -static unsigned int raw_check_txframe (struct raw_sock *ro,struct sk_buff *skb,int mtu) +static inline bool raw_dev_cc_enabled (struct net_device *dev, +struct can_priv *priv) { -/* Classical CAN -> no checks for flags and device capabilities */ -if (can_is_can_skb (skb)) +/* The CANXL-only mode disables error-signalling on the CAN bus +* which is needed to send CAN CC/FD frames +*/ +if (priv) +return !can_dev_in_xl_only_mode (priv); + +/* virtual CAN interfaces always support CAN CC */ +return true; +} + +static inline bool raw_dev_fd_enabled (struct net_device *dev, +struct can_priv *priv) +{ +/* check FD ctrlmode on real CAN interfaces */ +if (priv) +return (priv->ctrlmode &CAN_CTRLMODE_FD ); + +/* check MTU for virtual CAN FD interfaces */ +return (READ_ONCE (dev->mtu) >=CANFD_MTU ); +} + +static inline bool raw_dev_xl_enabled (struct net_device *dev, +struct can_priv *priv) +{ +/* check XL ctrlmode on real CAN interfaces */ +if (priv) +return (priv->ctrlmode &CAN_CTRLMODE_XL ); + +/* check MTU for virtual CAN XL interfaces */ +return can_is_canxl_dev_mtu (READ_ONCE (dev->mtu)); +} + +static unsigned int raw_check_txframe (struct raw_sock *ro,struct sk_buff *skb, +struct net_device *dev) +{ +struct can_priv *priv =safe_candev_priv (dev); + +/* Classical CAN */ +if (can_is_can_skb (skb) &&raw_dev_cc_enabled (dev, priv))return CAN_MTU ; -/* CAN FD -> needs to be enabled and a CAN FD or CAN XL device */ +/* CAN FD */ if (ro->fd_frames &&can_is_canfd_skb (skb) && - (mtu ==CANFD_MTU ||can_is_canxl_dev_mtu (mtu))) +raw_dev_fd_enabled (dev, priv))return CANFD_MTU ; -/* CAN XL -> needs to be enabled and a CAN XL device */ +/* CAN XL */ if (ro->xl_frames &&can_is_canxl_skb (skb) && -can_is_canxl_dev_mtu (mtu)) +raw_dev_xl_enabled (dev, priv))return CANXL_MTU ;return 0 ; }
@@ -959,11 +997,11 @@ static int raw_sendmsg(struct socket *sock, struct msghdr *msg, size_t size) goto free_skb; err = -EINVAL ;/* check for valid CAN (CC/FD/XL) frame content */ - txmtu =raw_check_txframe (ro, skb,READ_ONCE (dev->mtu)); + txmtu =raw_check_txframe (ro, skb, dev);if (!txmtu) goto free_skb;/* only CANXL: clear/forward/set VCID value */ if (txmtu ==CANXL_MTU )
Signature · 1 line
2.47.3