selftests/bpf: use ASSERT_STRNEQ to factor in long slab cache names
Subsystems (3)
PATCH 1/1 selftests/bpf: use ASSERT_STRNEQ to factor in long slab cache names
subtest_kmem_cache_iter_check_slabinfo() fundamentally compares slab cache names parsed out from /proc/slabinfo against those stored within struct kmem_cache_result. The current problem is that the slab cache name within struct kmem_cache_result is stored within a bounded fixed-length array (sized to SLAB_NAME_MAX(32)), whereas the name parsed out from /proc/slabinfo is not. Meaning, using ASSERT_STREQ() can certainly lead to test failures, particularly when dealing with slab cache names that are longer than SLAB_NAME_MAX(32) bytes. Notably, kmem_cache_create() allows callers to create slab caches with somewhat arbitrarily sized names via its __name identifier argument, so exceeding the SLAB_NAME_MAX(32) limit that is in place now can certainly happen.
Make subtest_kmem_cache_iter_check_slabinfo() more reliable by only checking up to sizeof(struct kmem_cache_result.name) - 1 using ASSERT_STRNEQ().
--- tools/testing/selftests/bpf/prog_tests/kmem_cache_iter.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
tools/testing/selftests/bpf/prog_tests/kmem_cache_iter.c +2 -1
@@ -57,7 +57,8 @@ static void subtest_kmem_cache_iter_check_slabinfo(struct kmem_cache_iter *skel)if (!ASSERT_OK (ret,"kmem_cache_lookup" ))break ; -ASSERT_STREQ (r.name, name,"kmem_cache_name" ); +ASSERT_STRNEQ (r.name, name,sizeof (r.name) -1 , +"kmem_cache_name" );ASSERT_EQ (r.obj_size, objsize,"kmem_cache_objsize" ); seen++;
Signature · 1 line
2.52.0.rc1.455.g30608eb744-goog
Quoted 14 lines · Matt Bobrowski
subtest_kmem_cache_iter_check_slabinfo()fundamentally compares slab cache names parsed out from/proc/slabinfoagainst those stored within structkmem_cache_result. The current problem is that the slab cache name within structkmem_cache_resultis stored within a bounded fixed-length array (sized toSLAB_NAME_MAX(32)), whereas the name parsed out from/proc/slabinfois not. Meaning, usingASSERT_STREQ()can certainly lead to test failures, particularly when dealing with slab cache names that are longer thanSLAB_NAME_MAX(32)bytes. Notably,kmem_cache_create()allows callers to create slab caches with somewhat arbitrarily sized names via its__nameidentifier argument, so exceeding theSLAB_NAME_MAX(32)limit that is in place now can certainly happen.
Quoted 6 lines
Make
subtest_kmem_cache_iter_check_slabinfo()more reliable by only checking up tosizeof(struct kmem_cache_result.name)- 1 usingASSERT_STRNEQ().Fixes a496d0cdc84d ("selftests/bpf: Add a test for kmem_cache_iter")Signed-off-by Matt Bobrowski <[email protected]>
LGTM.
This patch was applied to bpf/bpf-next.git (master) by Martin KaFai Lau <[email protected]>:
Hello:
This patch was applied to bpf/bpf-next.git (master) by Martin KaFai Lau <[email protected]>:
Quoted 13 lines · On Tue, 18 Nov 2025 07:37:34 +0000 you wrote:
subtest_kmem_cache_iter_check_slabinfo()fundamentally compares slab cache names parsed out from/proc/slabinfoagainst those stored within structkmem_cache_result. The current problem is that the slab cache name within structkmem_cache_resultis stored within a bounded fixed-length array (sized toSLAB_NAME_MAX(32)), whereas the name parsed out from/proc/slabinfois not. Meaning, usingASSERT_STREQ()can certainly lead to test failures, particularly when dealing with slab cache names that are longer thanSLAB_NAME_MAX(32)bytes. Notably,kmem_cache_create()allows callers to create slab caches with somewhat arbitrarily sized names via its__nameidentifier argument, so exceeding theSLAB_NAME_MAX(32)limit that is in place now can certainly happen.
Quoted 1 line
[...]
Here is the summary with links:
- [bpf-next] selftests/bpf: use ASSERT_STRNEQ to factor in long slab cache names
https://git.kernel.org/bpf/bpf-next/c/d088da904223
You are awesome, thank you!
Signature · 2 lines
Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html