test_kho: always print restore status
Subsystems (4)
Pratyush Yadav
maintainerPATCH 1/1 test_kho: always print restore status
Currently the KHO test only prints a message on success, and remains silent on failure. This makes it difficult to notice a failing test. A failing test is usually more interesting than a successful one.
Always print the test status after attempting restore.
--- lib/test_kho.c | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-)
lib/test_kho.c +9 -3
@@ -306,7 +306,6 @@ static int kho_test_restore(phys_addr_t fdt_phys)if (err)return err; -pr_info ("KHO restore succeeded\n" );return 0 ; }
@@ -319,8 +318,15 @@ static int __init kho_test_init(void)return 0 ; err =kho_retrieve_subtree (KHO_TEST_FDT , &fdt_phys); -if (!err) -return kho_test_restore (fdt_phys); +if (!err) { + err =kho_test_restore (fdt_phys); +if (err) +pr_err ("KHO restore failed\n" ); +else +pr_info ("KHO restore succeeded\n" ); + +return err; + }if (err != -ENOENT ) {pr_warn ("failed to retrieve %s FDT: %d\n" ,KHO_TEST_FDT , err);
base-commit: f0bfdc2b69f5c600b88ee484c01b213712c63d94
Signature · 1 line
2.47.3
Quoted 8 lines · Pratyush Yadav
Currently the KHO test only prints a message on success, and remains silent on failure. This makes it difficult to notice a failing test. A failing test is usually more interesting than a successful one.
Always print the test status after attempting restore.
Signed-off-by Pratyush Yadav <[email protected]>
Quoted 7 lines · Pratyush Yadav
Currently the KHO test only prints a message on success, and remains silent on failure. This makes it difficult to notice a failing test. A failing test is usually more interesting than a successful one.
Always print the test status after attempting restore.
Signed-off-by Pratyush Yadav <[email protected]>
Quoted 39 lines
--- lib/test_kho.c | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-)lib/test_kho.c +9
-3@@ -306,7 +306,6 @@ static int kho_test_restore(phys_addr_t fdt_phys)if (err)return err; -pr_info ("KHO restore succeeded\n" );return 0 ; }@@ -319,8 +318,15 @@ static int __init kho_test_init(void)return 0 ; err =kho_retrieve_subtree (KHO_TEST_FDT , &fdt_phys); -if (!err) -return kho_test_restore (fdt_phys); +if (!err) { + err =kho_test_restore (fdt_phys); +if (err) +pr_err ("KHO restore failed\n" ); +else +pr_info ("KHO restore succeeded\n" ); + +return err; + }if (err != -ENOENT ) {pr_warn ("failed to retrieve %s FDT: %d\n" ,KHO_TEST_FDT , err);base-commit:
f0bfdc2b69f5c600b88ee484c01b213712c63d94Signature · 1 line
2.47.3
Signature · 2 lines
Sincerely yours, Mike.
Quoted 7 lines · On Tue, 18 Nov 2025 19:10:45 +0100 Pratyush Yadav <[email protected]> wrote:
Currently the KHO test only prints a message on success, and remains silent on failure. This makes it difficult to notice a failing test. A failing test is usually more interesting than a successful one.
Always print the test status after attempting restore.
Signed-off-by Pratyush Yadav <[email protected]>
Thanks,
SJ
[...]