pmdomain: rockchip: quiet regulator error on -EPROBE_DEFER
Subsystems (2)
PATCH 1/1 pmdomain: rockchip: quiet regulator error on -EPROBE_DEFER
From: Chris Morgan <[email protected]>
Change the dev_err() to dev_err_probe() under rockchip_pd_power_on() to prevent errors early in the boot process when the requested regulator is not yet available. This converts errors like the following to debug messages:
rockchip-pm-domain fd8d8000.power-management:power-controller: Failed to enable supply: -517
--- drivers/pmdomain/rockchip/pm-domains.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/pmdomain/rockchip/pm-domains.c +2 -1
@@ -688,7 +688,8 @@ static int rockchip_pd_power_on(struct generic_pm_domain *domain) ret =rockchip_pd_regulator_enable (pd);if (ret) { -dev_err (pd->pmu->dev,"Failed to enable supply: %d\n" , ret); +dev_err_probe (pd->pmu->dev, ret, +"Failed to enable supply: %d\n" , ret);return ret; }
Signature · 1 line
2.43.0
Quoted 19 lines · Chris Morgan
From: Chris Morgan <[email protected]>
Change the
dev_err()todev_err_probe()underrockchip_pd_power_on()to prevent errors early in the boot process when the requested regulator is not yet available. This converts errors like the following to debug messages:rockchip-pm-domain fd8d8000.power-management:power-controller: Failed to enable supply: -517
Signed-off-by Chris Morgan <[email protected]>--- drivers/pmdomain/rockchip/pm-domains.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)drivers/pmdomain/rockchip/pm-domains.c +0
-0
drivers/pmdomain/rockchip/pm-domains.c static int rockchip_pd_power_on(struct generic_pm_domain *domain) · line 693
Quoted 7 lines
drivers/pmdomain/rockchip/pm-domains.c +2
-1@@ -688,7 +688,8 @@ static int rockchip_pd_power_on(struct generic_pm_domain *domain) ret =rockchip_pd_regulator_enable (pd);if (ret) { -dev_err (pd->pmu->dev,"Failed to enable supply: %d\n" , ret); +dev_err_probe (pd->pmu->dev, ret, +"Failed to enable supply: %d\n" , ret);return ret;
return dev_err_probe(pd->pmu->dev, ret, "Failed to enable supply: %d\n", ret); ?
drivers/pmdomain/rockchip/pm-domains.c static int rockchip_pd_power_on(struct generic_pm_domain *domain) · line 695
Quoted 2 lines
drivers/pmdomain/rockchip/pm-domains.c +0
-0}
_______________________________________________
Linux-rockchip mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-rockchip
Quoted 8 lines · Chris Morgan
From: Chris Morgan <[email protected]>
Change the
dev_err()todev_err_probe()underrockchip_pd_power_on()to prevent errors early in the boot process when the requested regulator is not yet available. This converts errors like the following to debug messages:rockchip-pm-domain fd8d8000.power-management:power-controller: Failed to enable supply: -517
I noticed I had a LOT (33 to be exact) of these errors on my Rock 5B. After building a kernel with just this patch added, those were all gone. So feel free to add:
I don't know if it's a logical consequence or just luck, but I'm no longer getting the following error either:
rockchip-pm-domain fd8d8000.power-management:power-controller:
Failed to create device link (0x180) with supplier spi2.0 for
/power-management@fd8d8000/power-controller/power-domain@12I'm still getting the following error though:
rockchip-pm-domain fd8d8000.power-management:power-controller:
Failed to create device link (0x180) with supplier 1-0042 for
/power-management@fd8d8000/power-controller/power-domain@8Those error msgs are broken up for readability, but they are on one line in dmesg.
Thanks!
Diederik
Quoted 19 lines
Signed-off-by Chris Morgan <[email protected]>--- drivers/pmdomain/rockchip/pm-domains.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)drivers/pmdomain/rockchip/pm-domains.c +2
-1@@ -688,7 +688,8 @@ static int rockchip_pd_power_on(struct generic_pm_domain *domain) ret =rockchip_pd_regulator_enable (pd);if (ret) { -dev_err (pd->pmu->dev,"Failed to enable supply: %d\n" , ret); +dev_err_probe (pd->pmu->dev, ret, +"Failed to enable supply: %d\n" , ret);return ret; }