Skip to contentSkip to conversation

net/mlx5: fix metadata sharing between E-Switch and VM

PATCH In review Gregory Etelson 2 participants 2 messages Nov 23, 2025 – Feb 4 Network drivers

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 net/mlx5: fix metadata sharing between E-Switch and VM

If metadata sharing between E-Switch and VM (multi GVMI sharing) is enabled, PMD creates the default metadata copy rule from register A to register C_1 on Tx.
This rule should be created in group 0, but due to an incorrect condition, it was created in group 1.
It prevented propagation of metadata from an application.

This patch fixes the condition by adding the missing check for external rules, so egress group translation applies only to application rules.

Fixes a78425ba3793 ("net/mlx5: support flow metadata between E-Switch and VM")
---
 drivers/net/mlx5/mlx5_flow_hw.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/net/mlx5/mlx5_flow_hw.c +2 -1
index c41b99746f..5932b2cd96 100644
@@ -5347,7 +5347,8 @@ __translate_group(struct rte_eth_dev *dev,
 						  NULL,
 						  "group index not supported");
 		*table_group = group + 1;
-	} else if (mlx5_vport_tx_metadata_passing_enabled(priv->sh) && flow_attr->egress) {
+	} else if (mlx5_vport_tx_metadata_passing_enabled(priv->sh) &&
+		   flow_attr->egress && external) {
 		/*
 		 * If VM cross GVMI metadata Tx was enabled, PMD creates a default
 		 * flow rule in the group 0 to copy metadata value.
Signature · 1 line
2.51.0
#1 lore raw

Hi,

Quoted 7 lines · Gregory Etelson

If metadata sharing between E-Switch and VM (multi GVMI sharing) is enabled, PMD creates the default metadata copy rule from register A to register C_1 on Tx.
This rule should be created in group 0, but due to an incorrect condition, it was created in group 1.
It prevented propagation of metadata from an application.

Quoted 8 lines

This patch fixes the condition by adding the missing check for external rules, so egress group translation applies only to application rules.

Fixes a78425ba3793 ("net/mlx5: support flow metadata between E-Switch and VM")

Patch applied to next-net-mlx,

Kindest regards
Raslan Darawsheh