Skip to contentSkip to conversation

ACPICA: Avoid walking the Namespace if StartNode is NULL

PATCH Applied Cryolitia PukNgae 3 participants 3 messages Nov 25, 2025

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ACPICA: Avoid walking the Namespace if StartNode is NULL

ACPICA commit 1c1b57b9eba4554cb132ee658dd942c0210ed20d

Since commit 0c9992315e73 ("ACPICA: Avoid walking the ACPI Namespace if it is not there") fixed the situation that both StartNode and AcpiGbl_RootNode is NULL. The Linux kernel mainline now still crashed on Honor Magicbook 14 Pro[1]. Due to the access to the member of ParentNode in AcpiNsGetNextNode, the NULL pointer dereference will always happen, no matter whether the StartNode equals to the ACPI_ROOT_OBJECT or not. So we move the check of StartNode being NULL out of the if block.

Unfortunately, all the attempt to contact with Honor has failed, they refused to provide any technical support for Linux. The bad DSDT table's dump could be found on GitHub[2].

DMI: HONOR FMB-P/FMB-P-PCB, BIOS 1.13 05/08/2025

1. https://gist.github.com/Cryolitia/a860ffc97437dcd2cd988371d5b73ed7
2. https://github.com/denis-bb/honor-fmb-p-dsdt

---
 drivers/acpi/acpica/nswalk.c | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)
drivers/acpi/acpica/nswalk.c +6 -3
index a2ac06a26e92..5670ff5a43cd 100644
@@ -169,9 +169,12 @@ acpi_ns_walk_namespace(acpi_object_type type,
 
 	if (start_node == ACPI_ROOT_OBJECT) {
 		start_node = acpi_gbl_root_node;
-		if (!start_node) {
-			return_ACPI_STATUS(AE_NO_NAMESPACE);
-		}
+	}
+
+	/* Avoid walking the namespace if the StartNode is NULL */
+
+	if (!start_node) {
+		return_ACPI_STATUS(AE_NO_NAMESPACE);
 	}
 
 	/* Null child means "get first node" */

---
base-commit: ac3fd01e4c1efce8f2c054cdeb2ddd2fc0fb150d
change-id: 20251125-acpica-efe5a5fc01d9

Best regards,

Signature · 1 line
Cryolitia PukNgae <[email protected]>
maintainer Applied
#2 lore raw
In reply to Cryolitia PukNgae
Quoted 40 lines · Cryolitia PukNgae

ACPICA commit 1c1b57b9eba4554cb132ee658dd942c0210ed20d

Since commit 0c9992315e73 ("ACPICA: Avoid walking the ACPI Namespace if it is not there") fixed the situation that both StartNode and AcpiGbl_RootNode is NULL. The Linux kernel mainline now still crashed on Honor Magicbook 14 Pro[1]. Due to the access to the member of ParentNode in AcpiNsGetNextNode, the NULL pointer dereference will always happen, no matter whether the StartNode equals to the ACPI_ROOT_OBJECT or not. So we move the check of StartNode being NULL out of the if block.

Unfortunately, all the attempt to contact with Honor has failed, they refused to provide any technical support for Linux. The bad DSDT table's dump could be found on GitHub[2].

DMI: HONOR FMB-P/FMB-P-PCB, BIOS 1.13 05/08/2025

1. https://gist.github.com/Cryolitia/a860ffc97437dcd2cd988371d5b73ed7
2. https://github.com/denis-bb/honor-fmb-p-dsdt

---
 drivers/acpi/acpica/nswalk.c | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)
drivers/acpi/acpica/nswalk.c +1 -3
index a2ac06a26e92..5670ff5a43cd 100644
@@ -169,9 +169,12 @@ acpi_ns_walk_namespace(acpi_object_type type,
 
        if (start_node == ACPI_ROOT_OBJECT) {
                start_node = acpi_gbl_root_node;
-               if (!start_node) {
-                       return_ACPI_STATUS(AE_NO_NAMESPACE);
-               }
+       }

drivers/acpi/acpica/nswalk.c acpi_ns_walk_namespace(acpi_object_type type,

Quoted 10 lines
drivers/acpi/acpica/nswalk.c +5 -1
+
+       /* Avoid walking the namespace if the StartNode is NULL */
+
+       if (!start_node) {
+               return_ACPI_STATUS(AE_NO_NAMESPACE);
        }
 
        /* Null child means "get first node" */
 
---

Applied as 6.19 material with adjusted subject and some edits in the changelog.

Thanks!