Skip to contentSkip to conversation

virtio_ring: code cleanup in detach_buf_split

PATCH In review [email protected] 2 participants 2 messages Nov 26, 2025 – Nov 28, 2025 virtio core

lore
Share & tools
lore

[email protected]

author
#0 lore raw

PATCH 1/1 virtio_ring: code cleanup in detach_buf_split

Since the return value of vring_unmap_one_split() is exactly vq->split.desc_extra[i].next, 'i = vq->split.desc_extra[i].next' is redundant. Assign vring_unmap_one_split() to i instead.

Since vq->split.desc_extra is assigned to extra, use extra[i].next instead of vq->split.desc_extra[i].next to improve readability.

No change in functionality.

Signed-off-by zhangdongchuan <[email protected]>
---
 drivers/virtio/virtio_ring.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)
drivers/virtio/virtio_ring.c +2 -3
index 7b6205253b46..0cbf3419a645 100644
@@ -764,13 +764,12 @@ static void detach_buf_split(struct vring_virtqueue *vq, unsigned int head,
 	i = head;
 
 	while (vq->split.vring.desc[i].flags & nextflag) {
-		vring_unmap_one_split(vq, &extra[i]);
-		i = vq->split.desc_extra[i].next;
+		i = vring_unmap_one_split(vq, &extra[i]);
 		vq->vq.num_free++;
 	}
 
 	vring_unmap_one_split(vq, &extra[i]);
-	vq->split.desc_extra[i].next = vq->free_head;
+	extra[i].next = vq->free_head;
 	vq->free_head = head;
 
 	/* Plus final descriptor */
Signature · 1 line
2.34.1
Acked-by on v1 1/1
#1 lore raw
Quoted 5 lines · On Wed, Nov 26, 2025 at 11:41 AM [email protected]…

Since the return value of vring_unmap_one_split() is exactly vq->split.desc_extra[i].next, 'i = vq->split.desc_extra[i].next' is redundant. Assign vring_unmap_one_split() to i instead.

Quoted 7 lines

Since vq->split.desc_extra is assigned to extra, use extra[i].next instead of vq->split.desc_extra[i].next to improve readability.

No change in functionality.

Signed-off-by zhangdongchuan <[email protected]>

---

Acked-by Jason Wang <[email protected]>

Thanks