Skip to contentSkip to conversation

dma-fence: Remove return code of dma_fence_signal() et al.

PATCH Superseded Philipp Stanner 7 participants 32 messages Nov 26, 2025 – Dec 1, 2025

Subsystems (10)

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore

Philipp Stanner

author maintainer
#0 lore raw

cover dma-fence: Remove return code of dma_fence_signal() et al.

Barely anyone uses dma_fence_signal()'s (and similar functions') return code. Checking it is pretty much useless anyways, because what are you going to do if a fence was already signal it? Unsignal it and signal it again? ;p

Removing the return code simplifies the API and makes it easier for me to sit on top with Rust DmaFence.

Philipp Stanner (6):
dma-buf/dma-fence: Add dma_fence_test_signaled_flag() amd/amdkfd: Ignore return code of dma_fence_signal() drm/gpu/xe: Ignore dma_fenc_signal() return code
dma-buf: Don't misuse dma_fence_signal()
drm/ttm: Remove return check of dma_fence_signal() dma-buf/dma-fence: Remove return code of signaling-functions

 drivers/dma-buf/dma-fence.c                   | 59 ++++++-------------
 drivers/dma-buf/st-dma-fence.c                |  7 +--
 drivers/gpu/drm/amd/amdkfd/kfd_process.c      |  5 +-
 .../gpu/drm/ttm/tests/ttm_bo_validate_test.c  |  3 +-
 drivers/gpu/drm/xe/xe_hw_fence.c              |  5 +-
 include/linux/dma-fence.h                     | 33 ++++++++---
 6 files changed, 53 insertions(+), 59 deletions(-)
Signature · 1 line
2.49.0
author maintainer
#1 lore raw

PATCH 1/6 dma-buf/dma-fence: Add dma_fence_test_signaled_flag()

The dma_fence framework checks at many places whether the signaled flag of a fence is already set. The code can be simplified and made more readable by providing a helper function for that.

Add dma_fence_test_signaled_flag(), which only checks whether a fence is signaled. Use it internally.

---
 drivers/dma-buf/dma-fence.c | 19 +++++++++----------
 include/linux/dma-fence.h   | 24 ++++++++++++++++++++++--
 2 files changed, 31 insertions(+), 12 deletions(-)
drivers/dma-buf/dma-fence.c +9 -10
index 39e6f93dc310..25117a906846 100644
@@ -372,8 +372,7 @@ int dma_fence_signal_timestamp_locked(struct dma_fence *fence,
 
 	lockdep_assert_held(fence->lock);
 
-	if (unlikely(test_and_set_bit(DMA_FENCE_FLAG_SIGNALED_BIT,
-				      &fence->flags)))
+	if (unlikely(dma_fence_test_signaled_flag(fence)))
 		return -EINVAL;
 
 	/* Stash the cb_list before replacing it with the timestamp */
@@ -545,7 +544,7 @@ void dma_fence_release(struct kref *kref)
 	trace_dma_fence_destroy(fence);
 
 	if (!list_empty(&fence->cb_list) &&
-	    !test_bit(DMA_FENCE_FLAG_SIGNALED_BIT, &fence->flags)) {
+	    !dma_fence_test_signaled_flag(fence)) {
 		const char __rcu *timeline;
 		const char __rcu *driver;
 		unsigned long flags;
@@ -602,7 +601,7 @@ static bool __dma_fence_enable_signaling(struct dma_fence *fence)
 	was_set = test_and_set_bit(DMA_FENCE_FLAG_ENABLE_SIGNAL_BIT,
 				   &fence->flags);
 
-	if (test_bit(DMA_FENCE_FLAG_SIGNALED_BIT, &fence->flags))
+	if (dma_fence_test_signaled_flag(fence))
 		return false;
 
 	if (!was_set && fence->ops->enable_signaling) {
@@ -666,7 +665,7 @@ int dma_fence_add_callback(struct dma_fence *fence, struct dma_fence_cb *cb,
 	if (WARN_ON(!fence || !func))
 		return -EINVAL;
 
-	if (test_bit(DMA_FENCE_FLAG_SIGNALED_BIT, &fence->flags)) {
+	if (dma_fence_test_signaled_flag(fence)) {
 		INIT_LIST_HEAD(&cb->node);
 		return -ENOENT;
 	}
@@ -783,7 +782,7 @@ dma_fence_default_wait(struct dma_fence *fence, bool intr, signed long timeout)
 
 	spin_lock_irqsave(fence->lock, flags);
 
-	if (test_bit(DMA_FENCE_FLAG_SIGNALED_BIT, &fence->flags))
+	if (dma_fence_test_signaled_flag(fence))
 		goto out;
 
 	if (intr && signal_pending(current)) {
@@ -800,7 +799,7 @@ dma_fence_default_wait(struct dma_fence *fence, bool intr, signed long timeout)
 	cb.task = current;
 	list_add(&cb.base.node, &fence->cb_list);
 
-	while (!test_bit(DMA_FENCE_FLAG_SIGNALED_BIT, &fence->flags) && ret > 0) {
+	while (!dma_fence_test_signaled_flag(fence) && ret > 0) {
 		if (intr)
 			__set_current_state(TASK_INTERRUPTIBLE);
 		else
@@ -832,7 +831,7 @@ dma_fence_test_signaled_any(struct dma_fence **fences, uint32_t count,
 
 	for (i = 0; i < count; ++i) {
 		struct dma_fence *fence = fences[i];
-		if (test_bit(DMA_FENCE_FLAG_SIGNALED_BIT, &fence->flags)) {
+		if (dma_fence_test_signaled_flag(fence)) {
 			if (idx)
 				*idx = i;
 			return true;
@@ -1108,7 +1107,7 @@ const char __rcu *dma_fence_driver_name(struct dma_fence *fence)
 	RCU_LOCKDEP_WARN(!rcu_read_lock_held(),
 			 "RCU protection is required for safe access to returned string");
 
-	if (!test_bit(DMA_FENCE_FLAG_SIGNALED_BIT, &fence->flags))
+	if (!dma_fence_test_signaled_flag(fence))
 		return fence->ops->get_driver_name(fence);
 	else
 		return "detached-driver";
@@ -1140,7 +1139,7 @@ const char __rcu *dma_fence_timeline_name(struct dma_fence *fence)
 	RCU_LOCKDEP_WARN(!rcu_read_lock_held(),
 			 "RCU protection is required for safe access to returned string");
 
-	if (!test_bit(DMA_FENCE_FLAG_SIGNALED_BIT, &fence->flags))
+	if (!dma_fence_test_signaled_flag(fence))
 		return fence->ops->get_timeline_name(fence);
 	else
 		return "signaled-timeline";
include/linux/dma-fence.h +22 -2
index 64639e104110..19972f5d176f 100644
@@ -401,6 +401,26 @@ void dma_fence_enable_sw_signaling(struct dma_fence *fence);
 const char __rcu *dma_fence_driver_name(struct dma_fence *fence);
 const char __rcu *dma_fence_timeline_name(struct dma_fence *fence);
 
+/*
+ * dma_fence_test_signaled_flag - Only check whether a fence is signaled yet.
+ * @fence: the fence to check
+ *
+ * This function just checks whether @fence is signaled, without interacting
+ * with the fence in any way. The user must, therefore, ensure through other
+ * means that fences get signaled eventually.
+ *
+ * This function uses test_bit(), which is thread-safe. Naturally, this function
+ * should be used opportunistically; a fence could get signaled at any moment
+ * after the check is done.
+ *
+ * Return: true if signaled, false otherwise.
+ */
+static inline bool
+dma_fence_test_signaled_flag(struct dma_fence *fence)
+{
+	return test_bit(DMA_FENCE_FLAG_SIGNALED_BIT, &fence->flags);
+}
+
 /**
  * dma_fence_is_signaled_locked - Return an indication if the fence
  *                                is signaled yet.
@@ -418,7 +438,7 @@ const char __rcu *dma_fence_timeline_name(struct dma_fence *fence);
 static inline bool
 dma_fence_is_signaled_locked(struct dma_fence *fence)
 {
-	if (test_bit(DMA_FENCE_FLAG_SIGNALED_BIT, &fence->flags))
+	if (dma_fence_test_signaled_flag(fence))
 		return true;
 
 	if (fence->ops->signaled && fence->ops->signaled(fence)) {
@@ -448,7 +468,7 @@ dma_fence_is_signaled_locked(struct dma_fence *fence)
 static inline bool
 dma_fence_is_signaled(struct dma_fence *fence)
 {
-	if (test_bit(DMA_FENCE_FLAG_SIGNALED_BIT, &fence->flags))
+	if (dma_fence_test_signaled_flag(fence))
 		return true;
 
 	if (fence->ops->signaled && fence->ops->signaled(fence)) {
Signature · 1 line
2.49.0
maintainer Reviewed-by on v1 1/6
#2 lore raw

Re: [PATCH 1/6] dma-buf/dma-fence: Add dma_fence_test_signaled_flag()

Quoted 9 lines · Philipp Stanner

The dma_fence framework checks at many places whether the signaled flag of a fence is already set. The code can be simplified and made more readable by providing a helper function for that.

Add dma_fence_test_signaled_flag(), which only checks whether a fence is signaled. Use it internally.

This is a nice cleanp:

Quoted 143 lines
---
 drivers/dma-buf/dma-fence.c | 19 +++++++++----------
 include/linux/dma-fence.h   | 24 ++++++++++++++++++++++--
 2 files changed, 31 insertions(+), 12 deletions(-)
drivers/dma-buf/dma-fence.c +9 -10
index 39e6f93dc310..25117a906846 100644
@@ -372,8 +372,7 @@ int dma_fence_signal_timestamp_locked(struct dma_fence *fence,
 
 	lockdep_assert_held(fence->lock);
 
-	if (unlikely(test_and_set_bit(DMA_FENCE_FLAG_SIGNALED_BIT,
-				      &fence->flags)))
+	if (unlikely(dma_fence_test_signaled_flag(fence)))
 		return -EINVAL;
 
 	/* Stash the cb_list before replacing it with the timestamp */
@@ -545,7 +544,7 @@ void dma_fence_release(struct kref *kref)
 	trace_dma_fence_destroy(fence);
 
 	if (!list_empty(&fence->cb_list) &&
-	    !test_bit(DMA_FENCE_FLAG_SIGNALED_BIT, &fence->flags)) {
+	    !dma_fence_test_signaled_flag(fence)) {
 		const char __rcu *timeline;
 		const char __rcu *driver;
 		unsigned long flags;
@@ -602,7 +601,7 @@ static bool __dma_fence_enable_signaling(struct dma_fence *fence)
 	was_set = test_and_set_bit(DMA_FENCE_FLAG_ENABLE_SIGNAL_BIT,
 				   &fence->flags);
 
-	if (test_bit(DMA_FENCE_FLAG_SIGNALED_BIT, &fence->flags))
+	if (dma_fence_test_signaled_flag(fence))
 		return false;
 
 	if (!was_set && fence->ops->enable_signaling) {
@@ -666,7 +665,7 @@ int dma_fence_add_callback(struct dma_fence *fence, struct dma_fence_cb *cb,
 	if (WARN_ON(!fence || !func))
 		return -EINVAL;
 
-	if (test_bit(DMA_FENCE_FLAG_SIGNALED_BIT, &fence->flags)) {
+	if (dma_fence_test_signaled_flag(fence)) {
 		INIT_LIST_HEAD(&cb->node);
 		return -ENOENT;
 	}
@@ -783,7 +782,7 @@ dma_fence_default_wait(struct dma_fence *fence, bool intr, signed long timeout)
 
 	spin_lock_irqsave(fence->lock, flags);
 
-	if (test_bit(DMA_FENCE_FLAG_SIGNALED_BIT, &fence->flags))
+	if (dma_fence_test_signaled_flag(fence))
 		goto out;
 
 	if (intr && signal_pending(current)) {
@@ -800,7 +799,7 @@ dma_fence_default_wait(struct dma_fence *fence, bool intr, signed long timeout)
 	cb.task = current;
 	list_add(&cb.base.node, &fence->cb_list);
 
-	while (!test_bit(DMA_FENCE_FLAG_SIGNALED_BIT, &fence->flags) && ret > 0) {
+	while (!dma_fence_test_signaled_flag(fence) && ret > 0) {
 		if (intr)
 			__set_current_state(TASK_INTERRUPTIBLE);
 		else
@@ -832,7 +831,7 @@ dma_fence_test_signaled_any(struct dma_fence **fences, uint32_t count,
 
 	for (i = 0; i < count; ++i) {
 		struct dma_fence *fence = fences[i];
-		if (test_bit(DMA_FENCE_FLAG_SIGNALED_BIT, &fence->flags)) {
+		if (dma_fence_test_signaled_flag(fence)) {
 			if (idx)
 				*idx = i;
 			return true;
@@ -1108,7 +1107,7 @@ const char __rcu *dma_fence_driver_name(struct dma_fence *fence)
 	RCU_LOCKDEP_WARN(!rcu_read_lock_held(),
 			 "RCU protection is required for safe access to returned string");
 
-	if (!test_bit(DMA_FENCE_FLAG_SIGNALED_BIT, &fence->flags))
+	if (!dma_fence_test_signaled_flag(fence))
 		return fence->ops->get_driver_name(fence);
 	else
 		return "detached-driver";
@@ -1140,7 +1139,7 @@ const char __rcu *dma_fence_timeline_name(struct dma_fence *fence)
 	RCU_LOCKDEP_WARN(!rcu_read_lock_held(),
 			 "RCU protection is required for safe access to returned string");
 
-	if (!test_bit(DMA_FENCE_FLAG_SIGNALED_BIT, &fence->flags))
+	if (!dma_fence_test_signaled_flag(fence))
 		return fence->ops->get_timeline_name(fence);
 	else
 		return "signaled-timeline";
include/linux/dma-fence.h +22 -2
index 64639e104110..19972f5d176f 100644
@@ -401,6 +401,26 @@ void dma_fence_enable_sw_signaling(struct dma_fence *fence);
 const char __rcu *dma_fence_driver_name(struct dma_fence *fence);
 const char __rcu *dma_fence_timeline_name(struct dma_fence *fence);
 
+/*
+ * dma_fence_test_signaled_flag - Only check whether a fence is signaled yet.
+ * @fence: the fence to check
+ *
+ * This function just checks whether @fence is signaled, without interacting
+ * with the fence in any way. The user must, therefore, ensure through other
+ * means that fences get signaled eventually.
+ *
+ * This function uses test_bit(), which is thread-safe. Naturally, this function
+ * should be used opportunistically; a fence could get signaled at any moment
+ * after the check is done.
+ *
+ * Return: true if signaled, false otherwise.
+ */
+static inline bool
+dma_fence_test_signaled_flag(struct dma_fence *fence)
+{
+	return test_bit(DMA_FENCE_FLAG_SIGNALED_BIT, &fence->flags);
+}
+
 /**
  * dma_fence_is_signaled_locked - Return an indication if the fence
  *                                is signaled yet.
@@ -418,7 +438,7 @@ const char __rcu *dma_fence_timeline_name(struct dma_fence *fence);
 static inline bool
 dma_fence_is_signaled_locked(struct dma_fence *fence)
 {
-	if (test_bit(DMA_FENCE_FLAG_SIGNALED_BIT, &fence->flags))
+	if (dma_fence_test_signaled_flag(fence))
 		return true;
 
 	if (fence->ops->signaled && fence->ops->signaled(fence)) {
@@ -448,7 +468,7 @@ dma_fence_is_signaled_locked(struct dma_fence *fence)
 static inline bool
 dma_fence_is_signaled(struct dma_fence *fence)
 {
-	if (test_bit(DMA_FENCE_FLAG_SIGNALED_BIT, &fence->flags))
+	if (dma_fence_test_signaled_flag(fence))
 		return true;
 
 	if (fence->ops->signaled && fence->ops->signaled(fence)) {
Signature · 1 line
2.49.0
maintainer
#3 lore raw

Re: [PATCH 1/6] dma-buf/dma-fence: Add dma_fence_test_signaled_flag()

Quoted 25 lines · Matthew Brost
Quoted 9 lines · Philipp Stanner

The dma_fence framework checks at many places whether the signaled flag of a fence is already set. The code can be simplified and made more readable by providing a helper function for that.

Add dma_fence_test_signaled_flag(), which only checks whether a fence is signaled. Use it internally.

This is a nice cleanp:

Quoted 11 lines
---
 drivers/dma-buf/dma-fence.c | 19 +++++++++----------
 include/linux/dma-fence.h   | 24 ++++++++++++++++++++++--
 2 files changed, 31 insertions(+), 12 deletions(-)
drivers/dma-buf/dma-fence.c +0 -0
index 39e6f93dc310..25117a906846 100644
@@ -372,8 +372,7 @@ int dma_fence_signal_timestamp_locked(struct dma_fence *fence,
 
Quoted 4 lines

drivers/dma-buf/dma-fence.c int dma_fence_signal_timestamp_locked(struct dma_fence *fence, · line 376

Quoted 4 lines
drivers/dma-buf/dma-fence.c +0 -2
 	lockdep_assert_held(fence->lock);
 
-	if (unlikely(test_and_set_bit(DMA_FENCE_FLAG_SIGNALED_BIT,
-				      &fence->flags)))

I need to read a little better, I think this change isn't quite right. The original code is test and set, the updated code is test only (i.e., you are missing the set step). So maybe just leave this line as is.

Matt

Quoted 128 lines
Quoted 128 lines
drivers/dma-buf/dma-fence.c +9 -8
+	if (unlikely(dma_fence_test_signaled_flag(fence)))
 		return -EINVAL;
 
 	/* Stash the cb_list before replacing it with the timestamp */
@@ -545,7 +544,7 @@ void dma_fence_release(struct kref *kref)
 	trace_dma_fence_destroy(fence);
 
 	if (!list_empty(&fence->cb_list) &&
-	    !test_bit(DMA_FENCE_FLAG_SIGNALED_BIT, &fence->flags)) {
+	    !dma_fence_test_signaled_flag(fence)) {
 		const char __rcu *timeline;
 		const char __rcu *driver;
 		unsigned long flags;
@@ -602,7 +601,7 @@ static bool __dma_fence_enable_signaling(struct dma_fence *fence)
 	was_set = test_and_set_bit(DMA_FENCE_FLAG_ENABLE_SIGNAL_BIT,
 				   &fence->flags);
 
-	if (test_bit(DMA_FENCE_FLAG_SIGNALED_BIT, &fence->flags))
+	if (dma_fence_test_signaled_flag(fence))
 		return false;
 
 	if (!was_set && fence->ops->enable_signaling) {
@@ -666,7 +665,7 @@ int dma_fence_add_callback(struct dma_fence *fence, struct dma_fence_cb *cb,
 	if (WARN_ON(!fence || !func))
 		return -EINVAL;
 
-	if (test_bit(DMA_FENCE_FLAG_SIGNALED_BIT, &fence->flags)) {
+	if (dma_fence_test_signaled_flag(fence)) {
 		INIT_LIST_HEAD(&cb->node);
 		return -ENOENT;
 	}
@@ -783,7 +782,7 @@ dma_fence_default_wait(struct dma_fence *fence, bool intr, signed long timeout)
 
 	spin_lock_irqsave(fence->lock, flags);
 
-	if (test_bit(DMA_FENCE_FLAG_SIGNALED_BIT, &fence->flags))
+	if (dma_fence_test_signaled_flag(fence))
 		goto out;
 
 	if (intr && signal_pending(current)) {
@@ -800,7 +799,7 @@ dma_fence_default_wait(struct dma_fence *fence, bool intr, signed long timeout)
 	cb.task = current;
 	list_add(&cb.base.node, &fence->cb_list);
 
-	while (!test_bit(DMA_FENCE_FLAG_SIGNALED_BIT, &fence->flags) && ret > 0) {
+	while (!dma_fence_test_signaled_flag(fence) && ret > 0) {
 		if (intr)
 			__set_current_state(TASK_INTERRUPTIBLE);
 		else
@@ -832,7 +831,7 @@ dma_fence_test_signaled_any(struct dma_fence **fences, uint32_t count,
 
 	for (i = 0; i < count; ++i) {
 		struct dma_fence *fence = fences[i];
-		if (test_bit(DMA_FENCE_FLAG_SIGNALED_BIT, &fence->flags)) {
+		if (dma_fence_test_signaled_flag(fence)) {
 			if (idx)
 				*idx = i;
 			return true;
@@ -1108,7 +1107,7 @@ const char __rcu *dma_fence_driver_name(struct dma_fence *fence)
 	RCU_LOCKDEP_WARN(!rcu_read_lock_held(),
 			 "RCU protection is required for safe access to returned string");
 
-	if (!test_bit(DMA_FENCE_FLAG_SIGNALED_BIT, &fence->flags))
+	if (!dma_fence_test_signaled_flag(fence))
 		return fence->ops->get_driver_name(fence);
 	else
 		return "detached-driver";
@@ -1140,7 +1139,7 @@ const char __rcu *dma_fence_timeline_name(struct dma_fence *fence)
 	RCU_LOCKDEP_WARN(!rcu_read_lock_held(),
 			 "RCU protection is required for safe access to returned string");
 
-	if (!test_bit(DMA_FENCE_FLAG_SIGNALED_BIT, &fence->flags))
+	if (!dma_fence_test_signaled_flag(fence))
 		return fence->ops->get_timeline_name(fence);
 	else
 		return "signaled-timeline";
include/linux/dma-fence.h +22 -2
index 64639e104110..19972f5d176f 100644
@@ -401,6 +401,26 @@ void dma_fence_enable_sw_signaling(struct dma_fence *fence);
 const char __rcu *dma_fence_driver_name(struct dma_fence *fence);
 const char __rcu *dma_fence_timeline_name(struct dma_fence *fence);
 
+/*
+ * dma_fence_test_signaled_flag - Only check whether a fence is signaled yet.
+ * @fence: the fence to check
+ *
+ * This function just checks whether @fence is signaled, without interacting
+ * with the fence in any way. The user must, therefore, ensure through other
+ * means that fences get signaled eventually.
+ *
+ * This function uses test_bit(), which is thread-safe. Naturally, this function
+ * should be used opportunistically; a fence could get signaled at any moment
+ * after the check is done.
+ *
+ * Return: true if signaled, false otherwise.
+ */
+static inline bool
+dma_fence_test_signaled_flag(struct dma_fence *fence)
+{
+	return test_bit(DMA_FENCE_FLAG_SIGNALED_BIT, &fence->flags);
+}
+
 /**
  * dma_fence_is_signaled_locked - Return an indication if the fence
  *                                is signaled yet.
@@ -418,7 +438,7 @@ const char __rcu *dma_fence_timeline_name(struct dma_fence *fence);
 static inline bool
 dma_fence_is_signaled_locked(struct dma_fence *fence)
 {
-	if (test_bit(DMA_FENCE_FLAG_SIGNALED_BIT, &fence->flags))
+	if (dma_fence_test_signaled_flag(fence))
 		return true;
 
 	if (fence->ops->signaled && fence->ops->signaled(fence)) {
@@ -448,7 +468,7 @@ dma_fence_is_signaled_locked(struct dma_fence *fence)
 static inline bool
 dma_fence_is_signaled(struct dma_fence *fence)
 {
-	if (test_bit(DMA_FENCE_FLAG_SIGNALED_BIT, &fence->flags))
+	if (dma_fence_test_signaled_flag(fence))
 		return true;
 
 	if (fence->ops->signaled && fence->ops->signaled(fence)) {
Signature · 1 line
2.49.0
maintainer
#4 lore raw

Re: [PATCH 1/6] dma-buf/dma-fence: Add dma_fence_test_signaled_flag()

Quoted 26 lines · Matthew Brost
Quoted 25 lines · Matthew Brost
Quoted 9 lines · Philipp Stanner

The dma_fence framework checks at many places whether the signaled flag of a fence is already set. The code can be simplified and made more readable by providing a helper function for that.

Add dma_fence_test_signaled_flag(), which only checks whether a fence is signaled. Use it internally.

This is a nice cleanp:

Quoted 11 lines
---
 drivers/dma-buf/dma-fence.c | 19 +++++++++----------
 include/linux/dma-fence.h   | 24 ++++++++++++++++++++++--
 2 files changed, 31 insertions(+), 12 deletions(-)
drivers/dma-buf/dma-fence.c +0 -0
index 39e6f93dc310..25117a906846 100644
@@ -372,8 +372,7 @@ int dma_fence_signal_timestamp_locked(struct dma_fence *fence,
 
Quoted 8 lines
Quoted 4 lines

drivers/dma-buf/dma-fence.c int dma_fence_signal_timestamp_locked(struct dma_fence *fence, · line 376

Quoted 4 lines
drivers/dma-buf/dma-fence.c +0 -2
 	lockdep_assert_held(fence->lock);
 
-	if (unlikely(test_and_set_bit(DMA_FENCE_FLAG_SIGNALED_BIT,
-				      &fence->flags)))

I need to read a little better, I think this change isn't quite right. The original code is test and set, the updated code is test only (i.e., you are missing the set step). So maybe just leave this line as is.

Oh, good point! I've totally missed that as well.

But that means that this patch set hasn't even been smoke tested.

Regards,
Christian.

Quoted 131 lines

Matt

Quoted 128 lines
Quoted 128 lines
drivers/dma-buf/dma-fence.c +9 -8
+	if (unlikely(dma_fence_test_signaled_flag(fence)))
 		return -EINVAL;
 
 	/* Stash the cb_list before replacing it with the timestamp */
@@ -545,7 +544,7 @@ void dma_fence_release(struct kref *kref)
 	trace_dma_fence_destroy(fence);
 
 	if (!list_empty(&fence->cb_list) &&
-	    !test_bit(DMA_FENCE_FLAG_SIGNALED_BIT, &fence->flags)) {
+	    !dma_fence_test_signaled_flag(fence)) {
 		const char __rcu *timeline;
 		const char __rcu *driver;
 		unsigned long flags;
@@ -602,7 +601,7 @@ static bool __dma_fence_enable_signaling(struct dma_fence *fence)
 	was_set = test_and_set_bit(DMA_FENCE_FLAG_ENABLE_SIGNAL_BIT,
 				   &fence->flags);
 
-	if (test_bit(DMA_FENCE_FLAG_SIGNALED_BIT, &fence->flags))
+	if (dma_fence_test_signaled_flag(fence))
 		return false;
 
 	if (!was_set && fence->ops->enable_signaling) {
@@ -666,7 +665,7 @@ int dma_fence_add_callback(struct dma_fence *fence, struct dma_fence_cb *cb,
 	if (WARN_ON(!fence || !func))
 		return -EINVAL;
 
-	if (test_bit(DMA_FENCE_FLAG_SIGNALED_BIT, &fence->flags)) {
+	if (dma_fence_test_signaled_flag(fence)) {
 		INIT_LIST_HEAD(&cb->node);
 		return -ENOENT;
 	}
@@ -783,7 +782,7 @@ dma_fence_default_wait(struct dma_fence *fence, bool intr, signed long timeout)
 
 	spin_lock_irqsave(fence->lock, flags);
 
-	if (test_bit(DMA_FENCE_FLAG_SIGNALED_BIT, &fence->flags))
+	if (dma_fence_test_signaled_flag(fence))
 		goto out;
 
 	if (intr && signal_pending(current)) {
@@ -800,7 +799,7 @@ dma_fence_default_wait(struct dma_fence *fence, bool intr, signed long timeout)
 	cb.task = current;
 	list_add(&cb.base.node, &fence->cb_list);
 
-	while (!test_bit(DMA_FENCE_FLAG_SIGNALED_BIT, &fence->flags) && ret > 0) {
+	while (!dma_fence_test_signaled_flag(fence) && ret > 0) {
 		if (intr)
 			__set_current_state(TASK_INTERRUPTIBLE);
 		else
@@ -832,7 +831,7 @@ dma_fence_test_signaled_any(struct dma_fence **fences, uint32_t count,
 
 	for (i = 0; i < count; ++i) {
 		struct dma_fence *fence = fences[i];
-		if (test_bit(DMA_FENCE_FLAG_SIGNALED_BIT, &fence->flags)) {
+		if (dma_fence_test_signaled_flag(fence)) {
 			if (idx)
 				*idx = i;
 			return true;
@@ -1108,7 +1107,7 @@ const char __rcu *dma_fence_driver_name(struct dma_fence *fence)
 	RCU_LOCKDEP_WARN(!rcu_read_lock_held(),
 			 "RCU protection is required for safe access to returned string");
 
-	if (!test_bit(DMA_FENCE_FLAG_SIGNALED_BIT, &fence->flags))
+	if (!dma_fence_test_signaled_flag(fence))
 		return fence->ops->get_driver_name(fence);
 	else
 		return "detached-driver";
@@ -1140,7 +1139,7 @@ const char __rcu *dma_fence_timeline_name(struct dma_fence *fence)
 	RCU_LOCKDEP_WARN(!rcu_read_lock_held(),
 			 "RCU protection is required for safe access to returned string");
 
-	if (!test_bit(DMA_FENCE_FLAG_SIGNALED_BIT, &fence->flags))
+	if (!dma_fence_test_signaled_flag(fence))
 		return fence->ops->get_timeline_name(fence);
 	else
 		return "signaled-timeline";
include/linux/dma-fence.h +22 -2
index 64639e104110..19972f5d176f 100644
@@ -401,6 +401,26 @@ void dma_fence_enable_sw_signaling(struct dma_fence *fence);
 const char __rcu *dma_fence_driver_name(struct dma_fence *fence);
 const char __rcu *dma_fence_timeline_name(struct dma_fence *fence);
 
+/*
+ * dma_fence_test_signaled_flag - Only check whether a fence is signaled yet.
+ * @fence: the fence to check
+ *
+ * This function just checks whether @fence is signaled, without interacting
+ * with the fence in any way. The user must, therefore, ensure through other
+ * means that fences get signaled eventually.
+ *
+ * This function uses test_bit(), which is thread-safe. Naturally, this function
+ * should be used opportunistically; a fence could get signaled at any moment
+ * after the check is done.
+ *
+ * Return: true if signaled, false otherwise.
+ */
+static inline bool
+dma_fence_test_signaled_flag(struct dma_fence *fence)
+{
+	return test_bit(DMA_FENCE_FLAG_SIGNALED_BIT, &fence->flags);
+}
+
 /**
  * dma_fence_is_signaled_locked - Return an indication if the fence
  *                                is signaled yet.
@@ -418,7 +438,7 @@ const char __rcu *dma_fence_timeline_name(struct dma_fence *fence);
 static inline bool
 dma_fence_is_signaled_locked(struct dma_fence *fence)
 {
-	if (test_bit(DMA_FENCE_FLAG_SIGNALED_BIT, &fence->flags))
+	if (dma_fence_test_signaled_flag(fence))
 		return true;
 
 	if (fence->ops->signaled && fence->ops->signaled(fence)) {
@@ -448,7 +468,7 @@ dma_fence_is_signaled_locked(struct dma_fence *fence)
 static inline bool
 dma_fence_is_signaled(struct dma_fence *fence)
 {
-	if (test_bit(DMA_FENCE_FLAG_SIGNALED_BIT, &fence->flags))
+	if (dma_fence_test_signaled_flag(fence))
 		return true;
 
 	if (fence->ops->signaled && fence->ops->signaled(fence)) {
Signature · 1 line
2.49.0
#5 lore raw

Re: [PATCH 1/6] dma-buf/dma-fence: Add dma_fence_test_signaled_flag()

Quoted 36 lines · Christian König
Quoted 20 lines · Matthew Brost
Quoted 19 lines · Matthew Brost
Quoted 9 lines · Philipp Stanner

The dma_fence framework checks at many places whether the signaled flag of a fence is already set. The code can be simplified and made more readable by providing a helper function for that.

Add dma_fence_test_signaled_flag(), which only checks whether a fence is signaled. Use it internally.

This is a nice cleanp:

Quoted 5 lines

---
 drivers/dma-buf/dma-fence.c | 19 +++++++++---------- include/linux/dma-fence.h   | 24 ++++++++++++++++++++++--

 2 files changed, 31 insertions(+), 12 deletions(-)
Quoted 14 lines
Quoted 10 lines

drivers/dma-buf/dma-fence.c int dma_fence_signal_timestamp_locked(struct dma_fence *fence, · line 376

Quoted 10 lines
drivers/dma-buf/dma-fence.c +0 -0
index 39e6f93dc310..25117a906846 100644
@@ -372,8 +372,7 @@ int dma_fence_signal_timestamp_locked(struct dma_fence *fence,


  lockdep_assert_held(fence->lock);

drivers/dma-buf/dma-fence.c +0 -2
-	if (unlikely(test_and_set_bit(DMA_FENCE_FLAG_SIGNALED_BIT,
-				      &fence->flags)))

I need to read a little better, I think this change isn't quite right. The original code is test and set, the updated code is test only (i.e., you are missing the set step). So maybe just leave this line as is.

Quoted 1 line

Oh, good point! I've totally missed that as well.

Oh dear; I also just saw it when opening the mail client ._.

Quoted 2 lines

But that means that this patch set hasn't even been smoke tested.

I've built it and did some basic testing with my Nouveau system. Any suggestions? Do you have a CI that one can trigger?

Thx
P.

maintainer
#6 lore raw

Re: [PATCH 1/6] dma-buf/dma-fence: Add dma_fence_test_signaled_flag()

Quoted 39 lines · Philipp Stanner
Quoted 36 lines · Christian König
Quoted 20 lines · Matthew Brost
Quoted 19 lines · Matthew Brost
Quoted 9 lines · Philipp Stanner

The dma_fence framework checks at many places whether the signaled flag of a fence is already set. The code can be simplified and made more readable by providing a helper function for that.

Add dma_fence_test_signaled_flag(), which only checks whether a fence is signaled. Use it internally.

This is a nice cleanp:

Quoted 5 lines

---
 drivers/dma-buf/dma-fence.c | 19 +++++++++---------- include/linux/dma-fence.h   | 24 ++++++++++++++++++++++--

 2 files changed, 31 insertions(+), 12 deletions(-)
Quoted 14 lines
Quoted 10 lines

drivers/dma-buf/dma-fence.c int dma_fence_signal_timestamp_locked(struct dma_fence *fence, · line 376

Quoted 10 lines
drivers/dma-buf/dma-fence.c +0 -0
index 39e6f93dc310..25117a906846 100644
@@ -372,8 +372,7 @@ int dma_fence_signal_timestamp_locked(struct dma_fence *fence,


  lockdep_assert_held(fence->lock);

drivers/dma-buf/dma-fence.c +0 -2
-	if (unlikely(test_and_set_bit(DMA_FENCE_FLAG_SIGNALED_BIT,
-				      &fence->flags)))

I need to read a little better, I think this change isn't quite right. The original code is test and set, the updated code is test only (i.e., you are missing the set step). So maybe just leave this line as is.

Quoted 1 line

Oh, good point! I've totally missed that as well.

Quoted 7 lines

Oh dear; I also just saw it when opening the mail client ._.

Quoted 2 lines

But that means that this patch set hasn't even been smoke tested.

I've built it and did some basic testing with my Nouveau system. Any suggestions? Do you have a CI that one can trigger?

DMA-buf has CONFIG_DMABUF_SELFTESTS which should be able to catch things like that.

But even running Nouveau should have found this since basically no fence at would signal any more.

Regards,
Christian.

Quoted 3 lines

Thx
P.

#7 lore raw

Re: [PATCH 1/6] dma-buf/dma-fence: Add dma_fence_test_signaled_flag()

Quoted 43 lines · Christian König
Quoted 42 lines · Philipp Stanner
Quoted 36 lines · Christian König
Quoted 20 lines · Matthew Brost
Quoted 19 lines · Matthew Brost
Quoted 9 lines · Philipp Stanner

The dma_fence framework checks at many places whether the signaled flag of a fence is already set. The code can be simplified and made more readable by providing a helper function for that.

Add dma_fence_test_signaled_flag(), which only checks whether a fence is signaled. Use it internally.

This is a nice cleanp:

Quoted 5 lines

---
 drivers/dma-buf/dma-fence.c | 19 +++++++++---------- include/linux/dma-fence.h   | 24 ++++++++++++++++++++++--

 2 files changed, 31 insertions(+), 12 deletions(-)
Quoted 14 lines
Quoted 10 lines

drivers/dma-buf/dma-fence.c int dma_fence_signal_timestamp_locked(struct dma_fence *fence, · line 376

Quoted 10 lines
drivers/dma-buf/dma-fence.c +0 -0
index 39e6f93dc310..25117a906846 100644
@@ -372,8 +372,7 @@ int dma_fence_signal_timestamp_locked(struct dma_fence *fence,


  lockdep_assert_held(fence->lock);

drivers/dma-buf/dma-fence.c +0 -2
-	if (unlikely(test_and_set_bit(DMA_FENCE_FLAG_SIGNALED_BIT,
-				      &fence->flags)))

I need to read a little better, I think this change isn't quite right. The original code is test and set, the updated code is test only (i.e., you are missing the set step). So maybe just leave this line as is.

Quoted 1 line

Oh, good point! I've totally missed that as well.

Oh dear; I also just saw it when opening the mail client ._.

Quoted 1 line
Quoted 8 lines
Quoted 4 lines
Quoted 1 line

But that means that this patch set hasn't even been smoke tested.

I've built it and did some basic testing with my Nouveau system. Any suggestions? Do you have a CI that one can trigger?

DMA-buf has CONFIG_DMABUF_SELFTESTS which should be able to catch things like that.

But even running Nouveau should have found this since basically no fence at would signal any more.

They will signal and execute their callbacks, but all is_signaled() checks are then broken.

Thx for the feedback, I'll be more careful with changes like those and test more extensively.

P.

maintainer
#8 lore raw

Re: [PATCH 1/6] dma-buf/dma-fence: Add dma_fence_test_signaled_flag()

Quoted 41 lines · Philipp Stanner
Quoted 40 lines · Christian König
Quoted 39 lines · Philipp Stanner
Quoted 37 lines · Christian König
Quoted 20 lines · Matthew Brost
Quoted 19 lines · Matthew Brost
Quoted 9 lines · Philipp Stanner

The dma_fence framework checks at many places whether the signaled flag of a fence is already set. The code can be simplified and made more readable by providing a helper function for that.

Add dma_fence_test_signaled_flag(), which only checks whether a fence is signaled. Use it internally.

This is a nice cleanp:

Quoted 5 lines

---
 drivers/dma-buf/dma-fence.c | 19 +++++++++---------- include/linux/dma-fence.h   | 24 ++++++++++++++++++++++--

 2 files changed, 31 insertions(+), 12 deletions(-)
Quoted 14 lines
Quoted 10 lines

drivers/dma-buf/dma-fence.c

Quoted 10 lines
drivers/dma-buf/dma-fence.c +0 -0
index 39e6f93dc310..25117a906846 100644
@@ -372,8 +372,7 @@ int dma_fence_signal_timestamp_locked(struct dma_fence *fence,


  lockdep_assert_held(fence->lock);

drivers/dma-buf/dma-fence.c +0 -2
-	if (unlikely(test_and_set_bit(DMA_FENCE_FLAG_SIGNALED_BIT,
-				      &fence->flags)))

I need to read a little better, I think this change isn't quite right. The original code is test and set, the updated code is test only (i.e., you are missing the set step). So maybe just leave this line as is.

Oh, good point! I've totally missed that as well.

Quoted 7 lines
Quoted 7 lines
Quoted 7 lines

Oh dear; I also just saw it when opening the mail client ._.

Quoted 2 lines

But that means that this patch set hasn't even been smoke tested.

I've built it and did some basic testing with my Nouveau system. Any suggestions? Do you have a CI that one can trigger?

Intel's Xe list will trigger CI - you are authorized to trigger that flow. Navigate to Intel's list patchworks [1], find your series and see the results. It is noisy, so also certainly to say failure but I let you know if anything is actually a problem.

Matt

[1] https://patchwork.freedesktop.org/project/intel-xe/series/?ordering=-last_updated

Quoted 12 lines
Quoted 4 lines

DMA-buf has CONFIG_DMABUF_SELFTESTS which should be able to catch things like that.

But even running Nouveau should have found this since basically no fence at would signal any more.

They will signal and execute their callbacks, but all is_signaled() checks are then broken.

Thx for the feedback, I'll be more careful with changes like those and test more extensively.

P.

#9 lore raw

Re: [PATCH 1/6] dma-buf/dma-fence: Add dma_fence_test_signaled_flag()

In reply to Philipp Stanner

Hi Philipp,

drivers/dma-buf/dma-fence.c int dma_fence_signal_timestamp_locked(struct dma_fence *fence, · line 376

Quoted 12 lines
drivers/dma-buf/dma-fence.c +1 -2
index 39e6f93dc310..25117a906846 100644
@@ -372,8 +372,7 @@ int dma_fence_signal_timestamp_locked(struct dma_fence *fence,
 
 	lockdep_assert_held(fence->lock);
 
-	if (unlikely(test_and_set_bit(DMA_FENCE_FLAG_SIGNALED_BIT,
-				      &fence->flags)))
+	if (unlikely(dma_fence_test_signaled_flag(fence)))
 		return -EINVAL;

Please, drop this change.

Andi

author maintainer
#10 lore raw

PATCH 2/6 amd/amdkfd: Ignore return code of dma_fence_signal()

In reply to Philipp Stanner

The return code of dma_fence_signal() is not really useful as there is nothing reasonable to do if a fence was already signaled. That return code shall be removed from the kernel.

Ignore dma_fence_signal()'s return code.

---
 drivers/gpu/drm/amd/amdkfd/kfd_process.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)
drivers/gpu/drm/amd/amdkfd/kfd_process.c +2 -3
index ddfe30c13e9d..950fafa4b3c3 100644
@@ -1986,7 +1986,6 @@ kfd_process_gpuid_from_node(struct kfd_process *p, struct kfd_node *node,
 static int signal_eviction_fence(struct kfd_process *p)
 {
 	struct dma_fence *ef;
-	int ret;
 
 	rcu_read_lock();
 	ef = dma_fence_get_rcu_safe(&p->ef);
@@ -1994,10 +1993,10 @@ static int signal_eviction_fence(struct kfd_process *p)
 	if (!ef)
 		return -EINVAL;
 
-	ret = dma_fence_signal(ef);
+	dma_fence_signal(ef);
 	dma_fence_put(ef);
 
-	return ret;
+	return 0;
 }
 
 static void evict_process_worker(struct work_struct *work)
Signature · 1 line
2.49.0
maintainer
#11 lore raw

Re: [PATCH 2/6] amd/amdkfd: Ignore return code of dma_fence_signal()

Quoted 5 lines · Philipp Stanner

The return code of dma_fence_signal() is not really useful as there is nothing reasonable to do if a fence was already signaled. That return code shall be removed from the kernel.

Ignore dma_fence_signal()'s return code.

I think this is not correct. Looking at the comment in evict_process_worker, we use the return value to decide a race conditions where multiple threads are trying to signal the eviction fence. Only one of them should schedule the restore work. And the other ones need to increment the reference count to keep evictions balanced.

Regards,
  Felix

Quoted 32 lines
---
  drivers/gpu/drm/amd/amdkfd/kfd_process.c | 5 ++---
  1 file changed, 2 insertions(+), 3 deletions(-)
drivers/gpu/drm/amd/amdkfd/kfd_process.c +2 -3
index ddfe30c13e9d..950fafa4b3c3 100644
@@ -1986,7 +1986,6 @@ kfd_process_gpuid_from_node(struct kfd_process *p, struct kfd_node *node,
  static int signal_eviction_fence(struct kfd_process *p)
  {
  	struct dma_fence *ef;
-	int ret;
 
  	rcu_read_lock();
  	ef = dma_fence_get_rcu_safe(&p->ef);
@@ -1994,10 +1993,10 @@ static int signal_eviction_fence(struct kfd_process *p)
  	if (!ef)
  		return -EINVAL;
 
-	ret = dma_fence_signal(ef);
+	dma_fence_signal(ef);
  	dma_fence_put(ef);
 
-	return ret;
+	return 0;
  }
 
  static void evict_process_worker(struct work_struct *work)
#12 lore raw

Re: [PATCH 2/6] amd/amdkfd: Ignore return code of dma_fence_signal()

Quoted 6 lines · Felix
Quoted 4 lines · Philipp Stanner

The return code of dma_fence_signal() is not really useful as there is nothing reasonable to do if a fence was already signaled. That return code shall be removed from the kernel.

Quoted 7 lines
Quoted 1 line

Ignore dma_fence_signal()'s return code.

I think this is not correct. Looking at the comment in evict_process_worker, we use the return value to decide a race conditions where multiple threads are trying to signal the eviction fence. Only one of them should schedule the restore work. And the other ones need to increment the reference count to keep evictions balanced.

Thank you for pointing that out. Seems then amdkfd is the only user who actually relies on the feature. See below

Quoted 22 lines

Regards,
   Felix

Quoted 17 lines

---
  drivers/gpu/drm/amd/amdkfd/kfd_process.c | 5 ++---

  1 file changed, 2 insertions(+), 3 deletions(-)
drivers/gpu/drm/amd/amdkfd/kfd_process.c +0 -1
index ddfe30c13e9d..950fafa4b3c3 100644
@@ -1986,7 +1986,6 @@ kfd_process_gpuid_from_node(struct kfd_process *p, struct kfd_node *node,
   static int signal_eviction_fence(struct kfd_process *p)
   {
   	struct dma_fence *ef;
-	int ret;

Quoted 8 lines

drivers/gpu/drm/amd/amdkfd/kfd_process.c static int signal_eviction_fence(struct kfd_process *p) · line 1996

Quoted 8 lines

   rcu_read_lock();
   ef = dma_fence_get_rcu_safe(&p->ef);

drivers/gpu/drm/amd/amdkfd/kfd_process.c +0 -0
@@ -1994,10 +1993,10 @@ static int signal_eviction_fence(struct kfd_process *p)
   	if (!ef)
   		return -EINVAL;

drivers/gpu/drm/amd/amdkfd/kfd_process.c +1 -1
-	ret = dma_fence_signal(ef);
+	dma_fence_signal(ef);

The issue now is that dma_fence_signal()'s return code is actually non- racy, because check + bit-set are protected by lock.

Christian's new spinlock series would add a lock function for fences:
https://lore.kernel.org/dri-devel/[email protected]/

So I suppose this should work:

dma_fence_lock_irqsave(ef, flags);

if (dma_fence_test_signaled_flag(ef)) {
	dma_fence_unlock_irqrestore(ef, flags);
	return true;
}

dma_fence_signal_locked(ef);
dma_fence_unlock_irqrestore(ef, flags);

return false;

+ some cosmetic adjustments for the boolean of course.

Would that fly and be reasonable? @Felix, Christian.

P.

maintainer
#13 lore raw

Re: [PATCH 2/6] amd/amdkfd: Ignore return code of dma_fence_signal()

Quoted 66 lines · Philipp Stanner
Quoted 6 lines · Felix
Quoted 4 lines · Philipp Stanner

The return code of dma_fence_signal() is not really useful as there is nothing reasonable to do if a fence was already signaled. That return code shall be removed from the kernel.

Quoted 7 lines
Quoted 1 line

Ignore dma_fence_signal()'s return code.

I think this is not correct. Looking at the comment in evict_process_worker, we use the return value to decide a race conditions where multiple threads are trying to signal the eviction fence. Only one of them should schedule the restore work. And the other ones need to increment the reference count to keep evictions balanced.

Thank you for pointing that out. Seems then amdkfd is the only user who actually relies on the feature. See below

Quoted 22 lines

Regards,
   Felix

Quoted 17 lines

---
  drivers/gpu/drm/amd/amdkfd/kfd_process.c | 5 ++---

  1 file changed, 2 insertions(+), 3 deletions(-)
drivers/gpu/drm/amd/amdkfd/kfd_process.c +0 -1
index ddfe30c13e9d..950fafa4b3c3 100644
@@ -1986,7 +1986,6 @@ kfd_process_gpuid_from_node(struct kfd_process *p, struct kfd_node *node,
   static int signal_eviction_fence(struct kfd_process *p)
   {
   	struct dma_fence *ef;
-	int ret;

Quoted 8 lines

drivers/gpu/drm/amd/amdkfd/kfd_process.c static int signal_eviction_fence(struct kfd_process *p) · line 1996

Quoted 8 lines

   rcu_read_lock();
   ef = dma_fence_get_rcu_safe(&p->ef);

drivers/gpu/drm/amd/amdkfd/kfd_process.c +0 -0
@@ -1994,10 +1993,10 @@ static int signal_eviction_fence(struct kfd_process *p)
   	if (!ef)
   		return -EINVAL;

drivers/gpu/drm/amd/amdkfd/kfd_process.c +1 -1
-	ret = dma_fence_signal(ef);
+	dma_fence_signal(ef);

The issue now is that dma_fence_signal()'s return code is actually non- racy, because check + bit-set are protected by lock.

Christian's new spinlock series would add a lock function for fences:
https://lore.kernel.org/dri-devel/[email protected]/

So I suppose this should work:

dma_fence_lock_irqsave(ef, flags);

if (dma_fence_test_signaled_flag(ef)) {
	dma_fence_unlock_irqrestore(ef, flags);
	return true;
}

dma_fence_signal_locked(ef);
dma_fence_unlock_irqrestore(ef, flags);

Quoted 7 lines

return false;

+ some cosmetic adjustments for the boolean of course.

Would that fly and be reasonable? @Felix, Christian.

I was just about to reply with the same idea when your mail arrived.

So yes looks totally reasonable to me.

Regards,
Christian.

Quoted 3 lines

P.

maintainer
#14 lore raw

Re: [PATCH 2/6] amd/amdkfd: Ignore return code of dma_fence_signal()

Quoted 61 lines · Christian König
Quoted 60 lines · Philipp Stanner
Quoted 11 lines · Felix
Quoted 5 lines · Philipp Stanner

The return code of dma_fence_signal() is not really useful as there is nothing reasonable to do if a fence was already signaled. That return code shall be removed from the kernel.

Ignore dma_fence_signal()'s return code.

I think this is not correct. Looking at the comment in evict_process_worker, we use the return value to decide a race conditions where multiple threads are trying to signal the eviction fence. Only one of them should schedule the restore work. And the other ones need to increment the reference count to keep evictions balanced.

Thank you for pointing that out. Seems then amdkfd is the only user who actually relies on the feature. See below

Quoted 20 lines

Regards,
   Felix

Quoted 16 lines
---
   drivers/gpu/drm/amd/amdkfd/kfd_process.c | 5 ++---
   1 file changed, 2 insertions(+), 3 deletions(-)
drivers/gpu/drm/amd/amdkfd/kfd_process.c +0 -1
index ddfe30c13e9d..950fafa4b3c3 100644
@@ -1986,7 +1986,6 @@ kfd_process_gpuid_from_node(struct kfd_process *p, struct kfd_node *node,
   static int signal_eviction_fence(struct kfd_process *p)
   {
   	struct dma_fence *ef;
-	int ret;
 
Quoted 8 lines

drivers/gpu/drm/amd/amdkfd/kfd_process.c static int signal_eviction_fence(struct kfd_process *p) · line 1996

Quoted 8 lines
drivers/gpu/drm/amd/amdkfd/kfd_process.c +1 -1
   	rcu_read_lock();
   	ef = dma_fence_get_rcu_safe(&p->ef);
@@ -1994,10 +1993,10 @@ static int signal_eviction_fence(struct kfd_process *p)
   	if (!ef)
   		return -EINVAL;
 
-	ret = dma_fence_signal(ef);
+	dma_fence_signal(ef);

The issue now is that dma_fence_signal()'s return code is actually non- racy, because check + bit-set are protected by lock.

Christian's new spinlock series would add a lock function for fences:
https://lore.kernel.org/dri-devel/[email protected]/

So I suppose this should work:

dma_fence_lock_irqsave(ef, flags);

if (dma_fence_test_signaled_flag(ef)) {
	dma_fence_unlock_irqrestore(ef, flags);
	return true;
}

dma_fence_signal_locked(ef);
dma_fence_unlock_irqrestore(ef, flags);

Quoted 8 lines
Quoted 7 lines

return false;

+ some cosmetic adjustments for the boolean of course.

Would that fly and be reasonable? @Felix, Christian.

I was just about to reply with the same idea when your mail arrived.

I agree as well. The important feature is that we need to test and signal the fence atomically. It may even make sense to add a function for that "dma_fence_test_and_signal" that preserves the original behaviour of dma_fence_signal. ;)

Regards,
  Felix

Quoted 8 lines

So yes looks totally reasonable to me.

Regards,
Christian.

Quoted 2 lines

P.

#15 lore raw

Re: [PATCH 2/6] amd/amdkfd: Ignore return code of dma_fence_signal()

Quoted 3 lines · Felix
Quoted 2 lines · Christian König
Quoted 1 line · Philipp Stanner

[…]

Quoted 23 lines
Quoted 23 lines
Quoted 23 lines

The issue now is that dma_fence_signal()'s return code is actually non- racy, because check + bit-set are protected by lock.

Christian's new spinlock series would add a lock function for fences:
https://lore.kernel.org/dri-devel/[email protected]/

So I suppose this should work:

dma_fence_lock_irqsave(ef, flags);

if (dma_fence_test_signaled_flag(ef)) {
	dma_fence_unlock_irqrestore(ef, flags);
	return true;
}

dma_fence_signal_locked(ef);
dma_fence_unlock_irqrestore(ef, flags);

return false;

+ some cosmetic adjustments for the boolean of course.

Quoted 7 lines
Quoted 2 lines
Quoted 1 line

Would that fly and be reasonable? @Felix, Christian.

I was just about to reply with the same idea when your mail arrived.

I agree as well. The important feature is that we need to test and signal the fence atomically. It may even make sense to add a function for that "dma_fence_test_and_signal" that preserves the original behaviour of dma_fence_signal. ;)

Fine by me if the maintainer agrees

P.

author maintainer
#16 lore raw

PATCH 3/6 drm/gpu/xe: Ignore dma_fenc_signal() return code

In reply to Philipp Stanner

The return code of dma_fence_signal() is not really useful as there is nothing reasonable to do if a fence was already signaled. That return code shall be removed from the kernel.

Ignore dma_fence_signal()'s return code.

---
 drivers/gpu/drm/xe/xe_hw_fence.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)
drivers/gpu/drm/xe/xe_hw_fence.c +2 -3
index b2a0c46dfcd4..959b30dde724 100644
@@ -85,7 +85,6 @@ void xe_hw_fence_irq_finish(struct xe_hw_fence_irq *irq)
 {
 	struct xe_hw_fence *fence, *next;
 	unsigned long flags;
-	int err;
 	bool tmp;
 
 	if (XE_WARN_ON(!list_empty(&irq->pending))) {
@@ -93,9 +92,9 @@ void xe_hw_fence_irq_finish(struct xe_hw_fence_irq *irq)
 		spin_lock_irqsave(&irq->lock, flags);
 		list_for_each_entry_safe(fence, next, &irq->pending, irq_link) {
 			list_del_init(&fence->irq_link);
-			err = dma_fence_signal_locked(&fence->dma);
+			XE_WARN_ON(dma_fence_test_signaled_flag(&fence->dma));
+			dma_fence_signal_locked(&fence->dma);
 			dma_fence_put(&fence->dma);
-			XE_WARN_ON(err);
 		}
 		spin_unlock_irqrestore(&irq->lock, flags);
 		dma_fence_end_signalling(tmp);
Signature · 1 line
2.49.0
maintainer Reviewed-by on v1 3/6
#17 lore raw

Re: [PATCH 3/6] drm/gpu/xe: Ignore dma_fenc_signal() return code

Quoted 25 lines · Philipp Stanner

The return code of dma_fence_signal() is not really useful as there is nothing reasonable to do if a fence was already signaled. That return code shall be removed from the kernel.

Ignore dma_fence_signal()'s return code.

---
 drivers/gpu/drm/xe/xe_hw_fence.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)
drivers/gpu/drm/xe/xe_hw_fence.c +0 -1
index b2a0c46dfcd4..959b30dde724 100644
@@ -85,7 +85,6 @@ void xe_hw_fence_irq_finish(struct xe_hw_fence_irq *irq)
 {
 	struct xe_hw_fence *fence, *next;
 	unsigned long flags;
-	int err;
 	bool tmp;
 
 	if (XE_WARN_ON(!list_empty(&irq->pending))) {

drivers/gpu/drm/xe/xe_hw_fence.c void xe_hw_fence_irq_finish(struct xe_hw_fence_irq *irq) · line 96

Quoted 6 lines
drivers/gpu/drm/xe/xe_hw_fence.c +2 -1
@@ -93,9 +92,9 @@ void xe_hw_fence_irq_finish(struct xe_hw_fence_irq *irq)
 		spin_lock_irqsave(&irq->lock, flags);
 		list_for_each_entry_safe(fence, next, &irq->pending, irq_link) {
 			list_del_init(&fence->irq_link);
-			err = dma_fence_signal_locked(&fence->dma);
+			XE_WARN_ON(dma_fence_test_signaled_flag(&fence->dma));
+			dma_fence_signal_locked(&fence->dma);

If you also want fix Xe to use dma_fence_test_signaled_flag in all places where we manually check DMA_FENCE_FLAG_SIGNALED_BIT, I'm not going to complain. Ofc I can also do this in follow if patch when patch #1 merges too.

Anyways this patch LGTM:

Quoted 8 lines
drivers/gpu/drm/xe/xe_hw_fence.c +0 -1
 			dma_fence_put(&fence->dma);
-			XE_WARN_ON(err);
 		}
 		spin_unlock_irqrestore(&irq->lock, flags);
 		dma_fence_end_signalling(tmp);
Signature · 1 line
2.49.0
#18 lore raw

Re: [PATCH 3/6] drm/gpu/xe: Ignore dma_fenc_signal() return code

In reply to Philipp Stanner

Hi Philipp,

in the subject /dma_fenc_signal/dma_fence_signal/

drivers/gpu/drm/xe/xe_hw_fence.c void xe_hw_fence_irq_finish(struct xe_hw_fence_irq *irq) · line 96

Quoted 13 lines
drivers/gpu/drm/xe/xe_hw_fence.c +0 -2
@@ -85,7 +85,6 @@ void xe_hw_fence_irq_finish(struct xe_hw_fence_irq *irq)
 {
 	struct xe_hw_fence *fence, *next;
 	unsigned long flags;
-	int err;
 	bool tmp;
 
 	if (XE_WARN_ON(!list_empty(&irq->pending))) {
@@ -93,9 +92,9 @@ void xe_hw_fence_irq_finish(struct xe_hw_fence_irq *irq)
 		spin_lock_irqsave(&irq->lock, flags);
 		list_for_each_entry_safe(fence, next, &irq->pending, irq_link) {
 			list_del_init(&fence->irq_link);
-			err = dma_fence_signal_locked(&fence->dma);

why don't we do

XE_WARN_ON(dma_fence_signal_locked(..))

instead?

Andi

Quoted 10 lines
drivers/gpu/drm/xe/xe_hw_fence.c +2 -1
+			XE_WARN_ON(dma_fence_test_signaled_flag(&fence->dma));
+			dma_fence_signal_locked(&fence->dma);
 			dma_fence_put(&fence->dma);
-			XE_WARN_ON(err);
 		}
 		spin_unlock_irqrestore(&irq->lock, flags);
 		dma_fence_end_signalling(tmp);
Signature · 1 line
2.49.0
maintainer
#19 lore raw

Re: [PATCH 3/6] drm/gpu/xe: Ignore dma_fenc_signal() return code

Quoted 20 lines · Andi Shyti

Hi Philipp,

in the subject /dma_fenc_signal/dma_fence_signal/

drivers/gpu/drm/xe/xe_hw_fence.c void xe_hw_fence_irq_finish(struct xe_hw_fence_irq *irq) · line 96

Quoted 13 lines
drivers/gpu/drm/xe/xe_hw_fence.c +0 -2
@@ -85,7 +85,6 @@ void xe_hw_fence_irq_finish(struct xe_hw_fence_irq *irq)
 {
 	struct xe_hw_fence *fence, *next;
 	unsigned long flags;
-	int err;
 	bool tmp;
 
 	if (XE_WARN_ON(!list_empty(&irq->pending))) {
@@ -93,9 +92,9 @@ void xe_hw_fence_irq_finish(struct xe_hw_fence_irq *irq)
 		spin_lock_irqsave(&irq->lock, flags);
 		list_for_each_entry_safe(fence, next, &irq->pending, irq_link) {
 			list_del_init(&fence->irq_link);
-			err = dma_fence_signal_locked(&fence->dma);

why don't we do

Quoted 2 lines

XE_WARN_ON(dma_fence_signal_locked(..))

IIRC the above statement can compile out. So the patch looks correct to me.

Matt

Quoted 14 lines

instead?

Andi

Quoted 10 lines
drivers/gpu/drm/xe/xe_hw_fence.c +2 -1
+			XE_WARN_ON(dma_fence_test_signaled_flag(&fence->dma));
+			dma_fence_signal_locked(&fence->dma);
 			dma_fence_put(&fence->dma);
-			XE_WARN_ON(err);
 		}
 		spin_unlock_irqrestore(&irq->lock, flags);
 		dma_fence_end_signalling(tmp);
Signature · 1 line
2.49.0
#20 lore raw

Re: [PATCH 3/6] drm/gpu/xe: Ignore dma_fenc_signal() return code

Hi Matt,

Quoted 10 lines · Matthew Brost
Quoted 9 lines · Andi Shyti

drivers/gpu/drm/xe/xe_hw_fence.c void xe_hw_fence_irq_finish(struct xe_hw_fence_irq *irq) · line 96

Quoted 6 lines
drivers/gpu/drm/xe/xe_hw_fence.c +0 -1
@@ -85,7 +85,6 @@ void xe_hw_fence_irq_finish(struct xe_hw_fence_irq *irq)
@@ -93,9 +92,9 @@ void xe_hw_fence_irq_finish(struct xe_hw_fence_irq *irq)
 		spin_lock_irqsave(&irq->lock, flags);
 		list_for_each_entry_safe(fence, next, &irq->pending, irq_link) {
 			list_del_init(&fence->irq_link);
-			err = dma_fence_signal_locked(&fence->dma);

why don't we do

Quoted 4 lines
Quoted 2 lines

XE_WARN_ON(dma_fence_signal_locked(..))

IIRC the above statement can compile out. So the patch looks correct to me.

you have defined XE_WARN_ON as WARN_ON that should always evaluate the content and, depending on the configuration, it prints the logs or not.

What I don't like from this patch is that we end up checking twice for the DMA_FENCE_FLAG_SIGNALED_BIT bit.

Thanks,
Andi

#21 lore raw

Re: [PATCH 3/6] drm/gpu/xe: Ignore dma_fenc_signal() return code

Quoted 14 lines · Andi Shyti

Hi Matt,

Quoted 11 lines · Matthew Brost
Quoted 10 lines · Andi Shyti

drivers/gpu/drm/xe/xe_hw_fence.c void xe_hw_fence_irq_finish(struct xe_hw_fence_irq *irq) · line 96

Quoted 6 lines
drivers/gpu/drm/xe/xe_hw_fence.c +0 -1
@@ -85,7 +85,6 @@ void xe_hw_fence_irq_finish(struct xe_hw_fence_irq *irq)
@@ -93,9 +92,9 @@ void xe_hw_fence_irq_finish(struct xe_hw_fence_irq *irq)
  		spin_lock_irqsave(&irq->lock, flags);
  		list_for_each_entry_safe(fence, next, &irq->pending, irq_link) {
  			list_del_init(&fence->irq_link);
-			err = dma_fence_signal_locked(&fence->dma);

why don't we do

XE_WARN_ON(dma_fence_signal_locked(..))

because it's impossible because the series is about removing the return codes from the dma_fence_signal_* functions.

Quoted 10 lines
Quoted 3 lines
Quoted 1 line

IIRC the above statement can compile out. So the patch looks correct to me.

you have defined XE_WARN_ON as WARN_ON that should always evaluate the content and, depending on the configuration, it prints the logs or not.

What I don't like from this patch is that we end up checking twice for the DMA_FENCE_FLAG_SIGNALED_BIT bit.

Depends on what you mean by "we". The Xe code checks it only once, with dma_fence_test_signaled_flag(). The dma_fence backend checks it yet again, as it always does, to avoid signaling a signaled fence.

That's not racy here, however, because the fence lock is already being held, as evidenced by the current usage of dma_fence_signal_locked().

P.

#22 lore raw

Re: [PATCH 3/6] drm/gpu/xe: Ignore dma_fenc_signal() return code

Quoted 12 lines · Philipp Stanner
Quoted 11 lines · Andi Shyti
Quoted 10 lines · Matthew Brost
Quoted 9 lines · Andi Shyti

drivers/gpu/drm/xe/xe_hw_fence.c void xe_hw_fence_irq_finish(struct xe_hw_fence_irq *irq) · line 96

Quoted 6 lines
drivers/gpu/drm/xe/xe_hw_fence.c +0 -1
@@ -85,7 +85,6 @@ void xe_hw_fence_irq_finish(struct xe_hw_fence_irq *irq)
@@ -93,9 +92,9 @@ void xe_hw_fence_irq_finish(struct xe_hw_fence_irq *irq)
  		spin_lock_irqsave(&irq->lock, flags);
  		list_for_each_entry_safe(fence, next, &irq->pending, irq_link) {
  			list_del_init(&fence->irq_link);
-			err = dma_fence_signal_locked(&fence->dma);

why don't we do

Quoted 4 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line

XE_WARN_ON(dma_fence_signal_locked(..))

because it's impossible because the series is about removing the return codes from the dma_fence_signal_* functions.

oh yes, the last patch. Sorry, I went on reviewing and lost the final target from sight.

Quoted 11 lines
Quoted 10 lines
Quoted 3 lines
Quoted 1 line

IIRC the above statement can compile out. So the patch looks correct to me.

you have defined XE_WARN_ON as WARN_ON that should always evaluate the content and, depending on the configuration, it prints the logs or not.

What I don't like from this patch is that we end up checking twice for the DMA_FENCE_FLAG_SIGNALED_BIT bit.

Quoted 6 lines

Depends on what you mean by "we". The Xe code checks it only once, with dma_fence_test_signaled_flag(). The dma_fence backend checks it yet again, as it always does, to avoid signaling a signaled fence.

That's not racy here, however, because the fence lock is already being held, as evidenced by the current usage of dma_fence_signal_locked().

I haven't said it's racy, I just didn't like that we are testing for the DMA_FENCE_FLAG_SIGNALED_BIT twice. On the other hand, with dma_fence_signal_locked() being void, I wouldn't know how to do it better. So that I guess it's fine.

Andi

author maintainer
#23 lore raw

PATCH 4/6 dma-buf: Don't misuse dma_fence_signal()

In reply to Philipp Stanner

The return code of dma_fence_signal() is not really useful as there is nothing reasonable to do if a fence was already signaled. That return code shall be removed from the kernel.

Moreover, dma_fence_signal() should not be used to check whether fences are signaled. That's what dma_fence_is_signaled() and dma_fence_test_signaled_flag() exist for.

Replace the non-canonical usage of dma_fence_signal().

---
 drivers/dma-buf/st-dma-fence.c | 7 ++-----
 1 file changed, 2 insertions(+), 5 deletions(-)
drivers/dma-buf/st-dma-fence.c +2 -5
index 27a36045410b..9fc93859f36f 100644
@@ -126,17 +126,14 @@ static int test_signaling(void *arg)
 		goto err_free;
 	}
 
-	if (dma_fence_signal(f)) {
-		pr_err("Fence reported being already signaled\n");
-		goto err_free;
-	}
+	dma_fence_signal(f);
 
 	if (!dma_fence_is_signaled(f)) {
 		pr_err("Fence not reporting signaled\n");
 		goto err_free;
 	}
 
-	if (!dma_fence_signal(f)) {
+	if (!dma_fence_test_signaled_flag(f)) {
 		pr_err("Fence reported not being already signaled\n");
 		goto err_free;
 	}
Signature · 1 line
2.49.0
author maintainer
#24 lore raw

PATCH 5/6 drm/ttm: Remove return check of dma_fence_signal()

In reply to Philipp Stanner

The return code of dma_fence_signal() is not useful and shall be removed from the kernel. To do so, all users must be removed.

Remove usage of dma_fence_signal()'s return code.

---
 drivers/gpu/drm/ttm/tests/ttm_bo_validate_test.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/gpu/drm/ttm/tests/ttm_bo_validate_test.c +2 -1
index 1bcc67977f48..34957624910f 100644
@@ -692,7 +692,8 @@ static int threaded_fence_signal(void *arg)
 
 	msleep(20);
 
-	return dma_fence_signal(fence);
+	dma_fence_signal(fence);
+	return 0;
 }
 
 static void ttm_bo_validate_move_fence_not_signaled(struct kunit *test)
Signature · 1 line
2.49.0
author maintainer
#25 lore raw

PATCH 6/6 dma-buf/dma-fence: Remove return code of signaling-functions

In reply to Philipp Stanner

All functions used for signaling a fence return an error code whose sole purpose is to tell whether a fence was already signaled.

This is racy and has been used by almost no party in the kernel, and the few users have been removed in preceding cleanup commits.

Turn all signaling-functions into void-functions.

---
 drivers/dma-buf/dma-fence.c | 40 ++++++++++---------------------------
 include/linux/dma-fence.h   |  9 ++++-----
 2 files changed, 14 insertions(+), 35 deletions(-)
drivers/dma-buf/dma-fence.c +10 -30
index 25117a906846..bed8d0c27217 100644
@@ -360,11 +360,8 @@ void __dma_fence_might_wait(void)
  *
  * Unlike dma_fence_signal_timestamp(), this function must be called with
  * &dma_fence.lock held.
- *
- * Returns 0 on success and a negative error value when @fence has been
- * signalled already.
  */
-int dma_fence_signal_timestamp_locked(struct dma_fence *fence,
+void dma_fence_signal_timestamp_locked(struct dma_fence *fence,
 				      ktime_t timestamp)
 {
 	struct dma_fence_cb *cur, *tmp;
@@ -373,7 +370,7 @@ int dma_fence_signal_timestamp_locked(struct dma_fence *fence,
 	lockdep_assert_held(fence->lock);
 
 	if (unlikely(dma_fence_test_signaled_flag(fence)))
-		return -EINVAL;
+		return;
 
 	/* Stash the cb_list before replacing it with the timestamp */
 	list_replace(&fence->cb_list, &cb_list);
@@ -386,8 +383,6 @@ int dma_fence_signal_timestamp_locked(struct dma_fence *fence,
 		INIT_LIST_HEAD(&cur->node);
 		cur->func(fence, cur);
 	}
-
-	return 0;
 }
 EXPORT_SYMBOL(dma_fence_signal_timestamp_locked);
 
@@ -402,23 +397,17 @@ EXPORT_SYMBOL(dma_fence_signal_timestamp_locked);
  * can only go from the unsignaled to the signaled state and not back, it will
  * only be effective the first time. Set the timestamp provided as the fence
  * signal timestamp.
- *
- * Returns 0 on success and a negative error value when @fence has been
- * signalled already.
  */
-int dma_fence_signal_timestamp(struct dma_fence *fence, ktime_t timestamp)
+void dma_fence_signal_timestamp(struct dma_fence *fence, ktime_t timestamp)
 {
 	unsigned long flags;
-	int ret;
 
 	if (WARN_ON(!fence))
-		return -EINVAL;
+		return;
 
 	spin_lock_irqsave(fence->lock, flags);
-	ret = dma_fence_signal_timestamp_locked(fence, timestamp);
+	dma_fence_signal_timestamp_locked(fence, timestamp);
 	spin_unlock_irqrestore(fence->lock, flags);
-
-	return ret;
 }
 EXPORT_SYMBOL(dma_fence_signal_timestamp);
 
@@ -434,13 +423,10 @@ EXPORT_SYMBOL(dma_fence_signal_timestamp);
  *
  * Unlike dma_fence_signal(), this function must be called with &dma_fence.lock
  * held.
- *
- * Returns 0 on success and a negative error value when @fence has been
- * signalled already.
  */
-int dma_fence_signal_locked(struct dma_fence *fence)
+void dma_fence_signal_locked(struct dma_fence *fence)
 {
-	return dma_fence_signal_timestamp_locked(fence, ktime_get());
+	dma_fence_signal_timestamp_locked(fence, ktime_get());
 }
 EXPORT_SYMBOL(dma_fence_signal_locked);
 
@@ -453,28 +439,22 @@ EXPORT_SYMBOL(dma_fence_signal_locked);
  * dma_fence_add_callback(). Can be called multiple times, but since a fence
  * can only go from the unsignaled to the signaled state and not back, it will
  * only be effective the first time.
- *
- * Returns 0 on success and a negative error value when @fence has been
- * signalled already.
  */
-int dma_fence_signal(struct dma_fence *fence)
+void dma_fence_signal(struct dma_fence *fence)
 {
 	unsigned long flags;
-	int ret;
 	bool tmp;
 
 	if (WARN_ON(!fence))
-		return -EINVAL;
+		return;
 
 	tmp = dma_fence_begin_signalling();
 
 	spin_lock_irqsave(fence->lock, flags);
-	ret = dma_fence_signal_timestamp_locked(fence, ktime_get());
+	dma_fence_signal_timestamp_locked(fence, ktime_get());
 	spin_unlock_irqrestore(fence->lock, flags);
 
 	dma_fence_end_signalling(tmp);
-
-	return ret;
 }
 EXPORT_SYMBOL(dma_fence_signal);
 
include/linux/dma-fence.h +4 -5
index 19972f5d176f..188f7641050f 100644
@@ -364,11 +364,10 @@ static inline void dma_fence_end_signalling(bool cookie) {}
 static inline void __dma_fence_might_wait(void) {}
 #endif
 
-int dma_fence_signal(struct dma_fence *fence);
-int dma_fence_signal_locked(struct dma_fence *fence);
-int dma_fence_signal_timestamp(struct dma_fence *fence, ktime_t timestamp);
-int dma_fence_signal_timestamp_locked(struct dma_fence *fence,
-				      ktime_t timestamp);
+void dma_fence_signal(struct dma_fence *fence);
+void dma_fence_signal_locked(struct dma_fence *fence);
+void dma_fence_signal_timestamp(struct dma_fence *fence, ktime_t timestamp);
+void dma_fence_signal_timestamp_locked(struct dma_fence *fence, ktime_t timestamp);
 signed long dma_fence_default_wait(struct dma_fence *fence,
 				   bool intr, signed long timeout);
 int dma_fence_add_callback(struct dma_fence *fence,
Signature · 1 line
2.49.0
#26 lore raw

✗ CI.checkpatch: warning for dma-fence: Remove return code of dma_fence_signal() et al.

In reply to Philipp Stanner
== Series Details ==

== Series Details ==

Series: dma-fence: Remove return code of dma_fence_signal() et al.
URL : https://patchwork.freedesktop.org/series/158108/
State : warning

== Summary ==

+ KERNEL=/kernel
+ git clone https://gitlab.freedesktop.org/drm/maintainer-tools mt Cloning into 'mt'...
warning: redirecting to https://gitlab.freedesktop.org/drm/maintainer-tools.git/
+ git -C mt rev-list -n1 origin/master 2de9a3901bc28757c7906b454717b64e2a214021
+ cd /kernel
+ git config --global --add safe.directory /kernel
+ git log -n1
commit ac37ad1a19b95593ec8ff82060b1f4788848acdc

Author: Philipp Stanner <[email protected]>
Date:   Wed Nov 26 14:19:15 2025 +0100

dma-buf/dma-fence: Remove return code of signaling-functions

All functions used for signaling a fence return an error code whose sole purpose is to tell whether a fence was already signaled.

This is racy and has been used by almost no party in the kernel, and the few users have been removed in preceding cleanup commits.

Turn all signaling-functions into void-functions.

+ /mt/dim checkpatch 13bec21f5f4cdabdf06725e5a8dee0b9b56ff671 drm-intel 7df9c2abae0c dma-buf/dma-fence: Add dma_fence_test_signaled_flag() 39d81656a3cd amd/amdkfd: Ignore return code of dma_fence_signal() 94813ca99142 drm/gpu/xe: Ignore dma_fenc_signal() return code 54d0b5ed7342 dma-buf: Don't misuse dma_fence_signal() 584e5f0cd0dc drm/ttm: Remove return check of dma_fence_signal() ac37ad1a19b9 dma-buf/dma-fence: Remove return code of signaling-functions -:34: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #34: FILE: drivers/dma-buf/dma-fence.c:363:
+void dma_fence_signal_timestamp_locked(struct dma_fence *fence,
ktime_t timestamp)

total: 0 errors, 0 warnings, 1 checks, 115 lines checked

#27 lore raw

✗ CI.KUnit: failure for dma-fence: Remove return code of dma_fence_signal() et al.

In reply to Philipp Stanner
== Series Details ==

== Series Details ==

Series: dma-fence: Remove return code of dma_fence_signal() et al.
URL : https://patchwork.freedesktop.org/series/158108/
State : failure

== Summary ==

+ trap cleanup EXIT
+ /kernel/tools/testing/kunit/kunit.py run --kunitconfig /kernel/drivers/gpu/drm/xe/.kunitconfig [13:59:47] Configuring KUnit Kernel ...
Generating .config ...
Populating config with:

$ make ARCH=um O=.kunit olddefconfig
[13:59:51] Building KUnit Kernel ...
Populating config with:
$ make ARCH=um O=.kunit olddefconfig
Building with:
$ make all compile_commands.json scripts_gdb ARCH=um O=.kunit --jobs=25
[14:00:29] Starting KUnit Kernel (1/1)...
[14:00:29] ============================================================
Running tests with:
$ .kunit/linux kunit.enable=1 mem=1G console=tty kunit_shutdown=halt
[14:00:29] ================== guc_buf (11 subtests) ===================
[14:00:29] [PASSED] test_smallest
[14:00:29] [PASSED] test_largest
[14:00:29] [PASSED] test_granular
[14:00:29] [PASSED] test_unique
[14:00:29] [PASSED] test_overlap
[14:00:29] [PASSED] test_reusable
[14:00:29] [PASSED] test_too_big
[14:00:29] [PASSED] test_flush
[14:00:29] [PASSED] test_lookup
[14:00:29] [PASSED] test_data
[14:00:29] [PASSED] test_class
[14:00:29] ===================== [PASSED] guc_buf =====================
[14:00:29] =================== guc_dbm (7 subtests) ===================
[14:00:29] [PASSED] test_empty
[14:00:29] [PASSED] test_default
[14:00:29] ======================== test_size  ========================
[14:00:29] [PASSED] 4
[14:00:29] [PASSED] 8
[14:00:29] [PASSED] 32
[14:00:29] [PASSED] 256
[14:00:29] ==================== [PASSED] test_size ====================
[14:00:29] ======================= test_reuse  ========================
[14:00:29] [PASSED] 4
[14:00:29] [PASSED] 8
[14:00:29] [PASSED] 32
[14:00:29] [PASSED] 256
[14:00:29] =================== [PASSED] test_reuse ====================
[14:00:29] =================== test_range_overlap  ====================
[14:00:29] [PASSED] 4
[14:00:29] [PASSED] 8
[14:00:29] [PASSED] 32
[14:00:29] [PASSED] 256
[14:00:29] =============== [PASSED] test_range_overlap ================
[14:00:29] =================== test_range_compact  ====================
[14:00:29] [PASSED] 4
[14:00:29] [PASSED] 8
[14:00:29] [PASSED] 32
[14:00:29] [PASSED] 256
[14:00:29] =============== [PASSED] test_range_compact ================
[14:00:29] ==================== test_range_spare  =====================
[14:00:29] [PASSED] 4
[14:00:29] [PASSED] 8
[14:00:29] [PASSED] 32
[14:00:29] [PASSED] 256
[14:00:29] ================ [PASSED] test_range_spare =================
[14:00:29] ===================== [PASSED] guc_dbm =====================
[14:00:29] =================== guc_idm (6 subtests) ===================
[14:00:29] [PASSED] bad_init
[14:00:29] [PASSED] no_init
[14:00:29] [PASSED] init_fini
[14:00:29] [PASSED] check_used
[14:00:29] [PASSED] check_quota
[14:00:29] [PASSED] check_all
[14:00:29] ===================== [PASSED] guc_idm =====================
[14:00:29] ================== no_relay (3 subtests) ===================
[14:00:29] [PASSED] xe_drops_guc2pf_if_not_ready
[14:00:29] [PASSED] xe_drops_guc2vf_if_not_ready
[14:00:29] [PASSED] xe_rejects_send_if_not_ready
[14:00:29] ==================== [PASSED] no_relay =====================
[14:00:29] ================== pf_relay (14 subtests) ==================
[14:00:29] [PASSED] pf_rejects_guc2pf_too_short
[14:00:29] [PASSED] pf_rejects_guc2pf_too_long
[14:00:29] [PASSED] pf_rejects_guc2pf_no_payload
[14:00:29] [PASSED] pf_fails_no_payload
[14:00:29] [PASSED] pf_fails_bad_origin
[14:00:29] [PASSED] pf_fails_bad_type
[14:00:29] [PASSED] pf_txn_reports_error
[14:00:29] [PASSED] pf_txn_sends_pf2guc
[14:00:29] [PASSED] pf_sends_pf2guc
[14:00:29] [SKIPPED] pf_loopback_nop
[14:00:29] [SKIPPED] pf_loopback_echo
[14:00:29] [SKIPPED] pf_loopback_fail
[14:00:29] [SKIPPED] pf_loopback_busy
[14:00:29] [SKIPPED] pf_loopback_retry
[14:00:29] ==================== [PASSED] pf_relay =====================
[14:00:29] ================== vf_relay (3 subtests) ===================
[14:00:29] [PASSED] vf_rejects_guc2vf_too_short
[14:00:29] [PASSED] vf_rejects_guc2vf_too_long
[14:00:29] [PASSED] vf_rejects_guc2vf_no_payload
[14:00:29] ==================== [PASSED] vf_relay =====================
[14:00:29] ================ pf_gt_config (6 subtests) =================
[14:00:29] [PASSED] fair_contexts_1vf
[14:00:29] [PASSED] fair_doorbells_1vf
[14:00:29] [PASSED] fair_ggtt_1vf
[14:00:29] ====================== fair_contexts  ======================
[14:00:29] [PASSED] 1 VF
[14:00:29] [PASSED] 2 VFs
[14:00:29] [PASSED] 3 VFs
[14:00:29] [PASSED] 4 VFs
[14:00:29] [PASSED] 5 VFs
[14:00:29] [PASSED] 6 VFs
[14:00:29] [PASSED] 7 VFs
[14:00:29] [PASSED] 8 VFs
[14:00:29] [PASSED] 9 VFs
[14:00:29] [PASSED] 10 VFs
[14:00:29] [PASSED] 11 VFs
[14:00:29] [PASSED] 12 VFs
[14:00:29] [PASSED] 13 VFs
[14:00:29] [PASSED] 14 VFs
[14:00:29] [PASSED] 15 VFs
[14:00:29] [PASSED] 16 VFs
[14:00:29] [PASSED] 17 VFs
[14:00:29] [PASSED] 18 VFs
[14:00:29] [PASSED] 19 VFs
[14:00:29] [PASSED] 20 VFs
[14:00:29] [PASSED] 21 VFs
[14:00:29] [PASSED] 22 VFs
[14:00:29] [PASSED] 23 VFs
[14:00:29] [PASSED] 24 VFs
[14:00:29] [PASSED] 25 VFs
[14:00:29] [PASSED] 26 VFs
[14:00:29] [PASSED] 27 VFs
[14:00:29] [PASSED] 28 VFs
[14:00:29] [PASSED] 29 VFs
[14:00:29] [PASSED] 30 VFs
[14:00:29] [PASSED] 31 VFs
[14:00:29] [PASSED] 32 VFs
[14:00:29] [PASSED] 33 VFs
[14:00:29] [PASSED] 34 VFs
[14:00:29] [PASSED] 35 VFs
[14:00:29] [PASSED] 36 VFs
[14:00:29] [PASSED] 37 VFs
[14:00:29] [PASSED] 38 VFs
[14:00:29] [PASSED] 39 VFs
[14:00:29] [PASSED] 40 VFs
[14:00:29] [PASSED] 41 VFs
[14:00:29] [PASSED] 42 VFs
[14:00:29] [PASSED] 43 VFs
[14:00:29] [PASSED] 44 VFs
[14:00:29] [PASSED] 45 VFs
[14:00:29] [PASSED] 46 VFs
[14:00:29] [PASSED] 47 VFs
[14:00:29] [PASSED] 48 VFs
[14:00:29] [PASSED] 49 VFs
[14:00:29] [PASSED] 50 VFs
[14:00:29] [PASSED] 51 VFs
[14:00:29] [PASSED] 52 VFs
[14:00:29] [PASSED] 53 VFs
[14:00:29] [PASSED] 54 VFs
[14:00:29] [PASSED] 55 VFs
[14:00:29] [PASSED] 56 VFs
[14:00:29] [PASSED] 57 VFs
[14:00:29] [PASSED] 58 VFs
[14:00:29] [PASSED] 59 VFs
[14:00:29] [PASSED] 60 VFs
[14:00:29] [PASSED] 61 VFs
[14:00:29] [PASSED] 62 VFs
[14:00:29] [PASSED] 63 VFs
[14:00:29] ================== [PASSED] fair_contexts ==================
[14:00:29] ===================== fair_doorbells  ======================
[14:00:29] [PASSED] 1 VF
[14:00:29] [PASSED] 2 VFs
[14:00:29] [PASSED] 3 VFs
[14:00:29] [PASSED] 4 VFs
[14:00:29] [PASSED] 5 VFs
[14:00:29] [PASSED] 6 VFs
[14:00:29] [PASSED] 7 VFs
[14:00:29] [PASSED] 8 VFs
[14:00:29] [PASSED] 9 VFs
[14:00:29] [PASSED] 10 VFs
[14:00:29] [PASSED] 11 VFs
[14:00:29] [PASSED] 12 VFs
[14:00:29] [PASSED] 13 VFs
[14:00:29] [PASSED] 14 VFs
[14:00:29] [PASSED] 15 VFs
[14:00:29] [PASSED] 16 VFs
[14:00:29] [PASSED] 17 VFs
[14:00:29] [PASSED] 18 VFs
[14:00:29] [PASSED] 19 VFs
[14:00:29] [PASSED] 20 VFs
[14:00:29] [PASSED] 21 VFs
[14:00:29] [PASSED] 22 VFs
[14:00:29] [PASSED] 23 VFs
[14:00:29] [PASSED] 24 VFs
[14:00:29] [PASSED] 25 VFs
[14:00:29] [PASSED] 26 VFs
[14:00:29] [PASSED] 27 VFs
[14:00:29] [PASSED] 28 VFs
[14:00:29] [PASSED] 29 VFs
[14:00:29] [PASSED] 30 VFs
[14:00:29] [PASSED] 31 VFs
[14:00:29] [PASSED] 32 VFs
[14:00:29] [PASSED] 33 VFs
[14:00:29] [PASSED] 34 VFs
[14:00:29] [PASSED] 35 VFs
[14:00:29] [PASSED] 36 VFs
[14:00:29] [PASSED] 37 VFs
[14:00:29] [PASSED] 38 VFs
[14:00:29] [PASSED] 39 VFs
[14:00:29] [PASSED] 40 VFs
[14:00:29] [PASSED] 41 VFs
[14:00:29] [PASSED] 42 VFs
[14:00:29] [PASSED] 43 VFs
[14:00:29] [PASSED] 44 VFs
[14:00:29] [PASSED] 45 VFs
[14:00:29] [PASSED] 46 VFs
[14:00:29] [PASSED] 47 VFs
[14:00:29] [PASSED] 48 VFs
[14:00:29] [PASSED] 49 VFs
[14:00:29] [PASSED] 50 VFs
[14:00:29] [PASSED] 51 VFs
[14:00:29] [PASSED] 52 VFs
[14:00:29] [PASSED] 53 VFs
[14:00:29] [PASSED] 54 VFs
[14:00:29] [PASSED] 55 VFs
[14:00:29] [PASSED] 56 VFs
[14:00:29] [PASSED] 57 VFs
[14:00:29] [PASSED] 58 VFs
[14:00:29] [PASSED] 59 VFs
[14:00:29] [PASSED] 60 VFs
[14:00:29] [PASSED] 61 VFs
[14:00:29] [PASSED] 62 VFs
[14:00:29] [PASSED] 63 VFs
[14:00:29] ================= [PASSED] fair_doorbells ==================
[14:00:29] ======================== fair_ggtt  ========================
[14:00:29] [PASSED] 1 VF
[14:00:29] [PASSED] 2 VFs
[14:00:29] [PASSED] 3 VFs
[14:00:29] [PASSED] 4 VFs
[14:00:29] [PASSED] 5 VFs
[14:00:29] [PASSED] 6 VFs
[14:00:29] [PASSED] 7 VFs
[14:00:29] [PASSED] 8 VFs
[14:00:29] [PASSED] 9 VFs
[14:00:29] [PASSED] 10 VFs
[14:00:29] [PASSED] 11 VFs
[14:00:29] [PASSED] 12 VFs
[14:00:29] [PASSED] 13 VFs
[14:00:29] [PASSED] 14 VFs
[14:00:29] [PASSED] 15 VFs
[14:00:29] [PASSED] 16 VFs
[14:00:29] [PASSED] 17 VFs
[14:00:29] [PASSED] 18 VFs
[14:00:29] [PASSED] 19 VFs
[14:00:29] [PASSED] 20 VFs
[14:00:29] [PASSED] 21 VFs
[14:00:29] [PASSED] 22 VFs
[14:00:29] [PASSED] 23 VFs
[14:00:29] [PASSED] 24 VFs
[14:00:29] [PASSED] 25 VFs
[14:00:29] [PASSED] 26 VFs
[14:00:29] [PASSED] 27 VFs
[14:00:29] [PASSED] 28 VFs
[14:00:29] [PASSED] 29 VFs
[14:00:29] [PASSED] 30 VFs
[14:00:29] [PASSED] 31 VFs
[14:00:29] [PASSED] 32 VFs
[14:00:29] [PASSED] 33 VFs
[14:00:29] [PASSED] 34 VFs
[14:00:29] [PASSED] 35 VFs
[14:00:29] [PASSED] 36 VFs
[14:00:29] [PASSED] 37 VFs
[14:00:29] [PASSED] 38 VFs
[14:00:29] [PASSED] 39 VFs
[14:00:29] [PASSED] 40 VFs
[14:00:29] [PASSED] 41 VFs
[14:00:29] [PASSED] 42 VFs
[14:00:29] [PASSED] 43 VFs
[14:00:29] [PASSED] 44 VFs
[14:00:29] [PASSED] 45 VFs
[14:00:29] [PASSED] 46 VFs
[14:00:29] [PASSED] 47 VFs
[14:00:29] [PASSED] 48 VFs
[14:00:29] [PASSED] 49 VFs
[14:00:29] [PASSED] 50 VFs
[14:00:29] [PASSED] 51 VFs
[14:00:29] [PASSED] 52 VFs
[14:00:29] [PASSED] 53 VFs
[14:00:29] [PASSED] 54 VFs
[14:00:29] [PASSED] 55 VFs
[14:00:29] [PASSED] 56 VFs
[14:00:29] [PASSED] 57 VFs
[14:00:29] [PASSED] 58 VFs
[14:00:29] [PASSED] 59 VFs
[14:00:29] [PASSED] 60 VFs
[14:00:29] [PASSED] 61 VFs
[14:00:29] [PASSED] 62 VFs
[14:00:29] [PASSED] 63 VFs
[14:00:29] ==================== [PASSED] fair_ggtt ====================
[14:00:29] ================== [PASSED] pf_gt_config ===================
[14:00:29] ===================== lmtt (1 subtest) =====================
[14:00:29] ======================== test_ops  =========================
[14:00:29] [PASSED] 2-level
[14:00:29] [PASSED] multi-level
[14:00:29] ==================== [PASSED] test_ops =====================
[14:00:29] ====================== [PASSED] lmtt =======================
[14:00:29] ================= pf_service (11 subtests) =================
[14:00:29] [PASSED] pf_negotiate_any
[14:00:29] [PASSED] pf_negotiate_base_match
[14:00:29] [PASSED] pf_negotiate_base_newer
[14:00:29] [PASSED] pf_negotiate_base_next
[14:00:29] [SKIPPED] pf_negotiate_base_older
[14:00:29] [PASSED] pf_negotiate_base_prev
[14:00:29] [PASSED] pf_negotiate_latest_match
[14:00:29] [PASSED] pf_negotiate_latest_newer
[14:00:29] [PASSED] pf_negotiate_latest_next
[14:00:29] [SKIPPED] pf_negotiate_latest_older
[14:00:29] [SKIPPED] pf_negotiate_latest_prev
[14:00:29] =================== [PASSED] pf_service ====================
[14:00:29] ================= xe_guc_g2g (2 subtests) ==================
[14:00:29] ============== xe_live_guc_g2g_kunit_default  ==============
[14:00:29] ========= [SKIPPED] xe_live_guc_g2g_kunit_default ==========
[14:00:29] ============== xe_live_guc_g2g_kunit_allmem  ===============
[14:00:29] ========== [SKIPPED] xe_live_guc_g2g_kunit_allmem ==========
[14:00:29] =================== [SKIPPED] xe_guc_g2g ===================
[14:00:29] =================== xe_mocs (2 subtests) ===================
[14:00:29] ================ xe_live_mocs_kernel_kunit  ================
[14:00:29] =========== [SKIPPED] xe_live_mocs_kernel_kunit ============
[14:00:29] ================ xe_live_mocs_reset_kunit  =================
[14:00:29] ============ [SKIPPED] xe_live_mocs_reset_kunit ============
[14:00:29] ==================== [SKIPPED] xe_mocs =====================
[14:00:29] ================= xe_migrate (2 subtests) ==================
[14:00:29] ================= xe_migrate_sanity_kunit  =================
[14:00:29] ============ [SKIPPED] xe_migrate_sanity_kunit =============
[14:00:29] ================== xe_validate_ccs_kunit  ==================
[14:00:29] ============= [SKIPPED] xe_validate_ccs_kunit ==============
[14:00:29] =================== [SKIPPED] xe_migrate ===================
[14:00:29] ================== xe_dma_buf (1 subtest) ==================
[14:00:29] ==================== xe_dma_buf_kunit  =====================
[14:00:29] ================ [SKIPPED] xe_dma_buf_kunit ================
[14:00:29] =================== [SKIPPED] xe_dma_buf ===================
[14:00:29] ================= xe_bo_shrink (1 subtest) =================
[14:00:29] =================== xe_bo_shrink_kunit  ====================
[14:00:29] =============== [SKIPPED] xe_bo_shrink_kunit ===============
[14:00:29] ================== [SKIPPED] xe_bo_shrink ==================
[14:00:29] ==================== xe_bo (2 subtests) ====================
[14:00:29] ================== xe_ccs_migrate_kunit  ===================
[14:00:29] ============== [SKIPPED] xe_ccs_migrate_kunit ==============
[14:00:29] ==================== xe_bo_evict_kunit  ====================
[14:00:29] =============== [SKIPPED] xe_bo_evict_kunit ================
[14:00:29] ===================== [SKIPPED] xe_bo ======================
[14:00:29] ==================== args (11 subtests) ====================
[14:00:29] [PASSED] count_args_test
[14:00:29] [PASSED] call_args_example
[14:00:29] [PASSED] call_args_test
[14:00:29] [PASSED] drop_first_arg_example
[14:00:29] [PASSED] drop_first_arg_test
[14:00:29] [PASSED] first_arg_example
[14:00:29] [PASSED] first_arg_test
[14:00:29] [PASSED] last_arg_example
[14:00:29] [PASSED] last_arg_test
[14:00:29] [PASSED] pick_arg_example
[14:00:29] [PASSED] sep_comma_example
[14:00:29] ====================== [PASSED] args =======================
[14:00:29] =================== xe_pci (3 subtests) ====================
[14:00:29] ==================== check_graphics_ip  ====================
[14:00:29] [PASSED] 12.00 Xe_LP
[14:00:29] [PASSED] 12.10 Xe_LP+
[14:00:29] [PASSED] 12.55 Xe_HPG
[14:00:29] [PASSED] 12.60 Xe_HPC
[14:00:29] [PASSED] 12.70 Xe_LPG
[14:00:29] [PASSED] 12.71 Xe_LPG
[14:00:29] [PASSED] 12.74 Xe_LPG+
[14:00:29] [PASSED] 20.01 Xe2_HPG
[14:00:29] [PASSED] 20.02 Xe2_HPG
[14:00:29] [PASSED] 20.04 Xe2_LPG
[14:00:29] [PASSED] 30.00 Xe3_LPG
[14:00:29] [PASSED] 30.01 Xe3_LPG
[14:00:29] [PASSED] 30.03 Xe3_LPG
[14:00:29] [PASSED] 30.04 Xe3_LPG
[14:00:29] [PASSED] 30.05 Xe3_LPG
[14:00:29] [PASSED] 35.11 Xe3p_XPC
[14:00:29] ================ [PASSED] check_graphics_ip ================
[14:00:29] ===================== check_media_ip  ======================
[14:00:29] [PASSED] 12.00 Xe_M
[14:00:29] [PASSED] 12.55 Xe_HPM
[14:00:29] [PASSED] 13.00 Xe_LPM+
[14:00:29] [PASSED] 13.01 Xe2_HPM
[14:00:29] [PASSED] 20.00 Xe2_LPM
[14:00:29] [PASSED] 30.00 Xe3_LPM
[14:00:29] [PASSED] 30.02 Xe3_LPM
[14:00:29] [PASSED] 35.00 Xe3p_LPM
[14:00:29] [PASSED] 35.03 Xe3p_HPM
[14:00:29] ================= [PASSED] check_media_ip ==================
[14:00:29] =================== check_platform_desc  ===================
[14:00:29] [PASSED] 0x9A60 (TIGERLAKE)
[14:00:29] [PASSED] 0x9A68 (TIGERLAKE)
[14:00:29] [PASSED] 0x9A70 (TIGERLAKE)
[14:00:29] [PASSED] 0x9A40 (TIGERLAKE)
[14:00:29] [PASSED] 0x9A49 (TIGERLAKE)
[14:00:29] [PASSED] 0x9A59 (TIGERLAKE)
[14:00:29] [PASSED] 0x9A78 (TIGERLAKE)
[14:00:29] [PASSED] 0x9AC0 (TIGERLAKE)
[14:00:29] [PASSED] 0x9AC9 (TIGERLAKE)
[14:00:29] [PASSED] 0x9AD9 (TIGERLAKE)
[14:00:29] [PASSED] 0x9AF8 (TIGERLAKE)
[14:00:29] [PASSED] 0x4C80 (ROCKETLAKE)
[14:00:29] [PASSED] 0x4C8A (ROCKETLAKE)
[14:00:29] [PASSED] 0x4C8B (ROCKETLAKE)
[14:00:29] [PASSED] 0x4C8C (ROCKETLAKE)
[14:00:29] [PASSED] 0x4C90 (ROCKETLAKE)
[14:00:29] [PASSED] 0x4C9A (ROCKETLAKE)
[14:00:29] [PASSED] 0x4680 (ALDERLAKE_S)
[14:00:29] [PASSED] 0x4682 (ALDERLAKE_S)
[14:00:29] [PASSED] 0x4688 (ALDERLAKE_S)
[14:00:29] [PASSED] 0x468A (ALDERLAKE_S)
[14:00:29] [PASSED] 0x468B (ALDERLAKE_S)
[14:00:29] [PASSED] 0x4690 (ALDERLAKE_S)
[14:00:29] [PASSED] 0x4692 (ALDERLAKE_S)
[14:00:29] [PASSED] 0x4693 (ALDERLAKE_S)
[14:00:29] [PASSED] 0x46A0 (ALDERLAKE_P)
[14:00:29] [PASSED] 0x46A1 (ALDERLAKE_P)
[14:00:29] [PASSED] 0x46A2 (ALDERLAKE_P)
[14:00:29] [PASSED] 0x46A3 (ALDERLAKE_P)
[14:00:29] [PASSED] 0x46A6 (ALDERLAKE_P)
[14:00:29] [PASSED] 0x46A8 (ALDERLAKE_P)
[14:00:29] [PASSED] 0x46AA (ALDERLAKE_P)
[14:00:29] [PASSED] 0x462A (ALDERLAKE_P)
[14:00:29] [PASSED] 0x4626 (ALDERLAKE_P)
[14:00:29] [PASSED] 0x4628 (ALDERLAKE_P)
[14:00:29] [PASSED] 0x46B0 (ALDERLAKE_P)
stty: 'standard input': Inappropriate ioctl for device
[14:00:29] [PASSED] 0x46B1 (ALDERLAKE_P)
[14:00:29] [PASSED] 0x46B2 (ALDERLAKE_P)
[14:00:29] [PASSED] 0x46B3 (ALDERLAKE_P)
[14:00:29] [PASSED] 0x46C0 (ALDERLAKE_P)
[14:00:29] [PASSED] 0x46C1 (ALDERLAKE_P)
[14:00:29] [PASSED] 0x46C2 (ALDERLAKE_P)
[14:00:29] [PASSED] 0x46C3 (ALDERLAKE_P)
[14:00:29] [PASSED] 0x46D0 (ALDERLAKE_N)
[14:00:29] [PASSED] 0x46D1 (ALDERLAKE_N)
[14:00:29] [PASSED] 0x46D2 (ALDERLAKE_N)
[14:00:29] [PASSED] 0x46D3 (ALDERLAKE_N)
[14:00:29] [PASSED] 0x46D4 (ALDERLAKE_N)
[14:00:29] [PASSED] 0xA721 (ALDERLAKE_P)
[14:00:29] [PASSED] 0xA7A1 (ALDERLAKE_P)
[14:00:29] [PASSED] 0xA7A9 (ALDERLAKE_P)
[14:00:29] [PASSED] 0xA7AC (ALDERLAKE_P)
[14:00:29] [PASSED] 0xA7AD (ALDERLAKE_P)
[14:00:29] [PASSED] 0xA720 (ALDERLAKE_P)
[14:00:29] [PASSED] 0xA7A0 (ALDERLAKE_P)
[14:00:29] [PASSED] 0xA7A8 (ALDERLAKE_P)
[14:00:29] [PASSED] 0xA7AA (ALDERLAKE_P)
[14:00:29] [PASSED] 0xA7AB (ALDERLAKE_P)
[14:00:29] [PASSED] 0xA780 (ALDERLAKE_S)
[14:00:29] [PASSED] 0xA781 (ALDERLAKE_S)
[14:00:29] [PASSED] 0xA782 (ALDERLAKE_S)
[14:00:29] [PASSED] 0xA783 (ALDERLAKE_S)
[14:00:29] [PASSED] 0xA788 (ALDERLAKE_S)
[14:00:29] [PASSED] 0xA789 (ALDERLAKE_S)
[14:00:29] [PASSED] 0xA78A (ALDERLAKE_S)
[14:00:29] [PASSED] 0xA78B (ALDERLAKE_S)
[14:00:29] [PASSED] 0x4905 (DG1)
[14:00:29] [PASSED] 0x4906 (DG1)
[14:00:29] [PASSED] 0x4907 (DG1)
[14:00:29] [PASSED] 0x4908 (DG1)
[14:00:29] [PASSED] 0x4909 (DG1)
[14:00:29] [PASSED] 0x56C0 (DG2)
[14:00:29] [PASSED] 0x56C2 (DG2)
[14:00:29] [PASSED] 0x56C1 (DG2)
[14:00:29] [PASSED] 0x7D51 (METEORLAKE)
[14:00:29] [PASSED] 0x7DD1 (METEORLAKE)
[14:00:29] [PASSED] 0x7D41 (METEORLAKE)
[14:00:29] [PASSED] 0x7D67 (METEORLAKE)
[14:00:29] [PASSED] 0xB640 (METEORLAKE)
[14:00:29] [PASSED] 0x56A0 (DG2)
[14:00:29] [PASSED] 0x56A1 (DG2)
[14:00:29] [PASSED] 0x56A2 (DG2)
[14:00:29] [PASSED] 0x56BE (DG2)
[14:00:29] [PASSED] 0x56BF (DG2)
[14:00:29] [PASSED] 0x5690 (DG2)
[14:00:29] [PASSED] 0x5691 (DG2)
[14:00:29] [PASSED] 0x5692 (DG2)
[14:00:29] [PASSED] 0x56A5 (DG2)
[14:00:29] [PASSED] 0x56A6 (DG2)
[14:00:29] [PASSED] 0x56B0 (DG2)
[14:00:29] [PASSED] 0x56B1 (DG2)
[14:00:29] [PASSED] 0x56BA (DG2)
[14:00:29] [PASSED] 0x56BB (DG2)
[14:00:29] [PASSED] 0x56BC (DG2)
[14:00:29] [PASSED] 0x56BD (DG2)
[14:00:29] [PASSED] 0x5693 (DG2)
[14:00:29] [PASSED] 0x5694 (DG2)
[14:00:29] [PASSED] 0x5695 (DG2)
[14:00:29] [PASSED] 0x56A3 (DG2)
[14:00:29] [PASSED] 0x56A4 (DG2)
[14:00:29] [PASSED] 0x56B2 (DG2)
[14:00:29] [PASSED] 0x56B3 (DG2)
[14:00:29] [PASSED] 0x5696 (DG2)
[14:00:29] [PASSED] 0x5697 (DG2)
[14:00:29] [PASSED] 0xB69 (PVC)
[14:00:29] [PASSED] 0xB6E (PVC)
[14:00:29] [PASSED] 0xBD4 (PVC)
[14:00:29] [PASSED] 0xBD5 (PVC)
[14:00:29] [PASSED] 0xBD6 (PVC)
[14:00:29] [PASSED] 0xBD7 (PVC)
[14:00:29] [PASSED] 0xBD8 (PVC)
[14:00:29] [PASSED] 0xBD9 (PVC)
[14:00:29] [PASSED] 0xBDA (PVC)
[14:00:29] [PASSED] 0xBDB (PVC)
[14:00:29] [PASSED] 0xBE0 (PVC)
[14:00:29] [PASSED] 0xBE1 (PVC)
[14:00:29] [PASSED] 0xBE5 (PVC)
[14:00:29] [PASSED] 0x7D40 (METEORLAKE)
[14:00:29] [PASSED] 0x7D45 (METEORLAKE)
[14:00:29] [PASSED] 0x7D55 (METEORLAKE)
[14:00:29] [PASSED] 0x7D60 (METEORLAKE)
[14:00:29] [PASSED] 0x7DD5 (METEORLAKE)
[14:00:29] [PASSED] 0x6420 (LUNARLAKE)
[14:00:29] [PASSED] 0x64A0 (LUNARLAKE)
[14:00:29] [PASSED] 0x64B0 (LUNARLAKE)
[14:00:29] [PASSED] 0xE202 (BATTLEMAGE)
[14:00:29] [PASSED] 0xE209 (BATTLEMAGE)
[14:00:29] [PASSED] 0xE20B (BATTLEMAGE)
[14:00:29] [PASSED] 0xE20C (BATTLEMAGE)
[14:00:29] [PASSED] 0xE20D (BATTLEMAGE)
[14:00:29] [PASSED] 0xE210 (BATTLEMAGE)
[14:00:29] [PASSED] 0xE211 (BATTLEMAGE)
[14:00:29] [PASSED] 0xE212 (BATTLEMAGE)
[14:00:29] [PASSED] 0xE216 (BATTLEMAGE)
[14:00:29] [PASSED] 0xE220 (BATTLEMAGE)
[14:00:29] [PASSED] 0xE221 (BATTLEMAGE)
[14:00:29] [PASSED] 0xE222 (BATTLEMAGE)
[14:00:29] [PASSED] 0xE223 (BATTLEMAGE)
[14:00:29] [PASSED] 0xB080 (PANTHERLAKE)
[14:00:29] [PASSED] 0xB081 (PANTHERLAKE)
[14:00:29] [PASSED] 0xB082 (PANTHERLAKE)
[14:00:29] [PASSED] 0xB083 (PANTHERLAKE)
[14:00:29] [PASSED] 0xB084 (PANTHERLAKE)
[14:00:29] [PASSED] 0xB085 (PANTHERLAKE)
[14:00:29] [PASSED] 0xB086 (PANTHERLAKE)
[14:00:29] [PASSED] 0xB087 (PANTHERLAKE)
[14:00:29] [PASSED] 0xB08F (PANTHERLAKE)
[14:00:29] [PASSED] 0xB090 (PANTHERLAKE)
[14:00:29] [PASSED] 0xB0A0 (PANTHERLAKE)
[14:00:29] [PASSED] 0xB0B0 (PANTHERLAKE)
[14:00:29] [PASSED] 0xD740 (NOVALAKE_S)
[14:00:29] [PASSED] 0xD741 (NOVALAKE_S)
[14:00:29] [PASSED] 0xD742 (NOVALAKE_S)
[14:00:29] [PASSED] 0xD743 (NOVALAKE_S)
[14:00:29] [PASSED] 0xD744 (NOVALAKE_S)
[14:00:29] [PASSED] 0xD745 (NOVALAKE_S)
[14:00:29] [PASSED] 0x674C (CRESCENTISLAND)
[14:00:29] [PASSED] 0xFD80 (PANTHERLAKE)
[14:00:29] [PASSED] 0xFD81 (PANTHERLAKE)
[14:00:29] =============== [PASSED] check_platform_desc ===============
[14:00:29] ===================== [PASSED] xe_pci ======================
[14:00:29] =================== xe_rtp (2 subtests) ====================
[14:00:29] =============== xe_rtp_process_to_sr_tests  ================
[14:00:29] [PASSED] coalesce-same-reg
[14:00:29] [PASSED] no-match-no-add
[14:00:29] [PASSED] match-or
[14:00:29] [PASSED] match-or-xfail
[14:00:29] [PASSED] no-match-no-add-multiple-rules
[14:00:29] [PASSED] two-regs-two-entries
[14:00:29] [PASSED] clr-one-set-other
[14:00:29] [PASSED] set-field
[14:00:29] [PASSED] conflict-duplicate
[14:00:29] [PASSED] conflict-not-disjoint
[14:00:29] [PASSED] conflict-reg-type
[14:00:29] =========== [PASSED] xe_rtp_process_to_sr_tests ============
[14:00:29] ================== xe_rtp_process_tests  ===================
[14:00:29] [PASSED] active1
[14:00:29] [PASSED] active2
[14:00:29] [PASSED] active-inactive
[14:00:29] [PASSED] inactive-active
[14:00:29] [PASSED] inactive-1st_or_active-inactive
[14:00:29] [PASSED] inactive-2nd_or_active-inactive
[14:00:29] [PASSED] inactive-last_or_active-inactive
[14:00:29] [PASSED] inactive-no_or_active-inactive
[14:00:29] ============== [PASSED] xe_rtp_process_tests ===============
[14:00:29] ===================== [PASSED] xe_rtp ======================
[14:00:29] ==================== xe_wa (1 subtest) =====================
[14:00:29] ======================== xe_wa_gt  =========================
[14:00:29] [PASSED] TIGERLAKE B0
[14:00:29] [PASSED] DG1 A0
[14:00:29] [PASSED] DG1 B0
[14:00:29] [PASSED] ALDERLAKE_S A0
[14:00:29] [PASSED] ALDERLAKE_S B0
[14:00:29] [PASSED] ALDERLAKE_S C0
[14:00:29] [PASSED] ALDERLAKE_S D0
[14:00:29] [PASSED] ALDERLAKE_P A0
[14:00:29] [PASSED] ALDERLAKE_P B0
[14:00:29] [PASSED] ALDERLAKE_P C0
[14:00:29] [PASSED] ALDERLAKE_S RPLS D0
[14:00:29] [PASSED] ALDERLAKE_P RPLU E0
[14:00:29] [PASSED] DG2 G10 C0
[14:00:29] [PASSED] DG2 G11 B1
[14:00:29] [PASSED] DG2 G12 A1
[14:00:29] [PASSED] METEORLAKE 12.70(Xe_LPG) A0 13.00(Xe_LPM+) A0
[14:00:29] [PASSED] METEORLAKE 12.71(Xe_LPG) A0 13.00(Xe_LPM+) A0
[14:00:29] [PASSED] METEORLAKE 12.74(Xe_LPG+) A0 13.00(Xe_LPM+) A0
[14:00:29] [PASSED] LUNARLAKE 20.04(Xe2_LPG) A0 20.00(Xe2_LPM) A0
[14:00:29] [PASSED] LUNARLAKE 20.04(Xe2_LPG) B0 20.00(Xe2_LPM) A0
[14:00:29] [PASSED] BATTLEMAGE 20.01(Xe2_HPG) A0 13.01(Xe2_HPM) A1
[14:00:29] [PASSED] PANTHERLAKE 30.00(Xe3_LPG) A0 30.00(Xe3_LPM) A0
[14:00:29] ==================== [PASSED] xe_wa_gt =====================
[14:00:29] ====================== [PASSED] xe_wa ======================
[14:00:29] ============================================================
[14:00:29] Testing complete. Ran 510 tests: passed: 492, skipped: 18
[14:00:29] Elapsed time: 42.323s total, 4.360s configuring, 37.446s building, 0.470s running

+ /kernel/tools/testing/kunit/kunit.py run --kunitconfig /kernel/drivers/gpu/drm/tests/.kunitconfig [14:00:29] Configuring KUnit Kernel ...
Regenerating .config ...
Populating config with:

$ make ARCH=um O=.kunit olddefconfig
[14:00:31] Building KUnit Kernel ...
Populating config with:
$ make ARCH=um O=.kunit olddefconfig
Building with:
$ make all compile_commands.json scripts_gdb ARCH=um O=.kunit --jobs=25
[14:01:01] Starting KUnit Kernel (1/1)...
[14:01:01] ============================================================
Running tests with:
$ .kunit/linux kunit.enable=1 mem=1G console=tty kunit_shutdown=halt
[14:01:01] ============ drm_test_pick_cmdline (2 subtests) ============
[14:01:01] [PASSED] drm_test_pick_cmdline_res_1920_1080_60
[14:01:01] =============== drm_test_pick_cmdline_named  ===============
[14:01:01] [PASSED] NTSC
[14:01:01] [PASSED] NTSC-J
[14:01:01] [PASSED] PAL
[14:01:01] [PASSED] PAL-M
[14:01:01] =========== [PASSED] drm_test_pick_cmdline_named ===========
[14:01:01] ============== [PASSED] drm_test_pick_cmdline ==============
[14:01:01] == drm_test_atomic_get_connector_for_encoder (1 subtest) ===
[14:01:01] [PASSED] drm_test_drm_atomic_get_connector_for_encoder
[14:01:01] ==== [PASSED] drm_test_atomic_get_connector_for_encoder ====
[14:01:01] =========== drm_validate_clone_mode (2 subtests) ===========
[14:01:01] ============== drm_test_check_in_clone_mode  ===============
[14:01:01] [PASSED] in_clone_mode
[14:01:01] [PASSED] not_in_clone_mode
[14:01:01] ========== [PASSED] drm_test_check_in_clone_mode ===========
[14:01:01] =============== drm_test_check_valid_clones  ===============
[14:01:01] [PASSED] not_in_clone_mode
[14:01:01] [PASSED] valid_clone
[14:01:01] [PASSED] invalid_clone
[14:01:01] =========== [PASSED] drm_test_check_valid_clones ===========
[14:01:01] ============= [PASSED] drm_validate_clone_mode =============
[14:01:01] ============= drm_validate_modeset (1 subtest) =============
[14:01:01] [PASSED] drm_test_check_connector_changed_modeset
[14:01:01] ============== [PASSED] drm_validate_modeset ===============
[14:01:01] ====== drm_test_bridge_get_current_state (2 subtests) ======
[14:01:01] [PASSED] drm_test_drm_bridge_get_current_state_atomic
[14:01:01] [PASSED] drm_test_drm_bridge_get_current_state_legacy
[14:01:01] ======== [PASSED] drm_test_bridge_get_current_state ========
[14:01:01] ====== drm_test_bridge_helper_reset_crtc (3 subtests) ======
[14:01:01] [PASSED] drm_test_drm_bridge_helper_reset_crtc_atomic
[14:01:01] [PASSED] drm_test_drm_bridge_helper_reset_crtc_atomic_disabled
[14:01:01] [PASSED] drm_test_drm_bridge_helper_reset_crtc_legacy
[14:01:01] ======== [PASSED] drm_test_bridge_helper_reset_crtc ========
[14:01:01] ============== drm_bridge_alloc (2 subtests) ===============
[14:01:01] [PASSED] drm_test_drm_bridge_alloc_basic
[14:01:01] [PASSED] drm_test_drm_bridge_alloc_get_put
[14:01:01] ================ [PASSED] drm_bridge_alloc =================
[14:01:01] ================== drm_buddy (8 subtests) ==================
[14:01:01] [PASSED] drm_test_buddy_alloc_limit
[14:01:01] [PASSED] drm_test_buddy_alloc_optimistic
[14:01:01] [PASSED] drm_test_buddy_alloc_pessimistic
[14:01:01] [PASSED] drm_test_buddy_alloc_pathological
[14:01:01] [PASSED] drm_test_buddy_alloc_contiguous
[14:01:01] [PASSED] drm_test_buddy_alloc_clear
[14:01:01] [PASSED] drm_test_buddy_alloc_range_bias
[14:01:01] [PASSED] drm_test_buddy_fragmentation_performance
[14:01:01] ==================== [PASSED] drm_buddy ====================
[14:01:01] ============= drm_cmdline_parser (40 subtests) =============
[14:01:01] [PASSED] drm_test_cmdline_force_d_only
[14:01:01] [PASSED] drm_test_cmdline_force_D_only_dvi
[14:01:01] [PASSED] drm_test_cmdline_force_D_only_hdmi
[14:01:01] [PASSED] drm_test_cmdline_force_D_only_not_digital
[14:01:01] [PASSED] drm_test_cmdline_force_e_only
[14:01:01] [PASSED] drm_test_cmdline_res
[14:01:01] [PASSED] drm_test_cmdline_res_vesa
[14:01:01] [PASSED] drm_test_cmdline_res_vesa_rblank
[14:01:01] [PASSED] drm_test_cmdline_res_rblank
[14:01:01] [PASSED] drm_test_cmdline_res_bpp
[14:01:01] [PASSED] drm_test_cmdline_res_refresh
[14:01:01] [PASSED] drm_test_cmdline_res_bpp_refresh
[14:01:01] [PASSED] drm_test_cmdline_res_bpp_refresh_interlaced
[14:01:01] [PASSED] drm_test_cmdline_res_bpp_refresh_margins
[14:01:01] [PASSED] drm_test_cmdline_res_bpp_refresh_force_off
[14:01:01] [PASSED] drm_test_cmdline_res_bpp_refresh_force_on
[14:01:01] [PASSED] drm_test_cmdline_res_bpp_refresh_force_on_analog
[14:01:01] [PASSED] drm_test_cmdline_res_bpp_refresh_force_on_digital
[14:01:01] [PASSED] drm_test_cmdline_res_bpp_refresh_interlaced_margins_force_on
[14:01:01] [PASSED] drm_test_cmdline_res_margins_force_on
[14:01:01] [PASSED] drm_test_cmdline_res_vesa_margins
[14:01:01] [PASSED] drm_test_cmdline_name
[14:01:01] [PASSED] drm_test_cmdline_name_bpp
[14:01:01] [PASSED] drm_test_cmdline_name_option
[14:01:01] [PASSED] drm_test_cmdline_name_bpp_option
[14:01:01] [PASSED] drm_test_cmdline_rotate_0
[14:01:01] [PASSED] drm_test_cmdline_rotate_90
[14:01:01] [PASSED] drm_test_cmdline_rotate_180
[14:01:01] [PASSED] drm_test_cmdline_rotate_270
[14:01:01] [PASSED] drm_test_cmdline_hmirror
[14:01:01] [PASSED] drm_test_cmdline_vmirror
[14:01:01] [PASSED] drm_test_cmdline_margin_options
[14:01:01] [PASSED] drm_test_cmdline_multiple_options
[14:01:01] [PASSED] drm_test_cmdline_bpp_extra_and_option
[14:01:01] [PASSED] drm_test_cmdline_extra_and_option
[14:01:01] [PASSED] drm_test_cmdline_freestanding_options
[14:01:01] [PASSED] drm_test_cmdline_freestanding_force_e_and_options
[14:01:01] [PASSED] drm_test_cmdline_panel_orientation
[14:01:01] ================ drm_test_cmdline_invalid  =================
[14:01:01] [PASSED] margin_only
[14:01:01] [PASSED] interlace_only
[14:01:01] [PASSED] res_missing_x
[14:01:01] [PASSED] res_missing_y
[14:01:01] [PASSED] res_bad_y
[14:01:01] [PASSED] res_missing_y_bpp
[14:01:01] [PASSED] res_bad_bpp
[14:01:01] [PASSED] res_bad_refresh
[14:01:01] [PASSED] res_bpp_refresh_force_on_off
[14:01:01] [PASSED] res_invalid_mode
[14:01:01] [PASSED] res_bpp_wrong_place_mode
[14:01:01] [PASSED] name_bpp_refresh
[14:01:01] [PASSED] name_refresh
[14:01:01] [PASSED] name_refresh_wrong_mode
[14:01:01] [PASSED] name_refresh_invalid_mode
[14:01:01] [PASSED] rotate_multiple
[14:01:01] [PASSED] rotate_invalid_val
[14:01:01] [PASSED] rotate_truncated
[14:01:01] [PASSED] invalid_option
[14:01:01] [PASSED] invalid_tv_option
[14:01:01] [PASSED] truncated_tv_option
[14:01:01] ============ [PASSED] drm_test_cmdline_invalid =============
[14:01:01] =============== drm_test_cmdline_tv_options  ===============
[14:01:01] [PASSED] NTSC
[14:01:01] [PASSED] NTSC_443
[14:01:01] [PASSED] NTSC_J
[14:01:01] [PASSED] PAL
[14:01:01] [PASSED] PAL_M
[14:01:01] [PASSED] PAL_N
[14:01:01] [PASSED] SECAM
[14:01:01] [PASSED] MONO_525
[14:01:01] [PASSED] MONO_625
[14:01:01] =========== [PASSED] drm_test_cmdline_tv_options ===========
[14:01:01] =============== [PASSED] drm_cmdline_parser ================
[14:01:01] ========== drmm_connector_hdmi_init (20 subtests) ==========
[14:01:01] [PASSED] drm_test_connector_hdmi_init_valid
[14:01:01] [PASSED] drm_test_connector_hdmi_init_bpc_8
[14:01:01] [PASSED] drm_test_connector_hdmi_init_bpc_10
[14:01:01] [PASSED] drm_test_connector_hdmi_init_bpc_12
[14:01:01] [PASSED] drm_test_connector_hdmi_init_bpc_invalid
[14:01:01] [PASSED] drm_test_connector_hdmi_init_bpc_null
[14:01:01] [PASSED] drm_test_connector_hdmi_init_formats_empty
[14:01:01] [PASSED] drm_test_connector_hdmi_init_formats_no_rgb
[14:01:01] === drm_test_connector_hdmi_init_formats_yuv420_allowed  ===
[14:01:01] [PASSED] supported_formats=0x9 yuv420_allowed=1
[14:01:01] [PASSED] supported_formats=0x9 yuv420_allowed=0
[14:01:01] [PASSED] supported_formats=0x3 yuv420_allowed=1
[14:01:01] [PASSED] supported_formats=0x3 yuv420_allowed=0
[14:01:01] === [PASSED] drm_test_connector_hdmi_init_formats_yuv420_allowed ===
[14:01:01] [PASSED] drm_test_connector_hdmi_init_null_ddc
[14:01:01] [PASSED] drm_test_connector_hdmi_init_null_product
[14:01:01] [PASSED] drm_test_connector_hdmi_init_null_vendor
[14:01:01] [PASSED] drm_test_connector_hdmi_init_product_length_exact
[14:01:01] [PASSED] drm_test_connector_hdmi_init_product_length_too_long
[14:01:01] [PASSED] drm_test_connector_hdmi_init_product_valid
[14:01:01] [PASSED] drm_test_connector_hdmi_init_vendor_length_exact
[14:01:01] [PASSED] drm_test_connector_hdmi_init_vendor_length_too_long
[14:01:01] [PASSED] drm_test_connector_hdmi_init_vendor_valid
[14:01:01] ========= drm_test_connector_hdmi_init_type_valid  =========
[14:01:01] [PASSED] HDMI-A
[14:01:01] [PASSED] HDMI-B
[14:01:01] ===== [PASSED] drm_test_connector_hdmi_init_type_valid =====
[14:01:01] ======== drm_test_connector_hdmi_init_type_invalid  ========
[14:01:01] [PASSED] Unknown
[14:01:01] [PASSED] VGA
[14:01:01] [PASSED] DVI-I
[14:01:01] [PASSED] DVI-D
[14:01:01] [PASSED] DVI-A
[14:01:01] [PASSED] Composite
[14:01:01] [PASSED] SVIDEO
[14:01:01] [PASSED] LVDS
[14:01:01] [PASSED] Component
[14:01:01] [PASSED] DIN
[14:01:01] [PASSED] DP
[14:01:01] [PASSED] TV
[14:01:01] [PASSED] eDP
[14:01:01] [PASSED] Virtual
[14:01:01] [PASSED] DSI
[14:01:01] [PASSED] DPI
[14:01:01] [PASSED] Writeback
[14:01:01] [PASSED] SPI
[14:01:01] [PASSED] USB
[14:01:01] ==== [PASSED] drm_test_connector_hdmi_init_type_invalid ====
[14:01:01] ============ [PASSED] drmm_connector_hdmi_init =============
[14:01:01] ============= drmm_connector_init (3 subtests) =============
[14:01:01] [PASSED] drm_test_drmm_connector_init
[14:01:01] [PASSED] drm_test_drmm_connector_init_null_ddc
[14:01:01] ========= drm_test_drmm_connector_init_type_valid  =========
[14:01:01] [PASSED] Unknown
[14:01:01] [PASSED] VGA
[14:01:01] [PASSED] DVI-I
[14:01:01] [PASSED] DVI-D
[14:01:01] [PASSED] DVI-A
[14:01:01] [PASSED] Composite
[14:01:01] [PASSED] SVIDEO
[14:01:01] [PASSED] LVDS
[14:01:01] [PASSED] Component
[14:01:01] [PASSED] DIN
[14:01:01] [PASSED] DP
[14:01:01] [PASSED] HDMI-A
[14:01:01] [PASSED] HDMI-B
[14:01:01] [PASSED] TV
[14:01:01] [PASSED] eDP
[14:01:01] [PASSED] Virtual
[14:01:01] [PASSED] DSI
[14:01:01] [PASSED] DPI
[14:01:01] [PASSED] Writeback
[14:01:01] [PASSED] SPI
[14:01:01] [PASSED] USB
[14:01:01] ===== [PASSED] drm_test_drmm_connector_init_type_valid =====
[14:01:01] =============== [PASSED] drmm_connector_init ===============
[14:01:01] ========= drm_connector_dynamic_init (6 subtests) ==========
[14:01:01] [PASSED] drm_test_drm_connector_dynamic_init
[14:01:01] [PASSED] drm_test_drm_connector_dynamic_init_null_ddc
[14:01:01] [PASSED] drm_test_drm_connector_dynamic_init_not_added
[14:01:01] [PASSED] drm_test_drm_connector_dynamic_init_properties
[14:01:01] ===== drm_test_drm_connector_dynamic_init_type_valid  ======
[14:01:01] [PASSED] Unknown
[14:01:01] [PASSED] VGA
[14:01:01] [PASSED] DVI-I
[14:01:01] [PASSED] DVI-D
[14:01:01] [PASSED] DVI-A
[14:01:01] [PASSED] Composite
[14:01:01] [PASSED] SVIDEO
[14:01:01] [PASSED] LVDS
[14:01:01] [PASSED] Component
[14:01:01] [PASSED] DIN
[14:01:01] [PASSED] DP
[14:01:01] [PASSED] HDMI-A
[14:01:01] [PASSED] HDMI-B
[14:01:01] [PASSED] TV
[14:01:01] [PASSED] eDP
[14:01:01] [PASSED] Virtual
[14:01:01] [PASSED] DSI
[14:01:01] [PASSED] DPI
[14:01:01] [PASSED] Writeback
[14:01:01] [PASSED] SPI
[14:01:01] [PASSED] USB
[14:01:01] = [PASSED] drm_test_drm_connector_dynamic_init_type_valid ==
[14:01:01] ======== drm_test_drm_connector_dynamic_init_name  =========
[14:01:01] [PASSED] Unknown
[14:01:01] [PASSED] VGA
[14:01:01] [PASSED] DVI-I
[14:01:01] [PASSED] DVI-D
[14:01:01] [PASSED] DVI-A
[14:01:01] [PASSED] Composite
[14:01:01] [PASSED] SVIDEO
[14:01:01] [PASSED] LVDS
[14:01:01] [PASSED] Component
[14:01:01] [PASSED] DIN
[14:01:01] [PASSED] DP
[14:01:01] [PASSED] HDMI-A
[14:01:01] [PASSED] HDMI-B
[14:01:01] [PASSED] TV
[14:01:01] [PASSED] eDP
[14:01:01] [PASSED] Virtual
[14:01:01] [PASSED] DSI
[14:01:01] [PASSED] DPI
[14:01:01] [PASSED] Writeback
[14:01:01] [PASSED] SPI
[14:01:01] [PASSED] USB
[14:01:01] ==== [PASSED] drm_test_drm_connector_dynamic_init_name =====
[14:01:01] =========== [PASSED] drm_connector_dynamic_init ============
[14:01:01] ==== drm_connector_dynamic_register_early (4 subtests) =====
[14:01:01] [PASSED] drm_test_drm_connector_dynamic_register_early_on_list
[14:01:01] [PASSED] drm_test_drm_connector_dynamic_register_early_defer
[14:01:01] [PASSED] drm_test_drm_connector_dynamic_register_early_no_init
[14:01:01] [PASSED] drm_test_drm_connector_dynamic_register_early_no_mode_object
[14:01:01] ====== [PASSED] drm_connector_dynamic_register_early =======
[14:01:01] ======= drm_connector_dynamic_register (7 subtests) ========
[14:01:01] [PASSED] drm_test_drm_connector_dynamic_register_on_list
[14:01:01] [PASSED] drm_test_drm_connector_dynamic_register_no_defer
[14:01:01] [PASSED] drm_test_drm_connector_dynamic_register_no_init
[14:01:01] [PASSED] drm_test_drm_connector_dynamic_register_mode_object
[14:01:01] [PASSED] drm_test_drm_connector_dynamic_register_sysfs
[14:01:01] [PASSED] drm_test_drm_connector_dynamic_register_sysfs_name
[14:01:01] [PASSED] drm_test_drm_connector_dynamic_register_debugfs
[14:01:01] ========= [PASSED] drm_connector_dynamic_register ==========
[14:01:01] = drm_connector_attach_broadcast_rgb_property (2 subtests) =
[14:01:01] [PASSED] drm_test_drm_connector_attach_broadcast_rgb_property
[14:01:01] [PASSED] drm_test_drm_connector_attach_broadcast_rgb_property_hdmi_connector
[14:01:01] === [PASSED] drm_connector_attach_broadcast_rgb_property ===
[14:01:01] ========== drm_get_tv_mode_from_name (2 subtests) ==========
[14:01:01] ========== drm_test_get_tv_mode_from_name_valid  ===========
[14:01:01] [PASSED] NTSC
[14:01:01] [PASSED] NTSC-443
[14:01:01] [PASSED] NTSC-J
[14:01:01] [PASSED] PAL
[14:01:01] [PASSED] PAL-M
[14:01:01] [PASSED] PAL-N
[14:01:01] [PASSED] SECAM
[14:01:01] [PASSED] Mono
[14:01:01] ====== [PASSED] drm_test_get_tv_mode_from_name_valid =======
[14:01:01] [PASSED] drm_test_get_tv_mode_from_name_truncated
[14:01:01] ============ [PASSED] drm_get_tv_mode_from_name ============
[14:01:01] = drm_test_connector_hdmi_compute_mode_clock (12 subtests) =
[14:01:01] [PASSED] drm_test_drm_hdmi_compute_mode_clock_rgb
[14:01:01] [PASSED] drm_test_drm_hdmi_compute_mode_clock_rgb_10bpc
[14:01:01] [PASSED] drm_test_drm_hdmi_compute_mode_clock_rgb_10bpc_vic_1
[14:01:01] [PASSED] drm_test_drm_hdmi_compute_mode_clock_rgb_12bpc
[14:01:01] [PASSED] drm_test_drm_hdmi_compute_mode_clock_rgb_12bpc_vic_1
[14:01:01] [PASSED] drm_test_drm_hdmi_compute_mode_clock_rgb_double
[14:01:01] = drm_test_connector_hdmi_compute_mode_clock_yuv420_valid  =
[14:01:01] [PASSED] VIC 96
[14:01:01] [PASSED] VIC 97
[14:01:01] [PASSED] VIC 101
[14:01:01] [PASSED] VIC 102
[14:01:01] [PASSED] VIC 106
[14:01:01] [PASSED] VIC 107
[14:01:01] === [PASSED] drm_test_connector_hdmi_compute_mode_clock_yuv420_valid ===
[14:01:01] [PASSED] drm_test_connector_hdmi_compute_mode_clock_yuv420_10_bpc
[14:01:01] [PASSED] drm_test_connector_hdmi_compute_mode_clock_yuv420_12_bpc
[14:01:01] [PASSED] drm_test_connector_hdmi_compute_mode_clock_yuv422_8_bpc
[14:01:01] [PASSED] drm_test_connector_hdmi_compute_mode_clock_yuv422_10_bpc
[14:01:01] [PASSED] drm_test_connector_hdmi_compute_mode_clock_yuv422_12_bpc
[14:01:01] === [PASSED] drm_test_connector_hdmi_compute_mode_clock ====
[14:01:01] == drm_hdmi_connector_get_broadcast_rgb_name (2 subtests) ==
[14:01:01] === drm_test_drm_hdmi_connector_get_broadcast_rgb_name  ====
[14:01:01] [PASSED] Automatic
[14:01:01] [PASSED] Full
[14:01:01] [PASSED] Limited 16:235
[14:01:01] === [PASSED] drm_test_drm_hdmi_connector_get_broadcast_rgb_name ===
[14:01:01] [PASSED] drm_test_drm_hdmi_connector_get_broadcast_rgb_name_invalid
[14:01:01] ==== [PASSED] drm_hdmi_connector_get_broadcast_rgb_name ====
[14:01:01] == drm_hdmi_connector_get_output_format_name (2 subtests) ==
[14:01:01] === drm_test_drm_hdmi_connector_get_output_format_name  ====
[14:01:01] [PASSED] RGB
[14:01:01] [PASSED] YUV 4:2:0
[14:01:01] [PASSED] YUV 4:2:2
[14:01:01] [PASSED] YUV 4:4:4
[14:01:01] === [PASSED] drm_test_drm_hdmi_connector_get_output_format_name ===
[14:01:01] [PASSED] drm_test_drm_hdmi_connector_get_output_format_name_invalid
[14:01:01] ==== [PASSED] drm_hdmi_connector_get_output_format_name ====
[14:01:01] ============= drm_damage_helper (21 subtests) ==============
[14:01:01] [PASSED] drm_test_damage_iter_no_damage
[14:01:01] [PASSED] drm_test_damage_iter_no_damage_fractional_src
[14:01:01] [PASSED] drm_test_damage_iter_no_damage_src_moved
[14:01:01] [PASSED] drm_test_damage_iter_no_damage_fractional_src_moved
[14:01:01] [PASSED] drm_test_damage_iter_no_damage_not_visible
[14:01:01] [PASSED] drm_test_damage_iter_no_damage_no_crtc
[14:01:01] [PASSED] drm_test_damage_iter_no_damage_no_fb
[14:01:01] [PASSED] drm_test_damage_iter_simple_damage
[14:01:01] [PASSED] drm_test_damage_iter_single_damage
[14:01:01] [PASSED] drm_test_damage_iter_single_damage_intersect_src
[14:01:01] [PASSED] drm_test_damage_iter_single_damage_outside_src
[14:01:01] [PASSED] drm_test_damage_iter_single_damage_fractional_src
[14:01:01] [PASSED] drm_test_damage_iter_single_damage_intersect_fractional_src
[14:01:01] [PASSED] drm_test_damage_iter_single_damage_outside_fractional_src
[14:01:01] [PASSED] drm_test_damage_iter_single_damage_src_moved
[14:01:01] [PASSED] drm_test_damage_iter_single_damage_fractional_src_moved
[14:01:01] [PASSED] drm_test_damage_iter_damage
[14:01:01] [PASSED] drm_test_damage_iter_damage_one_intersect
[14:01:01] [PASSED] drm_test_damage_iter_damage_one_outside
[14:01:01] [PASSED] drm_test_damage_iter_damage_src_moved
[14:01:01] [PASSED] drm_test_damage_iter_damage_not_visible
[14:01:01] ================ [PASSED] drm_damage_helper ================
[14:01:01] ============== drm_dp_mst_helper (3 subtests) ==============
[14:01:01] ============== drm_test_dp_mst_calc_pbn_mode  ==============
[14:01:01] [PASSED] Clock 154000 BPP 30 DSC disabled
[14:01:01] [PASSED] Clock 234000 BPP 30 DSC disabled
[14:01:01] [PASSED] Clock 297000 BPP 24 DSC disabled
[14:01:01] [PASSED] Clock 332880 BPP 24 DSC enabled
[14:01:01] [PASSED] Clock 324540 BPP 24 DSC enabled
[14:01:01] ========== [PASSED] drm_test_dp_mst_calc_pbn_mode ==========
[14:01:01] ============== drm_test_dp_mst_calc_pbn_div  ===============
[14:01:01] [PASSED] Link rate 2000000 lane count 4
[14:01:01] [PASSED] Link rate 2000000 lane count 2
[14:01:01] [PASSED] Link rate 2000000 lane count 1
[14:01:01] [PASSED] Link rate 1350000 lane count 4
[14:01:01] [PASSED] Link rate 1350000 lane count 2
[14:01:01] [PASSED] Link rate 1350000 lane count 1
[14:01:01] [PASSED] Link rate 1000000 lane count 4
[14:01:01] [PASSED] Link rate 1000000 lane count 2
[14:01:01] [PASSED] Link rate 1000000 lane count 1
[14:01:01] [PASSED] Link rate 810000 lane count 4
[14:01:01] [PASSED] Link rate 810000 lane count 2
[14:01:01] [PASSED] Link rate 810000 lane count 1
[14:01:01] [PASSED] Link rate 540000 lane count 4
[14:01:01] [PASSED] Link rate 540000 lane count 2
[14:01:01] [PASSED] Link rate 540000 lane count 1
[14:01:01] [PASSED] Link rate 270000 lane count 4
[14:01:01] [PASSED] Link rate 270000 lane count 2
[14:01:01] [PASSED] Link rate 270000 lane count 1
[14:01:01] [PASSED] Link rate 162000 lane count 4
[14:01:01] [PASSED] Link rate 162000 lane count 2
[14:01:01] [PASSED] Link rate 162000 lane count 1
[14:01:01] ========== [PASSED] drm_test_dp_mst_calc_pbn_div ===========
[14:01:01] ========= drm_test_dp_mst_sideband_msg_req_decode  =========
[14:01:01] [PASSED] DP_ENUM_PATH_RESOURCES with port number
[14:01:01] [PASSED] DP_POWER_UP_PHY with port number
[14:01:01] [PASSED] DP_POWER_DOWN_PHY with port number
[14:01:01] [PASSED] DP_ALLOCATE_PAYLOAD with SDP stream sinks
[14:01:01] [PASSED] DP_ALLOCATE_PAYLOAD with port number
[14:01:01] [PASSED] DP_ALLOCATE_PAYLOAD with VCPI
[14:01:01] [PASSED] DP_ALLOCATE_PAYLOAD with PBN
[14:01:01] [PASSED] DP_QUERY_PAYLOAD with port number
[14:01:01] [PASSED] DP_QUERY_PAYLOAD with VCPI
[14:01:01] [PASSED] DP_REMOTE_DPCD_READ with port number
[14:01:01] [PASSED] DP_REMOTE_DPCD_READ with DPCD address
[14:01:01] [PASSED] DP_REMOTE_DPCD_READ with max number of bytes
[14:01:01] [PASSED] DP_REMOTE_DPCD_WRITE with port number
[14:01:01] [PASSED] DP_REMOTE_DPCD_WRITE with DPCD address
[14:01:01] [PASSED] DP_REMOTE_DPCD_WRITE with data array
[14:01:01] [PASSED] DP_REMOTE_I2C_READ with port number
[14:01:01] [PASSED] DP_REMOTE_I2C_READ with I2C device ID
[14:01:01] [PASSED] DP_REMOTE_I2C_READ with transactions array
[14:01:01] [PASSED] DP_REMOTE_I2C_WRITE with port number
[14:01:01] [PASSED] DP_REMOTE_I2C_WRITE with I2C device ID
[14:01:01] [PASSED] DP_REMOTE_I2C_WRITE with data array
[14:01:01] [PASSED] DP_QUERY_STREAM_ENC_STATUS with stream ID
[14:01:01] [PASSED] DP_QUERY_STREAM_ENC_STATUS with client ID
[14:01:01] [PASSED] DP_QUERY_STREAM_ENC_STATUS with stream event
[14:01:01] [PASSED] DP_QUERY_STREAM_ENC_STATUS with valid stream event
[14:01:01] [PASSED] DP_QUERY_STREAM_ENC_STATUS with stream behavior
[14:01:01] [PASSED] DP_QUERY_STREAM_ENC_STATUS with a valid stream behavior
[14:01:01] ===== [PASSED] drm_test_dp_mst_sideband_msg_req_decode =====
[14:01:01] ================ [PASSED] drm_dp_mst_helper ================
[14:01:01] ================== drm_exec (7 subtests) ===================
[14:01:01] [PASSED] sanitycheck
[14:01:01] [PASSED] test_lock
[14:01:01] [PASSED] test_lock_unlock
[14:01:01] [PASSED] test_duplicates
[14:01:01] [PASSED] test_prepare
[14:01:01] [PASSED] test_prepare_array
[14:01:01] [PASSED] test_multiple_loops
[14:01:01] ==================== [PASSED] drm_exec =====================
[14:01:01] =========== drm_format_helper_test (17 subtests) ===========
[14:01:01] ============== drm_test_fb_xrgb8888_to_gray8  ==============
[14:01:01] [PASSED] single_pixel_source_buffer
[14:01:01] [PASSED] single_pixel_clip_rectangle
[14:01:01] [PASSED] well_known_colors
[14:01:01] [PASSED] destination_pitch
[14:01:01] ========== [PASSED] drm_test_fb_xrgb8888_to_gray8 ==========
[14:01:01] ============= drm_test_fb_xrgb8888_to_rgb332  ==============
[14:01:01] [PASSED] single_pixel_source_buffer
[14:01:01] [PASSED] single_pixel_clip_rectangle
[14:01:01] [PASSED] well_known_colors
[14:01:01] [PASSED] destination_pitch
[14:01:01] ========= [PASSED] drm_test_fb_xrgb8888_to_rgb332 ==========
[14:01:01] ============= drm_test_fb_xrgb8888_to_rgb565  ==============
[14:01:01] [PASSED] single_pixel_source_buffer
[14:01:01] [PASSED] single_pixel_clip_rectangle
[14:01:01] [PASSED] well_known_colors
[14:01:01] [PASSED] destination_pitch
[14:01:01] ========= [PASSED] drm_test_fb_xrgb8888_to_rgb565 ==========
[14:01:01] ============ drm_test_fb_xrgb8888_to_xrgb1555  =============
[14:01:01] [PASSED] single_pixel_source_buffer
[14:01:01] [PASSED] single_pixel_clip_rectangle
[14:01:01] [PASSED] well_known_colors
[14:01:01] [PASSED] destination_pitch
[14:01:01] ======== [PASSED] drm_test_fb_xrgb8888_to_xrgb1555 =========
[14:01:01] ============ drm_test_fb_xrgb8888_to_argb1555  =============
[14:01:01] [PASSED] single_pixel_source_buffer
[14:01:01] [PASSED] single_pixel_clip_rectangle
[14:01:01] [PASSED] well_known_colors
[14:01:01] [PASSED] destination_pitch
[14:01:01] ======== [PASSED] drm_test_fb_xrgb8888_to_argb1555 =========
[14:01:01] ============ drm_test_fb_xrgb8888_to_rgba5551  =============
[14:01:01] [PASSED] single_pixel_source_buffer
[14:01:01] [PASSED] single_pixel_clip_rectangle
[14:01:01] [PASSED] well_known_colors
[14:01:01] [PASSED] destination_pitch
[14:01:01] ======== [PASSED] drm_test_fb_xrgb8888_to_rgba5551 =========
[14:01:01] ============= drm_test_fb_xrgb8888_to_rgb888  ==============
[14:01:01] [PASSED] single_pixel_source_buffer
[14:01:01] [PASSED] single_pixel_clip_rectangle
[14:01:01] [PASSED] well_known_colors
[14:01:01] [PASSED] destination_pitch
[14:01:01] ========= [PASSED] drm_test_fb_xrgb8888_to_rgb888 ==========
[14:01:01] ============= drm_test_fb_xrgb8888_to_bgr888  ==============
[14:01:01] [PASSED] single_pixel_source_buffer
[14:01:01] [PASSED] single_pixel_clip_rectangle
[14:01:01] [PASSED] well_known_colors
[14:01:01] [PASSED] destination_pitch
[14:01:01] ========= [PASSED] drm_test_fb_xrgb8888_to_bgr888 ==========
[14:01:01] ============ drm_test_fb_xrgb8888_to_argb8888  =============
[14:01:01] [PASSED] single_pixel_source_buffer
[14:01:01] [PASSED] single_pixel_clip_rectangle
[14:01:01] [PASSED] well_known_colors
[14:01:01] [PASSED] destination_pitch
[14:01:01] ======== [PASSED] drm_test_fb_xrgb8888_to_argb8888 =========
[14:01:01] =========== drm_test_fb_xrgb8888_to_xrgb2101010  ===========
[14:01:01] [PASSED] single_pixel_source_buffer
[14:01:01] [PASSED] single_pixel_clip_rectangle
[14:01:01] [PASSED] well_known_colors
[14:01:01] [PASSED] destination_pitch
[14:01:01] ======= [PASSED] drm_test_fb_xrgb8888_to_xrgb2101010 =======
[14:01:01] =========== drm_test_fb_xrgb8888_to_argb2101010  ===========
[14:01:01] [PASSED] single_pixel_source_buffer
[14:01:01] [PASSED] single_pixel_clip_rectangle
[14:01:01] [PASSED] well_known_colors
[14:01:01] [PASSED] destination_pitch
[14:01:01] ======= [PASSED] drm_test_fb_xrgb8888_to_argb2101010 =======
[14:01:01] ============== drm_test_fb_xrgb8888_to_mono  ===============
[14:01:01] [PASSED] single_pixel_source_buffer
[14:01:01] [PASSED] single_pixel_clip_rectangle
[14:01:01] [PASSED] well_known_colors
[14:01:01] [PASSED] destination_pitch
[14:01:01] ========== [PASSED] drm_test_fb_xrgb8888_to_mono ===========
[14:01:01] ==================== drm_test_fb_swab  =====================
[14:01:01] [PASSED] single_pixel_source_buffer
[14:01:01] [PASSED] single_pixel_clip_rectangle
[14:01:01] [PASSED] well_known_colors
[14:01:01] [PASSED] destination_pitch
[14:01:01] ================ [PASSED] drm_test_fb_swab =================
[14:01:01] ============ drm_test_fb_xrgb8888_to_xbgr8888  =============
[14:01:01] [PASSED] single_pixel_source_buffer
[14:01:01] [PASSED] single_pixel_clip_rectangle
[14:01:01] [PASSED] well_known_colors
[14:01:01] [PASSED] destination_pitch
[14:01:01] ======== [PASSED] drm_test_fb_xrgb8888_to_xbgr8888 =========
[14:01:01] ============ drm_test_fb_xrgb8888_to_abgr8888  =============
[14:01:01] [PASSED] single_pixel_source_buffer
[14:01:01] [PASSED] single_pixel_clip_rectangle
[14:01:01] [PASSED] well_known_colors
[14:01:01] [PASSED] destination_pitch
[14:01:01] ======== [PASSED] drm_test_fb_xrgb8888_to_abgr8888 =========
[14:01:01] ================= drm_test_fb_clip_offset  =================
[14:01:01] [PASSED] pass through
[14:01:01] [PASSED] horizontal offset
[14:01:01] [PASSED] vertical offset
[14:01:01] [PASSED] horizontal and vertical offset
[14:01:01] [PASSED] horizontal offset (custom pitch)
[14:01:01] [PASSED] vertical offset (custom pitch)
[14:01:01] [PASSED] horizontal and vertical offset (custom pitch)
[14:01:01] ============= [PASSED] drm_test_fb_clip_offset =============
[14:01:01] =================== drm_test_fb_memcpy  ====================
[14:01:01] [PASSED] single_pixel_source_buffer: XR24 little-endian (0x34325258)
[14:01:01] [PASSED] single_pixel_source_buffer: XRA8 little-endian (0x38415258)
[14:01:01] [PASSED] single_pixel_source_buffer: YU24 little-endian (0x34325559)
[14:01:01] [PASSED] single_pixel_clip_rectangle: XB24 little-endian (0x34324258)
[14:01:01] [PASSED] single_pixel_clip_rectangle: XRA8 little-endian (0x38415258)
[14:01:01] [PASSED] single_pixel_clip_rectangle: YU24 little-endian (0x34325559)
[14:01:01] [PASSED] well_known_colors: XB24 little-endian (0x34324258)
[14:01:01] [PASSED] well_known_colors: XRA8 little-endian (0x38415258)
[14:01:01] [PASSED] well_known_colors: YU24 little-endian (0x34325559)
[14:01:01] [PASSED] destination_pitch: XB24 little-endian (0x34324258)
[14:01:01] [PASSED] destination_pitch: XRA8 little-endian (0x38415258)
[14:01:01] [PASSED] destination_pitch: YU24 little-endian (0x34325559)
[14:01:01] =============== [PASSED] drm_test_fb_memcpy ================
[14:01:01] ============= [PASSED] drm_format_helper_test ==============
[14:01:01] ================= drm_format (18 subtests) =================
[14:01:01] [PASSED] drm_test_format_block_width_invalid
[14:01:01] [PASSED] drm_test_format_block_width_one_plane
[14:01:01] [PASSED] drm_test_format_block_width_two_plane
[14:01:01] [PASSED] drm_test_format_block_width_three_plane
[14:01:01] [PASSED] drm_test_format_block_width_tiled
[14:01:01] [PASSED] drm_test_format_block_height_invalid
[14:01:01] [PASSED] drm_test_format_block_height_one_plane
[14:01:01] [PASSED] drm_test_format_block_height_two_plane
[14:01:01] [PASSED] drm_test_format_block_height_three_plane
[14:01:01] [PASSED] drm_test_format_block_height_tiled
[14:01:01] [PASSED] drm_test_format_min_pitch_invalid
[14:01:01] [PASSED] drm_test_format_min_pitch_one_plane_8bpp
[14:01:01] [PASSED] drm_test_format_min_pitch_one_plane_16bpp
[14:01:01] [PASSED] drm_test_format_min_pitch_one_plane_24bpp
[14:01:01] [PASSED] drm_test_format_min_pitch_one_plane_32bpp
[14:01:01] [PASSED] drm_test_format_min_pitch_two_plane
[14:01:01] [PASSED] drm_test_format_min_pitch_three_plane_8bpp
[14:01:01] [PASSED] drm_test_format_min_pitch_tiled
[14:01:01] =================== [PASSED] drm_format ====================
[14:01:01] ============== drm_framebuffer (10 subtests) ===============
[14:01:01] ========== drm_test_framebuffer_check_src_coords  ==========
[14:01:01] [PASSED] Success: source fits into fb
[14:01:01] [PASSED] Fail: overflowing fb with x-axis coordinate
[14:01:01] [PASSED] Fail: overflowing fb with y-axis coordinate
[14:01:01] [PASSED] Fail: overflowing fb with source width
[14:01:01] [PASSED] Fail: overflowing fb with source height
[14:01:01] ====== [PASSED] drm_test_framebuffer_check_src_coords ======
[14:01:01] [PASSED] drm_test_framebuffer_cleanup
[14:01:01] =============== drm_test_framebuffer_create  ===============
[14:01:01] [PASSED] ABGR8888 normal sizes
[14:01:01] [PASSED] ABGR8888 max sizes
[14:01:01] [PASSED] ABGR8888 pitch greater than min required
[14:01:01] [PASSED] ABGR8888 pitch less than min required
[14:01:01] [PASSED] ABGR8888 Invalid width
[14:01:01] [PASSED] ABGR8888 Invalid buffer handle
[14:01:01] [PASSED] No pixel format
[14:01:01] [PASSED] ABGR8888 Width 0
[14:01:01] [PASSED] ABGR8888 Height 0
[14:01:01] [PASSED] ABGR8888 Out of bound height * pitch combination
[14:01:01] [PASSED] ABGR8888 Large buffer offset
[14:01:01] [PASSED] ABGR8888 Buffer offset for inexistent plane
[14:01:01] [PASSED] ABGR8888 Invalid flag
[14:01:01] [PASSED] ABGR8888 Set DRM_MODE_FB_MODIFIERS without modifiers
[14:01:01] [PASSED] ABGR8888 Valid buffer modifier
[14:01:01] [PASSED] ABGR8888 Invalid buffer modifier(DRM_FORMAT_MOD_SAMSUNG_64_32_TILE)
[14:01:01] [PASSED] ABGR8888 Extra pitches without DRM_MODE_FB_MODIFIERS
[14:01:01] [PASSED] ABGR8888 Extra pitches with DRM_MODE_FB_MODIFIERS
[14:01:01] [PASSED] NV12 Normal sizes
[14:01:01] [PASSED] NV12 Max sizes
[14:01:01] [PASSED] NV12 Invalid pitch
[14:01:01] [PASSED] NV12 Invalid modifier/missing DRM_MODE_FB_MODIFIERS flag
[14:01:01] [PASSED] NV12 different  modifier per-plane
[14:01:01] [PASSED] NV12 with DRM_FORMAT_MOD_SAMSUNG_64_32_TILE
[14:01:01] [PASSED] NV12 Valid modifiers without DRM_MODE_FB_MODIFIERS
[14:01:01] [PASSED] NV12 Modifier for inexistent plane
[14:01:01] [PASSED] NV12 Handle for inexistent plane
[14:01:01] [PASSED] NV12 Handle for inexistent plane without DRM_MODE_FB_MODIFIERS
[14:01:01] [PASSED] YVU420 DRM_MODE_FB_MODIFIERS set without modifier
[14:01:01] [PASSED] YVU420 Normal sizes
[14:01:01] [PASSED] YVU420 Max sizes
[14:01:01] [PASSED] YVU420 Invalid pitch
[14:01:01] [PASSED] YVU420 Different pitches
[14:01:01] [PASSED] YVU420 Different buffer offsets/pitches
[14:01:01] [PASSED] YVU420 Modifier set just for plane 0, without DRM_MODE_FB_MODIFIERS
[14:01:01] [PASSED] YVU420 Modifier set just for planes 0, 1, without DRM_MODE_FB_MODIFIERS
[14:01:01] [PASSED] YVU420 Modifier set just for plane 0, 1, with DRM_MODE_FB_MODIFIERS
[14:01:01] [PASSED] YVU420 Valid modifier
[14:01:01] [PASSED] YVU420 Different modifiers per plane
[14:01:01] [PASSED] YVU420 Modifier for inexistent plane
[14:01:01] [PASSED] YUV420_10BIT Invalid modifier(DRM_FORMAT_MOD_LINEAR)
[14:01:01] [PASSED] X0L2 Normal sizes
[14:01:01] [PASSED] X0L2 Max sizes
[14:01:01] [PASSED] X0L2 Invalid pitch
[14:01:01] [PASSED] X0L2 Pitch greater than minimum required
[14:01:01] [PASSED] X0L2 Handle for inexistent plane
[14:01:01] [PASSED] X0L2 Offset for inexistent plane, without DRM_MODE_FB_MODIFIERS set
[14:01:01] [PASSED] X0L2 Modifier without DRM_MODE_FB_MODIFIERS set
[14:01:01] [PASSED] X0L2 Valid modifier
[14:01:01] [PASSED] X0L2 Modifier for inexistent plane
[14:01:01] =========== [PASSED] drm_test_framebuffer_create ===========
[14:01:01] [PASSED] drm_test_framebuffer_free
[14:01:01] [PASSED] drm_test_framebuffer_init
[14:01:01] [PASSED] drm_test_framebuffer_init_bad_format
[14:01:01] [PASSED] drm_test_framebuffer_init_dev_mismatch
[14:01:01] [PASSED] drm_test_framebuffer_lookup
[14:01:01] [PASSED] drm_test_framebuffer_lookup_inexistent
[14:01:01] [PASSED] drm_test_framebuffer_modifiers_not_supported
[14:01:01] ================= [PASSED] drm_framebuffer =================
[14:01:01] ================ drm_gem_shmem (8 subtests) ================
[14:01:01] [PASSED] drm_gem_shmem_test_obj_create
[14:01:01] [PASSED] drm_gem_shmem_test_obj_create_private
[14:01:01] [PASSED] drm_gem_shmem_test_pin_pages
[14:01:01] [PASSED] drm_gem_shmem_test_vmap
[14:01:01] [PASSED] drm_gem_shmem_test_get_pages_sgt
[14:01:01] [PASSED] drm_gem_shmem_test_get_sg_table
[14:01:01] [PASSED] drm_gem_shmem_test_madvise
[14:01:01] [PASSED] drm_gem_shmem_test_purge
[14:01:01] ================== [PASSED] drm_gem_shmem ==================
[14:01:01] === drm_atomic_helper_connector_hdmi_check (27 subtests) ===
[14:01:01] [PASSED] drm_test_check_broadcast_rgb_auto_cea_mode
[14:01:01] [PASSED] drm_test_check_broadcast_rgb_auto_cea_mode_vic_1
[14:01:01] [PASSED] drm_test_check_broadcast_rgb_full_cea_mode
[14:01:01] [PASSED] drm_test_check_broadcast_rgb_full_cea_mode_vic_1
[14:01:01] [PASSED] drm_test_check_broadcast_rgb_limited_cea_mode
[14:01:01] [PASSED] drm_test_check_broadcast_rgb_limited_cea_mode_vic_1
[14:01:01] ====== drm_test_check_broadcast_rgb_cea_mode_yuv420  =======
[14:01:01] [PASSED] Automatic
[14:01:01] [PASSED] Full
[14:01:01] [PASSED] Limited 16:235
[14:01:01] == [PASSED] drm_test_check_broadcast_rgb_cea_mode_yuv420 ===
[14:01:01] [PASSED] drm_test_check_broadcast_rgb_crtc_mode_changed
[14:01:01] [PASSED] drm_test_check_broadcast_rgb_crtc_mode_not_changed
[14:01:01] [PASSED] drm_test_check_disable_connector
[14:01:01] [PASSED] drm_test_check_hdmi_funcs_reject_rate
[14:01:01] [PASSED] drm_test_check_max_tmds_rate_bpc_fallback_rgb
[14:01:01] [PASSED] drm_test_check_max_tmds_rate_bpc_fallback_yuv420
[14:01:01] [PASSED] drm_test_check_max_tmds_rate_bpc_fallback_ignore_yuv422
[14:01:01] [PASSED] drm_test_check_max_tmds_rate_bpc_fallback_ignore_yuv420
[14:01:01] [PASSED] drm_test_check_driver_unsupported_fallback_yuv420
[14:01:01] [PASSED] drm_test_check_output_bpc_crtc_mode_changed
[14:01:01] [PASSED] drm_test_check_output_bpc_crtc_mode_not_changed
[14:01:01] [PASSED] drm_test_check_output_bpc_dvi
[14:01:01] [PASSED] drm_test_check_output_bpc_format_vic_1
[14:01:01] [PASSED] drm_test_check_output_bpc_format_display_8bpc_only
[14:01:01] [PASSED] drm_test_check_output_bpc_format_display_rgb_only
[14:01:01] [PASSED] drm_test_check_output_bpc_format_driver_8bpc_only
[14:01:01] [PASSED] drm_test_check_output_bpc_format_driver_rgb_only
[14:01:01] [PASSED] drm_test_check_tmds_char_rate_rgb_8bpc
[14:01:01] [PASSED] drm_test_check_tmds_char_rate_rgb_10bpc
[14:01:01] [PASSED] drm_test_check_tmds_char_rate_rgb_12bpc
[14:01:01] ===== [PASSED] drm_atomic_helper_connector_hdmi_check ======
[14:01:01] === drm_atomic_helper_connector_hdmi_reset (6 subtests) ====
[14:01:01] [PASSED] drm_test_check_broadcast_rgb_value
[14:01:01] [PASSED] drm_test_check_bpc_8_value
[14:01:01] [PASSED] drm_test_check_bpc_10_value
[14:01:01] [PASSED] drm_test_check_bpc_12_value
[14:01:01] [PASSED] drm_test_check_format_value
[14:01:01] [PASSED] drm_test_check_tmds_char_value
[14:01:01] ===== [PASSED] drm_atomic_helper_connector_hdmi_reset ======
[14:01:01] = drm_atomic_helper_connector_hdmi_mode_valid (4 subtests) =
[14:01:01] [PASSED] drm_test_check_mode_valid
[14:01:01] [PASSED] drm_test_check_mode_valid_reject
[14:01:01] [PASSED] drm_test_check_mode_valid_reject_rate
[14:01:01] [PASSED] drm_test_check_mode_valid_reject_max_clock
[14:01:01] === [PASSED] drm_atomic_helper_connector_hdmi_mode_valid ===
[14:01:01] ================= drm_managed (2 subtests) =================
[14:01:01] [PASSED] drm_test_managed_release_action
[14:01:01] [PASSED] drm_test_managed_run_action
[14:01:01] =================== [PASSED] drm_managed ===================
[14:01:01] =================== drm_mm (6 subtests) ====================
[14:01:01] [PASSED] drm_test_mm_init
[14:01:01] [PASSED] drm_test_mm_debug
[14:01:01] [PASSED] drm_test_mm_align32
[14:01:01] [PASSED] drm_test_mm_align64
[14:01:01] [PASSED] drm_test_mm_lowest
[14:01:01] [PASSED] drm_test_mm_highest
[14:01:01] ===================== [PASSED] drm_mm ======================
[14:01:01] ============= drm_modes_analog_tv (5 subtests) =============
[14:01:01] [PASSED] drm_test_modes_analog_tv_mono_576i
[14:01:01] [PASSED] drm_test_modes_analog_tv_ntsc_480i
[14:01:01] [PASSED] drm_test_modes_analog_tv_ntsc_480i_inlined
[14:01:01] [PASSED] drm_test_modes_analog_tv_pal_576i
[14:01:01] [PASSED] drm_test_modes_analog_tv_pal_576i_inlined
[14:01:01] =============== [PASSED] drm_modes_analog_tv ===============
[14:01:01] ============== drm_plane_helper (2 subtests) ===============
[14:01:01] =============== drm_test_check_plane_state  ================
[14:01:01] [PASSED] clipping_simple
[14:01:01] [PASSED] clipping_rotate_reflect
[14:01:01] [PASSED] positioning_simple
[14:01:01] [PASSED] upscaling
[14:01:01] [PASSED] downscaling
[14:01:01] [PASSED] rounding1
[14:01:01] [PASSED] rounding2
[14:01:01] [PASSED] rounding3
[14:01:01] [PASSED] rounding4
[14:01:01] =========== [PASSED] drm_test_check_plane_state ============
[14:01:01] =========== drm_test_check_invalid_plane_state  ============
[14:01:01] [PASSED] positioning_invalid
[14:01:01] [PASSED] upscaling_invalid
[14:01:01] [PASSED] downscaling_invalid
[14:01:01] ======= [PASSED] drm_test_check_invalid_plane_state ========
[14:01:01] ================ [PASSED] drm_plane_helper =================
[14:01:01] ====== drm_connector_helper_tv_get_modes (1 subtest) =======
[14:01:01] ====== drm_test_connector_helper_tv_get_modes_check  =======
[14:01:01] [PASSED] None
[14:01:01] [PASSED] PAL
[14:01:01] [PASSED] NTSC
[14:01:01] [PASSED] Both, NTSC Default
[14:01:01] [PASSED] Both, PAL Default
[14:01:01] [PASSED] Both, NTSC Default, with PAL on command-line
[14:01:01] [PASSED] Both, PAL Default, with NTSC on command-line
[14:01:01] == [PASSED] drm_test_connector_helper_tv_get_modes_check ===
[14:01:01] ======== [PASSED] drm_connector_helper_tv_get_modes ========
[14:01:01] ================== drm_rect (9 subtests) ===================
[14:01:01] [PASSED] drm_test_rect_clip_scaled_div_by_zero
[14:01:01] [PASSED] drm_test_rect_clip_scaled_not_clipped
[14:01:01] [PASSED] drm_test_rect_clip_scaled_clipped
[14:01:01] [PASSED] drm_test_rect_clip_scaled_signed_vs_unsigned
[14:01:01] ================= drm_test_rect_intersect  =================
[14:01:01] [PASSED] top-left x bottom-right: 2x2+1+1 x 2x2+0+0
[14:01:01] [PASSED] top-right x bottom-left: 2x2+0+0 x 2x2+1-1
[14:01:01] [PASSED] bottom-left x top-right: 2x2+1-1 x 2x2+0+0
[14:01:01] [PASSED] bottom-right x top-left: 2x2+0+0 x 2x2+1+1
[14:01:01] [PASSED] right x left: 2x1+0+0 x 3x1+1+0
[14:01:01] [PASSED] left x right: 3x1+1+0 x 2x1+0+0
[14:01:01] [PASSED] up x bottom: 1x2+0+0 x 1x3+0-1
[14:01:01] [PASSED] bottom x up: 1x3+0-1 x 1x2+0+0
[14:01:01] [PASSED] touching corner: 1x1+0+0 x 2x2+1+1
[14:01:01] [PASSED] touching side: 1x1+0+0 x 1x1+1+0
[14:01:01] [PASSED] equal rects: 2x2+0+0 x 2x2+0+0
[14:01:01] [PASSED] inside another: 2x2+0+0 x 1x1+1+1
[14:01:01] [PASSED] far away: 1x1+0+0 x 1x1+3+6
[14:01:01] [PASSED] points intersecting: 0x0+5+10 x 0x0+5+10
[14:01:01] [PASSED] points not intersecting: 0x0+0+0 x 0x0+5+10
[14:01:01] ============= [PASSED] drm_test_rect_intersect =============
[14:01:01] ================ drm_test_rect_calc_hscale  ================
[14:01:01] [PASSED] normal use
[14:01:01] [PASSED] out of max range
[14:01:01] [PASSED] out of min range
[14:01:01] [PASSED] zero dst
[14:01:01] [PASSED] negative src
[14:01:01] [PASSED] negative dst
[14:01:01] ============ [PASSED] drm_test_rect_calc_hscale ============
[14:01:01] ================ drm_test_rect_calc_vscale  ================
[14:01:01] [PASSED] normal use
stty: 'standard input': Inappropriate ioctl for device
[14:01:01] [PASSED] out of max range
[14:01:01] [PASSED] out of min range
[14:01:01] [PASSED] zero dst
[14:01:01] [PASSED] negative src
[14:01:01] [PASSED] negative dst
[14:01:01] ============ [PASSED] drm_test_rect_calc_vscale ============
[14:01:01] ================== drm_test_rect_rotate  ===================
[14:01:01] [PASSED] reflect-x
[14:01:01] [PASSED] reflect-y
[14:01:01] [PASSED] rotate-0
[14:01:01] [PASSED] rotate-90
[14:01:01] [PASSED] rotate-180
[14:01:01] [PASSED] rotate-270
[14:01:01] ============== [PASSED] drm_test_rect_rotate ===============
[14:01:01] ================ drm_test_rect_rotate_inv  =================
[14:01:01] [PASSED] reflect-x
[14:01:01] [PASSED] reflect-y
[14:01:01] [PASSED] rotate-0
[14:01:01] [PASSED] rotate-90
[14:01:01] [PASSED] rotate-180
[14:01:01] [PASSED] rotate-270
[14:01:01] ============ [PASSED] drm_test_rect_rotate_inv =============
[14:01:01] ==================== [PASSED] drm_rect =====================
[14:01:01] ============ drm_sysfb_modeset_test (1 subtest) ============
[14:01:01] ============ drm_test_sysfb_build_fourcc_list  =============
[14:01:01] [PASSED] no native formats
[14:01:01] [PASSED] XRGB8888 as native format
[14:01:01] [PASSED] remove duplicates
[14:01:01] [PASSED] convert alpha formats
[14:01:01] [PASSED] random formats
[14:01:01] ======== [PASSED] drm_test_sysfb_build_fourcc_list =========
[14:01:01] ============= [PASSED] drm_sysfb_modeset_test ==============
[14:01:01] ============================================================
[14:01:01] Testing complete. Ran 622 tests: passed: 622
[14:01:01] Elapsed time: 31.904s total, 1.643s configuring, 29.794s building, 0.409s running

+ /kernel/tools/testing/kunit/kunit.py run --kunitconfig /kernel/drivers/gpu/drm/ttm/tests/.kunitconfig
stty: 'standard input': Inappropriate ioctl for device
[14:01:01] Configuring KUnit Kernel ...
Regenerating .config ...
Populating config with:

$ make ARCH=um O=.kunit olddefconfig
[14:01:03] Building KUnit Kernel ...
Populating config with:
$ make ARCH=um O=.kunit olddefconfig
Building with:
$ make all compile_commands.json scripts_gdb ARCH=um O=.kunit --jobs=25
[14:01:12] Starting KUnit Kernel (1/1)...
[14:01:12] ============================================================
Running tests with:
$ .kunit/linux kunit.enable=1 mem=1G console=tty kunit_shutdown=halt
[14:01:12] ================= ttm_device (5 subtests) ==================
[14:01:12] [PASSED] ttm_device_init_basic
[14:01:12] [PASSED] ttm_device_init_multiple
[14:01:12] [PASSED] ttm_device_fini_basic
[14:01:12] [PASSED] ttm_device_init_no_vma_man
[14:01:12] ================== ttm_device_init_pools  ==================
[14:01:12] [PASSED] No DMA allocations, no DMA32 required
[14:01:12] [PASSED] DMA allocations, DMA32 required
[14:01:12] [PASSED] No DMA allocations, DMA32 required
[14:01:12] [PASSED] DMA allocations, no DMA32 required
[14:01:12] ============== [PASSED] ttm_device_init_pools ==============
[14:01:12] =================== [PASSED] ttm_device ====================
[14:01:12] ================== ttm_pool (8 subtests) ===================
[14:01:12] ================== ttm_pool_alloc_basic  ===================
[14:01:12] [PASSED] One page
[14:01:12] [PASSED] More than one page
[14:01:12] [PASSED] Above the allocation limit
[14:01:12] [PASSED] One page, with coherent DMA mappings enabled
[14:01:12] [PASSED] Above the allocation limit, with coherent DMA mappings enabled
[14:01:12] ============== [PASSED] ttm_pool_alloc_basic ===============
[14:01:12] ============== ttm_pool_alloc_basic_dma_addr  ==============
[14:01:12] [PASSED] One page
[14:01:12] [PASSED] More than one page
[14:01:12] [PASSED] Above the allocation limit
[14:01:12] [PASSED] One page, with coherent DMA mappings enabled
[14:01:12] [PASSED] Above the allocation limit, with coherent DMA mappings enabled
[14:01:12] ========== [PASSED] ttm_pool_alloc_basic_dma_addr ==========
[14:01:12] [PASSED] ttm_pool_alloc_order_caching_match
[14:01:12] [PASSED] ttm_pool_alloc_caching_mismatch
[14:01:12] [PASSED] ttm_pool_alloc_order_mismatch
[14:01:12] [PASSED] ttm_pool_free_dma_alloc
[14:01:12] [PASSED] ttm_pool_free_no_dma_alloc
[14:01:12] [PASSED] ttm_pool_fini_basic
[14:01:12] ==================== [PASSED] ttm_pool =====================
[14:01:12] ================ ttm_resource (8 subtests) =================
[14:01:12] ================= ttm_resource_init_basic  =================
[14:01:12] [PASSED] Init resource in TTM_PL_SYSTEM
[14:01:12] [PASSED] Init resource in TTM_PL_VRAM
[14:01:12] [PASSED] Init resource in a private placement
[14:01:12] [PASSED] Init resource in TTM_PL_SYSTEM, set placement flags
[14:01:12] ============= [PASSED] ttm_resource_init_basic =============
[14:01:12] [PASSED] ttm_resource_init_pinned
[14:01:12] [PASSED] ttm_resource_fini_basic
[14:01:12] [PASSED] ttm_resource_manager_init_basic
[14:01:12] [PASSED] ttm_resource_manager_usage_basic
[14:01:12] [PASSED] ttm_resource_manager_set_used_basic
[14:01:12] [PASSED] ttm_sys_man_alloc_basic
[14:01:12] [PASSED] ttm_sys_man_free_basic
[14:01:12] ================== [PASSED] ttm_resource ===================
[14:01:12] =================== ttm_tt (15 subtests) ===================
[14:01:12] ==================== ttm_tt_init_basic  ====================
[14:01:12] [PASSED] Page-aligned size
[14:01:12] [PASSED] Extra pages requested
[14:01:12] ================ [PASSED] ttm_tt_init_basic ================
[14:01:12] [PASSED] ttm_tt_init_misaligned
[14:01:12] [PASSED] ttm_tt_fini_basic
[14:01:12] [PASSED] ttm_tt_fini_sg
[14:01:12] [PASSED] ttm_tt_fini_shmem
[14:01:12] [PASSED] ttm_tt_create_basic
[14:01:12] [PASSED] ttm_tt_create_invalid_bo_type
[14:01:12] [PASSED] ttm_tt_create_ttm_exists
[14:01:12] [PASSED] ttm_tt_create_failed
[14:01:12] [PASSED] ttm_tt_destroy_basic
[14:01:12] [PASSED] ttm_tt_populate_null_ttm
[14:01:12] [PASSED] ttm_tt_populate_populated_ttm
[14:01:12] [PASSED] ttm_tt_unpopulate_basic
[14:01:12] [PASSED] ttm_tt_unpopulate_empty_ttm
[14:01:12] [PASSED] ttm_tt_swapin_basic
[14:01:12] ===================== [PASSED] ttm_tt ======================
[14:01:12] =================== ttm_bo (14 subtests) ===================
[14:01:12] =========== ttm_bo_reserve_optimistic_no_ticket  ===========
[14:01:12] [PASSED] Cannot be interrupted and sleeps
[14:01:12] [PASSED] Cannot be interrupted, locks straight away
[14:01:12] [PASSED] Can be interrupted, sleeps
[14:01:12] ======= [PASSED] ttm_bo_reserve_optimistic_no_ticket =======
[14:01:12] [PASSED] ttm_bo_reserve_locked_no_sleep
[14:01:12] [PASSED] ttm_bo_reserve_no_wait_ticket
[14:01:12] [PASSED] ttm_bo_reserve_double_resv
[14:01:12] [PASSED] ttm_bo_reserve_interrupted
[14:01:12] [PASSED] ttm_bo_reserve_deadlock
[14:01:12] [PASSED] ttm_bo_unreserve_basic
[14:01:12] [PASSED] ttm_bo_unreserve_pinned
[14:01:12] [PASSED] ttm_bo_unreserve_bulk
[14:01:12] [PASSED] ttm_bo_fini_basic
[14:01:13] [ERROR] Test: ttm_bo: missing expected subtest!
[14:01:13] 
[14:01:13] Pid: 223, comm: kworker/u5:0 Tainted: G        W        N  6.18.0-rc7-gac37ad1a19b9
[14:01:13] RIP: 0033:dma_fence_default_wait+0xbc/0x220
[14:01:13] RSP: 00000000c49c3df0  EFLAGS: 00010206
[14:01:13] RAX: 0000000084a42580 RBX: 7fffffffffffffff RCX: 00000000c49c3e00
[14:01:13] RDX: 00000000083d8480 RSI: 0000000000000000 RDI: 0000000000000000
[14:01:13] RBP: 7fffffffffffffff R08: 0000000084b436f8 R09: 0000000000000001
[14:01:13] R10: 0000000084b438b8 R11: fefefefefefefeff R12: 0000000060052ba0
[14:01:13] R13: 0000000000000001 R14: 0000000084b38100 R15: 0000000000000000
[14:01:13] Kernel panic - not syncing: Segfault with no mm
[14:01:13] [CRASHED] 
[14:01:13] [ERROR] Test: ttm_bo: missing expected subtest!
[14:01:13] [CRASHED] 
[14:01:13] [ERROR] Test: ttm_bo: missing expected subtest!
[14:01:13] [CRASHED] 
[14:01:13] [ERROR] Test: ttm_bo: missing expected subtest!
[14:01:13] [CRASHED] 
[14:01:13] [ERROR] Test: ttm_bo: missing subtest result line!
[14:01:13] # module: ttm_bo_test
[14:01:13] ===================== [CRASHED] ttm_bo =====================
[14:01:13] [ERROR] Test: main: missing expected subtest!
[14:01:13] [CRASHED] 
[14:01:13] ============================================================
[14:01:13] Testing complete. Ran 68 tests: passed: 63, crashed: 5, errors: 6
The kernel seems to have crashed; you can decode the stack traces with:
$ scripts/decode_stacktrace.sh .kunit/vmlinux .kunit < .kunit/test.log | tee .kunit/decoded.log | /kernel/tools/testing/kunit/kunit.py parse
[14:01:13] Elapsed time: 11.228s total, 1.658s configuring, 9.203s building, 0.367s running

+ cleanup
++ stat -c %u:%g /kernel
+ chown -R 1003:1003 /kernel

maintainer Reviewed-by on the v1 series
#28 lore raw
In reply to Philipp Stanner
Quoted 4 lines · Philipp Stanner

Barely anyone uses dma_fence_signal()'s (and similar functions') return code. Checking it is pretty much useless anyways, because what are you going to do if a fence was already signal it? Unsignal it and signal it again? ;p

Please push to drm-misc-next or leave me a note when I should pick it up.

Quoted 2 lines

Removing the return code simplifies the API and makes it easier for me to sit on top with Rust DmaFence.

BTW, I have an rb for embedding the lock and I'm now writing test cases.

When that is done you should be able to base the Rust DmaFence abstraction on that as well.

Regards,
Christian.

Quoted 17 lines

Philipp Stanner (6):
dma-buf/dma-fence: Add dma_fence_test_signaled_flag() amd/amdkfd: Ignore return code of dma_fence_signal() drm/gpu/xe: Ignore dma_fenc_signal() return code
dma-buf: Don't misuse dma_fence_signal()
drm/ttm: Remove return check of dma_fence_signal() dma-buf/dma-fence: Remove return code of signaling-functions

 drivers/dma-buf/dma-fence.c                   | 59 ++++++-------------
 drivers/dma-buf/st-dma-fence.c                |  7 +--
 drivers/gpu/drm/amd/amdkfd/kfd_process.c      |  5 +-
 .../gpu/drm/ttm/tests/ttm_bo_validate_test.c  |  3 +-
 drivers/gpu/drm/xe/xe_hw_fence.c              |  5 +-
 include/linux/dma-fence.h                     | 33 ++++++++---
 6 files changed, 53 insertions(+), 59 deletions(-)
#29 lore raw
Quoted 9 lines · Christian König
Quoted 4 lines · Philipp Stanner

Barely anyone uses dma_fence_signal()'s (and similar functions') return code. Checking it is pretty much useless anyways, because what are you going to do if a fence was already signal it? Unsignal it and signal it again? ;p

Please push to drm-misc-next or leave me a note when I should pick it up.

Thx! I can push it. Let's wait a while to see if some of the other folks have sth to say.

Quoted 7 lines
Quoted 3 lines

Removing the return code simplifies the API and makes it easier for me to sit on top with Rust DmaFence.

BTW, I have an rb for embedding the lock and I'm now writing test cases.

When that is done you should be able to base the Rust DmaFence abstraction on that as well.

Yeah, thank you, that will actually help since I was in the process of solving the same life time issues in Rust.

I will give your series a review ~tomorrow, too. Or should I wait for v4 with the tests?

P.

Quoted 22 lines

Regards,
Christian.

Quoted 17 lines

Philipp Stanner (6):
  dma-buf/dma-fence: Add dma_fence_test_signaled_flag() amd/amdkfd: Ignore return code of dma_fence_signal() drm/gpu/xe: Ignore dma_fenc_signal() return code
  dma-buf: Don't misuse dma_fence_signal()
  drm/ttm: Remove return check of dma_fence_signal() dma-buf/dma-fence: Remove return code of signaling-functions

 drivers/dma-buf/dma-fence.c                   | 59 ++++++------------- drivers/dma-buf/st-dma-fence.c                |  7 +-- drivers/gpu/drm/amd/amdkfd/kfd_process.c      |  5 +- .../gpu/drm/ttm/tests/ttm_bo_validate_test.c  |  3 +- drivers/gpu/drm/xe/xe_hw_fence.c              |  5 +- include/linux/dma-fence.h                     | 33 ++++++++---

 6 files changed, 53 insertions(+), 59 deletions(-)
maintainer
#30 lore raw
Quoted 7 lines · Philipp Stanner
Quoted 6 lines · Christian König
Quoted 4 lines · Philipp Stanner

Barely anyone uses dma_fence_signal()'s (and similar functions') return code. Checking it is pretty much useless anyways, because what are you going to do if a fence was already signal it? Unsignal it and signal it again? ;p

Quoted 7 lines
Quoted 3 lines

Please push to drm-misc-next or leave me a note when I should pick it up.

Thx! I can push it. Let's wait a while to see if some of the other folks have sth to say.

I think you have a small bug in patch #1 [1]. Also Intel's CI [2] is complaining, it would nice to figure that out too + get a clean(ish) run ahead of merging.

Matt

[1] https://patchwork.freedesktop.org/patch/690505/?series=158108&rev=1#comment_1268421
[2] https://patchwork.freedesktop.org/series/158108/

Quoted 39 lines
Quoted 7 lines
Quoted 3 lines

Removing the return code simplifies the API and makes it easier for me to sit on top with Rust DmaFence.

BTW, I have an rb for embedding the lock and I'm now writing test cases.

When that is done you should be able to base the Rust DmaFence abstraction on that as well.

Yeah, thank you, that will actually help since I was in the process of solving the same life time issues in Rust.

I will give your series a review ~tomorrow, too. Or should I wait for v4 with the tests?

P.

Quoted 22 lines

Regards,
Christian.

Quoted 17 lines

Philipp Stanner (6):
  dma-buf/dma-fence: Add dma_fence_test_signaled_flag() amd/amdkfd: Ignore return code of dma_fence_signal() drm/gpu/xe: Ignore dma_fenc_signal() return code
  dma-buf: Don't misuse dma_fence_signal()
  drm/ttm: Remove return check of dma_fence_signal() dma-buf/dma-fence: Remove return code of signaling-functions

 drivers/dma-buf/dma-fence.c                   | 59 ++++++------------- drivers/dma-buf/st-dma-fence.c                |  7 +-- drivers/gpu/drm/amd/amdkfd/kfd_process.c      |  5 +- .../gpu/drm/ttm/tests/ttm_bo_validate_test.c  |  3 +- drivers/gpu/drm/xe/xe_hw_fence.c              |  5 +- include/linux/dma-fence.h                     | 33 ++++++++---

 6 files changed, 53 insertions(+), 59 deletions(-)
#31 lore raw

✗ i915.CI.BAT: failure for dma-fence: Remove return code of dma_fence_signal() et al. (rev2)

In reply to Philipp Stanner
== Series Details ==

== Series Details ==

Series: dma-fence: Remove return code of dma_fence_signal() et al. (rev2)
URL : https://patchwork.freedesktop.org/series/158297/
State : failure

== Summary ==

CI Bug Log - changes from CI_DRM_17616 -> Patchwork_158297v2
====================================================

Summary
-------

**FAILURE**

Serious unknown changes coming with Patchwork_158297v2 absolutely need to be verified manually.

If you think the reported changes have nothing to do with the changes
introduced in Patchwork_158297v2, please notify your bug team ([email protected]) to allow them to document this new failure mode, which will reduce false positives in CI.

External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_158297v2/index.html

Participating hosts (44 -> 43)
------------------------------

Missing (1): fi-snb-2520m

Possible new issues
-------------------

Here are the unknown changes that may have been introduced in Patchwork_158297v2:

### IGT changes ###

#### Possible regressions ####

* igt@i915_module_load@load:
- fi-ilk-650: [PASS][1] -> [ABORT][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17616/fi-ilk-650/igt@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_158297v2/fi-ilk-650/igt@[email protected]
- bat-jsl-1: [PASS][3] -> [ABORT][4]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17616/bat-jsl-1/igt@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_158297v2/bat-jsl-1/igt@[email protected]
- fi-bsw-n3050: [PASS][5] -> [ABORT][6]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17616/fi-bsw-n3050/igt@[email protected]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_158297v2/fi-bsw-n3050/igt@[email protected]
- bat-adlp-6: [PASS][7] -> [ABORT][8]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17616/bat-adlp-6/igt@[email protected]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_158297v2/bat-adlp-6/igt@[email protected]
- bat-arlh-2: [PASS][9] -> [ABORT][10]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17616/bat-arlh-2/igt@[email protected]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_158297v2/bat-arlh-2/igt@[email protected]
- fi-rkl-11600: [PASS][11] -> [ABORT][12]
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17616/fi-rkl-11600/igt@[email protected]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_158297v2/fi-rkl-11600/igt@[email protected]
- fi-skl-6600u: [PASS][13] -> [ABORT][14]
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17616/fi-skl-6600u/igt@[email protected]
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_158297v2/fi-skl-6600u/igt@[email protected]
- bat-arlh-3: [PASS][15] -> [ABORT][16]
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17616/bat-arlh-3/igt@[email protected]
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_158297v2/bat-arlh-3/igt@[email protected]
- fi-pnv-d510: [PASS][17] -> [ABORT][18]
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17616/fi-pnv-d510/igt@[email protected]
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_158297v2/fi-pnv-d510/igt@[email protected]
- bat-dg1-7: [PASS][19] -> [ABORT][20]
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17616/bat-dg1-7/igt@[email protected]
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_158297v2/bat-dg1-7/igt@[email protected]
- bat-dg2-13: [PASS][21] -> [ABORT][22]
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17616/bat-dg2-13/igt@[email protected]
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_158297v2/bat-dg2-13/igt@[email protected]
- fi-glk-j4005: [PASS][23] -> [ABORT][24]
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17616/fi-glk-j4005/igt@[email protected]
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_158297v2/fi-glk-j4005/igt@[email protected]
- bat-adlp-9: [PASS][25] -> [ABORT][26]
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17616/bat-adlp-9/igt@[email protected]
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_158297v2/bat-adlp-9/igt@[email protected]
- bat-twl-2: [PASS][27] -> [ABORT][28]
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17616/bat-twl-2/igt@[email protected]
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_158297v2/bat-twl-2/igt@[email protected]
- bat-dg2-11: [PASS][29] -> [ABORT][30]
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17616/bat-dg2-11/igt@[email protected]
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_158297v2/bat-dg2-11/igt@[email protected]
- bat-rpls-4: [PASS][31] -> [ABORT][32]
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17616/bat-rpls-4/igt@[email protected]
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_158297v2/bat-rpls-4/igt@[email protected]
- fi-kbl-7567u: [PASS][33] -> [ABORT][34]
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17616/fi-kbl-7567u/igt@[email protected]
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_158297v2/fi-kbl-7567u/igt@[email protected]
- fi-cfl-8700k: [PASS][35] -> [ABORT][36]
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17616/fi-cfl-8700k/igt@[email protected]
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_158297v2/fi-cfl-8700k/igt@[email protected]
- bat-twl-1: [PASS][37] -> [ABORT][38]
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17616/bat-twl-1/igt@[email protected]
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_158297v2/bat-twl-1/igt@[email protected]
- fi-kbl-8809g: [PASS][39] -> [ABORT][40]
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17616/fi-kbl-8809g/igt@[email protected]
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_158297v2/fi-kbl-8809g/igt@[email protected]
- bat-jsl-5: [PASS][41] -> [ABORT][42]
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17616/bat-jsl-5/igt@[email protected]
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_158297v2/bat-jsl-5/igt@[email protected]
- bat-apl-1: [PASS][43] -> [ABORT][44]
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17616/bat-apl-1/igt@[email protected]
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_158297v2/bat-apl-1/igt@[email protected]
- bat-dg2-14: [PASS][45] -> [ABORT][46]
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17616/bat-dg2-14/igt@[email protected]
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_158297v2/bat-dg2-14/igt@[email protected]
- fi-elk-e7500: [PASS][47] -> [ABORT][48]
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17616/fi-elk-e7500/igt@[email protected]
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_158297v2/fi-elk-e7500/igt@[email protected]
- fi-bsw-nick: [PASS][49] -> [ABORT][50]
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17616/fi-bsw-nick/igt@[email protected]
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_158297v2/fi-bsw-nick/igt@[email protected]
- bat-kbl-2: [PASS][51] -> [ABORT][52]
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17616/bat-kbl-2/igt@[email protected]
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_158297v2/bat-kbl-2/igt@[email protected]
- bat-arls-5: [PASS][53] -> [ABORT][54]
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17616/bat-arls-5/igt@[email protected]
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_158297v2/bat-arls-5/igt@[email protected]
- bat-rplp-1: [PASS][55] -> [ABORT][56]
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17616/bat-rplp-1/igt@[email protected]
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_158297v2/bat-rplp-1/igt@[email protected]
- fi-tgl-1115g4: [PASS][57] -> [ABORT][58]
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17616/fi-tgl-1115g4/igt@[email protected]
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_158297v2/fi-tgl-1115g4/igt@[email protected]
- fi-cfl-guc: [PASS][59] -> [ABORT][60]
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17616/fi-cfl-guc/igt@[email protected]
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_158297v2/fi-cfl-guc/igt@[email protected]
- bat-mtlp-6: [PASS][61] -> [ABORT][62]
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17616/bat-mtlp-6/igt@[email protected]
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_158297v2/bat-mtlp-6/igt@[email protected]
- bat-mtlp-9: [PASS][63] -> [ABORT][64]
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17616/bat-mtlp-9/igt@[email protected]
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_158297v2/bat-mtlp-9/igt@[email protected]
- bat-arls-6: [PASS][65] -> [ABORT][66]
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17616/bat-arls-6/igt@[email protected]
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_158297v2/bat-arls-6/igt@[email protected]
- bat-dg2-9: [PASS][67] -> [ABORT][68]
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17616/bat-dg2-9/igt@[email protected]
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_158297v2/bat-dg2-9/igt@[email protected]
- fi-kbl-x1275: [PASS][69] -> [ABORT][70]
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17616/fi-kbl-x1275/igt@[email protected]
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_158297v2/fi-kbl-x1275/igt@[email protected]
- bat-adlp-11: [PASS][71] -> [ABORT][72]
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17616/bat-adlp-11/igt@[email protected]
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_158297v2/bat-adlp-11/igt@[email protected]
- fi-hsw-4770: [PASS][73] -> [ABORT][74]
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17616/fi-hsw-4770/igt@[email protected]
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_158297v2/fi-hsw-4770/igt@[email protected]
- fi-ivb-3770: [PASS][75] -> [ABORT][76]
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17616/fi-ivb-3770/igt@[email protected]
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_158297v2/fi-ivb-3770/igt@[email protected]
- bat-mtlp-8: [PASS][77] -> [ABORT][78]
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17616/bat-mtlp-8/igt@[email protected]
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_158297v2/bat-mtlp-8/igt@[email protected]
- bat-dg1-6: [PASS][79] -> [ABORT][80]
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17616/bat-dg1-6/igt@[email protected]
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_158297v2/bat-dg1-6/igt@[email protected]
- bat-dg2-8: [PASS][81] -> [ABORT][82]
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17616/bat-dg2-8/igt@[email protected]
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_158297v2/bat-dg2-8/igt@[email protected]
- fi-kbl-guc: [PASS][83] -> [ABORT][84]
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17616/fi-kbl-guc/igt@[email protected]
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_158297v2/fi-kbl-guc/igt@[email protected]
- bat-adls-6: [PASS][85] -> [ABORT][86]
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17616/bat-adls-6/igt@[email protected]
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_158297v2/bat-adls-6/igt@[email protected]

Build changes
-------------

* Linux: CI_DRM_17616 -> Patchwork_158297v2

CI-20190529: 20190529
CI_DRM_17616: b199e4bb77ebb447ce72d03bb2289b29713af7dd @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_8647: 8647
Patchwork_158297v2: b199e4bb77ebb447ce72d03bb2289b29713af7dd @ git://anongit.freedesktop.org/gfx-ci/linux

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_158297v2/index.html