media: atomisp: coding style: Move trailing statements to next line
Subsystems (4)
PATCH 1/1 media: atomisp: coding style: Move trailing statements to next line
Adhering to Linux kernel coding style guidelines (Chapter 3: Indentation).
--- drivers/staging/media/atomisp/pci/sh_css_params.c | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-)
drivers/staging/media/atomisp/pci/sh_css_params.c +6 -3
@@ -875,7 +875,8 @@ ia_css_process_kernel(struct ia_css_stream *stream,/* update the other buffers to the pipe specific copies */ for (stage = pipeline->stages; stage; stage = stage->next) { -if (!stage || !stage->binary)continue ; +if (!stage || !stage->binary) +continue ;process (pipeline->pipe_id, stage, params); } }
@@ -3045,7 +3046,8 @@ process_kernel_parameters(unsigned int pipe_id,/* Call parameter process functions for all kernels */ /* Skip SC, since that is called on a temp sc table */ for (param_id =0 ; param_id <IA_CSS_NUM_PARAMETER_IDS ; param_id++) { -if (param_id ==IA_CSS_SC_ID )continue ; +if (param_id ==IA_CSS_SC_ID ) +continue ;if (params->config_changed[param_id]) ia_css_kernel_process_param[param_id](pipe_id, stage, params); }
@@ -3600,7 +3602,8 @@ sh_css_params_write_to_ddr_internal( IA_CSS_PARAM_CLASS_PARAM, mem);size_t size = isp_data->size; -if (!size)continue ; +if (!size) +continue ; buff_realloced = reallocate_buffer(&ddr_map->isp_mem_param[stage_num][mem], &ddr_map_size->isp_mem_param[stage_num][mem], size,
Signature · 1 line
2.43.0
Quoted 1 line · Ayush Kumar
Adhering to Linux kernel coding style guidelines (Chapter 3: Indentation).
OK. Can be done more, but yeah...
Signature · 2 lines
With Best Regards, Andy Shevchenko
Greg KH
maintainerQuoted 6 lines · Ayush Kumar
Adhering to Linux kernel coding style guidelines (Chapter 3: Indentation).
Signed-off-by Ayush Kumar <[email protected]>--- drivers/staging/media/atomisp/pci/sh_css_params.c | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-)
Hi,
This is the friendly patch-bot of Greg Kroah-Hartman. You have sent him a patch that has triggered this response. He used to manually respond to these common problems, but in order to save his sanity (he kept writing the same thing over and over, yet to different people), I was created. Hopefully you will not take offence and will fix the problem in your patch and resubmit it so that it can be accepted into the Linux kernel tree.
You are receiving this message because of the following common error(s) as indicated below:
- You did not specify a description of why the patch is needed, or possibly, any description at all, in the email body. Please read the section entitled "The canonical patch format" in the kernel file, Documentation/process/submitting-patches.rst for what is needed in order to properly describe the change.
If you wish to discuss this problem further, or you have questions about how to resolve this issue, please feel free to respond to this email and Greg will reply once he has dug out from the pending patches received from other developers.
thanks,
greg k-h's patch email bot
Hi Ayush,
Thanks for the patch.
Quoted 3 lines · Ayush Kumar
Adhering to Linux kernel coding style guidelines (Chapter 3: Indentation).
Signed-off-by Ayush Kumar <[email protected]>
This has been addressed by commit 003c2c39ec77c84d704ee8effe170fd8658fde0b in my atomisp branch.
Signature · 3 lines
Kind regards, Sakari Ailus
Quoted 7 lines · Sakari Ailus
Quoted 3 lines · Ayush Kumar
Adhering to Linux kernel coding style guidelines (Chapter 3: Indentation).
Signed-off-by Ayush Kumar <[email protected]>This has been addressed by commit
003c2c39ec77c84d704ee8effe170fd8658fde0bin my atomisp branch.
Btw, can you rebase your branch and drop "staging" word from the Subject in all current patches?
Signature · 2 lines
With Best Regards, Andy Shevchenko
Moi,
Quoted 5 lines · Andy Shevchenko
Quoted 3 lines · Sakari Ailus
Quoted 2 lines · Ayush Kumar
Adhering to Linux kernel coding style guidelines (Chapter 3: Indentation).
Quoted 7 lines
Quoted 4 lines
Quoted 1 line
Signed-off-by Ayush Kumar <[email protected]>This has been addressed by commit
003c2c39ec77c84d704ee8effe170fd8658fde0bin my atomisp branch.Btw, can you rebase your branch and drop "staging" word from the Subject in all current patches?
Good question. The staging: prefix has been used in the past for atomisp patches and a lot of the rest appears to be doing that as well but definitely not all. I don't really have an opinion but we should do that consistently whichever is chosen.
Signature · 3 lines
Terveisin, Sakari Ailus
Quoted 10 lines · Sakari Ailus
Quoted 9 lines · Andy Shevchenko
Quoted 7 lines · Sakari Ailus
Quoted 3 lines · Ayush Kumar
Adhering to Linux kernel coding style guidelines (Chapter 3: Indentation).
Signed-off-by Ayush Kumar <[email protected]>This has been addressed by commit
003c2c39ec77c84d704ee8effe170fd8658fde0bin my atomisp branch.
Quoted 7 lines
Quoted 2 lines
Btw, can you rebase your branch and drop "staging" word from the Subject in all current patches?
Good question. The staging: prefix has been used in the past for atomisp patches and a lot of the rest appears to be doing that as well but definitely not all. I don't really have an opinion but we should do that consistently whichever is chosen.
I believe you were Cc'ed to the (private) email response from Hans where he explained why it should be dropped. Let me find if I still have it and bounce to you.
Signature · 2 lines
With Best Regards, Andy Shevchenko
Sakari Ailus
reviewerQuoted 14 lines · Andy Shevchenko
Quoted 13 lines · Sakari Ailus
Quoted 11 lines · Andy Shevchenko
Quoted 7 lines · Sakari Ailus
Quoted 3 lines · Ayush Kumar
Adhering to Linux kernel coding style guidelines (Chapter 3: Indentation).
Signed-off-by Ayush Kumar <[email protected]>This has been addressed by commit
003c2c39ec77c84d704ee8effe170fd8658fde0bin my atomisp branch.Btw, can you rebase your branch and drop "staging" word from the Subject in all current patches?
Quoted 8 lines
Quoted 4 lines
Good question. The staging: prefix has been used in the past for atomisp patches and a lot of the rest appears to be doing that as well but definitely not all. I don't really have an opinion but we should do that consistently whichever is chosen.
I believe you were Cc'ed to the (private) email response from Hans where he explained why it should be dropped. Let me find if I still have it and bounce to you.
AFAIU, those reasons haven't been applicable for a few years now.
Most patches to the staging tree have staging: prefix and "staging: media:
atomisp: " appears to be most common for atomisp based on a quick look.
Signature · 1 line
Sakari Ailus