Skip to contentSkip to conversation

ehci-zynq: variscite: tee: fix many typos struct device.

PATCH Applied [email protected] 4 participants 5 messages Nov 27, 2025

Subsystems (5)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ehci-zynq: variscite: tee: fix many typos struct device.

From: Chali Anis <[email protected]>

fix struct device_d to struct device.

---
 arch/arm/boards/variscite-som-mx7/board.c | 2 +-
 drivers/usb/host/ehci-zynq.c              | 2 +-
 include/linux/tee_drv.h                   | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)
arch/arm/boards/variscite-som-mx7/board.c +1 -1
index 005228d107af..8bce4ec8616d 100644
@@ -5,7 +5,7 @@
 #include <deep-probe.h>
 #include <mach/imx/bbu.h>
 
-static int var_som_mx7_probe(struct device_d *dev)
+static int var_som_mx7_probe(struct device *dev)
 {
 	imx7_bbu_internal_mmcboot_register_handler("eMMC", "/dev/mmc2", BBU_HANDLER_FLAG_DEFAULT);
 	return 0;
drivers/usb/host/ehci-zynq.c +1 -1
index 13b551d09156..b4b0e0f89100 100644
@@ -6,7 +6,7 @@
 #include <common.h>
 #include <linux/usb/ulpi.h>
 
-static int zynq_ehci_probe(struct device_d *dev)
+static int zynq_ehci_probe(struct device *dev)
 {
 	struct resource *res;
 	void __iomem *base;
include/linux/tee_drv.h +1 -1
index e2c1042debce..6a8e19459f47 100644
@@ -201,7 +201,7 @@ struct tee_shm {
 	struct list_head link;
 
 	int fd;
-	struct device_d dev;
+	struct device dev;
 	struct cdev cdev;
 	struct resource res;
 };
#1 lore raw

Am Mittwoch, dem 26.11.2025 um 23:54 -0500 schrieb [email protected]:

Quoted 3 lines

From: Chali Anis <[email protected]>

fix struct device_d to struct device.

It's not really a typo, as struct device was called struct device_d for a long time in barebox. You are fixing the last remnants of that. I'm not sure if it's a good idea to lump all those different sites into a single patch. At least the subject doesn't really make sense, as zynq, a board and tee are not one subsystem.

Also, now that you remove the last usages of the deprecated device_d you can also remove the
#define device_d device in driver.h

Regards,
Lucas

Quoted 48 lines
---
 arch/arm/boards/variscite-som-mx7/board.c | 2 +-
 drivers/usb/host/ehci-zynq.c              | 2 +-
 include/linux/tee_drv.h                   | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)
arch/arm/boards/variscite-som-mx7/board.c +1 -1
index 005228d107af..8bce4ec8616d 100644
@@ -5,7 +5,7 @@
 #include <deep-probe.h>
 #include <mach/imx/bbu.h>
 
-static int var_som_mx7_probe(struct device_d *dev)
+static int var_som_mx7_probe(struct device *dev)
 {
 	imx7_bbu_internal_mmcboot_register_handler("eMMC", "/dev/mmc2", BBU_HANDLER_FLAG_DEFAULT);
 	return 0;
drivers/usb/host/ehci-zynq.c +1 -1
index 13b551d09156..b4b0e0f89100 100644
@@ -6,7 +6,7 @@
 #include <common.h>
 #include <linux/usb/ulpi.h>
 
-static int zynq_ehci_probe(struct device_d *dev)
+static int zynq_ehci_probe(struct device *dev)
 {
 	struct resource *res;
 	void __iomem *base;
include/linux/tee_drv.h +1 -1
index e2c1042debce..6a8e19459f47 100644
@@ -201,7 +201,7 @@ struct tee_shm {
 	struct list_head link;
 
 	int fd;
-	struct device_d dev;
+	struct device dev;
 	struct cdev cdev;
 	struct resource res;
 };
#2 lore raw

Hi,

Quoted 11 lines · Lucas Stach

Am Mittwoch, dem 26.11.2025 um 23:54 -0500 schrieb [email protected]:

Quoted 3 lines

From: Chali Anis <[email protected]>

fix struct device_d to struct device.

It's not really a typo, as struct device was called struct device_d for a long time in barebox. You are fixing the last remnants of that. I'm not sure if it's a good idea to lump all those different sites into a single patch. At least the subject doesn't really make sense, as zynq, a board and tee are not one subsystem.

I use treewide: as prefix such minor patches that just do trivial stuff like renames. While at it, you could also rename driver_d to driver as well.

Quoted 3 lines

Also, now that you remove the last usages of the deprecated device_d you can also remove the
#define device_d device in driver.h

I would leave that in for out of tree board code to avoid the churn..

Cheers,
Ahmad

Quoted 55 lines

Regards,
Lucas

Quoted 48 lines
---
 arch/arm/boards/variscite-som-mx7/board.c | 2 +-
 drivers/usb/host/ehci-zynq.c              | 2 +-
 include/linux/tee_drv.h                   | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)
arch/arm/boards/variscite-som-mx7/board.c +1 -1
index 005228d107af..8bce4ec8616d 100644
@@ -5,7 +5,7 @@
 #include <deep-probe.h>
 #include <mach/imx/bbu.h>
 
-static int var_som_mx7_probe(struct device_d *dev)
+static int var_som_mx7_probe(struct device *dev)
 {
 	imx7_bbu_internal_mmcboot_register_handler("eMMC", "/dev/mmc2", BBU_HANDLER_FLAG_DEFAULT);
 	return 0;
drivers/usb/host/ehci-zynq.c +1 -1
index 13b551d09156..b4b0e0f89100 100644
@@ -6,7 +6,7 @@
 #include <common.h>
 #include <linux/usb/ulpi.h>
 
-static int zynq_ehci_probe(struct device_d *dev)
+static int zynq_ehci_probe(struct device *dev)
 {
 	struct resource *res;
 	void __iomem *base;
include/linux/tee_drv.h +1 -1
index e2c1042debce..6a8e19459f47 100644
@@ -201,7 +201,7 @@ struct tee_shm {
 	struct list_head link;
 
 	int fd;
-	struct device_d dev;
+	struct device dev;
 	struct cdev cdev;
 	struct resource res;
 };
Signature · 4 lines
Pengutronix e.K.                  |                             |
Steuerwalder Str. 21              | http://www.pengutronix.de/  |
31137 Hildesheim, Germany         | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686  | Fax:   +49-5121-206917-5555 |
#4 lore raw
In reply to [email protected]

Reworded while applying:

treewide: rename remnants of struct device_d

struct device_d has been renamed to struct device 3 years ago. Rename remnants of struct device_d to device. This was unnoticed so far as we have a #define device_d device in driver.h.

Sascha

Quoted 51 lines · On Wed, Nov 26, 2025 at 11:54:17PM -0500, [email protected] wrote:

From: Chali Anis <[email protected]>

fix struct device_d to struct device.

---
 arch/arm/boards/variscite-som-mx7/board.c | 2 +-
 drivers/usb/host/ehci-zynq.c              | 2 +-
 include/linux/tee_drv.h                   | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)
arch/arm/boards/variscite-som-mx7/board.c +1 -1
index 005228d107af..8bce4ec8616d 100644
@@ -5,7 +5,7 @@
 #include <deep-probe.h>
 #include <mach/imx/bbu.h>
 
-static int var_som_mx7_probe(struct device_d *dev)
+static int var_som_mx7_probe(struct device *dev)
 {
 	imx7_bbu_internal_mmcboot_register_handler("eMMC", "/dev/mmc2", BBU_HANDLER_FLAG_DEFAULT);
 	return 0;
drivers/usb/host/ehci-zynq.c +1 -1
index 13b551d09156..b4b0e0f89100 100644
@@ -6,7 +6,7 @@
 #include <common.h>
 #include <linux/usb/ulpi.h>
 
-static int zynq_ehci_probe(struct device_d *dev)
+static int zynq_ehci_probe(struct device *dev)
 {
 	struct resource *res;
 	void __iomem *base;
include/linux/tee_drv.h +1 -1
index e2c1042debce..6a8e19459f47 100644
@@ -201,7 +201,7 @@ struct tee_shm {
 	struct list_head link;
 
 	int fd;
-	struct device_d dev;
+	struct device dev;
 	struct cdev cdev;
 	struct resource res;
 };
Signature · 4 lines
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |