ehci-zynq: variscite: tee: fix many typos struct device.
Subsystems (5)
PATCH 1/1 ehci-zynq: variscite: tee: fix many typos struct device.
From: Chali Anis <[email protected]>
fix struct device_d to struct device.
--- arch/arm/boards/variscite-som-mx7/board.c | 2 +- drivers/usb/host/ehci-zynq.c | 2 +- include/linux/tee_drv.h | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-)
arch/arm/boards/variscite-som-mx7/board.c +1 -1
@@ -5,7 +5,7 @@#include <deep-probe.h> #include <mach/imx/bbu.h> -static int var_som_mx7_probe (struct device_d *dev) +static int var_som_mx7_probe (struct device *dev) {imx7_bbu_internal_mmcboot_register_handler ("eMMC" ,"/dev/mmc2" ,BBU_HANDLER_FLAG_DEFAULT );return 0 ;
drivers/usb/host/ehci-zynq.c +1 -1
@@ -6,7 +6,7 @@#include <common.h> #include <linux/usb/ulpi.h> -static int zynq_ehci_probe (struct device_d *dev) +static int zynq_ehci_probe (struct device *dev) {struct resource *res;void __iomem *base;
include/linux/tee_drv.h +1 -1
@@ -201,7 +201,7 @@ struct tee_shm {struct list_head link;int fd; -struct device_d dev; +struct device dev;struct cdev cdev;struct resource res; };
Am Mittwoch, dem 26.11.2025 um 23:54 -0500 schrieb [email protected]:
Quoted 3 lines
From: Chali Anis <[email protected]>
fix struct
device_dto struct device.
It's not really a typo, as struct device was called struct device_d for a long time in barebox. You are fixing the last remnants of that. I'm not sure if it's a good idea to lump all those different sites into a single patch. At least the subject doesn't really make sense, as zynq, a board and tee are not one subsystem.
Also, now that you remove the last usages of the deprecated device_d you can also remove the
#define device_d device in driver.h
Regards,
Lucas
Quoted 48 lines
Signed-off-by Chali Anis <[email protected]>--- arch/arm/boards/variscite-som-mx7/board.c | 2 +- drivers/usb/host/ehci-zynq.c | 2 +- include/linux/tee_drv.h | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-)arch/arm/boards/variscite-som-mx7/board.c +1
-1@@ -5,7 +5,7 @@#include <deep-probe.h> #include <mach/imx/bbu.h> -static int var_som_mx7_probe (struct device_d *dev) +static int var_som_mx7_probe (struct device *dev) {imx7_bbu_internal_mmcboot_register_handler ("eMMC" ,"/dev/mmc2" ,BBU_HANDLER_FLAG_DEFAULT );return 0 ;drivers/usb/host/ehci-zynq.c +1
-1@@ -6,7 +6,7 @@#include <common.h> #include <linux/usb/ulpi.h> -static int zynq_ehci_probe (struct device_d *dev) +static int zynq_ehci_probe (struct device *dev) {struct resource *res;void __iomem *base;include/linux/tee_drv.h +1
-1@@ -201,7 +201,7 @@ struct tee_shm {struct list_head link;int fd; -struct device_d dev; +struct device dev;struct cdev cdev;struct resource res; };
Hi,
Quoted 11 lines · Lucas Stach
Am Mittwoch, dem 26.11.2025 um 23:54 -0500 schrieb [email protected]:
Quoted 3 lines
From: Chali Anis <[email protected]>
fix struct
device_dto struct device.It's not really a typo, as struct device was called struct
device_dfor a long time in barebox. You are fixing the last remnants of that. I'm not sure if it's a good idea to lump all those different sites into a single patch. At least the subject doesn't really make sense, as zynq, a board and tee are not one subsystem.
I use treewide: as prefix such minor patches that just do trivial stuff like renames. While at it, you could also rename driver_d to driver as well.
Quoted 3 lines
Also, now that you remove the last usages of the deprecated
device_dyou can also remove the
#definedevice_ddevice indriver.h
I would leave that in for out of tree board code to avoid the churn..
Cheers,
Ahmad
Quoted 55 lines
Regards,
LucasQuoted 48 lines
Signed-off-by Chali Anis <[email protected]>--- arch/arm/boards/variscite-som-mx7/board.c | 2 +- drivers/usb/host/ehci-zynq.c | 2 +- include/linux/tee_drv.h | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-)arch/arm/boards/variscite-som-mx7/board.c +1
-1@@ -5,7 +5,7 @@#include <deep-probe.h> #include <mach/imx/bbu.h> -static int var_som_mx7_probe (struct device_d *dev) +static int var_som_mx7_probe (struct device *dev) {imx7_bbu_internal_mmcboot_register_handler ("eMMC" ,"/dev/mmc2" ,BBU_HANDLER_FLAG_DEFAULT );return 0 ;drivers/usb/host/ehci-zynq.c +1
-1@@ -6,7 +6,7 @@#include <common.h> #include <linux/usb/ulpi.h> -static int zynq_ehci_probe (struct device_d *dev) +static int zynq_ehci_probe (struct device *dev) {struct resource *res;void __iomem *base;include/linux/tee_drv.h +1
-1@@ -201,7 +201,7 @@ struct tee_shm {struct list_head link;int fd; -struct device_d dev; +struct device dev;struct cdev cdev;struct resource res; };
Signature · 4 lines
Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
Sascha Hauer
AppliedQuoted 3 lines · On Wed, 26 Nov 2025 23:54:17 -0500, [email protected] wrote:
fix struct
device_dto struct device.
Applied, thanks!
[1/1] ehci-zynq: variscite: tee: fix many typos struct device.
https://git.pengutronix.de/cgit/barebox/commit/?id=6816b9c4cdf6 (link may not be stable)
Best regards,
Signature · 1 line
Sascha Hauer <[email protected]>
Reworded while applying:
treewide: rename remnants of struct device_d
struct device_d has been renamed to struct device 3 years ago. Rename remnants of struct device_d to device. This was unnoticed so far as we have a #define device_d device in driver.h.
Sascha
Quoted 51 lines · On Wed, Nov 26, 2025 at 11:54:17PM -0500, [email protected] wrote:
From: Chali Anis <[email protected]>
fix struct
device_dto struct device.Signed-off-by Chali Anis <[email protected]>--- arch/arm/boards/variscite-som-mx7/board.c | 2 +- drivers/usb/host/ehci-zynq.c | 2 +- include/linux/tee_drv.h | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-)arch/arm/boards/variscite-som-mx7/board.c +1
-1@@ -5,7 +5,7 @@#include <deep-probe.h> #include <mach/imx/bbu.h> -static int var_som_mx7_probe (struct device_d *dev) +static int var_som_mx7_probe (struct device *dev) {imx7_bbu_internal_mmcboot_register_handler ("eMMC" ,"/dev/mmc2" ,BBU_HANDLER_FLAG_DEFAULT );return 0 ;drivers/usb/host/ehci-zynq.c +1
-1@@ -6,7 +6,7 @@#include <common.h> #include <linux/usb/ulpi.h> -static int zynq_ehci_probe (struct device_d *dev) +static int zynq_ehci_probe (struct device *dev) {struct resource *res;void __iomem *base;include/linux/tee_drv.h +1
-1@@ -201,7 +201,7 @@ struct tee_shm {struct list_head link;int fd; -struct device_d dev; +struct device dev;struct cdev cdev;struct resource res; };
Signature · 4 lines
Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |