kernel/liveupdate/luo_file.c:558 luo_retrieve_file() warn: iterator used outside loop: 'luo_file'
kernel test robot
build botBCC: [email protected]
CC: [email protected]
TO: Pasha Tatashin <[email protected]>
CC: Andrew Morton <[email protected]>
CC: Linux Memory Management List <[email protected]>
CC: "Mike Rapoport (Microsoft)" <[email protected]>
CC: Pratyush Yadav <[email protected]>
tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master head: ef68bf704646690aba5e81c2f7be8d6ef13d7ad8 commit: 3ee1d673194e5cb8955d700a6ac8e950a89cef13 [12119/12398] liveupdate: luo_file: implement file systems callbacks
:::::: branch date: 18 hours ago
:::::: commit date: 25 hours ago
config: x86_64-randconfig-161-20251127 (https://download.01.org/0day-ci/archive/20251128/[email protected]/config)
compiler: clang version 20.1.8 (https://github.com/llvm/llvm-project 87f0227cb60147a26a1eeb4fb06e3b505e9c7261)
If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <[email protected]> | Reported-by: Dan Carpenter <[email protected]> | Closes: https://lore.kernel.org/r/[email protected]/
smatch warnings:kernel/liveupdate/luo_file.c:558 luo_retrieve_file() warn: iterator used outside loop: 'luo_file'
vim +/luo_file +558 kernel/liveupdate/luo_file.c
3ee1d673194e5c Pasha Tatashin 2025-11-25 517
3ee1d673194e5c Pasha Tatashin 2025-11-25 518 /**
3ee1d673194e5c Pasha Tatashin 2025-11-25 519 * luo_retrieve_file - Restores a preserved file from a file_set by its token.
3ee1d673194e5c Pasha Tatashin 2025-11-25 520 * @file_set: The file_set from which to retrieve the file.
3ee1d673194e5c Pasha Tatashin 2025-11-25 521 * @token: The unique token identifying the file to be restored.
3ee1d673194e5c Pasha Tatashin 2025-11-25 522 * @filep: Output parameter; on success, this is populated with a pointer
3ee1d673194e5c Pasha Tatashin 2025-11-25 523 * to the newly retrieved 'struct file'.
3ee1d673194e5c Pasha Tatashin 2025-11-25 524 *
3ee1d673194e5c Pasha Tatashin 2025-11-25 525 * This function is the primary mechanism for recreating a file in the new
3ee1d673194e5c Pasha Tatashin 2025-11-25 526 * kernel after a live update. It searches the file_set's list of deserialized
3ee1d673194e5c Pasha Tatashin 2025-11-25 527 * files for an entry matching the provided @token.
3ee1d673194e5c Pasha Tatashin 2025-11-25 528 *
3ee1d673194e5c Pasha Tatashin 2025-11-25 529 * The operation is idempotent: if a file has already been successfully
3ee1d673194e5c Pasha Tatashin 2025-11-25 530 * retrieved, this function will simply return a pointer to the existing
3ee1d673194e5c Pasha Tatashin 2025-11-25 531 * 'struct file' and report success without re-executing the retrieve
3ee1d673194e5c Pasha Tatashin 2025-11-25 532 * operation. This is handled by checking the 'retrieved' flag under a lock.
3ee1d673194e5c Pasha Tatashin 2025-11-25 533 *
3ee1d673194e5c Pasha Tatashin 2025-11-25 534 * File retrieval can happen in any order; it is not bound by the order of
3ee1d673194e5c Pasha Tatashin 2025-11-25 535 * preservation.
3ee1d673194e5c Pasha Tatashin 2025-11-25 536 *
3ee1d673194e5c Pasha Tatashin 2025-11-25 537 * Context: Can be called from an ioctl or other in-kernel code in the new
3ee1d673194e5c Pasha Tatashin 2025-11-25 538 * kernel.
3ee1d673194e5c Pasha Tatashin 2025-11-25 539 * Return: 0 on success. Returns a negative errno on failure:
3ee1d673194e5c Pasha Tatashin 2025-11-25 540 * -ENOENT if no file with the matching token is found.
3ee1d673194e5c Pasha Tatashin 2025-11-25 541 * Any error code returned by the handler's .retrieve() op.
3ee1d673194e5c Pasha Tatashin 2025-11-25 542 */
3ee1d673194e5c Pasha Tatashin 2025-11-25 543 int luo_retrieve_file(struct luo_file_set *file_set, u64 token,
3ee1d673194e5c Pasha Tatashin 2025-11-25 544 struct file **filep)
3ee1d673194e5c Pasha Tatashin 2025-11-25 545 {
3ee1d673194e5c Pasha Tatashin 2025-11-25 546 struct liveupdate_file_op_args args = {0};
3ee1d673194e5c Pasha Tatashin 2025-11-25 547 struct luo_file *luo_file;
3ee1d673194e5c Pasha Tatashin 2025-11-25 548 int err;
3ee1d673194e5c Pasha Tatashin 2025-11-25 549
3ee1d673194e5c Pasha Tatashin 2025-11-25 550 if (list_empty(&file_set->files_list))
3ee1d673194e5c Pasha Tatashin 2025-11-25 551 return -ENOENT;
3ee1d673194e5c Pasha Tatashin 2025-11-25 552
3ee1d673194e5c Pasha Tatashin 2025-11-25 553 list_for_each_entry(luo_file, &file_set->files_list, list) {
3ee1d673194e5c Pasha Tatashin 2025-11-25 554 if (luo_file->token == token)
3ee1d673194e5c Pasha Tatashin 2025-11-25 555 break;
3ee1d673194e5c Pasha Tatashin 2025-11-25 556 }
3ee1d673194e5c Pasha Tatashin 2025-11-25 557
3ee1d673194e5c Pasha Tatashin 2025-11-25 @558 if (luo_file->token != token)
3ee1d673194e5c Pasha Tatashin 2025-11-25 559 return -ENOENT;
3ee1d673194e5c Pasha Tatashin 2025-11-25 560
3ee1d673194e5c Pasha Tatashin 2025-11-25 561 guard(mutex)(&luo_file->mutex);
3ee1d673194e5c Pasha Tatashin 2025-11-25 562 if (luo_file->retrieved) {
3ee1d673194e5c Pasha Tatashin 2025-11-25 563 /*
3ee1d673194e5c Pasha Tatashin 2025-11-25 564 * Someone is asking for this file again, so get a reference
3ee1d673194e5c Pasha Tatashin 2025-11-25 565 * for them.
3ee1d673194e5c Pasha Tatashin 2025-11-25 566 */
3ee1d673194e5c Pasha Tatashin 2025-11-25 567 get_file(luo_file->file);
3ee1d673194e5c Pasha Tatashin 2025-11-25 568 *filep = luo_file->file;
3ee1d673194e5c Pasha Tatashin 2025-11-25 569 return 0;
3ee1d673194e5c Pasha Tatashin 2025-11-25 570 }
3ee1d673194e5c Pasha Tatashin 2025-11-25 571
3ee1d673194e5c Pasha Tatashin 2025-11-25 572 args.handler = luo_file->fh;
3ee1d673194e5c Pasha Tatashin 2025-11-25 573 args.serialized_data = luo_file->serialized_data;
3ee1d673194e5c Pasha Tatashin 2025-11-25 574 err = luo_file->fh->ops->retrieve(&args);
3ee1d673194e5c Pasha Tatashin 2025-11-25 575 if (!err) {
3ee1d673194e5c Pasha Tatashin 2025-11-25 576 luo_file->file = args.file;
3ee1d673194e5c Pasha Tatashin 2025-11-25 577
3ee1d673194e5c Pasha Tatashin 2025-11-25 578 /* Get reference so we can keep this file in LUO until finish */
3ee1d673194e5c Pasha Tatashin 2025-11-25 579 get_file(luo_file->file);
3ee1d673194e5c Pasha Tatashin 2025-11-25 580 *filep = luo_file->file;
3ee1d673194e5c Pasha Tatashin 2025-11-25 581 luo_file->retrieved = true;
3ee1d673194e5c Pasha Tatashin 2025-11-25 582 }
3ee1d673194e5c Pasha Tatashin 2025-11-25 583
3ee1d673194e5c Pasha Tatashin 2025-11-25 584 return err;
3ee1d673194e5c Pasha Tatashin 2025-11-25 585 }
3ee1d673194e5c Pasha Tatashin 2025-11-25 586 Signature · 2 lines
0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki