Skip to contentSkip to conversation

thermal: broadcom: Use clamp() to simplify bcm2835_thermal_temp2adc()

PATCH Superseded Thorsten Blum 1 participant 1 message Dec 1, 2025

Subsystems (3)
Broadcom BCM2711/BCM2835 Arm architecture Thermal Broadcom BCM281XX/BCM11XXX/BCM216XX Arm architecture
lore
Share & tools
lore

Thorsten Blum

author
#0 lore raw

PATCH 1/1 thermal: broadcom: Use clamp() to simplify bcm2835_thermal_temp2adc()

Use clamp() to simplify bcm2835_thermal_temp2adc() and improve its readability. Explicitly cast BIT() to int to prevent a signedness error.

Signed-off-by Thorsten Blum <[email protected]>
---
 drivers/thermal/broadcom/bcm2835_thermal.c | 8 ++------
 1 file changed, 2 insertions(+), 6 deletions(-)
drivers/thermal/broadcom/bcm2835_thermal.c +2 -6
index 685a5aee5e0d..c5105dfc6ec9 100644
@@ -11,6 +11,7 @@
 #include <linux/err.h>
 #include <linux/io.h>
 #include <linux/kernel.h>
+#include <linux/minmax.h>
 #include <linux/module.h>
 #include <linux/of.h>
 #include <linux/of_address.h>

@@ -80,12 +81,7 @@ static int bcm2835_thermal_temp2adc(int temp, int offset, int slope)
 	temp -= offset;
 	temp /= slope;
 
-	if (temp < 0)
-		temp = 0;
-	if (temp >= BIT(BCM2835_TS_TSENSSTAT_DATA_BITS))
-		temp = BIT(BCM2835_TS_TSENSSTAT_DATA_BITS) - 1;
-
-	return temp;
+	return clamp(temp, 0, (int)BIT(BCM2835_TS_TSENSSTAT_DATA_BITS) - 1);
 }
 
 static int bcm2835_thermal_get_temp(struct thermal_zone_device *tz, int *temp)
Signature · 2 lines
Thorsten Blum <[email protected]>
GPG: 1D60 735E 8AEF 3BE4 73B6  9D84 7336 78FD 8DFE EAD4