platform: generic: Keep some empty space in FDT passed to next stage
PATCH v2 1/1 platform: generic: Keep some empty space in FDT passed to next stage
Leaving no empty space in the FDT passed to the next booting stage causes the following U-Boot crash on Ventana internal platforms:
Unhandled exception: Load access fault
EPC: 00000000fffa6372 RA: 00000000fffa7418 TVAL: 0001746174730068
EPC: 0000000080245372 RA: 0000000080246418 reloc adjusted
SP: 00000000fef38440 GP: 00000000fef40e60 TP: 0000000000000000 T0: 00000000fef40a70 T1: 000000000000ff00 T2: 0000000000000000 S0: 00000000fffc17a8 S1: 00000000fef38d40 A0: 7375746174730068 A1: 00000000fffc17a8 A2: 0000000000000010 A3: 0000000000000010 A4: 0000000000000000 A5: 00000000fffc17b8 A6: 0000000000ff0000 A7: 000000000000b100 S2: 0000000000000000 S3: 0000000000000001 S4: 00000000fef38d40 S5: 7375746174730068 S6: 0000000000000000 S7: 00000000fef4eef0 S8: 00000000fef4ef90 S9: 0000000000000000 S10: 0000000000000000 S11: 00000000fef4efc0 T3: 00000000fef40ea8 T4: 0000000000ff0000 T5: 00000000fef40a60 T6: 00000000fef40a6c
To address the above issue, keep some minimal empty space in the FDT instead of no empty space.
---
Changes since v1:
- Add Kconfig option for amount of empty space in FDT with default value as 4KB
--- platform/generic/Kconfig | 5 +++++ platform/generic/platform.c | 3 +++ 2 files changed, 8 insertions(+)
platform/generic/Kconfig +5 -0
@@ -23,6 +23,11 @@ config PLATFORM_GENERIC_MINOR_VER range 0 65535 default 1 +config PLATFORM_GENERIC_FDT_EMPTY_SPACE + int "Platform FDT empty space (KB)" + range 0 1024 + default 4 + config PLATFORM_ALLWINNER_D1 bool "Allwinner D1 support" depends on FDT_IRQCHIP_PLIC
platform/generic/platform.c +3 -0
@@ -245,7 +245,10 @@ int generic_final_init(bool cold_boot)fdt_fixups (fdt);fdt_domain_fixup (fdt); +/* Minimize the empty space in FDT to 4KB */ fdt_pack (fdt); +fdt_open_into (fdt, fdt,fdt_totalsize (fdt) + +CONFIG_PLATFORM_GENERIC_FDT_EMPTY_SPACE *1024 );return 0 ; }
Signature · 7 lines
2.43.0 -- opensbi mailing list [email protected] http://lists.infradead.org/mailman/listinfo/opensbi
Hi Anup,
Quoted 37 lines · Anup Patel
Leaving no empty space in the FDT passed to the next booting stage causes the following U-Boot crash on Ventana internal platforms:
Unhandled exception: Load access fault
EPC:00000000fffa6372RA:00000000fffa7418TVAL: 0001746174730068
EPC: 0000000080245372 RA: 0000000080246418 reloc adjustedSP: 00000000fef38440 GP: 00000000fef40e60 TP: 0000000000000000 T0: 00000000fef40a70 T1: 000000000000ff00 T2: 0000000000000000 S0: 00000000fffc17a8 S1: 00000000fef38d40 A0: 7375746174730068 A1: 00000000fffc17a8 A2: 0000000000000010 A3: 0000000000000010 A4: 0000000000000000 A5: 00000000fffc17b8 A6: 0000000000ff0000 A7: 000000000000b100 S2: 0000000000000000 S3: 0000000000000001 S4: 00000000fef38d40 S5: 7375746174730068 S6: 0000000000000000 S7: 00000000fef4eef0 S8: 00000000fef4ef90 S9: 0000000000000000 S10: 0000000000000000 S11: 00000000fef4efc0 T3: 00000000fef40ea8 T4: 0000000000ff0000 T5: 00000000fef40a60 T6: 00000000fef40a6cTo address the above issue, keep some minimal empty space in the FDT instead of no empty space.
Fixes bbe9a23060e9 ("platform: generic: Pack the FDT after applying fixups")Signed-off-by Anup Patel <[email protected]>---
Changes since v1:
- AddKconfigoption for amount of empty space in FDT with default value as 4KB--- platform/generic/Kconfig | 5 +++++ platform/generic/platform.c | 3 +++ 2 files changed, 8 insertions(+)platform/generic/Kconfig +0
-0
platform/generic/Kconfig config PLATFORM_GENERIC_MINOR_VER · line 29
Quoted 7 lines
platform/generic/Kconfig +4
-0@@ -23,6 +23,11 @@ config PLATFORM_GENERIC_MINOR_VER range 0 65535 default 1 +config PLATFORM_GENERIC_FDT_EMPTY_SPACE + int "Platform FDT empty space (KB)" + range 0 1024 + default 4
Since this is a workaround for a specific platform, and the workaround should eventually be obsoleted by a U-Boot fix, please default this to zero.
platform/generic/platform.c int generic_final_init(bool cold_boot) · line 248
Quoted 13 lines
platform/generic/Kconfig +1
-0+ config PLATFORM_ALLWINNER_D1 bool "Allwinner D1 support" depends on FDT_IRQCHIP_PLICplatform/generic/platform.c +1
-0@@ -245,7 +245,10 @@ int generic_final_init(bool cold_boot)fdt_fixups (fdt);fdt_domain_fixup (fdt); +/* Minimize the empty space in FDT to 4KB */
This comment is no longer accurate, since the padding is not a fixed size.
platform/generic/platform.c int generic_final_init(bool cold_boot) · line 251
Quoted 3 lines
platform/generic/platform.c +2
-0fdt_pack (fdt); +fdt_open_into (fdt, fdt,fdt_totalsize (fdt) + +CONFIG_PLATFORM_GENERIC_FDT_EMPTY_SPACE *1024 );
This change reintroduces the problem that motivated adding fdt_pack(). fdt_open_into() does not initialize the unused space, so once again the range [fdt, fdt + fdt_totalsize(fdt)) contains unitialized data.
If having unitialized data in the FDT blob is not a problem on the platform requiring this workaround, then I suppose the code is fine. Otherwise, this would need a memset().
Regards,
Samuel
Quoted 3 lines
platform/generic/platform.c +0
-0return 0 ; }
Signature · 3 lines
opensbi mailing list [email protected] http://lists.infradead.org/mailman/listinfo/opensbi
Quoted 44 lines · Samuel Holland
Hi Anup,
Quoted 40 lines · Anup Patel
Leaving no empty space in the FDT passed to the next booting stage causes the following U-Boot crash on Ventana internal platforms:
Unhandled exception: Load access fault
EPC:00000000fffa6372RA:00000000fffa7418TVAL: 0001746174730068
EPC: 0000000080245372 RA: 0000000080246418 reloc adjustedSP: 00000000fef38440 GP: 00000000fef40e60 TP: 0000000000000000 T0: 00000000fef40a70 T1: 000000000000ff00 T2: 0000000000000000 S0: 00000000fffc17a8 S1: 00000000fef38d40 A0: 7375746174730068 A1: 00000000fffc17a8 A2: 0000000000000010 A3: 0000000000000010 A4: 0000000000000000 A5: 00000000fffc17b8 A6: 0000000000ff0000 A7: 000000000000b100 S2: 0000000000000000 S3: 0000000000000001 S4: 00000000fef38d40 S5: 7375746174730068 S6: 0000000000000000 S7: 00000000fef4eef0 S8: 00000000fef4ef90 S9: 0000000000000000 S10: 0000000000000000 S11: 00000000fef4efc0 T3: 00000000fef40ea8 T4: 0000000000ff0000 T5: 00000000fef40a60 T6: 00000000fef40a6cTo address the above issue, keep some minimal empty space in the FDT instead of no empty space.
Fixes bbe9a23060e9 ("platform: generic: Pack the FDT after applying fixups")Signed-off-by Anup Patel <[email protected]>---
Changes since v1:
- AddKconfigoption for amount of empty space in FDT with default value as 4KB--- platform/generic/Kconfig | 5 +++++ platform/generic/platform.c | 3 +++ 2 files changed, 8 insertions(+)platform/generic/Kconfig +0
-0@@ -23,6 +23,11 @@ config PLATFORM_GENERIC_MINOR_VER range 0 65535 default 1
Quoted 7 lines
platform/generic/Kconfig config PLATFORM_GENERIC_MINOR_VER · line 29
Quoted 4 lines
platform/generic/Kconfig +4
-0+config PLATFORM_GENERIC_FDT_EMPTY_SPACE + int "Platform FDT empty space (KB)" + range 0 1024 + default 4Since this is a workaround for a specific platform, and the workaround should eventually be obsoleted by a U-Boot fix, please default this to zero.
Although the issue manifests on Ventana internal platforms, the issue is not Ventana specific and can happen on any platform where U-Boot tries to modify FDT passed by OpenSBI without adding extra space.
Quoted 13 lines
Quoted 13 lines
platform/generic/Kconfig +1
-0+ config PLATFORM_ALLWINNER_D1 bool "Allwinner D1 support" depends on FDT_IRQCHIP_PLICplatform/generic/platform.c +0
-0@@ -245,7 +245,10 @@ int generic_final_init(bool cold_boot)fdt_fixups (fdt);fdt_domain_fixup (fdt);
Quoted 3 lines
platform/generic/platform.c int generic_final_init(bool cold_boot) · line 248
Quoted 1 line
platform/generic/platform.c +1
-0+/* Minimize the empty space in FDT to 4KB */ This comment is no longer accurate, since the padding is not a fixed size.
Sure, I will update.
Quoted 5 lines
platform/generic/platform.c int generic_final_init(bool cold_boot) · line 251
Quoted 4 lines
platform/generic/platform.c +2
-0fdt_pack (fdt); +fdt_open_into (fdt, fdt,fdt_totalsize (fdt) + +CONFIG_PLATFORM_GENERIC_FDT_EMPTY_SPACE *1024 );
Quoted 7 lines
This change reintroduces the problem that motivated adding
fdt_pack().fdt_open_into()does not initialize the unused space, so once again the range [fdt, fdt +fdt_totalsize(fdt)) contains unitialized data.If having unitialized data in the FDT blob is not a problem on the platform requiring this workaround, then I suppose the code is fine. Otherwise, this would need a
memset().
I think it is better to do memset() on additional space in fdt_open_into() itself but that would be a separate change in libfdt.
Regards,
Anup
Signature · 3 lines
opensbi mailing list [email protected] http://lists.infradead.org/mailman/listinfo/opensbi
Hi Anup,
Quoted 50 lines · Anup Patel
Quoted 41 lines · Samuel Holland
Quoted 40 lines · Anup Patel
Leaving no empty space in the FDT passed to the next booting stage causes the following U-Boot crash on Ventana internal platforms:
Unhandled exception: Load access fault
EPC:00000000fffa6372RA:00000000fffa7418TVAL: 0001746174730068
EPC: 0000000080245372 RA: 0000000080246418 reloc adjustedSP: 00000000fef38440 GP: 00000000fef40e60 TP: 0000000000000000 T0: 00000000fef40a70 T1: 000000000000ff00 T2: 0000000000000000 S0: 00000000fffc17a8 S1: 00000000fef38d40 A0: 7375746174730068 A1: 00000000fffc17a8 A2: 0000000000000010 A3: 0000000000000010 A4: 0000000000000000 A5: 00000000fffc17b8 A6: 0000000000ff0000 A7: 000000000000b100 S2: 0000000000000000 S3: 0000000000000001 S4: 00000000fef38d40 S5: 7375746174730068 S6: 0000000000000000 S7: 00000000fef4eef0 S8: 00000000fef4ef90 S9: 0000000000000000 S10: 0000000000000000 S11: 00000000fef4efc0 T3: 00000000fef40ea8 T4: 0000000000ff0000 T5: 00000000fef40a60 T6: 00000000fef40a6cTo address the above issue, keep some minimal empty space in the FDT instead of no empty space.
Fixes bbe9a23060e9 ("platform: generic: Pack the FDT after applying fixups")Signed-off-by Anup Patel <[email protected]>---
Changes since v1:
- AddKconfigoption for amount of empty space in FDT with default value as 4KB--- platform/generic/Kconfig | 5 +++++ platform/generic/platform.c | 3 +++ 2 files changed, 8 insertions(+)platform/generic/Kconfig +0
-0@@ -23,6 +23,11 @@ config PLATFORM_GENERIC_MINOR_VER range 0 65535 default 1Quoted 7 lines
platform/generic/Kconfig config PLATFORM_GENERIC_MINOR_VER · line 29
Quoted 4 lines
platform/generic/Kconfig +4
-0+config PLATFORM_GENERIC_FDT_EMPTY_SPACE + int "Platform FDT empty space (KB)" + range 0 1024 + default 4Since this is a workaround for a specific platform, and the workaround should eventually be obsoleted by a U-Boot fix, please default this to zero.
Quoted 4 lines
Although the issue manifests on Ventana internal platforms, the issue is not Ventana specific and can happen on any platform where U-Boot tries to modify FDT passed by OpenSBI without adding extra space.
It's still a U-Boot bug, no? Is your plan to keep the workaround indefinitely?
Quoted 27 lines
Quoted 12 lines
Quoted 12 lines
platform/generic/Kconfig +1
-0+ config PLATFORM_ALLWINNER_D1 bool "Allwinner D1 support" depends on FDT_IRQCHIP_PLICplatform/generic/platform.c +0
-0@@ -245,7 +245,10 @@ int generic_final_init(bool cold_boot)fdt_fixups (fdt);fdt_domain_fixup (fdt);Quoted 3 lines
platform/generic/platform.c int generic_final_init(bool cold_boot) · line 248
Quoted 1 line
platform/generic/platform.c +1
-0+/* Minimize the empty space in FDT to 4KB */ This comment is no longer accurate, since the padding is not a fixed size.
Sure, I will update.
Quoted 9 lines
platform/generic/platform.c int generic_final_init(bool cold_boot) · line 251
Quoted 4 lines
platform/generic/platform.c +2
-0fdt_pack (fdt); +fdt_open_into (fdt, fdt,fdt_totalsize (fdt) + +CONFIG_PLATFORM_GENERIC_FDT_EMPTY_SPACE *1024 );This change reintroduces the problem that motivated adding
fdt_pack().fdt_open_into()does not initialize the unused space, so once again the range [fdt, fdt +fdt_totalsize(fdt)) contains unitialized data.
Quoted 6 lines
Quoted 3 lines
If having unitialized data in the FDT blob is not a problem on the platform requiring this workaround, then I suppose the code is fine. Otherwise, this would need a
memset().I think it is better to do
memset()on additional space infdt_open_into()itself but that would be a separate change in libfdt.
I don't have an opinion on whether it is better to change libfdt, but we need to add the memset() in at least one place to avoid regressing here.
Regards,
Samuel
Signature · 3 lines
opensbi mailing list [email protected] http://lists.infradead.org/mailman/listinfo/opensbi
Quoted 54 lines · Samuel Holland
Hi Anup,
Quoted 50 lines · Anup Patel
Quoted 48 lines · Samuel Holland
Quoted 37 lines · Anup Patel
Leaving no empty space in the FDT passed to the next booting stage causes the following U-Boot crash on Ventana internal platforms:
Unhandled exception: Load access fault
EPC:00000000fffa6372RA:00000000fffa7418TVAL: 0001746174730068
EPC: 0000000080245372 RA: 0000000080246418 reloc adjustedSP: 00000000fef38440 GP: 00000000fef40e60 TP: 0000000000000000 T0: 00000000fef40a70 T1: 000000000000ff00 T2: 0000000000000000 S0: 00000000fffc17a8 S1: 00000000fef38d40 A0: 7375746174730068 A1: 00000000fffc17a8 A2: 0000000000000010 A3: 0000000000000010 A4: 0000000000000000 A5: 00000000fffc17b8 A6: 0000000000ff0000 A7: 000000000000b100 S2: 0000000000000000 S3: 0000000000000001 S4: 00000000fef38d40 S5: 7375746174730068 S6: 0000000000000000 S7: 00000000fef4eef0 S8: 00000000fef4ef90 S9: 0000000000000000 S10: 0000000000000000 S11: 00000000fef4efc0 T3: 00000000fef40ea8 T4: 0000000000ff0000 T5: 00000000fef40a60 T6: 00000000fef40a6cTo address the above issue, keep some minimal empty space in the FDT instead of no empty space.
Fixes bbe9a23060e9 ("platform: generic: Pack the FDT after applying fixups")Signed-off-by Anup Patel <[email protected]>---
Changes since v1:
- AddKconfigoption for amount of empty space in FDT with default value as 4KB--- platform/generic/Kconfig | 5 +++++ platform/generic/platform.c | 3 +++ 2 files changed, 8 insertions(+)platform/generic/Kconfig +0
-0platform/generic/Kconfig config PLATFORM_GENERIC_MINOR_VER · line 29
Quoted 7 lines
platform/generic/Kconfig +4
-0@@ -23,6 +23,11 @@ config PLATFORM_GENERIC_MINOR_VER range 0 65535 default 1 +config PLATFORM_GENERIC_FDT_EMPTY_SPACE + int "Platform FDT empty space (KB)" + range 0 1024 + default 4Since this is a workaround for a specific platform, and the workaround should eventually be obsoleted by a U-Boot fix, please default this to zero.
Quoted 6 lines
Quoted 4 lines
Although the issue manifests on Ventana internal platforms, the issue is not Ventana specific and can happen on any platform where U-Boot tries to modify FDT passed by OpenSBI without adding extra space.
It's still a U-Boot bug, no? Is your plan to keep the workaround indefinitely?
It is certainly a U-Boot bug. We will keep the workaround for atleast 6 months (one OpenSBI release) after U-Boot has fixed it.
Quoted 32 lines
Quoted 32 lines
Quoted 13 lines
Quoted 13 lines
platform/generic/Kconfig +1
-0+ config PLATFORM_ALLWINNER_D1 bool "Allwinner D1 support" depends on FDT_IRQCHIP_PLICplatform/generic/platform.c +0
-0@@ -245,7 +245,10 @@ int generic_final_init(bool cold_boot)fdt_fixups (fdt);fdt_domain_fixup (fdt);Quoted 3 lines
platform/generic/platform.c int generic_final_init(bool cold_boot) · line 248
Quoted 1 line
platform/generic/platform.c +1
-0+/* Minimize the empty space in FDT to 4KB */ This comment is no longer accurate, since the padding is not a fixed size.
Sure, I will update.
Quoted 12 lines
platform/generic/platform.c int generic_final_init(bool cold_boot) · line 251
Quoted 4 lines
platform/generic/platform.c +2
-0fdt_pack (fdt); +fdt_open_into (fdt, fdt,fdt_totalsize (fdt) + +CONFIG_PLATFORM_GENERIC_FDT_EMPTY_SPACE *1024 );This change reintroduces the problem that motivated adding
fdt_pack().fdt_open_into()does not initialize the unused space, so once again the range [fdt, fdt +fdt_totalsize(fdt)) contains unitialized data.If having unitialized data in the FDT blob is not a problem on the platform requiring this workaround, then I suppose the code is fine. Otherwise, this would need a
memset().
Quoted 6 lines
Quoted 2 lines
I think it is better to do
memset()on additional space infdt_open_into()itself but that would be a separate change in libfdt.I don't have an opinion on whether it is better to change libfdt, but we need to add the
memset()in at least one place to avoid regressing here.
Understood. My suggestion is to do it as a separate patch irrespective of where we do it.
Regards,
Anup
Signature · 3 lines
opensbi mailing list [email protected] http://lists.infradead.org/mailman/listinfo/opensbi