Skip to contentSkip to conversation

ALSA: rawmidi: Fix inconsistent indenting warning reported by smatch

PATCH In review [email protected] 2 participants 2 messages Dec 1, 2025 Sound

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 ALSA: rawmidi: Fix inconsistent indenting warning reported by smatch

From: HariKrishna Sagala <[email protected]>

Fix smatch reported inconsistent indenting warning in rawmidi. sound/core/rawmidi.c:2115 alsa_rawmidi_init() warn: inconsistent indenting.
No functional changes were introduced.

---
This patch fixes the below smatch reported warning sound/core/rawmidi.c:2115 alsa_rawmidi_init() warn: inconsistent indenting.
Re-ran the smatch to confirm warning is cleared and no functional changes were introduced.

Thank you Takashi Iwai for quick feedback.
v2:
corrected review comments from Takashi Iwai.
v1:
https://lore.kernel.org/all/[email protected]/

Thank you.

 sound/core/rawmidi.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)
sound/core/rawmidi.c +1 -4
index 20d36a346cca..8969ee2757f1 100644
@@ -2106,13 +2106,11 @@ EXPORT_SYMBOL(snd_rawmidi_set_ops);
 
 static int __init alsa_rawmidi_init(void)
 {
-
 	snd_ctl_register_ioctl(snd_rawmidi_control_ioctl);
 	snd_ctl_register_ioctl_compat(snd_rawmidi_control_ioctl);
 #ifdef CONFIG_SND_OSSEMUL
-	{ int i;
 	/* check device map table */
-	for (i = 0; i < SNDRV_CARDS; i++) {
+	for (int i = 0; i < SNDRV_CARDS; i++) {
 		if (midi_map[i] < 0 || midi_map[i] >= SNDRV_RAWMIDI_DEVICES) {
 			pr_err("ALSA: rawmidi: invalid midi_map[%d] = %d\n",
 			       i, midi_map[i]);
@@ -2124,7 +2122,6 @@ static int __init alsa_rawmidi_init(void)
 			amidi_map[i] = 1;
 		}
 	}
-	}
 #endif /* CONFIG_SND_OSSEMUL */
 	return 0;
 }

base-commit: 7d0a66e4bb9081d75c82ec4957c50034cb0ea449

Signature · 1 line
2.43.0