Skip to contentSkip to conversation

lib_package.bbclass: Use += to add to PACKAGE_BEFORE_PN

PATCH New Peter Kjellerstedt 1 participant 1 message Dec 3, 2025

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 lib_package.bbclass: Use += to add to PACKAGE_BEFORE_PN

The bash-completion bbclass recently started to use PACKAGE_BEFORE_PN to add the ${PN}-bash-completion package. This meant that a recipe, e.g., proj in meta-oe, that inherits both bash-completion and lib_package would fail since lib_package set PACKAGE_BEFORE_PN rather than added to it.

---

Now, I have used += rather than :append here because I know RP's stance on :append, and it also matches what bash-completion.bbclass does. However, the comment seen below, indicates that ${PN}-bin is expected to be after all other packages that want something from /usr/bin, i.e., last in PACKAGE_BEFORE_PN. Using :append would make it behave closer to that (though not guarantee it).

 meta/classes-recipe/lib_package.bbclass | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta/classes-recipe/lib_package.bbclass +1 -1
index 6d110155e5..2a944268c8 100644
@@ -9,4 +9,4 @@
 # We need to allow the other packages to be greedy with what they
 # want out of /usr/bin and /usr/sbin before ${PN}-bin gets greedy.
 # 
-PACKAGE_BEFORE_PN = "${PN}-bin"
+PACKAGE_BEFORE_PN += "${PN}-bin"