spi: cadence-qspi: Remove redundant pm_runtime_mark_last_busy call
PATCH 1/1 spi: cadence-qspi: Remove redundant pm_runtime_mark_last_busy call
The pm_runtime_mark_last_busy() call is redundant in probe function as pm_runtime_put_autosuspend() already calls pm_runtime_mark_last_busy() internally to update the last access time of the device before queuing autosuspend.
Remove the pm_runtime_mark_last_busy() call from the probe function.
Tested on StarFive VisionFive 2 v1.2A board.
--- drivers/spi/spi-cadence-quadspi.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)
drivers/spi/spi-cadence-quadspi.c +1 -3
@@ -2011,10 +2011,8 @@ static int cqspi_probe(struct platform_device *pdev) goto probe_setup_failed; } -if (!(ddata && (ddata->quirks &CQSPI_DISABLE_RUNTIME_PM ))) { -pm_runtime_mark_last_busy (dev); +if (!(ddata && (ddata->quirks &CQSPI_DISABLE_RUNTIME_PM )))pm_runtime_put_autosuspend (dev); - }return 0 ; probe_setup_failed:
Signature · 1 line
2.34.1
Mark Brown
maintainerQuoted 8 lines · Akif Ejaz
The
pm_runtime_mark_last_busy()call is redundant in probe function aspm_runtime_put_autosuspend()already callspm_runtime_mark_last_busy()internally to update the last access time of the device before queuing autosuspend.Remove the
pm_runtime_mark_last_busy()call from the probe function.[...]
Applied to
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next
Thanks!
[1/1] spi: cadence-qspi: Remove redundant pm_runtime_mark_last_busy call
commit: 28d21dfcea0121afec04451733a6c553fd319c8e
All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying to this mail.
Thanks,
Mark