Skip to contentSkip to conversation

ASoC: cros_ec_codec: Remove unnecessary selection of CRYPTO

PATCH In review Eric Biggers 2 participants 2 messages Dec 4, 2025

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ASoC: cros_ec_codec: Remove unnecessary selection of CRYPTO

The only crypto-related functionality this codec uses is the sha256() function, which is provided by CRYPTO_LIB_SHA256. Originally CRYPTO_LIB_SHA256 was visible only when CRYPTO; however, that was fixed years ago and the libraries can now be selected on their own.

So, remove the unnecessary selection of CRYPTO.

---
 sound/soc/codecs/Kconfig | 1 -
 1 file changed, 1 deletion(-)
sound/soc/codecs/Kconfig +0 -1
index 6087ebde9523..a34a68d12668 100644
@@ -775,11 +775,10 @@ config SND_SOC_CQ0093VC
 	tristate
 
 config SND_SOC_CROS_EC_CODEC
 	tristate "codec driver for ChromeOS EC"
 	depends on CROS_EC
-	select CRYPTO
 	select CRYPTO_LIB_SHA256
 	help
 	  If you say yes here you will get support for the
 	  ChromeOS Embedded Controller's Audio Codec.
 

base-commit: b2c27842ba853508b0da00187a7508eb3a96c8f7

Signature · 1 line
2.52.0
maintainer
#1 lore raw
Quoted 8 lines · Eric Biggers

The only crypto-related functionality this codec uses is the sha256() function, which is provided by CRYPTO_LIB_SHA256. Originally CRYPTO_LIB_SHA256 was visible only when CRYPTO; however, that was fixed years ago and the libraries can now be selected on their own.

So, remove the unnecessary selection of CRYPTO.

[...]

Applied to

https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/1] ASoC: cros_ec_codec: Remove unnecessary selection of CRYPTO

      commit: 8fb817335ad8d960ea05af3882cea113e59cb4e1

All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying to this mail.

Thanks,
Mark