ASoC: tegra: Fix uninitialized flat cache warning in tegra210_ahub
Subsystems (3)
PATCH 1/1 ASoC: tegra: Fix uninitialized flat cache warning in tegra210_ahub
From: sheetal <[email protected]>
The tegra210_ahub driver started triggering a warning after commit e062bdfdd6ad ("regmap: warn users about uninitialized flat cache"), which flags drivers using REGCACHE_FLAT without register defaults. Since the driver omits default definitions because its registers are zero initialized, the following warning is shown:
WARNING KERN tegra210-ahub 2900800.ahub: using zero-initialized flat cache, this may cause unexpected behavior
Switch to REGCACHE_FLAT_S which is the recommended cache type for sparse register maps without defaults. This cache type initializes entries on-demand from hardware, eliminating the warning while using memory efficiently.
--- sound/soc/tegra/tegra210_ahub.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
sound/soc/tegra/tegra210_ahub.c +3 -3
@@ -2077,7 +2077,7 @@ static const struct regmap_config tegra210_ahub_regmap_config = { .val_bits = 32, .reg_stride = 4, .max_register = TEGRA210_MAX_REGISTER_ADDR, - .cache_type = REGCACHE_FLAT, + .cache_type = REGCACHE_FLAT_S, };static const struct regmap_config tegra186_ahub_regmap_config = {
@@ -2085,7 +2085,7 @@ static const struct regmap_config tegra186_ahub_regmap_config = { .val_bits = 32, .reg_stride = 4, .max_register = TEGRA186_MAX_REGISTER_ADDR, - .cache_type = REGCACHE_FLAT, + .cache_type = REGCACHE_FLAT_S, };static const struct regmap_config tegra264_ahub_regmap_config = {
@@ -2094,7 +2094,7 @@ static const struct regmap_config tegra264_ahub_regmap_config = { .reg_stride = 4, .writeable_reg = tegra264_ahub_wr_reg, .max_register = TEGRA264_MAX_REGISTER_ADDR, - .cache_type = REGCACHE_FLAT, + .cache_type = REGCACHE_FLAT_S, };static const struct tegra_ahub_soc_data soc_data_tegra210 = {
Signature · 1 line
2.34.1
Hi,
Quoted 11 lines · Sheetal .
From: sheetal <[email protected]>
The
tegra210_ahubdriver started triggering a warning after commite062bdfdd6ad("regmap: warn users about uninitialized flat cache"), which flags drivers usingREGCACHE_FLATwithout register defaults. Since the driver omits default definitions because its registers are zero initialized, the following warning is shown:WARNING KERN tegra210-ahub 2900800.ahub: using zero-initialized flat cache, this may cause unexpected behavior
Quoted 6 lines
Switch to
REGCACHE_FLAT_Swhich is the recommended cache type for sparse register maps without defaults. This cache type initializes entries on-demand from hardware, eliminating the warning while using memory efficiently.Fixes e062bdfdd6ad ("regmap: warn users about uninitialized flat cache")
I disagree with this tag. The commit is working as intended by giving a warning.
This device's reset state happens to match the zero-initialization of the flat cache, so there were no issues here. An earlier version of this sparse flat cache indicated a potential problem with another driver, so there are likely drivers out there that do need fixing:
https://lore.kernel.org/all/[email protected]/
Regardless, this patch could still be material for 6.19 to avoid unneeded warnings, but that's up to Mark.
Best,
Sander
Mark Brown
maintainerQuoted 8 lines · Sander Vanheule
Quoted 6 lines · Sheetal .
The
tegra210_ahubdriver started triggering a warning after commite062bdfdd6ad("regmap: warn users about uninitialized flat cache"), which flags drivers usingREGCACHE_FLATwithout register defaults. Since the driver omits default definitions because its registers are zero initialized, the following warning is shown:
Quoted 7 lines
Quoted 7 lines
WARNING KERN tegra210-ahub 2900800.ahub: using zero-initialized flat cache, this may cause unexpected behavior
Switch to
REGCACHE_FLAT_Swhich is the recommended cache type for sparse register maps without defaults. This cache type initializes entries on-demand from hardware, eliminating the warning while using memory efficiently.
Like Sander says we can't just do this without checking that the driver isn't relying on the fact that the cache ends up defaulting to zero initialisation, that's the whole reason there are two separate cache types here.
Quoted 3 lines
Quoted 1 line
Fixes e062bdfdd6ad ("regmap: warn users about uninitialized flat cache")I disagree with this tag. The commit is working as intended by giving a warning.
Yes.
Quoted 4 lines
This device's reset state happens to match the zero-initialization of the flat cache, so there were no issues here. An earlier version of this sparse flat cache indicated a potential problem with another driver, so there are likely drivers out there that do need fixing:
The driver could also just provide the defaults FWIW but there's likely to be little practical difference.
Mark Brown
maintainerQuoted 9 lines · Sheetal .
The
tegra210_ahubdriver started triggering a warning after commite062bdfdd6ad("regmap: warn users about uninitialized flat cache"), which flags drivers usingREGCACHE_FLATwithout register defaults. Since the driver omits default definitions because its registers are zero initialized, the following warning is shown:WARNING KERN tegra210-ahub 2900800.ahub: using zero-initialized flat cache, this may cause unexpected behavior
[...]
Applied to
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next
Thanks!
[1/1] ASoC: tegra: Fix uninitialized flat cache warning in tegra210_ahub
commit: 4d4021b0bbd1fad7c72b9155863f5b3ccb43ae91
All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying to this mail.
Thanks,
Mark
Hi Mark,
This patch is causing issues with the tegra AHUB driver. Could you please drop it, or should I send a revert?
Thanks,
Sheetal
Quoted 42 lines · Mark Brown
External email: Use caution opening links or attachments
Quoted 9 lines · Sheetal .
The
tegra210_ahubdriver started triggering a warning after commite062bdfdd6ad("regmap: warn users about uninitialized flat cache"), which flags drivers usingREGCACHE_FLATwithout register defaults. Since the driver omits default definitions because its registers are zero initialized, the following warning is shown:WARNING KERN tegra210-ahub 2900800.ahub: using zero-initialized flat cache, this may cause unexpected behavior
[...]
Applied to
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next
Thanks!
[1/1] ASoC: tegra: Fix uninitialized flat cache warning in
tegra210_ahubcommit: 4d4021b0bbd1fad7c72b9155863f5b3ccb43ae91All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying to this mail.
Thanks,
Mark
Mark Brown
maintainerOn Tue, Dec 16, 2025 at 04:06:53PM +0530, Sheetal . wrote:
Please don't top post, reply in line with needed context. This allows readers to readily follow the flow of conversation and understand what you are talking about and also helps ensure that everything in the discussion is being addressed.
Quoted 2 lines
This patch is causing issues with the tegra AHUB driver. Could you please drop it, or should I send a revert?
As covered in the mail you are replying to:
Quoted 3 lines
Quoted 3 lines
If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.