Skip to contentSkip to conversation

remoteproc/qcom,q6v5: introduce IPQ9574

RFC PATCH In review Alexandru Gagniuc 4 participants 11 messages Dec 10, 2025 – Dec 21, 2025

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

cover remoteproc/qcom,q6v5: introduce IPQ9574

I want to enable ath11k on IPQ9574 SoCs, which uses the qcom remoteproc for communication with firmware. It is similar to qcom,ipq8074-wcss-pil, and I think it makes sense to extend the IP8074 path. The existing bidings are not yaml. Am I required to convert the bindings to DT schema before updating them?

Whom do I add as the maintainer for the YAML binding? Do I add my name? Do I need to find an existing maintainer who is willing to use their name?

I would like to add the remoteproc node to IPQ8074. One of the resets is missing from "qcom,gcc-ipq8074.h". Can I use a placeholder value with a comment? Am I expected to enable the reset in code before adding the devicetree node?

Alex
---
Alexandru Gagniuc (3):
dt-bindings: remoteproc: qcom,ipq8074-wcss-pil: convert to DT schema
dt-bindings: remoteproc: qcom: add IPQ9574 image loader
arm64: dts: qcom: ipq8074: add remoteproc nodes

 .../remoteproc/qcom,ipq9574-wcss-pil.yaml     | 269 ++++++++++++++++++
 .../bindings/remoteproc/qcom,q6v5.txt         | 102 -------
 arch/arm64/boot/dts/qcom/ipq8074.dtsi         |  79 +++++
 3 files changed, 348 insertions(+), 102 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/remoteproc/qcom,ipq9574-wcss-pil.yaml
 delete mode 100644 Documentation/devicetree/bindings/remoteproc/qcom,q6v5.txt
Signature · 1 line
2.45.1
#1 lore raw

RFC PATCH 1/3 dt-bindings: remoteproc: qcom,ipq8074-wcss-pil: convert to DT schema

Convert the QCS404 and IPQ WCSS Peripheral Image Loader bindings to DT schema. The text bindngs incorrectly implied that IPQ8074 needs only one qcom,smem-states entry. This is only true for QCS404. IPQ8074 requires both "stop" and "shutdown".

---
 .../remoteproc/qcom,ipq9574-wcss-pil.yaml     | 167 ++++++++++++++++++
 .../bindings/remoteproc/qcom,q6v5.txt         | 102 -----------
 2 files changed, 167 insertions(+), 102 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/remoteproc/qcom,ipq9574-wcss-pil.yaml
 delete mode 100644 Documentation/devicetree/bindings/remoteproc/qcom,q6v5.txt
Documentation/devicetree/bindings/remoteproc/qcom,ipq9574-wcss-pil.yaml new file +167 -0
new file mode 100644
index 0000000000000..d28f42661d084
@@ -0,0 +1,167 @@
+# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/remoteproc/qcom,ipq9574-wcss-pil.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Qualcomm IPQ WCSS Peripheral Image Loader
+
+maintainers:
+  - Placeholder Maintainer <[email protected]>
+
+description:
+  The IPQ WCSS peripheral image loader is used to load firmware on the Qualcomm
+  Q6 processor that exposes WiFi-6 devices to the OS via the AHB bus. It is
+  generally used by ath11k to start up the wireless firmware.
+
+properties:
+  compatible:
+    enum:
+      - qcom,ipq8074-wcss-pil
+      - qcom,qcs404-wcss-pil
+
+  reg:
+    minItems: 2
+    maxItems: 2
+    description:
+      The base address and size of the QDSP6, and RMB register blocks
+
+  reg-names:
+    items:
+      - const: qdsp6
+      - const: rmb
+
+  interrupts-extended:
+    minItems: 5
+    maxItems: 5
+
+  interrupt-names:
+    items:
+      - const: wdog
+      - const: fatal
+      - const: ready
+      - const: handover
+      - const: stop-ack
+
+  resets:
+    minItems: 3
+    maxItems: 3
+
+  reset-names:
+    items:
+      - const: wcss_aon_reset
+      - const: wcss_reset
+      - const: wcss_q6_reset
+
+  clocks:
+    minItems: 10
+    maxItems: 13
+
+  clock-names:
+    minItems: 10
+    maxItems: 13
+
+  cx-supply:
+    description:
+      reference to the regulators used for the booting of the Hexagon core
+
+  memory-region:
+    description: Reference to wcss reserved-memory region
+
+  qcom,halt-regs:
+    $ref: /schemas/types.yaml#/definitions/phandle-array
+    description:
+      A phandle reference to a syscon representing TCSR followed by the three
+      offsets within syscon for q6, wcss and nc halt registers.
+    items:
+      - items:
+          - description: phandle to TCSR_MUTEX registers
+          - description: offset to the Q6 halt register
+          - description: offset to the wcss halt register
+          - description: offset to the nc halt register
+
+  qcom,smem-states:
+    $ref: /schemas/types.yaml#/definitions/phandle-array
+    description: States used by the AP to signal the remote processor
+
+  qcom,smem-state-names:
+    description:
+      Names of the states used by the AP to signal the remote processor
+
+  glink-edge:
+    $ref: /schemas/remoteproc/qcom,glink-edge.yaml#
+    description:
+      Qualcomm G-Link subnode which represents communication edge, channels
+      and devices related to the Modem.
+
+required:
+  - compatible
+  - reg
+  - reg-names
+  - interrupts-extended
+  - interrupt-names
+  - memory-region
+  - qcom,halt-regs
+  - qcom,smem-states
+  - qcom,smem-state-names
+
+allOf:
+  - if:
+      properties:
+        compatible:
+          contains:
+            enum:
+              - qcom,ipq8074-wcss-pil
+    then:
+      properties:
+        qcom,smem-states:
+          items:
+            - description: Shutdown Q6
+            - description: Stop Q6
+        qcom,smem-state-names:
+          items:
+            - const: shutdown
+            - const: stop
+  - if:
+      properties:
+        compatible:
+          contains:
+            enum:
+              - qcom,qcs404-wcss-pil
+    then:
+      properties:
+        qcom,smem-states:
+          maxItems: 1
+        qcom,smem-state-names:
+          items:
+            - const: stop
+
+  - if:
+      properties:
+        compatible:
+          contains:
+            enum:
+              - qcom,qcs404-wcss-pil
+    then:
+      properties:
+        clocks:
+          minItems: 10
+          maxItems: 10
+        clock-names:
+          items:
+            - const: xo
+            - const: gcc_abhs_cbcr
+            - const: gcc_axim_cbcr
+            - const: lcc_ahbfabric_cbc
+            - const: tcsr_lcc_cbc
+            - const: lcc_abhs_cbc
+            - const: lcc_tcm_slave_cbc
+            - const: lcc_abhm_cbc
+            - const: lcc_axim_cbc
+            - const: lcc_bcr_sleep
+      required:
+        - clocks
+        - clock-names
+        - cx-supply
+
+additionalProperties: false
Documentation/devicetree/bindings/remoteproc/qcom,q6v5.txt deleted +0 -102

102 lines not on this page · raw message

Signature · 1 line
2.45.1
#2 lore raw

Re: [PATCH RFC 1/3] dt-bindings: remoteproc: qcom,ipq8074-wcss-pil: convert to DT schema

Quoted 6 lines · Alexandru Gagniuc

Convert the QCS404 and IPQ WCSS Peripheral Image Loader bindings to DT schema. The text bindngs incorrectly implied that IPQ8074 needs only one qcom,smem-states entry. This is only true for QCS404. IPQ8074 requires both "stop" and "shutdown".

Don't add fake addresses to CC. I could not respond to this email because of that!

Documentation/devicetree/bindings/remoteproc/qcom,ipq9574-wcss-pil.yaml

Quoted 12 lines
---
 .../remoteproc/qcom,ipq9574-wcss-pil.yaml     | 167 ++++++++++++++++++
 .../bindings/remoteproc/qcom,q6v5.txt         | 102 -----------
 2 files changed, 167 insertions(+), 102 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/remoteproc/qcom,ipq9574-wcss-pil.yaml
 delete mode 100644 Documentation/devicetree/bindings/remoteproc/qcom,q6v5.txt
Documentation/devicetree/bindings/remoteproc/qcom,ipq9574-wcss-pil.yaml new file +0 -0
new file mode 100644
index 0000000000000..d28f42661d084

Filename based on the compatible, so for example:
qcom,ipq8074-wcss-pil.yaml

Documentation/devicetree/bindings/remoteproc/qcom,ipq9574-wcss-pil.yaml line 10

Quoted 11 lines
Documentation/devicetree/bindings/remoteproc/qcom,ipq9574-wcss-pil.yaml new file +10 -0
@@ -0,0 +1,167 @@
+# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/remoteproc/qcom,ipq9574-wcss-pil.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Qualcomm IPQ WCSS Peripheral Image Loader
+
+maintainers:
+  - Placeholder Maintainer <[email protected]>

This must be a real person. Fallback is your SoC maintainer.

Quoted 4 lines
Documentation/devicetree/bindings/remoteproc/qcom,ipq9574-wcss-pil.yaml new file +4 -0
+
+description:
+  The IPQ WCSS peripheral image loader is used to load firmware on the Qualcomm
+  Q6 processor that exposes WiFi-6 devices to the OS via the AHB bus. It is

Documentation/devicetree/bindings/remoteproc/qcom,ipq9574-wcss-pil.yaml line 24

Quoted 10 lines
Documentation/devicetree/bindings/remoteproc/qcom,ipq9574-wcss-pil.yaml new file +10 -0
+  generally used by ath11k to start up the wireless firmware.
+
+properties:
+  compatible:
+    enum:
+      - qcom,ipq8074-wcss-pil
+      - qcom,qcs404-wcss-pil
+
+  reg:
+    minItems: 2

Drop

Documentation/devicetree/bindings/remoteproc/qcom,ipq9574-wcss-pil.yaml line 27

Quoted 3 lines
Documentation/devicetree/bindings/remoteproc/qcom,ipq9574-wcss-pil.yaml new file +3 -0
+    maxItems: 2
+    description:
+      The base address and size of the QDSP6, and RMB register blocks

Drop description. Look at other bindings how this is written.

Documentation/devicetree/bindings/remoteproc/qcom,ipq9574-wcss-pil.yaml line 34

Quoted 7 lines
Documentation/devicetree/bindings/remoteproc/qcom,ipq9574-wcss-pil.yaml new file +7 -0
+
+  reg-names:
+    items:
+      - const: qdsp6
+      - const: rmb
+
+  interrupts-extended:

No, you only need interrupts. Please look at other bindings - how they write this.

Documentation/devicetree/bindings/remoteproc/qcom,ipq9574-wcss-pil.yaml line 35

Quoted 1 line
Documentation/devicetree/bindings/remoteproc/qcom,ipq9574-wcss-pil.yaml new file +1 -0
+    minItems: 5

Drop

Documentation/devicetree/bindings/remoteproc/qcom,ipq9574-wcss-pil.yaml line 47

Quoted 12 lines
Documentation/devicetree/bindings/remoteproc/qcom,ipq9574-wcss-pil.yaml new file +12 -0
+    maxItems: 5
+
+  interrupt-names:
+    items:
+      - const: wdog
+      - const: fatal
+      - const: ready
+      - const: handover
+      - const: stop-ack
+
+  resets:
+    minItems: 3

Drop

Documentation/devicetree/bindings/remoteproc/qcom,ipq9574-wcss-pil.yaml line 58

Quoted 11 lines
Documentation/devicetree/bindings/remoteproc/qcom,ipq9574-wcss-pil.yaml new file +11 -0
+    maxItems: 3
+
+  reset-names:
+    items:
+      - const: wcss_aon_reset
+      - const: wcss_reset
+      - const: wcss_q6_reset
+
+  clocks:
+    minItems: 10
+    maxItems: 13

Why is this flexible? Wasn't in the old binding and nothing in the commit msg explained a change in the binding.

Documentation/devicetree/bindings/remoteproc/qcom,ipq9574-wcss-pil.yaml line 69

Quoted 11 lines
Documentation/devicetree/bindings/remoteproc/qcom,ipq9574-wcss-pil.yaml new file +11 -0
+
+  clock-names:
+    minItems: 10
+    maxItems: 13
+
+  cx-supply:
+    description:
+      reference to the regulators used for the booting of the Hexagon core
+
+  memory-region:
+    description: Reference to wcss reserved-memory region

Drop description. Missing maxItems, please look at other bindings. Don't write your own style, but look how we already wrote remoteproc bindings (the latest).

Quoted 5 lines
Documentation/devicetree/bindings/remoteproc/qcom,ipq9574-wcss-pil.yaml new file +5 -0
+
+  qcom,halt-regs:
+    $ref: /schemas/types.yaml#/definitions/phandle-array
+    description:
+      A phandle reference to a syscon representing TCSR followed by the three

Documentation/devicetree/bindings/remoteproc/qcom,ipq9574-wcss-pil.yaml line 84

Quoted 10 lines
Documentation/devicetree/bindings/remoteproc/qcom,ipq9574-wcss-pil.yaml new file +10 -0
+      offsets within syscon for q6, wcss and nc halt registers.
+    items:
+      - items:
+          - description: phandle to TCSR_MUTEX registers
+          - description: offset to the Q6 halt register
+          - description: offset to the wcss halt register
+          - description: offset to the nc halt register
+
+  qcom,smem-states:
+    $ref: /schemas/types.yaml#/definitions/phandle-array

That's incomplete - missing constraints. Are you sure you wrote this code the same way we already did for other devices?

Quoted 14 lines
Documentation/devicetree/bindings/remoteproc/qcom,ipq9574-wcss-pil.yaml new file +14 -0
+    description: States used by the AP to signal the remote processor
+
+  qcom,smem-state-names:
+    description:
+      Names of the states used by the AP to signal the remote processor
+
+  glink-edge:
+    $ref: /schemas/remoteproc/qcom,glink-edge.yaml#
+    description:
+      Qualcomm G-Link subnode which represents communication edge, channels
+      and devices related to the Modem.
+
+required:
+  - compatible

Documentation/devicetree/bindings/remoteproc/qcom,ipq9574-wcss-pil.yaml line 108

Quoted 10 lines
Documentation/devicetree/bindings/remoteproc/qcom,ipq9574-wcss-pil.yaml new file +10 -0
+  - reg
+  - reg-names
+  - interrupts-extended
+  - interrupt-names
+  - memory-region
+  - qcom,halt-regs
+  - qcom,smem-states
+  - qcom,smem-state-names
+
+allOf:

Seems you do not reference other schemas. I am going to repeat myself for 10th time: are you sure you followed other devices?

Quoted 6 lines
Documentation/devicetree/bindings/remoteproc/qcom,ipq9574-wcss-pil.yaml new file +6 -0
+  - if:
+      properties:
+        compatible:
+          contains:
+            enum:
+              - qcom,ipq8074-wcss-pil

Documentation/devicetree/bindings/remoteproc/qcom,ipq9574-wcss-pil.yaml line 124

Quoted 10 lines
Documentation/devicetree/bindings/remoteproc/qcom,ipq9574-wcss-pil.yaml new file +10 -0
+    then:
+      properties:
+        qcom,smem-states:
+          items:
+            - description: Shutdown Q6
+            - description: Stop Q6
+        qcom,smem-state-names:
+          items:
+            - const: shutdown
+            - const: stop

Missing clocks

Missing blank line

Quoted 28 lines
Documentation/devicetree/bindings/remoteproc/qcom,ipq9574-wcss-pil.yaml new file +27 -0
+  - if:
+      properties:
+        compatible:
+          contains:
+            enum:
+              - qcom,qcs404-wcss-pil
+    then:
+      properties:
+        qcom,smem-states:
+          maxItems: 1
+        qcom,smem-state-names:
+          items:
+            - const: stop
 
+
+  - if:
+      properties:
+        compatible:
+          contains:
+            enum:
+              - qcom,qcs404-wcss-pil
+    then:
+      properties:
+        clocks:
+          minItems: 10
+          maxItems: 10
+        clock-names:
+          items:

Documentation/devicetree/bindings/remoteproc/qcom,ipq9574-wcss-pil.yaml line 161

Quoted 10 lines
Documentation/devicetree/bindings/remoteproc/qcom,ipq9574-wcss-pil.yaml new file +10 -0
+            - const: xo
+            - const: gcc_abhs_cbcr
+            - const: gcc_axim_cbcr
+            - const: lcc_ahbfabric_cbc
+            - const: tcsr_lcc_cbc
+            - const: lcc_abhs_cbc
+            - const: lcc_tcm_slave_cbc
+            - const: lcc_abhm_cbc
+            - const: lcc_axim_cbc
+            - const: lcc_bcr_sleep

All this goes to previous if.

Documentation/devicetree/bindings/remoteproc/qcom,ipq9574-wcss-pil.yaml line 167

Quoted 6 lines
Documentation/devicetree/bindings/remoteproc/qcom,ipq9574-wcss-pil.yaml new file +6 -0
+      required:
+        - clocks
+        - clock-names
+        - cx-supply
+
+additionalProperties: false

Missing example.

Best regards,
Krzysztof

author
#3 lore raw

Re: [PATCH RFC 1/3] dt-bindings: remoteproc: qcom,ipq8074-wcss-pil: convert to DT schema

Quoted 10 lines · Krzysztof Kozlowski
Quoted 6 lines · Alexandru Gagniuc

Convert the QCS404 and IPQ WCSS Peripheral Image Loader bindings to DT schema. The text bindngs incorrectly implied that IPQ8074 needs only one qcom,smem-states entry. This is only true for QCS404. IPQ8074 requires both "stop" and "shutdown".

Don't add fake addresses to CC. I could not respond to this email because of that!

Okay.

Quoted 7 lines
Quoted 7 lines
---
  .../remoteproc/qcom,ipq9574-wcss-pil.yaml     | 167 ++++++++++++++++++
  .../bindings/remoteproc/qcom,q6v5.txt         | 102 -----------
  2 files changed, 167 insertions(+), 102 deletions(-)

create mode 100644 Documentation/devicetree/bindings/remoteproc/qcom,ipq9574-wcss-pil.yaml delete mode 100644 Documentation/devicetree/bindings/remoteproc/qcom,q6v5.txt

Quoted 8 lines

Documentation/devicetree/bindings/remoteproc/qcom,ipq9574-wcss-pil.yaml

Quoted 5 lines
Documentation/devicetree/bindings/remoteproc/qcom,ipq9574-wcss-pil.yaml new file +0 -0
new file mode 100644
index 0000000000000..d28f42661d084

Filename based on the compatible, so for example:
qcom,ipq8074-wcss-pil.yaml

Okay.

Quoted 5 lines
Quoted 5 lines
Documentation/devicetree/bindings/remoteproc/qcom,ipq9574-wcss-pil.yaml new file +4 -0
@@ -0,0 +1,167 @@
+# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/remoteproc/qcom,ipq9574-wcss-pil.yaml#
Quoted 8 lines

Documentation/devicetree/bindings/remoteproc/qcom,ipq9574-wcss-pil.yaml line 10

Quoted 6 lines
Documentation/devicetree/bindings/remoteproc/qcom,ipq9574-wcss-pil.yaml new file +6 -0
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Qualcomm IPQ WCSS Peripheral Image Loader
+
+maintainers:
+  - Placeholder Maintainer <[email protected]>

This must be a real person. Fallback is your SoC maintainer.

I can't find an official maintainer for IPQ8074 or IPQ9574. I could list myself, but you know a lot about these bindings. Is it okay if I list you as the maintainer of this binding, Krzysztof?

Quoted 10 lines

Documentation/devicetree/bindings/remoteproc/qcom,ipq9574-wcss-pil.yaml line 34

Quoted 7 lines
Documentation/devicetree/bindings/remoteproc/qcom,ipq9574-wcss-pil.yaml new file +7 -0
+
+  reg-names:
+    items:
+      - const: qdsp6
+      - const: rmb
+
+  interrupts-extended:

No, you only need interrupts. Please look at other bindings - how they write this.

I thought I needed interrupts-extended if the interrupts use more than one interrupt controller. Is that not the case?

Quoted 4 lines

Documentation/devicetree/bindings/remoteproc/qcom,ipq9574-wcss-pil.yaml line 35

Quoted 1 line
Documentation/devicetree/bindings/remoteproc/qcom,ipq9574-wcss-pil.yaml new file +1 -0
+    minItems: 5

Drop

Quoted 14 lines

Documentation/devicetree/bindings/remoteproc/qcom,ipq9574-wcss-pil.yaml line 47

Quoted 12 lines
Documentation/devicetree/bindings/remoteproc/qcom,ipq9574-wcss-pil.yaml new file +12 -0
+    maxItems: 5
+
+  interrupt-names:
+    items:
+      - const: wdog
+      - const: fatal
+      - const: ready
+      - const: handover
+      - const: stop-ack
+
+  resets:
+    minItems: 3

Drop

I will drop all the items you identified as excessive.>

Quoted 6 lines
Quoted 6 lines
Documentation/devicetree/bindings/remoteproc/qcom,ipq9574-wcss-pil.yaml new file +6 -0
+    maxItems: 3
+
+  reset-names:
+    items:
+      - const: wcss_aon_reset
+      - const: wcss_reset
Quoted 8 lines

Documentation/devicetree/bindings/remoteproc/qcom,ipq9574-wcss-pil.yaml line 58

Quoted 5 lines
Documentation/devicetree/bindings/remoteproc/qcom,ipq9574-wcss-pil.yaml new file +5 -0
+      - const: wcss_q6_reset
+
+  clocks:
+    minItems: 10
+    maxItems: 13

Why is this flexible? Wasn't in the old binding and nothing in the commit msg explained a change in the binding.

I was thinking ahead to the next patch in the series that adds IPQ9574 binding. It makes more sense to keep it at 10 fot this patch, like you suggest.

Quoted 7 lines
Quoted 7 lines
Documentation/devicetree/bindings/remoteproc/qcom,ipq9574-wcss-pil.yaml new file +7 -0
+
+  clock-names:
+    minItems: 10
+    maxItems: 13
+
+  cx-supply:
+    description:
Quoted 8 lines

Documentation/devicetree/bindings/remoteproc/qcom,ipq9574-wcss-pil.yaml line 69

Quoted 4 lines
Documentation/devicetree/bindings/remoteproc/qcom,ipq9574-wcss-pil.yaml new file +4 -0
+      reference to the regulators used for the booting of the Hexagon core
+
+  memory-region:
+    description: Reference to wcss reserved-memory region

Drop description. Missing maxItems, please look at other bindings. Don't write your own style, but look how we already wrote remoteproc bindings (the latest).

Is "maxItems: 1" the correct thing to add here?

Quoted 10 lines
Quoted 10 lines
Documentation/devicetree/bindings/remoteproc/qcom,ipq9574-wcss-pil.yaml new file +10 -0
+
+  qcom,halt-regs:
+    $ref: /schemas/types.yaml#/definitions/phandle-array
+    description:
+      A phandle reference to a syscon representing TCSR followed by the three
+      offsets within syscon for q6, wcss and nc halt registers.
+    items:
+      - items:
+          - description: phandle to TCSR_MUTEX registers
+          - description: offset to the Q6 halt register
Quoted 8 lines

Documentation/devicetree/bindings/remoteproc/qcom,ipq9574-wcss-pil.yaml line 84

Quoted 5 lines
Documentation/devicetree/bindings/remoteproc/qcom,ipq9574-wcss-pil.yaml new file +5 -0
+          - description: offset to the wcss halt register
+          - description: offset to the nc halt register
+
+  qcom,smem-states:
+    $ref: /schemas/types.yaml#/definitions/phandle-array

That's incomplete - missing constraints. Are you sure you wrote this code the same way we already did for other devices?

I am not sure. It seems to match qcom,qcs404-cdsp-pil.yaml or qcom,wcnss.yaml. What constraints are you expecting here?

Quoted 19 lines
Quoted 19 lines
Documentation/devicetree/bindings/remoteproc/qcom,ipq9574-wcss-pil.yaml new file +19 -0
+    description: States used by the AP to signal the remote processor
+
+  qcom,smem-state-names:
+    description:
+      Names of the states used by the AP to signal the remote processor
+
+  glink-edge:
+    $ref: /schemas/remoteproc/qcom,glink-edge.yaml#
+    description:
+      Qualcomm G-Link subnode which represents communication edge, channels
+      and devices related to the Modem.
+
+required:
+  - compatible
+  - reg
+  - reg-names
+  - interrupts-extended
+  - interrupt-names
+  - memory-region
Quoted 8 lines

Documentation/devicetree/bindings/remoteproc/qcom,ipq9574-wcss-pil.yaml line 108

Quoted 5 lines
Documentation/devicetree/bindings/remoteproc/qcom,ipq9574-wcss-pil.yaml new file +5 -0
+  - qcom,halt-regs
+  - qcom,smem-states
+  - qcom,smem-state-names
+
+allOf:

Seems you do not reference other schemas. I am going to repeat myself for 10th time: are you sure you followed other devices?

It's the sixth time, but I see your point. Comparing to qcom,qcs404-cdsp-pil.yaml or qcom,wcnss.yaml, I can't see what's missing. What do I need here?

Quoted 18 lines
Quoted 7 lines
Documentation/devicetree/bindings/remoteproc/qcom,ipq9574-wcss-pil.yaml new file +6 -0
+  - if:
+      properties:
+        compatible:
+          contains:
+            enum:
+              - qcom,ipq8074-wcss-pil

Documentation/devicetree/bindings/remoteproc/qcom,ipq9574-wcss-pil.yaml line 124

Quoted 10 lines
Documentation/devicetree/bindings/remoteproc/qcom,ipq9574-wcss-pil.yaml new file +10 -0
+    then:
+      properties:
+        qcom,smem-states:
+          items:
+            - description: Shutdown Q6
+            - description: Stop Q6
+        qcom,smem-state-names:
+          items:
+            - const: shutdown
+            - const: stop
Quoted 1 line

Missing clocks

The text binding that this replaces implies no clocks for IPQ8074. What would you like me to add instead?

Quoted 41 lines

Missing blank line

Quoted 28 lines
Documentation/devicetree/bindings/remoteproc/qcom,ipq9574-wcss-pil.yaml new file +27 -0
+  - if:
+      properties:
+        compatible:
+          contains:
+            enum:
+              - qcom,qcs404-wcss-pil
+    then:
+      properties:
+        qcom,smem-states:
+          maxItems: 1
+        qcom,smem-state-names:
+          items:
+            - const: stop
 
+
+  - if:
+      properties:
+        compatible:
+          contains:
+            enum:
+              - qcom,qcs404-wcss-pil
+    then:
+      properties:
+        clocks:
+          minItems: 10
+          maxItems: 10
+        clock-names:
+          items:

Documentation/devicetree/bindings/remoteproc/qcom,ipq9574-wcss-pil.yaml line 161

Quoted 10 lines
Documentation/devicetree/bindings/remoteproc/qcom,ipq9574-wcss-pil.yaml new file +10 -0
+            - const: xo
+            - const: gcc_abhs_cbcr
+            - const: gcc_axim_cbcr
+            - const: lcc_ahbfabric_cbc
+            - const: tcsr_lcc_cbc
+            - const: lcc_abhs_cbc
+            - const: lcc_tcm_slave_cbc
+            - const: lcc_abhm_cbc
+            - const: lcc_axim_cbc
+            - const: lcc_bcr_sleep
Quoted 1 line

All this goes to previous if.

Okay

Quoted 8 lines

Documentation/devicetree/bindings/remoteproc/qcom,ipq9574-wcss-pil.yaml line 167

Quoted 6 lines
Documentation/devicetree/bindings/remoteproc/qcom,ipq9574-wcss-pil.yaml new file +6 -0
+      required:
+        - clocks
+        - clock-names
+        - cx-supply
+
+additionalProperties: false

Missing example.

I plan to add the example in the next patch in the series that adds IPQ9547 binding. I don't have the resources to test IPQ8074 or QCS404, and I want to be sure that the example I add is tested.

Alex

#4 lore raw

Re: [PATCH RFC 1/3] dt-bindings: remoteproc: qcom,ipq8074-wcss-pil: convert to DT schema

Quoted 17 lines · Alex G.
Quoted 2 lines

Filename based on the compatible, so for example:
qcom,ipq8074-wcss-pil.yaml

Okay.

Quoted 5 lines
Quoted 5 lines
Documentation/devicetree/bindings/remoteproc/qcom,ipq9574-wcss-pil.yaml new file +4 -0
@@ -0,0 +1,167 @@
+# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/remoteproc/qcom,ipq9574-wcss-pil.yaml#
Quoted 8 lines

Documentation/devicetree/bindings/remoteproc/qcom,ipq9574-wcss-pil.yaml line 10

Quoted 6 lines
Documentation/devicetree/bindings/remoteproc/qcom,ipq9574-wcss-pil.yaml new file +6 -0
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Qualcomm IPQ WCSS Peripheral Image Loader
+
+maintainers:
+  - Placeholder Maintainer <[email protected]>

This must be a real person. Fallback is your SoC maintainer.

Quoted 1 line

I can't find an official maintainer for IPQ8074 or IPQ9574. I could list

I don't think you looked then. get_maintainers gives you clear answer.

Quoted 2 lines

myself, but you know a lot about these bindings. Is it okay if I list you as the maintainer of this binding, Krzysztof?

No. I am not the maintainer of this SoC.

Quoted 12 lines
Quoted 11 lines

Documentation/devicetree/bindings/remoteproc/qcom,ipq9574-wcss-pil.yaml line 34

Quoted 8 lines
Documentation/devicetree/bindings/remoteproc/qcom,ipq9574-wcss-pil.yaml new file +7 -0
+
+  reg-names:
+    items:
+      - const: qdsp6
+      - const: rmb
+
+  interrupts-extended:

No, you only need interrupts. Please look at other bindings - how they write this.

Quoted 2 lines

I thought I needed interrupts-extended if the interrupts use more than one interrupt controller. Is that not the case?

Instead of asking the same question again, which would give you the same answer "No, you only need interrupts" please rather think on the rest of the answer - look at other bindings.

..

Quoted 7 lines
Quoted 5 lines

Documentation/devicetree/bindings/remoteproc/qcom,ipq9574-wcss-pil.yaml line 84

Quoted 2 lines
Documentation/devicetree/bindings/remoteproc/qcom,ipq9574-wcss-pil.yaml new file +2 -0
+  qcom,smem-states:
+    $ref: /schemas/types.yaml#/definitions/phandle-array

That's incomplete - missing constraints. Are you sure you wrote this code the same way we already did for other devices?

I am not sure. It seems to match qcom,qcs404-cdsp-pil.yaml or

No, it does not.

Look at these files even - they have maxItems. Where do you see maxItems here? So how this can be done the same way ("match")?

Quoted 1 line

qcom,wcnss.yaml. What constraints are you expecting here?

So you take the latest binding, e.g. pas-common for all new platforms. Or qcom,qcs404-cdsp-pil.yaml. You need maxItems here and list of items for the names.

Quoted 29 lines
Quoted 20 lines
Quoted 20 lines
Documentation/devicetree/bindings/remoteproc/qcom,ipq9574-wcss-pil.yaml new file +19 -0
+    description: States used by the AP to signal the remote processor
+
+  qcom,smem-state-names:
+    description:
+      Names of the states used by the AP to signal the remote processor
+
+  glink-edge:
+    $ref: /schemas/remoteproc/qcom,glink-edge.yaml#
+    description:
+      Qualcomm G-Link subnode which represents communication edge, channels
+      and devices related to the Modem.
+
+required:
+  - compatible
+  - reg
+  - reg-names
+  - interrupts-extended
+  - interrupt-names
+  - memory-region
Quoted 8 lines

Documentation/devicetree/bindings/remoteproc/qcom,ipq9574-wcss-pil.yaml line 108

Quoted 5 lines
Documentation/devicetree/bindings/remoteproc/qcom,ipq9574-wcss-pil.yaml new file +5 -0
+  - qcom,halt-regs
+  - qcom,smem-states
+  - qcom,smem-state-names
+
+allOf:

Seems you do not reference other schemas. I am going to repeat myself for 10th time: are you sure you followed other devices?

Quoted 3 lines

It's the sixth time, but I see your point. Comparing to qcom,qcs404-cdsp-pil.yaml or qcom,wcnss.yaml, I can't see what's missing. What do I need here?

In previous cases you did not look at other binding, so I am questioning now everything.

Quoted 19 lines
Quoted 19 lines
Quoted 18 lines
Documentation/devicetree/bindings/remoteproc/qcom,ipq9574-wcss-pil.yaml new file +16 -0
+  - if:
+      properties:
+        compatible:
+          contains:
+            enum:
+              - qcom,ipq8074-wcss-pil
+    then:
+      properties:
+        qcom,smem-states:
+          items:
+            - description: Shutdown Q6
+            - description: Stop Q6
+        qcom,smem-state-names:
+          items:
+            - const: shutdown
+            - const: stop
Quoted 4 lines
Quoted 1 line

Missing clocks

The text binding that this replaces implies no clocks for IPQ8074. What would you like me to add instead?

Disallow the clocks. See example-schema.

Quoted 55 lines
Quoted 42 lines

Missing blank line

Quoted 28 lines
Documentation/devicetree/bindings/remoteproc/qcom,ipq9574-wcss-pil.yaml new file +27 -0
+  - if:
+      properties:
+        compatible:
+          contains:
+            enum:
+              - qcom,qcs404-wcss-pil
+    then:
+      properties:
+        qcom,smem-states:
+          maxItems: 1
+        qcom,smem-state-names:
+          items:
+            - const: stop
 
+
+  - if:
+      properties:
+        compatible:
+          contains:
+            enum:
+              - qcom,qcs404-wcss-pil
+    then:
+      properties:
+        clocks:
+          minItems: 10
+          maxItems: 10
+        clock-names:
+          items:

Documentation/devicetree/bindings/remoteproc/qcom,ipq9574-wcss-pil.yaml line 161

Quoted 10 lines
Documentation/devicetree/bindings/remoteproc/qcom,ipq9574-wcss-pil.yaml new file +10 -0
+            - const: xo
+            - const: gcc_abhs_cbcr
+            - const: gcc_axim_cbcr
+            - const: lcc_ahbfabric_cbc
+            - const: tcsr_lcc_cbc
+            - const: lcc_abhs_cbc
+            - const: lcc_tcm_slave_cbc
+            - const: lcc_abhm_cbc
+            - const: lcc_axim_cbc
+            - const: lcc_bcr_sleep
Quoted 1 line

All this goes to previous if.

Okay

Quoted 8 lines

Documentation/devicetree/bindings/remoteproc/qcom,ipq9574-wcss-pil.yaml line 167

Quoted 6 lines
Documentation/devicetree/bindings/remoteproc/qcom,ipq9574-wcss-pil.yaml new file +6 -0
+      required:
+        - clocks
+        - clock-names
+        - cx-supply
+
+additionalProperties: false

Missing example.

Quoted 3 lines

I plan to add the example in the next patch in the series that adds IPQ9547 binding. I don't have the resources to test IPQ8074 or QCS404, and I want to be sure that the example I add is tested.

I don't understand what example has anything to do with testing. We speak here ONLY about this binding. I do not review other code. This patch should have the example, but if you cannot come with one, because it does not exist in any existing sources, then you should just say that. You have entire commit msg to explain every unusual thing. And testing something on a device is not a reason, because you do not test the binding on a device.

Best regards,
Krzysztof

#5 lore raw

Re: [PATCH RFC 1/3] dt-bindings: remoteproc: qcom,ipq8074-wcss-pil: convert to DT schema

Quoted 18 lines · Krzysztof Kozlowski
Quoted 17 lines · Alex G.
Quoted 2 lines

Filename based on the compatible, so for example:
qcom,ipq8074-wcss-pil.yaml

Okay.

Quoted 13 lines

Documentation/devicetree/bindings/remoteproc/qcom,ipq9574-wcss-pil.yaml line 10

Quoted 11 lines
Documentation/devicetree/bindings/remoteproc/qcom,ipq9574-wcss-pil.yaml new file +10 -0
@@ -0,0 +1,167 @@
+# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/remoteproc/qcom,ipq9574-wcss-pil.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Qualcomm IPQ WCSS Peripheral Image Loader
+
+maintainers:
+  - Placeholder Maintainer <[email protected]>

This must be a real person. Fallback is your SoC maintainer.

Quoted 3 lines
Quoted 1 line

I can't find an official maintainer for IPQ8074 or IPQ9574. I could list

I don't think you looked then. get_maintainers gives you clear answer.

get_maintainers on qcom,q6v5.txt gives five generic subsystem maintainers, and you are on of them! I'll take something more specific, but just defaulting to get_maintainers is not helpful here.

Quoted 4 lines
Quoted 2 lines

myself, but you know a lot about these bindings. Is it okay if I list you as the maintainer of this binding, Krzysztof?

No. I am not the maintainer of this SoC.

Thank you for confirming you do not wish to be listed as the maintainer here.

Quoted 11 lines
Quoted 11 lines
Quoted 10 lines

Documentation/devicetree/bindings/remoteproc/qcom,ipq9574-wcss-pil.yaml line 34

Quoted 7 lines
Documentation/devicetree/bindings/remoteproc/qcom,ipq9574-wcss-pil.yaml new file +7 -0
+
+  reg-names:
+    items:
+      - const: qdsp6
+      - const: rmb
+
+  interrupts-extended:

No, you only need interrupts. Please look at other bindings - how they write this.

Quoted 6 lines
Quoted 2 lines

I thought I needed interrupts-extended if the interrupts use more than one interrupt controller. Is that not the case?

Instead of asking the same question again, which would give you the same answer "No, you only need interrupts" please rather think on the rest of the answer - look at other bindings.

No. It's a clarifying question with additional context. I think I should be expected to ask them when I still have doubts.

Quoted 10 lines
Quoted 7 lines
Quoted 5 lines

Documentation/devicetree/bindings/remoteproc/qcom,ipq9574-wcss-pil.yaml line 84

Quoted 2 lines
Documentation/devicetree/bindings/remoteproc/qcom,ipq9574-wcss-pil.yaml new file +2 -0
+  qcom,smem-states:
+    $ref: /schemas/types.yaml#/definitions/phandle-array

That's incomplete - missing constraints. Are you sure you wrote this code the same way we already did for other devices?

I am not sure. It seems to match qcom,qcs404-cdsp-pil.yaml or

No, it does not.

Quoted 8 lines

Look at these files even - they have maxItems. Where do you see maxItems here? So how this can be done the same way ("match")?

Quoted 1 line

qcom,wcnss.yaml. What constraints are you expecting here?

So you take the latest binding, e.g. pas-common for all new platforms. Or qcom,qcs404-cdsp-pil.yaml. You need maxItems here and list of items for the names.

Okay. I wasn't sure if that's the appropriate solution when QCS404 and IPQ8074 take a different number of smem-states.

Quoted 29 lines
Quoted 29 lines
Quoted 28 lines
Quoted 15 lines
Documentation/devicetree/bindings/remoteproc/qcom,ipq9574-wcss-pil.yaml new file +14 -0
+    description: States used by the AP to signal the remote processor
+
+  qcom,smem-state-names:
+    description:
+      Names of the states used by the AP to signal the remote processor
+
+  glink-edge:
+    $ref: /schemas/remoteproc/qcom,glink-edge.yaml#
+    description:
+      Qualcomm G-Link subnode which represents communication edge, channels
+      and devices related to the Modem.
+
+required:
+  - compatible

Documentation/devicetree/bindings/remoteproc/qcom,ipq9574-wcss-pil.yaml line 108

Quoted 10 lines
Documentation/devicetree/bindings/remoteproc/qcom,ipq9574-wcss-pil.yaml new file +10 -0
+  - reg
+  - reg-names
+  - interrupts-extended
+  - interrupt-names
+  - memory-region
+  - qcom,halt-regs
+  - qcom,smem-states
+  - qcom,smem-state-names
+
+allOf:

Seems you do not reference other schemas. I am going to repeat myself for 10th time: are you sure you followed other devices?

Quoted 6 lines
Quoted 3 lines

It's the sixth time, but I see your point. Comparing to qcom,qcs404-cdsp-pil.yaml or qcom,wcnss.yaml, I can't see what's missing. What do I need here?

In previous cases you did not look at other binding, so I am questioning now everything.I resent the accusation. I looked at several other bindings to see the

best way to write this one in a manner that also works with "make dt_binding_check". I have done my homework, and think it is unproductive to accuse me of not doing it because I did not do it to your standards or liking.

Quoted 19 lines
Quoted 19 lines
Quoted 19 lines
Quoted 18 lines
Documentation/devicetree/bindings/remoteproc/qcom,ipq9574-wcss-pil.yaml new file +16 -0
+  - if:
+      properties:
+        compatible:
+          contains:
+            enum:
+              - qcom,ipq8074-wcss-pil
+    then:
+      properties:
+        qcom,smem-states:
+          items:
+            - description: Shutdown Q6
+            - description: Stop Q6
+        qcom,smem-state-names:
+          items:
+            - const: shutdown
+            - const: stop
Quoted 6 lines
Quoted 4 lines
Quoted 1 line

Missing clocks

The text binding that this replaces implies no clocks for IPQ8074. What would you like me to add instead?

Disallow the clocks. See example-schema.

Okay. Makes sense (clocks: false).

Quoted 59 lines
Quoted 55 lines
Quoted 42 lines

Missing blank line

Quoted 28 lines
Documentation/devicetree/bindings/remoteproc/qcom,ipq9574-wcss-pil.yaml new file +27 -0
+  - if:
+      properties:
+        compatible:
+          contains:
+            enum:
+              - qcom,qcs404-wcss-pil
+    then:
+      properties:
+        qcom,smem-states:
+          maxItems: 1
+        qcom,smem-state-names:
+          items:
+            - const: stop
 
+
+  - if:
+      properties:
+        compatible:
+          contains:
+            enum:
+              - qcom,qcs404-wcss-pil
+    then:
+      properties:
+        clocks:
+          minItems: 10
+          maxItems: 10
+        clock-names:
+          items:

Documentation/devicetree/bindings/remoteproc/qcom,ipq9574-wcss-pil.yaml line 161

Quoted 10 lines
Documentation/devicetree/bindings/remoteproc/qcom,ipq9574-wcss-pil.yaml new file +10 -0
+            - const: xo
+            - const: gcc_abhs_cbcr
+            - const: gcc_axim_cbcr
+            - const: lcc_ahbfabric_cbc
+            - const: tcsr_lcc_cbc
+            - const: lcc_abhs_cbc
+            - const: lcc_tcm_slave_cbc
+            - const: lcc_abhm_cbc
+            - const: lcc_axim_cbc
+            - const: lcc_bcr_sleep
Quoted 1 line

All this goes to previous if.

Okay

Quoted 8 lines

Documentation/devicetree/bindings/remoteproc/qcom,ipq9574-wcss-pil.yaml line 167

Quoted 6 lines
Documentation/devicetree/bindings/remoteproc/qcom,ipq9574-wcss-pil.yaml new file +6 -0
+      required:
+        - clocks
+        - clock-names
+        - cx-supply
+
+additionalProperties: false

Missing example.

Quoted 3 lines

I plan to add the example in the next patch in the series that adds IPQ9547 binding. I don't have the resources to test IPQ8074 or QCS404, and I want to be sure that the example I add is tested.

Quoted 7 lines

I don't understand what example has anything to do with testing. We speak here ONLY about this binding. I do not review other code. This patch should have the example, but if you cannot come with one, because it does not exist in any existing sources, then you should just say that. You have entire commit msg to explain every unusual thing. And testing something on a device is not a reason, because you do not test the binding on a device.

I will mention this discrepant in the commit message.

Quoted 2 lines

Best regards,
Krzysztof

#6 lore raw

Re: [PATCH RFC 1/3] dt-bindings: remoteproc: qcom,ipq8074-wcss-pil: convert to DT schema

Quoted 21 lines · On 17/12/2025 23:22, [email protected] wrote:
Quoted 18 lines · Krzysztof Kozlowski
Quoted 17 lines · Alex G.
Quoted 2 lines

Filename based on the compatible, so for example:
qcom,ipq8074-wcss-pil.yaml

Okay.

Quoted 13 lines

Documentation/devicetree/bindings/remoteproc/qcom,ipq9574-wcss-pil.yaml line 10

Quoted 11 lines
Documentation/devicetree/bindings/remoteproc/qcom,ipq9574-wcss-pil.yaml new file +10 -0
@@ -0,0 +1,167 @@
+# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/remoteproc/qcom,ipq9574-wcss-pil.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Qualcomm IPQ WCSS Peripheral Image Loader
+
+maintainers:
+  - Placeholder Maintainer <[email protected]>

This must be a real person. Fallback is your SoC maintainer.

Quoted 5 lines
Quoted 3 lines
Quoted 1 line

I can't find an official maintainer for IPQ8074 or IPQ9574. I could list

I don't think you looked then. get_maintainers gives you clear answer.

get_maintainers on qcom,q6v5.txt gives five generic subsystem

That's a binding and I did not say maintainer of this file. I said SoC maintainer - it's easy to find the name of the soc here and the maintainers of that SoC.

Best regards,
Krzysztof

#7 lore raw

RFC PATCH 2/3 dt-bindings: remoteproc: qcom: add IPQ9574 image loader

In reply to Alexandru Gagniuc

Document the IPQ9574 native (non-PAS) WCSS image loader. It is similar to IPQ8074 WCSS, but requires several new clocks. These clocks must be enabled in non-PAS mode, and are not optional. Add an example that uses the "qcom,ipq9574-wcss-pil" binding.

---
 .../remoteproc/qcom,ipq9574-wcss-pil.yaml     | 102 ++++++++++++++++++
 1 file changed, 102 insertions(+)
Documentation/devicetree/bindings/remoteproc/qcom,ipq9574-wcss-pil.yaml +102 -0
index d28f42661d084..3daa1cb736bf2 100644
@@ -18,6 +18,7 @@ properties:
   compatible:
     enum:
       - qcom,ipq8074-wcss-pil
+      - qcom,ipq9574-wcss-pil
       - qcom,qcs404-wcss-pil
 
   reg:
@@ -112,6 +113,7 @@ allOf:
           contains:
             enum:
               - qcom,ipq8074-wcss-pil
+              - qcom,ipq9574-wcss-pil
     then:
       properties:
         qcom,smem-states:
@@ -136,6 +138,35 @@ allOf:
           items:
             - const: stop
 
+  - if:
+      properties:
+        compatible:
+          contains:
+            enum:
+              - qcom,ipq9574-wcss-pil
+    then:
+      properties:
+        clocks:
+          minItems: 13
+        clock-names:
+          items:
+            - const: anoc_wcss_axi_m
+            - const: wcss_ahb_s
+            - const: wcss_ecahb
+            - const: wcss_acmt
+            - const: wcss_axi_m
+            - const: q6_axim
+            - const: q6_axim2
+            - const: q6_ahb
+            - const: q6_ahb_s
+            - const: q6ss_boot
+            - const: mem_noc_q6_axi
+            - const: wcss_q6_tbu
+            - const: sys_noc_wcss_ahb
+      required:
+        - clocks
+        - clock-names
+
   - if:
       properties:
         compatible:
@@ -165,3 +196,74 @@ allOf:
         - cx-supply
 
 additionalProperties: false
+
+examples:
+  - |
+    #include <dt-bindings/clock/qcom,ipq9574-gcc.h>
+    #include <dt-bindings/interrupt-controller/arm-gic.h>
+    #include <dt-bindings/reset/qcom,ipq9574-gcc.h>
+
+    q6v5_wcss: remoteproc@cd00000 {
+        compatible = "qcom,ipq9574-wcss-pil";
+        reg = <0x0cd00000 0x4040>,
+              <0x004ab000 0x20>;
+        reg-names = "qdsp6", "rmb";
+
+        interrupts-extended = <&intc GIC_SPI 325 IRQ_TYPE_EDGE_RISING>,
+                              <&wcss_smp2p_in 0 IRQ_TYPE_NONE>,
+                              <&wcss_smp2p_in 1 IRQ_TYPE_NONE>,
+                              <&wcss_smp2p_in 2 IRQ_TYPE_NONE>,
+                              <&wcss_smp2p_in 3 IRQ_TYPE_NONE>;
+        interrupt-names = "wdog", "fatal", "ready",
+                          "handover", "stop-ack";
+
+        resets = <&gcc GCC_WCSSAON_RESET>,
+                 <&gcc GCC_WCSS_BCR>,
+                 <&gcc GCC_WCSS_Q6_BCR>;
+        reset-names = "wcss_aon_reset",
+                      "wcss_reset",
+                      "wcss_q6_reset";
+
+        clocks = <&gcc GCC_ANOC_WCSS_AXI_M_CLK>,
+                 <&gcc GCC_WCSS_AHB_S_CLK>,
+                 <&gcc GCC_WCSS_ECAHB_CLK>,
+                 <&gcc GCC_WCSS_ACMT_CLK>,
+                 <&gcc GCC_WCSS_AXI_M_CLK>,
+                 <&gcc GCC_Q6_AXIM_CLK>,
+                 <&gcc GCC_Q6_AXIM2_CLK>,
+                 <&gcc GCC_Q6_AHB_CLK>,
+                 <&gcc GCC_Q6_AHB_S_CLK>,
+                 <&gcc GCC_Q6SS_BOOT_CLK>,
+                 <&gcc GCC_MEM_NOC_Q6_AXI_CLK>,
+                 <&gcc GCC_WCSS_Q6_TBU_CLK>,
+                 <&gcc GCC_SYS_NOC_WCSS_AHB_CLK>;
+
+        clock-names = "anoc_wcss_axi_m",
+                      "wcss_ahb_s",
+                      "wcss_ecahb",
+                      "wcss_acmt",
+                      "wcss_axi_m",
+                      "q6_axim",
+                      "q6_axim2",
+                      "q6_ahb",
+                      "q6_ahb_s",
+                      "q6ss_boot",
+                      "mem_noc_q6_axi",
+                      "wcss_q6_tbu",
+                      "sys_noc_wcss_ahb";
+
+        qcom,halt-regs = <&tcsr 0x18000 0x1b000 0xe000>;
+
+        qcom,smem-states = <&wcss_smp2p_out 0>,
+                           <&wcss_smp2p_out 1>;
+        qcom,smem-state-names = "shutdown",
+                                "stop";
+        memory-region = <&q6_region>;
+
+        glink-edge {
+            interrupts = <GIC_SPI 321 IRQ_TYPE_EDGE_RISING>;
+            label = "rtr";
+            qcom,remote-pid = <1>;
+            mboxes = <&apcs_glb 8>;
+        };
+    };
Signature · 1 line
2.45.1
#8 lore raw

Re: [PATCH RFC 2/3] dt-bindings: remoteproc: qcom: add IPQ9574 image loader

kernel test robot noticed the following build errors:

Hi Alexandru,

[This is a private test report for your RFC patch.] kernel test robot noticed the following build errors:

[auto build test ERROR on robh/for-next]
[also build test ERROR on remoteproc/rproc-next linus/master v6.19-rc1 next-20251219] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Alexandru-Gagniuc/dt-bindings-remoteproc-qcom-ipq8074-wcss-pil-convert-to-DT-schema/20251210-084421
base:   https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git for-next
patch link:    https://lore.kernel.org/r/20251210003729.3909663-3-mr.nuke.me%40gmail.com
patch subject: [PATCH RFC 2/3] dt-bindings: remoteproc: qcom: add IPQ9574 image loader
config: openrisc-randconfig-2051-20251221 (https://download.01.org/0day-ci/archive/20251221/[email protected]/config)
compiler: or1k-linux-gcc (GCC) 15.1.0
dtschema version: 2025.12
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20251221/[email protected]/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <[email protected]>
| Closes: https://lore.kernel.org/oe-kbuild-all/[email protected]/

All errors (new ones prefixed by >>):

Lexical error: Documentation/devicetree/bindings/remoteproc/qcom,ipq9574-wcss-pil.example.dts:49.28-51 Unexpected 'GCC_ANOC_WCSS_AXI_M_CLK' Lexical error: Documentation/devicetree/bindings/remoteproc/qcom,ipq9574-wcss-pil.example.dts:50.28-46 Unexpected 'GCC_WCSS_AHB_S_CLK' Lexical error: Documentation/devicetree/bindings/remoteproc/qcom,ipq9574-wcss-pil.example.dts:51.28-46 Unexpected 'GCC_WCSS_ECAHB_CLK' Lexical error: Documentation/devicetree/bindings/remoteproc/qcom,ipq9574-wcss-pil.example.dts:52.28-45 Unexpected 'GCC_WCSS_ACMT_CLK' Lexical error: Documentation/devicetree/bindings/remoteproc/qcom,ipq9574-wcss-pil.example.dts:53.28-46 Unexpected 'GCC_WCSS_AXI_M_CLK' Lexical error: Documentation/devicetree/bindings/remoteproc/qcom,ipq9574-wcss-pil.example.dts:54.28-43 Unexpected 'GCC_Q6_AXIM_CLK' Lexical error: Documentation/devicetree/bindings/remoteproc/qcom,ipq9574-wcss-pil.example.dts:55.28-44 Unexpected 'GCC_Q6_AXIM2_CLK' Lexical error: Documentation/devicetree/bindings/remoteproc/qcom,ipq9574-wcss-pil.example.dts:56.28-42 Unexpected 'GCC_Q6_AHB_CLK' Lexical error: Documentation/devicetree/bindings/remoteproc/qcom,ipq9574-wcss-pil.example.dts:57.28-44 Unexpected 'GCC_Q6_AHB_S_CLK' Lexical error: Documentation/devicetree/bindings/remoteproc/qcom,ipq9574-wcss-pil.example.dts:58.28-45 Unexpected 'GCC_Q6SS_BOOT_CLK' Lexical error: Documentation/devicetree/bindings/remoteproc/qcom,ipq9574-wcss-pil.example.dts:59.28-50 Unexpected 'GCC_MEM_NOC_Q6_AXI_CLK' Lexical error: Documentation/devicetree/bindings/remoteproc/qcom,ipq9574-wcss-pil.example.dts:60.28-47 Unexpected 'GCC_WCSS_Q6_TBU_CLK' Lexical error: Documentation/devicetree/bindings/remoteproc/qcom,ipq9574-wcss-pil.example.dts:61.28-52 Unexpected 'GCC_SYS_NOC_WCSS_AHB_CLK'

>> FATAL ERROR: Syntax error parsing input tree
Signature · 2 lines
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
#9 lore raw

RFC PATCH 3/3 arm64: dts: qcom: ipq8074: add remoteproc nodes

In reply to Alexandru Gagniuc

Add the nodes for the WCSS remoteproc loader on IPQ8074, so that there a use case for the DT bindings. GCC_WCSSAON_RESET is not implemented by the GCC reset controller, so use a placeholder value for now. Leave the node disabled so that remoteproc doesn't start up with the missing reset.

---
 arch/arm64/boot/dts/qcom/ipq8074.dtsi | 79 +++++++++++++++++++++++++++
 1 file changed, 79 insertions(+)
arch/arm64/boot/dts/qcom/ipq8074.dtsi +79 -0
index 256e12cf6d544..86369fa680553 100644
@@ -108,6 +108,11 @@ memory@4ac00000 {
 			reg = <0x0 0x4ac00000 0x0 0x400000>;
 			no-map;
 		};
+
+		q6_region: wcnss@4b000000 {
+			reg = <0x0 0x4b000000 0x0 0x03700000>;
+			no-map;
+		};
 	};
 
 	firmware {
@@ -390,6 +395,11 @@ tcsr: syscon@1937000 {
 			reg = <0x01937000 0x21000>;
 		};
 
+		tcsr_q6: syscon@1945000 {
+			compatible = "qcom,tcsr-ipq8074", "syscon";
+			reg = <0x01945000 0xe000>;
+		};
+
 		spmi_bus: spmi@200f000 {
 			compatible = "qcom,spmi-pmic-arb";
 			reg = <0x0200f000 0x001000>,
@@ -1003,6 +1013,50 @@ pcie@0 {
 				ranges;
 			};
 		};
+
+		q6v5_wcss: remoteproc@cd00000 {
+			compatible = "qcom,ipq8074-wcss-pil";
+			reg = <0x0cd00000 0x4040>,
+			      <0x004ab000 0x20>;
+			reg-names = "qdsp6",
+				    "rmb";
+
+			interrupts-extended = <&intc GIC_SPI 325 IRQ_TYPE_EDGE_RISING>,
+					      <&wcss_smp2p_in 0 0>,
+					      <&wcss_smp2p_in 1 0>,
+					      <&wcss_smp2p_in 2 0>,
+					      <&wcss_smp2p_in 3 0>;
+			interrupt-names = "wdog",
+					  "fatal",
+					  "ready",
+					  "handover",
+					  "stop-ack";
+
+			resets = <&gcc 0xffff>, /* GCC_WCSSAON_RESET */
+				 <&gcc GCC_WCSS_BCR>,
+				 <&gcc GCC_WCSS_Q6_BCR>;
+
+			reset-names = "wcss_aon_reset",
+				      "wcss_reset",
+				      "wcss_q6_reset";
+
+			memory-region = <&q6_region>;
+			qcom,halt-regs = <&tcsr_q6 0xa000 0xd000 0x0>;
+
+			qcom,smem-states = <&wcss_smp2p_out 0>,
+					   <&wcss_smp2p_out 1>;
+			qcom,smem-state-names = "shutdown",
+						"stop";
+
+			status = "disabled";
+
+			glink-edge {
+				interrupts = <GIC_SPI 321 IRQ_TYPE_EDGE_RISING>;
+				label = "rtr";
+				qcom,remote-pid = <1>;
+				mboxes = <&apcs_glb 8>;
+			};
+		};
 	};
 
 	timer {
@@ -1182,4 +1236,29 @@ wcss-phyb1-crit {
 			};
 		};
 	};
+
+	wcss: smp2p-wcss {
+		compatible = "qcom,smp2p";
+		qcom,smem = <435>, <428>;
+
+		interrupt-parent = <&intc>;
+		interrupts = <GIC_SPI 322 IRQ_TYPE_EDGE_RISING>;
+
+		mboxes = <&apcs_glb 9>;
+
+		qcom,local-pid = <0>;
+		qcom,remote-pid = <1>;
+
+		wcss_smp2p_out: master-kernel {
+			qcom,entry-name = "master-kernel";
+			#qcom,smem-state-cells = <1>;
+		};
+
+		wcss_smp2p_in: slave-kernel {
+			qcom,entry-name = "slave-kernel";
+
+			interrupt-controller;
+			#interrupt-cells = <2>;
+		};
+	};
 };
Signature · 1 line
2.45.1
#10 lore raw

Re: [PATCH RFC 3/3] arm64: dts: qcom: ipq8074: add remoteproc nodes

Quoted 40 lines · Alexandru Gagniuc

Add the nodes for the WCSS remoteproc loader on IPQ8074, so that there a use case for the DT bindings. GCC_WCSSAON_RESET is not implemented by the GCC reset controller, so use a placeholder value for now. Leave the node disabled so that remoteproc doesn't start up with the missing reset.

---
 arch/arm64/boot/dts/qcom/ipq8074.dtsi | 79 +++++++++++++++++++++++++++
 1 file changed, 79 insertions(+)
arch/arm64/boot/dts/qcom/ipq8074.dtsi +10 -0
index 256e12cf6d544..86369fa680553 100644
@@ -108,6 +108,11 @@ memory@4ac00000 {
 			reg = <0x0 0x4ac00000 0x0 0x400000>;
 			no-map;
 		};
+
+		q6_region: wcnss@4b000000 {
+			reg = <0x0 0x4b000000 0x0 0x03700000>;
+			no-map;
+		};
 	};
 
 	firmware {
@@ -390,6 +395,11 @@ tcsr: syscon@1937000 {
 			reg = <0x01937000 0x21000>;
 		};
 
+		tcsr_q6: syscon@1945000 {
+			compatible = "qcom,tcsr-ipq8074", "syscon";
+			reg = <0x01945000 0xe000>;
+		};
+
 		spmi_bus: spmi@200f000 {
 			compatible = "qcom,spmi-pmic-arb";
 			reg = <0x0200f000 0x001000>,

arch/arm64/boot/dts/qcom/ipq8074.dtsi pcie@0 { · line 1019

Quoted 7 lines
arch/arm64/boot/dts/qcom/ipq8074.dtsi +4 -0
@@ -1003,6 +1013,50 @@ pcie@0 {
 				ranges;
 			};
 		};
+
+		q6v5_wcss: remoteproc@cd00000 {
+			compatible = "qcom,ipq8074-wcss-pil";
+			reg = <0x0cd00000 0x4040>,

This node is out of place. it should be sorted by the address, so it should come after timer device.

Quoted 44 lines
arch/arm64/boot/dts/qcom/ipq8074.dtsi +40 -0
+			      <0x004ab000 0x20>;
+			reg-names = "qdsp6",
+				    "rmb";
+
+			interrupts-extended = <&intc GIC_SPI 325 IRQ_TYPE_EDGE_RISING>,
+					      <&wcss_smp2p_in 0 0>,
+					      <&wcss_smp2p_in 1 0>,
+					      <&wcss_smp2p_in 2 0>,
+					      <&wcss_smp2p_in 3 0>;
+			interrupt-names = "wdog",
+					  "fatal",
+					  "ready",
+					  "handover",
+					  "stop-ack";
+
+			resets = <&gcc 0xffff>, /* GCC_WCSSAON_RESET */
+				 <&gcc GCC_WCSS_BCR>,
+				 <&gcc GCC_WCSS_Q6_BCR>;
+
+			reset-names = "wcss_aon_reset",
+				      "wcss_reset",
+				      "wcss_q6_reset";
+
+			memory-region = <&q6_region>;
+			qcom,halt-regs = <&tcsr_q6 0xa000 0xd000 0x0>;
+
+			qcom,smem-states = <&wcss_smp2p_out 0>,
+					   <&wcss_smp2p_out 1>;
+			qcom,smem-state-names = "shutdown",
+						"stop";
+
+			status = "disabled";
+
+			glink-edge {
+				interrupts = <GIC_SPI 321 IRQ_TYPE_EDGE_RISING>;
+				label = "rtr";
+				qcom,remote-pid = <1>;
+				mboxes = <&apcs_glb 8>;
+			};
+		};
 	};
 
 	timer {

arch/arm64/boot/dts/qcom/ipq8074.dtsi wcss-phyb1-crit { · line 1240

Quoted 5 lines
arch/arm64/boot/dts/qcom/ipq8074.dtsi +2 -0
@@ -1182,4 +1236,29 @@ wcss-phyb1-crit {
 			};
 		};
 	};
+
+	wcss: smp2p-wcss {

'smp2p-wcss' < 'soc@0'

Quoted 27 lines
arch/arm64/boot/dts/qcom/ipq8074.dtsi +23 -0
+		compatible = "qcom,smp2p";
+		qcom,smem = <435>, <428>;
+
+		interrupt-parent = <&intc>;
+		interrupts = <GIC_SPI 322 IRQ_TYPE_EDGE_RISING>;
+
+		mboxes = <&apcs_glb 9>;
+
+		qcom,local-pid = <0>;
+		qcom,remote-pid = <1>;
+
+		wcss_smp2p_out: master-kernel {
+			qcom,entry-name = "master-kernel";
+			#qcom,smem-state-cells = <1>;
+		};
+
+		wcss_smp2p_in: slave-kernel {
+			qcom,entry-name = "slave-kernel";
+
+			interrupt-controller;
+			#interrupt-cells = <2>;
+		};
+	};
 };
Signature · 1 line
2.45.1
Signature · 2 lines
With best wishes
Dmitry