Skip to contentSkip to conversation

arm: kirkwood: Remove unnecessary watchdog GPIO for ZyXEL NSA325 board

PATCH In review Tony Dinh 2 participants 3 messages Dec 10, 2025 – Jun 10

lore
Share & tools
lore

Tony Dinh

author
#0 lore raw

PATCH 1/1 arm: kirkwood: Remove unnecessary watchdog GPIO for ZyXEL NSA325 board

Watchdog was already disabled in board/zyxel/nsa325/kwbimage.cfg.

---

 board/zyxel/nsa325/nsa325.c | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)
board/zyxel/nsa325/nsa325.c +3 -4
index 38340b33c8b..894c2ef293c 100644
@@ -1,6 +1,6 @@
 // SPDX-License-Identifier: GPL-2.0+
 /*
- * Copyright (C) 2014-2023 Tony Dinh <[email protected]>
+ * Copyright (C) 2014-2025 Tony Dinh <[email protected]>
  *
  * Based on
  * Copyright (C) 2014  Jason Plum <[email protected]>
@@ -51,11 +51,10 @@ DECLARE_GLOBAL_DATA_PTR;
 #define HDD1_GREEN_LED		BIT(9)
 #define HDD1_RED_LED		BIT(10)
 #define HDD2_POWER		BIT(15)
-#define WATCHDOG_SIGNAL		BIT(14)
 
 #define NSA325_OE_HIGH		(~(COPY_GREEN_LED | COPY_RED_LED | \
-				   HDD1_GREEN_LED | HDD1_RED_LED | HDD2_POWER | WATCHDOG_SIGNAL))
-#define NSA325_VAL_HIGH		(WATCHDOG_SIGNAL | HDD2_POWER)
+				   HDD1_GREEN_LED | HDD1_RED_LED | HDD2_POWER))
+#define NSA325_VAL_HIGH		(HDD2_POWER)
 
 #define BTN_POWER				46
 #define BTN_RESET				36
Signature · 4 lines
2.47.3

base-commit: b2195f0e62292fdf36be6d8bdfc9efc23ae30c5c
branch: master
Reviewed-by on v1 1/1
#1 lore raw
Quoted 3 lines · Tony Dinh

Watchdog was already disabled in board/zyxel/nsa325/kwbimage.cfg.

Thanks,
Stefan

Quoted 31 lines

---

  board/zyxel/nsa325/nsa325.c | 7 +++----
  1 file changed, 3 insertions(+), 4 deletions(-)
board/zyxel/nsa325/nsa325.c +3 -4
index 38340b33c8b..894c2ef293c 100644
@@ -1,6 +1,6 @@
  // SPDX-License-Identifier: GPL-2.0+
  /*
- * Copyright (C) 2014-2023 Tony Dinh <[email protected]>
+ * Copyright (C) 2014-2025 Tony Dinh <[email protected]>
   *
   * Based on
   * Copyright (C) 2014  Jason Plum <[email protected]>
@@ -51,11 +51,10 @@ DECLARE_GLOBAL_DATA_PTR;
  #define HDD1_GREEN_LED		BIT(9)
  #define HDD1_RED_LED		BIT(10)
  #define HDD2_POWER		BIT(15)
-#define WATCHDOG_SIGNAL		BIT(14)
 
  #define NSA325_OE_HIGH		(~(COPY_GREEN_LED | COPY_RED_LED | \
-				   HDD1_GREEN_LED | HDD1_RED_LED | HDD2_POWER | WATCHDOG_SIGNAL))
-#define NSA325_VAL_HIGH		(WATCHDOG_SIGNAL | HDD2_POWER)
+				   HDD1_GREEN_LED | HDD1_RED_LED | HDD2_POWER))
+#define NSA325_VAL_HIGH		(HDD2_POWER)
 
  #define BTN_POWER				46
  #define BTN_RESET				36