Skip to contentSkip to conversation

crypto: scompress - Use crypto_unregister_scomps in crypto_register_scomps

PATCH In review Thorsten Blum 2 participants 2 messages Dec 11, 2025 – Dec 19, 2025 Crypto API

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 crypto: scompress - Use crypto_unregister_scomps in crypto_register_scomps

Replace the for loop with a call to crypto_unregister_scomps(). Return 'ret' immediately and remove the goto statement to simplify the error handling code. No functional changes.

---
Changes in v2:
- Leave crypto_unregister_scomps() as is (Herbert)
- Link to v1: https://lore.kernel.org/lkml/[email protected]/

---
 crypto/scompress.c | 12 ++++--------
 1 file changed, 4 insertions(+), 8 deletions(-)
crypto/scompress.c +4 -8
index 1a7ed8ae65b0..8d70c5ec6f8b 100644
@@ -383,17 +383,13 @@ int crypto_register_scomps(struct scomp_alg *algs, int count)
 
 	for (i = 0; i < count; i++) {
 		ret = crypto_register_scomp(&algs[i]);
-		if (ret)
-			goto err;
+		if (ret) {
+			crypto_unregister_scomps(algs, i);
+			return ret;
+		}
 	}
 
 	return 0;
-
-err:
-	for (--i; i >= 0; --i)
-		crypto_unregister_scomp(&algs[i]);
-
-	return ret;
 }
 EXPORT_SYMBOL_GPL(crypto_register_scomps);
 
Signature · 2 lines
Thorsten Blum <[email protected]>
GPG: 1D60 735E 8AEF 3BE4 73B6  9D84 7336 78FD 8DFE EAD4
maintainer
#1 lore raw
Quoted 4 lines · Thorsten Blum

Replace the for loop with a call to crypto_unregister_scomps(). Return 'ret' immediately and remove the goto statement to simplify the error handling code. No functional changes.

Quoted 8 lines

---
Changes in v2:
- Leave crypto_unregister_scomps() as is (Herbert)
- Link to v1: https://lore.kernel.org/lkml/[email protected]/

---
 crypto/scompress.c | 12 ++++--------
 1 file changed, 4 insertions(+), 8 deletions(-)

Patch applied. Thanks.

Signature · 3 lines
Email: Herbert Xu <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt