Skip to contentSkip to conversation

rust: fix off-by-one line number in rustdoc tests

PATCH Applied Gary Guo 3 participants 3 messages Dec 11, 2025 – Jan 4

Subsystems (3)
Kselftest Rust KUnit
lore
Share & tools
lore

Gary Guo

author
#0 lore raw

PATCH 1/1 rust: fix off-by-one line number in rustdoc tests

From: Gary Guo <[email protected]>

When the #![allow] line was added, the doctest line number anchor isn't updated which causes the line number printed in kunit test to be off-by-one.

Fixes ab844cf32058 ("rust: allow `unreachable_pub` for doctests")
Signed-off-by Gary Guo <[email protected]>
---
 scripts/rustdoc_test_gen.rs | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
scripts/rustdoc_test_gen.rs +1 -1
index be05610496605..6fd9f5c84e2e4 100644
@@ -206,7 +206,7 @@ macro_rules! assert_eq {{
 
     /// The anchor where the test code body starts.
     #[allow(unused)]
-    static __DOCTEST_ANCHOR: i32 = ::core::line!() as i32 + {body_offset} + 1;
+    static __DOCTEST_ANCHOR: i32 = ::core::line!() as i32 + {body_offset} + 2;
     {{
         #![allow(unreachable_pub, clippy::disallowed_names)]
         {body}

base-commit: 559e608c46553c107dbba19dae0854af7b219400

Signature · 1 line
2.51.2
Reviewed-by on v1 1/1
#1 lore raw
Quoted 10 lines · Gary Guo

From: Gary Guo <[email protected]>

When the #![allow] line was added, the doctest line number anchor isn't updated which causes the line number printed in kunit test to be off-by-one.

Fixes ab844cf32058 ("rust: allow `unreachable_pub` for doctests")
Signed-off-by Gary Guo <[email protected]>

---

Nice catch!

Reviewed-by David Gow <[email protected]>

Cheers,
-- David

Quoted 21 lines
 scripts/rustdoc_test_gen.rs | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
scripts/rustdoc_test_gen.rs +1 -1
index be05610496605..6fd9f5c84e2e4 100644
@@ -206,7 +206,7 @@ macro_rules! assert_eq {{
 
     /// The anchor where the test code body starts.
     #[allow(unused)]
-    static __DOCTEST_ANCHOR: i32 = ::core::line!() as i32 + {body_offset} + 1;
+    static __DOCTEST_ANCHOR: i32 = ::core::line!() as i32 + {body_offset} + 2;
     {{
         #![allow(unreachable_pub, clippy::disallowed_names)]
         {body}

base-commit: 559e608c46553c107dbba19dae0854af7b219400 --
2.51.2

Applied
#2 lore raw
In reply to Gary Guo
Quoted 9 lines · Gary Guo

From: Gary Guo <[email protected]>

When the #![allow] line was added, the doctest line number anchor isn't updated which causes the line number printed in kunit test to be off-by-one.

Fixes ab844cf32058 ("rust: allow `unreachable_pub` for doctests")
Signed-off-by Gary Guo <[email protected]>

Applied to rust-fixes -- thanks everyone!

Cheers,
Miguel