Skip to contentSkip to conversation

ALSA: vxpocket: Fix resource leak in vxpocket_probe error path

PATCH In review Haotian Zhang 2 participants 2 messages Dec 15, 2025 Sound

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ALSA: vxpocket: Fix resource leak in vxpocket_probe error path

When vxpocket_config() fails, vxpocket_probe() returns the error code directly without freeing the sound card resources allocated by snd_card_new(), which leads to a memory leak.

Add proper error handling to free the sound card and clear the allocation bit when vxpocket_config() fails.

Fixes 15b99ac17295 ("[PATCH] pcmcia: add return value to _config() functions")
---
 sound/pcmcia/vx/vxpocket.c | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)
sound/pcmcia/vx/vxpocket.c +7 -1
index 2e09f2a513a6..9a5c9aa8eec4 100644
@@ -284,7 +284,13 @@ static int vxpocket_probe(struct pcmcia_device *p_dev)
 
 	vxp->p_dev = p_dev;
 
-	return vxpocket_config(p_dev);
+	err = vxpocket_config(p_dev);
+	if (err < 0) {
+		card_alloc &= ~(1 << i);
+		snd_card_free(card);
+		return err;
+	}
+	return 0;
 }
 
 static void vxpocket_detach(struct pcmcia_device *link)
Signature · 1 line
2.50.1.windows.1
#1 lore raw
Quoted 10 lines · Haotian Zhang

When vxpocket_config() fails, vxpocket_probe() returns the error code directly without freeing the sound card resources allocated by snd_card_new(), which leads to a memory leak.

Add proper error handling to free the sound card and clear the allocation bit when vxpocket_config() fails.

Fixes 15b99ac17295 ("[PATCH] pcmcia: add return value to _config() functions")

Applied now. Thanks.

I guess a similar bug is present in
sound/pcmcia/pdaudiocf/pdaudiocf.c, too.
Care to fix it as well? ;)

Takashi