nvmem/core: fixup minor typo
Subsystems (3)
PATCH 1/2 nvmem/core: fixup minor typo
From: Wilfred Mallawa <[email protected]>
Signed-off-by Wilfred Mallawa <[email protected]>
--- drivers/nvmem/core.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/nvmem/core.c +2 -2
@@ -1224,7 +1224,7 @@ static void devm_nvmem_device_release(struct device *dev, void *res) }/** -* devm_nvmem_device_put() - put alredy got nvmem device +* devm_nvmem_device_put() - put already got nvmem device * * @dev: Device that uses the nvmem device. * @nvmem: pointer to nvmem device allocated by devm_nvmem_cell_get(),
@@ -1242,7 +1242,7 @@ void devm_nvmem_device_put(struct device *dev, struct nvmem_device *nvmem)EXPORT_SYMBOL_GPL (devm_nvmem_device_put);/** -* nvmem_device_put() - put alredy got nvmem device +* nvmem_device_put() - put already got nvmem device * * @nvmem: pointer to nvmem device that needs to be released. */
Signature · 1 line
2.52.0
PATCH 2/2 nvme/host: fixup some typos
From: Wilfred Mallawa <[email protected]>
Signed-off-by Wilfred Mallawa <[email protected]>
--- drivers/nvme/host/fc.c | 2 +- drivers/nvme/host/ioctl.c | 4 ++-- drivers/nvme/host/pci.c | 6 +++--- drivers/nvme/host/rdma.c | 2 +- drivers/nvme/host/tcp.c | 6 +++--- 5 files changed, 10 insertions(+), 10 deletions(-)
drivers/nvme/host/fc.c +1 -1
@@ -2513,7 +2513,7 @@ __nvme_fc_abort_outstanding_ios(struct nvme_fc_ctrl *ctrl, bool start_queues)* writing the registers for shutdown and polling (call * nvme_disable_ctrl()). Given a bunch of i/o was potentially * just aborted and we will wait on those contexts, and given -* there was no indication of how live the controlelr is on the +* there was no indication of how live the controller is on the * link, don't send more io to create more contexts for the * shutdown. Let the controller fail via keepalive failure if * its still present.
drivers/nvme/host/ioctl.c +2 -2
@@ -271,7 +271,7 @@ static bool nvme_validate_passthru_nsid(struct nvme_ctrl *ctrl, {if (ns && nsid != ns->head->ns_id) {dev_err (ctrl->device, -"%s: nsid (%u) in cmd does not match nsid (%u)" +"%s: nsid (%u) in cmd does not match nsid (%u) " "of namespace\n" , current->comm, nsid, ns->head->ns_id);return false;
@@ -696,7 +696,7 @@ int nvme_ns_head_ioctl(struct block_device *bdev, blk_mode_t mode,/* * Handle ioctls that apply to the controller instead of the namespace -* seperately and drop the ns SRCU reference early. This avoids a +* separately and drop the ns SRCU reference early. This avoids a * deadlock when deleting namespaces using the passthrough interface. */ if (is_ctrl_ioctl (cmd))
drivers/nvme/host/pci.c +3 -3
@@ -367,7 +367,7 @@ static bool nvme_dbbuf_update_and_check_event(u16 value, __le32 *dbbuf_db,/* * Ensure that the doorbell is updated before reading the event * index from memory. The controller needs to provide similar -* ordering to ensure the envent index is updated before reading +* ordering to ensure the event index is updated before reading * the doorbell. */ mb ();
@@ -2741,7 +2741,7 @@ static void nvme_reset_work(struct work_struct *work) goto out;/* -* Freeze and update the number of I/O queues as thos might have +* Freeze and update the number of I/O queues as those might have * changed. If there are no I/O queues left after this reset, keep the * controller around but remove all namespaces. */
@@ -2910,7 +2910,7 @@ static unsigned long check_vendor_combination_bug(struct pci_dev *pdev)/* * Exclude some Kingston NV1 and A2000 devices from * NVME_QUIRK_SIMPLE_SUSPEND. Do a full suspend to save a -* lot fo energy with s2idle sleep on some TUXEDO platforms. +* lot of energy with s2idle sleep on some TUXEDO platforms. */ if (dmi_match(DMI_BOARD_NAME, "NS5X_NS7XAU") || dmi_match(DMI_BOARD_NAME, "NS5x_7xAU") ||
drivers/nvme/host/rdma.c +1 -1
@@ -877,7 +877,7 @@ static int nvme_rdma_configure_io_queues(struct nvme_rdma_ctrl *ctrl, bool new)/* * Only start IO queues for which we have allocated the tagset -* and limitted it to the available queues. On reconnects, the +* and limited it to the available queues. On reconnects, the * queue number might have changed. */ nr_queues =min (ctrl->tag_set.nr_hw_queues +1 , ctrl->ctrl.queue_count);
drivers/nvme/host/tcp.c +3 -3
@@ -26,7 +26,7 @@struct nvme_tcp_queue ; -/* Define the socket priority to use for connections were it is desirable +/* Define the socket priority to use for connections where it is desirable * that the NIC consider performing optimized packet processing or filtering. * A non-zero value being sufficient to indicate general consideration of any * possible optimization. Making it a module param allows for alternative
@@ -808,7 +808,7 @@ static int nvme_tcp_recv_data(struct nvme_tcp_queue *queue, struct sk_buff *skb, req->curr_bio = req->curr_bio->bi_next;/* -* If we don`t have any bios it means that controller +* If we don't have any bios it means that controller * sent more data than we requested, hence error */ if (!req->curr_bio) {
@@ -2017,7 +2017,7 @@ static int nvme_tcp_configure_io_queues(struct nvme_ctrl *ctrl, bool new)/* * Only start IO queues for which we have allocated the tagset -* and limitted it to the available queues. On reconnects, the +* and limited it to the available queues. On reconnects, the * queue number might have changed. */ nr_queues =min (ctrl->tagset->nr_hw_queues +1 , ctrl->queue_count);
Signature · 1 line
2.52.0
Quoted 3 lines · Wilfred Mallawa
From: Wilfred Mallawa <[email protected]>
Signed-off-by Wilfred Mallawa <[email protected]>
This is not nvme :) So this should be a separate patch.
Empty commit messages is also not great. Even if trivial, write something.
Nevertheless,
Reviewed-by Damien Le Moal <[email protected]>
Signature · 2 lines
Damien Le Moal Western Digital Research
Re: [PATCH 2/2] nvme/host: fixup some typos
In reply to Wilfred MallawaQuoted 3 lines · Wilfred Mallawa
From: Wilfred Mallawa <[email protected]>
Signed-off-by Wilfred Mallawa <[email protected]>
Looks good, but write something as the commit message.
One nit below.
Reviewed-by Damien Le Moal <[email protected]>
drivers/nvme/host/ioctl.c static bool nvme_validate_passthru_nsid(struct nvme_ctrl *ctrl, · line 275
Quoted 7 lines
drivers/nvme/host/ioctl.c +1
-1@@ -271,7 +271,7 @@ static bool nvme_validate_passthru_nsid(struct nvme_ctrl *ctrl, {if (ns && nsid != ns->head->ns_id) { dev_err(ctrl->device, - "%s: nsid (%u) in cmd does not match nsid (%u)" + "%s: nsid (%u) in cmd does not match nsid (%u) " "of namespace\n",
I know that Christoph does not like long lines, but it may be better to unwrap this message to make it easier to grep the code.
Signature · 2 lines
Damien Le Moal Western Digital Research