mm/damon/stat: deduplicate intervals_goal setup in damon_stat_build_ctx()
Subsystems (2)
SeongJae Park
maintainerPATCH RESEND 1/1 mm/damon/stat: deduplicate intervals_goal setup in damon_stat_build_ctx()
From: JaeJoon Jung <[email protected]>
The damon_stat_build_ctx() function sets the values of intervals_goal structure members. These values are applied to damon_ctx in damon_set_attrs(). However, It is resetting the values that were already applied previously to the same values. I suggest removing this code as it constitutes duplicate execution.
Signed-off-by JaeJoon Jung <[email protected]>
Reviewed-by Enze Li <[email protected]>
Reviewed-by SeongJae Park <[email protected]>
Signed-off-by SeongJae Park <[email protected]>
--- mm/damon/stat.c | 8 -------- 1 file changed, 8 deletions(-)
mm/damon/stat.c +0 -8
@@ -173,14 +173,6 @@ static struct damon_ctx *damon_stat_build_ctx(void)if (damon_set_attrs (ctx, &attrs)) goto free_out; -/* -* auto-tune sampling and aggregation interval aiming 4% DAMON-observed -* accesses ratio, keeping sampling interval in [5ms, 10s] range. -*/ - ctx->attrs.intervals_goal = (struct damon_intervals_goal ) { - .access_bp =400 , .aggrs =3 , - .min_sample_us =5000 , .max_sample_us =10000000 , - };if (damon_select_ops (ctx,DAMON_OPS_PADDR )) goto free_out;
base-commit: 1791b1de223b928dd1903984344b64b8148ca671
Signature · 1 line
2.47.3