ALSA: hda/realtek: Add Asus quirk for TAS amplifiers
PATCH 1/1 ALSA: hda/realtek: Add Asus quirk for TAS amplifiers
By default, these devices use the quirk ALC294_FIXUP_ASUS_SPK. Not using it causes the headphone jack to stop working. Therefore, introduce a new quirk ALC287_FIXUP_TXNW2781_I2C_ASUS that binds to the TAS amplifier while using that quirk.
---
I was pretty busy the last few weeks. Now that the initial quirk is merged, we should try to get this to fixes as well to prevent this small regression.
It turns out that when not using a quirk, the fallback is ALC294_FIXUP_ASUS_SPK and with the quirk optimized for lenovo devices this causes the audio jack to not work. Other than that, the previous quirk worked fine.
This was tested on both devices.
@Matt you might want to add a tested-by, since you were the one to test on Xbox Ally X.
Matt also figured out that the firmware issue on XAX is not related to the quirks, but to incorrect configuration loading by TAS for dual amplifiers, which would be a separate patch.
Thanks
--- sound/hda/codecs/realtek/alc269.c | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-)
sound/hda/codecs/realtek/alc269.c +9 -2
@@ -3753,6 +3753,7 @@ enum {ALC295_FIXUP_DELL_TAS2781_I2C ,ALC245_FIXUP_TAS2781_SPI_2 ,ALC287_FIXUP_TXNW2781_I2C , +ALC287_FIXUP_TXNW2781_I2C_ASUS ,ALC287_FIXUP_YOGA7_14ARB7_I2C ,ALC245_FIXUP_HP_MUTE_LED_COEFBIT , ALC245_FIXUP_HP_MUTE_LED_V1_COEFBIT,
@@ -6053,6 +6054,12 @@ static const struct hda_fixup alc269_fixups[] = { .chained = true, .chain_id = ALC285_FIXUP_THINKPAD_HEADSET_JACK, }, + [ALC287_FIXUP_TXNW2781_I2C_ASUS] = { + .type = HDA_FIXUP_FUNC, + .v.func = tas2781_fixup_txnw_i2c, + .chained = true, + .chain_id = ALC294_FIXUP_ASUS_SPK, + }, [ALC287_FIXUP_YOGA7_14ARB7_I2C] = { .type = HDA_FIXUP_FUNC, .v.func = yoga7_14arb7_fixup_i2c,
@@ -6827,8 +6834,8 @@ static const struct hda_quirk alc269_fixup_tbl[] = {SND_PCI_QUIRK (0x1043 ,0x12f0 ,"ASUS X541UV" ,ALC256_FIXUP_ASUS_MIC_NO_PRESENCE ),SND_PCI_QUIRK (0x1043 ,0x1313 ,"Asus K42JZ" ,ALC269VB_FIXUP_ASUS_MIC_NO_PRESENCE ),SND_PCI_QUIRK (0x1043 ,0x1314 ,"ASUS GA605K" ,ALC285_FIXUP_ASUS_GA605K_HEADSET_MIC ), -SND_PCI_QUIRK (0x1043 ,0x1384 ,"ASUS RC73XA" ,ALC287_FIXUP_TXNW2781_I2C ), -SND_PCI_QUIRK (0x1043 ,0x1394 ,"ASUS RC73YA" ,ALC287_FIXUP_TXNW2781_I2C ), +SND_PCI_QUIRK (0x1043 ,0x1384 ,"ASUS RC73XA" ,ALC287_FIXUP_TXNW2781_I2C_ASUS ), +SND_PCI_QUIRK (0x1043 ,0x1394 ,"ASUS RC73YA" ,ALC287_FIXUP_TXNW2781_I2C_ASUS ),SND_PCI_QUIRK (0x1043 ,0x13b0 ,"ASUS Z550SA" ,ALC256_FIXUP_ASUS_MIC_NO_PRESENCE ),SND_PCI_QUIRK (0x1043 ,0x1427 ,"Asus Zenbook UX31E" ,ALC269VB_FIXUP_ASUS_ZENBOOK ), SND_PCI_QUIRK(0x1043, 0x1433, "ASUS GX650PY/PZ/PV/PU/PYV/PZV/PIV/PVV", ALC285_FIXUP_ASUS_I2C_HEADSET_MIC),
base-commit: 8f0b4cce4481fb22653697cced8d0d04027cb1e8
Signature · 1 line
2.52.0
Quoted 9 lines · Antheas Kapenekakis
By default, these devices use the quirk
ALC294_FIXUP_ASUS_SPK. Not using it causes the headphone jack to stop working. Therefore, introduce a new quirkALC287_FIXUP_TXNW2781_I2C_ASUSthat binds to the TAS amplifier while using that quirk.Fixes 18a4895370a7 ("ALSA: hda/realtek: Add match for ASUS Xbox Ally projects")Signed-off-by Antheas Kapenekakis <[email protected]>
Applied now. Thanks.
Takashi