ALSA: hda/realtek: fix micmute LED reversed on HP Abe and Bantie
PATCH 1/1 ALSA: hda/realtek: fix micmute LED reversed on HP Abe and Bantie
Quirk ALC236_FIXUP_HP_MUTE_LED_MICMUTE_GPIO make mute/micmute LEDs on HP Abe and Bantie functional. But the micmute LED's function is reversed, LED will be on when Mic enabled and off when Mic disabled. Create a new function to fix the micmute LED reversed issue.
Signed-off-by Dirk Su <[email protected]>
--- sound/hda/codecs/realtek/alc269.c | 16 +++++++++++++--- 1 file changed, 13 insertions(+), 3 deletions(-)
sound/hda/codecs/realtek/alc269.c +13 -3
@@ -1656,6 +1656,18 @@ static void alc236_fixup_hp_mute_led_micmute_vref(struct hda_codec *codec,alc236_fixup_hp_micmute_led_vref (codec, fix, action); } +static void alc236_fixup_hp_mute_led_micmute_gpio (struct hda_codec *codec, +const struct hda_fixup *fix,int action) +{ +struct alc_spec *spec = codec->spec; + +if (action ==HDA_FIXUP_ACT_PRE_PROBE ) + spec->micmute_led_polarity =1 ; + +alc236_fixup_hp_mute_led_coefbit2 (codec, fix, action); +alc_fixup_hp_gpio_led (codec, action,0x00 ,0x01 ); +} +static inline void alc298_samsung_write_coef_pack (struct hda_codec *codec,const unsigned short coefs[2 ]) {
@@ -5326,9 +5338,7 @@ static const struct hda_fixup alc269_fixups[] = { }, [ALC236_FIXUP_HP_MUTE_LED_MICMUTE_GPIO] = { .type = HDA_FIXUP_FUNC, - .v.func = alc236_fixup_hp_mute_led_coefbit2, - .chained = true, - .chain_id = ALC236_FIXUP_HP_GPIO_LED, + .v.func = alc236_fixup_hp_mute_led_micmute_gpio, }, [ALC236_FIXUP_LENOVO_INV_DMIC] = { .type = HDA_FIXUP_FUNC,
Signature · 1 line
2.43.0
Quoted 8 lines · Dirk Su
Quirk
ALC236_FIXUP_HP_MUTE_LED_MICMUTE_GPIOmake mute/micmute LEDs on HP Abe and Bantie functional. But the micmute LED's function is reversed, LED will be on when Mic enabled and off when Mic disabled. Create a new function to fix the micmute LED reversed issue.Signed-off-by Dirk Su <[email protected]>
Applied now with Fixes tag. Thanks.
Takashi