Skip to contentSkip to conversation

btrfs: Fix -Wmaybe-uninitialized warning

PATCH In review Qiang Ma 2 participants 3 messages Dec 18, 2025 – Dec 19, 2025 Btrfs file system

lore
Share & tools
lore

Qiang Ma

author
#0 lore raw

PATCH 1/1 btrfs: Fix -Wmaybe-uninitialized warning

Fix a -Wmaybe-uninitialized warning by initializing the variable to NULL.

$ make CFLAGS_tree-log.o=-Wmaybe-uninitialized

In file included from fs/btrfs/ctree.h:21,

                 from fs/btrfs/tree-log.c:12:
fs/btrfs/accessors.h: In function 'replay_one_buffer':
fs/btrfs/accessors.h:66:16: warning: 'inode_item' may be used uninitialized [-Wmaybe-uninitialized]
   66 |         return btrfs_get_##bits(eb, s, offsetof(type, member));         \
      |                ^~~~~~~~~~

fs/btrfs/tree-log.c:2803:42: note: 'inode_item' declared here
2803 | struct btrfs_inode_item *inode_item;
| ^~~~~~~~~~

Warning was found when compiling using loongarch64-gcc 12.3.1.

---
 fs/btrfs/tree-log.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
fs/btrfs/tree-log.c +1 -1
index 31edc93a383e..0d6faaaa70f1 100644
@@ -2798,7 +2798,7 @@ static int replay_one_buffer(struct extent_buffer *eb,
 
 	nritems = btrfs_header_nritems(eb);
 	for (wc->log_slot = 0; wc->log_slot < nritems; wc->log_slot++) {
-		struct btrfs_inode_item *inode_item;
+		struct btrfs_inode_item *inode_item = NULL;
 
 		btrfs_item_key_to_cpu(eb, &wc->log_key, wc->log_slot);
 
Signature · 1 line
2.20.1
#1 lore raw
Quoted 11 lines · Qiang Ma

Fix a -Wmaybe-uninitialized warning by initializing the variable to NULL.

$ make CFLAGS_tree-log.o=-Wmaybe-uninitialized

In file included from fs/btrfs/ctree.h:21,

                 from fs/btrfs/tree-log.c:12:
fs/btrfs/accessors.h: In function 'replay_one_buffer':
fs/btrfs/accessors.h:66:16: warning: 'inode_item' may be used uninitialized [-Wmaybe-uninitialized]
   66 |         return btrfs_get_##bits(eb, s, offsetof(type, member));         \
      |                ^~~~~~~~~~
Quoted 5 lines

fs/btrfs/tree-log.c:2803:42: note: 'inode_item' declared here
2803 | struct btrfs_inode_item *inode_item;
| ^~~~~~~~~~

Warning was found when compiling using loongarch64-gcc 12.3.1.

We have the -Wmaybe-uninitialized warning enabled per fs/btrfs/ directory, there are no other known reports fixing the uninitialized inode_item so this might be specific to loongarch gcc 12.x. I'll add the patch to for-next as we still want to get all the warnings fixed, thanks.

author
#2 lore raw
Quoted 16 lines · David Sterba
Quoted 15 lines · Qiang Ma

Fix a -Wmaybe-uninitialized warning by initializing the variable to NULL.

$ make CFLAGS_tree-log.o=-Wmaybe-uninitialized

In file included from fs/btrfs/ctree.h:21,

                  from fs/btrfs/tree-log.c:12:
fs/btrfs/accessors.h: In function 'replay_one_buffer':
fs/btrfs/accessors.h:66:16: warning: 'inode_item' may be used uninitialized [-Wmaybe-uninitialized]
    66 |         return btrfs_get_##bits(eb, s, offsetof(type, member));         \
       |                ^~~~~~~~~~

fs/btrfs/tree-log.c:2803:42: note: 'inode_item' declared here
2803 | struct btrfs_inode_item *inode_item;
| ^~~~~~~~~~

Quoted 4 lines
Quoted 1 line

Warning was found when compiling using loongarch64-gcc 12.3.1.

We have the -Wmaybe-uninitialized warning enabled per fs/btrfs/ directory, there are no other known reports fixing the uninitialized inode_item so this might be specific to loongarch gcc 12.x. I'll add the

Yes, x86 and arm64 did not report this warning issue.

Quoted 2 lines

patch to for-next as we still want to get all the warnings fixed, thanks.