Skip to contentSkip to conversation

x86/mtrr: Replace simple_strtoul with kstrtoul in parse_mtrr_spare_reg

PATCH Superseded Thorsten Blum 1 participant 1 message Dec 18, 2025 x86

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 x86/mtrr: Replace simple_strtoul with kstrtoul in parse_mtrr_spare_reg

Replace simple_strtoul() with the recommended kstrtoul() for parsing the 'mtrr_spare_reg_nr' boot parameter.

Check the return value of kstrtoul() and reject invalid values. This adds error handling while preserving behavior for existing values, and removes use of the deprecated simple_strtoul() helper. The current code silently sets 'nr_mtrr_spare_reg = 0' if parsing fails, instead of leaving the default value (CONFIG_MTRR_SANITIZER_SPARE_REG_NR_DEFAULT) unchanged.

---
 arch/x86/kernel/cpu/mtrr/cleanup.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
arch/x86/kernel/cpu/mtrr/cleanup.c +1 -3
index 763534d77f59..1de5134b1916 100644
@@ -437,9 +437,7 @@ static unsigned long nr_mtrr_spare_reg __initdata =
 
 static int __init parse_mtrr_spare_reg(char *arg)
 {
-	if (arg)
-		nr_mtrr_spare_reg = simple_strtoul(arg, NULL, 0);
-	return 0;
+	return kstrtoul(arg, 0, &nr_mtrr_spare_reg);
 }
 early_param("mtrr_spare_reg_nr", parse_mtrr_spare_reg);
 
Signature · 2 lines
Thorsten Blum <[email protected]>
GPG: 1D60 735E 8AEF 3BE4 73B6  9D84 7336 78FD 8DFE EAD4